982e4fb448
Passing around a bare pointer to the map of configured features in order to propagate to consumers changes to the configuration across reloads is dangerous. Map operations are not atomic, so concurrently reading from the map while it is being updated is a data race as there is no synchronization. Use a getter function to retrieve the current features map so the features can be retrieved race-free. Remove the unused features argument from the build router. Signed-off-by: Cory Snider <csnider@mirantis.com>
60 lines
1.6 KiB
Go
60 lines
1.6 KiB
Go
package build // import "github.com/docker/docker/api/server/router/build"
|
|
|
|
import (
|
|
"runtime"
|
|
|
|
"github.com/docker/docker/api/server/router"
|
|
"github.com/docker/docker/api/types"
|
|
)
|
|
|
|
// buildRouter is a router to talk with the build controller
|
|
type buildRouter struct {
|
|
backend Backend
|
|
daemon experimentalProvider
|
|
routes []router.Route
|
|
}
|
|
|
|
// NewRouter initializes a new build router
|
|
func NewRouter(b Backend, d experimentalProvider) router.Router {
|
|
r := &buildRouter{
|
|
backend: b,
|
|
daemon: d,
|
|
}
|
|
r.initRoutes()
|
|
return r
|
|
}
|
|
|
|
// Routes returns the available routers to the build controller
|
|
func (r *buildRouter) Routes() []router.Route {
|
|
return r.routes
|
|
}
|
|
|
|
func (r *buildRouter) initRoutes() {
|
|
r.routes = []router.Route{
|
|
router.NewPostRoute("/build", r.postBuild),
|
|
router.NewPostRoute("/build/prune", r.postPrune),
|
|
router.NewPostRoute("/build/cancel", r.postCancel),
|
|
}
|
|
}
|
|
|
|
// BuilderVersion derives the default docker builder version from the config.
|
|
//
|
|
// The default on Linux is version "2" (BuildKit), but the daemon can be
|
|
// configured to recommend version "1" (classic Builder). Windows does not
|
|
// yet support BuildKit for native Windows images, and uses "1" (classic builder)
|
|
// as a default.
|
|
//
|
|
// This value is only a recommendation as advertised by the daemon, and it is
|
|
// up to the client to choose which builder to use.
|
|
func BuilderVersion(features map[string]bool) types.BuilderVersion {
|
|
// TODO(thaJeztah) move the default to daemon/config
|
|
if runtime.GOOS == "windows" {
|
|
return types.BuilderV1
|
|
}
|
|
|
|
bv := types.BuilderBuildKit
|
|
if v, ok := features["buildkit"]; ok && !v {
|
|
bv = types.BuilderV1
|
|
}
|
|
return bv
|
|
}
|