docker_cli_build_test.go 98 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198219922002201220222032204220522062207220822092210221122122213221422152216221722182219222022212222222322242225222622272228222922302231223222332234223522362237223822392240224122422243224422452246224722482249225022512252225322542255225622572258225922602261226222632264226522662267226822692270227122722273227422752276227722782279228022812282228322842285228622872288228922902291229222932294229522962297229822992300230123022303230423052306230723082309231023112312231323142315231623172318231923202321232223232324232523262327232823292330233123322333233423352336233723382339234023412342234323442345234623472348234923502351235223532354235523562357235823592360236123622363236423652366236723682369237023712372237323742375237623772378237923802381238223832384238523862387238823892390239123922393239423952396239723982399240024012402240324042405240624072408240924102411241224132414241524162417241824192420242124222423242424252426242724282429243024312432243324342435243624372438243924402441244224432444244524462447244824492450245124522453245424552456245724582459246024612462246324642465246624672468246924702471247224732474247524762477247824792480248124822483248424852486248724882489249024912492249324942495249624972498249925002501250225032504250525062507250825092510251125122513251425152516251725182519252025212522252325242525252625272528252925302531253225332534253525362537253825392540254125422543254425452546254725482549255025512552255325542555255625572558255925602561256225632564256525662567256825692570257125722573257425752576257725782579258025812582258325842585258625872588258925902591259225932594259525962597259825992600260126022603260426052606260726082609261026112612261326142615261626172618261926202621262226232624262526262627262826292630263126322633263426352636263726382639264026412642264326442645264626472648264926502651265226532654265526562657265826592660266126622663266426652666266726682669267026712672267326742675267626772678267926802681268226832684268526862687268826892690269126922693269426952696269726982699270027012702270327042705270627072708270927102711271227132714271527162717271827192720272127222723272427252726272727282729273027312732273327342735273627372738273927402741274227432744274527462747274827492750275127522753275427552756275727582759276027612762276327642765276627672768276927702771277227732774277527762777277827792780278127822783278427852786278727882789279027912792279327942795279627972798279928002801280228032804280528062807280828092810281128122813281428152816281728182819282028212822282328242825282628272828282928302831283228332834283528362837283828392840284128422843284428452846284728482849285028512852285328542855285628572858285928602861286228632864286528662867286828692870287128722873287428752876287728782879288028812882288328842885288628872888288928902891289228932894289528962897289828992900290129022903290429052906290729082909291029112912291329142915291629172918291929202921292229232924292529262927292829292930293129322933293429352936293729382939294029412942294329442945294629472948294929502951295229532954295529562957295829592960296129622963296429652966296729682969297029712972297329742975297629772978297929802981298229832984298529862987298829892990299129922993299429952996299729982999300030013002300330043005300630073008300930103011301230133014301530163017301830193020302130223023302430253026302730283029303030313032303330343035303630373038303930403041304230433044304530463047304830493050305130523053305430553056305730583059306030613062306330643065306630673068306930703071307230733074307530763077307830793080308130823083308430853086308730883089309030913092309330943095309630973098309931003101310231033104310531063107310831093110311131123113311431153116311731183119312031213122312331243125312631273128312931303131313231333134313531363137313831393140314131423143314431453146314731483149315031513152315331543155315631573158315931603161316231633164316531663167316831693170317131723173317431753176317731783179318031813182318331843185318631873188318931903191319231933194319531963197319831993200320132023203320432053206320732083209321032113212321332143215321632173218321932203221322232233224322532263227322832293230323132323233323432353236323732383239324032413242324332443245324632473248324932503251325232533254325532563257325832593260326132623263326432653266326732683269327032713272327332743275327632773278327932803281328232833284328532863287328832893290329132923293329432953296329732983299330033013302330333043305330633073308330933103311331233133314331533163317331833193320332133223323332433253326332733283329333033313332333333343335333633373338333933403341334233433344334533463347334833493350335133523353335433553356335733583359336033613362336333643365336633673368336933703371337233733374337533763377337833793380338133823383338433853386338733883389339033913392339333943395339633973398339934003401340234033404340534063407340834093410341134123413341434153416341734183419342034213422342334243425342634273428342934303431343234333434343534363437343834393440344134423443344434453446344734483449345034513452345334543455345634573458345934603461346234633464346534663467346834693470347134723473347434753476347734783479348034813482348334843485348634873488348934903491349234933494349534963497349834993500350135023503350435053506350735083509351035113512351335143515351635173518351935203521352235233524352535263527352835293530353135323533353435353536353735383539354035413542354335443545354635473548354935503551355235533554355535563557355835593560356135623563356435653566356735683569357035713572357335743575357635773578357935803581358235833584358535863587358835893590359135923593359435953596359735983599360036013602360336043605360636073608360936103611361236133614361536163617361836193620362136223623362436253626362736283629363036313632363336343635363636373638363936403641364236433644364536463647364836493650365136523653365436553656365736583659366036613662366336643665366636673668366936703671367236733674367536763677367836793680368136823683368436853686368736883689369036913692369336943695369636973698369937003701370237033704370537063707370837093710371137123713371437153716371737183719372037213722372337243725372637273728372937303731373237333734373537363737373837393740374137423743374437453746374737483749375037513752375337543755375637573758375937603761376237633764376537663767376837693770377137723773377437753776377737783779378037813782378337843785378637873788378937903791379237933794379537963797379837993800380138023803380438053806380738083809381038113812381338143815381638173818381938203821382238233824382538263827382838293830383138323833383438353836383738383839384038413842384338443845384638473848384938503851385238533854385538563857385838593860386138623863386438653866386738683869387038713872387338743875387638773878387938803881388238833884388538863887388838893890389138923893389438953896389738983899390039013902390339043905390639073908390939103911391239133914391539163917391839193920392139223923392439253926392739283929393039313932393339343935393639373938393939403941394239433944394539463947394839493950
  1. package main
  2. import (
  3. "archive/tar"
  4. "encoding/json"
  5. "fmt"
  6. "io/ioutil"
  7. "os"
  8. "os/exec"
  9. "path"
  10. "path/filepath"
  11. "reflect"
  12. "regexp"
  13. "strings"
  14. "syscall"
  15. "testing"
  16. "time"
  17. "github.com/docker/docker/pkg/archive"
  18. )
  19. func TestBuildShCmdJSONEntrypoint(t *testing.T) {
  20. name := "testbuildshcmdjsonentrypoint"
  21. defer deleteImages(name)
  22. _, err := buildImage(
  23. name,
  24. `
  25. FROM busybox
  26. ENTRYPOINT ["/bin/echo"]
  27. CMD echo test
  28. `,
  29. true)
  30. if err != nil {
  31. t.Fatal(err)
  32. }
  33. out, _, err := runCommandWithOutput(
  34. exec.Command(
  35. dockerBinary,
  36. "run",
  37. "--rm",
  38. name))
  39. if err != nil {
  40. t.Fatal(err)
  41. }
  42. if strings.TrimSpace(out) != "/bin/sh -c echo test" {
  43. t.Fatal("CMD did not contain /bin/sh -c")
  44. }
  45. logDone("build - CMD should always contain /bin/sh -c when specified without JSON")
  46. }
  47. func TestBuildEnvironmentReplacementUser(t *testing.T) {
  48. name := "testbuildenvironmentreplacement"
  49. defer deleteImages(name)
  50. _, err := buildImage(name, `
  51. FROM scratch
  52. ENV user foo
  53. USER ${user}
  54. `, true)
  55. if err != nil {
  56. t.Fatal(err)
  57. }
  58. res, err := inspectFieldJSON(name, "Config.User")
  59. if err != nil {
  60. t.Fatal(err)
  61. }
  62. if res != `"foo"` {
  63. t.Fatal("User foo from environment not in Config.User on image")
  64. }
  65. logDone("build - user environment replacement")
  66. }
  67. func TestBuildEnvironmentReplacementVolume(t *testing.T) {
  68. name := "testbuildenvironmentreplacement"
  69. defer deleteImages(name)
  70. _, err := buildImage(name, `
  71. FROM scratch
  72. ENV volume /quux
  73. VOLUME ${volume}
  74. `, true)
  75. if err != nil {
  76. t.Fatal(err)
  77. }
  78. res, err := inspectFieldJSON(name, "Config.Volumes")
  79. if err != nil {
  80. t.Fatal(err)
  81. }
  82. var volumes map[string]interface{}
  83. if err := json.Unmarshal([]byte(res), &volumes); err != nil {
  84. t.Fatal(err)
  85. }
  86. if _, ok := volumes["/quux"]; !ok {
  87. t.Fatal("Volume /quux from environment not in Config.Volumes on image")
  88. }
  89. logDone("build - volume environment replacement")
  90. }
  91. func TestBuildEnvironmentReplacementExpose(t *testing.T) {
  92. name := "testbuildenvironmentreplacement"
  93. defer deleteImages(name)
  94. _, err := buildImage(name, `
  95. FROM scratch
  96. ENV port 80
  97. EXPOSE ${port}
  98. `, true)
  99. if err != nil {
  100. t.Fatal(err)
  101. }
  102. res, err := inspectFieldJSON(name, "Config.ExposedPorts")
  103. if err != nil {
  104. t.Fatal(err)
  105. }
  106. var exposedPorts map[string]interface{}
  107. if err := json.Unmarshal([]byte(res), &exposedPorts); err != nil {
  108. t.Fatal(err)
  109. }
  110. if _, ok := exposedPorts["80/tcp"]; !ok {
  111. t.Fatal("Exposed port 80 from environment not in Config.ExposedPorts on image")
  112. }
  113. logDone("build - expose environment replacement")
  114. }
  115. func TestBuildEnvironmentReplacementWorkdir(t *testing.T) {
  116. name := "testbuildenvironmentreplacement"
  117. defer deleteImages(name)
  118. _, err := buildImage(name, `
  119. FROM busybox
  120. ENV MYWORKDIR /work
  121. RUN mkdir ${MYWORKDIR}
  122. WORKDIR ${MYWORKDIR}
  123. `, true)
  124. if err != nil {
  125. t.Fatal(err)
  126. }
  127. logDone("build - workdir environment replacement")
  128. }
  129. func TestBuildEnvironmentReplacementAddCopy(t *testing.T) {
  130. name := "testbuildenvironmentreplacement"
  131. defer deleteImages(name)
  132. ctx, err := fakeContext(`
  133. FROM scratch
  134. ENV baz foo
  135. ENV quux bar
  136. ENV dot .
  137. ADD ${baz} ${dot}
  138. COPY ${quux} ${dot}
  139. `,
  140. map[string]string{
  141. "foo": "test1",
  142. "bar": "test2",
  143. })
  144. if err != nil {
  145. t.Fatal(err)
  146. }
  147. defer ctx.Close()
  148. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  149. t.Fatal(err)
  150. }
  151. logDone("build - add/copy environment replacement")
  152. }
  153. func TestBuildEnvironmentReplacementEnv(t *testing.T) {
  154. name := "testbuildenvironmentreplacement"
  155. defer deleteImages(name)
  156. _, err := buildImage(name,
  157. `
  158. FROM scratch
  159. ENV foo foo
  160. ENV bar ${foo}
  161. `, true)
  162. if err != nil {
  163. t.Fatal(err)
  164. }
  165. res, err := inspectFieldJSON(name, "Config.Env")
  166. if err != nil {
  167. t.Fatal(err)
  168. }
  169. envResult := []string{}
  170. if err = unmarshalJSON([]byte(res), &envResult); err != nil {
  171. t.Fatal(err)
  172. }
  173. found := false
  174. for _, env := range envResult {
  175. parts := strings.SplitN(env, "=", 2)
  176. if parts[0] == "bar" {
  177. found = true
  178. if parts[1] != "foo" {
  179. t.Fatalf("Could not find replaced var for env `bar`: got %q instead of `foo`", parts[1])
  180. }
  181. }
  182. }
  183. if !found {
  184. t.Fatal("Never found the `bar` env variable")
  185. }
  186. logDone("build - env environment replacement")
  187. }
  188. func TestBuildHandleEscapes(t *testing.T) {
  189. name := "testbuildhandleescapes"
  190. defer deleteImages(name)
  191. _, err := buildImage(name,
  192. `
  193. FROM scratch
  194. ENV FOO bar
  195. VOLUME ${FOO}
  196. `, true)
  197. if err != nil {
  198. t.Fatal(err)
  199. }
  200. var result map[string]map[string]struct{}
  201. res, err := inspectFieldJSON(name, "Config.Volumes")
  202. if err != nil {
  203. t.Fatal(err)
  204. }
  205. if err = unmarshalJSON([]byte(res), &result); err != nil {
  206. t.Fatal(err)
  207. }
  208. if _, ok := result["bar"]; !ok {
  209. t.Fatal("Could not find volume bar set from env foo in volumes table")
  210. }
  211. deleteImages(name)
  212. _, err = buildImage(name,
  213. `
  214. FROM scratch
  215. ENV FOO bar
  216. VOLUME \${FOO}
  217. `, true)
  218. if err != nil {
  219. t.Fatal(err)
  220. }
  221. res, err = inspectFieldJSON(name, "Config.Volumes")
  222. if err != nil {
  223. t.Fatal(err)
  224. }
  225. if err = unmarshalJSON([]byte(res), &result); err != nil {
  226. t.Fatal(err)
  227. }
  228. if _, ok := result["${FOO}"]; !ok {
  229. t.Fatal("Could not find volume ${FOO} set from env foo in volumes table")
  230. }
  231. deleteImages(name)
  232. // this test in particular provides *7* backslashes and expects 6 to come back.
  233. // Like above, the first escape is swallowed and the rest are treated as
  234. // literals, this one is just less obvious because of all the character noise.
  235. _, err = buildImage(name,
  236. `
  237. FROM scratch
  238. ENV FOO bar
  239. VOLUME \\\\\\\${FOO}
  240. `, true)
  241. if err != nil {
  242. t.Fatal(err)
  243. }
  244. res, err = inspectFieldJSON(name, "Config.Volumes")
  245. if err != nil {
  246. t.Fatal(err)
  247. }
  248. if err = unmarshalJSON([]byte(res), &result); err != nil {
  249. t.Fatal(err)
  250. }
  251. if _, ok := result[`\\\\\\${FOO}`]; !ok {
  252. t.Fatal(`Could not find volume \\\\\\${FOO} set from env foo in volumes table`)
  253. }
  254. logDone("build - handle escapes")
  255. }
  256. func TestBuildOnBuildLowercase(t *testing.T) {
  257. name := "testbuildonbuildlowercase"
  258. name2 := "testbuildonbuildlowercase2"
  259. defer deleteImages(name, name2)
  260. _, err := buildImage(name,
  261. `
  262. FROM busybox
  263. onbuild run echo quux
  264. `, true)
  265. if err != nil {
  266. t.Fatal(err)
  267. }
  268. _, out, err := buildImageWithOut(name2, fmt.Sprintf(`
  269. FROM %s
  270. `, name), true)
  271. if err != nil {
  272. t.Fatal(err)
  273. }
  274. if !strings.Contains(out, "quux") {
  275. t.Fatalf("Did not receive the expected echo text, got %s", out)
  276. }
  277. if strings.Contains(out, "ONBUILD ONBUILD") {
  278. t.Fatalf("Got an ONBUILD ONBUILD error with no error: got %s", out)
  279. }
  280. logDone("build - handle case-insensitive onbuild statement")
  281. }
  282. func TestBuildEnvEscapes(t *testing.T) {
  283. name := "testbuildenvescapes"
  284. defer deleteImages(name)
  285. defer deleteAllContainers()
  286. _, err := buildImage(name,
  287. `
  288. FROM busybox
  289. ENV TEST foo
  290. CMD echo \$
  291. `,
  292. true)
  293. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "-t", name))
  294. if err != nil {
  295. t.Fatal(err)
  296. }
  297. if strings.TrimSpace(out) != "$" {
  298. t.Fatalf("Env TEST was not overwritten with bar when foo was supplied to dockerfile: was %q", strings.TrimSpace(out))
  299. }
  300. logDone("build - env should handle \\$ properly")
  301. }
  302. func TestBuildEnvOverwrite(t *testing.T) {
  303. name := "testbuildenvoverwrite"
  304. defer deleteImages(name)
  305. defer deleteAllContainers()
  306. _, err := buildImage(name,
  307. `
  308. FROM busybox
  309. ENV TEST foo
  310. CMD echo ${TEST}
  311. `,
  312. true)
  313. if err != nil {
  314. t.Fatal(err)
  315. }
  316. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "-e", "TEST=bar", "-t", name))
  317. if err != nil {
  318. t.Fatal(err)
  319. }
  320. if strings.TrimSpace(out) != "bar" {
  321. t.Fatalf("Env TEST was not overwritten with bar when foo was supplied to dockerfile: was %q", strings.TrimSpace(out))
  322. }
  323. logDone("build - env should overwrite builder ENV during run")
  324. }
  325. func TestBuildOnBuildForbiddenMaintainerInSourceImage(t *testing.T) {
  326. name := "testbuildonbuildforbiddenmaintainerinsourceimage"
  327. defer deleteImages("onbuild")
  328. defer deleteImages(name)
  329. defer deleteAllContainers()
  330. createCmd := exec.Command(dockerBinary, "create", "busybox", "true")
  331. out, _, _, err := runCommandWithStdoutStderr(createCmd)
  332. if err != nil {
  333. t.Fatal(out, err)
  334. }
  335. cleanedContainerID := stripTrailingCharacters(out)
  336. commitCmd := exec.Command(dockerBinary, "commit", "--run", "{\"OnBuild\":[\"MAINTAINER docker.io\"]}", cleanedContainerID, "onbuild")
  337. if _, err := runCommand(commitCmd); err != nil {
  338. t.Fatal(err)
  339. }
  340. _, err = buildImage(name,
  341. `FROM onbuild`,
  342. true)
  343. if err != nil {
  344. if !strings.Contains(err.Error(), "maintainer isn't allowed as an ONBUILD trigger") {
  345. t.Fatalf("Wrong error %v, must be about MAINTAINER and ONBUILD in source image", err)
  346. }
  347. } else {
  348. t.Fatal("Error must not be nil")
  349. }
  350. logDone("build - onbuild forbidden maintainer in source image")
  351. }
  352. func TestBuildOnBuildForbiddenFromInSourceImage(t *testing.T) {
  353. name := "testbuildonbuildforbiddenfrominsourceimage"
  354. defer deleteImages("onbuild")
  355. defer deleteImages(name)
  356. defer deleteAllContainers()
  357. createCmd := exec.Command(dockerBinary, "create", "busybox", "true")
  358. out, _, _, err := runCommandWithStdoutStderr(createCmd)
  359. if err != nil {
  360. t.Fatal(out, err)
  361. }
  362. cleanedContainerID := stripTrailingCharacters(out)
  363. commitCmd := exec.Command(dockerBinary, "commit", "--run", "{\"OnBuild\":[\"FROM busybox\"]}", cleanedContainerID, "onbuild")
  364. if _, err := runCommand(commitCmd); err != nil {
  365. t.Fatal(err)
  366. }
  367. _, err = buildImage(name,
  368. `FROM onbuild`,
  369. true)
  370. if err != nil {
  371. if !strings.Contains(err.Error(), "from isn't allowed as an ONBUILD trigger") {
  372. t.Fatalf("Wrong error %v, must be about FROM and ONBUILD in source image", err)
  373. }
  374. } else {
  375. t.Fatal("Error must not be nil")
  376. }
  377. logDone("build - onbuild forbidden from in source image")
  378. }
  379. func TestBuildOnBuildForbiddenChainedInSourceImage(t *testing.T) {
  380. name := "testbuildonbuildforbiddenchainedinsourceimage"
  381. defer deleteImages("onbuild")
  382. defer deleteImages(name)
  383. defer deleteAllContainers()
  384. createCmd := exec.Command(dockerBinary, "create", "busybox", "true")
  385. out, _, _, err := runCommandWithStdoutStderr(createCmd)
  386. if err != nil {
  387. t.Fatal(out, err)
  388. }
  389. cleanedContainerID := stripTrailingCharacters(out)
  390. commitCmd := exec.Command(dockerBinary, "commit", "--run", "{\"OnBuild\":[\"ONBUILD RUN ls\"]}", cleanedContainerID, "onbuild")
  391. if _, err := runCommand(commitCmd); err != nil {
  392. t.Fatal(err)
  393. }
  394. _, err = buildImage(name,
  395. `FROM onbuild`,
  396. true)
  397. if err != nil {
  398. if !strings.Contains(err.Error(), "Chaining ONBUILD via `ONBUILD ONBUILD` isn't allowed") {
  399. t.Fatalf("Wrong error %v, must be about chaining ONBUILD in source image", err)
  400. }
  401. } else {
  402. t.Fatal("Error must not be nil")
  403. }
  404. logDone("build - onbuild forbidden chained in source image")
  405. }
  406. func TestBuildOnBuildCmdEntrypointJSON(t *testing.T) {
  407. name1 := "onbuildcmd"
  408. name2 := "onbuildgenerated"
  409. defer deleteImages(name2)
  410. defer deleteImages(name1)
  411. defer deleteAllContainers()
  412. _, err := buildImage(name1, `
  413. FROM busybox
  414. ONBUILD CMD ["hello world"]
  415. ONBUILD ENTRYPOINT ["echo"]
  416. ONBUILD RUN ["true"]`,
  417. false)
  418. if err != nil {
  419. t.Fatal(err)
  420. }
  421. _, err = buildImage(name2, fmt.Sprintf(`FROM %s`, name1), false)
  422. if err != nil {
  423. t.Fatal(err)
  424. }
  425. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "-t", name2))
  426. if err != nil {
  427. t.Fatal(err)
  428. }
  429. if !regexp.MustCompile(`(?m)^hello world`).MatchString(out) {
  430. t.Fatal("did not get echo output from onbuild", out)
  431. }
  432. logDone("build - onbuild with json entrypoint/cmd")
  433. }
  434. func TestBuildOnBuildEntrypointJSON(t *testing.T) {
  435. name1 := "onbuildcmd"
  436. name2 := "onbuildgenerated"
  437. defer deleteImages(name2)
  438. defer deleteImages(name1)
  439. defer deleteAllContainers()
  440. _, err := buildImage(name1, `
  441. FROM busybox
  442. ONBUILD ENTRYPOINT ["echo"]`,
  443. false)
  444. if err != nil {
  445. t.Fatal(err)
  446. }
  447. _, err = buildImage(name2, fmt.Sprintf("FROM %s\nCMD [\"hello world\"]\n", name1), false)
  448. if err != nil {
  449. t.Fatal(err)
  450. }
  451. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "-t", name2))
  452. if err != nil {
  453. t.Fatal(err)
  454. }
  455. if !regexp.MustCompile(`(?m)^hello world`).MatchString(out) {
  456. t.Fatal("got malformed output from onbuild", out)
  457. }
  458. logDone("build - onbuild with json entrypoint")
  459. }
  460. func TestBuildCacheADD(t *testing.T) {
  461. name := "testbuildtwoimageswithadd"
  462. defer deleteImages(name)
  463. server, err := fakeStorage(map[string]string{
  464. "robots.txt": "hello",
  465. "index.html": "world",
  466. })
  467. if err != nil {
  468. t.Fatal(err)
  469. }
  470. defer server.Close()
  471. if _, err := buildImage(name,
  472. fmt.Sprintf(`FROM scratch
  473. ADD %s/robots.txt /`, server.URL),
  474. true); err != nil {
  475. t.Fatal(err)
  476. }
  477. if err != nil {
  478. t.Fatal(err)
  479. }
  480. deleteImages(name)
  481. _, out, err := buildImageWithOut(name,
  482. fmt.Sprintf(`FROM scratch
  483. ADD %s/index.html /`, server.URL),
  484. true)
  485. if err != nil {
  486. t.Fatal(err)
  487. }
  488. if strings.Contains(out, "Using cache") {
  489. t.Fatal("2nd build used cache on ADD, it shouldn't")
  490. }
  491. logDone("build - build two images with remote ADD")
  492. }
  493. func TestBuildSixtySteps(t *testing.T) {
  494. name := "foobuildsixtysteps"
  495. defer deleteImages(name)
  496. ctx, err := fakeContext("FROM scratch\n"+strings.Repeat("ADD foo /\n", 60),
  497. map[string]string{
  498. "foo": "test1",
  499. })
  500. if err != nil {
  501. t.Fatal(err)
  502. }
  503. defer ctx.Close()
  504. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  505. t.Fatal(err)
  506. }
  507. logDone("build - build an image with sixty build steps")
  508. }
  509. func TestBuildAddSingleFileToRoot(t *testing.T) {
  510. name := "testaddimg"
  511. defer deleteImages(name)
  512. ctx, err := fakeContext(`FROM busybox
  513. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  514. RUN echo 'dockerio:x:1001:' >> /etc/group
  515. RUN touch /exists
  516. RUN chown dockerio.dockerio /exists
  517. ADD test_file /
  518. RUN [ $(ls -l /test_file | awk '{print $3":"$4}') = 'root:root' ]
  519. RUN [ $(ls -l /test_file | awk '{print $1}') = '-rw-r--r--' ]
  520. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  521. map[string]string{
  522. "test_file": "test1",
  523. })
  524. if err != nil {
  525. t.Fatal(err)
  526. }
  527. defer ctx.Close()
  528. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  529. t.Fatal(err)
  530. }
  531. logDone("build - add single file to root")
  532. }
  533. // Issue #3960: "ADD src ." hangs
  534. func TestBuildAddSingleFileToWorkdir(t *testing.T) {
  535. name := "testaddsinglefiletoworkdir"
  536. defer deleteImages(name)
  537. ctx, err := fakeContext(`FROM busybox
  538. ADD test_file .`,
  539. map[string]string{
  540. "test_file": "test1",
  541. })
  542. if err != nil {
  543. t.Fatal(err)
  544. }
  545. defer ctx.Close()
  546. done := make(chan struct{})
  547. go func() {
  548. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  549. t.Fatal(err)
  550. }
  551. close(done)
  552. }()
  553. select {
  554. case <-time.After(5 * time.Second):
  555. t.Fatal("Build with adding to workdir timed out")
  556. case <-done:
  557. }
  558. logDone("build - add single file to workdir")
  559. }
  560. func TestBuildAddSingleFileToExistDir(t *testing.T) {
  561. name := "testaddsinglefiletoexistdir"
  562. defer deleteImages(name)
  563. ctx, err := fakeContext(`FROM busybox
  564. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  565. RUN echo 'dockerio:x:1001:' >> /etc/group
  566. RUN mkdir /exists
  567. RUN touch /exists/exists_file
  568. RUN chown -R dockerio.dockerio /exists
  569. ADD test_file /exists/
  570. RUN [ $(ls -l / | grep exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]
  571. RUN [ $(ls -l /exists/test_file | awk '{print $3":"$4}') = 'root:root' ]
  572. RUN [ $(ls -l /exists/exists_file | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  573. map[string]string{
  574. "test_file": "test1",
  575. })
  576. if err != nil {
  577. t.Fatal(err)
  578. }
  579. defer ctx.Close()
  580. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  581. t.Fatal(err)
  582. }
  583. logDone("build - add single file to existing dir")
  584. }
  585. func TestBuildCopyAddMultipleFiles(t *testing.T) {
  586. name := "testcopymultiplefilestofile"
  587. defer deleteImages(name)
  588. ctx, err := fakeContext(`FROM busybox
  589. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  590. RUN echo 'dockerio:x:1001:' >> /etc/group
  591. RUN mkdir /exists
  592. RUN touch /exists/exists_file
  593. RUN chown -R dockerio.dockerio /exists
  594. COPY test_file1 test_file2 /exists/
  595. ADD test_file3 test_file4 https://docker.com/robots.txt /exists/
  596. RUN [ $(ls -l / | grep exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]
  597. RUN [ $(ls -l /exists/test_file1 | awk '{print $3":"$4}') = 'root:root' ]
  598. RUN [ $(ls -l /exists/test_file2 | awk '{print $3":"$4}') = 'root:root' ]
  599. RUN [ $(ls -l /exists/test_file3 | awk '{print $3":"$4}') = 'root:root' ]
  600. RUN [ $(ls -l /exists/test_file4 | awk '{print $3":"$4}') = 'root:root' ]
  601. RUN [ $(ls -l /exists/robots.txt | awk '{print $3":"$4}') = 'root:root' ]
  602. RUN [ $(ls -l /exists/exists_file | awk '{print $3":"$4}') = 'dockerio:dockerio' ]
  603. `,
  604. map[string]string{
  605. "test_file1": "test1",
  606. "test_file2": "test2",
  607. "test_file3": "test3",
  608. "test_file4": "test4",
  609. })
  610. defer ctx.Close()
  611. if err != nil {
  612. t.Fatal(err)
  613. }
  614. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  615. t.Fatal(err)
  616. }
  617. logDone("build - mulitple file copy/add tests")
  618. }
  619. func TestBuildAddMultipleFilesToFile(t *testing.T) {
  620. name := "testaddmultiplefilestofile"
  621. defer deleteImages(name)
  622. ctx, err := fakeContext(`FROM scratch
  623. ADD file1.txt file2.txt test
  624. `,
  625. map[string]string{
  626. "file1.txt": "test1",
  627. "file2.txt": "test1",
  628. })
  629. defer ctx.Close()
  630. if err != nil {
  631. t.Fatal(err)
  632. }
  633. expected := "When using ADD with more than one source file, the destination must be a directory and end with a /"
  634. if _, err := buildImageFromContext(name, ctx, true); err == nil || !strings.Contains(err.Error(), expected) {
  635. t.Fatalf("Wrong error: (should contain \"%s\") got:\n%v", expected, err)
  636. }
  637. logDone("build - multiple add files to file")
  638. }
  639. func TestBuildAddMultipleFilesToFileWild(t *testing.T) {
  640. name := "testaddmultiplefilestofilewild"
  641. defer deleteImages(name)
  642. ctx, err := fakeContext(`FROM scratch
  643. ADD file*.txt test
  644. `,
  645. map[string]string{
  646. "file1.txt": "test1",
  647. "file2.txt": "test1",
  648. })
  649. defer ctx.Close()
  650. if err != nil {
  651. t.Fatal(err)
  652. }
  653. expected := "When using ADD with more than one source file, the destination must be a directory and end with a /"
  654. if _, err := buildImageFromContext(name, ctx, true); err == nil || !strings.Contains(err.Error(), expected) {
  655. t.Fatalf("Wrong error: (should contain \"%s\") got:\n%v", expected, err)
  656. }
  657. logDone("build - multiple add files to file wild")
  658. }
  659. func TestBuildCopyMultipleFilesToFile(t *testing.T) {
  660. name := "testcopymultiplefilestofile"
  661. defer deleteImages(name)
  662. ctx, err := fakeContext(`FROM scratch
  663. COPY file1.txt file2.txt test
  664. `,
  665. map[string]string{
  666. "file1.txt": "test1",
  667. "file2.txt": "test1",
  668. })
  669. defer ctx.Close()
  670. if err != nil {
  671. t.Fatal(err)
  672. }
  673. expected := "When using COPY with more than one source file, the destination must be a directory and end with a /"
  674. if _, err := buildImageFromContext(name, ctx, true); err == nil || !strings.Contains(err.Error(), expected) {
  675. t.Fatalf("Wrong error: (should contain \"%s\") got:\n%v", expected, err)
  676. }
  677. logDone("build - multiple copy files to file")
  678. }
  679. func TestBuildCopyWildcard(t *testing.T) {
  680. name := "testcopywildcard"
  681. defer deleteImages(name)
  682. server, err := fakeStorage(map[string]string{
  683. "robots.txt": "hello",
  684. "index.html": "world",
  685. })
  686. if err != nil {
  687. t.Fatal(err)
  688. }
  689. defer server.Close()
  690. ctx, err := fakeContext(fmt.Sprintf(`FROM busybox
  691. COPY file*.txt /tmp/
  692. RUN ls /tmp/file1.txt /tmp/file2.txt
  693. RUN mkdir /tmp1
  694. COPY dir* /tmp1/
  695. RUN ls /tmp1/dirt /tmp1/nested_file /tmp1/nested_dir/nest_nest_file
  696. RUN mkdir /tmp2
  697. ADD dir/*dir %s/robots.txt /tmp2/
  698. RUN ls /tmp2/nest_nest_file /tmp2/robots.txt
  699. `, server.URL),
  700. map[string]string{
  701. "file1.txt": "test1",
  702. "file2.txt": "test2",
  703. "dir/nested_file": "nested file",
  704. "dir/nested_dir/nest_nest_file": "2 times nested",
  705. "dirt": "dirty",
  706. })
  707. defer ctx.Close()
  708. if err != nil {
  709. t.Fatal(err)
  710. }
  711. id1, err := buildImageFromContext(name, ctx, true)
  712. if err != nil {
  713. t.Fatal(err)
  714. }
  715. // Now make sure we use a cache the 2nd time
  716. id2, err := buildImageFromContext(name, ctx, true)
  717. if err != nil {
  718. t.Fatal(err)
  719. }
  720. if id1 != id2 {
  721. t.Fatal("didn't use the cache")
  722. }
  723. logDone("build - copy wild card")
  724. }
  725. func TestBuildCopyWildcardNoFind(t *testing.T) {
  726. name := "testcopywildcardnofind"
  727. defer deleteImages(name)
  728. ctx, err := fakeContext(`FROM busybox
  729. COPY file*.txt /tmp/
  730. `, nil)
  731. defer ctx.Close()
  732. if err != nil {
  733. t.Fatal(err)
  734. }
  735. _, err = buildImageFromContext(name, ctx, true)
  736. if err == nil {
  737. t.Fatal("should have failed to find a file")
  738. }
  739. if !strings.Contains(err.Error(), "No source files were specified") {
  740. t.Fatalf("Wrong error %v, must be about no source files", err)
  741. }
  742. logDone("build - copy wild card no find")
  743. }
  744. func TestBuildCopyWildcardCache(t *testing.T) {
  745. name := "testcopywildcardcache"
  746. defer deleteImages(name)
  747. ctx, err := fakeContext(`FROM busybox
  748. COPY file1.txt /tmp/`,
  749. map[string]string{
  750. "file1.txt": "test1",
  751. })
  752. defer ctx.Close()
  753. if err != nil {
  754. t.Fatal(err)
  755. }
  756. id1, err := buildImageFromContext(name, ctx, true)
  757. if err != nil {
  758. t.Fatal(err)
  759. }
  760. // Now make sure we use a cache the 2nd time even with wild cards.
  761. // Use the same context so the file is the same and the checksum will match
  762. ctx.Add("Dockerfile", `FROM busybox
  763. COPY file*.txt /tmp/`)
  764. id2, err := buildImageFromContext(name, ctx, true)
  765. if err != nil {
  766. t.Fatal(err)
  767. }
  768. if id1 != id2 {
  769. t.Fatal("didn't use the cache")
  770. }
  771. logDone("build - copy wild card cache")
  772. }
  773. func TestBuildAddSingleFileToNonExistingDir(t *testing.T) {
  774. name := "testaddsinglefiletononexistingdir"
  775. defer deleteImages(name)
  776. ctx, err := fakeContext(`FROM busybox
  777. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  778. RUN echo 'dockerio:x:1001:' >> /etc/group
  779. RUN touch /exists
  780. RUN chown dockerio.dockerio /exists
  781. ADD test_file /test_dir/
  782. RUN [ $(ls -l / | grep test_dir | awk '{print $3":"$4}') = 'root:root' ]
  783. RUN [ $(ls -l /test_dir/test_file | awk '{print $3":"$4}') = 'root:root' ]
  784. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  785. map[string]string{
  786. "test_file": "test1",
  787. })
  788. if err != nil {
  789. t.Fatal(err)
  790. }
  791. defer ctx.Close()
  792. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  793. t.Fatal(err)
  794. }
  795. logDone("build - add single file to non-existing dir")
  796. }
  797. func TestBuildAddDirContentToRoot(t *testing.T) {
  798. name := "testadddircontenttoroot"
  799. defer deleteImages(name)
  800. ctx, err := fakeContext(`FROM busybox
  801. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  802. RUN echo 'dockerio:x:1001:' >> /etc/group
  803. RUN touch /exists
  804. RUN chown dockerio.dockerio exists
  805. ADD test_dir /
  806. RUN [ $(ls -l /test_file | awk '{print $3":"$4}') = 'root:root' ]
  807. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  808. map[string]string{
  809. "test_dir/test_file": "test1",
  810. })
  811. if err != nil {
  812. t.Fatal(err)
  813. }
  814. defer ctx.Close()
  815. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  816. t.Fatal(err)
  817. }
  818. logDone("build - add directory contents to root")
  819. }
  820. func TestBuildAddDirContentToExistingDir(t *testing.T) {
  821. name := "testadddircontenttoexistingdir"
  822. defer deleteImages(name)
  823. ctx, err := fakeContext(`FROM busybox
  824. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  825. RUN echo 'dockerio:x:1001:' >> /etc/group
  826. RUN mkdir /exists
  827. RUN touch /exists/exists_file
  828. RUN chown -R dockerio.dockerio /exists
  829. ADD test_dir/ /exists/
  830. RUN [ $(ls -l / | grep exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]
  831. RUN [ $(ls -l /exists/exists_file | awk '{print $3":"$4}') = 'dockerio:dockerio' ]
  832. RUN [ $(ls -l /exists/test_file | awk '{print $3":"$4}') = 'root:root' ]`,
  833. map[string]string{
  834. "test_dir/test_file": "test1",
  835. })
  836. if err != nil {
  837. t.Fatal(err)
  838. }
  839. defer ctx.Close()
  840. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  841. t.Fatal(err)
  842. }
  843. logDone("build - add directory contents to existing dir")
  844. }
  845. func TestBuildAddWholeDirToRoot(t *testing.T) {
  846. name := "testaddwholedirtoroot"
  847. defer deleteImages(name)
  848. ctx, err := fakeContext(`FROM busybox
  849. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  850. RUN echo 'dockerio:x:1001:' >> /etc/group
  851. RUN touch /exists
  852. RUN chown dockerio.dockerio exists
  853. ADD test_dir /test_dir
  854. RUN [ $(ls -l / | grep test_dir | awk '{print $3":"$4}') = 'root:root' ]
  855. RUN [ $(ls -l / | grep test_dir | awk '{print $1}') = 'drwxr-xr-x' ]
  856. RUN [ $(ls -l /test_dir/test_file | awk '{print $3":"$4}') = 'root:root' ]
  857. RUN [ $(ls -l /test_dir/test_file | awk '{print $1}') = '-rw-r--r--' ]
  858. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  859. map[string]string{
  860. "test_dir/test_file": "test1",
  861. })
  862. if err != nil {
  863. t.Fatal(err)
  864. }
  865. defer ctx.Close()
  866. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  867. t.Fatal(err)
  868. }
  869. logDone("build - add whole directory to root")
  870. }
  871. // Testing #5941
  872. func TestBuildAddEtcToRoot(t *testing.T) {
  873. name := "testaddetctoroot"
  874. defer deleteImages(name)
  875. ctx, err := fakeContext(`FROM scratch
  876. ADD . /`,
  877. map[string]string{
  878. "etc/test_file": "test1",
  879. })
  880. if err != nil {
  881. t.Fatal(err)
  882. }
  883. defer ctx.Close()
  884. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  885. t.Fatal(err)
  886. }
  887. logDone("build - add etc directory to root")
  888. }
  889. // Testing #9401
  890. func TestBuildAddPreservesFilesSpecialBits(t *testing.T) {
  891. name := "testaddpreservesfilesspecialbits"
  892. defer deleteImages(name)
  893. ctx, err := fakeContext(`FROM busybox
  894. ADD suidbin /usr/bin/suidbin
  895. RUN chmod 4755 /usr/bin/suidbin
  896. RUN [ $(ls -l /usr/bin/suidbin | awk '{print $1}') = '-rwsr-xr-x' ]
  897. ADD ./data/ /
  898. RUN [ $(ls -l /usr/bin/suidbin | awk '{print $1}') = '-rwsr-xr-x' ]`,
  899. map[string]string{
  900. "suidbin": "suidbin",
  901. "/data/usr/test_file": "test1",
  902. })
  903. if err != nil {
  904. t.Fatal(err)
  905. }
  906. defer ctx.Close()
  907. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  908. t.Fatal(err)
  909. }
  910. logDone("build - add preserves files special bits")
  911. }
  912. func TestBuildCopySingleFileToRoot(t *testing.T) {
  913. name := "testcopysinglefiletoroot"
  914. defer deleteImages(name)
  915. ctx, err := fakeContext(`FROM busybox
  916. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  917. RUN echo 'dockerio:x:1001:' >> /etc/group
  918. RUN touch /exists
  919. RUN chown dockerio.dockerio /exists
  920. COPY test_file /
  921. RUN [ $(ls -l /test_file | awk '{print $3":"$4}') = 'root:root' ]
  922. RUN [ $(ls -l /test_file | awk '{print $1}') = '-rw-r--r--' ]
  923. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  924. map[string]string{
  925. "test_file": "test1",
  926. })
  927. if err != nil {
  928. t.Fatal(err)
  929. }
  930. defer ctx.Close()
  931. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  932. t.Fatal(err)
  933. }
  934. logDone("build - copy single file to root")
  935. }
  936. // Issue #3960: "ADD src ." hangs - adapted for COPY
  937. func TestBuildCopySingleFileToWorkdir(t *testing.T) {
  938. name := "testcopysinglefiletoworkdir"
  939. defer deleteImages(name)
  940. ctx, err := fakeContext(`FROM busybox
  941. COPY test_file .`,
  942. map[string]string{
  943. "test_file": "test1",
  944. })
  945. if err != nil {
  946. t.Fatal(err)
  947. }
  948. defer ctx.Close()
  949. done := make(chan struct{})
  950. go func() {
  951. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  952. t.Fatal(err)
  953. }
  954. close(done)
  955. }()
  956. select {
  957. case <-time.After(5 * time.Second):
  958. t.Fatal("Build with adding to workdir timed out")
  959. case <-done:
  960. }
  961. logDone("build - copy single file to workdir")
  962. }
  963. func TestBuildCopySingleFileToExistDir(t *testing.T) {
  964. name := "testcopysinglefiletoexistdir"
  965. defer deleteImages(name)
  966. ctx, err := fakeContext(`FROM busybox
  967. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  968. RUN echo 'dockerio:x:1001:' >> /etc/group
  969. RUN mkdir /exists
  970. RUN touch /exists/exists_file
  971. RUN chown -R dockerio.dockerio /exists
  972. COPY test_file /exists/
  973. RUN [ $(ls -l / | grep exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]
  974. RUN [ $(ls -l /exists/test_file | awk '{print $3":"$4}') = 'root:root' ]
  975. RUN [ $(ls -l /exists/exists_file | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  976. map[string]string{
  977. "test_file": "test1",
  978. })
  979. if err != nil {
  980. t.Fatal(err)
  981. }
  982. defer ctx.Close()
  983. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  984. t.Fatal(err)
  985. }
  986. logDone("build - copy single file to existing dir")
  987. }
  988. func TestBuildCopySingleFileToNonExistDir(t *testing.T) {
  989. name := "testcopysinglefiletononexistdir"
  990. defer deleteImages(name)
  991. ctx, err := fakeContext(`FROM busybox
  992. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  993. RUN echo 'dockerio:x:1001:' >> /etc/group
  994. RUN touch /exists
  995. RUN chown dockerio.dockerio /exists
  996. COPY test_file /test_dir/
  997. RUN [ $(ls -l / | grep test_dir | awk '{print $3":"$4}') = 'root:root' ]
  998. RUN [ $(ls -l /test_dir/test_file | awk '{print $3":"$4}') = 'root:root' ]
  999. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  1000. map[string]string{
  1001. "test_file": "test1",
  1002. })
  1003. if err != nil {
  1004. t.Fatal(err)
  1005. }
  1006. defer ctx.Close()
  1007. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1008. t.Fatal(err)
  1009. }
  1010. logDone("build - copy single file to non-existing dir")
  1011. }
  1012. func TestBuildCopyDirContentToRoot(t *testing.T) {
  1013. name := "testcopydircontenttoroot"
  1014. defer deleteImages(name)
  1015. ctx, err := fakeContext(`FROM busybox
  1016. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  1017. RUN echo 'dockerio:x:1001:' >> /etc/group
  1018. RUN touch /exists
  1019. RUN chown dockerio.dockerio exists
  1020. COPY test_dir /
  1021. RUN [ $(ls -l /test_file | awk '{print $3":"$4}') = 'root:root' ]
  1022. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  1023. map[string]string{
  1024. "test_dir/test_file": "test1",
  1025. })
  1026. if err != nil {
  1027. t.Fatal(err)
  1028. }
  1029. defer ctx.Close()
  1030. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1031. t.Fatal(err)
  1032. }
  1033. logDone("build - copy directory contents to root")
  1034. }
  1035. func TestBuildCopyDirContentToExistDir(t *testing.T) {
  1036. name := "testcopydircontenttoexistdir"
  1037. defer deleteImages(name)
  1038. ctx, err := fakeContext(`FROM busybox
  1039. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  1040. RUN echo 'dockerio:x:1001:' >> /etc/group
  1041. RUN mkdir /exists
  1042. RUN touch /exists/exists_file
  1043. RUN chown -R dockerio.dockerio /exists
  1044. COPY test_dir/ /exists/
  1045. RUN [ $(ls -l / | grep exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]
  1046. RUN [ $(ls -l /exists/exists_file | awk '{print $3":"$4}') = 'dockerio:dockerio' ]
  1047. RUN [ $(ls -l /exists/test_file | awk '{print $3":"$4}') = 'root:root' ]`,
  1048. map[string]string{
  1049. "test_dir/test_file": "test1",
  1050. })
  1051. if err != nil {
  1052. t.Fatal(err)
  1053. }
  1054. defer ctx.Close()
  1055. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1056. t.Fatal(err)
  1057. }
  1058. logDone("build - copy directory contents to existing dir")
  1059. }
  1060. func TestBuildCopyWholeDirToRoot(t *testing.T) {
  1061. name := "testcopywholedirtoroot"
  1062. defer deleteImages(name)
  1063. ctx, err := fakeContext(`FROM busybox
  1064. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  1065. RUN echo 'dockerio:x:1001:' >> /etc/group
  1066. RUN touch /exists
  1067. RUN chown dockerio.dockerio exists
  1068. COPY test_dir /test_dir
  1069. RUN [ $(ls -l / | grep test_dir | awk '{print $3":"$4}') = 'root:root' ]
  1070. RUN [ $(ls -l / | grep test_dir | awk '{print $1}') = 'drwxr-xr-x' ]
  1071. RUN [ $(ls -l /test_dir/test_file | awk '{print $3":"$4}') = 'root:root' ]
  1072. RUN [ $(ls -l /test_dir/test_file | awk '{print $1}') = '-rw-r--r--' ]
  1073. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  1074. map[string]string{
  1075. "test_dir/test_file": "test1",
  1076. })
  1077. if err != nil {
  1078. t.Fatal(err)
  1079. }
  1080. defer ctx.Close()
  1081. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1082. t.Fatal(err)
  1083. }
  1084. logDone("build - copy whole directory to root")
  1085. }
  1086. func TestBuildCopyEtcToRoot(t *testing.T) {
  1087. name := "testcopyetctoroot"
  1088. defer deleteImages(name)
  1089. ctx, err := fakeContext(`FROM scratch
  1090. COPY . /`,
  1091. map[string]string{
  1092. "etc/test_file": "test1",
  1093. })
  1094. if err != nil {
  1095. t.Fatal(err)
  1096. }
  1097. defer ctx.Close()
  1098. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1099. t.Fatal(err)
  1100. }
  1101. logDone("build - copy etc directory to root")
  1102. }
  1103. func TestBuildCopyDisallowRemote(t *testing.T) {
  1104. name := "testcopydisallowremote"
  1105. defer deleteImages(name)
  1106. _, out, err := buildImageWithOut(name, `FROM scratch
  1107. COPY https://index.docker.io/robots.txt /`,
  1108. true)
  1109. if err == nil || !strings.Contains(out, "Source can't be a URL for COPY") {
  1110. t.Fatalf("Error should be about disallowed remote source, got err: %s, out: %q", err, out)
  1111. }
  1112. logDone("build - copy - disallow copy from remote")
  1113. }
  1114. func TestBuildAddBadLinks(t *testing.T) {
  1115. const (
  1116. dockerfile = `
  1117. FROM scratch
  1118. ADD links.tar /
  1119. ADD foo.txt /symlink/
  1120. `
  1121. targetFile = "foo.txt"
  1122. )
  1123. var (
  1124. name = "test-link-absolute"
  1125. )
  1126. defer deleteImages(name)
  1127. ctx, err := fakeContext(dockerfile, nil)
  1128. if err != nil {
  1129. t.Fatal(err)
  1130. }
  1131. defer ctx.Close()
  1132. tempDir, err := ioutil.TempDir("", "test-link-absolute-temp-")
  1133. if err != nil {
  1134. t.Fatalf("failed to create temporary directory: %s", tempDir)
  1135. }
  1136. defer os.RemoveAll(tempDir)
  1137. symlinkTarget := fmt.Sprintf("/../../../../../../../../../../../..%s", tempDir)
  1138. tarPath := filepath.Join(ctx.Dir, "links.tar")
  1139. nonExistingFile := filepath.Join(tempDir, targetFile)
  1140. fooPath := filepath.Join(ctx.Dir, targetFile)
  1141. tarOut, err := os.Create(tarPath)
  1142. if err != nil {
  1143. t.Fatal(err)
  1144. }
  1145. tarWriter := tar.NewWriter(tarOut)
  1146. header := &tar.Header{
  1147. Name: "symlink",
  1148. Typeflag: tar.TypeSymlink,
  1149. Linkname: symlinkTarget,
  1150. Mode: 0755,
  1151. Uid: 0,
  1152. Gid: 0,
  1153. }
  1154. err = tarWriter.WriteHeader(header)
  1155. if err != nil {
  1156. t.Fatal(err)
  1157. }
  1158. tarWriter.Close()
  1159. tarOut.Close()
  1160. foo, err := os.Create(fooPath)
  1161. if err != nil {
  1162. t.Fatal(err)
  1163. }
  1164. defer foo.Close()
  1165. if _, err := foo.WriteString("test"); err != nil {
  1166. t.Fatal(err)
  1167. }
  1168. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1169. t.Fatal(err)
  1170. }
  1171. if _, err := os.Stat(nonExistingFile); err == nil || err != nil && !os.IsNotExist(err) {
  1172. t.Fatalf("%s shouldn't have been written and it shouldn't exist", nonExistingFile)
  1173. }
  1174. logDone("build - ADD must add files in container")
  1175. }
  1176. func TestBuildAddBadLinksVolume(t *testing.T) {
  1177. const (
  1178. dockerfileTemplate = `
  1179. FROM busybox
  1180. RUN ln -s /../../../../../../../../%s /x
  1181. VOLUME /x
  1182. ADD foo.txt /x/`
  1183. targetFile = "foo.txt"
  1184. )
  1185. var (
  1186. name = "test-link-absolute-volume"
  1187. dockerfile = ""
  1188. )
  1189. defer deleteImages(name)
  1190. tempDir, err := ioutil.TempDir("", "test-link-absolute-volume-temp-")
  1191. if err != nil {
  1192. t.Fatalf("failed to create temporary directory: %s", tempDir)
  1193. }
  1194. defer os.RemoveAll(tempDir)
  1195. dockerfile = fmt.Sprintf(dockerfileTemplate, tempDir)
  1196. nonExistingFile := filepath.Join(tempDir, targetFile)
  1197. ctx, err := fakeContext(dockerfile, nil)
  1198. if err != nil {
  1199. t.Fatal(err)
  1200. }
  1201. defer ctx.Close()
  1202. fooPath := filepath.Join(ctx.Dir, targetFile)
  1203. foo, err := os.Create(fooPath)
  1204. if err != nil {
  1205. t.Fatal(err)
  1206. }
  1207. defer foo.Close()
  1208. if _, err := foo.WriteString("test"); err != nil {
  1209. t.Fatal(err)
  1210. }
  1211. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1212. t.Fatal(err)
  1213. }
  1214. if _, err := os.Stat(nonExistingFile); err == nil || err != nil && !os.IsNotExist(err) {
  1215. t.Fatalf("%s shouldn't have been written and it shouldn't exist", nonExistingFile)
  1216. }
  1217. logDone("build - ADD should add files in volume")
  1218. }
  1219. // Issue #5270 - ensure we throw a better error than "unexpected EOF"
  1220. // when we can't access files in the context.
  1221. func TestBuildWithInaccessibleFilesInContext(t *testing.T) {
  1222. {
  1223. name := "testbuildinaccessiblefiles"
  1224. defer deleteImages(name)
  1225. ctx, err := fakeContext("FROM scratch\nADD . /foo/", map[string]string{"fileWithoutReadAccess": "foo"})
  1226. if err != nil {
  1227. t.Fatal(err)
  1228. }
  1229. defer ctx.Close()
  1230. // This is used to ensure we detect inaccessible files early during build in the cli client
  1231. pathToFileWithoutReadAccess := filepath.Join(ctx.Dir, "fileWithoutReadAccess")
  1232. if err = os.Chown(pathToFileWithoutReadAccess, 0, 0); err != nil {
  1233. t.Fatalf("failed to chown file to root: %s", err)
  1234. }
  1235. if err = os.Chmod(pathToFileWithoutReadAccess, 0700); err != nil {
  1236. t.Fatalf("failed to chmod file to 700: %s", err)
  1237. }
  1238. buildCmd := exec.Command("su", "unprivilegeduser", "-c", fmt.Sprintf("%s build -t %s .", dockerBinary, name))
  1239. buildCmd.Dir = ctx.Dir
  1240. out, _, err := runCommandWithOutput(buildCmd)
  1241. if err == nil {
  1242. t.Fatalf("build should have failed: %s %s", err, out)
  1243. }
  1244. // check if we've detected the failure before we started building
  1245. if !strings.Contains(out, "no permission to read from ") {
  1246. t.Fatalf("output should've contained the string: no permission to read from but contained: %s", out)
  1247. }
  1248. if !strings.Contains(out, "Error checking context is accessible") {
  1249. t.Fatalf("output should've contained the string: Error checking context is accessible")
  1250. }
  1251. }
  1252. {
  1253. name := "testbuildinaccessibledirectory"
  1254. defer deleteImages(name)
  1255. ctx, err := fakeContext("FROM scratch\nADD . /foo/", map[string]string{"directoryWeCantStat/bar": "foo"})
  1256. if err != nil {
  1257. t.Fatal(err)
  1258. }
  1259. defer ctx.Close()
  1260. // This is used to ensure we detect inaccessible directories early during build in the cli client
  1261. pathToDirectoryWithoutReadAccess := filepath.Join(ctx.Dir, "directoryWeCantStat")
  1262. pathToFileInDirectoryWithoutReadAccess := filepath.Join(pathToDirectoryWithoutReadAccess, "bar")
  1263. if err = os.Chown(pathToDirectoryWithoutReadAccess, 0, 0); err != nil {
  1264. t.Fatalf("failed to chown directory to root: %s", err)
  1265. }
  1266. if err = os.Chmod(pathToDirectoryWithoutReadAccess, 0444); err != nil {
  1267. t.Fatalf("failed to chmod directory to 755: %s", err)
  1268. }
  1269. if err = os.Chmod(pathToFileInDirectoryWithoutReadAccess, 0700); err != nil {
  1270. t.Fatalf("failed to chmod file to 444: %s", err)
  1271. }
  1272. buildCmd := exec.Command("su", "unprivilegeduser", "-c", fmt.Sprintf("%s build -t %s .", dockerBinary, name))
  1273. buildCmd.Dir = ctx.Dir
  1274. out, _, err := runCommandWithOutput(buildCmd)
  1275. if err == nil {
  1276. t.Fatalf("build should have failed: %s %s", err, out)
  1277. }
  1278. // check if we've detected the failure before we started building
  1279. if !strings.Contains(out, "can't stat") {
  1280. t.Fatalf("output should've contained the string: can't access %s", out)
  1281. }
  1282. if !strings.Contains(out, "Error checking context is accessible") {
  1283. t.Fatalf("output should've contained the string: Error checking context is accessible")
  1284. }
  1285. }
  1286. {
  1287. name := "testlinksok"
  1288. defer deleteImages(name)
  1289. ctx, err := fakeContext("FROM scratch\nADD . /foo/", nil)
  1290. if err != nil {
  1291. t.Fatal(err)
  1292. }
  1293. defer ctx.Close()
  1294. target := "../../../../../../../../../../../../../../../../../../../azA"
  1295. if err := os.Symlink(filepath.Join(ctx.Dir, "g"), target); err != nil {
  1296. t.Fatal(err)
  1297. }
  1298. defer os.Remove(target)
  1299. // This is used to ensure we don't follow links when checking if everything in the context is accessible
  1300. // This test doesn't require that we run commands as an unprivileged user
  1301. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1302. t.Fatal(err)
  1303. }
  1304. }
  1305. {
  1306. name := "testbuildignoredinaccessible"
  1307. defer deleteImages(name)
  1308. ctx, err := fakeContext("FROM scratch\nADD . /foo/",
  1309. map[string]string{
  1310. "directoryWeCantStat/bar": "foo",
  1311. ".dockerignore": "directoryWeCantStat",
  1312. })
  1313. if err != nil {
  1314. t.Fatal(err)
  1315. }
  1316. defer ctx.Close()
  1317. // This is used to ensure we don't try to add inaccessible files when they are ignored by a .dockerignore pattern
  1318. pathToDirectoryWithoutReadAccess := filepath.Join(ctx.Dir, "directoryWeCantStat")
  1319. pathToFileInDirectoryWithoutReadAccess := filepath.Join(pathToDirectoryWithoutReadAccess, "bar")
  1320. if err = os.Chown(pathToDirectoryWithoutReadAccess, 0, 0); err != nil {
  1321. t.Fatalf("failed to chown directory to root: %s", err)
  1322. }
  1323. if err = os.Chmod(pathToDirectoryWithoutReadAccess, 0444); err != nil {
  1324. t.Fatalf("failed to chmod directory to 755: %s", err)
  1325. }
  1326. if err = os.Chmod(pathToFileInDirectoryWithoutReadAccess, 0700); err != nil {
  1327. t.Fatalf("failed to chmod file to 444: %s", err)
  1328. }
  1329. buildCmd := exec.Command("su", "unprivilegeduser", "-c", fmt.Sprintf("%s build -t %s .", dockerBinary, name))
  1330. buildCmd.Dir = ctx.Dir
  1331. if out, _, err := runCommandWithOutput(buildCmd); err != nil {
  1332. t.Fatalf("build should have worked: %s %s", err, out)
  1333. }
  1334. }
  1335. logDone("build - ADD from context with inaccessible files must fail")
  1336. logDone("build - ADD from context with accessible links must work")
  1337. logDone("build - ADD from context with ignored inaccessible files must work")
  1338. }
  1339. func TestBuildForceRm(t *testing.T) {
  1340. containerCountBefore, err := getContainerCount()
  1341. if err != nil {
  1342. t.Fatalf("failed to get the container count: %s", err)
  1343. }
  1344. name := "testbuildforcerm"
  1345. defer deleteImages(name)
  1346. ctx, err := fakeContext("FROM scratch\nRUN true\nRUN thiswillfail", nil)
  1347. if err != nil {
  1348. t.Fatal(err)
  1349. }
  1350. defer ctx.Close()
  1351. buildCmd := exec.Command(dockerBinary, "build", "-t", name, "--force-rm", ".")
  1352. buildCmd.Dir = ctx.Dir
  1353. if out, _, err := runCommandWithOutput(buildCmd); err == nil {
  1354. t.Fatalf("failed to build the image: %s, %v", out, err)
  1355. }
  1356. containerCountAfter, err := getContainerCount()
  1357. if err != nil {
  1358. t.Fatalf("failed to get the container count: %s", err)
  1359. }
  1360. if containerCountBefore != containerCountAfter {
  1361. t.Fatalf("--force-rm shouldn't have left containers behind")
  1362. }
  1363. logDone("build - ensure --force-rm doesn't leave containers behind")
  1364. }
  1365. func TestBuildRm(t *testing.T) {
  1366. name := "testbuildrm"
  1367. defer deleteImages(name)
  1368. ctx, err := fakeContext("FROM scratch\nADD foo /\nADD foo /", map[string]string{"foo": "bar"})
  1369. if err != nil {
  1370. t.Fatal(err)
  1371. }
  1372. defer ctx.Close()
  1373. {
  1374. containerCountBefore, err := getContainerCount()
  1375. if err != nil {
  1376. t.Fatalf("failed to get the container count: %s", err)
  1377. }
  1378. out, _, err := dockerCmdInDir(t, ctx.Dir, "build", "--rm", "-t", name, ".")
  1379. if err != nil {
  1380. t.Fatal("failed to build the image", out)
  1381. }
  1382. containerCountAfter, err := getContainerCount()
  1383. if err != nil {
  1384. t.Fatalf("failed to get the container count: %s", err)
  1385. }
  1386. if containerCountBefore != containerCountAfter {
  1387. t.Fatalf("-rm shouldn't have left containers behind")
  1388. }
  1389. deleteImages(name)
  1390. }
  1391. {
  1392. containerCountBefore, err := getContainerCount()
  1393. if err != nil {
  1394. t.Fatalf("failed to get the container count: %s", err)
  1395. }
  1396. out, _, err := dockerCmdInDir(t, ctx.Dir, "build", "-t", name, ".")
  1397. if err != nil {
  1398. t.Fatal("failed to build the image", out)
  1399. }
  1400. containerCountAfter, err := getContainerCount()
  1401. if err != nil {
  1402. t.Fatalf("failed to get the container count: %s", err)
  1403. }
  1404. if containerCountBefore != containerCountAfter {
  1405. t.Fatalf("--rm shouldn't have left containers behind")
  1406. }
  1407. deleteImages(name)
  1408. }
  1409. {
  1410. containerCountBefore, err := getContainerCount()
  1411. if err != nil {
  1412. t.Fatalf("failed to get the container count: %s", err)
  1413. }
  1414. out, _, err := dockerCmdInDir(t, ctx.Dir, "build", "--rm=false", "-t", name, ".")
  1415. if err != nil {
  1416. t.Fatal("failed to build the image", out)
  1417. }
  1418. containerCountAfter, err := getContainerCount()
  1419. if err != nil {
  1420. t.Fatalf("failed to get the container count: %s", err)
  1421. }
  1422. if containerCountBefore == containerCountAfter {
  1423. t.Fatalf("--rm=false should have left containers behind")
  1424. }
  1425. deleteAllContainers()
  1426. deleteImages(name)
  1427. }
  1428. logDone("build - ensure --rm doesn't leave containers behind and that --rm=true is the default")
  1429. logDone("build - ensure --rm=false overrides the default")
  1430. }
  1431. func TestBuildWithVolumes(t *testing.T) {
  1432. var (
  1433. result map[string]map[string]struct{}
  1434. name = "testbuildvolumes"
  1435. emptyMap = make(map[string]struct{})
  1436. expected = map[string]map[string]struct{}{
  1437. "/test1": emptyMap,
  1438. "/test2": emptyMap,
  1439. "/test3": emptyMap,
  1440. "/test4": emptyMap,
  1441. "/test5": emptyMap,
  1442. "/test6": emptyMap,
  1443. "[/test7": emptyMap,
  1444. "/test8]": emptyMap,
  1445. }
  1446. )
  1447. defer deleteImages(name)
  1448. _, err := buildImage(name,
  1449. `FROM scratch
  1450. VOLUME /test1
  1451. VOLUME /test2
  1452. VOLUME /test3 /test4
  1453. VOLUME ["/test5", "/test6"]
  1454. VOLUME [/test7 /test8]
  1455. `,
  1456. true)
  1457. if err != nil {
  1458. t.Fatal(err)
  1459. }
  1460. res, err := inspectFieldJSON(name, "Config.Volumes")
  1461. if err != nil {
  1462. t.Fatal(err)
  1463. }
  1464. err = unmarshalJSON([]byte(res), &result)
  1465. if err != nil {
  1466. t.Fatal(err)
  1467. }
  1468. equal := reflect.DeepEqual(&result, &expected)
  1469. if !equal {
  1470. t.Fatalf("Volumes %s, expected %s", result, expected)
  1471. }
  1472. logDone("build - with volumes")
  1473. }
  1474. func TestBuildMaintainer(t *testing.T) {
  1475. name := "testbuildmaintainer"
  1476. expected := "dockerio"
  1477. defer deleteImages(name)
  1478. _, err := buildImage(name,
  1479. `FROM scratch
  1480. MAINTAINER dockerio`,
  1481. true)
  1482. if err != nil {
  1483. t.Fatal(err)
  1484. }
  1485. res, err := inspectField(name, "Author")
  1486. if err != nil {
  1487. t.Fatal(err)
  1488. }
  1489. if res != expected {
  1490. t.Fatalf("Maintainer %s, expected %s", res, expected)
  1491. }
  1492. logDone("build - maintainer")
  1493. }
  1494. func TestBuildUser(t *testing.T) {
  1495. name := "testbuilduser"
  1496. expected := "dockerio"
  1497. defer deleteImages(name)
  1498. _, err := buildImage(name,
  1499. `FROM busybox
  1500. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  1501. USER dockerio
  1502. RUN [ $(whoami) = 'dockerio' ]`,
  1503. true)
  1504. if err != nil {
  1505. t.Fatal(err)
  1506. }
  1507. res, err := inspectField(name, "Config.User")
  1508. if err != nil {
  1509. t.Fatal(err)
  1510. }
  1511. if res != expected {
  1512. t.Fatalf("User %s, expected %s", res, expected)
  1513. }
  1514. logDone("build - user")
  1515. }
  1516. func TestBuildRelativeWorkdir(t *testing.T) {
  1517. name := "testbuildrelativeworkdir"
  1518. expected := "/test2/test3"
  1519. defer deleteImages(name)
  1520. _, err := buildImage(name,
  1521. `FROM busybox
  1522. RUN [ "$PWD" = '/' ]
  1523. WORKDIR test1
  1524. RUN [ "$PWD" = '/test1' ]
  1525. WORKDIR /test2
  1526. RUN [ "$PWD" = '/test2' ]
  1527. WORKDIR test3
  1528. RUN [ "$PWD" = '/test2/test3' ]`,
  1529. true)
  1530. if err != nil {
  1531. t.Fatal(err)
  1532. }
  1533. res, err := inspectField(name, "Config.WorkingDir")
  1534. if err != nil {
  1535. t.Fatal(err)
  1536. }
  1537. if res != expected {
  1538. t.Fatalf("Workdir %s, expected %s", res, expected)
  1539. }
  1540. logDone("build - relative workdir")
  1541. }
  1542. func TestBuildWorkdirWithEnvVariables(t *testing.T) {
  1543. name := "testbuildworkdirwithenvvariables"
  1544. expected := "/test1/test2/$MISSING_VAR"
  1545. defer deleteImages(name)
  1546. _, err := buildImage(name,
  1547. `FROM busybox
  1548. ENV DIRPATH /test1
  1549. ENV SUBDIRNAME test2
  1550. WORKDIR $DIRPATH
  1551. WORKDIR $SUBDIRNAME/$MISSING_VAR`,
  1552. true)
  1553. if err != nil {
  1554. t.Fatal(err)
  1555. }
  1556. res, err := inspectField(name, "Config.WorkingDir")
  1557. if err != nil {
  1558. t.Fatal(err)
  1559. }
  1560. if res != expected {
  1561. t.Fatalf("Workdir %s, expected %s", res, expected)
  1562. }
  1563. logDone("build - workdir with env variables")
  1564. }
  1565. func TestBuildEnv(t *testing.T) {
  1566. name := "testbuildenv"
  1567. expected := "[PATH=/test:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PORT=2375]"
  1568. defer deleteImages(name)
  1569. _, err := buildImage(name,
  1570. `FROM busybox
  1571. ENV PATH /test:$PATH
  1572. ENV PORT 2375
  1573. RUN [ $(env | grep PORT) = 'PORT=2375' ]`,
  1574. true)
  1575. if err != nil {
  1576. t.Fatal(err)
  1577. }
  1578. res, err := inspectField(name, "Config.Env")
  1579. if err != nil {
  1580. t.Fatal(err)
  1581. }
  1582. if res != expected {
  1583. t.Fatalf("Env %s, expected %s", res, expected)
  1584. }
  1585. logDone("build - env")
  1586. }
  1587. func TestBuildContextCleanup(t *testing.T) {
  1588. name := "testbuildcontextcleanup"
  1589. defer deleteImages(name)
  1590. entries, err := ioutil.ReadDir("/var/lib/docker/tmp")
  1591. if err != nil {
  1592. t.Fatalf("failed to list contents of tmp dir: %s", err)
  1593. }
  1594. _, err = buildImage(name,
  1595. `FROM scratch
  1596. ENTRYPOINT ["/bin/echo"]`,
  1597. true)
  1598. if err != nil {
  1599. t.Fatal(err)
  1600. }
  1601. entriesFinal, err := ioutil.ReadDir("/var/lib/docker/tmp")
  1602. if err != nil {
  1603. t.Fatalf("failed to list contents of tmp dir: %s", err)
  1604. }
  1605. if err = compareDirectoryEntries(entries, entriesFinal); err != nil {
  1606. t.Fatalf("context should have been deleted, but wasn't")
  1607. }
  1608. logDone("build - verify context cleanup works properly")
  1609. }
  1610. func TestBuildContextCleanupFailedBuild(t *testing.T) {
  1611. name := "testbuildcontextcleanup"
  1612. defer deleteImages(name)
  1613. defer deleteAllContainers()
  1614. entries, err := ioutil.ReadDir("/var/lib/docker/tmp")
  1615. if err != nil {
  1616. t.Fatalf("failed to list contents of tmp dir: %s", err)
  1617. }
  1618. _, err = buildImage(name,
  1619. `FROM scratch
  1620. RUN /non/existing/command`,
  1621. true)
  1622. if err == nil {
  1623. t.Fatalf("expected build to fail, but it didn't")
  1624. }
  1625. entriesFinal, err := ioutil.ReadDir("/var/lib/docker/tmp")
  1626. if err != nil {
  1627. t.Fatalf("failed to list contents of tmp dir: %s", err)
  1628. }
  1629. if err = compareDirectoryEntries(entries, entriesFinal); err != nil {
  1630. t.Fatalf("context should have been deleted, but wasn't")
  1631. }
  1632. logDone("build - verify context cleanup works properly after a failed build")
  1633. }
  1634. func TestBuildCmd(t *testing.T) {
  1635. name := "testbuildcmd"
  1636. expected := "[/bin/echo Hello World]"
  1637. defer deleteImages(name)
  1638. _, err := buildImage(name,
  1639. `FROM scratch
  1640. CMD ["/bin/echo", "Hello World"]`,
  1641. true)
  1642. if err != nil {
  1643. t.Fatal(err)
  1644. }
  1645. res, err := inspectField(name, "Config.Cmd")
  1646. if err != nil {
  1647. t.Fatal(err)
  1648. }
  1649. if res != expected {
  1650. t.Fatalf("Cmd %s, expected %s", res, expected)
  1651. }
  1652. logDone("build - cmd")
  1653. }
  1654. func TestBuildExpose(t *testing.T) {
  1655. name := "testbuildexpose"
  1656. expected := "map[2375/tcp:map[]]"
  1657. defer deleteImages(name)
  1658. _, err := buildImage(name,
  1659. `FROM scratch
  1660. EXPOSE 2375`,
  1661. true)
  1662. if err != nil {
  1663. t.Fatal(err)
  1664. }
  1665. res, err := inspectField(name, "Config.ExposedPorts")
  1666. if err != nil {
  1667. t.Fatal(err)
  1668. }
  1669. if res != expected {
  1670. t.Fatalf("Exposed ports %s, expected %s", res, expected)
  1671. }
  1672. logDone("build - expose")
  1673. }
  1674. func TestBuildEmptyEntrypointInheritance(t *testing.T) {
  1675. name := "testbuildentrypointinheritance"
  1676. name2 := "testbuildentrypointinheritance2"
  1677. defer deleteImages(name, name2)
  1678. _, err := buildImage(name,
  1679. `FROM busybox
  1680. ENTRYPOINT ["/bin/echo"]`,
  1681. true)
  1682. if err != nil {
  1683. t.Fatal(err)
  1684. }
  1685. res, err := inspectField(name, "Config.Entrypoint")
  1686. if err != nil {
  1687. t.Fatal(err)
  1688. }
  1689. expected := "[/bin/echo]"
  1690. if res != expected {
  1691. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  1692. }
  1693. _, err = buildImage(name2,
  1694. fmt.Sprintf(`FROM %s
  1695. ENTRYPOINT []`, name),
  1696. true)
  1697. if err != nil {
  1698. t.Fatal(err)
  1699. }
  1700. res, err = inspectField(name2, "Config.Entrypoint")
  1701. if err != nil {
  1702. t.Fatal(err)
  1703. }
  1704. expected = "[]"
  1705. if res != expected {
  1706. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  1707. }
  1708. logDone("build - empty entrypoint inheritance")
  1709. }
  1710. func TestBuildEmptyEntrypoint(t *testing.T) {
  1711. name := "testbuildentrypoint"
  1712. defer deleteImages(name)
  1713. expected := "[]"
  1714. _, err := buildImage(name,
  1715. `FROM busybox
  1716. ENTRYPOINT []`,
  1717. true)
  1718. if err != nil {
  1719. t.Fatal(err)
  1720. }
  1721. res, err := inspectField(name, "Config.Entrypoint")
  1722. if err != nil {
  1723. t.Fatal(err)
  1724. }
  1725. if res != expected {
  1726. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  1727. }
  1728. logDone("build - empty entrypoint")
  1729. }
  1730. func TestBuildEntrypoint(t *testing.T) {
  1731. name := "testbuildentrypoint"
  1732. expected := "[/bin/echo]"
  1733. defer deleteImages(name)
  1734. _, err := buildImage(name,
  1735. `FROM scratch
  1736. ENTRYPOINT ["/bin/echo"]`,
  1737. true)
  1738. if err != nil {
  1739. t.Fatal(err)
  1740. }
  1741. res, err := inspectField(name, "Config.Entrypoint")
  1742. if err != nil {
  1743. t.Fatal(err)
  1744. }
  1745. if res != expected {
  1746. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  1747. }
  1748. logDone("build - entrypoint")
  1749. }
  1750. // #6445 ensure ONBUILD triggers aren't committed to grandchildren
  1751. func TestBuildOnBuildLimitedInheritence(t *testing.T) {
  1752. var (
  1753. out2, out3 string
  1754. )
  1755. {
  1756. name1 := "testonbuildtrigger1"
  1757. dockerfile1 := `
  1758. FROM busybox
  1759. RUN echo "GRANDPARENT"
  1760. ONBUILD RUN echo "ONBUILD PARENT"
  1761. `
  1762. ctx, err := fakeContext(dockerfile1, nil)
  1763. if err != nil {
  1764. t.Fatal(err)
  1765. }
  1766. defer ctx.Close()
  1767. out1, _, err := dockerCmdInDir(t, ctx.Dir, "build", "-t", name1, ".")
  1768. if err != nil {
  1769. t.Fatalf("build failed to complete: %s, %v", out1, err)
  1770. }
  1771. defer deleteImages(name1)
  1772. }
  1773. {
  1774. name2 := "testonbuildtrigger2"
  1775. dockerfile2 := `
  1776. FROM testonbuildtrigger1
  1777. `
  1778. ctx, err := fakeContext(dockerfile2, nil)
  1779. if err != nil {
  1780. t.Fatal(err)
  1781. }
  1782. defer ctx.Close()
  1783. out2, _, err = dockerCmdInDir(t, ctx.Dir, "build", "-t", name2, ".")
  1784. if err != nil {
  1785. t.Fatalf("build failed to complete: %s, %v", out2, err)
  1786. }
  1787. defer deleteImages(name2)
  1788. }
  1789. {
  1790. name3 := "testonbuildtrigger3"
  1791. dockerfile3 := `
  1792. FROM testonbuildtrigger2
  1793. `
  1794. ctx, err := fakeContext(dockerfile3, nil)
  1795. if err != nil {
  1796. t.Fatal(err)
  1797. }
  1798. defer ctx.Close()
  1799. out3, _, err = dockerCmdInDir(t, ctx.Dir, "build", "-t", name3, ".")
  1800. if err != nil {
  1801. t.Fatalf("build failed to complete: %s, %v", out3, err)
  1802. }
  1803. defer deleteImages(name3)
  1804. }
  1805. // ONBUILD should be run in second build.
  1806. if !strings.Contains(out2, "ONBUILD PARENT") {
  1807. t.Fatalf("ONBUILD instruction did not run in child of ONBUILD parent")
  1808. }
  1809. // ONBUILD should *not* be run in third build.
  1810. if strings.Contains(out3, "ONBUILD PARENT") {
  1811. t.Fatalf("ONBUILD instruction ran in grandchild of ONBUILD parent")
  1812. }
  1813. logDone("build - onbuild")
  1814. }
  1815. func TestBuildWithCache(t *testing.T) {
  1816. name := "testbuildwithcache"
  1817. defer deleteImages(name)
  1818. id1, err := buildImage(name,
  1819. `FROM scratch
  1820. MAINTAINER dockerio
  1821. EXPOSE 5432
  1822. ENTRYPOINT ["/bin/echo"]`,
  1823. true)
  1824. if err != nil {
  1825. t.Fatal(err)
  1826. }
  1827. id2, err := buildImage(name,
  1828. `FROM scratch
  1829. MAINTAINER dockerio
  1830. EXPOSE 5432
  1831. ENTRYPOINT ["/bin/echo"]`,
  1832. true)
  1833. if err != nil {
  1834. t.Fatal(err)
  1835. }
  1836. if id1 != id2 {
  1837. t.Fatal("The cache should have been used but hasn't.")
  1838. }
  1839. logDone("build - with cache")
  1840. }
  1841. func TestBuildWithoutCache(t *testing.T) {
  1842. name := "testbuildwithoutcache"
  1843. name2 := "testbuildwithoutcache2"
  1844. defer deleteImages(name, name2)
  1845. id1, err := buildImage(name,
  1846. `FROM scratch
  1847. MAINTAINER dockerio
  1848. EXPOSE 5432
  1849. ENTRYPOINT ["/bin/echo"]`,
  1850. true)
  1851. if err != nil {
  1852. t.Fatal(err)
  1853. }
  1854. id2, err := buildImage(name2,
  1855. `FROM scratch
  1856. MAINTAINER dockerio
  1857. EXPOSE 5432
  1858. ENTRYPOINT ["/bin/echo"]`,
  1859. false)
  1860. if err != nil {
  1861. t.Fatal(err)
  1862. }
  1863. if id1 == id2 {
  1864. t.Fatal("The cache should have been invalided but hasn't.")
  1865. }
  1866. logDone("build - without cache")
  1867. }
  1868. func TestBuildADDLocalFileWithCache(t *testing.T) {
  1869. name := "testbuildaddlocalfilewithcache"
  1870. name2 := "testbuildaddlocalfilewithcache2"
  1871. defer deleteImages(name, name2)
  1872. dockerfile := `
  1873. FROM busybox
  1874. MAINTAINER dockerio
  1875. ADD foo /usr/lib/bla/bar
  1876. RUN [ "$(cat /usr/lib/bla/bar)" = "hello" ]`
  1877. ctx, err := fakeContext(dockerfile, map[string]string{
  1878. "foo": "hello",
  1879. })
  1880. defer ctx.Close()
  1881. if err != nil {
  1882. t.Fatal(err)
  1883. }
  1884. id1, err := buildImageFromContext(name, ctx, true)
  1885. if err != nil {
  1886. t.Fatal(err)
  1887. }
  1888. id2, err := buildImageFromContext(name2, ctx, true)
  1889. if err != nil {
  1890. t.Fatal(err)
  1891. }
  1892. if id1 != id2 {
  1893. t.Fatal("The cache should have been used but hasn't.")
  1894. }
  1895. logDone("build - add local file with cache")
  1896. }
  1897. func TestBuildADDMultipleLocalFileWithCache(t *testing.T) {
  1898. name := "testbuildaddmultiplelocalfilewithcache"
  1899. name2 := "testbuildaddmultiplelocalfilewithcache2"
  1900. defer deleteImages(name, name2)
  1901. dockerfile := `
  1902. FROM busybox
  1903. MAINTAINER dockerio
  1904. ADD foo Dockerfile /usr/lib/bla/
  1905. RUN [ "$(cat /usr/lib/bla/foo)" = "hello" ]`
  1906. ctx, err := fakeContext(dockerfile, map[string]string{
  1907. "foo": "hello",
  1908. })
  1909. defer ctx.Close()
  1910. if err != nil {
  1911. t.Fatal(err)
  1912. }
  1913. id1, err := buildImageFromContext(name, ctx, true)
  1914. if err != nil {
  1915. t.Fatal(err)
  1916. }
  1917. id2, err := buildImageFromContext(name2, ctx, true)
  1918. if err != nil {
  1919. t.Fatal(err)
  1920. }
  1921. if id1 != id2 {
  1922. t.Fatal("The cache should have been used but hasn't.")
  1923. }
  1924. logDone("build - add multiple local files with cache")
  1925. }
  1926. func TestBuildADDLocalFileWithoutCache(t *testing.T) {
  1927. name := "testbuildaddlocalfilewithoutcache"
  1928. name2 := "testbuildaddlocalfilewithoutcache2"
  1929. defer deleteImages(name, name2)
  1930. dockerfile := `
  1931. FROM busybox
  1932. MAINTAINER dockerio
  1933. ADD foo /usr/lib/bla/bar
  1934. RUN [ "$(cat /usr/lib/bla/bar)" = "hello" ]`
  1935. ctx, err := fakeContext(dockerfile, map[string]string{
  1936. "foo": "hello",
  1937. })
  1938. defer ctx.Close()
  1939. if err != nil {
  1940. t.Fatal(err)
  1941. }
  1942. id1, err := buildImageFromContext(name, ctx, true)
  1943. if err != nil {
  1944. t.Fatal(err)
  1945. }
  1946. id2, err := buildImageFromContext(name2, ctx, false)
  1947. if err != nil {
  1948. t.Fatal(err)
  1949. }
  1950. if id1 == id2 {
  1951. t.Fatal("The cache should have been invalided but hasn't.")
  1952. }
  1953. logDone("build - add local file without cache")
  1954. }
  1955. func TestBuildCopyDirButNotFile(t *testing.T) {
  1956. name := "testbuildcopydirbutnotfile"
  1957. name2 := "testbuildcopydirbutnotfile2"
  1958. defer deleteImages(name, name2)
  1959. dockerfile := `
  1960. FROM scratch
  1961. COPY dir /tmp/`
  1962. ctx, err := fakeContext(dockerfile, map[string]string{
  1963. "dir/foo": "hello",
  1964. })
  1965. defer ctx.Close()
  1966. if err != nil {
  1967. t.Fatal(err)
  1968. }
  1969. id1, err := buildImageFromContext(name, ctx, true)
  1970. if err != nil {
  1971. t.Fatal(err)
  1972. }
  1973. // Check that adding file with similar name doesn't mess with cache
  1974. if err := ctx.Add("dir_file", "hello2"); err != nil {
  1975. t.Fatal(err)
  1976. }
  1977. id2, err := buildImageFromContext(name2, ctx, true)
  1978. if err != nil {
  1979. t.Fatal(err)
  1980. }
  1981. if id1 != id2 {
  1982. t.Fatal("The cache should have been used but wasn't")
  1983. }
  1984. logDone("build - add current directory but not file")
  1985. }
  1986. func TestBuildADDCurrentDirWithCache(t *testing.T) {
  1987. name := "testbuildaddcurrentdirwithcache"
  1988. name2 := name + "2"
  1989. name3 := name + "3"
  1990. name4 := name + "4"
  1991. name5 := name + "5"
  1992. defer deleteImages(name, name2, name3, name4, name5)
  1993. dockerfile := `
  1994. FROM scratch
  1995. MAINTAINER dockerio
  1996. ADD . /usr/lib/bla`
  1997. ctx, err := fakeContext(dockerfile, map[string]string{
  1998. "foo": "hello",
  1999. })
  2000. defer ctx.Close()
  2001. if err != nil {
  2002. t.Fatal(err)
  2003. }
  2004. id1, err := buildImageFromContext(name, ctx, true)
  2005. if err != nil {
  2006. t.Fatal(err)
  2007. }
  2008. // Check that adding file invalidate cache of "ADD ."
  2009. if err := ctx.Add("bar", "hello2"); err != nil {
  2010. t.Fatal(err)
  2011. }
  2012. id2, err := buildImageFromContext(name2, ctx, true)
  2013. if err != nil {
  2014. t.Fatal(err)
  2015. }
  2016. if id1 == id2 {
  2017. t.Fatal("The cache should have been invalided but hasn't.")
  2018. }
  2019. // Check that changing file invalidate cache of "ADD ."
  2020. if err := ctx.Add("foo", "hello1"); err != nil {
  2021. t.Fatal(err)
  2022. }
  2023. id3, err := buildImageFromContext(name3, ctx, true)
  2024. if err != nil {
  2025. t.Fatal(err)
  2026. }
  2027. if id2 == id3 {
  2028. t.Fatal("The cache should have been invalided but hasn't.")
  2029. }
  2030. // Check that changing file to same content invalidate cache of "ADD ."
  2031. time.Sleep(1 * time.Second) // wait second because of mtime precision
  2032. if err := ctx.Add("foo", "hello1"); err != nil {
  2033. t.Fatal(err)
  2034. }
  2035. id4, err := buildImageFromContext(name4, ctx, true)
  2036. if err != nil {
  2037. t.Fatal(err)
  2038. }
  2039. if id3 == id4 {
  2040. t.Fatal("The cache should have been invalided but hasn't.")
  2041. }
  2042. id5, err := buildImageFromContext(name5, ctx, true)
  2043. if err != nil {
  2044. t.Fatal(err)
  2045. }
  2046. if id4 != id5 {
  2047. t.Fatal("The cache should have been used but hasn't.")
  2048. }
  2049. logDone("build - add current directory with cache")
  2050. }
  2051. func TestBuildADDCurrentDirWithoutCache(t *testing.T) {
  2052. name := "testbuildaddcurrentdirwithoutcache"
  2053. name2 := "testbuildaddcurrentdirwithoutcache2"
  2054. defer deleteImages(name, name2)
  2055. dockerfile := `
  2056. FROM scratch
  2057. MAINTAINER dockerio
  2058. ADD . /usr/lib/bla`
  2059. ctx, err := fakeContext(dockerfile, map[string]string{
  2060. "foo": "hello",
  2061. })
  2062. defer ctx.Close()
  2063. if err != nil {
  2064. t.Fatal(err)
  2065. }
  2066. id1, err := buildImageFromContext(name, ctx, true)
  2067. if err != nil {
  2068. t.Fatal(err)
  2069. }
  2070. id2, err := buildImageFromContext(name2, ctx, false)
  2071. if err != nil {
  2072. t.Fatal(err)
  2073. }
  2074. if id1 == id2 {
  2075. t.Fatal("The cache should have been invalided but hasn't.")
  2076. }
  2077. logDone("build - add current directory without cache")
  2078. }
  2079. func TestBuildADDRemoteFileWithCache(t *testing.T) {
  2080. name := "testbuildaddremotefilewithcache"
  2081. defer deleteImages(name)
  2082. server, err := fakeStorage(map[string]string{
  2083. "baz": "hello",
  2084. })
  2085. if err != nil {
  2086. t.Fatal(err)
  2087. }
  2088. defer server.Close()
  2089. id1, err := buildImage(name,
  2090. fmt.Sprintf(`FROM scratch
  2091. MAINTAINER dockerio
  2092. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  2093. true)
  2094. if err != nil {
  2095. t.Fatal(err)
  2096. }
  2097. id2, err := buildImage(name,
  2098. fmt.Sprintf(`FROM scratch
  2099. MAINTAINER dockerio
  2100. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  2101. true)
  2102. if err != nil {
  2103. t.Fatal(err)
  2104. }
  2105. if id1 != id2 {
  2106. t.Fatal("The cache should have been used but hasn't.")
  2107. }
  2108. logDone("build - add remote file with cache")
  2109. }
  2110. func TestBuildADDRemoteFileWithoutCache(t *testing.T) {
  2111. name := "testbuildaddremotefilewithoutcache"
  2112. name2 := "testbuildaddremotefilewithoutcache2"
  2113. defer deleteImages(name, name2)
  2114. server, err := fakeStorage(map[string]string{
  2115. "baz": "hello",
  2116. })
  2117. if err != nil {
  2118. t.Fatal(err)
  2119. }
  2120. defer server.Close()
  2121. id1, err := buildImage(name,
  2122. fmt.Sprintf(`FROM scratch
  2123. MAINTAINER dockerio
  2124. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  2125. true)
  2126. if err != nil {
  2127. t.Fatal(err)
  2128. }
  2129. id2, err := buildImage(name2,
  2130. fmt.Sprintf(`FROM scratch
  2131. MAINTAINER dockerio
  2132. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  2133. false)
  2134. if err != nil {
  2135. t.Fatal(err)
  2136. }
  2137. if id1 == id2 {
  2138. t.Fatal("The cache should have been invalided but hasn't.")
  2139. }
  2140. logDone("build - add remote file without cache")
  2141. }
  2142. func TestBuildADDRemoteFileMTime(t *testing.T) {
  2143. name := "testbuildaddremotefilemtime"
  2144. name2 := name + "2"
  2145. name3 := name + "3"
  2146. name4 := name + "4"
  2147. defer deleteImages(name, name2, name3, name4)
  2148. server, err := fakeStorage(map[string]string{"baz": "hello"})
  2149. if err != nil {
  2150. t.Fatal(err)
  2151. }
  2152. defer server.Close()
  2153. ctx, err := fakeContext(fmt.Sprintf(`FROM scratch
  2154. MAINTAINER dockerio
  2155. ADD %s/baz /usr/lib/baz/quux`, server.URL), nil)
  2156. if err != nil {
  2157. t.Fatal(err)
  2158. }
  2159. defer ctx.Close()
  2160. id1, err := buildImageFromContext(name, ctx, true)
  2161. if err != nil {
  2162. t.Fatal(err)
  2163. }
  2164. id2, err := buildImageFromContext(name2, ctx, true)
  2165. if err != nil {
  2166. t.Fatal(err)
  2167. }
  2168. if id1 != id2 {
  2169. t.Fatal("The cache should have been used but wasn't - #1")
  2170. }
  2171. // Now set baz's times to anything else and redo the build
  2172. // This time the cache should not be used
  2173. bazPath := path.Join(server.FakeContext.Dir, "baz")
  2174. err = syscall.UtimesNano(bazPath, make([]syscall.Timespec, 2))
  2175. if err != nil {
  2176. t.Fatalf("Error setting mtime on %q: %v", bazPath, err)
  2177. }
  2178. id3, err := buildImageFromContext(name3, ctx, true)
  2179. if err != nil {
  2180. t.Fatal(err)
  2181. }
  2182. if id1 == id3 {
  2183. t.Fatal("The cache should not have been used but was")
  2184. }
  2185. // And for good measure do it again and make sure cache is used this time
  2186. id4, err := buildImageFromContext(name4, ctx, true)
  2187. if err != nil {
  2188. t.Fatal(err)
  2189. }
  2190. if id3 != id4 {
  2191. t.Fatal("The cache should have been used but wasn't - #2")
  2192. }
  2193. logDone("build - add remote file testing mtime")
  2194. }
  2195. func TestBuildADDLocalAndRemoteFilesWithCache(t *testing.T) {
  2196. name := "testbuildaddlocalandremotefilewithcache"
  2197. defer deleteImages(name)
  2198. server, err := fakeStorage(map[string]string{
  2199. "baz": "hello",
  2200. })
  2201. if err != nil {
  2202. t.Fatal(err)
  2203. }
  2204. defer server.Close()
  2205. ctx, err := fakeContext(fmt.Sprintf(`FROM scratch
  2206. MAINTAINER dockerio
  2207. ADD foo /usr/lib/bla/bar
  2208. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  2209. map[string]string{
  2210. "foo": "hello world",
  2211. })
  2212. if err != nil {
  2213. t.Fatal(err)
  2214. }
  2215. defer ctx.Close()
  2216. id1, err := buildImageFromContext(name, ctx, true)
  2217. if err != nil {
  2218. t.Fatal(err)
  2219. }
  2220. id2, err := buildImageFromContext(name, ctx, true)
  2221. if err != nil {
  2222. t.Fatal(err)
  2223. }
  2224. if id1 != id2 {
  2225. t.Fatal("The cache should have been used but hasn't.")
  2226. }
  2227. logDone("build - add local and remote file with cache")
  2228. }
  2229. func testContextTar(t *testing.T, compression archive.Compression) {
  2230. ctx, err := fakeContext(
  2231. `FROM busybox
  2232. ADD foo /foo
  2233. CMD ["cat", "/foo"]`,
  2234. map[string]string{
  2235. "foo": "bar",
  2236. },
  2237. )
  2238. defer ctx.Close()
  2239. if err != nil {
  2240. t.Fatal(err)
  2241. }
  2242. context, err := archive.Tar(ctx.Dir, compression)
  2243. if err != nil {
  2244. t.Fatalf("failed to build context tar: %v", err)
  2245. }
  2246. name := "contexttar"
  2247. buildCmd := exec.Command(dockerBinary, "build", "-t", name, "-")
  2248. defer deleteImages(name)
  2249. buildCmd.Stdin = context
  2250. if out, _, err := runCommandWithOutput(buildCmd); err != nil {
  2251. t.Fatalf("build failed to complete: %v %v", out, err)
  2252. }
  2253. logDone(fmt.Sprintf("build - build an image with a context tar, compression: %v", compression))
  2254. }
  2255. func TestBuildContextTarGzip(t *testing.T) {
  2256. testContextTar(t, archive.Gzip)
  2257. }
  2258. func TestBuildContextTarNoCompression(t *testing.T) {
  2259. testContextTar(t, archive.Uncompressed)
  2260. }
  2261. func TestBuildNoContext(t *testing.T) {
  2262. buildCmd := exec.Command(dockerBinary, "build", "-t", "nocontext", "-")
  2263. buildCmd.Stdin = strings.NewReader("FROM busybox\nCMD echo ok\n")
  2264. if out, _, err := runCommandWithOutput(buildCmd); err != nil {
  2265. t.Fatalf("build failed to complete: %v %v", out, err)
  2266. }
  2267. if out, _, err := dockerCmd(t, "run", "--rm", "nocontext"); out != "ok\n" || err != nil {
  2268. t.Fatalf("run produced invalid output: %q, expected %q", out, "ok")
  2269. }
  2270. deleteImages("nocontext")
  2271. logDone("build - build an image with no context")
  2272. }
  2273. // TODO: TestCaching
  2274. func TestBuildADDLocalAndRemoteFilesWithoutCache(t *testing.T) {
  2275. name := "testbuildaddlocalandremotefilewithoutcache"
  2276. name2 := "testbuildaddlocalandremotefilewithoutcache2"
  2277. defer deleteImages(name, name2)
  2278. server, err := fakeStorage(map[string]string{
  2279. "baz": "hello",
  2280. })
  2281. if err != nil {
  2282. t.Fatal(err)
  2283. }
  2284. defer server.Close()
  2285. ctx, err := fakeContext(fmt.Sprintf(`FROM scratch
  2286. MAINTAINER dockerio
  2287. ADD foo /usr/lib/bla/bar
  2288. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  2289. map[string]string{
  2290. "foo": "hello world",
  2291. })
  2292. if err != nil {
  2293. t.Fatal(err)
  2294. }
  2295. defer ctx.Close()
  2296. id1, err := buildImageFromContext(name, ctx, true)
  2297. if err != nil {
  2298. t.Fatal(err)
  2299. }
  2300. id2, err := buildImageFromContext(name2, ctx, false)
  2301. if err != nil {
  2302. t.Fatal(err)
  2303. }
  2304. if id1 == id2 {
  2305. t.Fatal("The cache should have been invalided but hasn't.")
  2306. }
  2307. logDone("build - add local and remote file without cache")
  2308. }
  2309. func TestBuildWithVolumeOwnership(t *testing.T) {
  2310. name := "testbuildimg"
  2311. defer deleteImages(name)
  2312. _, err := buildImage(name,
  2313. `FROM busybox:latest
  2314. RUN mkdir /test && chown daemon:daemon /test && chmod 0600 /test
  2315. VOLUME /test`,
  2316. true)
  2317. if err != nil {
  2318. t.Fatal(err)
  2319. }
  2320. cmd := exec.Command(dockerBinary, "run", "--rm", "testbuildimg", "ls", "-la", "/test")
  2321. out, _, err := runCommandWithOutput(cmd)
  2322. if err != nil {
  2323. t.Fatal(out, err)
  2324. }
  2325. if expected := "drw-------"; !strings.Contains(out, expected) {
  2326. t.Fatalf("expected %s received %s", expected, out)
  2327. }
  2328. if expected := "daemon daemon"; !strings.Contains(out, expected) {
  2329. t.Fatalf("expected %s received %s", expected, out)
  2330. }
  2331. logDone("build - volume ownership")
  2332. }
  2333. // testing #1405 - config.Cmd does not get cleaned up if
  2334. // utilizing cache
  2335. func TestBuildEntrypointRunCleanup(t *testing.T) {
  2336. name := "testbuildcmdcleanup"
  2337. defer deleteImages(name)
  2338. if _, err := buildImage(name,
  2339. `FROM busybox
  2340. RUN echo "hello"`,
  2341. true); err != nil {
  2342. t.Fatal(err)
  2343. }
  2344. ctx, err := fakeContext(`FROM busybox
  2345. RUN echo "hello"
  2346. ADD foo /foo
  2347. ENTRYPOINT ["/bin/echo"]`,
  2348. map[string]string{
  2349. "foo": "hello",
  2350. })
  2351. defer ctx.Close()
  2352. if err != nil {
  2353. t.Fatal(err)
  2354. }
  2355. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  2356. t.Fatal(err)
  2357. }
  2358. res, err := inspectField(name, "Config.Cmd")
  2359. if err != nil {
  2360. t.Fatal(err)
  2361. }
  2362. // Cmd must be cleaned up
  2363. if expected := "<no value>"; res != expected {
  2364. t.Fatalf("Cmd %s, expected %s", res, expected)
  2365. }
  2366. logDone("build - cleanup cmd after RUN")
  2367. }
  2368. func TestBuildForbiddenContextPath(t *testing.T) {
  2369. name := "testbuildforbidpath"
  2370. defer deleteImages(name)
  2371. ctx, err := fakeContext(`FROM scratch
  2372. ADD ../../ test/
  2373. `,
  2374. map[string]string{
  2375. "test.txt": "test1",
  2376. "other.txt": "other",
  2377. })
  2378. defer ctx.Close()
  2379. if err != nil {
  2380. t.Fatal(err)
  2381. }
  2382. expected := "Forbidden path outside the build context: ../../ "
  2383. if _, err := buildImageFromContext(name, ctx, true); err == nil || !strings.Contains(err.Error(), expected) {
  2384. t.Fatalf("Wrong error: (should contain \"%s\") got:\n%v", expected, err)
  2385. }
  2386. logDone("build - forbidden context path")
  2387. }
  2388. func TestBuildADDFileNotFound(t *testing.T) {
  2389. name := "testbuildaddnotfound"
  2390. defer deleteImages(name)
  2391. ctx, err := fakeContext(`FROM scratch
  2392. ADD foo /usr/local/bar`,
  2393. map[string]string{"bar": "hello"})
  2394. defer ctx.Close()
  2395. if err != nil {
  2396. t.Fatal(err)
  2397. }
  2398. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  2399. if !strings.Contains(err.Error(), "foo: no such file or directory") {
  2400. t.Fatalf("Wrong error %v, must be about missing foo file or directory", err)
  2401. }
  2402. } else {
  2403. t.Fatal("Error must not be nil")
  2404. }
  2405. logDone("build - add file not found")
  2406. }
  2407. func TestBuildInheritance(t *testing.T) {
  2408. name := "testbuildinheritance"
  2409. defer deleteImages(name)
  2410. _, err := buildImage(name,
  2411. `FROM scratch
  2412. EXPOSE 2375`,
  2413. true)
  2414. if err != nil {
  2415. t.Fatal(err)
  2416. }
  2417. ports1, err := inspectField(name, "Config.ExposedPorts")
  2418. if err != nil {
  2419. t.Fatal(err)
  2420. }
  2421. _, err = buildImage(name,
  2422. fmt.Sprintf(`FROM %s
  2423. ENTRYPOINT ["/bin/echo"]`, name),
  2424. true)
  2425. if err != nil {
  2426. t.Fatal(err)
  2427. }
  2428. res, err := inspectField(name, "Config.Entrypoint")
  2429. if err != nil {
  2430. t.Fatal(err)
  2431. }
  2432. if expected := "[/bin/echo]"; res != expected {
  2433. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  2434. }
  2435. ports2, err := inspectField(name, "Config.ExposedPorts")
  2436. if err != nil {
  2437. t.Fatal(err)
  2438. }
  2439. if ports1 != ports2 {
  2440. t.Fatalf("Ports must be same: %s != %s", ports1, ports2)
  2441. }
  2442. logDone("build - inheritance")
  2443. }
  2444. func TestBuildFails(t *testing.T) {
  2445. name := "testbuildfails"
  2446. defer deleteImages(name)
  2447. defer deleteAllContainers()
  2448. _, err := buildImage(name,
  2449. `FROM busybox
  2450. RUN sh -c "exit 23"`,
  2451. true)
  2452. if err != nil {
  2453. if !strings.Contains(err.Error(), "returned a non-zero code: 23") {
  2454. t.Fatalf("Wrong error %v, must be about non-zero code 23", err)
  2455. }
  2456. } else {
  2457. t.Fatal("Error must not be nil")
  2458. }
  2459. logDone("build - fails")
  2460. }
  2461. func TestBuildFailsDockerfileEmpty(t *testing.T) {
  2462. name := "testbuildfails"
  2463. defer deleteImages(name)
  2464. _, err := buildImage(name, ``, true)
  2465. if err != nil {
  2466. if !strings.Contains(err.Error(), "Dockerfile cannot be empty") {
  2467. t.Fatalf("Wrong error %v, must be about empty Dockerfile", err)
  2468. }
  2469. } else {
  2470. t.Fatal("Error must not be nil")
  2471. }
  2472. logDone("build - fails with empty dockerfile")
  2473. }
  2474. func TestBuildOnBuild(t *testing.T) {
  2475. name := "testbuildonbuild"
  2476. defer deleteImages(name)
  2477. _, err := buildImage(name,
  2478. `FROM busybox
  2479. ONBUILD RUN touch foobar`,
  2480. true)
  2481. if err != nil {
  2482. t.Fatal(err)
  2483. }
  2484. _, err = buildImage(name,
  2485. fmt.Sprintf(`FROM %s
  2486. RUN [ -f foobar ]`, name),
  2487. true)
  2488. if err != nil {
  2489. t.Fatal(err)
  2490. }
  2491. logDone("build - onbuild")
  2492. }
  2493. func TestBuildOnBuildForbiddenChained(t *testing.T) {
  2494. name := "testbuildonbuildforbiddenchained"
  2495. defer deleteImages(name)
  2496. _, err := buildImage(name,
  2497. `FROM busybox
  2498. ONBUILD ONBUILD RUN touch foobar`,
  2499. true)
  2500. if err != nil {
  2501. if !strings.Contains(err.Error(), "Chaining ONBUILD via `ONBUILD ONBUILD` isn't allowed") {
  2502. t.Fatalf("Wrong error %v, must be about chaining ONBUILD", err)
  2503. }
  2504. } else {
  2505. t.Fatal("Error must not be nil")
  2506. }
  2507. logDone("build - onbuild forbidden chained")
  2508. }
  2509. func TestBuildOnBuildForbiddenFrom(t *testing.T) {
  2510. name := "testbuildonbuildforbiddenfrom"
  2511. defer deleteImages(name)
  2512. _, err := buildImage(name,
  2513. `FROM busybox
  2514. ONBUILD FROM scratch`,
  2515. true)
  2516. if err != nil {
  2517. if !strings.Contains(err.Error(), "FROM isn't allowed as an ONBUILD trigger") {
  2518. t.Fatalf("Wrong error %v, must be about FROM forbidden", err)
  2519. }
  2520. } else {
  2521. t.Fatal("Error must not be nil")
  2522. }
  2523. logDone("build - onbuild forbidden from")
  2524. }
  2525. func TestBuildOnBuildForbiddenMaintainer(t *testing.T) {
  2526. name := "testbuildonbuildforbiddenmaintainer"
  2527. defer deleteImages(name)
  2528. _, err := buildImage(name,
  2529. `FROM busybox
  2530. ONBUILD MAINTAINER docker.io`,
  2531. true)
  2532. if err != nil {
  2533. if !strings.Contains(err.Error(), "MAINTAINER isn't allowed as an ONBUILD trigger") {
  2534. t.Fatalf("Wrong error %v, must be about MAINTAINER forbidden", err)
  2535. }
  2536. } else {
  2537. t.Fatal("Error must not be nil")
  2538. }
  2539. logDone("build - onbuild forbidden maintainer")
  2540. }
  2541. // gh #2446
  2542. func TestBuildAddToSymlinkDest(t *testing.T) {
  2543. name := "testbuildaddtosymlinkdest"
  2544. defer deleteImages(name)
  2545. ctx, err := fakeContext(`FROM busybox
  2546. RUN mkdir /foo
  2547. RUN ln -s /foo /bar
  2548. ADD foo /bar/
  2549. RUN [ -f /bar/foo ]
  2550. RUN [ -f /foo/foo ]`,
  2551. map[string]string{
  2552. "foo": "hello",
  2553. })
  2554. if err != nil {
  2555. t.Fatal(err)
  2556. }
  2557. defer ctx.Close()
  2558. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  2559. t.Fatal(err)
  2560. }
  2561. logDone("build - add to symlink destination")
  2562. }
  2563. func TestBuildEscapeWhitespace(t *testing.T) {
  2564. name := "testbuildescaping"
  2565. defer deleteImages(name)
  2566. _, err := buildImage(name, `
  2567. FROM busybox
  2568. MAINTAINER "Docker \
  2569. IO <io@\
  2570. docker.com>"
  2571. `, true)
  2572. res, err := inspectField(name, "Author")
  2573. if err != nil {
  2574. t.Fatal(err)
  2575. }
  2576. if res != "Docker IO <io@docker.com>" {
  2577. t.Fatal("Parsed string did not match the escaped string")
  2578. }
  2579. logDone("build - validate escaping whitespace")
  2580. }
  2581. func TestBuildDockerignore(t *testing.T) {
  2582. name := "testbuilddockerignore"
  2583. defer deleteImages(name)
  2584. dockerfile := `
  2585. FROM busybox
  2586. ADD . /bla
  2587. RUN [[ -f /bla/src/x.go ]]
  2588. RUN [[ -f /bla/Makefile ]]
  2589. RUN [[ ! -e /bla/src/_vendor ]]
  2590. RUN [[ ! -e /bla/.gitignore ]]
  2591. RUN [[ ! -e /bla/README.md ]]
  2592. RUN [[ ! -e /bla/.git ]]`
  2593. ctx, err := fakeContext(dockerfile, map[string]string{
  2594. "Makefile": "all:",
  2595. ".git/HEAD": "ref: foo",
  2596. "src/x.go": "package main",
  2597. "src/_vendor/v.go": "package main",
  2598. ".gitignore": "",
  2599. "README.md": "readme",
  2600. ".dockerignore": ".git\npkg\n.gitignore\nsrc/_vendor\n*.md",
  2601. })
  2602. defer ctx.Close()
  2603. if err != nil {
  2604. t.Fatal(err)
  2605. }
  2606. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  2607. t.Fatal(err)
  2608. }
  2609. logDone("build - test .dockerignore")
  2610. }
  2611. func TestBuildDockerignoreCleanPaths(t *testing.T) {
  2612. name := "testbuilddockerignorecleanpaths"
  2613. defer deleteImages(name)
  2614. dockerfile := `
  2615. FROM busybox
  2616. ADD . /tmp/
  2617. RUN (! ls /tmp/foo) && (! ls /tmp/foo2) && (! ls /tmp/dir1/foo)`
  2618. ctx, err := fakeContext(dockerfile, map[string]string{
  2619. "foo": "foo",
  2620. "foo2": "foo2",
  2621. "dir1/foo": "foo in dir1",
  2622. ".dockerignore": "./foo\ndir1//foo\n./dir1/../foo2",
  2623. })
  2624. if err != nil {
  2625. t.Fatal(err)
  2626. }
  2627. defer ctx.Close()
  2628. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  2629. t.Fatal(err)
  2630. }
  2631. logDone("build - test .dockerignore with clean paths")
  2632. }
  2633. func TestBuildDockerignoringDockerfile(t *testing.T) {
  2634. name := "testbuilddockerignoredockerfile"
  2635. defer deleteImages(name)
  2636. dockerfile := `
  2637. FROM scratch`
  2638. ctx, err := fakeContext(dockerfile, map[string]string{
  2639. "Dockerfile": "FROM scratch",
  2640. ".dockerignore": "Dockerfile\n",
  2641. })
  2642. if err != nil {
  2643. t.Fatal(err)
  2644. }
  2645. defer ctx.Close()
  2646. if _, err = buildImageFromContext(name, ctx, true); err == nil {
  2647. t.Fatalf("Didn't get expected error from ignoring Dockerfile")
  2648. }
  2649. // now try it with ./Dockerfile
  2650. ctx.Add(".dockerignore", "./Dockerfile\n")
  2651. if _, err = buildImageFromContext(name, ctx, true); err == nil {
  2652. t.Fatalf("Didn't get expected error from ignoring ./Dockerfile")
  2653. }
  2654. logDone("build - test .dockerignore of Dockerfile")
  2655. }
  2656. func TestBuildDockerignoringWholeDir(t *testing.T) {
  2657. name := "testbuilddockerignorewholedir"
  2658. defer deleteImages(name)
  2659. dockerfile := `
  2660. FROM busybox
  2661. COPY . /
  2662. RUN [[ ! -e /.gitignore ]]
  2663. RUN [[ -f /Makefile ]]`
  2664. ctx, err := fakeContext(dockerfile, map[string]string{
  2665. "Dockerfile": "FROM scratch",
  2666. "Makefile": "all:",
  2667. ".dockerignore": ".*\n",
  2668. })
  2669. defer ctx.Close()
  2670. if err != nil {
  2671. t.Fatal(err)
  2672. }
  2673. if _, err = buildImageFromContext(name, ctx, true); err != nil {
  2674. t.Fatal(err)
  2675. }
  2676. logDone("build - test .dockerignore whole dir with .*")
  2677. }
  2678. func TestBuildLineBreak(t *testing.T) {
  2679. name := "testbuildlinebreak"
  2680. defer deleteImages(name)
  2681. _, err := buildImage(name,
  2682. `FROM busybox
  2683. RUN sh -c 'echo root:testpass \
  2684. > /tmp/passwd'
  2685. RUN mkdir -p /var/run/sshd
  2686. RUN [ "$(cat /tmp/passwd)" = "root:testpass" ]
  2687. RUN [ "$(ls -d /var/run/sshd)" = "/var/run/sshd" ]`,
  2688. true)
  2689. if err != nil {
  2690. t.Fatal(err)
  2691. }
  2692. logDone("build - line break with \\")
  2693. }
  2694. func TestBuildEOLInLine(t *testing.T) {
  2695. name := "testbuildeolinline"
  2696. defer deleteImages(name)
  2697. _, err := buildImage(name,
  2698. `FROM busybox
  2699. RUN sh -c 'echo root:testpass > /tmp/passwd'
  2700. RUN echo "foo \n bar"; echo "baz"
  2701. RUN mkdir -p /var/run/sshd
  2702. RUN [ "$(cat /tmp/passwd)" = "root:testpass" ]
  2703. RUN [ "$(ls -d /var/run/sshd)" = "/var/run/sshd" ]`,
  2704. true)
  2705. if err != nil {
  2706. t.Fatal(err)
  2707. }
  2708. logDone("build - end of line in dockerfile instruction")
  2709. }
  2710. func TestBuildCommentsShebangs(t *testing.T) {
  2711. name := "testbuildcomments"
  2712. defer deleteImages(name)
  2713. _, err := buildImage(name,
  2714. `FROM busybox
  2715. # This is an ordinary comment.
  2716. RUN { echo '#!/bin/sh'; echo 'echo hello world'; } > /hello.sh
  2717. RUN [ ! -x /hello.sh ]
  2718. # comment with line break \
  2719. RUN chmod +x /hello.sh
  2720. RUN [ -x /hello.sh ]
  2721. RUN [ "$(cat /hello.sh)" = $'#!/bin/sh\necho hello world' ]
  2722. RUN [ "$(/hello.sh)" = "hello world" ]`,
  2723. true)
  2724. if err != nil {
  2725. t.Fatal(err)
  2726. }
  2727. logDone("build - comments and shebangs")
  2728. }
  2729. func TestBuildUsersAndGroups(t *testing.T) {
  2730. name := "testbuildusers"
  2731. defer deleteImages(name)
  2732. _, err := buildImage(name,
  2733. `FROM busybox
  2734. # Make sure our defaults work
  2735. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)" = '0:0/root:root' ]
  2736. # TODO decide if "args.user = strconv.Itoa(syscall.Getuid())" is acceptable behavior for changeUser in sysvinit instead of "return nil" when "USER" isn't specified (so that we get the proper group list even if that is the empty list, even in the default case of not supplying an explicit USER to run as, which implies USER 0)
  2737. USER root
  2738. RUN [ "$(id -G):$(id -Gn)" = '0 10:root wheel' ]
  2739. # Setup dockerio user and group
  2740. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  2741. RUN echo 'dockerio:x:1001:' >> /etc/group
  2742. # Make sure we can switch to our user and all the information is exactly as we expect it to be
  2743. USER dockerio
  2744. RUN id -G
  2745. RUN id -Gn
  2746. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  2747. # Switch back to root and double check that worked exactly as we might expect it to
  2748. USER root
  2749. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '0:0/root:root/0 10:root wheel' ]
  2750. # Add a "supplementary" group for our dockerio user
  2751. RUN echo 'supplementary:x:1002:dockerio' >> /etc/group
  2752. # ... and then go verify that we get it like we expect
  2753. USER dockerio
  2754. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001 1002:dockerio supplementary' ]
  2755. USER 1001
  2756. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001 1002:dockerio supplementary' ]
  2757. # super test the new "user:group" syntax
  2758. USER dockerio:dockerio
  2759. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  2760. USER 1001:dockerio
  2761. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  2762. USER dockerio:1001
  2763. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  2764. USER 1001:1001
  2765. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  2766. USER dockerio:supplementary
  2767. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1002/dockerio:supplementary/1002:supplementary' ]
  2768. USER dockerio:1002
  2769. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1002/dockerio:supplementary/1002:supplementary' ]
  2770. USER 1001:supplementary
  2771. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1002/dockerio:supplementary/1002:supplementary' ]
  2772. USER 1001:1002
  2773. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1002/dockerio:supplementary/1002:supplementary' ]
  2774. # make sure unknown uid/gid still works properly
  2775. USER 1042:1043
  2776. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1042:1043/1042:1043/1043:1043' ]`,
  2777. true)
  2778. if err != nil {
  2779. t.Fatal(err)
  2780. }
  2781. logDone("build - users and groups")
  2782. }
  2783. func TestBuildEnvUsage(t *testing.T) {
  2784. name := "testbuildenvusage"
  2785. defer deleteImages(name)
  2786. dockerfile := `FROM busybox
  2787. ENV HOME /root
  2788. ENV PATH $HOME/bin:$PATH
  2789. ENV PATH /tmp:$PATH
  2790. RUN [ "$PATH" = "/tmp:$HOME/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" ]
  2791. ENV FOO /foo/baz
  2792. ENV BAR /bar
  2793. ENV BAZ $BAR
  2794. ENV FOOPATH $PATH:$FOO
  2795. RUN [ "$BAR" = "$BAZ" ]
  2796. RUN [ "$FOOPATH" = "$PATH:/foo/baz" ]
  2797. ENV FROM hello/docker/world
  2798. ENV TO /docker/world/hello
  2799. ADD $FROM $TO
  2800. RUN [ "$(cat $TO)" = "hello" ]
  2801. `
  2802. ctx, err := fakeContext(dockerfile, map[string]string{
  2803. "hello/docker/world": "hello",
  2804. })
  2805. if err != nil {
  2806. t.Fatal(err)
  2807. }
  2808. defer ctx.Close()
  2809. _, err = buildImageFromContext(name, ctx, true)
  2810. if err != nil {
  2811. t.Fatal(err)
  2812. }
  2813. logDone("build - environment variables usage")
  2814. }
  2815. func TestBuildEnvUsage2(t *testing.T) {
  2816. name := "testbuildenvusage2"
  2817. defer deleteImages(name)
  2818. dockerfile := `FROM busybox
  2819. ENV abc=def
  2820. RUN [ "$abc" = "def" ]
  2821. ENV def="hello world"
  2822. RUN [ "$def" = "hello world" ]
  2823. ENV def=hello\ world
  2824. RUN [ "$def" = "hello world" ]
  2825. ENV v1=abc v2="hi there"
  2826. RUN [ "$v1" = "abc" ]
  2827. RUN [ "$v2" = "hi there" ]
  2828. ENV v3='boogie nights' v4="with'quotes too"
  2829. RUN [ "$v3" = "boogie nights" ]
  2830. RUN [ "$v4" = "with'quotes too" ]
  2831. ENV abc=zzz FROM=hello/docker/world
  2832. ENV abc=zzz TO=/docker/world/hello
  2833. ADD $FROM $TO
  2834. RUN [ "$(cat $TO)" = "hello" ]
  2835. ENV abc "zzz"
  2836. RUN [ $abc = \"zzz\" ]
  2837. ENV abc 'yyy'
  2838. RUN [ $abc = \'yyy\' ]
  2839. ENV abc=
  2840. RUN [ "$abc" = "" ]
  2841. `
  2842. ctx, err := fakeContext(dockerfile, map[string]string{
  2843. "hello/docker/world": "hello",
  2844. })
  2845. if err != nil {
  2846. t.Fatal(err)
  2847. }
  2848. _, err = buildImageFromContext(name, ctx, true)
  2849. if err != nil {
  2850. t.Fatal(err)
  2851. }
  2852. logDone("build - environment variables usage2")
  2853. }
  2854. func TestBuildAddScript(t *testing.T) {
  2855. name := "testbuildaddscript"
  2856. defer deleteImages(name)
  2857. dockerfile := `
  2858. FROM busybox
  2859. ADD test /test
  2860. RUN ["chmod","+x","/test"]
  2861. RUN ["/test"]
  2862. RUN [ "$(cat /testfile)" = 'test!' ]`
  2863. ctx, err := fakeContext(dockerfile, map[string]string{
  2864. "test": "#!/bin/sh\necho 'test!' > /testfile",
  2865. })
  2866. if err != nil {
  2867. t.Fatal(err)
  2868. }
  2869. defer ctx.Close()
  2870. _, err = buildImageFromContext(name, ctx, true)
  2871. if err != nil {
  2872. t.Fatal(err)
  2873. }
  2874. logDone("build - add and run script")
  2875. }
  2876. func TestBuildAddTar(t *testing.T) {
  2877. name := "testbuildaddtar"
  2878. defer deleteImages(name)
  2879. ctx := func() *FakeContext {
  2880. dockerfile := `
  2881. FROM busybox
  2882. ADD test.tar /
  2883. RUN cat /test/foo | grep Hi
  2884. ADD test.tar /test.tar
  2885. RUN cat /test.tar/test/foo | grep Hi
  2886. ADD test.tar /unlikely-to-exist
  2887. RUN cat /unlikely-to-exist/test/foo | grep Hi
  2888. ADD test.tar /unlikely-to-exist-trailing-slash/
  2889. RUN cat /unlikely-to-exist-trailing-slash/test/foo | grep Hi
  2890. RUN mkdir /existing-directory
  2891. ADD test.tar /existing-directory
  2892. RUN cat /existing-directory/test/foo | grep Hi
  2893. ADD test.tar /existing-directory-trailing-slash/
  2894. RUN cat /existing-directory-trailing-slash/test/foo | grep Hi`
  2895. tmpDir, err := ioutil.TempDir("", "fake-context")
  2896. testTar, err := os.Create(filepath.Join(tmpDir, "test.tar"))
  2897. if err != nil {
  2898. t.Fatalf("failed to create test.tar archive: %v", err)
  2899. }
  2900. defer testTar.Close()
  2901. tw := tar.NewWriter(testTar)
  2902. if err := tw.WriteHeader(&tar.Header{
  2903. Name: "test/foo",
  2904. Size: 2,
  2905. }); err != nil {
  2906. t.Fatalf("failed to write tar file header: %v", err)
  2907. }
  2908. if _, err := tw.Write([]byte("Hi")); err != nil {
  2909. t.Fatalf("failed to write tar file content: %v", err)
  2910. }
  2911. if err := tw.Close(); err != nil {
  2912. t.Fatalf("failed to close tar archive: %v", err)
  2913. }
  2914. if err := ioutil.WriteFile(filepath.Join(tmpDir, "Dockerfile"), []byte(dockerfile), 0644); err != nil {
  2915. t.Fatalf("failed to open destination dockerfile: %v", err)
  2916. }
  2917. return &FakeContext{Dir: tmpDir}
  2918. }()
  2919. defer ctx.Close()
  2920. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  2921. t.Fatalf("build failed to complete for TestBuildAddTar: %v", err)
  2922. }
  2923. logDone("build - ADD tar")
  2924. }
  2925. func TestBuildAddTarXz(t *testing.T) {
  2926. name := "testbuildaddtarxz"
  2927. defer deleteImages(name)
  2928. ctx := func() *FakeContext {
  2929. dockerfile := `
  2930. FROM busybox
  2931. ADD test.tar.xz /
  2932. RUN cat /test/foo | grep Hi`
  2933. tmpDir, err := ioutil.TempDir("", "fake-context")
  2934. testTar, err := os.Create(filepath.Join(tmpDir, "test.tar"))
  2935. if err != nil {
  2936. t.Fatalf("failed to create test.tar archive: %v", err)
  2937. }
  2938. defer testTar.Close()
  2939. tw := tar.NewWriter(testTar)
  2940. if err := tw.WriteHeader(&tar.Header{
  2941. Name: "test/foo",
  2942. Size: 2,
  2943. }); err != nil {
  2944. t.Fatalf("failed to write tar file header: %v", err)
  2945. }
  2946. if _, err := tw.Write([]byte("Hi")); err != nil {
  2947. t.Fatalf("failed to write tar file content: %v", err)
  2948. }
  2949. if err := tw.Close(); err != nil {
  2950. t.Fatalf("failed to close tar archive: %v", err)
  2951. }
  2952. xzCompressCmd := exec.Command("xz", "test.tar")
  2953. xzCompressCmd.Dir = tmpDir
  2954. out, _, err := runCommandWithOutput(xzCompressCmd)
  2955. if err != nil {
  2956. t.Fatal(err, out)
  2957. }
  2958. if err := ioutil.WriteFile(filepath.Join(tmpDir, "Dockerfile"), []byte(dockerfile), 0644); err != nil {
  2959. t.Fatalf("failed to open destination dockerfile: %v", err)
  2960. }
  2961. return &FakeContext{Dir: tmpDir}
  2962. }()
  2963. defer ctx.Close()
  2964. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  2965. t.Fatalf("build failed to complete for TestBuildAddTarXz: %v", err)
  2966. }
  2967. logDone("build - ADD tar.xz")
  2968. }
  2969. func TestBuildAddTarXzGz(t *testing.T) {
  2970. name := "testbuildaddtarxzgz"
  2971. defer deleteImages(name)
  2972. ctx := func() *FakeContext {
  2973. dockerfile := `
  2974. FROM busybox
  2975. ADD test.tar.xz.gz /
  2976. RUN ls /test.tar.xz.gz`
  2977. tmpDir, err := ioutil.TempDir("", "fake-context")
  2978. testTar, err := os.Create(filepath.Join(tmpDir, "test.tar"))
  2979. if err != nil {
  2980. t.Fatalf("failed to create test.tar archive: %v", err)
  2981. }
  2982. defer testTar.Close()
  2983. tw := tar.NewWriter(testTar)
  2984. if err := tw.WriteHeader(&tar.Header{
  2985. Name: "test/foo",
  2986. Size: 2,
  2987. }); err != nil {
  2988. t.Fatalf("failed to write tar file header: %v", err)
  2989. }
  2990. if _, err := tw.Write([]byte("Hi")); err != nil {
  2991. t.Fatalf("failed to write tar file content: %v", err)
  2992. }
  2993. if err := tw.Close(); err != nil {
  2994. t.Fatalf("failed to close tar archive: %v", err)
  2995. }
  2996. xzCompressCmd := exec.Command("xz", "test.tar")
  2997. xzCompressCmd.Dir = tmpDir
  2998. out, _, err := runCommandWithOutput(xzCompressCmd)
  2999. if err != nil {
  3000. t.Fatal(err, out)
  3001. }
  3002. gzipCompressCmd := exec.Command("gzip", "test.tar.xz")
  3003. gzipCompressCmd.Dir = tmpDir
  3004. out, _, err = runCommandWithOutput(gzipCompressCmd)
  3005. if err != nil {
  3006. t.Fatal(err, out)
  3007. }
  3008. if err := ioutil.WriteFile(filepath.Join(tmpDir, "Dockerfile"), []byte(dockerfile), 0644); err != nil {
  3009. t.Fatalf("failed to open destination dockerfile: %v", err)
  3010. }
  3011. return &FakeContext{Dir: tmpDir}
  3012. }()
  3013. defer ctx.Close()
  3014. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  3015. t.Fatalf("build failed to complete for TestBuildAddTarXz: %v", err)
  3016. }
  3017. logDone("build - ADD tar.xz.gz")
  3018. }
  3019. func TestBuildFromGIT(t *testing.T) {
  3020. name := "testbuildfromgit"
  3021. defer deleteImages(name)
  3022. git, err := fakeGIT("repo", map[string]string{
  3023. "Dockerfile": `FROM busybox
  3024. ADD first /first
  3025. RUN [ -f /first ]
  3026. MAINTAINER docker`,
  3027. "first": "test git data",
  3028. })
  3029. if err != nil {
  3030. t.Fatal(err)
  3031. }
  3032. defer git.Close()
  3033. _, err = buildImageFromPath(name, git.RepoURL, true)
  3034. if err != nil {
  3035. t.Fatal(err)
  3036. }
  3037. res, err := inspectField(name, "Author")
  3038. if err != nil {
  3039. t.Fatal(err)
  3040. }
  3041. if res != "docker" {
  3042. t.Fatalf("Maintainer should be docker, got %s", res)
  3043. }
  3044. logDone("build - build from GIT")
  3045. }
  3046. func TestBuildCleanupCmdOnEntrypoint(t *testing.T) {
  3047. name := "testbuildcmdcleanuponentrypoint"
  3048. defer deleteImages(name)
  3049. if _, err := buildImage(name,
  3050. `FROM scratch
  3051. CMD ["test"]
  3052. ENTRYPOINT ["echo"]`,
  3053. true); err != nil {
  3054. t.Fatal(err)
  3055. }
  3056. if _, err := buildImage(name,
  3057. fmt.Sprintf(`FROM %s
  3058. ENTRYPOINT ["cat"]`, name),
  3059. true); err != nil {
  3060. t.Fatal(err)
  3061. }
  3062. res, err := inspectField(name, "Config.Cmd")
  3063. if err != nil {
  3064. t.Fatal(err)
  3065. }
  3066. if expected := "<no value>"; res != expected {
  3067. t.Fatalf("Cmd %s, expected %s", res, expected)
  3068. }
  3069. res, err = inspectField(name, "Config.Entrypoint")
  3070. if err != nil {
  3071. t.Fatal(err)
  3072. }
  3073. if expected := "[cat]"; res != expected {
  3074. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  3075. }
  3076. logDone("build - cleanup cmd on ENTRYPOINT")
  3077. }
  3078. func TestBuildClearCmd(t *testing.T) {
  3079. name := "testbuildclearcmd"
  3080. defer deleteImages(name)
  3081. _, err := buildImage(name,
  3082. `From scratch
  3083. ENTRYPOINT ["/bin/bash"]
  3084. CMD []`,
  3085. true)
  3086. if err != nil {
  3087. t.Fatal(err)
  3088. }
  3089. res, err := inspectFieldJSON(name, "Config.Cmd")
  3090. if err != nil {
  3091. t.Fatal(err)
  3092. }
  3093. if res != "[]" {
  3094. t.Fatalf("Cmd %s, expected %s", res, "[]")
  3095. }
  3096. logDone("build - clearcmd")
  3097. }
  3098. func TestBuildEmptyCmd(t *testing.T) {
  3099. name := "testbuildemptycmd"
  3100. defer deleteImages(name)
  3101. if _, err := buildImage(name, "FROM scratch\nMAINTAINER quux\n", true); err != nil {
  3102. t.Fatal(err)
  3103. }
  3104. res, err := inspectFieldJSON(name, "Config.Cmd")
  3105. if err != nil {
  3106. t.Fatal(err)
  3107. }
  3108. if res != "null" {
  3109. t.Fatalf("Cmd %s, expected %s", res, "null")
  3110. }
  3111. logDone("build - empty cmd")
  3112. }
  3113. func TestBuildOnBuildOutput(t *testing.T) {
  3114. name := "testbuildonbuildparent"
  3115. defer deleteImages(name)
  3116. if _, err := buildImage(name, "FROM busybox\nONBUILD RUN echo foo\n", true); err != nil {
  3117. t.Fatal(err)
  3118. }
  3119. childname := "testbuildonbuildchild"
  3120. defer deleteImages(childname)
  3121. _, out, err := buildImageWithOut(name, "FROM "+name+"\nMAINTAINER quux\n", true)
  3122. if err != nil {
  3123. t.Fatal(err)
  3124. }
  3125. if !strings.Contains(out, "Trigger 0, RUN echo foo") {
  3126. t.Fatal("failed to find the ONBUILD output", out)
  3127. }
  3128. logDone("build - onbuild output")
  3129. }
  3130. func TestBuildInvalidTag(t *testing.T) {
  3131. name := "abcd:" + makeRandomString(200)
  3132. defer deleteImages(name)
  3133. _, out, err := buildImageWithOut(name, "FROM scratch\nMAINTAINER quux\n", true)
  3134. // if the error doesnt check for illegal tag name, or the image is built
  3135. // then this should fail
  3136. if !strings.Contains(out, "Illegal tag name") || strings.Contains(out, "Sending build context to Docker daemon") {
  3137. t.Fatalf("failed to stop before building. Error: %s, Output: %s", err, out)
  3138. }
  3139. logDone("build - invalid tag")
  3140. }
  3141. func TestBuildCmdShDashC(t *testing.T) {
  3142. name := "testbuildcmdshc"
  3143. defer deleteImages(name)
  3144. if _, err := buildImage(name, "FROM busybox\nCMD echo cmd\n", true); err != nil {
  3145. t.Fatal(err)
  3146. }
  3147. res, err := inspectFieldJSON(name, "Config.Cmd")
  3148. if err != nil {
  3149. t.Fatal(err, res)
  3150. }
  3151. expected := `["/bin/sh","-c","echo cmd"]`
  3152. if res != expected {
  3153. t.Fatalf("Expected value %s not in Config.Cmd: %s", expected, res)
  3154. }
  3155. logDone("build - cmd should have sh -c for non-json")
  3156. }
  3157. func TestBuildCmdJSONNoShDashC(t *testing.T) {
  3158. name := "testbuildcmdjson"
  3159. defer deleteImages(name)
  3160. if _, err := buildImage(name, "FROM busybox\nCMD [\"echo\", \"cmd\"]", true); err != nil {
  3161. t.Fatal(err)
  3162. }
  3163. res, err := inspectFieldJSON(name, "Config.Cmd")
  3164. if err != nil {
  3165. t.Fatal(err, res)
  3166. }
  3167. expected := `["echo","cmd"]`
  3168. if res != expected {
  3169. t.Fatalf("Expected value %s not in Config.Cmd: %s", expected, res)
  3170. }
  3171. logDone("build - cmd should not have /bin/sh -c for json")
  3172. }
  3173. func TestBuildIgnoreInvalidInstruction(t *testing.T) {
  3174. name := "testbuildignoreinvalidinstruction"
  3175. defer deleteImages(name)
  3176. out, _, err := buildImageWithOut(name, "FROM busybox\nfoo bar", true)
  3177. if err != nil {
  3178. t.Fatal(err, out)
  3179. }
  3180. logDone("build - ignore invalid Dockerfile instruction")
  3181. }
  3182. func TestBuildEntrypointInheritance(t *testing.T) {
  3183. defer deleteImages("parent", "child")
  3184. defer deleteAllContainers()
  3185. if _, err := buildImage("parent", `
  3186. FROM busybox
  3187. ENTRYPOINT exit 130
  3188. `, true); err != nil {
  3189. t.Fatal(err)
  3190. }
  3191. status, _ := runCommand(exec.Command(dockerBinary, "run", "parent"))
  3192. if status != 130 {
  3193. t.Fatalf("expected exit code 130 but received %d", status)
  3194. }
  3195. if _, err := buildImage("child", `
  3196. FROM parent
  3197. ENTRYPOINT exit 5
  3198. `, true); err != nil {
  3199. t.Fatal(err)
  3200. }
  3201. status, _ = runCommand(exec.Command(dockerBinary, "run", "child"))
  3202. if status != 5 {
  3203. t.Fatalf("expected exit code 5 but received %d", status)
  3204. }
  3205. logDone("build - clear entrypoint")
  3206. }
  3207. func TestBuildEntrypointInheritanceInspect(t *testing.T) {
  3208. var (
  3209. name = "testbuildepinherit"
  3210. name2 = "testbuildepinherit2"
  3211. expected = `["/bin/sh","-c","echo quux"]`
  3212. )
  3213. defer deleteImages(name, name2)
  3214. defer deleteAllContainers()
  3215. if _, err := buildImage(name, "FROM busybox\nENTRYPOINT /foo/bar", true); err != nil {
  3216. t.Fatal(err)
  3217. }
  3218. if _, err := buildImage(name2, fmt.Sprintf("FROM %s\nENTRYPOINT echo quux", name), true); err != nil {
  3219. t.Fatal(err)
  3220. }
  3221. res, err := inspectFieldJSON(name2, "Config.Entrypoint")
  3222. if err != nil {
  3223. t.Fatal(err, res)
  3224. }
  3225. if res != expected {
  3226. t.Fatalf("Expected value %s not in Config.Entrypoint: %s", expected, res)
  3227. }
  3228. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "-t", name2))
  3229. if err != nil {
  3230. t.Fatal(err, out)
  3231. }
  3232. expected = "quux"
  3233. if strings.TrimSpace(out) != expected {
  3234. t.Fatalf("Expected output is %s, got %s", expected, out)
  3235. }
  3236. logDone("build - entrypoint override inheritance properly")
  3237. }
  3238. func TestBuildRunShEntrypoint(t *testing.T) {
  3239. name := "testbuildentrypoint"
  3240. defer deleteImages(name)
  3241. _, err := buildImage(name,
  3242. `FROM busybox
  3243. ENTRYPOINT /bin/echo`,
  3244. true)
  3245. if err != nil {
  3246. t.Fatal(err)
  3247. }
  3248. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "--rm", name))
  3249. if err != nil {
  3250. t.Fatal(err, out)
  3251. }
  3252. logDone("build - entrypoint with /bin/echo running successfully")
  3253. }
  3254. func TestBuildExoticShellInterpolation(t *testing.T) {
  3255. name := "testbuildexoticshellinterpolation"
  3256. defer deleteImages(name)
  3257. _, err := buildImage(name, `
  3258. FROM busybox
  3259. ENV SOME_VAR a.b.c
  3260. RUN [ "$SOME_VAR" = 'a.b.c' ]
  3261. RUN [ "${SOME_VAR}" = 'a.b.c' ]
  3262. RUN [ "${SOME_VAR%.*}" = 'a.b' ]
  3263. RUN [ "${SOME_VAR%%.*}" = 'a' ]
  3264. RUN [ "${SOME_VAR#*.}" = 'b.c' ]
  3265. RUN [ "${SOME_VAR##*.}" = 'c' ]
  3266. RUN [ "${SOME_VAR/c/d}" = 'a.b.d' ]
  3267. RUN [ "${#SOME_VAR}" = '5' ]
  3268. RUN [ "${SOME_UNSET_VAR:-$SOME_VAR}" = 'a.b.c' ]
  3269. RUN [ "${SOME_VAR:+Version: ${SOME_VAR}}" = 'Version: a.b.c' ]
  3270. RUN [ "${SOME_UNSET_VAR:+${SOME_VAR}}" = '' ]
  3271. RUN [ "${SOME_UNSET_VAR:-${SOME_VAR:-d.e.f}}" = 'a.b.c' ]
  3272. `, false)
  3273. if err != nil {
  3274. t.Fatal(err)
  3275. }
  3276. logDone("build - exotic shell interpolation")
  3277. }
  3278. func TestBuildVerifySingleQuoteFails(t *testing.T) {
  3279. // This testcase is supposed to generate an error because the
  3280. // JSON array we're passing in on the CMD uses single quotes instead
  3281. // of double quotes (per the JSON spec). This means we interpret it
  3282. // as a "string" insead of "JSON array" and pass it on to "sh -c" and
  3283. // it should barf on it.
  3284. name := "testbuildsinglequotefails"
  3285. defer deleteImages(name)
  3286. defer deleteAllContainers()
  3287. _, err := buildImage(name,
  3288. `FROM busybox
  3289. CMD [ '/bin/sh', '-c', 'echo hi' ]`,
  3290. true)
  3291. _, _, err = runCommandWithOutput(exec.Command(dockerBinary, "run", "--rm", name))
  3292. if err == nil {
  3293. t.Fatal("The image was not supposed to be able to run")
  3294. }
  3295. logDone("build - verify single quotes fail")
  3296. }
  3297. func TestBuildVerboseOut(t *testing.T) {
  3298. name := "testbuildverboseout"
  3299. defer deleteImages(name)
  3300. _, out, err := buildImageWithOut(name,
  3301. `FROM busybox
  3302. RUN echo 123`,
  3303. false)
  3304. if err != nil {
  3305. t.Fatal(err)
  3306. }
  3307. if !strings.Contains(out, "\n123\n") {
  3308. t.Fatalf("Output should contain %q: %q", "123", out)
  3309. }
  3310. logDone("build - verbose output from commands")
  3311. }
  3312. func TestBuildWithTabs(t *testing.T) {
  3313. name := "testbuildwithtabs"
  3314. defer deleteImages(name)
  3315. _, err := buildImage(name,
  3316. "FROM busybox\nRUN echo\tone\t\ttwo", true)
  3317. if err != nil {
  3318. t.Fatal(err)
  3319. }
  3320. res, err := inspectFieldJSON(name, "ContainerConfig.Cmd")
  3321. if err != nil {
  3322. t.Fatal(err)
  3323. }
  3324. expected := "[\"/bin/sh\",\"-c\",\"echo\\u0009one\\u0009\\u0009two\"]"
  3325. if res != expected {
  3326. t.Fatalf("Missing tabs.\nGot:%s\nExp:%s", res, expected)
  3327. }
  3328. logDone("build - with tabs")
  3329. }
  3330. func TestBuildStderr(t *testing.T) {
  3331. // This test just makes sure that no non-error output goes
  3332. // to stderr
  3333. name := "testbuildstderr"
  3334. defer deleteImages(name)
  3335. _, _, stderr, err := buildImageWithStdoutStderr(name,
  3336. "FROM busybox\nRUN echo one", true)
  3337. if err != nil {
  3338. t.Fatal(err)
  3339. }
  3340. if stderr != "" {
  3341. t.Fatal("Stderr should have been empty, instead its: %q", stderr)
  3342. }
  3343. logDone("build - testing stderr")
  3344. }
  3345. func TestBuildChownSingleFile(t *testing.T) {
  3346. name := "testbuildchownsinglefile"
  3347. defer deleteImages(name)
  3348. ctx, err := fakeContext(`
  3349. FROM busybox
  3350. COPY test /
  3351. RUN ls -l /test
  3352. RUN [ $(ls -l /test | awk '{print $3":"$4}') = 'root:root' ]
  3353. `, map[string]string{
  3354. "test": "test",
  3355. })
  3356. if err != nil {
  3357. t.Fatal(err)
  3358. }
  3359. defer ctx.Close()
  3360. if err := os.Chown(filepath.Join(ctx.Dir, "test"), 4242, 4242); err != nil {
  3361. t.Fatal(err)
  3362. }
  3363. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  3364. t.Fatal(err)
  3365. }
  3366. logDone("build - change permission on single file")
  3367. }
  3368. func TestBuildSymlinkBreakout(t *testing.T) {
  3369. name := "testbuildsymlinkbreakout"
  3370. tmpdir, err := ioutil.TempDir("", name)
  3371. if err != nil {
  3372. t.Fatal(err)
  3373. }
  3374. defer os.RemoveAll(tmpdir)
  3375. ctx := filepath.Join(tmpdir, "context")
  3376. if err := os.MkdirAll(ctx, 0755); err != nil {
  3377. t.Fatal(err)
  3378. }
  3379. if err := ioutil.WriteFile(filepath.Join(ctx, "Dockerfile"), []byte(`
  3380. from busybox
  3381. add symlink.tar /
  3382. add inject /symlink/
  3383. `), 0644); err != nil {
  3384. t.Fatal(err)
  3385. }
  3386. inject := filepath.Join(ctx, "inject")
  3387. if err := ioutil.WriteFile(inject, nil, 0644); err != nil {
  3388. t.Fatal(err)
  3389. }
  3390. f, err := os.Create(filepath.Join(ctx, "symlink.tar"))
  3391. if err != nil {
  3392. t.Fatal(err)
  3393. }
  3394. w := tar.NewWriter(f)
  3395. w.WriteHeader(&tar.Header{
  3396. Name: "symlink2",
  3397. Typeflag: tar.TypeSymlink,
  3398. Linkname: "/../../../../../../../../../../../../../../",
  3399. Uid: os.Getuid(),
  3400. Gid: os.Getgid(),
  3401. })
  3402. w.WriteHeader(&tar.Header{
  3403. Name: "symlink",
  3404. Typeflag: tar.TypeSymlink,
  3405. Linkname: filepath.Join("symlink2", tmpdir),
  3406. Uid: os.Getuid(),
  3407. Gid: os.Getgid(),
  3408. })
  3409. w.Close()
  3410. f.Close()
  3411. if _, err := buildImageFromContext(name, &FakeContext{Dir: ctx}, false); err != nil {
  3412. t.Fatal(err)
  3413. }
  3414. if _, err := os.Lstat(filepath.Join(tmpdir, "inject")); err == nil {
  3415. t.Fatal("symlink breakout - inject")
  3416. } else if !os.IsNotExist(err) {
  3417. t.Fatalf("unexpected error: %v", err)
  3418. }
  3419. logDone("build - symlink breakout")
  3420. }
  3421. func TestBuildXZHost(t *testing.T) {
  3422. name := "testbuildxzhost"
  3423. defer deleteImages(name)
  3424. ctx, err := fakeContext(`
  3425. FROM busybox
  3426. ADD xz /usr/local/sbin/
  3427. RUN chmod 755 /usr/local/sbin/xz
  3428. ADD test.xz /
  3429. RUN [ ! -e /injected ]`,
  3430. map[string]string{
  3431. "test.xz": "\xfd\x37\x7a\x58\x5a\x00\x00\x04\xe6\xd6\xb4\x46\x02\x00" +
  3432. "\x21\x01\x16\x00\x00\x00\x74\x2f\xe5\xa3\x01\x00\x3f\xfd" +
  3433. "\x37\x7a\x58\x5a\x00\x00\x04\xe6\xd6\xb4\x46\x02\x00\x21",
  3434. "xz": "#!/bin/sh\ntouch /injected",
  3435. })
  3436. if err != nil {
  3437. t.Fatal(err)
  3438. }
  3439. defer ctx.Close()
  3440. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  3441. t.Fatal(err)
  3442. }
  3443. logDone("build - xz host is being used")
  3444. }
  3445. func TestBuildVolumesRetainContents(t *testing.T) {
  3446. var (
  3447. name = "testbuildvolumescontent"
  3448. expected = "some text"
  3449. )
  3450. defer deleteImages(name)
  3451. ctx, err := fakeContext(`
  3452. FROM busybox
  3453. COPY content /foo/file
  3454. VOLUME /foo
  3455. CMD cat /foo/file`,
  3456. map[string]string{
  3457. "content": expected,
  3458. })
  3459. if err != nil {
  3460. t.Fatal(err)
  3461. }
  3462. defer ctx.Close()
  3463. if _, err := buildImageFromContext(name, ctx, false); err != nil {
  3464. t.Fatal(err)
  3465. }
  3466. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "--rm", name))
  3467. if err != nil {
  3468. t.Fatal(err)
  3469. }
  3470. if out != expected {
  3471. t.Fatalf("expected file contents for /foo/file to be %q but received %q", expected, out)
  3472. }
  3473. logDone("build - volumes retain contents in build")
  3474. }