builder.go 8.2 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293
  1. package dockerfile
  2. import (
  3. "bytes"
  4. "fmt"
  5. "io"
  6. "io/ioutil"
  7. "strings"
  8. "github.com/Sirupsen/logrus"
  9. "github.com/docker/docker/api/types"
  10. "github.com/docker/docker/api/types/backend"
  11. "github.com/docker/docker/api/types/container"
  12. "github.com/docker/docker/builder"
  13. "github.com/docker/docker/builder/dockerfile/command"
  14. "github.com/docker/docker/builder/dockerfile/parser"
  15. "github.com/docker/docker/builder/remotecontext"
  16. "github.com/docker/docker/pkg/stringid"
  17. "github.com/pkg/errors"
  18. "golang.org/x/net/context"
  19. "golang.org/x/sync/syncmap"
  20. )
  21. var validCommitCommands = map[string]bool{
  22. "cmd": true,
  23. "entrypoint": true,
  24. "healthcheck": true,
  25. "env": true,
  26. "expose": true,
  27. "label": true,
  28. "onbuild": true,
  29. "user": true,
  30. "volume": true,
  31. "workdir": true,
  32. }
  33. var defaultLogConfig = container.LogConfig{Type: "none"}
  34. // BuildManager is shared across all Builder objects
  35. type BuildManager struct {
  36. backend builder.Backend
  37. pathCache pathCache // TODO: make this persistent
  38. }
  39. // NewBuildManager creates a BuildManager
  40. func NewBuildManager(b builder.Backend) *BuildManager {
  41. return &BuildManager{backend: b, pathCache: &syncmap.Map{}}
  42. }
  43. // Build starts a new build from a BuildConfig
  44. func (bm *BuildManager) Build(ctx context.Context, config backend.BuildConfig) (*builder.Result, error) {
  45. buildsTriggered.Inc()
  46. if config.Options.Dockerfile == "" {
  47. config.Options.Dockerfile = builder.DefaultDockerfileName
  48. }
  49. source, dockerfile, err := remotecontext.Detect(config)
  50. if err != nil {
  51. return nil, err
  52. }
  53. if source != nil {
  54. defer func() {
  55. if err := source.Close(); err != nil {
  56. logrus.Debugf("[BUILDER] failed to remove temporary context: %v", err)
  57. }
  58. }()
  59. }
  60. builderOptions := builderOptions{
  61. Options: config.Options,
  62. ProgressWriter: config.ProgressWriter,
  63. Backend: bm.backend,
  64. PathCache: bm.pathCache,
  65. }
  66. return newBuilder(ctx, builderOptions).build(source, dockerfile)
  67. }
  68. // builderOptions are the dependencies required by the builder
  69. type builderOptions struct {
  70. Options *types.ImageBuildOptions
  71. Backend builder.Backend
  72. ProgressWriter backend.ProgressWriter
  73. PathCache pathCache
  74. }
  75. // Builder is a Dockerfile builder
  76. // It implements the builder.Backend interface.
  77. type Builder struct {
  78. options *types.ImageBuildOptions
  79. Stdout io.Writer
  80. Stderr io.Writer
  81. Output io.Writer
  82. docker builder.Backend
  83. source builder.Source
  84. clientCtx context.Context
  85. tmpContainers map[string]struct{}
  86. imageContexts *imageContexts // helper for storing contexts from builds
  87. disableCommit bool
  88. cacheBusted bool
  89. buildArgs *buildArgs
  90. imageCache builder.ImageCache
  91. }
  92. // newBuilder creates a new Dockerfile builder from an optional dockerfile and a Options.
  93. func newBuilder(clientCtx context.Context, options builderOptions) *Builder {
  94. config := options.Options
  95. if config == nil {
  96. config = new(types.ImageBuildOptions)
  97. }
  98. b := &Builder{
  99. clientCtx: clientCtx,
  100. options: config,
  101. Stdout: options.ProgressWriter.StdoutFormatter,
  102. Stderr: options.ProgressWriter.StderrFormatter,
  103. Output: options.ProgressWriter.Output,
  104. docker: options.Backend,
  105. tmpContainers: map[string]struct{}{},
  106. buildArgs: newBuildArgs(config.BuildArgs),
  107. }
  108. b.imageContexts = &imageContexts{b: b, cache: options.PathCache}
  109. return b
  110. }
  111. func (b *Builder) resetImageCache() {
  112. if icb, ok := b.docker.(builder.ImageCacheBuilder); ok {
  113. b.imageCache = icb.MakeImageCache(b.options.CacheFrom)
  114. }
  115. b.cacheBusted = false
  116. }
  117. // Build runs the Dockerfile builder by parsing the Dockerfile and executing
  118. // the instructions from the file.
  119. func (b *Builder) build(source builder.Source, dockerfile *parser.Result) (*builder.Result, error) {
  120. defer b.imageContexts.unmount()
  121. // TODO: Remove source field from Builder
  122. b.source = source
  123. addNodesForLabelOption(dockerfile.AST, b.options.Labels)
  124. if err := checkDispatchDockerfile(dockerfile.AST); err != nil {
  125. buildsFailed.WithValues(metricsDockerfileSyntaxError).Inc()
  126. return nil, err
  127. }
  128. dispatchState, err := b.dispatchDockerfileWithCancellation(dockerfile)
  129. if err != nil {
  130. return nil, err
  131. }
  132. if b.options.Target != "" && !dispatchState.isCurrentStage(b.options.Target) {
  133. buildsFailed.WithValues(metricsBuildTargetNotReachableError).Inc()
  134. return nil, errors.Errorf("failed to reach build target %s in Dockerfile", b.options.Target)
  135. }
  136. b.warnOnUnusedBuildArgs()
  137. if dispatchState.imageID == "" {
  138. buildsFailed.WithValues(metricsDockerfileEmptyError).Inc()
  139. return nil, errors.New("No image was generated. Is your Dockerfile empty?")
  140. }
  141. return &builder.Result{ImageID: dispatchState.imageID, FromImage: dispatchState.baseImage}, nil
  142. }
  143. func (b *Builder) dispatchDockerfileWithCancellation(dockerfile *parser.Result) (*dispatchState, error) {
  144. shlex := NewShellLex(dockerfile.EscapeToken)
  145. state := newDispatchState()
  146. total := len(dockerfile.AST.Children)
  147. var err error
  148. for i, n := range dockerfile.AST.Children {
  149. select {
  150. case <-b.clientCtx.Done():
  151. logrus.Debug("Builder: build cancelled!")
  152. fmt.Fprint(b.Stdout, "Build cancelled")
  153. buildsFailed.WithValues(metricsBuildCanceled).Inc()
  154. return nil, errors.New("Build cancelled")
  155. default:
  156. // Not cancelled yet, keep going...
  157. }
  158. if n.Value == command.From && state.isCurrentStage(b.options.Target) {
  159. break
  160. }
  161. opts := dispatchOptions{
  162. state: state,
  163. stepMsg: formatStep(i, total),
  164. node: n,
  165. shlex: shlex,
  166. }
  167. if state, err = b.dispatch(opts); err != nil {
  168. if b.options.ForceRemove {
  169. b.clearTmp()
  170. }
  171. return nil, err
  172. }
  173. fmt.Fprintf(b.Stdout, " ---> %s\n", stringid.TruncateID(state.imageID))
  174. if b.options.Remove {
  175. b.clearTmp()
  176. }
  177. }
  178. return state, nil
  179. }
  180. func addNodesForLabelOption(dockerfile *parser.Node, labels map[string]string) {
  181. if len(labels) == 0 {
  182. return
  183. }
  184. node := parser.NodeFromLabels(labels)
  185. dockerfile.Children = append(dockerfile.Children, node)
  186. }
  187. // check if there are any leftover build-args that were passed but not
  188. // consumed during build. Print a warning, if there are any.
  189. func (b *Builder) warnOnUnusedBuildArgs() {
  190. leftoverArgs := b.buildArgs.UnreferencedOptionArgs()
  191. if len(leftoverArgs) > 0 {
  192. fmt.Fprintf(b.Stderr, "[Warning] One or more build-args %v were not consumed\n", leftoverArgs)
  193. }
  194. }
  195. // BuildFromConfig builds directly from `changes`, treating it as if it were the contents of a Dockerfile
  196. // It will:
  197. // - Call parse.Parse() to get an AST root for the concatenated Dockerfile entries.
  198. // - Do build by calling builder.dispatch() to call all entries' handling routines
  199. //
  200. // BuildFromConfig is used by the /commit endpoint, with the changes
  201. // coming from the query parameter of the same name.
  202. //
  203. // TODO: Remove?
  204. func BuildFromConfig(config *container.Config, changes []string) (*container.Config, error) {
  205. if len(changes) == 0 {
  206. return config, nil
  207. }
  208. b := newBuilder(context.Background(), builderOptions{})
  209. dockerfile, err := parser.Parse(bytes.NewBufferString(strings.Join(changes, "\n")))
  210. if err != nil {
  211. return nil, err
  212. }
  213. // ensure that the commands are valid
  214. for _, n := range dockerfile.AST.Children {
  215. if !validCommitCommands[n.Value] {
  216. return nil, fmt.Errorf("%s is not a valid change command", n.Value)
  217. }
  218. }
  219. b.Stdout = ioutil.Discard
  220. b.Stderr = ioutil.Discard
  221. b.disableCommit = true
  222. if err := checkDispatchDockerfile(dockerfile.AST); err != nil {
  223. return nil, err
  224. }
  225. dispatchState := newDispatchState()
  226. dispatchState.runConfig = config
  227. return dispatchFromDockerfile(b, dockerfile, dispatchState)
  228. }
  229. func checkDispatchDockerfile(dockerfile *parser.Node) error {
  230. for _, n := range dockerfile.Children {
  231. if err := checkDispatch(n); err != nil {
  232. return errors.Wrapf(err, "Dockerfile parse error line %d", n.StartLine)
  233. }
  234. }
  235. return nil
  236. }
  237. func dispatchFromDockerfile(b *Builder, result *parser.Result, dispatchState *dispatchState) (*container.Config, error) {
  238. shlex := NewShellLex(result.EscapeToken)
  239. ast := result.AST
  240. total := len(ast.Children)
  241. for i, n := range ast.Children {
  242. opts := dispatchOptions{
  243. state: dispatchState,
  244. stepMsg: formatStep(i, total),
  245. node: n,
  246. shlex: shlex,
  247. }
  248. if _, err := b.dispatch(opts); err != nil {
  249. return nil, err
  250. }
  251. }
  252. return dispatchState.runConfig, nil
  253. }