pull.go 19 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616
  1. package graph
  2. import (
  3. "fmt"
  4. "io"
  5. "io/ioutil"
  6. "net"
  7. "net/url"
  8. "os"
  9. "strings"
  10. "time"
  11. "github.com/Sirupsen/logrus"
  12. "github.com/docker/distribution/digest"
  13. "github.com/docker/docker/cliconfig"
  14. "github.com/docker/docker/image"
  15. "github.com/docker/docker/pkg/progressreader"
  16. "github.com/docker/docker/pkg/streamformatter"
  17. "github.com/docker/docker/pkg/stringid"
  18. "github.com/docker/docker/registry"
  19. "github.com/docker/docker/utils"
  20. )
  21. type ImagePullConfig struct {
  22. Parallel bool
  23. MetaHeaders map[string][]string
  24. AuthConfig *cliconfig.AuthConfig
  25. Json bool
  26. OutStream io.Writer
  27. }
  28. func (s *TagStore) Pull(image string, tag string, imagePullConfig *ImagePullConfig) error {
  29. var (
  30. sf = streamformatter.NewStreamFormatter(imagePullConfig.Json)
  31. )
  32. // Resolve the Repository name from fqn to RepositoryInfo
  33. repoInfo, err := s.registryService.ResolveRepository(image)
  34. if err != nil {
  35. return err
  36. }
  37. c, err := s.poolAdd("pull", utils.ImageReference(repoInfo.LocalName, tag))
  38. if err != nil {
  39. if c != nil {
  40. // Another pull of the same repository is already taking place; just wait for it to finish
  41. imagePullConfig.OutStream.Write(sf.FormatStatus("", "Repository %s already being pulled by another client. Waiting.", repoInfo.LocalName))
  42. <-c
  43. return nil
  44. }
  45. return err
  46. }
  47. defer s.poolRemove("pull", utils.ImageReference(repoInfo.LocalName, tag))
  48. logrus.Debugf("pulling image from host %q with remote name %q", repoInfo.Index.Name, repoInfo.RemoteName)
  49. endpoint, err := repoInfo.GetEndpoint()
  50. if err != nil {
  51. return err
  52. }
  53. r, err := registry.NewSession(imagePullConfig.AuthConfig, registry.HTTPRequestFactory(imagePullConfig.MetaHeaders), endpoint, true)
  54. if err != nil {
  55. return err
  56. }
  57. logName := repoInfo.LocalName
  58. if tag != "" {
  59. logName = utils.ImageReference(logName, tag)
  60. }
  61. if len(repoInfo.Index.Mirrors) == 0 && (repoInfo.Index.Official || endpoint.Version == registry.APIVersion2) {
  62. if repoInfo.Official {
  63. s.trustService.UpdateBase()
  64. }
  65. logrus.Debugf("pulling v2 repository with local name %q", repoInfo.LocalName)
  66. if err := s.pullV2Repository(r, imagePullConfig.OutStream, repoInfo, tag, sf, imagePullConfig.Parallel); err == nil {
  67. s.eventsService.Log("pull", logName, "")
  68. return nil
  69. } else if err != registry.ErrDoesNotExist && err != ErrV2RegistryUnavailable {
  70. logrus.Errorf("Error from V2 registry: %s", err)
  71. }
  72. logrus.Debug("image does not exist on v2 registry, falling back to v1")
  73. }
  74. logrus.Debugf("pulling v1 repository with local name %q", repoInfo.LocalName)
  75. if err = s.pullRepository(r, imagePullConfig.OutStream, repoInfo, tag, sf, imagePullConfig.Parallel); err != nil {
  76. return err
  77. }
  78. s.eventsService.Log("pull", logName, "")
  79. return nil
  80. }
  81. func (s *TagStore) pullRepository(r *registry.Session, out io.Writer, repoInfo *registry.RepositoryInfo, askedTag string, sf *streamformatter.StreamFormatter, parallel bool) error {
  82. out.Write(sf.FormatStatus("", "Pulling repository %s", repoInfo.CanonicalName))
  83. repoData, err := r.GetRepositoryData(repoInfo.RemoteName)
  84. if err != nil {
  85. if strings.Contains(err.Error(), "HTTP code: 404") {
  86. return fmt.Errorf("Error: image %s not found", utils.ImageReference(repoInfo.RemoteName, askedTag))
  87. }
  88. // Unexpected HTTP error
  89. return err
  90. }
  91. logrus.Debugf("Retrieving the tag list")
  92. tagsList, err := r.GetRemoteTags(repoData.Endpoints, repoInfo.RemoteName, repoData.Tokens)
  93. if err != nil {
  94. logrus.Errorf("unable to get remote tags: %s", err)
  95. return err
  96. }
  97. for tag, id := range tagsList {
  98. repoData.ImgList[id] = &registry.ImgData{
  99. ID: id,
  100. Tag: tag,
  101. Checksum: "",
  102. }
  103. }
  104. logrus.Debugf("Registering tags")
  105. // If no tag has been specified, pull them all
  106. if askedTag == "" {
  107. for tag, id := range tagsList {
  108. repoData.ImgList[id].Tag = tag
  109. }
  110. } else {
  111. // Otherwise, check that the tag exists and use only that one
  112. id, exists := tagsList[askedTag]
  113. if !exists {
  114. return fmt.Errorf("Tag %s not found in repository %s", askedTag, repoInfo.CanonicalName)
  115. }
  116. repoData.ImgList[id].Tag = askedTag
  117. }
  118. errors := make(chan error)
  119. layersDownloaded := false
  120. for _, image := range repoData.ImgList {
  121. downloadImage := func(img *registry.ImgData) {
  122. if askedTag != "" && img.Tag != askedTag {
  123. if parallel {
  124. errors <- nil
  125. }
  126. return
  127. }
  128. if img.Tag == "" {
  129. logrus.Debugf("Image (id: %s) present in this repository but untagged, skipping", img.ID)
  130. if parallel {
  131. errors <- nil
  132. }
  133. return
  134. }
  135. // ensure no two downloads of the same image happen at the same time
  136. if c, err := s.poolAdd("pull", "img:"+img.ID); err != nil {
  137. if c != nil {
  138. out.Write(sf.FormatProgress(stringid.TruncateID(img.ID), "Layer already being pulled by another client. Waiting.", nil))
  139. <-c
  140. out.Write(sf.FormatProgress(stringid.TruncateID(img.ID), "Download complete", nil))
  141. } else {
  142. logrus.Debugf("Image (id: %s) pull is already running, skipping: %v", img.ID, err)
  143. }
  144. if parallel {
  145. errors <- nil
  146. }
  147. return
  148. }
  149. defer s.poolRemove("pull", "img:"+img.ID)
  150. out.Write(sf.FormatProgress(stringid.TruncateID(img.ID), fmt.Sprintf("Pulling image (%s) from %s", img.Tag, repoInfo.CanonicalName), nil))
  151. success := false
  152. var lastErr, err error
  153. var isDownloaded bool
  154. for _, ep := range repoInfo.Index.Mirrors {
  155. out.Write(sf.FormatProgress(stringid.TruncateID(img.ID), fmt.Sprintf("Pulling image (%s) from %s, mirror: %s", img.Tag, repoInfo.CanonicalName, ep), nil))
  156. if isDownloaded, err = s.pullImage(r, out, img.ID, ep, repoData.Tokens, sf); err != nil {
  157. // Don't report errors when pulling from mirrors.
  158. logrus.Debugf("Error pulling image (%s) from %s, mirror: %s, %s", img.Tag, repoInfo.CanonicalName, ep, err)
  159. continue
  160. }
  161. layersDownloaded = layersDownloaded || isDownloaded
  162. success = true
  163. break
  164. }
  165. if !success {
  166. for _, ep := range repoData.Endpoints {
  167. out.Write(sf.FormatProgress(stringid.TruncateID(img.ID), fmt.Sprintf("Pulling image (%s) from %s, endpoint: %s", img.Tag, repoInfo.CanonicalName, ep), nil))
  168. if isDownloaded, err = s.pullImage(r, out, img.ID, ep, repoData.Tokens, sf); err != nil {
  169. // It's not ideal that only the last error is returned, it would be better to concatenate the errors.
  170. // As the error is also given to the output stream the user will see the error.
  171. lastErr = err
  172. out.Write(sf.FormatProgress(stringid.TruncateID(img.ID), fmt.Sprintf("Error pulling image (%s) from %s, endpoint: %s, %s", img.Tag, repoInfo.CanonicalName, ep, err), nil))
  173. continue
  174. }
  175. layersDownloaded = layersDownloaded || isDownloaded
  176. success = true
  177. break
  178. }
  179. }
  180. if !success {
  181. err := fmt.Errorf("Error pulling image (%s) from %s, %v", img.Tag, repoInfo.CanonicalName, lastErr)
  182. out.Write(sf.FormatProgress(stringid.TruncateID(img.ID), err.Error(), nil))
  183. if parallel {
  184. errors <- err
  185. return
  186. }
  187. }
  188. out.Write(sf.FormatProgress(stringid.TruncateID(img.ID), "Download complete", nil))
  189. if parallel {
  190. errors <- nil
  191. }
  192. }
  193. if parallel {
  194. go downloadImage(image)
  195. } else {
  196. downloadImage(image)
  197. }
  198. }
  199. if parallel {
  200. var lastError error
  201. for i := 0; i < len(repoData.ImgList); i++ {
  202. if err := <-errors; err != nil {
  203. lastError = err
  204. }
  205. }
  206. if lastError != nil {
  207. return lastError
  208. }
  209. }
  210. for tag, id := range tagsList {
  211. if askedTag != "" && tag != askedTag {
  212. continue
  213. }
  214. if err := s.Tag(repoInfo.LocalName, tag, id, true); err != nil {
  215. return err
  216. }
  217. }
  218. requestedTag := repoInfo.CanonicalName
  219. if len(askedTag) > 0 {
  220. requestedTag = utils.ImageReference(repoInfo.CanonicalName, askedTag)
  221. }
  222. WriteStatus(requestedTag, out, sf, layersDownloaded)
  223. return nil
  224. }
  225. func (s *TagStore) pullImage(r *registry.Session, out io.Writer, imgID, endpoint string, token []string, sf *streamformatter.StreamFormatter) (bool, error) {
  226. history, err := r.GetRemoteHistory(imgID, endpoint, token)
  227. if err != nil {
  228. return false, err
  229. }
  230. out.Write(sf.FormatProgress(stringid.TruncateID(imgID), "Pulling dependent layers", nil))
  231. // FIXME: Try to stream the images?
  232. // FIXME: Launch the getRemoteImage() in goroutines
  233. layersDownloaded := false
  234. for i := len(history) - 1; i >= 0; i-- {
  235. id := history[i]
  236. // ensure no two downloads of the same layer happen at the same time
  237. if c, err := s.poolAdd("pull", "layer:"+id); err != nil {
  238. logrus.Debugf("Image (id: %s) pull is already running, skipping: %v", id, err)
  239. <-c
  240. }
  241. defer s.poolRemove("pull", "layer:"+id)
  242. if !s.graph.Exists(id) {
  243. out.Write(sf.FormatProgress(stringid.TruncateID(id), "Pulling metadata", nil))
  244. var (
  245. imgJSON []byte
  246. imgSize int
  247. err error
  248. img *image.Image
  249. )
  250. retries := 5
  251. for j := 1; j <= retries; j++ {
  252. imgJSON, imgSize, err = r.GetRemoteImageJSON(id, endpoint, token)
  253. if err != nil && j == retries {
  254. out.Write(sf.FormatProgress(stringid.TruncateID(id), "Error pulling dependent layers", nil))
  255. return layersDownloaded, err
  256. } else if err != nil {
  257. time.Sleep(time.Duration(j) * 500 * time.Millisecond)
  258. continue
  259. }
  260. img, err = image.NewImgJSON(imgJSON)
  261. layersDownloaded = true
  262. if err != nil && j == retries {
  263. out.Write(sf.FormatProgress(stringid.TruncateID(id), "Error pulling dependent layers", nil))
  264. return layersDownloaded, fmt.Errorf("Failed to parse json: %s", err)
  265. } else if err != nil {
  266. time.Sleep(time.Duration(j) * 500 * time.Millisecond)
  267. continue
  268. } else {
  269. break
  270. }
  271. }
  272. for j := 1; j <= retries; j++ {
  273. // Get the layer
  274. status := "Pulling fs layer"
  275. if j > 1 {
  276. status = fmt.Sprintf("Pulling fs layer [retries: %d]", j)
  277. }
  278. out.Write(sf.FormatProgress(stringid.TruncateID(id), status, nil))
  279. layer, err := r.GetRemoteImageLayer(img.ID, endpoint, token, int64(imgSize))
  280. if uerr, ok := err.(*url.Error); ok {
  281. err = uerr.Err
  282. }
  283. if terr, ok := err.(net.Error); ok && terr.Timeout() && j < retries {
  284. time.Sleep(time.Duration(j) * 500 * time.Millisecond)
  285. continue
  286. } else if err != nil {
  287. out.Write(sf.FormatProgress(stringid.TruncateID(id), "Error pulling dependent layers", nil))
  288. return layersDownloaded, err
  289. }
  290. layersDownloaded = true
  291. defer layer.Close()
  292. err = s.graph.Register(img,
  293. progressreader.New(progressreader.Config{
  294. In: layer,
  295. Out: out,
  296. Formatter: sf,
  297. Size: imgSize,
  298. NewLines: false,
  299. ID: stringid.TruncateID(id),
  300. Action: "Downloading",
  301. }))
  302. if terr, ok := err.(net.Error); ok && terr.Timeout() && j < retries {
  303. time.Sleep(time.Duration(j) * 500 * time.Millisecond)
  304. continue
  305. } else if err != nil {
  306. out.Write(sf.FormatProgress(stringid.TruncateID(id), "Error downloading dependent layers", nil))
  307. return layersDownloaded, err
  308. } else {
  309. break
  310. }
  311. }
  312. }
  313. out.Write(sf.FormatProgress(stringid.TruncateID(id), "Download complete", nil))
  314. }
  315. return layersDownloaded, nil
  316. }
  317. func WriteStatus(requestedTag string, out io.Writer, sf *streamformatter.StreamFormatter, layersDownloaded bool) {
  318. if layersDownloaded {
  319. out.Write(sf.FormatStatus("", "Status: Downloaded newer image for %s", requestedTag))
  320. } else {
  321. out.Write(sf.FormatStatus("", "Status: Image is up to date for %s", requestedTag))
  322. }
  323. }
  324. // downloadInfo is used to pass information from download to extractor
  325. type downloadInfo struct {
  326. imgJSON []byte
  327. img *image.Image
  328. digest digest.Digest
  329. tmpFile *os.File
  330. length int64
  331. downloaded bool
  332. err chan error
  333. }
  334. func (s *TagStore) pullV2Repository(r *registry.Session, out io.Writer, repoInfo *registry.RepositoryInfo, tag string, sf *streamformatter.StreamFormatter, parallel bool) error {
  335. endpoint, err := r.V2RegistryEndpoint(repoInfo.Index)
  336. if err != nil {
  337. if repoInfo.Index.Official {
  338. logrus.Debugf("Unable to pull from V2 registry, falling back to v1: %s", err)
  339. return ErrV2RegistryUnavailable
  340. }
  341. return fmt.Errorf("error getting registry endpoint: %s", err)
  342. }
  343. auth, err := r.GetV2Authorization(endpoint, repoInfo.RemoteName, true)
  344. if err != nil {
  345. return fmt.Errorf("error getting authorization: %s", err)
  346. }
  347. var layersDownloaded bool
  348. if tag == "" {
  349. logrus.Debugf("Pulling tag list from V2 registry for %s", repoInfo.CanonicalName)
  350. tags, err := r.GetV2RemoteTags(endpoint, repoInfo.RemoteName, auth)
  351. if err != nil {
  352. return err
  353. }
  354. if len(tags) == 0 {
  355. return registry.ErrDoesNotExist
  356. }
  357. for _, t := range tags {
  358. if downloaded, err := s.pullV2Tag(r, out, endpoint, repoInfo, t, sf, parallel, auth); err != nil {
  359. return err
  360. } else if downloaded {
  361. layersDownloaded = true
  362. }
  363. }
  364. } else {
  365. if downloaded, err := s.pullV2Tag(r, out, endpoint, repoInfo, tag, sf, parallel, auth); err != nil {
  366. return err
  367. } else if downloaded {
  368. layersDownloaded = true
  369. }
  370. }
  371. requestedTag := repoInfo.CanonicalName
  372. if len(tag) > 0 {
  373. requestedTag = utils.ImageReference(repoInfo.CanonicalName, tag)
  374. }
  375. WriteStatus(requestedTag, out, sf, layersDownloaded)
  376. return nil
  377. }
  378. func (s *TagStore) pullV2Tag(r *registry.Session, out io.Writer, endpoint *registry.Endpoint, repoInfo *registry.RepositoryInfo, tag string, sf *streamformatter.StreamFormatter, parallel bool, auth *registry.RequestAuthorization) (bool, error) {
  379. logrus.Debugf("Pulling tag from V2 registry: %q", tag)
  380. manifestBytes, manifestDigest, err := r.GetV2ImageManifest(endpoint, repoInfo.RemoteName, tag, auth)
  381. if err != nil {
  382. return false, err
  383. }
  384. // loadManifest ensures that the manifest payload has the expected digest
  385. // if the tag is a digest reference.
  386. manifest, verified, err := s.loadManifest(manifestBytes, manifestDigest, tag)
  387. if err != nil {
  388. return false, fmt.Errorf("error verifying manifest: %s", err)
  389. }
  390. if err := checkValidManifest(manifest); err != nil {
  391. return false, err
  392. }
  393. if verified {
  394. logrus.Printf("Image manifest for %s has been verified", utils.ImageReference(repoInfo.CanonicalName, tag))
  395. }
  396. out.Write(sf.FormatStatus(tag, "Pulling from %s", repoInfo.CanonicalName))
  397. downloads := make([]downloadInfo, len(manifest.FSLayers))
  398. for i := len(manifest.FSLayers) - 1; i >= 0; i-- {
  399. var (
  400. sumStr = manifest.FSLayers[i].BlobSum
  401. imgJSON = []byte(manifest.History[i].V1Compatibility)
  402. )
  403. img, err := image.NewImgJSON(imgJSON)
  404. if err != nil {
  405. return false, fmt.Errorf("failed to parse json: %s", err)
  406. }
  407. downloads[i].img = img
  408. // Check if exists
  409. if s.graph.Exists(img.ID) {
  410. logrus.Debugf("Image already exists: %s", img.ID)
  411. continue
  412. }
  413. dgst, err := digest.ParseDigest(sumStr)
  414. if err != nil {
  415. return false, err
  416. }
  417. downloads[i].digest = dgst
  418. out.Write(sf.FormatProgress(stringid.TruncateID(img.ID), "Pulling fs layer", nil))
  419. downloadFunc := func(di *downloadInfo) error {
  420. logrus.Debugf("pulling blob %q to V1 img %s", sumStr, img.ID)
  421. if c, err := s.poolAdd("pull", "img:"+img.ID); err != nil {
  422. if c != nil {
  423. out.Write(sf.FormatProgress(stringid.TruncateID(img.ID), "Layer already being pulled by another client. Waiting.", nil))
  424. <-c
  425. out.Write(sf.FormatProgress(stringid.TruncateID(img.ID), "Download complete", nil))
  426. } else {
  427. logrus.Debugf("Image (id: %s) pull is already running, skipping: %v", img.ID, err)
  428. }
  429. } else {
  430. defer s.poolRemove("pull", "img:"+img.ID)
  431. tmpFile, err := ioutil.TempFile("", "GetV2ImageBlob")
  432. if err != nil {
  433. return err
  434. }
  435. r, l, err := r.GetV2ImageBlobReader(endpoint, repoInfo.RemoteName, di.digest, auth)
  436. if err != nil {
  437. return err
  438. }
  439. defer r.Close()
  440. verifier, err := digest.NewDigestVerifier(di.digest)
  441. if err != nil {
  442. return err
  443. }
  444. if _, err := io.Copy(tmpFile, progressreader.New(progressreader.Config{
  445. In: ioutil.NopCloser(io.TeeReader(r, verifier)),
  446. Out: out,
  447. Formatter: sf,
  448. Size: int(l),
  449. NewLines: false,
  450. ID: stringid.TruncateID(img.ID),
  451. Action: "Downloading",
  452. })); err != nil {
  453. return fmt.Errorf("unable to copy v2 image blob data: %s", err)
  454. }
  455. out.Write(sf.FormatProgress(stringid.TruncateID(img.ID), "Verifying Checksum", nil))
  456. if !verifier.Verified() {
  457. logrus.Infof("Image verification failed: checksum mismatch for %q", di.digest.String())
  458. verified = false
  459. }
  460. out.Write(sf.FormatProgress(stringid.TruncateID(img.ID), "Download complete", nil))
  461. logrus.Debugf("Downloaded %s to tempfile %s", img.ID, tmpFile.Name())
  462. di.tmpFile = tmpFile
  463. di.length = l
  464. di.downloaded = true
  465. }
  466. di.imgJSON = imgJSON
  467. return nil
  468. }
  469. if parallel {
  470. downloads[i].err = make(chan error)
  471. go func(di *downloadInfo) {
  472. di.err <- downloadFunc(di)
  473. }(&downloads[i])
  474. } else {
  475. err := downloadFunc(&downloads[i])
  476. if err != nil {
  477. return false, err
  478. }
  479. }
  480. }
  481. var tagUpdated bool
  482. for i := len(downloads) - 1; i >= 0; i-- {
  483. d := &downloads[i]
  484. if d.err != nil {
  485. err := <-d.err
  486. if err != nil {
  487. return false, err
  488. }
  489. }
  490. if d.downloaded {
  491. // if tmpFile is empty assume download and extracted elsewhere
  492. defer os.Remove(d.tmpFile.Name())
  493. defer d.tmpFile.Close()
  494. d.tmpFile.Seek(0, 0)
  495. if d.tmpFile != nil {
  496. err = s.graph.Register(d.img,
  497. progressreader.New(progressreader.Config{
  498. In: d.tmpFile,
  499. Out: out,
  500. Formatter: sf,
  501. Size: int(d.length),
  502. ID: stringid.TruncateID(d.img.ID),
  503. Action: "Extracting",
  504. }))
  505. if err != nil {
  506. return false, err
  507. }
  508. // FIXME: Pool release here for parallel tag pull (ensures any downloads block until fully extracted)
  509. }
  510. out.Write(sf.FormatProgress(stringid.TruncateID(d.img.ID), "Pull complete", nil))
  511. tagUpdated = true
  512. } else {
  513. out.Write(sf.FormatProgress(stringid.TruncateID(d.img.ID), "Already exists", nil))
  514. }
  515. }
  516. // Check for new tag if no layers downloaded
  517. if !tagUpdated {
  518. repo, err := s.Get(repoInfo.LocalName)
  519. if err != nil {
  520. return false, err
  521. }
  522. if repo != nil {
  523. if _, exists := repo[tag]; !exists {
  524. tagUpdated = true
  525. }
  526. } else {
  527. tagUpdated = true
  528. }
  529. }
  530. if verified && tagUpdated {
  531. out.Write(sf.FormatStatus(utils.ImageReference(repoInfo.CanonicalName, tag), "The image you are pulling has been verified. Important: image verification is a tech preview feature and should not be relied on to provide security."))
  532. }
  533. if manifestDigest != "" {
  534. out.Write(sf.FormatStatus("", "Digest: %s", manifestDigest))
  535. }
  536. if utils.DigestReference(tag) {
  537. if err = s.SetDigest(repoInfo.LocalName, tag, downloads[0].img.ID); err != nil {
  538. return false, err
  539. }
  540. } else {
  541. // only set the repository/tag -> image ID mapping when pulling by tag (i.e. not by digest)
  542. if err = s.Tag(repoInfo.LocalName, tag, downloads[0].img.ID, true); err != nil {
  543. return false, err
  544. }
  545. }
  546. return tagUpdated, nil
  547. }