internals.go 18 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664
  1. package dockerfile
  2. // internals for handling commands. Covers many areas and a lot of
  3. // non-contiguous functionality. Please read the comments.
  4. import (
  5. "crypto/sha256"
  6. "encoding/hex"
  7. "fmt"
  8. "io"
  9. "io/ioutil"
  10. "net/http"
  11. "net/url"
  12. "os"
  13. "path/filepath"
  14. "runtime"
  15. "sort"
  16. "strings"
  17. "time"
  18. "github.com/Sirupsen/logrus"
  19. "github.com/docker/docker/api"
  20. "github.com/docker/docker/api/types"
  21. "github.com/docker/docker/builder"
  22. "github.com/docker/docker/builder/dockerfile/parser"
  23. "github.com/docker/docker/daemon"
  24. "github.com/docker/docker/pkg/archive"
  25. "github.com/docker/docker/pkg/httputils"
  26. "github.com/docker/docker/pkg/ioutils"
  27. "github.com/docker/docker/pkg/jsonmessage"
  28. "github.com/docker/docker/pkg/progress"
  29. "github.com/docker/docker/pkg/streamformatter"
  30. "github.com/docker/docker/pkg/stringid"
  31. "github.com/docker/docker/pkg/stringutils"
  32. "github.com/docker/docker/pkg/system"
  33. "github.com/docker/docker/pkg/tarsum"
  34. "github.com/docker/docker/pkg/urlutil"
  35. "github.com/docker/docker/runconfig"
  36. )
  37. func (b *Builder) commit(id string, autoCmd *stringutils.StrSlice, comment string) error {
  38. if b.disableCommit {
  39. return nil
  40. }
  41. if b.image == "" && !b.noBaseImage {
  42. return fmt.Errorf("Please provide a source image with `from` prior to commit")
  43. }
  44. b.runConfig.Image = b.image
  45. if id == "" {
  46. cmd := b.runConfig.Cmd
  47. if runtime.GOOS != "windows" {
  48. b.runConfig.Cmd = stringutils.NewStrSlice("/bin/sh", "-c", "#(nop) "+comment)
  49. } else {
  50. b.runConfig.Cmd = stringutils.NewStrSlice("cmd", "/S /C", "REM (nop) "+comment)
  51. }
  52. defer func(cmd *stringutils.StrSlice) { b.runConfig.Cmd = cmd }(cmd)
  53. hit, err := b.probeCache()
  54. if err != nil {
  55. return err
  56. } else if hit {
  57. return nil
  58. }
  59. id, err = b.create()
  60. if err != nil {
  61. return err
  62. }
  63. if err := b.docker.Mount(id); err != nil {
  64. return err
  65. }
  66. defer b.docker.Unmount(id)
  67. }
  68. // Note: Actually copy the struct
  69. autoConfig := *b.runConfig
  70. autoConfig.Cmd = autoCmd
  71. commitCfg := &types.ContainerCommitConfig{
  72. Author: b.maintainer,
  73. Pause: true,
  74. Config: &autoConfig,
  75. }
  76. // Commit the container
  77. imageID, err := b.docker.Commit(id, commitCfg)
  78. if err != nil {
  79. return err
  80. }
  81. b.image = imageID
  82. return nil
  83. }
  84. type copyInfo struct {
  85. builder.FileInfo
  86. decompress bool
  87. }
  88. func (b *Builder) runContextCommand(args []string, allowRemote bool, allowLocalDecompression bool, cmdName string) error {
  89. if b.context == nil {
  90. return fmt.Errorf("No context given. Impossible to use %s", cmdName)
  91. }
  92. if len(args) < 2 {
  93. return fmt.Errorf("Invalid %s format - at least two arguments required", cmdName)
  94. }
  95. // Work in daemon-specific filepath semantics
  96. dest := filepath.FromSlash(args[len(args)-1]) // last one is always the dest
  97. b.runConfig.Image = b.image
  98. var infos []copyInfo
  99. // Loop through each src file and calculate the info we need to
  100. // do the copy (e.g. hash value if cached). Don't actually do
  101. // the copy until we've looked at all src files
  102. var err error
  103. for _, orig := range args[0 : len(args)-1] {
  104. var fi builder.FileInfo
  105. decompress := allowLocalDecompression
  106. if urlutil.IsURL(orig) {
  107. if !allowRemote {
  108. return fmt.Errorf("Source can't be a URL for %s", cmdName)
  109. }
  110. fi, err = b.download(orig)
  111. if err != nil {
  112. return err
  113. }
  114. defer os.RemoveAll(filepath.Dir(fi.Path()))
  115. decompress = false
  116. infos = append(infos, copyInfo{fi, decompress})
  117. continue
  118. }
  119. // not a URL
  120. subInfos, err := b.calcCopyInfo(cmdName, orig, allowLocalDecompression, true)
  121. if err != nil {
  122. return err
  123. }
  124. infos = append(infos, subInfos...)
  125. }
  126. if len(infos) == 0 {
  127. return fmt.Errorf("No source files were specified")
  128. }
  129. if len(infos) > 1 && !strings.HasSuffix(dest, string(os.PathSeparator)) {
  130. return fmt.Errorf("When using %s with more than one source file, the destination must be a directory and end with a /", cmdName)
  131. }
  132. // For backwards compat, if there's just one info then use it as the
  133. // cache look-up string, otherwise hash 'em all into one
  134. var srcHash string
  135. var origPaths string
  136. if len(infos) == 1 {
  137. fi := infos[0].FileInfo
  138. origPaths = fi.Name()
  139. if hfi, ok := fi.(builder.Hashed); ok {
  140. srcHash = hfi.Hash()
  141. }
  142. } else {
  143. var hashs []string
  144. var origs []string
  145. for _, info := range infos {
  146. fi := info.FileInfo
  147. origs = append(origs, fi.Name())
  148. if hfi, ok := fi.(builder.Hashed); ok {
  149. hashs = append(hashs, hfi.Hash())
  150. }
  151. }
  152. hasher := sha256.New()
  153. hasher.Write([]byte(strings.Join(hashs, ",")))
  154. srcHash = "multi:" + hex.EncodeToString(hasher.Sum(nil))
  155. origPaths = strings.Join(origs, " ")
  156. }
  157. cmd := b.runConfig.Cmd
  158. if runtime.GOOS != "windows" {
  159. b.runConfig.Cmd = stringutils.NewStrSlice("/bin/sh", "-c", fmt.Sprintf("#(nop) %s %s in %s", cmdName, srcHash, dest))
  160. } else {
  161. b.runConfig.Cmd = stringutils.NewStrSlice("cmd", "/S", "/C", fmt.Sprintf("REM (nop) %s %s in %s", cmdName, srcHash, dest))
  162. }
  163. defer func(cmd *stringutils.StrSlice) { b.runConfig.Cmd = cmd }(cmd)
  164. if hit, err := b.probeCache(); err != nil {
  165. return err
  166. } else if hit {
  167. return nil
  168. }
  169. container, err := b.docker.ContainerCreate(&daemon.ContainerCreateConfig{Config: b.runConfig})
  170. if err != nil {
  171. return err
  172. }
  173. if err := b.docker.Mount(container.ID); err != nil {
  174. return err
  175. }
  176. defer b.docker.Unmount(container.ID)
  177. b.tmpContainers[container.ID] = struct{}{}
  178. comment := fmt.Sprintf("%s %s in %s", cmdName, origPaths, dest)
  179. // Twiddle the destination when its a relative path - meaning, make it
  180. // relative to the WORKINGDIR
  181. if !system.IsAbs(dest) {
  182. hasSlash := strings.HasSuffix(dest, string(os.PathSeparator))
  183. dest = filepath.Join(string(os.PathSeparator), filepath.FromSlash(b.runConfig.WorkingDir), dest)
  184. // Make sure we preserve any trailing slash
  185. if hasSlash {
  186. dest += string(os.PathSeparator)
  187. }
  188. }
  189. for _, info := range infos {
  190. if err := b.docker.BuilderCopy(container.ID, dest, info.FileInfo, info.decompress); err != nil {
  191. return err
  192. }
  193. }
  194. return b.commit(container.ID, cmd, comment)
  195. }
  196. func (b *Builder) download(srcURL string) (fi builder.FileInfo, err error) {
  197. // get filename from URL
  198. u, err := url.Parse(srcURL)
  199. if err != nil {
  200. return
  201. }
  202. path := filepath.FromSlash(u.Path) // Ensure in platform semantics
  203. if strings.HasSuffix(path, string(os.PathSeparator)) {
  204. path = path[:len(path)-1]
  205. }
  206. parts := strings.Split(path, string(os.PathSeparator))
  207. filename := parts[len(parts)-1]
  208. if filename == "" {
  209. err = fmt.Errorf("cannot determine filename from url: %s", u)
  210. return
  211. }
  212. // Initiate the download
  213. resp, err := httputils.Download(srcURL)
  214. if err != nil {
  215. return
  216. }
  217. // Prepare file in a tmp dir
  218. tmpDir, err := ioutils.TempDir("", "docker-remote")
  219. if err != nil {
  220. return
  221. }
  222. defer func() {
  223. if err != nil {
  224. os.RemoveAll(tmpDir)
  225. }
  226. }()
  227. tmpFileName := filepath.Join(tmpDir, filename)
  228. tmpFile, err := os.OpenFile(tmpFileName, os.O_RDWR|os.O_CREATE|os.O_EXCL, 0600)
  229. if err != nil {
  230. return
  231. }
  232. stdoutFormatter := b.Stdout.(*streamformatter.StdoutFormatter)
  233. progressOutput := stdoutFormatter.StreamFormatter.NewProgressOutput(stdoutFormatter.Writer, true)
  234. progressReader := progress.NewProgressReader(resp.Body, progressOutput, resp.ContentLength, "", "Downloading")
  235. // Download and dump result to tmp file
  236. if _, err = io.Copy(tmpFile, progressReader); err != nil {
  237. tmpFile.Close()
  238. return
  239. }
  240. fmt.Fprintln(b.Stdout)
  241. // ignoring error because the file was already opened successfully
  242. tmpFileSt, err := tmpFile.Stat()
  243. if err != nil {
  244. return
  245. }
  246. tmpFile.Close()
  247. // Set the mtime to the Last-Modified header value if present
  248. // Otherwise just remove atime and mtime
  249. mTime := time.Time{}
  250. lastMod := resp.Header.Get("Last-Modified")
  251. if lastMod != "" {
  252. // If we can't parse it then just let it default to 'zero'
  253. // otherwise use the parsed time value
  254. if parsedMTime, err := http.ParseTime(lastMod); err == nil {
  255. mTime = parsedMTime
  256. }
  257. }
  258. if err = system.Chtimes(tmpFileName, mTime, mTime); err != nil {
  259. return
  260. }
  261. // Calc the checksum, even if we're using the cache
  262. r, err := archive.Tar(tmpFileName, archive.Uncompressed)
  263. if err != nil {
  264. return
  265. }
  266. tarSum, err := tarsum.NewTarSum(r, true, tarsum.Version1)
  267. if err != nil {
  268. return
  269. }
  270. if _, err = io.Copy(ioutil.Discard, tarSum); err != nil {
  271. return
  272. }
  273. hash := tarSum.Sum(nil)
  274. r.Close()
  275. return &builder.HashedFileInfo{FileInfo: builder.PathFileInfo{FileInfo: tmpFileSt, FilePath: tmpFileName}, FileHash: hash}, nil
  276. }
  277. func (b *Builder) calcCopyInfo(cmdName, origPath string, allowLocalDecompression, allowWildcards bool) ([]copyInfo, error) {
  278. // Work in daemon-specific OS filepath semantics
  279. origPath = filepath.FromSlash(origPath)
  280. if origPath != "" && origPath[0] == os.PathSeparator && len(origPath) > 1 {
  281. origPath = origPath[1:]
  282. }
  283. origPath = strings.TrimPrefix(origPath, "."+string(os.PathSeparator))
  284. // Deal with wildcards
  285. if allowWildcards && containsWildcards(origPath) {
  286. var copyInfos []copyInfo
  287. if err := b.context.Walk("", func(path string, info builder.FileInfo, err error) error {
  288. if err != nil {
  289. return err
  290. }
  291. if info.Name() == "" {
  292. // Why are we doing this check?
  293. return nil
  294. }
  295. if match, _ := filepath.Match(origPath, path); !match {
  296. return nil
  297. }
  298. // Note we set allowWildcards to false in case the name has
  299. // a * in it
  300. subInfos, err := b.calcCopyInfo(cmdName, path, allowLocalDecompression, false)
  301. if err != nil {
  302. return err
  303. }
  304. copyInfos = append(copyInfos, subInfos...)
  305. return nil
  306. }); err != nil {
  307. return nil, err
  308. }
  309. return copyInfos, nil
  310. }
  311. // Must be a dir or a file
  312. statPath, fi, err := b.context.Stat(origPath)
  313. if err != nil {
  314. return nil, err
  315. }
  316. copyInfos := []copyInfo{{FileInfo: fi, decompress: allowLocalDecompression}}
  317. hfi, handleHash := fi.(builder.Hashed)
  318. if !handleHash {
  319. return copyInfos, nil
  320. }
  321. // Deal with the single file case
  322. if !fi.IsDir() {
  323. hfi.SetHash("file:" + hfi.Hash())
  324. return copyInfos, nil
  325. }
  326. // Must be a dir
  327. var subfiles []string
  328. err = b.context.Walk(statPath, func(path string, info builder.FileInfo, err error) error {
  329. if err != nil {
  330. return err
  331. }
  332. // we already checked handleHash above
  333. subfiles = append(subfiles, info.(builder.Hashed).Hash())
  334. return nil
  335. })
  336. if err != nil {
  337. return nil, err
  338. }
  339. sort.Strings(subfiles)
  340. hasher := sha256.New()
  341. hasher.Write([]byte(strings.Join(subfiles, ",")))
  342. hfi.SetHash("dir:" + hex.EncodeToString(hasher.Sum(nil)))
  343. return copyInfos, nil
  344. }
  345. func containsWildcards(name string) bool {
  346. for i := 0; i < len(name); i++ {
  347. ch := name[i]
  348. if ch == '\\' {
  349. i++
  350. } else if ch == '*' || ch == '?' || ch == '[' {
  351. return true
  352. }
  353. }
  354. return false
  355. }
  356. func (b *Builder) processImageFrom(img builder.Image) error {
  357. b.image = img.ID()
  358. if img.Config != nil {
  359. b.runConfig = img.Config()
  360. }
  361. // The default path will be blank on Windows (set by HCS)
  362. if len(b.runConfig.Env) == 0 && system.DefaultPathEnv != "" {
  363. b.runConfig.Env = append(b.runConfig.Env, "PATH="+system.DefaultPathEnv)
  364. }
  365. // Process ONBUILD triggers if they exist
  366. if nTriggers := len(b.runConfig.OnBuild); nTriggers != 0 {
  367. word := "trigger"
  368. if nTriggers > 1 {
  369. word = "triggers"
  370. }
  371. fmt.Fprintf(b.Stderr, "# Executing %d build %s...\n", nTriggers, word)
  372. }
  373. // Copy the ONBUILD triggers, and remove them from the config, since the config will be committed.
  374. onBuildTriggers := b.runConfig.OnBuild
  375. b.runConfig.OnBuild = []string{}
  376. // parse the ONBUILD triggers by invoking the parser
  377. for _, step := range onBuildTriggers {
  378. ast, err := parser.Parse(strings.NewReader(step))
  379. if err != nil {
  380. return err
  381. }
  382. for i, n := range ast.Children {
  383. switch strings.ToUpper(n.Value) {
  384. case "ONBUILD":
  385. return fmt.Errorf("Chaining ONBUILD via `ONBUILD ONBUILD` isn't allowed")
  386. case "MAINTAINER", "FROM":
  387. return fmt.Errorf("%s isn't allowed as an ONBUILD trigger", n.Value)
  388. }
  389. if err := b.dispatch(i, n); err != nil {
  390. return err
  391. }
  392. }
  393. }
  394. return nil
  395. }
  396. // probeCache checks if `b.docker` implements builder.ImageCache and image-caching
  397. // is enabled (`b.UseCache`).
  398. // If so attempts to look up the current `b.image` and `b.runConfig` pair with `b.docker`.
  399. // If an image is found, probeCache returns `(true, nil)`.
  400. // If no image is found, it returns `(false, nil)`.
  401. // If there is any error, it returns `(false, err)`.
  402. func (b *Builder) probeCache() (bool, error) {
  403. c, ok := b.docker.(builder.ImageCache)
  404. if !ok || !b.UseCache || b.cacheBusted {
  405. return false, nil
  406. }
  407. cache, err := c.GetCachedImage(b.image, b.runConfig)
  408. if err != nil {
  409. return false, err
  410. }
  411. if len(cache) == 0 {
  412. logrus.Debugf("[BUILDER] Cache miss: %s", b.runConfig.Cmd)
  413. b.cacheBusted = true
  414. return false, nil
  415. }
  416. fmt.Fprintf(b.Stdout, " ---> Using cache\n")
  417. logrus.Debugf("[BUILDER] Use cached version: %s", b.runConfig.Cmd)
  418. b.image = string(cache)
  419. return true, nil
  420. }
  421. func (b *Builder) create() (string, error) {
  422. if b.image == "" && !b.noBaseImage {
  423. return "", fmt.Errorf("Please provide a source image with `from` prior to run")
  424. }
  425. b.runConfig.Image = b.image
  426. resources := runconfig.Resources{
  427. CgroupParent: b.CgroupParent,
  428. CPUShares: b.CPUShares,
  429. CPUPeriod: b.CPUPeriod,
  430. CPUQuota: b.CPUQuota,
  431. CpusetCpus: b.CPUSetCpus,
  432. CpusetMems: b.CPUSetMems,
  433. Memory: b.Memory,
  434. MemorySwap: b.MemorySwap,
  435. Ulimits: b.Ulimits,
  436. }
  437. // TODO: why not embed a hostconfig in builder?
  438. hostConfig := &runconfig.HostConfig{
  439. Isolation: b.Isolation,
  440. ShmSize: b.ShmSize,
  441. Resources: resources,
  442. }
  443. config := *b.runConfig
  444. // Create the container
  445. c, err := b.docker.ContainerCreate(&daemon.ContainerCreateConfig{
  446. Config: b.runConfig,
  447. HostConfig: hostConfig,
  448. })
  449. if err != nil {
  450. return "", err
  451. }
  452. for _, warning := range c.Warnings {
  453. fmt.Fprintf(b.Stdout, " ---> [Warning] %s\n", warning)
  454. }
  455. b.tmpContainers[c.ID] = struct{}{}
  456. fmt.Fprintf(b.Stdout, " ---> Running in %s\n", stringid.TruncateID(c.ID))
  457. if config.Cmd.Len() > 0 {
  458. // override the entry point that may have been picked up from the base image
  459. if err := b.docker.ContainerUpdateCmd(c.ID, config.Cmd.Slice()); err != nil {
  460. return "", err
  461. }
  462. }
  463. return c.ID, nil
  464. }
  465. func (b *Builder) run(cID string) (err error) {
  466. errCh := make(chan error)
  467. if b.Verbose {
  468. go func() {
  469. errCh <- b.docker.ContainerWsAttachWithLogs(cID, &daemon.ContainerWsAttachWithLogsConfig{
  470. OutStream: b.Stdout,
  471. ErrStream: b.Stderr,
  472. Stream: true,
  473. })
  474. }()
  475. }
  476. finished := make(chan struct{})
  477. defer close(finished)
  478. go func() {
  479. select {
  480. case <-b.cancelled:
  481. logrus.Debugln("Build cancelled, killing and removing container:", cID)
  482. b.docker.ContainerKill(cID, 0)
  483. b.removeContainer(cID)
  484. case <-finished:
  485. }
  486. }()
  487. if err := b.docker.ContainerStart(cID, nil); err != nil {
  488. return err
  489. }
  490. if b.Verbose {
  491. // Block on reading output from container, stop on err or chan closed
  492. if err := <-errCh; err != nil {
  493. return err
  494. }
  495. }
  496. if ret, _ := b.docker.ContainerWait(cID, -1); ret != 0 {
  497. // TODO: change error type, because jsonmessage.JSONError assumes HTTP
  498. return &jsonmessage.JSONError{
  499. Message: fmt.Sprintf("The command '%s' returned a non-zero code: %d", b.runConfig.Cmd.ToString(), ret),
  500. Code: ret,
  501. }
  502. }
  503. return nil
  504. }
  505. func (b *Builder) removeContainer(c string) error {
  506. rmConfig := &types.ContainerRmConfig{
  507. ForceRemove: true,
  508. RemoveVolume: true,
  509. }
  510. if err := b.docker.ContainerRm(c, rmConfig); err != nil {
  511. fmt.Fprintf(b.Stdout, "Error removing intermediate container %s: %v\n", stringid.TruncateID(c), err)
  512. return err
  513. }
  514. return nil
  515. }
  516. func (b *Builder) clearTmp() {
  517. for c := range b.tmpContainers {
  518. if err := b.removeContainer(c); err != nil {
  519. return
  520. }
  521. delete(b.tmpContainers, c)
  522. fmt.Fprintf(b.Stdout, "Removing intermediate container %s\n", stringid.TruncateID(c))
  523. }
  524. }
  525. // readDockerfile reads a Dockerfile from the current context.
  526. func (b *Builder) readDockerfile() error {
  527. // If no -f was specified then look for 'Dockerfile'. If we can't find
  528. // that then look for 'dockerfile'. If neither are found then default
  529. // back to 'Dockerfile' and use that in the error message.
  530. if b.DockerfileName == "" {
  531. b.DockerfileName = api.DefaultDockerfileName
  532. if _, _, err := b.context.Stat(b.DockerfileName); os.IsNotExist(err) {
  533. lowercase := strings.ToLower(b.DockerfileName)
  534. if _, _, err := b.context.Stat(lowercase); err == nil {
  535. b.DockerfileName = lowercase
  536. }
  537. }
  538. }
  539. f, err := b.context.Open(b.DockerfileName)
  540. if err != nil {
  541. if os.IsNotExist(err) {
  542. return fmt.Errorf("Cannot locate specified Dockerfile: %s", b.DockerfileName)
  543. }
  544. return err
  545. }
  546. if f, ok := f.(*os.File); ok {
  547. // ignoring error because Open already succeeded
  548. fi, err := f.Stat()
  549. if err != nil {
  550. return fmt.Errorf("Unexpected error reading Dockerfile: %v", err)
  551. }
  552. if fi.Size() == 0 {
  553. return fmt.Errorf("The Dockerfile (%s) cannot be empty", b.DockerfileName)
  554. }
  555. }
  556. b.dockerfile, err = parser.Parse(f)
  557. f.Close()
  558. if err != nil {
  559. return err
  560. }
  561. // After the Dockerfile has been parsed, we need to check the .dockerignore
  562. // file for either "Dockerfile" or ".dockerignore", and if either are
  563. // present then erase them from the build context. These files should never
  564. // have been sent from the client but we did send them to make sure that
  565. // we had the Dockerfile to actually parse, and then we also need the
  566. // .dockerignore file to know whether either file should be removed.
  567. // Note that this assumes the Dockerfile has been read into memory and
  568. // is now safe to be removed.
  569. if dockerIgnore, ok := b.context.(builder.DockerIgnoreContext); ok {
  570. dockerIgnore.Process([]string{b.DockerfileName})
  571. }
  572. return nil
  573. }
  574. // determine if build arg is part of built-in args or user
  575. // defined args in Dockerfile at any point in time.
  576. func (b *Builder) isBuildArgAllowed(arg string) bool {
  577. if _, ok := BuiltinAllowedBuildArgs[arg]; ok {
  578. return true
  579. }
  580. if _, ok := b.allowedBuildArgs[arg]; ok {
  581. return true
  582. }
  583. return false
  584. }