update.go 12 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424
  1. package service
  2. import (
  3. "fmt"
  4. "strings"
  5. "time"
  6. "golang.org/x/net/context"
  7. "github.com/docker/docker/api/client"
  8. "github.com/docker/docker/cli"
  9. "github.com/docker/docker/opts"
  10. runconfigopts "github.com/docker/docker/runconfig/opts"
  11. "github.com/docker/engine-api/types"
  12. "github.com/docker/engine-api/types/swarm"
  13. "github.com/docker/go-connections/nat"
  14. shlex "github.com/flynn-archive/go-shlex"
  15. "github.com/spf13/cobra"
  16. "github.com/spf13/pflag"
  17. )
  18. func newUpdateCommand(dockerCli *client.DockerCli) *cobra.Command {
  19. opts := newServiceOptions()
  20. cmd := &cobra.Command{
  21. Use: "update [OPTIONS] SERVICE",
  22. Short: "Update a service",
  23. Args: cli.ExactArgs(1),
  24. RunE: func(cmd *cobra.Command, args []string) error {
  25. return runUpdate(dockerCli, cmd.Flags(), args[0])
  26. },
  27. }
  28. flags := cmd.Flags()
  29. flags.String("image", "", "Service image tag")
  30. flags.String("args", "", "Service command args")
  31. addServiceFlags(cmd, opts)
  32. flags.Var(newListOptsVar(), flagEnvRemove, "Remove an environment variable")
  33. flags.Var(newListOptsVar(), flagLabelRemove, "Remove a label by its key")
  34. flags.Var(newListOptsVar(), flagContainerLabelRemove, "Remove a container label by its key")
  35. flags.Var(newListOptsVar(), flagMountRemove, "Remove a mount by its target path")
  36. flags.Var(newListOptsVar(), flagPublishRemove, "Remove a published port by its target port")
  37. flags.Var(newListOptsVar(), flagConstraintRemove, "Remove a constraint")
  38. flags.Var(&opts.labels, flagLabelAdd, "Add or update service labels")
  39. flags.Var(&opts.containerLabels, flagContainerLabelAdd, "Add or update container labels")
  40. flags.Var(&opts.env, flagEnvAdd, "Add or update environment variables")
  41. flags.Var(&opts.mounts, flagMountAdd, "Add or update a mount on a service")
  42. flags.StringSliceVar(&opts.constraints, flagConstraintAdd, []string{}, "Add or update placement constraints")
  43. flags.Var(&opts.endpoint.ports, flagPublishAdd, "Add or update a published port")
  44. return cmd
  45. }
  46. func newListOptsVar() *opts.ListOpts {
  47. return opts.NewListOptsRef(&[]string{}, nil)
  48. }
  49. func runUpdate(dockerCli *client.DockerCli, flags *pflag.FlagSet, serviceID string) error {
  50. apiClient := dockerCli.Client()
  51. ctx := context.Background()
  52. updateOpts := types.ServiceUpdateOptions{}
  53. service, _, err := apiClient.ServiceInspectWithRaw(ctx, serviceID)
  54. if err != nil {
  55. return err
  56. }
  57. err = updateService(flags, &service.Spec)
  58. if err != nil {
  59. return err
  60. }
  61. // only send auth if flag was set
  62. sendAuth, err := flags.GetBool(flagRegistryAuth)
  63. if err != nil {
  64. return err
  65. }
  66. if sendAuth {
  67. // Retrieve encoded auth token from the image reference
  68. // This would be the old image if it didn't change in this update
  69. image := service.Spec.TaskTemplate.ContainerSpec.Image
  70. encodedAuth, err := dockerCli.RetrieveAuthTokenFromImage(ctx, image)
  71. if err != nil {
  72. return err
  73. }
  74. updateOpts.EncodedRegistryAuth = encodedAuth
  75. }
  76. err = apiClient.ServiceUpdate(ctx, service.ID, service.Version, service.Spec, updateOpts)
  77. if err != nil {
  78. return err
  79. }
  80. fmt.Fprintf(dockerCli.Out(), "%s\n", serviceID)
  81. return nil
  82. }
  83. func updateService(flags *pflag.FlagSet, spec *swarm.ServiceSpec) error {
  84. updateString := func(flag string, field *string) {
  85. if flags.Changed(flag) {
  86. *field, _ = flags.GetString(flag)
  87. }
  88. }
  89. updateInt64Value := func(flag string, field *int64) {
  90. if flags.Changed(flag) {
  91. *field = flags.Lookup(flag).Value.(int64Value).Value()
  92. }
  93. }
  94. updateDuration := func(flag string, field *time.Duration) {
  95. if flags.Changed(flag) {
  96. *field, _ = flags.GetDuration(flag)
  97. }
  98. }
  99. updateDurationOpt := func(flag string, field **time.Duration) {
  100. if flags.Changed(flag) {
  101. val := *flags.Lookup(flag).Value.(*DurationOpt).Value()
  102. *field = &val
  103. }
  104. }
  105. updateUint64 := func(flag string, field *uint64) {
  106. if flags.Changed(flag) {
  107. *field, _ = flags.GetUint64(flag)
  108. }
  109. }
  110. updateUint64Opt := func(flag string, field **uint64) {
  111. if flags.Changed(flag) {
  112. val := *flags.Lookup(flag).Value.(*Uint64Opt).Value()
  113. *field = &val
  114. }
  115. }
  116. cspec := &spec.TaskTemplate.ContainerSpec
  117. task := &spec.TaskTemplate
  118. taskResources := func() *swarm.ResourceRequirements {
  119. if task.Resources == nil {
  120. task.Resources = &swarm.ResourceRequirements{}
  121. }
  122. return task.Resources
  123. }
  124. updateString(flagName, &spec.Name)
  125. updateLabels(flags, &spec.Labels)
  126. updateContainerLabels(flags, &cspec.Labels)
  127. updateString("image", &cspec.Image)
  128. updateStringToSlice(flags, "args", &cspec.Args)
  129. updateEnvironment(flags, &cspec.Env)
  130. updateString("workdir", &cspec.Dir)
  131. updateString(flagUser, &cspec.User)
  132. updateMounts(flags, &cspec.Mounts)
  133. if flags.Changed(flagLimitCPU) || flags.Changed(flagLimitMemory) {
  134. taskResources().Limits = &swarm.Resources{}
  135. updateInt64Value(flagLimitCPU, &task.Resources.Limits.NanoCPUs)
  136. updateInt64Value(flagLimitMemory, &task.Resources.Limits.MemoryBytes)
  137. }
  138. if flags.Changed(flagReserveCPU) || flags.Changed(flagReserveMemory) {
  139. taskResources().Reservations = &swarm.Resources{}
  140. updateInt64Value(flagReserveCPU, &task.Resources.Reservations.NanoCPUs)
  141. updateInt64Value(flagReserveMemory, &task.Resources.Reservations.MemoryBytes)
  142. }
  143. updateDurationOpt(flagStopGracePeriod, &cspec.StopGracePeriod)
  144. if anyChanged(flags, flagRestartCondition, flagRestartDelay, flagRestartMaxAttempts, flagRestartWindow) {
  145. if task.RestartPolicy == nil {
  146. task.RestartPolicy = &swarm.RestartPolicy{}
  147. }
  148. if flags.Changed(flagRestartCondition) {
  149. value, _ := flags.GetString(flagRestartCondition)
  150. task.RestartPolicy.Condition = swarm.RestartPolicyCondition(value)
  151. }
  152. updateDurationOpt(flagRestartDelay, &task.RestartPolicy.Delay)
  153. updateUint64Opt(flagRestartMaxAttempts, &task.RestartPolicy.MaxAttempts)
  154. updateDurationOpt(flagRestartWindow, &task.RestartPolicy.Window)
  155. }
  156. if anyChanged(flags, flagConstraintAdd, flagConstraintRemove) {
  157. if task.Placement == nil {
  158. task.Placement = &swarm.Placement{}
  159. }
  160. updatePlacement(flags, task.Placement)
  161. }
  162. if err := updateReplicas(flags, &spec.Mode); err != nil {
  163. return err
  164. }
  165. if anyChanged(flags, flagUpdateParallelism, flagUpdateDelay, flagUpdateFailureAction) {
  166. if spec.UpdateConfig == nil {
  167. spec.UpdateConfig = &swarm.UpdateConfig{}
  168. }
  169. updateUint64(flagUpdateParallelism, &spec.UpdateConfig.Parallelism)
  170. updateDuration(flagUpdateDelay, &spec.UpdateConfig.Delay)
  171. updateString(flagUpdateFailureAction, &spec.UpdateConfig.FailureAction)
  172. }
  173. if flags.Changed(flagEndpointMode) {
  174. value, _ := flags.GetString(flagEndpointMode)
  175. if spec.EndpointSpec == nil {
  176. spec.EndpointSpec = &swarm.EndpointSpec{}
  177. }
  178. spec.EndpointSpec.Mode = swarm.ResolutionMode(value)
  179. }
  180. if anyChanged(flags, flagPublishAdd, flagPublishRemove) {
  181. if spec.EndpointSpec == nil {
  182. spec.EndpointSpec = &swarm.EndpointSpec{}
  183. }
  184. updatePorts(flags, &spec.EndpointSpec.Ports)
  185. }
  186. if err := updateLogDriver(flags, &spec.TaskTemplate); err != nil {
  187. return err
  188. }
  189. return nil
  190. }
  191. func updateStringToSlice(flags *pflag.FlagSet, flag string, field *[]string) error {
  192. if !flags.Changed(flag) {
  193. return nil
  194. }
  195. value, _ := flags.GetString(flag)
  196. valueSlice, err := shlex.Split(value)
  197. *field = valueSlice
  198. return err
  199. }
  200. func anyChanged(flags *pflag.FlagSet, fields ...string) bool {
  201. for _, flag := range fields {
  202. if flags.Changed(flag) {
  203. return true
  204. }
  205. }
  206. return false
  207. }
  208. func updatePlacement(flags *pflag.FlagSet, placement *swarm.Placement) {
  209. field, _ := flags.GetStringSlice(flagConstraintAdd)
  210. placement.Constraints = append(placement.Constraints, field...)
  211. toRemove := buildToRemoveSet(flags, flagConstraintRemove)
  212. placement.Constraints = removeItems(placement.Constraints, toRemove, itemKey)
  213. }
  214. func updateContainerLabels(flags *pflag.FlagSet, field *map[string]string) {
  215. if flags.Changed(flagContainerLabelAdd) {
  216. if *field == nil {
  217. *field = map[string]string{}
  218. }
  219. values := flags.Lookup(flagContainerLabelAdd).Value.(*opts.ListOpts).GetAll()
  220. for key, value := range runconfigopts.ConvertKVStringsToMap(values) {
  221. (*field)[key] = value
  222. }
  223. }
  224. if *field != nil && flags.Changed(flagContainerLabelRemove) {
  225. toRemove := flags.Lookup(flagContainerLabelRemove).Value.(*opts.ListOpts).GetAll()
  226. for _, label := range toRemove {
  227. delete(*field, label)
  228. }
  229. }
  230. }
  231. func updateLabels(flags *pflag.FlagSet, field *map[string]string) {
  232. if flags.Changed(flagLabelAdd) {
  233. if *field == nil {
  234. *field = map[string]string{}
  235. }
  236. values := flags.Lookup(flagLabelAdd).Value.(*opts.ListOpts).GetAll()
  237. for key, value := range runconfigopts.ConvertKVStringsToMap(values) {
  238. (*field)[key] = value
  239. }
  240. }
  241. if *field != nil && flags.Changed(flagLabelRemove) {
  242. toRemove := flags.Lookup(flagLabelRemove).Value.(*opts.ListOpts).GetAll()
  243. for _, label := range toRemove {
  244. delete(*field, label)
  245. }
  246. }
  247. }
  248. func updateEnvironment(flags *pflag.FlagSet, field *[]string) {
  249. if flags.Changed(flagEnvAdd) {
  250. value := flags.Lookup(flagEnvAdd).Value.(*opts.ListOpts)
  251. *field = append(*field, value.GetAll()...)
  252. }
  253. toRemove := buildToRemoveSet(flags, flagEnvRemove)
  254. *field = removeItems(*field, toRemove, envKey)
  255. }
  256. func envKey(value string) string {
  257. kv := strings.SplitN(value, "=", 2)
  258. return kv[0]
  259. }
  260. func itemKey(value string) string {
  261. return value
  262. }
  263. func buildToRemoveSet(flags *pflag.FlagSet, flag string) map[string]struct{} {
  264. var empty struct{}
  265. toRemove := make(map[string]struct{})
  266. if !flags.Changed(flag) {
  267. return toRemove
  268. }
  269. toRemoveSlice := flags.Lookup(flag).Value.(*opts.ListOpts).GetAll()
  270. for _, key := range toRemoveSlice {
  271. toRemove[key] = empty
  272. }
  273. return toRemove
  274. }
  275. func removeItems(
  276. seq []string,
  277. toRemove map[string]struct{},
  278. keyFunc func(string) string,
  279. ) []string {
  280. newSeq := []string{}
  281. for _, item := range seq {
  282. if _, exists := toRemove[keyFunc(item)]; !exists {
  283. newSeq = append(newSeq, item)
  284. }
  285. }
  286. return newSeq
  287. }
  288. func updateMounts(flags *pflag.FlagSet, mounts *[]swarm.Mount) {
  289. if flags.Changed(flagMountAdd) {
  290. values := flags.Lookup(flagMountAdd).Value.(*MountOpt).Value()
  291. *mounts = append(*mounts, values...)
  292. }
  293. toRemove := buildToRemoveSet(flags, flagMountRemove)
  294. newMounts := []swarm.Mount{}
  295. for _, mount := range *mounts {
  296. if _, exists := toRemove[mount.Target]; !exists {
  297. newMounts = append(newMounts, mount)
  298. }
  299. }
  300. *mounts = newMounts
  301. }
  302. func updatePorts(flags *pflag.FlagSet, portConfig *[]swarm.PortConfig) {
  303. if flags.Changed(flagPublishAdd) {
  304. values := flags.Lookup(flagPublishAdd).Value.(*opts.ListOpts).GetAll()
  305. ports, portBindings, _ := nat.ParsePortSpecs(values)
  306. for port := range ports {
  307. *portConfig = append(*portConfig, convertPortToPortConfig(port, portBindings)...)
  308. }
  309. }
  310. if !flags.Changed(flagPublishRemove) {
  311. return
  312. }
  313. toRemove := flags.Lookup(flagPublishRemove).Value.(*opts.ListOpts).GetAll()
  314. newPorts := []swarm.PortConfig{}
  315. portLoop:
  316. for _, port := range *portConfig {
  317. for _, rawTargetPort := range toRemove {
  318. targetPort := nat.Port(rawTargetPort)
  319. if equalPort(targetPort, port) {
  320. continue portLoop
  321. }
  322. }
  323. newPorts = append(newPorts, port)
  324. }
  325. *portConfig = newPorts
  326. }
  327. func equalPort(targetPort nat.Port, port swarm.PortConfig) bool {
  328. return (string(port.Protocol) == targetPort.Proto() &&
  329. port.TargetPort == uint32(targetPort.Int()))
  330. }
  331. func updateReplicas(flags *pflag.FlagSet, serviceMode *swarm.ServiceMode) error {
  332. if !flags.Changed(flagReplicas) {
  333. return nil
  334. }
  335. if serviceMode == nil || serviceMode.Replicated == nil {
  336. return fmt.Errorf("replicas can only be used with replicated mode")
  337. }
  338. serviceMode.Replicated.Replicas = flags.Lookup(flagReplicas).Value.(*Uint64Opt).Value()
  339. return nil
  340. }
  341. // updateLogDriver updates the log driver only if the log driver flag is set.
  342. // All options will be replaced with those provided on the command line.
  343. func updateLogDriver(flags *pflag.FlagSet, taskTemplate *swarm.TaskSpec) error {
  344. if !flags.Changed(flagLogDriver) {
  345. return nil
  346. }
  347. name, err := flags.GetString(flagLogDriver)
  348. if err != nil {
  349. return err
  350. }
  351. if name == "" {
  352. return nil
  353. }
  354. taskTemplate.LogDriver = &swarm.Driver{
  355. Name: name,
  356. Options: runconfigopts.ConvertKVStringsToMap(flags.Lookup(flagLogOpt).Value.(*opts.ListOpts).GetAll()),
  357. }
  358. return nil
  359. }