internals.go 18 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669
  1. package dockerfile
  2. // internals for handling commands. Covers many areas and a lot of
  3. // non-contiguous functionality. Please read the comments.
  4. import (
  5. "crypto/sha256"
  6. "encoding/hex"
  7. "errors"
  8. "fmt"
  9. "io"
  10. "io/ioutil"
  11. "net/http"
  12. "net/url"
  13. "os"
  14. "path/filepath"
  15. "sort"
  16. "strings"
  17. "sync"
  18. "time"
  19. "github.com/Sirupsen/logrus"
  20. "github.com/docker/docker/api/types/backend"
  21. "github.com/docker/docker/builder"
  22. "github.com/docker/docker/builder/dockerfile/parser"
  23. "github.com/docker/docker/pkg/archive"
  24. "github.com/docker/docker/pkg/httputils"
  25. "github.com/docker/docker/pkg/ioutils"
  26. "github.com/docker/docker/pkg/jsonmessage"
  27. "github.com/docker/docker/pkg/progress"
  28. "github.com/docker/docker/pkg/streamformatter"
  29. "github.com/docker/docker/pkg/stringid"
  30. "github.com/docker/docker/pkg/system"
  31. "github.com/docker/docker/pkg/tarsum"
  32. "github.com/docker/docker/pkg/urlutil"
  33. "github.com/docker/docker/runconfig/opts"
  34. "github.com/docker/engine-api/types"
  35. "github.com/docker/engine-api/types/container"
  36. "github.com/docker/engine-api/types/strslice"
  37. )
  38. func (b *Builder) commit(id string, autoCmd strslice.StrSlice, comment string) error {
  39. if b.disableCommit {
  40. return nil
  41. }
  42. if b.image == "" && !b.noBaseImage {
  43. return fmt.Errorf("Please provide a source image with `from` prior to commit")
  44. }
  45. b.runConfig.Image = b.image
  46. if id == "" {
  47. cmd := b.runConfig.Cmd
  48. b.runConfig.Cmd = strslice.StrSlice(append(getShell(b.runConfig), "#(nop) ", comment))
  49. defer func(cmd strslice.StrSlice) { b.runConfig.Cmd = cmd }(cmd)
  50. hit, err := b.probeCache()
  51. if err != nil {
  52. return err
  53. } else if hit {
  54. return nil
  55. }
  56. id, err = b.create()
  57. if err != nil {
  58. return err
  59. }
  60. }
  61. // Note: Actually copy the struct
  62. autoConfig := *b.runConfig
  63. autoConfig.Cmd = autoCmd
  64. commitCfg := &backend.ContainerCommitConfig{
  65. ContainerCommitConfig: types.ContainerCommitConfig{
  66. Author: b.maintainer,
  67. Pause: true,
  68. Config: &autoConfig,
  69. },
  70. }
  71. // Commit the container
  72. imageID, err := b.docker.Commit(id, commitCfg)
  73. if err != nil {
  74. return err
  75. }
  76. b.image = imageID
  77. return nil
  78. }
  79. type copyInfo struct {
  80. builder.FileInfo
  81. decompress bool
  82. }
  83. func (b *Builder) runContextCommand(args []string, allowRemote bool, allowLocalDecompression bool, cmdName string) error {
  84. if b.context == nil {
  85. return fmt.Errorf("No context given. Impossible to use %s", cmdName)
  86. }
  87. if len(args) < 2 {
  88. return fmt.Errorf("Invalid %s format - at least two arguments required", cmdName)
  89. }
  90. // Work in daemon-specific filepath semantics
  91. dest := filepath.FromSlash(args[len(args)-1]) // last one is always the dest
  92. b.runConfig.Image = b.image
  93. var infos []copyInfo
  94. // Loop through each src file and calculate the info we need to
  95. // do the copy (e.g. hash value if cached). Don't actually do
  96. // the copy until we've looked at all src files
  97. var err error
  98. for _, orig := range args[0 : len(args)-1] {
  99. var fi builder.FileInfo
  100. decompress := allowLocalDecompression
  101. if urlutil.IsURL(orig) {
  102. if !allowRemote {
  103. return fmt.Errorf("Source can't be a URL for %s", cmdName)
  104. }
  105. fi, err = b.download(orig)
  106. if err != nil {
  107. return err
  108. }
  109. defer os.RemoveAll(filepath.Dir(fi.Path()))
  110. decompress = false
  111. infos = append(infos, copyInfo{fi, decompress})
  112. continue
  113. }
  114. // not a URL
  115. subInfos, err := b.calcCopyInfo(cmdName, orig, allowLocalDecompression, true)
  116. if err != nil {
  117. return err
  118. }
  119. infos = append(infos, subInfos...)
  120. }
  121. if len(infos) == 0 {
  122. return fmt.Errorf("No source files were specified")
  123. }
  124. if len(infos) > 1 && !strings.HasSuffix(dest, string(os.PathSeparator)) {
  125. return fmt.Errorf("When using %s with more than one source file, the destination must be a directory and end with a /", cmdName)
  126. }
  127. // For backwards compat, if there's just one info then use it as the
  128. // cache look-up string, otherwise hash 'em all into one
  129. var srcHash string
  130. var origPaths string
  131. if len(infos) == 1 {
  132. fi := infos[0].FileInfo
  133. origPaths = fi.Name()
  134. if hfi, ok := fi.(builder.Hashed); ok {
  135. srcHash = hfi.Hash()
  136. }
  137. } else {
  138. var hashs []string
  139. var origs []string
  140. for _, info := range infos {
  141. fi := info.FileInfo
  142. origs = append(origs, fi.Name())
  143. if hfi, ok := fi.(builder.Hashed); ok {
  144. hashs = append(hashs, hfi.Hash())
  145. }
  146. }
  147. hasher := sha256.New()
  148. hasher.Write([]byte(strings.Join(hashs, ",")))
  149. srcHash = "multi:" + hex.EncodeToString(hasher.Sum(nil))
  150. origPaths = strings.Join(origs, " ")
  151. }
  152. cmd := b.runConfig.Cmd
  153. b.runConfig.Cmd = strslice.StrSlice(append(getShell(b.runConfig), fmt.Sprintf("#(nop) %s %s in %s ", cmdName, srcHash, dest)))
  154. defer func(cmd strslice.StrSlice) { b.runConfig.Cmd = cmd }(cmd)
  155. if hit, err := b.probeCache(); err != nil {
  156. return err
  157. } else if hit {
  158. return nil
  159. }
  160. container, err := b.docker.ContainerCreate(types.ContainerCreateConfig{Config: b.runConfig}, true)
  161. if err != nil {
  162. return err
  163. }
  164. b.tmpContainers[container.ID] = struct{}{}
  165. comment := fmt.Sprintf("%s %s in %s", cmdName, origPaths, dest)
  166. // Twiddle the destination when its a relative path - meaning, make it
  167. // relative to the WORKINGDIR
  168. if dest, err = normaliseDest(cmdName, b.runConfig.WorkingDir, dest); err != nil {
  169. return err
  170. }
  171. for _, info := range infos {
  172. if err := b.docker.CopyOnBuild(container.ID, dest, info.FileInfo, info.decompress); err != nil {
  173. return err
  174. }
  175. }
  176. return b.commit(container.ID, cmd, comment)
  177. }
  178. func (b *Builder) download(srcURL string) (fi builder.FileInfo, err error) {
  179. // get filename from URL
  180. u, err := url.Parse(srcURL)
  181. if err != nil {
  182. return
  183. }
  184. path := filepath.FromSlash(u.Path) // Ensure in platform semantics
  185. if strings.HasSuffix(path, string(os.PathSeparator)) {
  186. path = path[:len(path)-1]
  187. }
  188. parts := strings.Split(path, string(os.PathSeparator))
  189. filename := parts[len(parts)-1]
  190. if filename == "" {
  191. err = fmt.Errorf("cannot determine filename from url: %s", u)
  192. return
  193. }
  194. // Initiate the download
  195. resp, err := httputils.Download(srcURL)
  196. if err != nil {
  197. return
  198. }
  199. // Prepare file in a tmp dir
  200. tmpDir, err := ioutils.TempDir("", "docker-remote")
  201. if err != nil {
  202. return
  203. }
  204. defer func() {
  205. if err != nil {
  206. os.RemoveAll(tmpDir)
  207. }
  208. }()
  209. tmpFileName := filepath.Join(tmpDir, filename)
  210. tmpFile, err := os.OpenFile(tmpFileName, os.O_RDWR|os.O_CREATE|os.O_EXCL, 0600)
  211. if err != nil {
  212. return
  213. }
  214. stdoutFormatter := b.Stdout.(*streamformatter.StdoutFormatter)
  215. progressOutput := stdoutFormatter.StreamFormatter.NewProgressOutput(stdoutFormatter.Writer, true)
  216. progressReader := progress.NewProgressReader(resp.Body, progressOutput, resp.ContentLength, "", "Downloading")
  217. // Download and dump result to tmp file
  218. if _, err = io.Copy(tmpFile, progressReader); err != nil {
  219. tmpFile.Close()
  220. return
  221. }
  222. fmt.Fprintln(b.Stdout)
  223. // ignoring error because the file was already opened successfully
  224. tmpFileSt, err := tmpFile.Stat()
  225. if err != nil {
  226. return
  227. }
  228. tmpFile.Close()
  229. // Set the mtime to the Last-Modified header value if present
  230. // Otherwise just remove atime and mtime
  231. mTime := time.Time{}
  232. lastMod := resp.Header.Get("Last-Modified")
  233. if lastMod != "" {
  234. // If we can't parse it then just let it default to 'zero'
  235. // otherwise use the parsed time value
  236. if parsedMTime, err := http.ParseTime(lastMod); err == nil {
  237. mTime = parsedMTime
  238. }
  239. }
  240. if err = system.Chtimes(tmpFileName, mTime, mTime); err != nil {
  241. return
  242. }
  243. // Calc the checksum, even if we're using the cache
  244. r, err := archive.Tar(tmpFileName, archive.Uncompressed)
  245. if err != nil {
  246. return
  247. }
  248. tarSum, err := tarsum.NewTarSum(r, true, tarsum.Version1)
  249. if err != nil {
  250. return
  251. }
  252. if _, err = io.Copy(ioutil.Discard, tarSum); err != nil {
  253. return
  254. }
  255. hash := tarSum.Sum(nil)
  256. r.Close()
  257. return &builder.HashedFileInfo{FileInfo: builder.PathFileInfo{FileInfo: tmpFileSt, FilePath: tmpFileName}, FileHash: hash}, nil
  258. }
  259. func (b *Builder) calcCopyInfo(cmdName, origPath string, allowLocalDecompression, allowWildcards bool) ([]copyInfo, error) {
  260. // Work in daemon-specific OS filepath semantics
  261. origPath = filepath.FromSlash(origPath)
  262. if origPath != "" && origPath[0] == os.PathSeparator && len(origPath) > 1 {
  263. origPath = origPath[1:]
  264. }
  265. origPath = strings.TrimPrefix(origPath, "."+string(os.PathSeparator))
  266. // Deal with wildcards
  267. if allowWildcards && containsWildcards(origPath) {
  268. var copyInfos []copyInfo
  269. if err := b.context.Walk("", func(path string, info builder.FileInfo, err error) error {
  270. if err != nil {
  271. return err
  272. }
  273. if info.Name() == "" {
  274. // Why are we doing this check?
  275. return nil
  276. }
  277. if match, _ := filepath.Match(origPath, path); !match {
  278. return nil
  279. }
  280. // Note we set allowWildcards to false in case the name has
  281. // a * in it
  282. subInfos, err := b.calcCopyInfo(cmdName, path, allowLocalDecompression, false)
  283. if err != nil {
  284. return err
  285. }
  286. copyInfos = append(copyInfos, subInfos...)
  287. return nil
  288. }); err != nil {
  289. return nil, err
  290. }
  291. return copyInfos, nil
  292. }
  293. // Must be a dir or a file
  294. statPath, fi, err := b.context.Stat(origPath)
  295. if err != nil {
  296. return nil, err
  297. }
  298. copyInfos := []copyInfo{{FileInfo: fi, decompress: allowLocalDecompression}}
  299. hfi, handleHash := fi.(builder.Hashed)
  300. if !handleHash {
  301. return copyInfos, nil
  302. }
  303. // Deal with the single file case
  304. if !fi.IsDir() {
  305. hfi.SetHash("file:" + hfi.Hash())
  306. return copyInfos, nil
  307. }
  308. // Must be a dir
  309. var subfiles []string
  310. err = b.context.Walk(statPath, func(path string, info builder.FileInfo, err error) error {
  311. if err != nil {
  312. return err
  313. }
  314. // we already checked handleHash above
  315. subfiles = append(subfiles, info.(builder.Hashed).Hash())
  316. return nil
  317. })
  318. if err != nil {
  319. return nil, err
  320. }
  321. sort.Strings(subfiles)
  322. hasher := sha256.New()
  323. hasher.Write([]byte(strings.Join(subfiles, ",")))
  324. hfi.SetHash("dir:" + hex.EncodeToString(hasher.Sum(nil)))
  325. return copyInfos, nil
  326. }
  327. func containsWildcards(name string) bool {
  328. for i := 0; i < len(name); i++ {
  329. ch := name[i]
  330. if ch == '\\' {
  331. i++
  332. } else if ch == '*' || ch == '?' || ch == '[' {
  333. return true
  334. }
  335. }
  336. return false
  337. }
  338. func (b *Builder) processImageFrom(img builder.Image) error {
  339. if img != nil {
  340. b.image = img.ImageID()
  341. if img.RunConfig() != nil {
  342. b.runConfig = img.RunConfig()
  343. }
  344. }
  345. // Check to see if we have a default PATH, note that windows won't
  346. // have one as its set by HCS
  347. if system.DefaultPathEnv != "" {
  348. // Convert the slice of strings that represent the current list
  349. // of env vars into a map so we can see if PATH is already set.
  350. // If its not set then go ahead and give it our default value
  351. configEnv := opts.ConvertKVStringsToMap(b.runConfig.Env)
  352. if _, ok := configEnv["PATH"]; !ok {
  353. b.runConfig.Env = append(b.runConfig.Env,
  354. "PATH="+system.DefaultPathEnv)
  355. }
  356. }
  357. if img == nil {
  358. // Typically this means they used "FROM scratch"
  359. return nil
  360. }
  361. // Process ONBUILD triggers if they exist
  362. if nTriggers := len(b.runConfig.OnBuild); nTriggers != 0 {
  363. word := "trigger"
  364. if nTriggers > 1 {
  365. word = "triggers"
  366. }
  367. fmt.Fprintf(b.Stderr, "# Executing %d build %s...\n", nTriggers, word)
  368. }
  369. // Copy the ONBUILD triggers, and remove them from the config, since the config will be comitted.
  370. onBuildTriggers := b.runConfig.OnBuild
  371. b.runConfig.OnBuild = []string{}
  372. // parse the ONBUILD triggers by invoking the parser
  373. for _, step := range onBuildTriggers {
  374. ast, err := parser.Parse(strings.NewReader(step), &b.directive)
  375. if err != nil {
  376. return err
  377. }
  378. for i, n := range ast.Children {
  379. switch strings.ToUpper(n.Value) {
  380. case "ONBUILD":
  381. return fmt.Errorf("Chaining ONBUILD via `ONBUILD ONBUILD` isn't allowed")
  382. case "MAINTAINER", "FROM":
  383. return fmt.Errorf("%s isn't allowed as an ONBUILD trigger", n.Value)
  384. }
  385. if err := b.dispatch(i, n); err != nil {
  386. return err
  387. }
  388. }
  389. }
  390. return nil
  391. }
  392. // probeCache checks if `b.docker` implements builder.ImageCache and image-caching
  393. // is enabled (`b.UseCache`).
  394. // If so attempts to look up the current `b.image` and `b.runConfig` pair with `b.docker`.
  395. // If an image is found, probeCache returns `(true, nil)`.
  396. // If no image is found, it returns `(false, nil)`.
  397. // If there is any error, it returns `(false, err)`.
  398. func (b *Builder) probeCache() (bool, error) {
  399. c, ok := b.docker.(builder.ImageCache)
  400. if !ok || b.options.NoCache || b.cacheBusted {
  401. return false, nil
  402. }
  403. cache, err := c.GetCachedImageOnBuild(b.image, b.runConfig)
  404. if err != nil {
  405. return false, err
  406. }
  407. if len(cache) == 0 {
  408. logrus.Debugf("[BUILDER] Cache miss: %s", b.runConfig.Cmd)
  409. b.cacheBusted = true
  410. return false, nil
  411. }
  412. fmt.Fprintf(b.Stdout, " ---> Using cache\n")
  413. logrus.Debugf("[BUILDER] Use cached version: %s", b.runConfig.Cmd)
  414. b.image = string(cache)
  415. return true, nil
  416. }
  417. func (b *Builder) create() (string, error) {
  418. if b.image == "" && !b.noBaseImage {
  419. return "", fmt.Errorf("Please provide a source image with `from` prior to run")
  420. }
  421. b.runConfig.Image = b.image
  422. resources := container.Resources{
  423. CgroupParent: b.options.CgroupParent,
  424. CPUShares: b.options.CPUShares,
  425. CPUPeriod: b.options.CPUPeriod,
  426. CPUQuota: b.options.CPUQuota,
  427. CpusetCpus: b.options.CPUSetCPUs,
  428. CpusetMems: b.options.CPUSetMems,
  429. Memory: b.options.Memory,
  430. MemorySwap: b.options.MemorySwap,
  431. Ulimits: b.options.Ulimits,
  432. }
  433. // TODO: why not embed a hostconfig in builder?
  434. hostConfig := &container.HostConfig{
  435. Isolation: b.options.Isolation,
  436. ShmSize: b.options.ShmSize,
  437. Resources: resources,
  438. }
  439. config := *b.runConfig
  440. // Create the container
  441. c, err := b.docker.ContainerCreate(types.ContainerCreateConfig{
  442. Config: b.runConfig,
  443. HostConfig: hostConfig,
  444. }, true)
  445. if err != nil {
  446. return "", err
  447. }
  448. for _, warning := range c.Warnings {
  449. fmt.Fprintf(b.Stdout, " ---> [Warning] %s\n", warning)
  450. }
  451. b.tmpContainers[c.ID] = struct{}{}
  452. fmt.Fprintf(b.Stdout, " ---> Running in %s\n", stringid.TruncateID(c.ID))
  453. // override the entry point that may have been picked up from the base image
  454. if err := b.docker.ContainerUpdateCmdOnBuild(c.ID, config.Cmd); err != nil {
  455. return "", err
  456. }
  457. return c.ID, nil
  458. }
  459. var errCancelled = errors.New("build cancelled")
  460. func (b *Builder) run(cID string) (err error) {
  461. errCh := make(chan error)
  462. go func() {
  463. errCh <- b.docker.ContainerAttachRaw(cID, nil, b.Stdout, b.Stderr, true)
  464. }()
  465. finished := make(chan struct{})
  466. var once sync.Once
  467. finish := func() { close(finished) }
  468. cancelErrCh := make(chan error, 1)
  469. defer once.Do(finish)
  470. go func() {
  471. select {
  472. case <-b.clientCtx.Done():
  473. logrus.Debugln("Build cancelled, killing and removing container:", cID)
  474. b.docker.ContainerKill(cID, 0)
  475. b.removeContainer(cID)
  476. cancelErrCh <- errCancelled
  477. case <-finished:
  478. cancelErrCh <- nil
  479. }
  480. }()
  481. if err := b.docker.ContainerStart(cID, nil, true); err != nil {
  482. return err
  483. }
  484. // Block on reading output from container, stop on err or chan closed
  485. if err := <-errCh; err != nil {
  486. return err
  487. }
  488. if ret, _ := b.docker.ContainerWait(cID, -1); ret != 0 {
  489. // TODO: change error type, because jsonmessage.JSONError assumes HTTP
  490. return &jsonmessage.JSONError{
  491. Message: fmt.Sprintf("The command '%s' returned a non-zero code: %d", strings.Join(b.runConfig.Cmd, " "), ret),
  492. Code: ret,
  493. }
  494. }
  495. once.Do(finish)
  496. return <-cancelErrCh
  497. }
  498. func (b *Builder) removeContainer(c string) error {
  499. rmConfig := &types.ContainerRmConfig{
  500. ForceRemove: true,
  501. RemoveVolume: true,
  502. }
  503. if err := b.docker.ContainerRm(c, rmConfig); err != nil {
  504. fmt.Fprintf(b.Stdout, "Error removing intermediate container %s: %v\n", stringid.TruncateID(c), err)
  505. return err
  506. }
  507. return nil
  508. }
  509. func (b *Builder) clearTmp() {
  510. for c := range b.tmpContainers {
  511. if err := b.removeContainer(c); err != nil {
  512. return
  513. }
  514. delete(b.tmpContainers, c)
  515. fmt.Fprintf(b.Stdout, "Removing intermediate container %s\n", stringid.TruncateID(c))
  516. }
  517. }
  518. // readDockerfile reads a Dockerfile from the current context.
  519. func (b *Builder) readDockerfile() error {
  520. // If no -f was specified then look for 'Dockerfile'. If we can't find
  521. // that then look for 'dockerfile'. If neither are found then default
  522. // back to 'Dockerfile' and use that in the error message.
  523. if b.options.Dockerfile == "" {
  524. b.options.Dockerfile = builder.DefaultDockerfileName
  525. if _, _, err := b.context.Stat(b.options.Dockerfile); os.IsNotExist(err) {
  526. lowercase := strings.ToLower(b.options.Dockerfile)
  527. if _, _, err := b.context.Stat(lowercase); err == nil {
  528. b.options.Dockerfile = lowercase
  529. }
  530. }
  531. }
  532. err := b.parseDockerfile()
  533. if err != nil {
  534. return err
  535. }
  536. // After the Dockerfile has been parsed, we need to check the .dockerignore
  537. // file for either "Dockerfile" or ".dockerignore", and if either are
  538. // present then erase them from the build context. These files should never
  539. // have been sent from the client but we did send them to make sure that
  540. // we had the Dockerfile to actually parse, and then we also need the
  541. // .dockerignore file to know whether either file should be removed.
  542. // Note that this assumes the Dockerfile has been read into memory and
  543. // is now safe to be removed.
  544. if dockerIgnore, ok := b.context.(builder.DockerIgnoreContext); ok {
  545. dockerIgnore.Process([]string{b.options.Dockerfile})
  546. }
  547. return nil
  548. }
  549. func (b *Builder) parseDockerfile() error {
  550. f, err := b.context.Open(b.options.Dockerfile)
  551. if err != nil {
  552. if os.IsNotExist(err) {
  553. return fmt.Errorf("Cannot locate specified Dockerfile: %s", b.options.Dockerfile)
  554. }
  555. return err
  556. }
  557. defer f.Close()
  558. if f, ok := f.(*os.File); ok {
  559. // ignoring error because Open already succeeded
  560. fi, err := f.Stat()
  561. if err != nil {
  562. return fmt.Errorf("Unexpected error reading Dockerfile: %v", err)
  563. }
  564. if fi.Size() == 0 {
  565. return fmt.Errorf("The Dockerfile (%s) cannot be empty", b.options.Dockerfile)
  566. }
  567. }
  568. b.dockerfile, err = parser.Parse(f, &b.directive)
  569. if err != nil {
  570. return err
  571. }
  572. return nil
  573. }
  574. // determine if build arg is part of built-in args or user
  575. // defined args in Dockerfile at any point in time.
  576. func (b *Builder) isBuildArgAllowed(arg string) bool {
  577. if _, ok := BuiltinAllowedBuildArgs[arg]; ok {
  578. return true
  579. }
  580. if _, ok := b.allowedBuildArgs[arg]; ok {
  581. return true
  582. }
  583. return false
  584. }