update.go 13 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444
  1. package service
  2. import (
  3. "fmt"
  4. "strings"
  5. "time"
  6. "golang.org/x/net/context"
  7. "github.com/docker/docker/api/client"
  8. "github.com/docker/docker/cli"
  9. "github.com/docker/docker/opts"
  10. runconfigopts "github.com/docker/docker/runconfig/opts"
  11. "github.com/docker/engine-api/types"
  12. "github.com/docker/engine-api/types/swarm"
  13. "github.com/docker/go-connections/nat"
  14. shlex "github.com/flynn-archive/go-shlex"
  15. "github.com/spf13/cobra"
  16. "github.com/spf13/pflag"
  17. )
  18. func newUpdateCommand(dockerCli *client.DockerCli) *cobra.Command {
  19. opts := newServiceOptions()
  20. cmd := &cobra.Command{
  21. Use: "update [OPTIONS] SERVICE",
  22. Short: "Update a service",
  23. Args: cli.ExactArgs(1),
  24. RunE: func(cmd *cobra.Command, args []string) error {
  25. return runUpdate(dockerCli, cmd.Flags(), args[0])
  26. },
  27. }
  28. flags := cmd.Flags()
  29. flags.String("image", "", "Service image tag")
  30. flags.String("args", "", "Service command args")
  31. addServiceFlags(cmd, opts)
  32. flags.Var(newListOptsVar(), flagEnvRemove, "Remove an environment variable")
  33. flags.Var(newListOptsVar(), flagLabelRemove, "Remove a label by its key")
  34. flags.Var(newListOptsVar(), flagContainerLabelRemove, "Remove a container label by its key")
  35. flags.Var(newListOptsVar(), flagMountRemove, "Remove a mount by its target path")
  36. flags.Var(newListOptsVar(), flagPublishRemove, "Remove a published port by its target port")
  37. flags.Var(newListOptsVar(), flagNetworkRemove, "Remove a network by name")
  38. flags.Var(newListOptsVar(), flagConstraintRemove, "Remove a constraint")
  39. flags.Var(&opts.labels, flagLabelAdd, "Add or update service labels")
  40. flags.Var(&opts.containerLabels, flagContainerLabelAdd, "Add or update container labels")
  41. flags.Var(&opts.env, flagEnvAdd, "Add or update environment variables")
  42. flags.Var(&opts.mounts, flagMountAdd, "Add or update a mount on a service")
  43. flags.StringSliceVar(&opts.constraints, flagConstraintAdd, []string{}, "Add or update placement constraints")
  44. flags.StringSliceVar(&opts.networks, flagNetworkAdd, []string{}, "Add or update network attachments")
  45. flags.Var(&opts.endpoint.ports, flagPublishAdd, "Add or update a published port")
  46. return cmd
  47. }
  48. func newListOptsVar() *opts.ListOpts {
  49. return opts.NewListOptsRef(&[]string{}, nil)
  50. }
  51. func runUpdate(dockerCli *client.DockerCli, flags *pflag.FlagSet, serviceID string) error {
  52. apiClient := dockerCli.Client()
  53. ctx := context.Background()
  54. updateOpts := types.ServiceUpdateOptions{}
  55. service, _, err := apiClient.ServiceInspectWithRaw(ctx, serviceID)
  56. if err != nil {
  57. return err
  58. }
  59. err = updateService(flags, &service.Spec)
  60. if err != nil {
  61. return err
  62. }
  63. // only send auth if flag was set
  64. sendAuth, err := flags.GetBool(flagRegistryAuth)
  65. if err != nil {
  66. return err
  67. }
  68. if sendAuth {
  69. // Retrieve encoded auth token from the image reference
  70. // This would be the old image if it didn't change in this update
  71. image := service.Spec.TaskTemplate.ContainerSpec.Image
  72. encodedAuth, err := dockerCli.RetrieveAuthTokenFromImage(ctx, image)
  73. if err != nil {
  74. return err
  75. }
  76. updateOpts.EncodedRegistryAuth = encodedAuth
  77. }
  78. err = apiClient.ServiceUpdate(ctx, service.ID, service.Version, service.Spec, updateOpts)
  79. if err != nil {
  80. return err
  81. }
  82. fmt.Fprintf(dockerCli.Out(), "%s\n", serviceID)
  83. return nil
  84. }
  85. func updateService(flags *pflag.FlagSet, spec *swarm.ServiceSpec) error {
  86. updateString := func(flag string, field *string) {
  87. if flags.Changed(flag) {
  88. *field, _ = flags.GetString(flag)
  89. }
  90. }
  91. updateInt64Value := func(flag string, field *int64) {
  92. if flags.Changed(flag) {
  93. *field = flags.Lookup(flag).Value.(int64Value).Value()
  94. }
  95. }
  96. updateDuration := func(flag string, field *time.Duration) {
  97. if flags.Changed(flag) {
  98. *field, _ = flags.GetDuration(flag)
  99. }
  100. }
  101. updateDurationOpt := func(flag string, field **time.Duration) {
  102. if flags.Changed(flag) {
  103. val := *flags.Lookup(flag).Value.(*DurationOpt).Value()
  104. *field = &val
  105. }
  106. }
  107. updateUint64 := func(flag string, field *uint64) {
  108. if flags.Changed(flag) {
  109. *field, _ = flags.GetUint64(flag)
  110. }
  111. }
  112. updateUint64Opt := func(flag string, field **uint64) {
  113. if flags.Changed(flag) {
  114. val := *flags.Lookup(flag).Value.(*Uint64Opt).Value()
  115. *field = &val
  116. }
  117. }
  118. cspec := &spec.TaskTemplate.ContainerSpec
  119. task := &spec.TaskTemplate
  120. taskResources := func() *swarm.ResourceRequirements {
  121. if task.Resources == nil {
  122. task.Resources = &swarm.ResourceRequirements{}
  123. }
  124. return task.Resources
  125. }
  126. updateString(flagName, &spec.Name)
  127. updateLabels(flags, &spec.Labels)
  128. updateContainerLabels(flags, &cspec.Labels)
  129. updateString("image", &cspec.Image)
  130. updateStringToSlice(flags, "args", &cspec.Args)
  131. updateEnvironment(flags, &cspec.Env)
  132. updateString(flagWorkdir, &cspec.Dir)
  133. updateString(flagUser, &cspec.User)
  134. updateMounts(flags, &cspec.Mounts)
  135. if flags.Changed(flagLimitCPU) || flags.Changed(flagLimitMemory) {
  136. taskResources().Limits = &swarm.Resources{}
  137. updateInt64Value(flagLimitCPU, &task.Resources.Limits.NanoCPUs)
  138. updateInt64Value(flagLimitMemory, &task.Resources.Limits.MemoryBytes)
  139. }
  140. if flags.Changed(flagReserveCPU) || flags.Changed(flagReserveMemory) {
  141. taskResources().Reservations = &swarm.Resources{}
  142. updateInt64Value(flagReserveCPU, &task.Resources.Reservations.NanoCPUs)
  143. updateInt64Value(flagReserveMemory, &task.Resources.Reservations.MemoryBytes)
  144. }
  145. updateDurationOpt(flagStopGracePeriod, &cspec.StopGracePeriod)
  146. if anyChanged(flags, flagRestartCondition, flagRestartDelay, flagRestartMaxAttempts, flagRestartWindow) {
  147. if task.RestartPolicy == nil {
  148. task.RestartPolicy = &swarm.RestartPolicy{}
  149. }
  150. if flags.Changed(flagRestartCondition) {
  151. value, _ := flags.GetString(flagRestartCondition)
  152. task.RestartPolicy.Condition = swarm.RestartPolicyCondition(value)
  153. }
  154. updateDurationOpt(flagRestartDelay, &task.RestartPolicy.Delay)
  155. updateUint64Opt(flagRestartMaxAttempts, &task.RestartPolicy.MaxAttempts)
  156. updateDurationOpt(flagRestartWindow, &task.RestartPolicy.Window)
  157. }
  158. if anyChanged(flags, flagConstraintAdd, flagConstraintRemove) {
  159. if task.Placement == nil {
  160. task.Placement = &swarm.Placement{}
  161. }
  162. updatePlacement(flags, task.Placement)
  163. }
  164. if err := updateReplicas(flags, &spec.Mode); err != nil {
  165. return err
  166. }
  167. if anyChanged(flags, flagUpdateParallelism, flagUpdateDelay, flagUpdateFailureAction) {
  168. if spec.UpdateConfig == nil {
  169. spec.UpdateConfig = &swarm.UpdateConfig{}
  170. }
  171. updateUint64(flagUpdateParallelism, &spec.UpdateConfig.Parallelism)
  172. updateDuration(flagUpdateDelay, &spec.UpdateConfig.Delay)
  173. updateString(flagUpdateFailureAction, &spec.UpdateConfig.FailureAction)
  174. }
  175. updateNetworks(flags, &spec.Networks)
  176. if flags.Changed(flagEndpointMode) {
  177. value, _ := flags.GetString(flagEndpointMode)
  178. if spec.EndpointSpec == nil {
  179. spec.EndpointSpec = &swarm.EndpointSpec{}
  180. }
  181. spec.EndpointSpec.Mode = swarm.ResolutionMode(value)
  182. }
  183. if anyChanged(flags, flagPublishAdd, flagPublishRemove) {
  184. if spec.EndpointSpec == nil {
  185. spec.EndpointSpec = &swarm.EndpointSpec{}
  186. }
  187. updatePorts(flags, &spec.EndpointSpec.Ports)
  188. }
  189. if err := updateLogDriver(flags, &spec.TaskTemplate); err != nil {
  190. return err
  191. }
  192. return nil
  193. }
  194. func updateStringToSlice(flags *pflag.FlagSet, flag string, field *[]string) error {
  195. if !flags.Changed(flag) {
  196. return nil
  197. }
  198. value, _ := flags.GetString(flag)
  199. valueSlice, err := shlex.Split(value)
  200. *field = valueSlice
  201. return err
  202. }
  203. func anyChanged(flags *pflag.FlagSet, fields ...string) bool {
  204. for _, flag := range fields {
  205. if flags.Changed(flag) {
  206. return true
  207. }
  208. }
  209. return false
  210. }
  211. func updatePlacement(flags *pflag.FlagSet, placement *swarm.Placement) {
  212. field, _ := flags.GetStringSlice(flagConstraintAdd)
  213. placement.Constraints = append(placement.Constraints, field...)
  214. toRemove := buildToRemoveSet(flags, flagConstraintRemove)
  215. placement.Constraints = removeItems(placement.Constraints, toRemove, itemKey)
  216. }
  217. func updateContainerLabels(flags *pflag.FlagSet, field *map[string]string) {
  218. if flags.Changed(flagContainerLabelAdd) {
  219. if *field == nil {
  220. *field = map[string]string{}
  221. }
  222. values := flags.Lookup(flagContainerLabelAdd).Value.(*opts.ListOpts).GetAll()
  223. for key, value := range runconfigopts.ConvertKVStringsToMap(values) {
  224. (*field)[key] = value
  225. }
  226. }
  227. if *field != nil && flags.Changed(flagContainerLabelRemove) {
  228. toRemove := flags.Lookup(flagContainerLabelRemove).Value.(*opts.ListOpts).GetAll()
  229. for _, label := range toRemove {
  230. delete(*field, label)
  231. }
  232. }
  233. }
  234. func updateLabels(flags *pflag.FlagSet, field *map[string]string) {
  235. if flags.Changed(flagLabelAdd) {
  236. if *field == nil {
  237. *field = map[string]string{}
  238. }
  239. values := flags.Lookup(flagLabelAdd).Value.(*opts.ListOpts).GetAll()
  240. for key, value := range runconfigopts.ConvertKVStringsToMap(values) {
  241. (*field)[key] = value
  242. }
  243. }
  244. if *field != nil && flags.Changed(flagLabelRemove) {
  245. toRemove := flags.Lookup(flagLabelRemove).Value.(*opts.ListOpts).GetAll()
  246. for _, label := range toRemove {
  247. delete(*field, label)
  248. }
  249. }
  250. }
  251. func updateEnvironment(flags *pflag.FlagSet, field *[]string) {
  252. if flags.Changed(flagEnvAdd) {
  253. value := flags.Lookup(flagEnvAdd).Value.(*opts.ListOpts)
  254. *field = append(*field, value.GetAll()...)
  255. }
  256. toRemove := buildToRemoveSet(flags, flagEnvRemove)
  257. *field = removeItems(*field, toRemove, envKey)
  258. }
  259. func envKey(value string) string {
  260. kv := strings.SplitN(value, "=", 2)
  261. return kv[0]
  262. }
  263. func itemKey(value string) string {
  264. return value
  265. }
  266. func buildToRemoveSet(flags *pflag.FlagSet, flag string) map[string]struct{} {
  267. var empty struct{}
  268. toRemove := make(map[string]struct{})
  269. if !flags.Changed(flag) {
  270. return toRemove
  271. }
  272. toRemoveSlice := flags.Lookup(flag).Value.(*opts.ListOpts).GetAll()
  273. for _, key := range toRemoveSlice {
  274. toRemove[key] = empty
  275. }
  276. return toRemove
  277. }
  278. func removeItems(
  279. seq []string,
  280. toRemove map[string]struct{},
  281. keyFunc func(string) string,
  282. ) []string {
  283. newSeq := []string{}
  284. for _, item := range seq {
  285. if _, exists := toRemove[keyFunc(item)]; !exists {
  286. newSeq = append(newSeq, item)
  287. }
  288. }
  289. return newSeq
  290. }
  291. func updateMounts(flags *pflag.FlagSet, mounts *[]swarm.Mount) {
  292. if flags.Changed(flagMountAdd) {
  293. values := flags.Lookup(flagMountAdd).Value.(*MountOpt).Value()
  294. *mounts = append(*mounts, values...)
  295. }
  296. toRemove := buildToRemoveSet(flags, flagMountRemove)
  297. newMounts := []swarm.Mount{}
  298. for _, mount := range *mounts {
  299. if _, exists := toRemove[mount.Target]; !exists {
  300. newMounts = append(newMounts, mount)
  301. }
  302. }
  303. *mounts = newMounts
  304. }
  305. func updatePorts(flags *pflag.FlagSet, portConfig *[]swarm.PortConfig) {
  306. if flags.Changed(flagPublishAdd) {
  307. values := flags.Lookup(flagPublishAdd).Value.(*opts.ListOpts).GetAll()
  308. ports, portBindings, _ := nat.ParsePortSpecs(values)
  309. for port := range ports {
  310. *portConfig = append(*portConfig, convertPortToPortConfig(port, portBindings)...)
  311. }
  312. }
  313. if !flags.Changed(flagPublishRemove) {
  314. return
  315. }
  316. toRemove := flags.Lookup(flagPublishRemove).Value.(*opts.ListOpts).GetAll()
  317. newPorts := []swarm.PortConfig{}
  318. portLoop:
  319. for _, port := range *portConfig {
  320. for _, rawTargetPort := range toRemove {
  321. targetPort := nat.Port(rawTargetPort)
  322. if equalPort(targetPort, port) {
  323. continue portLoop
  324. }
  325. }
  326. newPorts = append(newPorts, port)
  327. }
  328. *portConfig = newPorts
  329. }
  330. func equalPort(targetPort nat.Port, port swarm.PortConfig) bool {
  331. return (string(port.Protocol) == targetPort.Proto() &&
  332. port.TargetPort == uint32(targetPort.Int()))
  333. }
  334. func updateNetworks(flags *pflag.FlagSet, attachments *[]swarm.NetworkAttachmentConfig) {
  335. if flags.Changed(flagNetworkAdd) {
  336. networks, _ := flags.GetStringSlice(flagNetworkAdd)
  337. for _, network := range networks {
  338. *attachments = append(*attachments, swarm.NetworkAttachmentConfig{Target: network})
  339. }
  340. }
  341. toRemove := buildToRemoveSet(flags, flagNetworkRemove)
  342. newNetworks := []swarm.NetworkAttachmentConfig{}
  343. for _, network := range *attachments {
  344. if _, exists := toRemove[network.Target]; !exists {
  345. newNetworks = append(newNetworks, network)
  346. }
  347. }
  348. *attachments = newNetworks
  349. }
  350. func updateReplicas(flags *pflag.FlagSet, serviceMode *swarm.ServiceMode) error {
  351. if !flags.Changed(flagReplicas) {
  352. return nil
  353. }
  354. if serviceMode == nil || serviceMode.Replicated == nil {
  355. return fmt.Errorf("replicas can only be used with replicated mode")
  356. }
  357. serviceMode.Replicated.Replicas = flags.Lookup(flagReplicas).Value.(*Uint64Opt).Value()
  358. return nil
  359. }
  360. // updateLogDriver updates the log driver only if the log driver flag is set.
  361. // All options will be replaced with those provided on the command line.
  362. func updateLogDriver(flags *pflag.FlagSet, taskTemplate *swarm.TaskSpec) error {
  363. if !flags.Changed(flagLogDriver) {
  364. return nil
  365. }
  366. name, err := flags.GetString(flagLogDriver)
  367. if err != nil {
  368. return err
  369. }
  370. if name == "" {
  371. return nil
  372. }
  373. taskTemplate.LogDriver = &swarm.Driver{
  374. Name: name,
  375. Options: runconfigopts.ConvertKVStringsToMap(flags.Lookup(flagLogOpt).Value.(*opts.ListOpts).GetAll()),
  376. }
  377. return nil
  378. }