docker_cli_build_test.go 72 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543154415451546154715481549155015511552155315541555155615571558155915601561156215631564156515661567156815691570157115721573157415751576157715781579158015811582158315841585158615871588158915901591159215931594159515961597159815991600160116021603160416051606160716081609161016111612161316141615161616171618161916201621162216231624162516261627162816291630163116321633163416351636163716381639164016411642164316441645164616471648164916501651165216531654165516561657165816591660166116621663166416651666166716681669167016711672167316741675167616771678167916801681168216831684168516861687168816891690169116921693169416951696169716981699170017011702170317041705170617071708170917101711171217131714171517161717171817191720172117221723172417251726172717281729173017311732173317341735173617371738173917401741174217431744174517461747174817491750175117521753175417551756175717581759176017611762176317641765176617671768176917701771177217731774177517761777177817791780178117821783178417851786178717881789179017911792179317941795179617971798179918001801180218031804180518061807180818091810181118121813181418151816181718181819182018211822182318241825182618271828182918301831183218331834183518361837183818391840184118421843184418451846184718481849185018511852185318541855185618571858185918601861186218631864186518661867186818691870187118721873187418751876187718781879188018811882188318841885188618871888188918901891189218931894189518961897189818991900190119021903190419051906190719081909191019111912191319141915191619171918191919201921192219231924192519261927192819291930193119321933193419351936193719381939194019411942194319441945194619471948194919501951195219531954195519561957195819591960196119621963196419651966196719681969197019711972197319741975197619771978197919801981198219831984198519861987198819891990199119921993199419951996199719981999200020012002200320042005200620072008200920102011201220132014201520162017201820192020202120222023202420252026202720282029203020312032203320342035203620372038203920402041204220432044204520462047204820492050205120522053205420552056205720582059206020612062206320642065206620672068206920702071207220732074207520762077207820792080208120822083208420852086208720882089209020912092209320942095209620972098209921002101210221032104210521062107210821092110211121122113211421152116211721182119212021212122212321242125212621272128212921302131213221332134213521362137213821392140214121422143214421452146214721482149215021512152215321542155215621572158215921602161216221632164216521662167216821692170217121722173217421752176217721782179218021812182218321842185218621872188218921902191219221932194219521962197219821992200220122022203220422052206220722082209221022112212221322142215221622172218221922202221222222232224222522262227222822292230223122322233223422352236223722382239224022412242224322442245224622472248224922502251225222532254225522562257225822592260226122622263226422652266226722682269227022712272227322742275227622772278227922802281228222832284228522862287228822892290229122922293229422952296229722982299230023012302230323042305230623072308230923102311231223132314231523162317231823192320232123222323232423252326232723282329233023312332233323342335233623372338233923402341234223432344234523462347234823492350235123522353235423552356235723582359236023612362236323642365236623672368236923702371237223732374237523762377237823792380238123822383238423852386238723882389239023912392239323942395239623972398239924002401240224032404240524062407240824092410241124122413241424152416241724182419242024212422242324242425242624272428242924302431243224332434243524362437243824392440244124422443244424452446244724482449245024512452245324542455245624572458245924602461246224632464246524662467246824692470247124722473247424752476247724782479248024812482248324842485248624872488248924902491249224932494249524962497249824992500250125022503250425052506250725082509251025112512251325142515251625172518251925202521252225232524252525262527252825292530253125322533253425352536253725382539254025412542254325442545254625472548254925502551255225532554255525562557255825592560256125622563256425652566256725682569257025712572257325742575257625772578257925802581258225832584258525862587258825892590259125922593259425952596259725982599260026012602260326042605260626072608260926102611261226132614261526162617261826192620262126222623262426252626262726282629263026312632263326342635263626372638263926402641264226432644264526462647264826492650265126522653265426552656265726582659266026612662266326642665266626672668266926702671267226732674267526762677267826792680268126822683268426852686268726882689269026912692269326942695269626972698269927002701270227032704270527062707270827092710271127122713271427152716271727182719272027212722272327242725272627272728272927302731273227332734273527362737273827392740274127422743274427452746274727482749275027512752275327542755275627572758275927602761276227632764276527662767276827692770277127722773
  1. package main
  2. import (
  3. "archive/tar"
  4. "fmt"
  5. "io/ioutil"
  6. "os"
  7. "os/exec"
  8. "path/filepath"
  9. "regexp"
  10. "strings"
  11. "testing"
  12. "time"
  13. "github.com/docker/docker/pkg/archive"
  14. )
  15. func TestBuildOnBuildForbiddenMaintainerInSourceImage(t *testing.T) {
  16. name := "testbuildonbuildforbiddenmaintainerinsourceimage"
  17. defer deleteImages(name)
  18. createCmd := exec.Command(dockerBinary, "create", "busybox", "true")
  19. out, _, _, err := runCommandWithStdoutStderr(createCmd)
  20. if err != nil {
  21. t.Fatal(out, err)
  22. }
  23. cleanedContainerID := stripTrailingCharacters(out)
  24. commitCmd := exec.Command(dockerBinary, "commit", "--run", "{\"OnBuild\":[\"MAINTAINER docker.io\"]}", cleanedContainerID, "onbuild")
  25. if _, err := runCommand(commitCmd); err != nil {
  26. t.Fatal(err)
  27. }
  28. _, err = buildImage(name,
  29. `FROM onbuild`,
  30. true)
  31. if err != nil {
  32. if !strings.Contains(err.Error(), "maintainer isn't allowed as an ONBUILD trigger") {
  33. t.Fatalf("Wrong error %v, must be about MAINTAINER and ONBUILD in source image", err)
  34. }
  35. } else {
  36. t.Fatal("Error must not be nil")
  37. }
  38. logDone("build - onbuild forbidden maintainer in source image")
  39. }
  40. func TestBuildOnBuildForbiddenFromInSourceImage(t *testing.T) {
  41. name := "testbuildonbuildforbiddenfrominsourceimage"
  42. defer deleteImages(name)
  43. createCmd := exec.Command(dockerBinary, "create", "busybox", "true")
  44. out, _, _, err := runCommandWithStdoutStderr(createCmd)
  45. if err != nil {
  46. t.Fatal(out, err)
  47. }
  48. cleanedContainerID := stripTrailingCharacters(out)
  49. commitCmd := exec.Command(dockerBinary, "commit", "--run", "{\"OnBuild\":[\"FROM busybox\"]}", cleanedContainerID, "onbuild")
  50. if _, err := runCommand(commitCmd); err != nil {
  51. t.Fatal(err)
  52. }
  53. _, err = buildImage(name,
  54. `FROM onbuild`,
  55. true)
  56. if err != nil {
  57. if !strings.Contains(err.Error(), "from isn't allowed as an ONBUILD trigger") {
  58. t.Fatalf("Wrong error %v, must be about FROM and ONBUILD in source image", err)
  59. }
  60. } else {
  61. t.Fatal("Error must not be nil")
  62. }
  63. logDone("build - onbuild forbidden from in source image")
  64. }
  65. func TestBuildOnBuildForbiddenChainedInSourceImage(t *testing.T) {
  66. name := "testbuildonbuildforbiddenchainedinsourceimage"
  67. defer deleteImages(name)
  68. createCmd := exec.Command(dockerBinary, "create", "busybox", "true")
  69. out, _, _, err := runCommandWithStdoutStderr(createCmd)
  70. if err != nil {
  71. t.Fatal(out, err)
  72. }
  73. cleanedContainerID := stripTrailingCharacters(out)
  74. commitCmd := exec.Command(dockerBinary, "commit", "--run", "{\"OnBuild\":[\"ONBUILD RUN ls\"]}", cleanedContainerID, "onbuild")
  75. if _, err := runCommand(commitCmd); err != nil {
  76. t.Fatal(err)
  77. }
  78. _, err = buildImage(name,
  79. `FROM onbuild`,
  80. true)
  81. if err != nil {
  82. if !strings.Contains(err.Error(), "Chaining ONBUILD via `ONBUILD ONBUILD` isn't allowed") {
  83. t.Fatalf("Wrong error %v, must be about chaining ONBUILD in source image", err)
  84. }
  85. } else {
  86. t.Fatal("Error must not be nil")
  87. }
  88. logDone("build - onbuild forbidden chained in source image")
  89. }
  90. func TestBuildOnBuildCmdEntrypointJSON(t *testing.T) {
  91. name1 := "onbuildcmd"
  92. name2 := "onbuildgenerated"
  93. defer deleteAllContainers()
  94. defer deleteImages(name2)
  95. defer deleteImages(name1)
  96. _, err := buildImage(name1, `
  97. FROM busybox
  98. ONBUILD CMD ["hello world"]
  99. ONBUILD ENTRYPOINT ["echo"]
  100. ONBUILD RUN ["true"]`,
  101. false)
  102. if err != nil {
  103. t.Fatal(err)
  104. }
  105. _, err = buildImage(name2, fmt.Sprintf(`FROM %s`, name1), false)
  106. if err != nil {
  107. t.Fatal(err)
  108. }
  109. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "-t", name2))
  110. if err != nil {
  111. t.Fatal(err)
  112. }
  113. if !regexp.MustCompile(`(?m)^hello world`).MatchString(out) {
  114. t.Fatal("did not get echo output from onbuild", out)
  115. }
  116. logDone("build - onbuild with json entrypoint/cmd")
  117. }
  118. func TestBuildOnBuildEntrypointJSON(t *testing.T) {
  119. name1 := "onbuildcmd"
  120. name2 := "onbuildgenerated"
  121. defer deleteAllContainers()
  122. defer deleteImages(name2)
  123. defer deleteImages(name1)
  124. _, err := buildImage(name1, `
  125. FROM busybox
  126. ONBUILD ENTRYPOINT ["echo"]`,
  127. false)
  128. if err != nil {
  129. t.Fatal(err)
  130. }
  131. _, err = buildImage(name2, fmt.Sprintf("FROM %s\nCMD [\"hello world\"]\n", name1), false)
  132. if err != nil {
  133. t.Fatal(err)
  134. }
  135. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "-t", name2))
  136. if err != nil {
  137. t.Fatal(err)
  138. }
  139. if !regexp.MustCompile(`(?m)^hello world`).MatchString(out) {
  140. t.Fatal("got malformed output from onbuild", out)
  141. }
  142. logDone("build - onbuild with json entrypoint")
  143. }
  144. func TestBuildCacheADD(t *testing.T) {
  145. name := "testbuildtwoimageswithadd"
  146. defer deleteImages(name)
  147. server, err := fakeStorage(map[string]string{
  148. "robots.txt": "hello",
  149. "index.html": "world",
  150. })
  151. if err != nil {
  152. t.Fatal(err)
  153. }
  154. defer server.Close()
  155. if _, err := buildImage(name,
  156. fmt.Sprintf(`FROM scratch
  157. ADD %s/robots.txt /`, server.URL),
  158. true); err != nil {
  159. t.Fatal(err)
  160. }
  161. _, out, err := buildImageWithOut(name,
  162. fmt.Sprintf(`FROM scratch
  163. ADD %s/index.html /`, server.URL),
  164. true)
  165. if err != nil {
  166. t.Fatal(err)
  167. }
  168. if strings.Contains(out, "Using cache") {
  169. t.Fatal("2nd build used cache on ADD, it shouldn't")
  170. }
  171. logDone("build - build two images with remote ADD")
  172. }
  173. func TestBuildSixtySteps(t *testing.T) {
  174. name := "foobuildsixtysteps"
  175. defer deleteImages(name)
  176. ctx, err := fakeContext("FROM scratch\n"+strings.Repeat("ADD foo /\n", 60),
  177. map[string]string{
  178. "foo": "test1",
  179. })
  180. if err != nil {
  181. t.Fatal(err)
  182. }
  183. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  184. t.Fatal(err)
  185. }
  186. logDone("build - build an image with sixty build steps")
  187. }
  188. func TestBuildAddSingleFileToRoot(t *testing.T) {
  189. name := "testaddimg"
  190. defer deleteImages(name)
  191. ctx, err := fakeContext(`FROM busybox
  192. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  193. RUN echo 'dockerio:x:1001:' >> /etc/group
  194. RUN touch /exists
  195. RUN chown dockerio.dockerio /exists
  196. ADD test_file /
  197. RUN [ $(ls -l /test_file | awk '{print $3":"$4}') = 'root:root' ]
  198. RUN [ $(ls -l /test_file | awk '{print $1}') = '-rw-r--r--' ]
  199. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  200. map[string]string{
  201. "test_file": "test1",
  202. })
  203. if err != nil {
  204. t.Fatal(err)
  205. }
  206. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  207. t.Fatal(err)
  208. }
  209. logDone("build - add single file to root")
  210. }
  211. // Issue #3960: "ADD src ." hangs
  212. func TestBuildAddSingleFileToWorkdir(t *testing.T) {
  213. name := "testaddsinglefiletoworkdir"
  214. defer deleteImages(name)
  215. ctx, err := fakeContext(`FROM busybox
  216. ADD test_file .`,
  217. map[string]string{
  218. "test_file": "test1",
  219. })
  220. if err != nil {
  221. t.Fatal(err)
  222. }
  223. done := make(chan struct{})
  224. go func() {
  225. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  226. t.Fatal(err)
  227. }
  228. close(done)
  229. }()
  230. select {
  231. case <-time.After(5 * time.Second):
  232. t.Fatal("Build with adding to workdir timed out")
  233. case <-done:
  234. }
  235. logDone("build - add single file to workdir")
  236. }
  237. func TestBuildAddSingleFileToExistDir(t *testing.T) {
  238. name := "testaddsinglefiletoexistdir"
  239. defer deleteImages(name)
  240. ctx, err := fakeContext(`FROM busybox
  241. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  242. RUN echo 'dockerio:x:1001:' >> /etc/group
  243. RUN mkdir /exists
  244. RUN touch /exists/exists_file
  245. RUN chown -R dockerio.dockerio /exists
  246. ADD test_file /exists/
  247. RUN [ $(ls -l / | grep exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]
  248. RUN [ $(ls -l /exists/test_file | awk '{print $3":"$4}') = 'root:root' ]
  249. RUN [ $(ls -l /exists/exists_file | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  250. map[string]string{
  251. "test_file": "test1",
  252. })
  253. if err != nil {
  254. t.Fatal(err)
  255. }
  256. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  257. t.Fatal(err)
  258. }
  259. logDone("build - add single file to existing dir")
  260. }
  261. func TestBuildCopyAddMultipleFiles(t *testing.T) {
  262. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
  263. if out, _, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testaddimg", "MultipleFiles"); err != nil {
  264. t.Fatalf("build failed to complete: %s, %v", out, err)
  265. }
  266. deleteImages("testaddimg")
  267. logDone("build - mulitple file copy/add tests")
  268. }
  269. func TestBuildAddMultipleFilesToFile(t *testing.T) {
  270. name := "testaddmultiplefilestofile"
  271. defer deleteImages(name)
  272. ctx, err := fakeContext(`FROM scratch
  273. ADD file1.txt file2.txt test
  274. `,
  275. map[string]string{
  276. "file1.txt": "test1",
  277. "file2.txt": "test1",
  278. })
  279. defer ctx.Close()
  280. if err != nil {
  281. t.Fatal(err)
  282. }
  283. expected := "When using ADD with more than one source file, the destination must be a directory and end with a /"
  284. if _, err := buildImageFromContext(name, ctx, true); err == nil || !strings.Contains(err.Error(), expected) {
  285. t.Fatalf("Wrong error: (should contain \"%s\") got:\n%v", expected, err)
  286. }
  287. logDone("build - multiple add files to file")
  288. }
  289. func TestBuildAddMultipleFilesToFileWild(t *testing.T) {
  290. name := "testaddmultiplefilestofilewild"
  291. defer deleteImages(name)
  292. ctx, err := fakeContext(`FROM scratch
  293. ADD file*.txt test
  294. `,
  295. map[string]string{
  296. "file1.txt": "test1",
  297. "file2.txt": "test1",
  298. })
  299. defer ctx.Close()
  300. if err != nil {
  301. t.Fatal(err)
  302. }
  303. expected := "When using ADD with more than one source file, the destination must be a directory and end with a /"
  304. if _, err := buildImageFromContext(name, ctx, true); err == nil || !strings.Contains(err.Error(), expected) {
  305. t.Fatalf("Wrong error: (should contain \"%s\") got:\n%v", expected, err)
  306. }
  307. logDone("build - multiple add files to file wild")
  308. }
  309. func TestBuildCopyMultipleFilesToFile(t *testing.T) {
  310. name := "testcopymultiplefilestofile"
  311. defer deleteImages(name)
  312. ctx, err := fakeContext(`FROM scratch
  313. COPY file1.txt file2.txt test
  314. `,
  315. map[string]string{
  316. "file1.txt": "test1",
  317. "file2.txt": "test1",
  318. })
  319. defer ctx.Close()
  320. if err != nil {
  321. t.Fatal(err)
  322. }
  323. expected := "When using COPY with more than one source file, the destination must be a directory and end with a /"
  324. if _, err := buildImageFromContext(name, ctx, true); err == nil || !strings.Contains(err.Error(), expected) {
  325. t.Fatalf("Wrong error: (should contain \"%s\") got:\n%v", expected, err)
  326. }
  327. logDone("build - multiple copy files to file")
  328. }
  329. func TestBuildCopyWildcard(t *testing.T) {
  330. name := "testcopywildcard"
  331. defer deleteImages(name)
  332. server, err := fakeStorage(map[string]string{
  333. "robots.txt": "hello",
  334. "index.html": "world",
  335. })
  336. if err != nil {
  337. t.Fatal(err)
  338. }
  339. defer server.Close()
  340. ctx, err := fakeContext(fmt.Sprintf(`FROM busybox
  341. COPY file*.txt /tmp/
  342. RUN ls /tmp/file1.txt /tmp/file2.txt
  343. RUN mkdir /tmp1
  344. COPY dir* /tmp1/
  345. RUN ls /tmp1/dirt /tmp1/nested_file /tmp1/nested_dir/nest_nest_file
  346. RUN mkdir /tmp2
  347. ADD dir/*dir %s/robots.txt /tmp2/
  348. RUN ls /tmp2/nest_nest_file /tmp2/robots.txt
  349. `, server.URL),
  350. map[string]string{
  351. "file1.txt": "test1",
  352. "file2.txt": "test2",
  353. "dir/nested_file": "nested file",
  354. "dir/nested_dir/nest_nest_file": "2 times nested",
  355. "dirt": "dirty",
  356. })
  357. defer ctx.Close()
  358. if err != nil {
  359. t.Fatal(err)
  360. }
  361. id1, err := buildImageFromContext(name, ctx, true)
  362. if err != nil {
  363. t.Fatal(err)
  364. }
  365. // Now make sure we use a cache the 2nd time
  366. id2, err := buildImageFromContext(name, ctx, true)
  367. if err != nil {
  368. t.Fatal(err)
  369. }
  370. if id1 != id2 {
  371. t.Fatal("didn't use the cache")
  372. }
  373. logDone("build - copy wild card")
  374. }
  375. func TestBuildCopyWildcardNoFind(t *testing.T) {
  376. name := "testcopywildcardnofind"
  377. defer deleteImages(name)
  378. ctx, err := fakeContext(`FROM busybox
  379. COPY file*.txt /tmp/
  380. `, nil)
  381. defer ctx.Close()
  382. if err != nil {
  383. t.Fatal(err)
  384. }
  385. _, err = buildImageFromContext(name, ctx, true)
  386. if err == nil {
  387. t.Fatal("should have failed to find a file")
  388. }
  389. if !strings.Contains(err.Error(), "No source files were specified") {
  390. t.Fatalf("Wrong error %v, must be about no source files", err)
  391. }
  392. logDone("build - copy wild card no find")
  393. }
  394. func TestBuildCopyWildcardCache(t *testing.T) {
  395. name := "testcopywildcardcache"
  396. defer deleteImages(name)
  397. ctx, err := fakeContext(`FROM busybox
  398. COPY file1.txt /tmp/`,
  399. map[string]string{
  400. "file1.txt": "test1",
  401. })
  402. defer ctx.Close()
  403. if err != nil {
  404. t.Fatal(err)
  405. }
  406. id1, err := buildImageFromContext(name, ctx, true)
  407. if err != nil {
  408. t.Fatal(err)
  409. }
  410. // Now make sure we use a cache the 2nd time even with wild cards.
  411. // Use the same context so the file is the same and the checksum will match
  412. ctx.Add("Dockerfile", `FROM busybox
  413. COPY file*.txt /tmp/`)
  414. id2, err := buildImageFromContext(name, ctx, true)
  415. if err != nil {
  416. t.Fatal(err)
  417. }
  418. if id1 != id2 {
  419. t.Fatal("didn't use the cache")
  420. }
  421. logDone("build - copy wild card cache")
  422. }
  423. func TestBuildAddSingleFileToNonExistingDir(t *testing.T) {
  424. name := "testaddsinglefiletononexistingdir"
  425. defer deleteImages(name)
  426. ctx, err := fakeContext(`FROM busybox
  427. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  428. RUN echo 'dockerio:x:1001:' >> /etc/group
  429. RUN touch /exists
  430. RUN chown dockerio.dockerio /exists
  431. ADD test_file /test_dir/
  432. RUN [ $(ls -l / | grep test_dir | awk '{print $3":"$4}') = 'root:root' ]
  433. RUN [ $(ls -l /test_dir/test_file | awk '{print $3":"$4}') = 'root:root' ]
  434. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  435. map[string]string{
  436. "test_file": "test1",
  437. })
  438. if err != nil {
  439. t.Fatal(err)
  440. }
  441. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  442. t.Fatal(err)
  443. }
  444. logDone("build - add single file to non-existing dir")
  445. }
  446. func TestBuildAddDirContentToRoot(t *testing.T) {
  447. name := "testadddircontenttoroot"
  448. defer deleteImages(name)
  449. ctx, err := fakeContext(`FROM busybox
  450. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  451. RUN echo 'dockerio:x:1001:' >> /etc/group
  452. RUN touch /exists
  453. RUN chown dockerio.dockerio exists
  454. ADD test_dir /
  455. RUN [ $(ls -l /test_file | awk '{print $3":"$4}') = 'root:root' ]
  456. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  457. map[string]string{
  458. "test_dir/test_file": "test1",
  459. })
  460. if err != nil {
  461. t.Fatal(err)
  462. }
  463. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  464. t.Fatal(err)
  465. }
  466. logDone("build - add directory contents to root")
  467. }
  468. func TestBuildAddDirContentToExistingDir(t *testing.T) {
  469. name := "testadddircontenttoexistingdir"
  470. defer deleteImages(name)
  471. ctx, err := fakeContext(`FROM busybox
  472. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  473. RUN echo 'dockerio:x:1001:' >> /etc/group
  474. RUN mkdir /exists
  475. RUN touch /exists/exists_file
  476. RUN chown -R dockerio.dockerio /exists
  477. ADD test_dir/ /exists/
  478. RUN [ $(ls -l / | grep exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]
  479. RUN [ $(ls -l /exists/exists_file | awk '{print $3":"$4}') = 'dockerio:dockerio' ]
  480. RUN [ $(ls -l /exists/test_file | awk '{print $3":"$4}') = 'root:root' ]`,
  481. map[string]string{
  482. "test_dir/test_file": "test1",
  483. })
  484. if err != nil {
  485. t.Fatal(err)
  486. }
  487. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  488. t.Fatal(err)
  489. }
  490. logDone("build - add directory contents to existing dir")
  491. }
  492. func TestBuildAddWholeDirToRoot(t *testing.T) {
  493. name := "testaddwholedirtoroot"
  494. defer deleteImages(name)
  495. ctx, err := fakeContext(`FROM busybox
  496. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  497. RUN echo 'dockerio:x:1001:' >> /etc/group
  498. RUN touch /exists
  499. RUN chown dockerio.dockerio exists
  500. ADD test_dir /test_dir
  501. RUN [ $(ls -l / | grep test_dir | awk '{print $3":"$4}') = 'root:root' ]
  502. RUN [ $(ls -l / | grep test_dir | awk '{print $1}') = 'drwxr-xr-x' ]
  503. RUN [ $(ls -l /test_dir/test_file | awk '{print $3":"$4}') = 'root:root' ]
  504. RUN [ $(ls -l /test_dir/test_file | awk '{print $1}') = '-rw-r--r--' ]
  505. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  506. map[string]string{
  507. "test_dir/test_file": "test1",
  508. })
  509. if err != nil {
  510. t.Fatal(err)
  511. }
  512. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  513. t.Fatal(err)
  514. }
  515. logDone("build - add whole directory to root")
  516. }
  517. // Testing #5941
  518. func TestBuildAddEtcToRoot(t *testing.T) {
  519. name := "testaddetctoroot"
  520. defer deleteImages(name)
  521. ctx, err := fakeContext(`FROM scratch
  522. ADD . /`,
  523. map[string]string{
  524. "etc/test_file": "test1",
  525. })
  526. if err != nil {
  527. t.Fatal(err)
  528. }
  529. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  530. t.Fatal(err)
  531. }
  532. logDone("build - add etc directory to root")
  533. }
  534. func TestBuildCopySingleFileToRoot(t *testing.T) {
  535. testDirName := "SingleFileToRoot"
  536. sourceDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy", testDirName)
  537. buildDirectory, err := ioutil.TempDir("", "test-build-add")
  538. defer os.RemoveAll(buildDirectory)
  539. err = copyWithCP(sourceDirectory, buildDirectory)
  540. if err != nil {
  541. t.Fatalf("failed to copy files to temporary directory: %s", err)
  542. }
  543. buildDirectory = filepath.Join(buildDirectory, testDirName)
  544. f, err := os.OpenFile(filepath.Join(buildDirectory, "test_file"), os.O_CREATE, 0644)
  545. if err != nil {
  546. t.Fatal(err)
  547. }
  548. f.Close()
  549. if out, _, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", "."); err != nil {
  550. t.Fatalf("build failed to complete: %s, %v", out, err)
  551. }
  552. deleteImages("testcopyimg")
  553. logDone("build - copy single file to root")
  554. }
  555. // Issue #3960: "ADD src ." hangs - adapted for COPY
  556. func TestBuildCopySingleFileToWorkdir(t *testing.T) {
  557. testDirName := "SingleFileToWorkdir"
  558. sourceDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy", testDirName)
  559. buildDirectory, err := ioutil.TempDir("", "test-build-add")
  560. defer os.RemoveAll(buildDirectory)
  561. err = copyWithCP(sourceDirectory, buildDirectory)
  562. if err != nil {
  563. t.Fatalf("failed to copy files to temporary directory: %s", err)
  564. }
  565. buildDirectory = filepath.Join(buildDirectory, testDirName)
  566. f, err := os.OpenFile(filepath.Join(buildDirectory, "test_file"), os.O_CREATE, 0644)
  567. if err != nil {
  568. t.Fatal(err)
  569. }
  570. f.Close()
  571. if out, _, err := dockerCmdInDirWithTimeout(5*time.Second, buildDirectory, "build", "-t", "testcopyimg", "."); err != nil {
  572. t.Fatalf("build failed to complete: %s, %v", out, err)
  573. }
  574. deleteImages("testcopyimg")
  575. logDone("build - copy single file to workdir")
  576. }
  577. func TestBuildCopySingleFileToExistDir(t *testing.T) {
  578. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
  579. if out, _, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", "SingleFileToExistDir"); err != nil {
  580. t.Fatalf("build failed to complete: %s, %v", out, err)
  581. }
  582. deleteImages("testcopyimg")
  583. logDone("build - copy single file to existing dir")
  584. }
  585. func TestBuildCopySingleFileToNonExistDir(t *testing.T) {
  586. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
  587. if out, _, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", "SingleFileToNonExistDir"); err != nil {
  588. t.Fatalf("build failed to complete: %s, %v", out, err)
  589. }
  590. deleteImages("testcopyimg")
  591. logDone("build - copy single file to non-existing dir")
  592. }
  593. func TestBuildCopyDirContentToRoot(t *testing.T) {
  594. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
  595. if out, _, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", "DirContentToRoot"); err != nil {
  596. t.Fatalf("build failed to complete: %s, %v", out, err)
  597. }
  598. deleteImages("testcopyimg")
  599. logDone("build - copy directory contents to root")
  600. }
  601. func TestBuildCopyDirContentToExistDir(t *testing.T) {
  602. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
  603. if out, _, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", "DirContentToExistDir"); err != nil {
  604. t.Fatalf("build failed to complete: %s, %v", out, err)
  605. }
  606. deleteImages("testcopyimg")
  607. logDone("build - copy directory contents to existing dir")
  608. }
  609. func TestBuildCopyWholeDirToRoot(t *testing.T) {
  610. testDirName := "WholeDirToRoot"
  611. sourceDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy", testDirName)
  612. buildDirectory, err := ioutil.TempDir("", "test-build-add")
  613. defer os.RemoveAll(buildDirectory)
  614. err = copyWithCP(sourceDirectory, buildDirectory)
  615. if err != nil {
  616. t.Fatalf("failed to copy files to temporary directory: %s", err)
  617. }
  618. buildDirectory = filepath.Join(buildDirectory, testDirName)
  619. testDir := filepath.Join(buildDirectory, "test_dir")
  620. if err := os.MkdirAll(testDir, 0755); err != nil {
  621. t.Fatal(err)
  622. }
  623. f, err := os.OpenFile(filepath.Join(testDir, "test_file"), os.O_CREATE, 0644)
  624. if err != nil {
  625. t.Fatal(err)
  626. }
  627. f.Close()
  628. if out, _, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", "."); err != nil {
  629. t.Fatalf("build failed to complete: %s, %v", out, err)
  630. }
  631. deleteImages("testcopyimg")
  632. logDone("build - copy whole directory to root")
  633. }
  634. func TestBuildCopyEtcToRoot(t *testing.T) {
  635. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
  636. if out, _, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", "EtcToRoot"); err != nil {
  637. t.Fatalf("build failed to complete: %s, %v", out, err)
  638. }
  639. deleteImages("testcopyimg")
  640. logDone("build - copy etc directory to root")
  641. }
  642. func TestBuildCopyDisallowRemote(t *testing.T) {
  643. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
  644. buildCmd := exec.Command(dockerBinary, "build", "-t", "testcopyimg", "DisallowRemote")
  645. buildCmd.Dir = buildDirectory
  646. if out, _, err := runCommandWithOutput(buildCmd); err == nil {
  647. t.Fatalf("building the image should've failed; output: %s", out)
  648. }
  649. deleteImages("testcopyimg")
  650. logDone("build - copy - disallow copy from remote")
  651. }
  652. // Issue #5270 - ensure we throw a better error than "unexpected EOF"
  653. // when we can't access files in the context.
  654. func TestBuildWithInaccessibleFilesInContext(t *testing.T) {
  655. {
  656. name := "testbuildinaccessiblefiles"
  657. defer deleteImages(name)
  658. ctx, err := fakeContext("FROM scratch\nADD . /foo/", map[string]string{"fileWithoutReadAccess": "foo"})
  659. if err != nil {
  660. t.Fatal(err)
  661. }
  662. defer ctx.Close()
  663. // This is used to ensure we detect inaccessible files early during build in the cli client
  664. pathToFileWithoutReadAccess := filepath.Join(ctx.Dir, "fileWithoutReadAccess")
  665. if err = os.Chown(pathToFileWithoutReadAccess, 0, 0); err != nil {
  666. t.Fatalf("failed to chown file to root: %s", err)
  667. }
  668. if err = os.Chmod(pathToFileWithoutReadAccess, 0700); err != nil {
  669. t.Fatalf("failed to chmod file to 700: %s", err)
  670. }
  671. buildCmd := exec.Command("su", "unprivilegeduser", "-c", fmt.Sprintf("%s build -t %s .", dockerBinary, name))
  672. buildCmd.Dir = ctx.Dir
  673. out, _, err := runCommandWithOutput(buildCmd)
  674. if err == nil {
  675. t.Fatalf("build should have failed: %s %s", err, out)
  676. }
  677. // check if we've detected the failure before we started building
  678. if !strings.Contains(out, "no permission to read from ") {
  679. t.Fatalf("output should've contained the string: no permission to read from but contained: %s", out)
  680. }
  681. if !strings.Contains(out, "Error checking context is accessible") {
  682. t.Fatalf("output should've contained the string: Error checking context is accessible")
  683. }
  684. }
  685. {
  686. name := "testbuildinaccessibledirectory"
  687. defer deleteImages(name)
  688. ctx, err := fakeContext("FROM scratch\nADD . /foo/", map[string]string{"directoryWeCantStat/bar": "foo"})
  689. if err != nil {
  690. t.Fatal(err)
  691. }
  692. defer ctx.Close()
  693. // This is used to ensure we detect inaccessible directories early during build in the cli client
  694. pathToDirectoryWithoutReadAccess := filepath.Join(ctx.Dir, "directoryWeCantStat")
  695. pathToFileInDirectoryWithoutReadAccess := filepath.Join(pathToDirectoryWithoutReadAccess, "bar")
  696. if err = os.Chown(pathToDirectoryWithoutReadAccess, 0, 0); err != nil {
  697. t.Fatalf("failed to chown directory to root: %s", err)
  698. }
  699. if err = os.Chmod(pathToDirectoryWithoutReadAccess, 0444); err != nil {
  700. t.Fatalf("failed to chmod directory to 755: %s", err)
  701. }
  702. if err = os.Chmod(pathToFileInDirectoryWithoutReadAccess, 0700); err != nil {
  703. t.Fatalf("failed to chmod file to 444: %s", err)
  704. }
  705. buildCmd := exec.Command("su", "unprivilegeduser", "-c", fmt.Sprintf("%s build -t %s .", dockerBinary, name))
  706. buildCmd.Dir = ctx.Dir
  707. out, _, err := runCommandWithOutput(buildCmd)
  708. if err == nil {
  709. t.Fatalf("build should have failed: %s %s", err, out)
  710. }
  711. // check if we've detected the failure before we started building
  712. if !strings.Contains(out, "can't stat") {
  713. t.Fatalf("output should've contained the string: can't access %s", out)
  714. }
  715. if !strings.Contains(out, "Error checking context is accessible") {
  716. t.Fatalf("output should've contained the string: Error checking context is accessible")
  717. }
  718. }
  719. {
  720. name := "testlinksok"
  721. defer deleteImages(name)
  722. ctx, err := fakeContext("FROM scratch\nADD . /foo/", nil)
  723. if err != nil {
  724. t.Fatal(err)
  725. }
  726. defer ctx.Close()
  727. if err := os.Symlink(filepath.Join(ctx.Dir, "g"), "../../../../../../../../../../../../../../../../../../../azA"); err != nil {
  728. t.Fatal(err)
  729. }
  730. // This is used to ensure we don't follow links when checking if everything in the context is accessible
  731. // This test doesn't require that we run commands as an unprivileged user
  732. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  733. t.Fatal(err)
  734. }
  735. }
  736. {
  737. name := "testbuildignoredinaccessible"
  738. defer deleteImages(name)
  739. ctx, err := fakeContext("FROM scratch\nADD . /foo/",
  740. map[string]string{
  741. "directoryWeCantStat/bar": "foo",
  742. ".dockerignore": "directoryWeCantStat",
  743. })
  744. if err != nil {
  745. t.Fatal(err)
  746. }
  747. defer ctx.Close()
  748. // This is used to ensure we don't try to add inaccessible files when they are ignored by a .dockerignore pattern
  749. pathToDirectoryWithoutReadAccess := filepath.Join(ctx.Dir, "directoryWeCantStat")
  750. pathToFileInDirectoryWithoutReadAccess := filepath.Join(pathToDirectoryWithoutReadAccess, "bar")
  751. if err = os.Chown(pathToDirectoryWithoutReadAccess, 0, 0); err != nil {
  752. t.Fatalf("failed to chown directory to root: %s", err)
  753. }
  754. if err = os.Chmod(pathToDirectoryWithoutReadAccess, 0444); err != nil {
  755. t.Fatalf("failed to chmod directory to 755: %s", err)
  756. }
  757. if err = os.Chmod(pathToFileInDirectoryWithoutReadAccess, 0700); err != nil {
  758. t.Fatalf("failed to chmod file to 444: %s", err)
  759. }
  760. buildCmd := exec.Command("su", "unprivilegeduser", "-c", fmt.Sprintf("%s build -t %s .", dockerBinary, name))
  761. buildCmd.Dir = ctx.Dir
  762. if out, _, err := runCommandWithOutput(buildCmd); err != nil {
  763. t.Fatalf("build should have worked: %s %s", err, out)
  764. }
  765. }
  766. logDone("build - ADD from context with inaccessible files must fail")
  767. logDone("build - ADD from context with accessible links must work")
  768. logDone("build - ADD from context with ignored inaccessible files must work")
  769. }
  770. func TestBuildForceRm(t *testing.T) {
  771. containerCountBefore, err := getContainerCount()
  772. if err != nil {
  773. t.Fatalf("failed to get the container count: %s", err)
  774. }
  775. name := "testbuildforcerm"
  776. defer deleteImages(name)
  777. ctx, err := fakeContext("FROM scratch\nRUN true\nRUN thiswillfail", nil)
  778. if err != nil {
  779. t.Fatal(err)
  780. }
  781. defer ctx.Close()
  782. buildCmd := exec.Command(dockerBinary, "build", "-t", name, "--force-rm", ".")
  783. buildCmd.Dir = ctx.Dir
  784. if out, _, err := runCommandWithOutput(buildCmd); err == nil {
  785. t.Fatal("failed to build the image: %s, %v", out, err)
  786. }
  787. containerCountAfter, err := getContainerCount()
  788. if err != nil {
  789. t.Fatalf("failed to get the container count: %s", err)
  790. }
  791. if containerCountBefore != containerCountAfter {
  792. t.Fatalf("--force-rm shouldn't have left containers behind")
  793. }
  794. logDone("build - ensure --force-rm doesn't leave containers behind")
  795. }
  796. func TestBuildRm(t *testing.T) {
  797. name := "testbuildrm"
  798. defer deleteImages(name)
  799. ctx, err := fakeContext("FROM scratch\nADD foo /\nADD foo /", map[string]string{"foo": "bar"})
  800. if err != nil {
  801. t.Fatal(err)
  802. }
  803. defer ctx.Close()
  804. {
  805. containerCountBefore, err := getContainerCount()
  806. if err != nil {
  807. t.Fatalf("failed to get the container count: %s", err)
  808. }
  809. out, _, err := dockerCmdInDir(t, ctx.Dir, "build", "--rm", "-t", name, ".")
  810. if err != nil {
  811. t.Fatal("failed to build the image", out)
  812. }
  813. containerCountAfter, err := getContainerCount()
  814. if err != nil {
  815. t.Fatalf("failed to get the container count: %s", err)
  816. }
  817. if containerCountBefore != containerCountAfter {
  818. t.Fatalf("-rm shouldn't have left containers behind")
  819. }
  820. deleteImages(name)
  821. }
  822. {
  823. containerCountBefore, err := getContainerCount()
  824. if err != nil {
  825. t.Fatalf("failed to get the container count: %s", err)
  826. }
  827. out, _, err := dockerCmdInDir(t, ctx.Dir, "build", "-t", name, ".")
  828. if err != nil {
  829. t.Fatal("failed to build the image", out)
  830. }
  831. containerCountAfter, err := getContainerCount()
  832. if err != nil {
  833. t.Fatalf("failed to get the container count: %s", err)
  834. }
  835. if containerCountBefore != containerCountAfter {
  836. t.Fatalf("--rm shouldn't have left containers behind")
  837. }
  838. deleteImages(name)
  839. }
  840. {
  841. containerCountBefore, err := getContainerCount()
  842. if err != nil {
  843. t.Fatalf("failed to get the container count: %s", err)
  844. }
  845. out, _, err := dockerCmdInDir(t, ctx.Dir, "build", "--rm=false", "-t", name, ".")
  846. if err != nil {
  847. t.Fatal("failed to build the image", out)
  848. }
  849. containerCountAfter, err := getContainerCount()
  850. if err != nil {
  851. t.Fatalf("failed to get the container count: %s", err)
  852. }
  853. if containerCountBefore == containerCountAfter {
  854. t.Fatalf("--rm=false should have left containers behind")
  855. }
  856. deleteAllContainers()
  857. deleteImages(name)
  858. }
  859. logDone("build - ensure --rm doesn't leave containers behind and that --rm=true is the default")
  860. logDone("build - ensure --rm=false overrides the default")
  861. }
  862. func TestBuildWithVolumes(t *testing.T) {
  863. var (
  864. result map[string]map[string]struct{}
  865. name = "testbuildvolumes"
  866. emptyMap = make(map[string]struct{})
  867. expected = map[string]map[string]struct{}{
  868. "/test1": emptyMap,
  869. "/test2": emptyMap,
  870. "/test3": emptyMap,
  871. "/test4": emptyMap,
  872. "/test5": emptyMap,
  873. "/test6": emptyMap,
  874. "[/test7": emptyMap,
  875. "/test8]": emptyMap,
  876. }
  877. )
  878. defer deleteImages(name)
  879. _, err := buildImage(name,
  880. `FROM scratch
  881. VOLUME /test1
  882. VOLUME /test2
  883. VOLUME /test3 /test4
  884. VOLUME ["/test5", "/test6"]
  885. VOLUME [/test7 /test8]
  886. `,
  887. true)
  888. if err != nil {
  889. t.Fatal(err)
  890. }
  891. res, err := inspectFieldJSON(name, "Config.Volumes")
  892. if err != nil {
  893. t.Fatal(err)
  894. }
  895. err = unmarshalJSON([]byte(res), &result)
  896. if err != nil {
  897. t.Fatal(err)
  898. }
  899. equal := deepEqual(&expected, &result)
  900. if !equal {
  901. t.Fatalf("Volumes %s, expected %s", result, expected)
  902. }
  903. logDone("build - with volumes")
  904. }
  905. func TestBuildMaintainer(t *testing.T) {
  906. name := "testbuildmaintainer"
  907. expected := "dockerio"
  908. defer deleteImages(name)
  909. _, err := buildImage(name,
  910. `FROM scratch
  911. MAINTAINER dockerio`,
  912. true)
  913. if err != nil {
  914. t.Fatal(err)
  915. }
  916. res, err := inspectField(name, "Author")
  917. if err != nil {
  918. t.Fatal(err)
  919. }
  920. if res != expected {
  921. t.Fatalf("Maintainer %s, expected %s", res, expected)
  922. }
  923. logDone("build - maintainer")
  924. }
  925. func TestBuildUser(t *testing.T) {
  926. name := "testbuilduser"
  927. expected := "dockerio"
  928. defer deleteImages(name)
  929. _, err := buildImage(name,
  930. `FROM busybox
  931. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  932. USER dockerio
  933. RUN [ $(whoami) = 'dockerio' ]`,
  934. true)
  935. if err != nil {
  936. t.Fatal(err)
  937. }
  938. res, err := inspectField(name, "Config.User")
  939. if err != nil {
  940. t.Fatal(err)
  941. }
  942. if res != expected {
  943. t.Fatalf("User %s, expected %s", res, expected)
  944. }
  945. logDone("build - user")
  946. }
  947. func TestBuildRelativeWorkdir(t *testing.T) {
  948. name := "testbuildrelativeworkdir"
  949. expected := "/test2/test3"
  950. defer deleteImages(name)
  951. _, err := buildImage(name,
  952. `FROM busybox
  953. RUN [ "$PWD" = '/' ]
  954. WORKDIR test1
  955. RUN [ "$PWD" = '/test1' ]
  956. WORKDIR /test2
  957. RUN [ "$PWD" = '/test2' ]
  958. WORKDIR test3
  959. RUN [ "$PWD" = '/test2/test3' ]`,
  960. true)
  961. if err != nil {
  962. t.Fatal(err)
  963. }
  964. res, err := inspectField(name, "Config.WorkingDir")
  965. if err != nil {
  966. t.Fatal(err)
  967. }
  968. if res != expected {
  969. t.Fatalf("Workdir %s, expected %s", res, expected)
  970. }
  971. logDone("build - relative workdir")
  972. }
  973. func TestBuildWorkdirWithEnvVariables(t *testing.T) {
  974. name := "testbuildworkdirwithenvvariables"
  975. expected := "/test1/test2/$MISSING_VAR"
  976. defer deleteImages(name)
  977. _, err := buildImage(name,
  978. `FROM busybox
  979. ENV DIRPATH /test1
  980. ENV SUBDIRNAME test2
  981. WORKDIR $DIRPATH
  982. WORKDIR $SUBDIRNAME/$MISSING_VAR`,
  983. true)
  984. if err != nil {
  985. t.Fatal(err)
  986. }
  987. res, err := inspectField(name, "Config.WorkingDir")
  988. if err != nil {
  989. t.Fatal(err)
  990. }
  991. if res != expected {
  992. t.Fatalf("Workdir %s, expected %s", res, expected)
  993. }
  994. logDone("build - workdir with env variables")
  995. }
  996. func TestBuildEnv(t *testing.T) {
  997. name := "testbuildenv"
  998. expected := "[PATH=/test:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PORT=2375]"
  999. defer deleteImages(name)
  1000. _, err := buildImage(name,
  1001. `FROM busybox
  1002. ENV PATH /test:$PATH
  1003. ENV PORT 2375
  1004. RUN [ $(env | grep PORT) = 'PORT=2375' ]`,
  1005. true)
  1006. if err != nil {
  1007. t.Fatal(err)
  1008. }
  1009. res, err := inspectField(name, "Config.Env")
  1010. if err != nil {
  1011. t.Fatal(err)
  1012. }
  1013. if res != expected {
  1014. t.Fatalf("Env %s, expected %s", res, expected)
  1015. }
  1016. logDone("build - env")
  1017. }
  1018. func TestBuildContextCleanup(t *testing.T) {
  1019. name := "testbuildcontextcleanup"
  1020. defer deleteImages(name)
  1021. entries, err := ioutil.ReadDir("/var/lib/docker/tmp")
  1022. if err != nil {
  1023. t.Fatalf("failed to list contents of tmp dir: %s", err)
  1024. }
  1025. _, err = buildImage(name,
  1026. `FROM scratch
  1027. ENTRYPOINT ["/bin/echo"]`,
  1028. true)
  1029. if err != nil {
  1030. t.Fatal(err)
  1031. }
  1032. entriesFinal, err := ioutil.ReadDir("/var/lib/docker/tmp")
  1033. if err != nil {
  1034. t.Fatalf("failed to list contents of tmp dir: %s", err)
  1035. }
  1036. if err = compareDirectoryEntries(entries, entriesFinal); err != nil {
  1037. t.Fatalf("context should have been deleted, but wasn't")
  1038. }
  1039. logDone("build - verify context cleanup works properly")
  1040. }
  1041. func TestBuildContextCleanupFailedBuild(t *testing.T) {
  1042. name := "testbuildcontextcleanup"
  1043. defer deleteImages(name)
  1044. entries, err := ioutil.ReadDir("/var/lib/docker/tmp")
  1045. if err != nil {
  1046. t.Fatalf("failed to list contents of tmp dir: %s", err)
  1047. }
  1048. _, err = buildImage(name,
  1049. `FROM scratch
  1050. RUN /non/existing/command`,
  1051. true)
  1052. if err == nil {
  1053. t.Fatalf("expected build to fail, but it didn't")
  1054. }
  1055. entriesFinal, err := ioutil.ReadDir("/var/lib/docker/tmp")
  1056. if err != nil {
  1057. t.Fatalf("failed to list contents of tmp dir: %s", err)
  1058. }
  1059. if err = compareDirectoryEntries(entries, entriesFinal); err != nil {
  1060. t.Fatalf("context should have been deleted, but wasn't")
  1061. }
  1062. logDone("build - verify context cleanup works properly after a failed build")
  1063. }
  1064. func TestBuildCmd(t *testing.T) {
  1065. name := "testbuildcmd"
  1066. expected := "[/bin/echo Hello World]"
  1067. defer deleteImages(name)
  1068. _, err := buildImage(name,
  1069. `FROM scratch
  1070. CMD ["/bin/echo", "Hello World"]`,
  1071. true)
  1072. if err != nil {
  1073. t.Fatal(err)
  1074. }
  1075. res, err := inspectField(name, "Config.Cmd")
  1076. if err != nil {
  1077. t.Fatal(err)
  1078. }
  1079. if res != expected {
  1080. t.Fatalf("Cmd %s, expected %s", res, expected)
  1081. }
  1082. logDone("build - cmd")
  1083. }
  1084. func TestBuildExpose(t *testing.T) {
  1085. name := "testbuildexpose"
  1086. expected := "map[2375/tcp:map[]]"
  1087. defer deleteImages(name)
  1088. _, err := buildImage(name,
  1089. `FROM scratch
  1090. EXPOSE 2375`,
  1091. true)
  1092. if err != nil {
  1093. t.Fatal(err)
  1094. }
  1095. res, err := inspectField(name, "Config.ExposedPorts")
  1096. if err != nil {
  1097. t.Fatal(err)
  1098. }
  1099. if res != expected {
  1100. t.Fatalf("Exposed ports %s, expected %s", res, expected)
  1101. }
  1102. logDone("build - expose")
  1103. }
  1104. func TestBuildEmptyEntrypoint(t *testing.T) {
  1105. name := "testbuildentrypoint"
  1106. defer deleteImages(name)
  1107. expected := "[]"
  1108. _, err := buildImage(name,
  1109. `FROM busybox
  1110. ENTRYPOINT []`,
  1111. true)
  1112. if err != nil {
  1113. t.Fatal(err)
  1114. }
  1115. res, err := inspectField(name, "Config.Entrypoint")
  1116. if err != nil {
  1117. t.Fatal(err)
  1118. }
  1119. if res != expected {
  1120. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  1121. }
  1122. logDone("build - empty entrypoint")
  1123. }
  1124. func TestBuildEntrypoint(t *testing.T) {
  1125. name := "testbuildentrypoint"
  1126. expected := "[/bin/echo]"
  1127. defer deleteImages(name)
  1128. _, err := buildImage(name,
  1129. `FROM scratch
  1130. ENTRYPOINT ["/bin/echo"]`,
  1131. true)
  1132. if err != nil {
  1133. t.Fatal(err)
  1134. }
  1135. res, err := inspectField(name, "Config.Entrypoint")
  1136. if err != nil {
  1137. t.Fatal(err)
  1138. }
  1139. if res != expected {
  1140. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  1141. }
  1142. logDone("build - entrypoint")
  1143. }
  1144. // #6445 ensure ONBUILD triggers aren't committed to grandchildren
  1145. func TestBuildOnBuildLimitedInheritence(t *testing.T) {
  1146. var (
  1147. out2, out3 string
  1148. )
  1149. {
  1150. name1 := "testonbuildtrigger1"
  1151. dockerfile1 := `
  1152. FROM busybox
  1153. RUN echo "GRANDPARENT"
  1154. ONBUILD RUN echo "ONBUILD PARENT"
  1155. `
  1156. ctx, err := fakeContext(dockerfile1, nil)
  1157. if err != nil {
  1158. t.Fatal(err)
  1159. }
  1160. out1, _, err := dockerCmdInDir(t, ctx.Dir, "build", "-t", name1, ".")
  1161. if err != nil {
  1162. t.Fatalf("build failed to complete: %s, %v", out1, err)
  1163. }
  1164. defer deleteImages(name1)
  1165. }
  1166. {
  1167. name2 := "testonbuildtrigger2"
  1168. dockerfile2 := `
  1169. FROM testonbuildtrigger1
  1170. `
  1171. ctx, err := fakeContext(dockerfile2, nil)
  1172. if err != nil {
  1173. t.Fatal(err)
  1174. }
  1175. out2, _, err = dockerCmdInDir(t, ctx.Dir, "build", "-t", name2, ".")
  1176. if err != nil {
  1177. t.Fatalf("build failed to complete: %s, %v", out2, err)
  1178. }
  1179. defer deleteImages(name2)
  1180. }
  1181. {
  1182. name3 := "testonbuildtrigger3"
  1183. dockerfile3 := `
  1184. FROM testonbuildtrigger2
  1185. `
  1186. ctx, err := fakeContext(dockerfile3, nil)
  1187. if err != nil {
  1188. t.Fatal(err)
  1189. }
  1190. out3, _, err = dockerCmdInDir(t, ctx.Dir, "build", "-t", name3, ".")
  1191. if err != nil {
  1192. t.Fatalf("build failed to complete: %s, %v", out3, err)
  1193. }
  1194. defer deleteImages(name3)
  1195. }
  1196. // ONBUILD should be run in second build.
  1197. if !strings.Contains(out2, "ONBUILD PARENT") {
  1198. t.Fatalf("ONBUILD instruction did not run in child of ONBUILD parent")
  1199. }
  1200. // ONBUILD should *not* be run in third build.
  1201. if strings.Contains(out3, "ONBUILD PARENT") {
  1202. t.Fatalf("ONBUILD instruction ran in grandchild of ONBUILD parent")
  1203. }
  1204. logDone("build - onbuild")
  1205. }
  1206. func TestBuildWithCache(t *testing.T) {
  1207. name := "testbuildwithcache"
  1208. defer deleteImages(name)
  1209. id1, err := buildImage(name,
  1210. `FROM scratch
  1211. MAINTAINER dockerio
  1212. EXPOSE 5432
  1213. ENTRYPOINT ["/bin/echo"]`,
  1214. true)
  1215. if err != nil {
  1216. t.Fatal(err)
  1217. }
  1218. id2, err := buildImage(name,
  1219. `FROM scratch
  1220. MAINTAINER dockerio
  1221. EXPOSE 5432
  1222. ENTRYPOINT ["/bin/echo"]`,
  1223. true)
  1224. if err != nil {
  1225. t.Fatal(err)
  1226. }
  1227. if id1 != id2 {
  1228. t.Fatal("The cache should have been used but hasn't.")
  1229. }
  1230. logDone("build - with cache")
  1231. }
  1232. func TestBuildWithoutCache(t *testing.T) {
  1233. name := "testbuildwithoutcache"
  1234. defer deleteImages(name)
  1235. id1, err := buildImage(name,
  1236. `FROM scratch
  1237. MAINTAINER dockerio
  1238. EXPOSE 5432
  1239. ENTRYPOINT ["/bin/echo"]`,
  1240. true)
  1241. if err != nil {
  1242. t.Fatal(err)
  1243. }
  1244. id2, err := buildImage(name,
  1245. `FROM scratch
  1246. MAINTAINER dockerio
  1247. EXPOSE 5432
  1248. ENTRYPOINT ["/bin/echo"]`,
  1249. false)
  1250. if err != nil {
  1251. t.Fatal(err)
  1252. }
  1253. if id1 == id2 {
  1254. t.Fatal("The cache should have been invalided but hasn't.")
  1255. }
  1256. logDone("build - without cache")
  1257. }
  1258. func TestBuildADDLocalFileWithCache(t *testing.T) {
  1259. name := "testbuildaddlocalfilewithcache"
  1260. defer deleteImages(name)
  1261. dockerfile := `
  1262. FROM busybox
  1263. MAINTAINER dockerio
  1264. ADD foo /usr/lib/bla/bar
  1265. RUN [ "$(cat /usr/lib/bla/bar)" = "hello" ]`
  1266. ctx, err := fakeContext(dockerfile, map[string]string{
  1267. "foo": "hello",
  1268. })
  1269. defer ctx.Close()
  1270. if err != nil {
  1271. t.Fatal(err)
  1272. }
  1273. id1, err := buildImageFromContext(name, ctx, true)
  1274. if err != nil {
  1275. t.Fatal(err)
  1276. }
  1277. id2, err := buildImageFromContext(name, ctx, true)
  1278. if err != nil {
  1279. t.Fatal(err)
  1280. }
  1281. if id1 != id2 {
  1282. t.Fatal("The cache should have been used but hasn't.")
  1283. }
  1284. logDone("build - add local file with cache")
  1285. }
  1286. func TestBuildADDMultipleLocalFileWithCache(t *testing.T) {
  1287. name := "testbuildaddmultiplelocalfilewithcache"
  1288. defer deleteImages(name)
  1289. dockerfile := `
  1290. FROM busybox
  1291. MAINTAINER dockerio
  1292. ADD foo Dockerfile /usr/lib/bla/
  1293. RUN [ "$(cat /usr/lib/bla/foo)" = "hello" ]`
  1294. ctx, err := fakeContext(dockerfile, map[string]string{
  1295. "foo": "hello",
  1296. })
  1297. defer ctx.Close()
  1298. if err != nil {
  1299. t.Fatal(err)
  1300. }
  1301. id1, err := buildImageFromContext(name, ctx, true)
  1302. if err != nil {
  1303. t.Fatal(err)
  1304. }
  1305. id2, err := buildImageFromContext(name, ctx, true)
  1306. if err != nil {
  1307. t.Fatal(err)
  1308. }
  1309. if id1 != id2 {
  1310. t.Fatal("The cache should have been used but hasn't.")
  1311. }
  1312. logDone("build - add multiple local files with cache")
  1313. }
  1314. func TestBuildADDLocalFileWithoutCache(t *testing.T) {
  1315. name := "testbuildaddlocalfilewithoutcache"
  1316. defer deleteImages(name)
  1317. dockerfile := `
  1318. FROM busybox
  1319. MAINTAINER dockerio
  1320. ADD foo /usr/lib/bla/bar
  1321. RUN [ "$(cat /usr/lib/bla/bar)" = "hello" ]`
  1322. ctx, err := fakeContext(dockerfile, map[string]string{
  1323. "foo": "hello",
  1324. })
  1325. defer ctx.Close()
  1326. if err != nil {
  1327. t.Fatal(err)
  1328. }
  1329. id1, err := buildImageFromContext(name, ctx, true)
  1330. if err != nil {
  1331. t.Fatal(err)
  1332. }
  1333. id2, err := buildImageFromContext(name, ctx, false)
  1334. if err != nil {
  1335. t.Fatal(err)
  1336. }
  1337. if id1 == id2 {
  1338. t.Fatal("The cache should have been invalided but hasn't.")
  1339. }
  1340. logDone("build - add local file without cache")
  1341. }
  1342. func TestBuildCopyDirButNotFile(t *testing.T) {
  1343. name := "testbuildcopydirbutnotfile"
  1344. defer deleteImages(name)
  1345. dockerfile := `
  1346. FROM scratch
  1347. COPY dir /tmp/`
  1348. ctx, err := fakeContext(dockerfile, map[string]string{
  1349. "dir/foo": "hello",
  1350. })
  1351. defer ctx.Close()
  1352. if err != nil {
  1353. t.Fatal(err)
  1354. }
  1355. id1, err := buildImageFromContext(name, ctx, true)
  1356. if err != nil {
  1357. t.Fatal(err)
  1358. }
  1359. // Check that adding file with similar name doesn't mess with cache
  1360. if err := ctx.Add("dir_file", "hello2"); err != nil {
  1361. t.Fatal(err)
  1362. }
  1363. id2, err := buildImageFromContext(name, ctx, true)
  1364. if err != nil {
  1365. t.Fatal(err)
  1366. }
  1367. if id1 != id2 {
  1368. t.Fatal("The cache should have been used but wasn't")
  1369. }
  1370. logDone("build - add current directory but not file")
  1371. }
  1372. func TestBuildADDCurrentDirWithCache(t *testing.T) {
  1373. name := "testbuildaddcurrentdirwithcache"
  1374. defer deleteImages(name)
  1375. dockerfile := `
  1376. FROM scratch
  1377. MAINTAINER dockerio
  1378. ADD . /usr/lib/bla`
  1379. ctx, err := fakeContext(dockerfile, map[string]string{
  1380. "foo": "hello",
  1381. })
  1382. defer ctx.Close()
  1383. if err != nil {
  1384. t.Fatal(err)
  1385. }
  1386. id1, err := buildImageFromContext(name, ctx, true)
  1387. if err != nil {
  1388. t.Fatal(err)
  1389. }
  1390. // Check that adding file invalidate cache of "ADD ."
  1391. if err := ctx.Add("bar", "hello2"); err != nil {
  1392. t.Fatal(err)
  1393. }
  1394. id2, err := buildImageFromContext(name, ctx, true)
  1395. if err != nil {
  1396. t.Fatal(err)
  1397. }
  1398. if id1 == id2 {
  1399. t.Fatal("The cache should have been invalided but hasn't.")
  1400. }
  1401. // Check that changing file invalidate cache of "ADD ."
  1402. if err := ctx.Add("foo", "hello1"); err != nil {
  1403. t.Fatal(err)
  1404. }
  1405. id3, err := buildImageFromContext(name, ctx, true)
  1406. if err != nil {
  1407. t.Fatal(err)
  1408. }
  1409. if id2 == id3 {
  1410. t.Fatal("The cache should have been invalided but hasn't.")
  1411. }
  1412. // Check that changing file to same content invalidate cache of "ADD ."
  1413. time.Sleep(1 * time.Second) // wait second because of mtime precision
  1414. if err := ctx.Add("foo", "hello1"); err != nil {
  1415. t.Fatal(err)
  1416. }
  1417. id4, err := buildImageFromContext(name, ctx, true)
  1418. if err != nil {
  1419. t.Fatal(err)
  1420. }
  1421. if id3 == id4 {
  1422. t.Fatal("The cache should have been invalided but hasn't.")
  1423. }
  1424. id5, err := buildImageFromContext(name, ctx, true)
  1425. if err != nil {
  1426. t.Fatal(err)
  1427. }
  1428. if id4 != id5 {
  1429. t.Fatal("The cache should have been used but hasn't.")
  1430. }
  1431. logDone("build - add current directory with cache")
  1432. }
  1433. func TestBuildADDCurrentDirWithoutCache(t *testing.T) {
  1434. name := "testbuildaddcurrentdirwithoutcache"
  1435. defer deleteImages(name)
  1436. dockerfile := `
  1437. FROM scratch
  1438. MAINTAINER dockerio
  1439. ADD . /usr/lib/bla`
  1440. ctx, err := fakeContext(dockerfile, map[string]string{
  1441. "foo": "hello",
  1442. })
  1443. defer ctx.Close()
  1444. if err != nil {
  1445. t.Fatal(err)
  1446. }
  1447. id1, err := buildImageFromContext(name, ctx, true)
  1448. if err != nil {
  1449. t.Fatal(err)
  1450. }
  1451. id2, err := buildImageFromContext(name, ctx, false)
  1452. if err != nil {
  1453. t.Fatal(err)
  1454. }
  1455. if id1 == id2 {
  1456. t.Fatal("The cache should have been invalided but hasn't.")
  1457. }
  1458. logDone("build - add current directory without cache")
  1459. }
  1460. func TestBuildADDRemoteFileWithCache(t *testing.T) {
  1461. name := "testbuildaddremotefilewithcache"
  1462. defer deleteImages(name)
  1463. server, err := fakeStorage(map[string]string{
  1464. "baz": "hello",
  1465. })
  1466. if err != nil {
  1467. t.Fatal(err)
  1468. }
  1469. defer server.Close()
  1470. id1, err := buildImage(name,
  1471. fmt.Sprintf(`FROM scratch
  1472. MAINTAINER dockerio
  1473. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  1474. true)
  1475. if err != nil {
  1476. t.Fatal(err)
  1477. }
  1478. id2, err := buildImage(name,
  1479. fmt.Sprintf(`FROM scratch
  1480. MAINTAINER dockerio
  1481. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  1482. true)
  1483. if err != nil {
  1484. t.Fatal(err)
  1485. }
  1486. if id1 != id2 {
  1487. t.Fatal("The cache should have been used but hasn't.")
  1488. }
  1489. logDone("build - add remote file with cache")
  1490. }
  1491. func TestBuildADDRemoteFileWithoutCache(t *testing.T) {
  1492. name := "testbuildaddremotefilewithoutcache"
  1493. defer deleteImages(name)
  1494. server, err := fakeStorage(map[string]string{
  1495. "baz": "hello",
  1496. })
  1497. if err != nil {
  1498. t.Fatal(err)
  1499. }
  1500. defer server.Close()
  1501. id1, err := buildImage(name,
  1502. fmt.Sprintf(`FROM scratch
  1503. MAINTAINER dockerio
  1504. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  1505. true)
  1506. if err != nil {
  1507. t.Fatal(err)
  1508. }
  1509. id2, err := buildImage(name,
  1510. fmt.Sprintf(`FROM scratch
  1511. MAINTAINER dockerio
  1512. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  1513. false)
  1514. if err != nil {
  1515. t.Fatal(err)
  1516. }
  1517. if id1 == id2 {
  1518. t.Fatal("The cache should have been invalided but hasn't.")
  1519. }
  1520. logDone("build - add remote file without cache")
  1521. }
  1522. func TestBuildADDLocalAndRemoteFilesWithCache(t *testing.T) {
  1523. name := "testbuildaddlocalandremotefilewithcache"
  1524. defer deleteImages(name)
  1525. server, err := fakeStorage(map[string]string{
  1526. "baz": "hello",
  1527. })
  1528. if err != nil {
  1529. t.Fatal(err)
  1530. }
  1531. defer server.Close()
  1532. ctx, err := fakeContext(fmt.Sprintf(`FROM scratch
  1533. MAINTAINER dockerio
  1534. ADD foo /usr/lib/bla/bar
  1535. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  1536. map[string]string{
  1537. "foo": "hello world",
  1538. })
  1539. if err != nil {
  1540. t.Fatal(err)
  1541. }
  1542. defer ctx.Close()
  1543. id1, err := buildImageFromContext(name, ctx, true)
  1544. if err != nil {
  1545. t.Fatal(err)
  1546. }
  1547. id2, err := buildImageFromContext(name, ctx, true)
  1548. if err != nil {
  1549. t.Fatal(err)
  1550. }
  1551. if id1 != id2 {
  1552. t.Fatal("The cache should have been used but hasn't.")
  1553. }
  1554. logDone("build - add local and remote file with cache")
  1555. }
  1556. func testContextTar(t *testing.T, compression archive.Compression) {
  1557. ctx, err := fakeContext(
  1558. `FROM busybox
  1559. ADD foo /foo
  1560. CMD ["cat", "/foo"]`,
  1561. map[string]string{
  1562. "foo": "bar",
  1563. },
  1564. )
  1565. defer ctx.Close()
  1566. if err != nil {
  1567. t.Fatal(err)
  1568. }
  1569. context, err := archive.Tar(ctx.Dir, compression)
  1570. if err != nil {
  1571. t.Fatalf("failed to build context tar: %v", err)
  1572. }
  1573. name := "contexttar"
  1574. buildCmd := exec.Command(dockerBinary, "build", "-t", name, "-")
  1575. defer deleteImages(name)
  1576. buildCmd.Stdin = context
  1577. if out, _, err := runCommandWithOutput(buildCmd); err != nil {
  1578. t.Fatalf("build failed to complete: %v %v", out, err)
  1579. }
  1580. logDone(fmt.Sprintf("build - build an image with a context tar, compression: %v", compression))
  1581. }
  1582. func TestBuildContextTarGzip(t *testing.T) {
  1583. testContextTar(t, archive.Gzip)
  1584. }
  1585. func TestBuildContextTarNoCompression(t *testing.T) {
  1586. testContextTar(t, archive.Uncompressed)
  1587. }
  1588. func TestBuildNoContext(t *testing.T) {
  1589. buildCmd := exec.Command(dockerBinary, "build", "-t", "nocontext", "-")
  1590. buildCmd.Stdin = strings.NewReader("FROM busybox\nCMD echo ok\n")
  1591. if out, _, err := runCommandWithOutput(buildCmd); err != nil {
  1592. t.Fatalf("build failed to complete: %v %v", out, err)
  1593. }
  1594. if out, _, err := cmd(t, "run", "nocontext"); out != "ok\n" || err != nil {
  1595. t.Fatalf("run produced invalid output: %q, expected %q", out, "ok")
  1596. }
  1597. deleteImages("nocontext")
  1598. logDone("build - build an image with no context")
  1599. }
  1600. // TODO: TestCaching
  1601. func TestBuildADDLocalAndRemoteFilesWithoutCache(t *testing.T) {
  1602. name := "testbuildaddlocalandremotefilewithoutcache"
  1603. defer deleteImages(name)
  1604. server, err := fakeStorage(map[string]string{
  1605. "baz": "hello",
  1606. })
  1607. if err != nil {
  1608. t.Fatal(err)
  1609. }
  1610. defer server.Close()
  1611. ctx, err := fakeContext(fmt.Sprintf(`FROM scratch
  1612. MAINTAINER dockerio
  1613. ADD foo /usr/lib/bla/bar
  1614. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  1615. map[string]string{
  1616. "foo": "hello world",
  1617. })
  1618. if err != nil {
  1619. t.Fatal(err)
  1620. }
  1621. defer ctx.Close()
  1622. id1, err := buildImageFromContext(name, ctx, true)
  1623. if err != nil {
  1624. t.Fatal(err)
  1625. }
  1626. id2, err := buildImageFromContext(name, ctx, false)
  1627. if err != nil {
  1628. t.Fatal(err)
  1629. }
  1630. if id1 == id2 {
  1631. t.Fatal("The cache should have been invalided but hasn't.")
  1632. }
  1633. logDone("build - add local and remote file without cache")
  1634. }
  1635. func TestBuildWithVolumeOwnership(t *testing.T) {
  1636. name := "testbuildimg"
  1637. defer deleteImages(name)
  1638. _, err := buildImage(name,
  1639. `FROM busybox:latest
  1640. RUN mkdir /test && chown daemon:daemon /test && chmod 0600 /test
  1641. VOLUME /test`,
  1642. true)
  1643. if err != nil {
  1644. t.Fatal(err)
  1645. }
  1646. cmd := exec.Command(dockerBinary, "run", "--rm", "testbuildimg", "ls", "-la", "/test")
  1647. out, _, err := runCommandWithOutput(cmd)
  1648. if err != nil {
  1649. t.Fatal(out, err)
  1650. }
  1651. if expected := "drw-------"; !strings.Contains(out, expected) {
  1652. t.Fatalf("expected %s received %s", expected, out)
  1653. }
  1654. if expected := "daemon daemon"; !strings.Contains(out, expected) {
  1655. t.Fatalf("expected %s received %s", expected, out)
  1656. }
  1657. logDone("build - volume ownership")
  1658. }
  1659. // testing #1405 - config.Cmd does not get cleaned up if
  1660. // utilizing cache
  1661. func TestBuildEntrypointRunCleanup(t *testing.T) {
  1662. name := "testbuildcmdcleanup"
  1663. defer deleteImages(name)
  1664. if _, err := buildImage(name,
  1665. `FROM busybox
  1666. RUN echo "hello"`,
  1667. true); err != nil {
  1668. t.Fatal(err)
  1669. }
  1670. ctx, err := fakeContext(`FROM busybox
  1671. RUN echo "hello"
  1672. ADD foo /foo
  1673. ENTRYPOINT ["/bin/echo"]`,
  1674. map[string]string{
  1675. "foo": "hello",
  1676. })
  1677. defer ctx.Close()
  1678. if err != nil {
  1679. t.Fatal(err)
  1680. }
  1681. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1682. t.Fatal(err)
  1683. }
  1684. res, err := inspectField(name, "Config.Cmd")
  1685. if err != nil {
  1686. t.Fatal(err)
  1687. }
  1688. // Cmd must be cleaned up
  1689. if expected := "<no value>"; res != expected {
  1690. t.Fatalf("Cmd %s, expected %s", res, expected)
  1691. }
  1692. logDone("build - cleanup cmd after RUN")
  1693. }
  1694. func TestBuildForbiddenContextPath(t *testing.T) {
  1695. name := "testbuildforbidpath"
  1696. defer deleteImages(name)
  1697. ctx, err := fakeContext(`FROM scratch
  1698. ADD ../../ test/
  1699. `,
  1700. map[string]string{
  1701. "test.txt": "test1",
  1702. "other.txt": "other",
  1703. })
  1704. defer ctx.Close()
  1705. if err != nil {
  1706. t.Fatal(err)
  1707. }
  1708. expected := "Forbidden path outside the build context: ../../ "
  1709. if _, err := buildImageFromContext(name, ctx, true); err == nil || !strings.Contains(err.Error(), expected) {
  1710. t.Fatalf("Wrong error: (should contain \"%s\") got:\n%v", expected, err)
  1711. }
  1712. logDone("build - forbidden context path")
  1713. }
  1714. func TestBuildADDFileNotFound(t *testing.T) {
  1715. name := "testbuildaddnotfound"
  1716. defer deleteImages(name)
  1717. ctx, err := fakeContext(`FROM scratch
  1718. ADD foo /usr/local/bar`,
  1719. map[string]string{"bar": "hello"})
  1720. defer ctx.Close()
  1721. if err != nil {
  1722. t.Fatal(err)
  1723. }
  1724. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1725. if !strings.Contains(err.Error(), "foo: no such file or directory") {
  1726. t.Fatalf("Wrong error %v, must be about missing foo file or directory", err)
  1727. }
  1728. } else {
  1729. t.Fatal("Error must not be nil")
  1730. }
  1731. logDone("build - add file not found")
  1732. }
  1733. func TestBuildInheritance(t *testing.T) {
  1734. name := "testbuildinheritance"
  1735. defer deleteImages(name)
  1736. _, err := buildImage(name,
  1737. `FROM scratch
  1738. EXPOSE 2375`,
  1739. true)
  1740. if err != nil {
  1741. t.Fatal(err)
  1742. }
  1743. ports1, err := inspectField(name, "Config.ExposedPorts")
  1744. if err != nil {
  1745. t.Fatal(err)
  1746. }
  1747. _, err = buildImage(name,
  1748. fmt.Sprintf(`FROM %s
  1749. ENTRYPOINT ["/bin/echo"]`, name),
  1750. true)
  1751. if err != nil {
  1752. t.Fatal(err)
  1753. }
  1754. res, err := inspectField(name, "Config.Entrypoint")
  1755. if err != nil {
  1756. t.Fatal(err)
  1757. }
  1758. if expected := "[/bin/echo]"; res != expected {
  1759. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  1760. }
  1761. ports2, err := inspectField(name, "Config.ExposedPorts")
  1762. if err != nil {
  1763. t.Fatal(err)
  1764. }
  1765. if ports1 != ports2 {
  1766. t.Fatalf("Ports must be same: %s != %s", ports1, ports2)
  1767. }
  1768. logDone("build - inheritance")
  1769. }
  1770. func TestBuildFails(t *testing.T) {
  1771. name := "testbuildfails"
  1772. defer deleteImages(name)
  1773. _, err := buildImage(name,
  1774. `FROM busybox
  1775. RUN sh -c "exit 23"`,
  1776. true)
  1777. if err != nil {
  1778. if !strings.Contains(err.Error(), "returned a non-zero code: 23") {
  1779. t.Fatalf("Wrong error %v, must be about non-zero code 23", err)
  1780. }
  1781. } else {
  1782. t.Fatal("Error must not be nil")
  1783. }
  1784. logDone("build - fails")
  1785. }
  1786. func TestBuildFailsDockerfileEmpty(t *testing.T) {
  1787. name := "testbuildfails"
  1788. defer deleteImages(name)
  1789. _, err := buildImage(name, ``, true)
  1790. if err != nil {
  1791. if !strings.Contains(err.Error(), "Dockerfile cannot be empty") {
  1792. t.Fatalf("Wrong error %v, must be about empty Dockerfile", err)
  1793. }
  1794. } else {
  1795. t.Fatal("Error must not be nil")
  1796. }
  1797. logDone("build - fails with empty dockerfile")
  1798. }
  1799. func TestBuildOnBuild(t *testing.T) {
  1800. name := "testbuildonbuild"
  1801. defer deleteImages(name)
  1802. _, err := buildImage(name,
  1803. `FROM busybox
  1804. ONBUILD RUN touch foobar`,
  1805. true)
  1806. if err != nil {
  1807. t.Fatal(err)
  1808. }
  1809. _, err = buildImage(name,
  1810. fmt.Sprintf(`FROM %s
  1811. RUN [ -f foobar ]`, name),
  1812. true)
  1813. if err != nil {
  1814. t.Fatal(err)
  1815. }
  1816. logDone("build - onbuild")
  1817. }
  1818. func TestBuildOnBuildForbiddenChained(t *testing.T) {
  1819. name := "testbuildonbuildforbiddenchained"
  1820. defer deleteImages(name)
  1821. _, err := buildImage(name,
  1822. `FROM busybox
  1823. ONBUILD ONBUILD RUN touch foobar`,
  1824. true)
  1825. if err != nil {
  1826. if !strings.Contains(err.Error(), "Chaining ONBUILD via `ONBUILD ONBUILD` isn't allowed") {
  1827. t.Fatalf("Wrong error %v, must be about chaining ONBUILD", err)
  1828. }
  1829. } else {
  1830. t.Fatal("Error must not be nil")
  1831. }
  1832. logDone("build - onbuild forbidden chained")
  1833. }
  1834. func TestBuildOnBuildForbiddenFrom(t *testing.T) {
  1835. name := "testbuildonbuildforbiddenfrom"
  1836. defer deleteImages(name)
  1837. _, err := buildImage(name,
  1838. `FROM busybox
  1839. ONBUILD FROM scratch`,
  1840. true)
  1841. if err != nil {
  1842. if !strings.Contains(err.Error(), "FROM isn't allowed as an ONBUILD trigger") {
  1843. t.Fatalf("Wrong error %v, must be about FROM forbidden", err)
  1844. }
  1845. } else {
  1846. t.Fatal("Error must not be nil")
  1847. }
  1848. logDone("build - onbuild forbidden from")
  1849. }
  1850. func TestBuildOnBuildForbiddenMaintainer(t *testing.T) {
  1851. name := "testbuildonbuildforbiddenmaintainer"
  1852. defer deleteImages(name)
  1853. _, err := buildImage(name,
  1854. `FROM busybox
  1855. ONBUILD MAINTAINER docker.io`,
  1856. true)
  1857. if err != nil {
  1858. if !strings.Contains(err.Error(), "MAINTAINER isn't allowed as an ONBUILD trigger") {
  1859. t.Fatalf("Wrong error %v, must be about MAINTAINER forbidden", err)
  1860. }
  1861. } else {
  1862. t.Fatal("Error must not be nil")
  1863. }
  1864. logDone("build - onbuild forbidden maintainer")
  1865. }
  1866. // gh #2446
  1867. func TestBuildAddToSymlinkDest(t *testing.T) {
  1868. name := "testbuildaddtosymlinkdest"
  1869. defer deleteImages(name)
  1870. ctx, err := fakeContext(`FROM busybox
  1871. RUN mkdir /foo
  1872. RUN ln -s /foo /bar
  1873. ADD foo /bar/
  1874. RUN [ -f /bar/foo ]
  1875. RUN [ -f /foo/foo ]`,
  1876. map[string]string{
  1877. "foo": "hello",
  1878. })
  1879. if err != nil {
  1880. t.Fatal(err)
  1881. }
  1882. defer ctx.Close()
  1883. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1884. t.Fatal(err)
  1885. }
  1886. logDone("build - add to symlink destination")
  1887. }
  1888. func TestBuildEscapeWhitespace(t *testing.T) {
  1889. name := "testbuildescaping"
  1890. defer deleteImages(name)
  1891. _, err := buildImage(name, `
  1892. FROM busybox
  1893. MAINTAINER "Docker \
  1894. IO <io@\
  1895. docker.com>"
  1896. `, true)
  1897. res, err := inspectField(name, "Author")
  1898. if err != nil {
  1899. t.Fatal(err)
  1900. }
  1901. if res != "Docker IO <io@docker.com>" {
  1902. t.Fatal("Parsed string did not match the escaped string")
  1903. }
  1904. logDone("build - validate escaping whitespace")
  1905. }
  1906. func TestBuildDockerignore(t *testing.T) {
  1907. name := "testbuilddockerignore"
  1908. defer deleteImages(name)
  1909. dockerfile := `
  1910. FROM busybox
  1911. ADD . /bla
  1912. RUN [[ -f /bla/src/x.go ]]
  1913. RUN [[ -f /bla/Makefile ]]
  1914. RUN [[ ! -e /bla/src/_vendor ]]
  1915. RUN [[ ! -e /bla/.gitignore ]]
  1916. RUN [[ ! -e /bla/README.md ]]
  1917. RUN [[ ! -e /bla/.git ]]`
  1918. ctx, err := fakeContext(dockerfile, map[string]string{
  1919. "Makefile": "all:",
  1920. ".git/HEAD": "ref: foo",
  1921. "src/x.go": "package main",
  1922. "src/_vendor/v.go": "package main",
  1923. ".gitignore": "",
  1924. "README.md": "readme",
  1925. ".dockerignore": ".git\npkg\n.gitignore\nsrc/_vendor\n*.md",
  1926. })
  1927. defer ctx.Close()
  1928. if err != nil {
  1929. t.Fatal(err)
  1930. }
  1931. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1932. t.Fatal(err)
  1933. }
  1934. logDone("build - test .dockerignore")
  1935. }
  1936. func TestBuildDockerignoringDockerfile(t *testing.T) {
  1937. name := "testbuilddockerignoredockerfile"
  1938. defer deleteImages(name)
  1939. dockerfile := `
  1940. FROM scratch`
  1941. ctx, err := fakeContext(dockerfile, map[string]string{
  1942. "Dockerfile": "FROM scratch",
  1943. ".dockerignore": "Dockerfile\n",
  1944. })
  1945. defer ctx.Close()
  1946. if err != nil {
  1947. t.Fatal(err)
  1948. }
  1949. if _, err = buildImageFromContext(name, ctx, true); err == nil {
  1950. t.Fatalf("Didn't get expected error from ignoring Dockerfile")
  1951. }
  1952. logDone("build - test .dockerignore of Dockerfile")
  1953. }
  1954. func TestBuildDockerignoringWholeDir(t *testing.T) {
  1955. name := "testbuilddockerignorewholedir"
  1956. defer deleteImages(name)
  1957. dockerfile := `
  1958. FROM busybox
  1959. COPY . /
  1960. RUN [[ ! -e /.gitignore ]]
  1961. RUN [[ -f /Makefile ]]`
  1962. ctx, err := fakeContext(dockerfile, map[string]string{
  1963. "Dockerfile": "FROM scratch",
  1964. "Makefile": "all:",
  1965. ".dockerignore": ".*\n",
  1966. })
  1967. defer ctx.Close()
  1968. if err != nil {
  1969. t.Fatal(err)
  1970. }
  1971. if _, err = buildImageFromContext(name, ctx, true); err != nil {
  1972. t.Fatal(err)
  1973. }
  1974. logDone("build - test .dockerignore whole dir with .*")
  1975. }
  1976. func TestBuildLineBreak(t *testing.T) {
  1977. name := "testbuildlinebreak"
  1978. defer deleteImages(name)
  1979. _, err := buildImage(name,
  1980. `FROM busybox
  1981. RUN sh -c 'echo root:testpass \
  1982. > /tmp/passwd'
  1983. RUN mkdir -p /var/run/sshd
  1984. RUN [ "$(cat /tmp/passwd)" = "root:testpass" ]
  1985. RUN [ "$(ls -d /var/run/sshd)" = "/var/run/sshd" ]`,
  1986. true)
  1987. if err != nil {
  1988. t.Fatal(err)
  1989. }
  1990. logDone("build - line break with \\")
  1991. }
  1992. func TestBuildEOLInLine(t *testing.T) {
  1993. name := "testbuildeolinline"
  1994. defer deleteImages(name)
  1995. _, err := buildImage(name,
  1996. `FROM busybox
  1997. RUN sh -c 'echo root:testpass > /tmp/passwd'
  1998. RUN echo "foo \n bar"; echo "baz"
  1999. RUN mkdir -p /var/run/sshd
  2000. RUN [ "$(cat /tmp/passwd)" = "root:testpass" ]
  2001. RUN [ "$(ls -d /var/run/sshd)" = "/var/run/sshd" ]`,
  2002. true)
  2003. if err != nil {
  2004. t.Fatal(err)
  2005. }
  2006. logDone("build - end of line in dockerfile instruction")
  2007. }
  2008. func TestBuildCommentsShebangs(t *testing.T) {
  2009. name := "testbuildcomments"
  2010. defer deleteImages(name)
  2011. _, err := buildImage(name,
  2012. `FROM busybox
  2013. # This is an ordinary comment.
  2014. RUN { echo '#!/bin/sh'; echo 'echo hello world'; } > /hello.sh
  2015. RUN [ ! -x /hello.sh ]
  2016. # comment with line break \
  2017. RUN chmod +x /hello.sh
  2018. RUN [ -x /hello.sh ]
  2019. RUN [ "$(cat /hello.sh)" = $'#!/bin/sh\necho hello world' ]
  2020. RUN [ "$(/hello.sh)" = "hello world" ]`,
  2021. true)
  2022. if err != nil {
  2023. t.Fatal(err)
  2024. }
  2025. logDone("build - comments and shebangs")
  2026. }
  2027. func TestBuildUsersAndGroups(t *testing.T) {
  2028. name := "testbuildusers"
  2029. defer deleteImages(name)
  2030. _, err := buildImage(name,
  2031. `FROM busybox
  2032. # Make sure our defaults work
  2033. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)" = '0:0/root:root' ]
  2034. # TODO decide if "args.user = strconv.Itoa(syscall.Getuid())" is acceptable behavior for changeUser in sysvinit instead of "return nil" when "USER" isn't specified (so that we get the proper group list even if that is the empty list, even in the default case of not supplying an explicit USER to run as, which implies USER 0)
  2035. USER root
  2036. RUN [ "$(id -G):$(id -Gn)" = '0 10:root wheel' ]
  2037. # Setup dockerio user and group
  2038. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  2039. RUN echo 'dockerio:x:1001:' >> /etc/group
  2040. # Make sure we can switch to our user and all the information is exactly as we expect it to be
  2041. USER dockerio
  2042. RUN id -G
  2043. RUN id -Gn
  2044. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  2045. # Switch back to root and double check that worked exactly as we might expect it to
  2046. USER root
  2047. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '0:0/root:root/0 10:root wheel' ]
  2048. # Add a "supplementary" group for our dockerio user
  2049. RUN echo 'supplementary:x:1002:dockerio' >> /etc/group
  2050. # ... and then go verify that we get it like we expect
  2051. USER dockerio
  2052. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001 1002:dockerio supplementary' ]
  2053. USER 1001
  2054. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001 1002:dockerio supplementary' ]
  2055. # super test the new "user:group" syntax
  2056. USER dockerio:dockerio
  2057. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  2058. USER 1001:dockerio
  2059. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  2060. USER dockerio:1001
  2061. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  2062. USER 1001:1001
  2063. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  2064. USER dockerio:supplementary
  2065. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1002/dockerio:supplementary/1002:supplementary' ]
  2066. USER dockerio:1002
  2067. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1002/dockerio:supplementary/1002:supplementary' ]
  2068. USER 1001:supplementary
  2069. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1002/dockerio:supplementary/1002:supplementary' ]
  2070. USER 1001:1002
  2071. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1002/dockerio:supplementary/1002:supplementary' ]
  2072. # make sure unknown uid/gid still works properly
  2073. USER 1042:1043
  2074. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1042:1043/1042:1043/1043:1043' ]`,
  2075. true)
  2076. if err != nil {
  2077. t.Fatal(err)
  2078. }
  2079. logDone("build - users and groups")
  2080. }
  2081. func TestBuildEnvUsage(t *testing.T) {
  2082. name := "testbuildenvusage"
  2083. defer deleteImages(name)
  2084. dockerfile := `FROM busybox
  2085. ENV PATH $HOME/bin:$PATH
  2086. ENV PATH /tmp:$PATH
  2087. RUN [ "$PATH" = "/tmp:$HOME/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" ]
  2088. ENV FOO /foo/baz
  2089. ENV BAR /bar
  2090. ENV BAZ $BAR
  2091. ENV FOOPATH $PATH:$FOO
  2092. RUN [ "$BAR" = "$BAZ" ]
  2093. RUN [ "$FOOPATH" = "$PATH:/foo/baz" ]
  2094. ENV FROM hello/docker/world
  2095. ENV TO /docker/world/hello
  2096. ADD $FROM $TO
  2097. RUN [ "$(cat $TO)" = "hello" ]
  2098. `
  2099. ctx, err := fakeContext(dockerfile, map[string]string{
  2100. "hello/docker/world": "hello",
  2101. })
  2102. if err != nil {
  2103. t.Fatal(err)
  2104. }
  2105. _, err = buildImageFromContext(name, ctx, true)
  2106. if err != nil {
  2107. t.Fatal(err)
  2108. }
  2109. logDone("build - environment variables usage")
  2110. }
  2111. func TestBuildAddScript(t *testing.T) {
  2112. name := "testbuildaddscript"
  2113. defer deleteImages(name)
  2114. dockerfile := `
  2115. FROM busybox
  2116. ADD test /test
  2117. RUN ["chmod","+x","/test"]
  2118. RUN ["/test"]
  2119. RUN [ "$(cat /testfile)" = 'test!' ]`
  2120. ctx, err := fakeContext(dockerfile, map[string]string{
  2121. "test": "#!/bin/sh\necho 'test!' > /testfile",
  2122. })
  2123. if err != nil {
  2124. t.Fatal(err)
  2125. }
  2126. _, err = buildImageFromContext(name, ctx, true)
  2127. if err != nil {
  2128. t.Fatal(err)
  2129. }
  2130. logDone("build - add and run script")
  2131. }
  2132. func TestBuildAddTar(t *testing.T) {
  2133. name := "testbuildaddtar"
  2134. defer deleteImages(name)
  2135. ctx := func() *FakeContext {
  2136. dockerfile := `
  2137. FROM busybox
  2138. ADD test.tar /
  2139. RUN cat /test/foo | grep Hi
  2140. ADD test.tar /test.tar
  2141. RUN cat /test.tar/test/foo | grep Hi
  2142. ADD test.tar /unlikely-to-exist
  2143. RUN cat /unlikely-to-exist/test/foo | grep Hi
  2144. ADD test.tar /unlikely-to-exist-trailing-slash/
  2145. RUN cat /unlikely-to-exist-trailing-slash/test/foo | grep Hi
  2146. RUN mkdir /existing-directory
  2147. ADD test.tar /existing-directory
  2148. RUN cat /existing-directory/test/foo | grep Hi
  2149. ADD test.tar /existing-directory-trailing-slash/
  2150. RUN cat /existing-directory-trailing-slash/test/foo | grep Hi`
  2151. tmpDir, err := ioutil.TempDir("", "fake-context")
  2152. testTar, err := os.Create(filepath.Join(tmpDir, "test.tar"))
  2153. if err != nil {
  2154. t.Fatalf("failed to create test.tar archive: %v", err)
  2155. }
  2156. defer testTar.Close()
  2157. tw := tar.NewWriter(testTar)
  2158. if err := tw.WriteHeader(&tar.Header{
  2159. Name: "test/foo",
  2160. Size: 2,
  2161. }); err != nil {
  2162. t.Fatalf("failed to write tar file header: %v", err)
  2163. }
  2164. if _, err := tw.Write([]byte("Hi")); err != nil {
  2165. t.Fatalf("failed to write tar file content: %v", err)
  2166. }
  2167. if err := tw.Close(); err != nil {
  2168. t.Fatalf("failed to close tar archive: %v", err)
  2169. }
  2170. if err := ioutil.WriteFile(filepath.Join(tmpDir, "Dockerfile"), []byte(dockerfile), 0644); err != nil {
  2171. t.Fatalf("failed to open destination dockerfile: %v", err)
  2172. }
  2173. return &FakeContext{Dir: tmpDir}
  2174. }()
  2175. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  2176. t.Fatalf("build failed to complete for TestBuildAddTar: %v", err)
  2177. }
  2178. logDone("build - ADD tar")
  2179. }
  2180. func TestBuildFromGIT(t *testing.T) {
  2181. name := "testbuildfromgit"
  2182. defer deleteImages(name)
  2183. git, err := fakeGIT("repo", map[string]string{
  2184. "Dockerfile": `FROM busybox
  2185. ADD first /first
  2186. RUN [ -f /first ]
  2187. MAINTAINER docker`,
  2188. "first": "test git data",
  2189. })
  2190. if err != nil {
  2191. t.Fatal(err)
  2192. }
  2193. defer git.Close()
  2194. _, err = buildImageFromPath(name, git.RepoURL, true)
  2195. if err != nil {
  2196. t.Fatal(err)
  2197. }
  2198. res, err := inspectField(name, "Author")
  2199. if err != nil {
  2200. t.Fatal(err)
  2201. }
  2202. if res != "docker" {
  2203. t.Fatalf("Maintainer should be docker, got %s", res)
  2204. }
  2205. logDone("build - build from GIT")
  2206. }
  2207. func TestBuildCleanupCmdOnEntrypoint(t *testing.T) {
  2208. name := "testbuildcmdcleanuponentrypoint"
  2209. defer deleteImages(name)
  2210. if _, err := buildImage(name,
  2211. `FROM scratch
  2212. CMD ["test"]
  2213. ENTRYPOINT ["echo"]`,
  2214. true); err != nil {
  2215. t.Fatal(err)
  2216. }
  2217. if _, err := buildImage(name,
  2218. fmt.Sprintf(`FROM %s
  2219. ENTRYPOINT ["cat"]`, name),
  2220. true); err != nil {
  2221. t.Fatal(err)
  2222. }
  2223. res, err := inspectField(name, "Config.Cmd")
  2224. if err != nil {
  2225. t.Fatal(err)
  2226. }
  2227. if expected := "<no value>"; res != expected {
  2228. t.Fatalf("Cmd %s, expected %s", res, expected)
  2229. }
  2230. res, err = inspectField(name, "Config.Entrypoint")
  2231. if err != nil {
  2232. t.Fatal(err)
  2233. }
  2234. if expected := "[cat]"; res != expected {
  2235. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  2236. }
  2237. logDone("build - cleanup cmd on ENTRYPOINT")
  2238. }
  2239. func TestBuildClearCmd(t *testing.T) {
  2240. name := "testbuildclearcmd"
  2241. defer deleteImages(name)
  2242. _, err := buildImage(name,
  2243. `From scratch
  2244. ENTRYPOINT ["/bin/bash"]
  2245. CMD []`,
  2246. true)
  2247. if err != nil {
  2248. t.Fatal(err)
  2249. }
  2250. res, err := inspectFieldJSON(name, "Config.Cmd")
  2251. if err != nil {
  2252. t.Fatal(err)
  2253. }
  2254. if res != "[]" {
  2255. t.Fatalf("Cmd %s, expected %s", res, "[]")
  2256. }
  2257. logDone("build - clearcmd")
  2258. }
  2259. func TestBuildEmptyCmd(t *testing.T) {
  2260. name := "testbuildemptycmd"
  2261. defer deleteImages(name)
  2262. if _, err := buildImage(name, "FROM scratch\nMAINTAINER quux\n", true); err != nil {
  2263. t.Fatal(err)
  2264. }
  2265. res, err := inspectFieldJSON(name, "Config.Cmd")
  2266. if err != nil {
  2267. t.Fatal(err)
  2268. }
  2269. if res != "null" {
  2270. t.Fatalf("Cmd %s, expected %s", res, "null")
  2271. }
  2272. logDone("build - empty cmd")
  2273. }
  2274. func TestBuildOnBuildOutput(t *testing.T) {
  2275. name := "testbuildonbuildparent"
  2276. defer deleteImages(name)
  2277. if _, err := buildImage(name, "FROM busybox\nONBUILD RUN echo foo\n", true); err != nil {
  2278. t.Fatal(err)
  2279. }
  2280. childname := "testbuildonbuildchild"
  2281. defer deleteImages(childname)
  2282. _, out, err := buildImageWithOut(name, "FROM "+name+"\nMAINTAINER quux\n", true)
  2283. if err != nil {
  2284. t.Fatal(err)
  2285. }
  2286. if !strings.Contains(out, "Trigger 0, RUN echo foo") {
  2287. t.Fatal("failed to find the ONBUILD output", out)
  2288. }
  2289. logDone("build - onbuild output")
  2290. }
  2291. func TestBuildInvalidTag(t *testing.T) {
  2292. name := "abcd:" + makeRandomString(200)
  2293. defer deleteImages(name)
  2294. _, out, err := buildImageWithOut(name, "FROM scratch\nMAINTAINER quux\n", true)
  2295. // if the error doesnt check for illegal tag name, or the image is built
  2296. // then this should fail
  2297. if !strings.Contains(out, "Illegal tag name") || strings.Contains(out, "Sending build context to Docker daemon") {
  2298. t.Fatalf("failed to stop before building. Error: %s, Output: %s", err, out)
  2299. }
  2300. logDone("build - invalid tag")
  2301. }
  2302. func TestBuildCmdShDashC(t *testing.T) {
  2303. name := "testbuildcmdshc"
  2304. defer deleteImages(name)
  2305. if _, err := buildImage(name, "FROM busybox\nCMD echo cmd\n", true); err != nil {
  2306. t.Fatal(err)
  2307. }
  2308. res, err := inspectFieldJSON(name, "Config.Cmd")
  2309. if err != nil {
  2310. t.Fatal(err, res)
  2311. }
  2312. expected := `["/bin/sh","-c","echo cmd"]`
  2313. if res != expected {
  2314. t.Fatalf("Expected value %s not in Config.Cmd: %s", expected, res)
  2315. }
  2316. logDone("build - cmd should have sh -c for non-json")
  2317. }
  2318. func TestBuildCmdJSONNoShDashC(t *testing.T) {
  2319. name := "testbuildcmdjson"
  2320. defer deleteImages(name)
  2321. if _, err := buildImage(name, "FROM busybox\nCMD [\"echo\", \"cmd\"]", true); err != nil {
  2322. t.Fatal(err)
  2323. }
  2324. res, err := inspectFieldJSON(name, "Config.Cmd")
  2325. if err != nil {
  2326. t.Fatal(err, res)
  2327. }
  2328. expected := `["echo","cmd"]`
  2329. if res != expected {
  2330. t.Fatalf("Expected value %s not in Config.Cmd: %s", expected, res)
  2331. }
  2332. logDone("build - cmd should not have /bin/sh -c for json")
  2333. }
  2334. func TestBuildIgnoreInvalidInstruction(t *testing.T) {
  2335. name := "testbuildignoreinvalidinstruction"
  2336. defer deleteImages(name)
  2337. out, _, err := buildImageWithOut(name, "FROM busybox\nfoo bar", true)
  2338. if err != nil {
  2339. t.Fatal(err, out)
  2340. }
  2341. logDone("build - ignore invalid Dockerfile instruction")
  2342. }
  2343. func TestBuildEntrypointInheritance(t *testing.T) {
  2344. defer deleteImages("parent", "child")
  2345. if _, err := buildImage("parent", `
  2346. FROM busybox
  2347. ENTRYPOINT exit 130
  2348. `, true); err != nil {
  2349. t.Fatal(err)
  2350. }
  2351. status, _ := runCommand(exec.Command(dockerBinary, "run", "parent"))
  2352. if status != 130 {
  2353. t.Fatalf("expected exit code 130 but received %d", status)
  2354. }
  2355. if _, err := buildImage("child", `
  2356. FROM parent
  2357. ENTRYPOINT exit 5
  2358. `, true); err != nil {
  2359. t.Fatal(err)
  2360. }
  2361. status, _ = runCommand(exec.Command(dockerBinary, "run", "child"))
  2362. if status != 5 {
  2363. t.Fatal("expected exit code 5 but received %d", status)
  2364. }
  2365. logDone("build - clear entrypoint")
  2366. }
  2367. func TestBuildEntrypointInheritanceInspect(t *testing.T) {
  2368. var (
  2369. name = "testbuildepinherit"
  2370. name2 = "testbuildepinherit2"
  2371. expected = `["/bin/sh","-c","echo quux"]`
  2372. )
  2373. defer deleteImages(name, name2)
  2374. if _, err := buildImage(name, "FROM busybox\nENTRYPOINT /foo/bar", true); err != nil {
  2375. t.Fatal(err)
  2376. }
  2377. if _, err := buildImage(name2, fmt.Sprintf("FROM %s\nENTRYPOINT echo quux", name), true); err != nil {
  2378. t.Fatal(err)
  2379. }
  2380. res, err := inspectFieldJSON(name2, "Config.Entrypoint")
  2381. if err != nil {
  2382. t.Fatal(err, res)
  2383. }
  2384. if res != expected {
  2385. t.Fatalf("Expected value %s not in Config.Entrypoint: %s", expected, res)
  2386. }
  2387. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "-t", name2))
  2388. if err != nil {
  2389. t.Fatal(err, out)
  2390. }
  2391. expected = "quux"
  2392. if strings.TrimSpace(out) != expected {
  2393. t.Fatalf("Expected output is %s, got %s", expected, out)
  2394. }
  2395. logDone("build - entrypoint override inheritance properly")
  2396. }
  2397. func TestBuildRunShEntrypoint(t *testing.T) {
  2398. name := "testbuildentrypoint"
  2399. defer deleteImages(name)
  2400. _, err := buildImage(name,
  2401. `FROM busybox
  2402. ENTRYPOINT /bin/echo`,
  2403. true)
  2404. if err != nil {
  2405. t.Fatal(err)
  2406. }
  2407. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", name))
  2408. if err != nil {
  2409. t.Fatal(err, out)
  2410. }
  2411. logDone("build - entrypoint with /bin/echo running successfully")
  2412. }
  2413. func TestBuildExoticShellInterpolation(t *testing.T) {
  2414. name := "testbuildexoticshellinterpolation"
  2415. defer deleteImages(name)
  2416. _, err := buildImage(name, `
  2417. FROM busybox
  2418. ENV SOME_VAR a.b.c
  2419. RUN [ "$SOME_VAR" = 'a.b.c' ]
  2420. RUN [ "${SOME_VAR}" = 'a.b.c' ]
  2421. RUN [ "${SOME_VAR%.*}" = 'a.b' ]
  2422. RUN [ "${SOME_VAR%%.*}" = 'a' ]
  2423. RUN [ "${SOME_VAR#*.}" = 'b.c' ]
  2424. RUN [ "${SOME_VAR##*.}" = 'c' ]
  2425. RUN [ "${SOME_VAR/c/d}" = 'a.b.d' ]
  2426. RUN [ "${#SOME_VAR}" = '5' ]
  2427. RUN [ "${SOME_UNSET_VAR:-$SOME_VAR}" = 'a.b.c' ]
  2428. RUN [ "${SOME_VAR:+Version: ${SOME_VAR}}" = 'Version: a.b.c' ]
  2429. RUN [ "${SOME_UNSET_VAR:+${SOME_VAR}}" = '' ]
  2430. RUN [ "${SOME_UNSET_VAR:-${SOME_VAR:-d.e.f}}" = 'a.b.c' ]
  2431. `, false)
  2432. if err != nil {
  2433. t.Fatal(err)
  2434. }
  2435. logDone("build - exotic shell interpolation")
  2436. }
  2437. func TestBuildVerifySingleQuoteFails(t *testing.T) {
  2438. // This testcase is supposed to generate an error because the
  2439. // JSON array we're passing in on the CMD uses single quotes instead
  2440. // of double quotes (per the JSON spec). This means we interpret it
  2441. // as a "string" insead of "JSON array" and pass it on to "sh -c" and
  2442. // it should barf on it.
  2443. name := "testbuildsinglequotefails"
  2444. defer deleteImages(name)
  2445. _, err := buildImage(name,
  2446. `FROM busybox
  2447. CMD [ '/bin/sh', '-c', 'echo hi' ]`,
  2448. true)
  2449. _, _, err = runCommandWithOutput(exec.Command(dockerBinary, "run", name))
  2450. if err == nil {
  2451. t.Fatal("The image was not supposed to be able to run")
  2452. }
  2453. logDone("build - verify single quotes fail")
  2454. }
  2455. func TestBuildVerboseOut(t *testing.T) {
  2456. name := "testbuildverboseout"
  2457. defer deleteImages(name)
  2458. _, out, err := buildImageWithOut(name,
  2459. `FROM busybox
  2460. RUN echo 123`,
  2461. false)
  2462. if err != nil {
  2463. t.Fatal(err)
  2464. }
  2465. if !strings.Contains(out, "\n123\n") {
  2466. t.Fatalf("Output should contain %q: %q", "123", out)
  2467. }
  2468. logDone("build - verbose output from commands")
  2469. }