docker_cli_build_test.go 139 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198219922002201220222032204220522062207220822092210221122122213221422152216221722182219222022212222222322242225222622272228222922302231223222332234223522362237223822392240224122422243224422452246224722482249225022512252225322542255225622572258225922602261226222632264226522662267226822692270227122722273227422752276227722782279228022812282228322842285228622872288228922902291229222932294229522962297229822992300230123022303230423052306230723082309231023112312231323142315231623172318231923202321232223232324232523262327232823292330233123322333233423352336233723382339234023412342234323442345234623472348234923502351235223532354235523562357235823592360236123622363236423652366236723682369237023712372237323742375237623772378237923802381238223832384238523862387238823892390239123922393239423952396239723982399240024012402240324042405240624072408240924102411241224132414241524162417241824192420242124222423242424252426242724282429243024312432243324342435243624372438243924402441244224432444244524462447244824492450245124522453245424552456245724582459246024612462246324642465246624672468246924702471247224732474247524762477247824792480248124822483248424852486248724882489249024912492249324942495249624972498249925002501250225032504250525062507250825092510251125122513251425152516251725182519252025212522252325242525252625272528252925302531253225332534253525362537253825392540254125422543254425452546254725482549255025512552255325542555255625572558255925602561256225632564256525662567256825692570257125722573257425752576257725782579258025812582258325842585258625872588258925902591259225932594259525962597259825992600260126022603260426052606260726082609261026112612261326142615261626172618261926202621262226232624262526262627262826292630263126322633263426352636263726382639264026412642264326442645264626472648264926502651265226532654265526562657265826592660266126622663266426652666266726682669267026712672267326742675267626772678267926802681268226832684268526862687268826892690269126922693269426952696269726982699270027012702270327042705270627072708270927102711271227132714271527162717271827192720272127222723272427252726272727282729273027312732273327342735273627372738273927402741274227432744274527462747274827492750275127522753275427552756275727582759276027612762276327642765276627672768276927702771277227732774277527762777277827792780278127822783278427852786278727882789279027912792279327942795279627972798279928002801280228032804280528062807280828092810281128122813281428152816281728182819282028212822282328242825282628272828282928302831283228332834283528362837283828392840284128422843284428452846284728482849285028512852285328542855285628572858285928602861286228632864286528662867286828692870287128722873287428752876287728782879288028812882288328842885288628872888288928902891289228932894289528962897289828992900290129022903290429052906290729082909291029112912291329142915291629172918291929202921292229232924292529262927292829292930293129322933293429352936293729382939294029412942294329442945294629472948294929502951295229532954295529562957295829592960296129622963296429652966296729682969297029712972297329742975297629772978297929802981298229832984298529862987298829892990299129922993299429952996299729982999300030013002300330043005300630073008300930103011301230133014301530163017301830193020302130223023302430253026302730283029303030313032303330343035303630373038303930403041304230433044304530463047304830493050305130523053305430553056305730583059306030613062306330643065306630673068306930703071307230733074307530763077307830793080308130823083308430853086308730883089309030913092309330943095309630973098309931003101310231033104310531063107310831093110311131123113311431153116311731183119312031213122312331243125312631273128312931303131313231333134313531363137313831393140314131423143314431453146314731483149315031513152315331543155315631573158315931603161316231633164316531663167316831693170317131723173317431753176317731783179318031813182318331843185318631873188318931903191319231933194319531963197319831993200320132023203320432053206320732083209321032113212321332143215321632173218321932203221322232233224322532263227322832293230323132323233323432353236323732383239324032413242324332443245324632473248324932503251325232533254325532563257325832593260326132623263326432653266326732683269327032713272327332743275327632773278327932803281328232833284328532863287328832893290329132923293329432953296329732983299330033013302330333043305330633073308330933103311331233133314331533163317331833193320332133223323332433253326332733283329333033313332333333343335333633373338333933403341334233433344334533463347334833493350335133523353335433553356335733583359336033613362336333643365336633673368336933703371337233733374337533763377337833793380338133823383338433853386338733883389339033913392339333943395339633973398339934003401340234033404340534063407340834093410341134123413341434153416341734183419342034213422342334243425342634273428342934303431343234333434343534363437343834393440344134423443344434453446344734483449345034513452345334543455345634573458345934603461346234633464346534663467346834693470347134723473347434753476347734783479348034813482348334843485348634873488348934903491349234933494349534963497349834993500350135023503350435053506350735083509351035113512351335143515351635173518351935203521352235233524352535263527352835293530353135323533353435353536353735383539354035413542354335443545354635473548354935503551355235533554355535563557355835593560356135623563356435653566356735683569357035713572357335743575357635773578357935803581358235833584358535863587358835893590359135923593359435953596359735983599360036013602360336043605360636073608360936103611361236133614361536163617361836193620362136223623362436253626362736283629363036313632363336343635363636373638363936403641364236433644364536463647364836493650365136523653365436553656365736583659366036613662366336643665366636673668366936703671367236733674367536763677367836793680368136823683368436853686368736883689369036913692369336943695369636973698369937003701370237033704370537063707370837093710371137123713371437153716371737183719372037213722372337243725372637273728372937303731373237333734373537363737373837393740374137423743374437453746374737483749375037513752375337543755375637573758375937603761376237633764376537663767376837693770377137723773377437753776377737783779378037813782378337843785378637873788378937903791379237933794379537963797379837993800380138023803380438053806380738083809381038113812381338143815381638173818381938203821382238233824382538263827382838293830383138323833383438353836383738383839384038413842384338443845384638473848384938503851385238533854385538563857385838593860386138623863386438653866386738683869387038713872387338743875387638773878387938803881388238833884388538863887388838893890389138923893389438953896389738983899390039013902390339043905390639073908390939103911391239133914391539163917391839193920392139223923392439253926392739283929393039313932393339343935393639373938393939403941394239433944394539463947394839493950395139523953395439553956395739583959396039613962396339643965396639673968396939703971397239733974397539763977397839793980398139823983398439853986398739883989399039913992399339943995399639973998399940004001400240034004400540064007400840094010401140124013401440154016401740184019402040214022402340244025402640274028402940304031403240334034403540364037403840394040404140424043404440454046404740484049405040514052405340544055405640574058405940604061406240634064406540664067406840694070407140724073407440754076407740784079408040814082408340844085408640874088408940904091409240934094409540964097409840994100410141024103410441054106410741084109411041114112411341144115411641174118411941204121412241234124412541264127412841294130413141324133413441354136413741384139414041414142414341444145414641474148414941504151415241534154415541564157415841594160416141624163416441654166416741684169417041714172417341744175417641774178417941804181418241834184418541864187418841894190419141924193419441954196419741984199420042014202420342044205420642074208420942104211421242134214421542164217421842194220422142224223422442254226422742284229423042314232423342344235423642374238423942404241424242434244424542464247424842494250425142524253425442554256425742584259426042614262426342644265426642674268426942704271427242734274427542764277427842794280428142824283428442854286428742884289429042914292429342944295429642974298429943004301430243034304430543064307430843094310431143124313431443154316431743184319432043214322432343244325432643274328432943304331433243334334433543364337433843394340434143424343434443454346434743484349435043514352435343544355435643574358435943604361436243634364436543664367436843694370437143724373437443754376437743784379438043814382438343844385438643874388438943904391439243934394439543964397439843994400440144024403440444054406440744084409441044114412441344144415441644174418441944204421442244234424442544264427442844294430443144324433443444354436443744384439444044414442444344444445444644474448444944504451445244534454445544564457445844594460446144624463446444654466446744684469447044714472447344744475447644774478447944804481448244834484448544864487448844894490449144924493449444954496449744984499450045014502450345044505450645074508450945104511451245134514451545164517451845194520452145224523452445254526452745284529453045314532453345344535453645374538453945404541454245434544454545464547454845494550455145524553455445554556455745584559456045614562456345644565456645674568456945704571457245734574457545764577457845794580458145824583458445854586458745884589459045914592459345944595459645974598459946004601460246034604460546064607460846094610461146124613461446154616461746184619462046214622462346244625462646274628462946304631463246334634463546364637463846394640464146424643464446454646464746484649465046514652465346544655465646574658465946604661466246634664466546664667466846694670467146724673467446754676467746784679468046814682468346844685468646874688468946904691469246934694469546964697469846994700470147024703470447054706470747084709471047114712471347144715471647174718471947204721472247234724472547264727472847294730473147324733473447354736473747384739474047414742474347444745474647474748474947504751475247534754475547564757475847594760476147624763476447654766476747684769477047714772477347744775477647774778477947804781478247834784478547864787478847894790479147924793479447954796479747984799480048014802480348044805480648074808480948104811481248134814481548164817481848194820482148224823482448254826482748284829483048314832483348344835483648374838483948404841484248434844484548464847484848494850485148524853485448554856485748584859486048614862486348644865486648674868486948704871487248734874487548764877487848794880488148824883488448854886488748884889489048914892489348944895489648974898489949004901490249034904490549064907490849094910491149124913491449154916491749184919492049214922492349244925492649274928492949304931493249334934493549364937493849394940494149424943494449454946494749484949495049514952495349544955495649574958495949604961496249634964496549664967496849694970497149724973497449754976497749784979498049814982498349844985498649874988498949904991499249934994499549964997499849995000500150025003500450055006500750085009501050115012501350145015501650175018501950205021502250235024502550265027502850295030503150325033503450355036503750385039504050415042504350445045504650475048504950505051505250535054505550565057505850595060506150625063506450655066506750685069507050715072507350745075507650775078507950805081508250835084508550865087508850895090509150925093509450955096509750985099510051015102510351045105510651075108510951105111511251135114511551165117511851195120512151225123512451255126512751285129513051315132513351345135513651375138513951405141514251435144514551465147514851495150515151525153515451555156515751585159516051615162516351645165516651675168516951705171517251735174517551765177517851795180518151825183518451855186518751885189519051915192519351945195519651975198519952005201520252035204520552065207520852095210521152125213521452155216521752185219522052215222522352245225522652275228522952305231523252335234523552365237523852395240524152425243524452455246524752485249525052515252525352545255525652575258525952605261526252635264526552665267526852695270527152725273527452755276527752785279528052815282528352845285528652875288528952905291529252935294529552965297529852995300530153025303530453055306530753085309531053115312531353145315531653175318531953205321532253235324532553265327532853295330533153325333533453355336533753385339534053415342534353445345534653475348534953505351535253535354535553565357535853595360536153625363536453655366536753685369537053715372537353745375537653775378537953805381538253835384538553865387538853895390539153925393539453955396539753985399540054015402540354045405540654075408540954105411541254135414541554165417541854195420542154225423542454255426542754285429543054315432543354345435543654375438543954405441544254435444544554465447544854495450
  1. package main
  2. import (
  3. "archive/tar"
  4. "bytes"
  5. "encoding/json"
  6. "fmt"
  7. "io/ioutil"
  8. "os"
  9. "os/exec"
  10. "path/filepath"
  11. "reflect"
  12. "regexp"
  13. "runtime"
  14. "strconv"
  15. "strings"
  16. "testing"
  17. "text/template"
  18. "time"
  19. "github.com/docker/docker/builder/command"
  20. "github.com/docker/docker/pkg/archive"
  21. )
  22. func TestBuildJSONEmptyRun(t *testing.T) {
  23. name := "testbuildjsonemptyrun"
  24. defer deleteImages(name)
  25. _, err := buildImage(
  26. name,
  27. `
  28. FROM busybox
  29. RUN []
  30. `,
  31. true)
  32. if err != nil {
  33. t.Fatal("error when dealing with a RUN statement with empty JSON array")
  34. }
  35. logDone("build - RUN with an empty array should not panic")
  36. }
  37. func TestBuildEmptyWhitespace(t *testing.T) {
  38. name := "testbuildemptywhitespace"
  39. defer deleteImages(name)
  40. _, err := buildImage(
  41. name,
  42. `
  43. FROM busybox
  44. COPY
  45. quux \
  46. bar
  47. `,
  48. true)
  49. if err == nil {
  50. t.Fatal("no error when dealing with a COPY statement with no content on the same line")
  51. }
  52. logDone("build - statements with whitespace and no content should generate a parse error")
  53. }
  54. func TestBuildShCmdJSONEntrypoint(t *testing.T) {
  55. name := "testbuildshcmdjsonentrypoint"
  56. defer deleteImages(name)
  57. _, err := buildImage(
  58. name,
  59. `
  60. FROM busybox
  61. ENTRYPOINT ["/bin/echo"]
  62. CMD echo test
  63. `,
  64. true)
  65. if err != nil {
  66. t.Fatal(err)
  67. }
  68. out, _, err := runCommandWithOutput(
  69. exec.Command(
  70. dockerBinary,
  71. "run",
  72. "--rm",
  73. name))
  74. if err != nil {
  75. t.Fatal(err)
  76. }
  77. if strings.TrimSpace(out) != "/bin/sh -c echo test" {
  78. t.Fatal("CMD did not contain /bin/sh -c")
  79. }
  80. logDone("build - CMD should always contain /bin/sh -c when specified without JSON")
  81. }
  82. func TestBuildEnvironmentReplacementUser(t *testing.T) {
  83. name := "testbuildenvironmentreplacement"
  84. defer deleteImages(name)
  85. _, err := buildImage(name, `
  86. FROM scratch
  87. ENV user foo
  88. USER ${user}
  89. `, true)
  90. if err != nil {
  91. t.Fatal(err)
  92. }
  93. res, err := inspectFieldJSON(name, "Config.User")
  94. if err != nil {
  95. t.Fatal(err)
  96. }
  97. if res != `"foo"` {
  98. t.Fatal("User foo from environment not in Config.User on image")
  99. }
  100. logDone("build - user environment replacement")
  101. }
  102. func TestBuildEnvironmentReplacementVolume(t *testing.T) {
  103. name := "testbuildenvironmentreplacement"
  104. defer deleteImages(name)
  105. _, err := buildImage(name, `
  106. FROM scratch
  107. ENV volume /quux
  108. VOLUME ${volume}
  109. `, true)
  110. if err != nil {
  111. t.Fatal(err)
  112. }
  113. res, err := inspectFieldJSON(name, "Config.Volumes")
  114. if err != nil {
  115. t.Fatal(err)
  116. }
  117. var volumes map[string]interface{}
  118. if err := json.Unmarshal([]byte(res), &volumes); err != nil {
  119. t.Fatal(err)
  120. }
  121. if _, ok := volumes["/quux"]; !ok {
  122. t.Fatal("Volume /quux from environment not in Config.Volumes on image")
  123. }
  124. logDone("build - volume environment replacement")
  125. }
  126. func TestBuildEnvironmentReplacementExpose(t *testing.T) {
  127. name := "testbuildenvironmentreplacement"
  128. defer deleteImages(name)
  129. _, err := buildImage(name, `
  130. FROM scratch
  131. ENV port 80
  132. EXPOSE ${port}
  133. `, true)
  134. if err != nil {
  135. t.Fatal(err)
  136. }
  137. res, err := inspectFieldJSON(name, "Config.ExposedPorts")
  138. if err != nil {
  139. t.Fatal(err)
  140. }
  141. var exposedPorts map[string]interface{}
  142. if err := json.Unmarshal([]byte(res), &exposedPorts); err != nil {
  143. t.Fatal(err)
  144. }
  145. if _, ok := exposedPorts["80/tcp"]; !ok {
  146. t.Fatal("Exposed port 80 from environment not in Config.ExposedPorts on image")
  147. }
  148. logDone("build - expose environment replacement")
  149. }
  150. func TestBuildEnvironmentReplacementWorkdir(t *testing.T) {
  151. name := "testbuildenvironmentreplacement"
  152. defer deleteImages(name)
  153. _, err := buildImage(name, `
  154. FROM busybox
  155. ENV MYWORKDIR /work
  156. RUN mkdir ${MYWORKDIR}
  157. WORKDIR ${MYWORKDIR}
  158. `, true)
  159. if err != nil {
  160. t.Fatal(err)
  161. }
  162. logDone("build - workdir environment replacement")
  163. }
  164. func TestBuildEnvironmentReplacementAddCopy(t *testing.T) {
  165. name := "testbuildenvironmentreplacement"
  166. defer deleteImages(name)
  167. ctx, err := fakeContext(`
  168. FROM scratch
  169. ENV baz foo
  170. ENV quux bar
  171. ENV dot .
  172. ADD ${baz} ${dot}
  173. COPY ${quux} ${dot}
  174. `,
  175. map[string]string{
  176. "foo": "test1",
  177. "bar": "test2",
  178. })
  179. if err != nil {
  180. t.Fatal(err)
  181. }
  182. defer ctx.Close()
  183. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  184. t.Fatal(err)
  185. }
  186. logDone("build - add/copy environment replacement")
  187. }
  188. func TestBuildEnvironmentReplacementEnv(t *testing.T) {
  189. name := "testbuildenvironmentreplacement"
  190. defer deleteImages(name)
  191. _, err := buildImage(name,
  192. `
  193. FROM busybox
  194. ENV foo zzz
  195. ENV bar ${foo}
  196. ENV abc1='$foo'
  197. ENV env1=$foo env2=${foo} env3="$foo" env4="${foo}"
  198. RUN [ "$abc1" = '$foo' ] && (echo "$abc1" | grep -q foo)
  199. ENV abc2="\$foo"
  200. RUN [ "$abc2" = '$foo' ] && (echo "$abc2" | grep -q foo)
  201. ENV abc3 '$foo'
  202. RUN [ "$abc3" = '$foo' ] && (echo "$abc3" | grep -q foo)
  203. ENV abc4 "\$foo"
  204. RUN [ "$abc4" = '$foo' ] && (echo "$abc4" | grep -q foo)
  205. `, true)
  206. if err != nil {
  207. t.Fatal(err)
  208. }
  209. res, err := inspectFieldJSON(name, "Config.Env")
  210. if err != nil {
  211. t.Fatal(err)
  212. }
  213. envResult := []string{}
  214. if err = unmarshalJSON([]byte(res), &envResult); err != nil {
  215. t.Fatal(err)
  216. }
  217. found := false
  218. envCount := 0
  219. for _, env := range envResult {
  220. parts := strings.SplitN(env, "=", 2)
  221. if parts[0] == "bar" {
  222. found = true
  223. if parts[1] != "zzz" {
  224. t.Fatalf("Could not find replaced var for env `bar`: got %q instead of `zzz`", parts[1])
  225. }
  226. } else if strings.HasPrefix(parts[0], "env") {
  227. envCount++
  228. if parts[1] != "zzz" {
  229. t.Fatalf("%s should be 'foo' but instead its %q", parts[0], parts[1])
  230. }
  231. }
  232. }
  233. if !found {
  234. t.Fatal("Never found the `bar` env variable")
  235. }
  236. if envCount != 4 {
  237. t.Fatalf("Didn't find all env vars - only saw %d\n%s", envCount, envResult)
  238. }
  239. logDone("build - env environment replacement")
  240. }
  241. func TestBuildHandleEscapes(t *testing.T) {
  242. name := "testbuildhandleescapes"
  243. defer deleteImages(name)
  244. _, err := buildImage(name,
  245. `
  246. FROM scratch
  247. ENV FOO bar
  248. VOLUME ${FOO}
  249. `, true)
  250. if err != nil {
  251. t.Fatal(err)
  252. }
  253. var result map[string]map[string]struct{}
  254. res, err := inspectFieldJSON(name, "Config.Volumes")
  255. if err != nil {
  256. t.Fatal(err)
  257. }
  258. if err = unmarshalJSON([]byte(res), &result); err != nil {
  259. t.Fatal(err)
  260. }
  261. if _, ok := result["bar"]; !ok {
  262. t.Fatal("Could not find volume bar set from env foo in volumes table")
  263. }
  264. deleteImages(name)
  265. _, err = buildImage(name,
  266. `
  267. FROM scratch
  268. ENV FOO bar
  269. VOLUME \${FOO}
  270. `, true)
  271. if err != nil {
  272. t.Fatal(err)
  273. }
  274. res, err = inspectFieldJSON(name, "Config.Volumes")
  275. if err != nil {
  276. t.Fatal(err)
  277. }
  278. if err = unmarshalJSON([]byte(res), &result); err != nil {
  279. t.Fatal(err)
  280. }
  281. if _, ok := result["${FOO}"]; !ok {
  282. t.Fatal("Could not find volume ${FOO} set from env foo in volumes table")
  283. }
  284. deleteImages(name)
  285. // this test in particular provides *7* backslashes and expects 6 to come back.
  286. // Like above, the first escape is swallowed and the rest are treated as
  287. // literals, this one is just less obvious because of all the character noise.
  288. _, err = buildImage(name,
  289. `
  290. FROM scratch
  291. ENV FOO bar
  292. VOLUME \\\\\\\${FOO}
  293. `, true)
  294. if err != nil {
  295. t.Fatal(err)
  296. }
  297. res, err = inspectFieldJSON(name, "Config.Volumes")
  298. if err != nil {
  299. t.Fatal(err)
  300. }
  301. if err = unmarshalJSON([]byte(res), &result); err != nil {
  302. t.Fatal(err)
  303. }
  304. if _, ok := result[`\\\${FOO}`]; !ok {
  305. t.Fatal(`Could not find volume \\\${FOO} set from env foo in volumes table`, result)
  306. }
  307. logDone("build - handle escapes")
  308. }
  309. func TestBuildOnBuildLowercase(t *testing.T) {
  310. name := "testbuildonbuildlowercase"
  311. name2 := "testbuildonbuildlowercase2"
  312. defer deleteImages(name, name2)
  313. _, err := buildImage(name,
  314. `
  315. FROM busybox
  316. onbuild run echo quux
  317. `, true)
  318. if err != nil {
  319. t.Fatal(err)
  320. }
  321. _, out, err := buildImageWithOut(name2, fmt.Sprintf(`
  322. FROM %s
  323. `, name), true)
  324. if err != nil {
  325. t.Fatal(err)
  326. }
  327. if !strings.Contains(out, "quux") {
  328. t.Fatalf("Did not receive the expected echo text, got %s", out)
  329. }
  330. if strings.Contains(out, "ONBUILD ONBUILD") {
  331. t.Fatalf("Got an ONBUILD ONBUILD error with no error: got %s", out)
  332. }
  333. logDone("build - handle case-insensitive onbuild statement")
  334. }
  335. func TestBuildEnvEscapes(t *testing.T) {
  336. name := "testbuildenvescapes"
  337. defer deleteImages(name)
  338. defer deleteAllContainers()
  339. _, err := buildImage(name,
  340. `
  341. FROM busybox
  342. ENV TEST foo
  343. CMD echo \$
  344. `,
  345. true)
  346. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "-t", name))
  347. if err != nil {
  348. t.Fatal(err)
  349. }
  350. if strings.TrimSpace(out) != "$" {
  351. t.Fatalf("Env TEST was not overwritten with bar when foo was supplied to dockerfile: was %q", strings.TrimSpace(out))
  352. }
  353. logDone("build - env should handle \\$ properly")
  354. }
  355. func TestBuildEnvOverwrite(t *testing.T) {
  356. name := "testbuildenvoverwrite"
  357. defer deleteImages(name)
  358. defer deleteAllContainers()
  359. _, err := buildImage(name,
  360. `
  361. FROM busybox
  362. ENV TEST foo
  363. CMD echo ${TEST}
  364. `,
  365. true)
  366. if err != nil {
  367. t.Fatal(err)
  368. }
  369. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "-e", "TEST=bar", "-t", name))
  370. if err != nil {
  371. t.Fatal(err)
  372. }
  373. if strings.TrimSpace(out) != "bar" {
  374. t.Fatalf("Env TEST was not overwritten with bar when foo was supplied to dockerfile: was %q", strings.TrimSpace(out))
  375. }
  376. logDone("build - env should overwrite builder ENV during run")
  377. }
  378. func TestBuildOnBuildForbiddenMaintainerInSourceImage(t *testing.T) {
  379. name := "testbuildonbuildforbiddenmaintainerinsourceimage"
  380. defer deleteImages("onbuild")
  381. defer deleteImages(name)
  382. defer deleteAllContainers()
  383. createCmd := exec.Command(dockerBinary, "create", "busybox", "true")
  384. out, _, _, err := runCommandWithStdoutStderr(createCmd)
  385. if err != nil {
  386. t.Fatal(out, err)
  387. }
  388. cleanedContainerID := stripTrailingCharacters(out)
  389. commitCmd := exec.Command(dockerBinary, "commit", "--run", "{\"OnBuild\":[\"MAINTAINER docker.io\"]}", cleanedContainerID, "onbuild")
  390. if _, err := runCommand(commitCmd); err != nil {
  391. t.Fatal(err)
  392. }
  393. _, err = buildImage(name,
  394. `FROM onbuild`,
  395. true)
  396. if err != nil {
  397. if !strings.Contains(err.Error(), "maintainer isn't allowed as an ONBUILD trigger") {
  398. t.Fatalf("Wrong error %v, must be about MAINTAINER and ONBUILD in source image", err)
  399. }
  400. } else {
  401. t.Fatal("Error must not be nil")
  402. }
  403. logDone("build - onbuild forbidden maintainer in source image")
  404. }
  405. func TestBuildOnBuildForbiddenFromInSourceImage(t *testing.T) {
  406. name := "testbuildonbuildforbiddenfrominsourceimage"
  407. defer deleteImages("onbuild")
  408. defer deleteImages(name)
  409. defer deleteAllContainers()
  410. createCmd := exec.Command(dockerBinary, "create", "busybox", "true")
  411. out, _, _, err := runCommandWithStdoutStderr(createCmd)
  412. if err != nil {
  413. t.Fatal(out, err)
  414. }
  415. cleanedContainerID := stripTrailingCharacters(out)
  416. commitCmd := exec.Command(dockerBinary, "commit", "--run", "{\"OnBuild\":[\"FROM busybox\"]}", cleanedContainerID, "onbuild")
  417. if _, err := runCommand(commitCmd); err != nil {
  418. t.Fatal(err)
  419. }
  420. _, err = buildImage(name,
  421. `FROM onbuild`,
  422. true)
  423. if err != nil {
  424. if !strings.Contains(err.Error(), "from isn't allowed as an ONBUILD trigger") {
  425. t.Fatalf("Wrong error %v, must be about FROM and ONBUILD in source image", err)
  426. }
  427. } else {
  428. t.Fatal("Error must not be nil")
  429. }
  430. logDone("build - onbuild forbidden from in source image")
  431. }
  432. func TestBuildOnBuildForbiddenChainedInSourceImage(t *testing.T) {
  433. name := "testbuildonbuildforbiddenchainedinsourceimage"
  434. defer deleteImages("onbuild")
  435. defer deleteImages(name)
  436. defer deleteAllContainers()
  437. createCmd := exec.Command(dockerBinary, "create", "busybox", "true")
  438. out, _, _, err := runCommandWithStdoutStderr(createCmd)
  439. if err != nil {
  440. t.Fatal(out, err)
  441. }
  442. cleanedContainerID := stripTrailingCharacters(out)
  443. commitCmd := exec.Command(dockerBinary, "commit", "--run", "{\"OnBuild\":[\"ONBUILD RUN ls\"]}", cleanedContainerID, "onbuild")
  444. if _, err := runCommand(commitCmd); err != nil {
  445. t.Fatal(err)
  446. }
  447. _, err = buildImage(name,
  448. `FROM onbuild`,
  449. true)
  450. if err != nil {
  451. if !strings.Contains(err.Error(), "Chaining ONBUILD via `ONBUILD ONBUILD` isn't allowed") {
  452. t.Fatalf("Wrong error %v, must be about chaining ONBUILD in source image", err)
  453. }
  454. } else {
  455. t.Fatal("Error must not be nil")
  456. }
  457. logDone("build - onbuild forbidden chained in source image")
  458. }
  459. func TestBuildOnBuildCmdEntrypointJSON(t *testing.T) {
  460. name1 := "onbuildcmd"
  461. name2 := "onbuildgenerated"
  462. defer deleteImages(name2)
  463. defer deleteImages(name1)
  464. defer deleteAllContainers()
  465. _, err := buildImage(name1, `
  466. FROM busybox
  467. ONBUILD CMD ["hello world"]
  468. ONBUILD ENTRYPOINT ["echo"]
  469. ONBUILD RUN ["true"]`,
  470. false)
  471. if err != nil {
  472. t.Fatal(err)
  473. }
  474. _, err = buildImage(name2, fmt.Sprintf(`FROM %s`, name1), false)
  475. if err != nil {
  476. t.Fatal(err)
  477. }
  478. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "-t", name2))
  479. if err != nil {
  480. t.Fatal(err)
  481. }
  482. if !regexp.MustCompile(`(?m)^hello world`).MatchString(out) {
  483. t.Fatal("did not get echo output from onbuild", out)
  484. }
  485. logDone("build - onbuild with json entrypoint/cmd")
  486. }
  487. func TestBuildOnBuildEntrypointJSON(t *testing.T) {
  488. name1 := "onbuildcmd"
  489. name2 := "onbuildgenerated"
  490. defer deleteImages(name2)
  491. defer deleteImages(name1)
  492. defer deleteAllContainers()
  493. _, err := buildImage(name1, `
  494. FROM busybox
  495. ONBUILD ENTRYPOINT ["echo"]`,
  496. false)
  497. if err != nil {
  498. t.Fatal(err)
  499. }
  500. _, err = buildImage(name2, fmt.Sprintf("FROM %s\nCMD [\"hello world\"]\n", name1), false)
  501. if err != nil {
  502. t.Fatal(err)
  503. }
  504. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "-t", name2))
  505. if err != nil {
  506. t.Fatal(err)
  507. }
  508. if !regexp.MustCompile(`(?m)^hello world`).MatchString(out) {
  509. t.Fatal("got malformed output from onbuild", out)
  510. }
  511. logDone("build - onbuild with json entrypoint")
  512. }
  513. func TestBuildCacheADD(t *testing.T) {
  514. name := "testbuildtwoimageswithadd"
  515. defer deleteImages(name)
  516. server, err := fakeStorage(map[string]string{
  517. "robots.txt": "hello",
  518. "index.html": "world",
  519. })
  520. if err != nil {
  521. t.Fatal(err)
  522. }
  523. defer server.Close()
  524. if _, err := buildImage(name,
  525. fmt.Sprintf(`FROM scratch
  526. ADD %s/robots.txt /`, server.URL()),
  527. true); err != nil {
  528. t.Fatal(err)
  529. }
  530. if err != nil {
  531. t.Fatal(err)
  532. }
  533. deleteImages(name)
  534. _, out, err := buildImageWithOut(name,
  535. fmt.Sprintf(`FROM scratch
  536. ADD %s/index.html /`, server.URL()),
  537. true)
  538. if err != nil {
  539. t.Fatal(err)
  540. }
  541. if strings.Contains(out, "Using cache") {
  542. t.Fatal("2nd build used cache on ADD, it shouldn't")
  543. }
  544. logDone("build - build two images with remote ADD")
  545. }
  546. func TestBuildLastModified(t *testing.T) {
  547. name := "testbuildlastmodified"
  548. defer deleteImages(name)
  549. server, err := fakeStorage(map[string]string{
  550. "file": "hello",
  551. })
  552. if err != nil {
  553. t.Fatal(err)
  554. }
  555. defer server.Close()
  556. var out, out2 string
  557. dFmt := `FROM busybox
  558. ADD %s/file /
  559. RUN ls -le /file`
  560. dockerfile := fmt.Sprintf(dFmt, server.URL())
  561. if _, out, err = buildImageWithOut(name, dockerfile, false); err != nil {
  562. t.Fatal(err)
  563. }
  564. originMTime := regexp.MustCompile(`root.*/file.*\n`).FindString(out)
  565. // Make sure our regexp is correct
  566. if strings.Index(originMTime, "/file") < 0 {
  567. t.Fatalf("Missing ls info on 'file':\n%s", out)
  568. }
  569. // Build it again and make sure the mtime of the file didn't change.
  570. // Wait a few seconds to make sure the time changed enough to notice
  571. time.Sleep(2 * time.Second)
  572. if _, out2, err = buildImageWithOut(name, dockerfile, false); err != nil {
  573. t.Fatal(err)
  574. }
  575. newMTime := regexp.MustCompile(`root.*/file.*\n`).FindString(out2)
  576. if newMTime != originMTime {
  577. t.Fatalf("MTime changed:\nOrigin:%s\nNew:%s", originMTime, newMTime)
  578. }
  579. // Now 'touch' the file and make sure the timestamp DID change this time
  580. // Create a new fakeStorage instead of just using Add() to help windows
  581. server, err = fakeStorage(map[string]string{
  582. "file": "hello",
  583. })
  584. if err != nil {
  585. t.Fatal(err)
  586. }
  587. defer server.Close()
  588. dockerfile = fmt.Sprintf(dFmt, server.URL())
  589. if _, out2, err = buildImageWithOut(name, dockerfile, false); err != nil {
  590. t.Fatal(err)
  591. }
  592. newMTime = regexp.MustCompile(`root.*/file.*\n`).FindString(out2)
  593. if newMTime == originMTime {
  594. t.Fatalf("MTime didn't change:\nOrigin:%s\nNew:%s", originMTime, newMTime)
  595. }
  596. logDone("build - use Last-Modified header")
  597. }
  598. func TestBuildSixtySteps(t *testing.T) {
  599. name := "foobuildsixtysteps"
  600. defer deleteImages(name)
  601. ctx, err := fakeContext("FROM scratch\n"+strings.Repeat("ADD foo /\n", 60),
  602. map[string]string{
  603. "foo": "test1",
  604. })
  605. if err != nil {
  606. t.Fatal(err)
  607. }
  608. defer ctx.Close()
  609. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  610. t.Fatal(err)
  611. }
  612. logDone("build - build an image with sixty build steps")
  613. }
  614. func TestBuildAddSingleFileToRoot(t *testing.T) {
  615. name := "testaddimg"
  616. defer deleteImages(name)
  617. ctx, err := fakeContext(fmt.Sprintf(`FROM busybox
  618. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  619. RUN echo 'dockerio:x:1001:' >> /etc/group
  620. RUN touch /exists
  621. RUN chown dockerio.dockerio /exists
  622. ADD test_file /
  623. RUN [ $(ls -l /test_file | awk '{print $3":"$4}') = 'root:root' ]
  624. RUN [ $(ls -l /test_file | awk '{print $1}') = '%s' ]
  625. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`, expectedFileChmod),
  626. map[string]string{
  627. "test_file": "test1",
  628. })
  629. if err != nil {
  630. t.Fatal(err)
  631. }
  632. defer ctx.Close()
  633. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  634. t.Fatal(err)
  635. }
  636. logDone("build - add single file to root")
  637. }
  638. // Issue #3960: "ADD src ." hangs
  639. func TestBuildAddSingleFileToWorkdir(t *testing.T) {
  640. name := "testaddsinglefiletoworkdir"
  641. defer deleteImages(name)
  642. ctx, err := fakeContext(`FROM busybox
  643. ADD test_file .`,
  644. map[string]string{
  645. "test_file": "test1",
  646. })
  647. if err != nil {
  648. t.Fatal(err)
  649. }
  650. defer ctx.Close()
  651. done := make(chan struct{})
  652. go func() {
  653. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  654. t.Fatal(err)
  655. }
  656. close(done)
  657. }()
  658. select {
  659. case <-time.After(5 * time.Second):
  660. t.Fatal("Build with adding to workdir timed out")
  661. case <-done:
  662. }
  663. logDone("build - add single file to workdir")
  664. }
  665. func TestBuildAddSingleFileToExistDir(t *testing.T) {
  666. name := "testaddsinglefiletoexistdir"
  667. defer deleteImages(name)
  668. ctx, err := fakeContext(`FROM busybox
  669. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  670. RUN echo 'dockerio:x:1001:' >> /etc/group
  671. RUN mkdir /exists
  672. RUN touch /exists/exists_file
  673. RUN chown -R dockerio.dockerio /exists
  674. ADD test_file /exists/
  675. RUN [ $(ls -l / | grep exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]
  676. RUN [ $(ls -l /exists/test_file | awk '{print $3":"$4}') = 'root:root' ]
  677. RUN [ $(ls -l /exists/exists_file | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  678. map[string]string{
  679. "test_file": "test1",
  680. })
  681. if err != nil {
  682. t.Fatal(err)
  683. }
  684. defer ctx.Close()
  685. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  686. t.Fatal(err)
  687. }
  688. logDone("build - add single file to existing dir")
  689. }
  690. func TestBuildCopyAddMultipleFiles(t *testing.T) {
  691. server, err := fakeStorage(map[string]string{
  692. "robots.txt": "hello",
  693. })
  694. if err != nil {
  695. t.Fatal(err)
  696. }
  697. defer server.Close()
  698. name := "testcopymultiplefilestofile"
  699. defer deleteImages(name)
  700. ctx, err := fakeContext(fmt.Sprintf(`FROM busybox
  701. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  702. RUN echo 'dockerio:x:1001:' >> /etc/group
  703. RUN mkdir /exists
  704. RUN touch /exists/exists_file
  705. RUN chown -R dockerio.dockerio /exists
  706. COPY test_file1 test_file2 /exists/
  707. ADD test_file3 test_file4 %s/robots.txt /exists/
  708. RUN [ $(ls -l / | grep exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]
  709. RUN [ $(ls -l /exists/test_file1 | awk '{print $3":"$4}') = 'root:root' ]
  710. RUN [ $(ls -l /exists/test_file2 | awk '{print $3":"$4}') = 'root:root' ]
  711. RUN [ $(ls -l /exists/test_file3 | awk '{print $3":"$4}') = 'root:root' ]
  712. RUN [ $(ls -l /exists/test_file4 | awk '{print $3":"$4}') = 'root:root' ]
  713. RUN [ $(ls -l /exists/robots.txt | awk '{print $3":"$4}') = 'root:root' ]
  714. RUN [ $(ls -l /exists/exists_file | awk '{print $3":"$4}') = 'dockerio:dockerio' ]
  715. `, server.URL()),
  716. map[string]string{
  717. "test_file1": "test1",
  718. "test_file2": "test2",
  719. "test_file3": "test3",
  720. "test_file4": "test4",
  721. })
  722. defer ctx.Close()
  723. if err != nil {
  724. t.Fatal(err)
  725. }
  726. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  727. t.Fatal(err)
  728. }
  729. logDone("build - multiple file copy/add tests")
  730. }
  731. func TestBuildAddMultipleFilesToFile(t *testing.T) {
  732. name := "testaddmultiplefilestofile"
  733. defer deleteImages(name)
  734. ctx, err := fakeContext(`FROM scratch
  735. ADD file1.txt file2.txt test
  736. `,
  737. map[string]string{
  738. "file1.txt": "test1",
  739. "file2.txt": "test1",
  740. })
  741. defer ctx.Close()
  742. if err != nil {
  743. t.Fatal(err)
  744. }
  745. expected := "When using ADD with more than one source file, the destination must be a directory and end with a /"
  746. if _, err := buildImageFromContext(name, ctx, true); err == nil || !strings.Contains(err.Error(), expected) {
  747. t.Fatalf("Wrong error: (should contain %q) got:\n%v", expected, err)
  748. }
  749. logDone("build - multiple add files to file")
  750. }
  751. func TestBuildJSONAddMultipleFilesToFile(t *testing.T) {
  752. name := "testjsonaddmultiplefilestofile"
  753. defer deleteImages(name)
  754. ctx, err := fakeContext(`FROM scratch
  755. ADD ["file1.txt", "file2.txt", "test"]
  756. `,
  757. map[string]string{
  758. "file1.txt": "test1",
  759. "file2.txt": "test1",
  760. })
  761. defer ctx.Close()
  762. if err != nil {
  763. t.Fatal(err)
  764. }
  765. expected := "When using ADD with more than one source file, the destination must be a directory and end with a /"
  766. if _, err := buildImageFromContext(name, ctx, true); err == nil || !strings.Contains(err.Error(), expected) {
  767. t.Fatalf("Wrong error: (should contain %q) got:\n%v", expected, err)
  768. }
  769. logDone("build - multiple add files to file json syntax")
  770. }
  771. func TestBuildAddMultipleFilesToFileWild(t *testing.T) {
  772. name := "testaddmultiplefilestofilewild"
  773. defer deleteImages(name)
  774. ctx, err := fakeContext(`FROM scratch
  775. ADD file*.txt test
  776. `,
  777. map[string]string{
  778. "file1.txt": "test1",
  779. "file2.txt": "test1",
  780. })
  781. defer ctx.Close()
  782. if err != nil {
  783. t.Fatal(err)
  784. }
  785. expected := "When using ADD with more than one source file, the destination must be a directory and end with a /"
  786. if _, err := buildImageFromContext(name, ctx, true); err == nil || !strings.Contains(err.Error(), expected) {
  787. t.Fatalf("Wrong error: (should contain %q) got:\n%v", expected, err)
  788. }
  789. logDone("build - multiple add files to file wild")
  790. }
  791. func TestBuildJSONAddMultipleFilesToFileWild(t *testing.T) {
  792. name := "testjsonaddmultiplefilestofilewild"
  793. defer deleteImages(name)
  794. ctx, err := fakeContext(`FROM scratch
  795. ADD ["file*.txt", "test"]
  796. `,
  797. map[string]string{
  798. "file1.txt": "test1",
  799. "file2.txt": "test1",
  800. })
  801. defer ctx.Close()
  802. if err != nil {
  803. t.Fatal(err)
  804. }
  805. expected := "When using ADD with more than one source file, the destination must be a directory and end with a /"
  806. if _, err := buildImageFromContext(name, ctx, true); err == nil || !strings.Contains(err.Error(), expected) {
  807. t.Fatalf("Wrong error: (should contain %q) got:\n%v", expected, err)
  808. }
  809. logDone("build - multiple add files to file wild json syntax")
  810. }
  811. func TestBuildCopyMultipleFilesToFile(t *testing.T) {
  812. name := "testcopymultiplefilestofile"
  813. defer deleteImages(name)
  814. ctx, err := fakeContext(`FROM scratch
  815. COPY file1.txt file2.txt test
  816. `,
  817. map[string]string{
  818. "file1.txt": "test1",
  819. "file2.txt": "test1",
  820. })
  821. defer ctx.Close()
  822. if err != nil {
  823. t.Fatal(err)
  824. }
  825. expected := "When using COPY with more than one source file, the destination must be a directory and end with a /"
  826. if _, err := buildImageFromContext(name, ctx, true); err == nil || !strings.Contains(err.Error(), expected) {
  827. t.Fatalf("Wrong error: (should contain %q) got:\n%v", expected, err)
  828. }
  829. logDone("build - multiple copy files to file")
  830. }
  831. func TestBuildJSONCopyMultipleFilesToFile(t *testing.T) {
  832. name := "testjsoncopymultiplefilestofile"
  833. defer deleteImages(name)
  834. ctx, err := fakeContext(`FROM scratch
  835. COPY ["file1.txt", "file2.txt", "test"]
  836. `,
  837. map[string]string{
  838. "file1.txt": "test1",
  839. "file2.txt": "test1",
  840. })
  841. defer ctx.Close()
  842. if err != nil {
  843. t.Fatal(err)
  844. }
  845. expected := "When using COPY with more than one source file, the destination must be a directory and end with a /"
  846. if _, err := buildImageFromContext(name, ctx, true); err == nil || !strings.Contains(err.Error(), expected) {
  847. t.Fatalf("Wrong error: (should contain %q) got:\n%v", expected, err)
  848. }
  849. logDone("build - multiple copy files to file json syntax")
  850. }
  851. func TestBuildAddFileWithWhitespace(t *testing.T) {
  852. name := "testaddfilewithwhitespace"
  853. defer deleteImages(name)
  854. ctx, err := fakeContext(`FROM busybox
  855. RUN mkdir "/test dir"
  856. RUN mkdir "/test_dir"
  857. ADD [ "test file1", "/test_file1" ]
  858. ADD [ "test_file2", "/test file2" ]
  859. ADD [ "test file3", "/test file3" ]
  860. ADD [ "test dir/test_file4", "/test_dir/test_file4" ]
  861. ADD [ "test_dir/test_file5", "/test dir/test_file5" ]
  862. ADD [ "test dir/test_file6", "/test dir/test_file6" ]
  863. RUN [ $(cat "/test_file1") = 'test1' ]
  864. RUN [ $(cat "/test file2") = 'test2' ]
  865. RUN [ $(cat "/test file3") = 'test3' ]
  866. RUN [ $(cat "/test_dir/test_file4") = 'test4' ]
  867. RUN [ $(cat "/test dir/test_file5") = 'test5' ]
  868. RUN [ $(cat "/test dir/test_file6") = 'test6' ]`,
  869. map[string]string{
  870. "test file1": "test1",
  871. "test_file2": "test2",
  872. "test file3": "test3",
  873. "test dir/test_file4": "test4",
  874. "test_dir/test_file5": "test5",
  875. "test dir/test_file6": "test6",
  876. })
  877. defer ctx.Close()
  878. if err != nil {
  879. t.Fatal(err)
  880. }
  881. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  882. t.Fatal(err)
  883. }
  884. logDone("build - add file with whitespace")
  885. }
  886. func TestBuildCopyFileWithWhitespace(t *testing.T) {
  887. name := "testcopyfilewithwhitespace"
  888. defer deleteImages(name)
  889. ctx, err := fakeContext(`FROM busybox
  890. RUN mkdir "/test dir"
  891. RUN mkdir "/test_dir"
  892. COPY [ "test file1", "/test_file1" ]
  893. COPY [ "test_file2", "/test file2" ]
  894. COPY [ "test file3", "/test file3" ]
  895. COPY [ "test dir/test_file4", "/test_dir/test_file4" ]
  896. COPY [ "test_dir/test_file5", "/test dir/test_file5" ]
  897. COPY [ "test dir/test_file6", "/test dir/test_file6" ]
  898. RUN [ $(cat "/test_file1") = 'test1' ]
  899. RUN [ $(cat "/test file2") = 'test2' ]
  900. RUN [ $(cat "/test file3") = 'test3' ]
  901. RUN [ $(cat "/test_dir/test_file4") = 'test4' ]
  902. RUN [ $(cat "/test dir/test_file5") = 'test5' ]
  903. RUN [ $(cat "/test dir/test_file6") = 'test6' ]`,
  904. map[string]string{
  905. "test file1": "test1",
  906. "test_file2": "test2",
  907. "test file3": "test3",
  908. "test dir/test_file4": "test4",
  909. "test_dir/test_file5": "test5",
  910. "test dir/test_file6": "test6",
  911. })
  912. defer ctx.Close()
  913. if err != nil {
  914. t.Fatal(err)
  915. }
  916. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  917. t.Fatal(err)
  918. }
  919. logDone("build - copy file with whitespace")
  920. }
  921. func TestBuildAddMultipleFilesToFileWithWhitespace(t *testing.T) {
  922. name := "testaddmultiplefilestofilewithwhitespace"
  923. defer deleteImages(name)
  924. ctx, err := fakeContext(`FROM busybox
  925. ADD [ "test file1", "test file2", "test" ]
  926. `,
  927. map[string]string{
  928. "test file1": "test1",
  929. "test file2": "test2",
  930. })
  931. defer ctx.Close()
  932. if err != nil {
  933. t.Fatal(err)
  934. }
  935. expected := "When using ADD with more than one source file, the destination must be a directory and end with a /"
  936. if _, err := buildImageFromContext(name, ctx, true); err == nil || !strings.Contains(err.Error(), expected) {
  937. t.Fatalf("Wrong error: (should contain %q) got:\n%v", expected, err)
  938. }
  939. logDone("build - multiple add files to file with whitespace")
  940. }
  941. func TestBuildCopyMultipleFilesToFileWithWhitespace(t *testing.T) {
  942. name := "testcopymultiplefilestofilewithwhitespace"
  943. defer deleteImages(name)
  944. ctx, err := fakeContext(`FROM busybox
  945. COPY [ "test file1", "test file2", "test" ]
  946. `,
  947. map[string]string{
  948. "test file1": "test1",
  949. "test file2": "test2",
  950. })
  951. defer ctx.Close()
  952. if err != nil {
  953. t.Fatal(err)
  954. }
  955. expected := "When using COPY with more than one source file, the destination must be a directory and end with a /"
  956. if _, err := buildImageFromContext(name, ctx, true); err == nil || !strings.Contains(err.Error(), expected) {
  957. t.Fatalf("Wrong error: (should contain %q) got:\n%v", expected, err)
  958. }
  959. logDone("build - multiple copy files to file with whitespace")
  960. }
  961. func TestBuildCopyWildcard(t *testing.T) {
  962. name := "testcopywildcard"
  963. defer deleteImages(name)
  964. server, err := fakeStorage(map[string]string{
  965. "robots.txt": "hello",
  966. "index.html": "world",
  967. })
  968. if err != nil {
  969. t.Fatal(err)
  970. }
  971. defer server.Close()
  972. ctx, err := fakeContext(fmt.Sprintf(`FROM busybox
  973. COPY file*.txt /tmp/
  974. RUN ls /tmp/file1.txt /tmp/file2.txt
  975. RUN mkdir /tmp1
  976. COPY dir* /tmp1/
  977. RUN ls /tmp1/dirt /tmp1/nested_file /tmp1/nested_dir/nest_nest_file
  978. RUN mkdir /tmp2
  979. ADD dir/*dir %s/robots.txt /tmp2/
  980. RUN ls /tmp2/nest_nest_file /tmp2/robots.txt
  981. `, server.URL()),
  982. map[string]string{
  983. "file1.txt": "test1",
  984. "file2.txt": "test2",
  985. "dir/nested_file": "nested file",
  986. "dir/nested_dir/nest_nest_file": "2 times nested",
  987. "dirt": "dirty",
  988. })
  989. defer ctx.Close()
  990. if err != nil {
  991. t.Fatal(err)
  992. }
  993. id1, err := buildImageFromContext(name, ctx, true)
  994. if err != nil {
  995. t.Fatal(err)
  996. }
  997. // Now make sure we use a cache the 2nd time
  998. id2, err := buildImageFromContext(name, ctx, true)
  999. if err != nil {
  1000. t.Fatal(err)
  1001. }
  1002. if id1 != id2 {
  1003. t.Fatal("didn't use the cache")
  1004. }
  1005. logDone("build - copy wild card")
  1006. }
  1007. func TestBuildCopyWildcardNoFind(t *testing.T) {
  1008. name := "testcopywildcardnofind"
  1009. defer deleteImages(name)
  1010. ctx, err := fakeContext(`FROM busybox
  1011. COPY file*.txt /tmp/
  1012. `, nil)
  1013. defer ctx.Close()
  1014. if err != nil {
  1015. t.Fatal(err)
  1016. }
  1017. _, err = buildImageFromContext(name, ctx, true)
  1018. if err == nil {
  1019. t.Fatal("should have failed to find a file")
  1020. }
  1021. if !strings.Contains(err.Error(), "No source files were specified") {
  1022. t.Fatalf("Wrong error %v, must be about no source files", err)
  1023. }
  1024. logDone("build - copy wild card no find")
  1025. }
  1026. func TestBuildCopyWildcardCache(t *testing.T) {
  1027. name := "testcopywildcardcache"
  1028. defer deleteImages(name)
  1029. ctx, err := fakeContext(`FROM busybox
  1030. COPY file1.txt /tmp/`,
  1031. map[string]string{
  1032. "file1.txt": "test1",
  1033. })
  1034. defer ctx.Close()
  1035. if err != nil {
  1036. t.Fatal(err)
  1037. }
  1038. id1, err := buildImageFromContext(name, ctx, true)
  1039. if err != nil {
  1040. t.Fatal(err)
  1041. }
  1042. // Now make sure we use a cache the 2nd time even with wild cards.
  1043. // Use the same context so the file is the same and the checksum will match
  1044. ctx.Add("Dockerfile", `FROM busybox
  1045. COPY file*.txt /tmp/`)
  1046. id2, err := buildImageFromContext(name, ctx, true)
  1047. if err != nil {
  1048. t.Fatal(err)
  1049. }
  1050. if id1 != id2 {
  1051. t.Fatal("didn't use the cache")
  1052. }
  1053. logDone("build - copy wild card cache")
  1054. }
  1055. func TestBuildAddSingleFileToNonExistingDir(t *testing.T) {
  1056. name := "testaddsinglefiletononexistingdir"
  1057. defer deleteImages(name)
  1058. ctx, err := fakeContext(`FROM busybox
  1059. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  1060. RUN echo 'dockerio:x:1001:' >> /etc/group
  1061. RUN touch /exists
  1062. RUN chown dockerio.dockerio /exists
  1063. ADD test_file /test_dir/
  1064. RUN [ $(ls -l / | grep test_dir | awk '{print $3":"$4}') = 'root:root' ]
  1065. RUN [ $(ls -l /test_dir/test_file | awk '{print $3":"$4}') = 'root:root' ]
  1066. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  1067. map[string]string{
  1068. "test_file": "test1",
  1069. })
  1070. if err != nil {
  1071. t.Fatal(err)
  1072. }
  1073. defer ctx.Close()
  1074. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1075. t.Fatal(err)
  1076. }
  1077. logDone("build - add single file to non-existing dir")
  1078. }
  1079. func TestBuildAddDirContentToRoot(t *testing.T) {
  1080. name := "testadddircontenttoroot"
  1081. defer deleteImages(name)
  1082. ctx, err := fakeContext(`FROM busybox
  1083. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  1084. RUN echo 'dockerio:x:1001:' >> /etc/group
  1085. RUN touch /exists
  1086. RUN chown dockerio.dockerio exists
  1087. ADD test_dir /
  1088. RUN [ $(ls -l /test_file | awk '{print $3":"$4}') = 'root:root' ]
  1089. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  1090. map[string]string{
  1091. "test_dir/test_file": "test1",
  1092. })
  1093. if err != nil {
  1094. t.Fatal(err)
  1095. }
  1096. defer ctx.Close()
  1097. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1098. t.Fatal(err)
  1099. }
  1100. logDone("build - add directory contents to root")
  1101. }
  1102. func TestBuildAddDirContentToExistingDir(t *testing.T) {
  1103. name := "testadddircontenttoexistingdir"
  1104. defer deleteImages(name)
  1105. ctx, err := fakeContext(`FROM busybox
  1106. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  1107. RUN echo 'dockerio:x:1001:' >> /etc/group
  1108. RUN mkdir /exists
  1109. RUN touch /exists/exists_file
  1110. RUN chown -R dockerio.dockerio /exists
  1111. ADD test_dir/ /exists/
  1112. RUN [ $(ls -l / | grep exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]
  1113. RUN [ $(ls -l /exists/exists_file | awk '{print $3":"$4}') = 'dockerio:dockerio' ]
  1114. RUN [ $(ls -l /exists/test_file | awk '{print $3":"$4}') = 'root:root' ]`,
  1115. map[string]string{
  1116. "test_dir/test_file": "test1",
  1117. })
  1118. if err != nil {
  1119. t.Fatal(err)
  1120. }
  1121. defer ctx.Close()
  1122. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1123. t.Fatal(err)
  1124. }
  1125. logDone("build - add directory contents to existing dir")
  1126. }
  1127. func TestBuildAddWholeDirToRoot(t *testing.T) {
  1128. name := "testaddwholedirtoroot"
  1129. defer deleteImages(name)
  1130. ctx, err := fakeContext(fmt.Sprintf(`FROM busybox
  1131. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  1132. RUN echo 'dockerio:x:1001:' >> /etc/group
  1133. RUN touch /exists
  1134. RUN chown dockerio.dockerio exists
  1135. ADD test_dir /test_dir
  1136. RUN [ $(ls -l / | grep test_dir | awk '{print $3":"$4}') = 'root:root' ]
  1137. RUN [ $(ls -l / | grep test_dir | awk '{print $1}') = 'drwxr-xr-x' ]
  1138. RUN [ $(ls -l /test_dir/test_file | awk '{print $3":"$4}') = 'root:root' ]
  1139. RUN [ $(ls -l /test_dir/test_file | awk '{print $1}') = '%s' ]
  1140. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`, expectedFileChmod),
  1141. map[string]string{
  1142. "test_dir/test_file": "test1",
  1143. })
  1144. if err != nil {
  1145. t.Fatal(err)
  1146. }
  1147. defer ctx.Close()
  1148. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1149. t.Fatal(err)
  1150. }
  1151. logDone("build - add whole directory to root")
  1152. }
  1153. // Testing #5941
  1154. func TestBuildAddEtcToRoot(t *testing.T) {
  1155. name := "testaddetctoroot"
  1156. defer deleteImages(name)
  1157. ctx, err := fakeContext(`FROM scratch
  1158. ADD . /`,
  1159. map[string]string{
  1160. "etc/test_file": "test1",
  1161. })
  1162. if err != nil {
  1163. t.Fatal(err)
  1164. }
  1165. defer ctx.Close()
  1166. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1167. t.Fatal(err)
  1168. }
  1169. logDone("build - add etc directory to root")
  1170. }
  1171. // Testing #9401
  1172. func TestBuildAddPreservesFilesSpecialBits(t *testing.T) {
  1173. name := "testaddpreservesfilesspecialbits"
  1174. defer deleteImages(name)
  1175. ctx, err := fakeContext(`FROM busybox
  1176. ADD suidbin /usr/bin/suidbin
  1177. RUN chmod 4755 /usr/bin/suidbin
  1178. RUN [ $(ls -l /usr/bin/suidbin | awk '{print $1}') = '-rwsr-xr-x' ]
  1179. ADD ./data/ /
  1180. RUN [ $(ls -l /usr/bin/suidbin | awk '{print $1}') = '-rwsr-xr-x' ]`,
  1181. map[string]string{
  1182. "suidbin": "suidbin",
  1183. "/data/usr/test_file": "test1",
  1184. })
  1185. if err != nil {
  1186. t.Fatal(err)
  1187. }
  1188. defer ctx.Close()
  1189. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1190. t.Fatal(err)
  1191. }
  1192. logDone("build - add preserves files special bits")
  1193. }
  1194. func TestBuildCopySingleFileToRoot(t *testing.T) {
  1195. name := "testcopysinglefiletoroot"
  1196. defer deleteImages(name)
  1197. ctx, err := fakeContext(fmt.Sprintf(`FROM busybox
  1198. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  1199. RUN echo 'dockerio:x:1001:' >> /etc/group
  1200. RUN touch /exists
  1201. RUN chown dockerio.dockerio /exists
  1202. COPY test_file /
  1203. RUN [ $(ls -l /test_file | awk '{print $3":"$4}') = 'root:root' ]
  1204. RUN [ $(ls -l /test_file | awk '{print $1}') = '%s' ]
  1205. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`, expectedFileChmod),
  1206. map[string]string{
  1207. "test_file": "test1",
  1208. })
  1209. if err != nil {
  1210. t.Fatal(err)
  1211. }
  1212. defer ctx.Close()
  1213. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1214. t.Fatal(err)
  1215. }
  1216. logDone("build - copy single file to root")
  1217. }
  1218. // Issue #3960: "ADD src ." hangs - adapted for COPY
  1219. func TestBuildCopySingleFileToWorkdir(t *testing.T) {
  1220. name := "testcopysinglefiletoworkdir"
  1221. defer deleteImages(name)
  1222. ctx, err := fakeContext(`FROM busybox
  1223. COPY test_file .`,
  1224. map[string]string{
  1225. "test_file": "test1",
  1226. })
  1227. if err != nil {
  1228. t.Fatal(err)
  1229. }
  1230. defer ctx.Close()
  1231. done := make(chan struct{})
  1232. go func() {
  1233. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1234. t.Fatal(err)
  1235. }
  1236. close(done)
  1237. }()
  1238. select {
  1239. case <-time.After(5 * time.Second):
  1240. t.Fatal("Build with adding to workdir timed out")
  1241. case <-done:
  1242. }
  1243. logDone("build - copy single file to workdir")
  1244. }
  1245. func TestBuildCopySingleFileToExistDir(t *testing.T) {
  1246. name := "testcopysinglefiletoexistdir"
  1247. defer deleteImages(name)
  1248. ctx, err := fakeContext(`FROM busybox
  1249. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  1250. RUN echo 'dockerio:x:1001:' >> /etc/group
  1251. RUN mkdir /exists
  1252. RUN touch /exists/exists_file
  1253. RUN chown -R dockerio.dockerio /exists
  1254. COPY test_file /exists/
  1255. RUN [ $(ls -l / | grep exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]
  1256. RUN [ $(ls -l /exists/test_file | awk '{print $3":"$4}') = 'root:root' ]
  1257. RUN [ $(ls -l /exists/exists_file | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  1258. map[string]string{
  1259. "test_file": "test1",
  1260. })
  1261. if err != nil {
  1262. t.Fatal(err)
  1263. }
  1264. defer ctx.Close()
  1265. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1266. t.Fatal(err)
  1267. }
  1268. logDone("build - copy single file to existing dir")
  1269. }
  1270. func TestBuildCopySingleFileToNonExistDir(t *testing.T) {
  1271. name := "testcopysinglefiletononexistdir"
  1272. defer deleteImages(name)
  1273. ctx, err := fakeContext(`FROM busybox
  1274. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  1275. RUN echo 'dockerio:x:1001:' >> /etc/group
  1276. RUN touch /exists
  1277. RUN chown dockerio.dockerio /exists
  1278. COPY test_file /test_dir/
  1279. RUN [ $(ls -l / | grep test_dir | awk '{print $3":"$4}') = 'root:root' ]
  1280. RUN [ $(ls -l /test_dir/test_file | awk '{print $3":"$4}') = 'root:root' ]
  1281. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  1282. map[string]string{
  1283. "test_file": "test1",
  1284. })
  1285. if err != nil {
  1286. t.Fatal(err)
  1287. }
  1288. defer ctx.Close()
  1289. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1290. t.Fatal(err)
  1291. }
  1292. logDone("build - copy single file to non-existing dir")
  1293. }
  1294. func TestBuildCopyDirContentToRoot(t *testing.T) {
  1295. name := "testcopydircontenttoroot"
  1296. defer deleteImages(name)
  1297. ctx, err := fakeContext(`FROM busybox
  1298. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  1299. RUN echo 'dockerio:x:1001:' >> /etc/group
  1300. RUN touch /exists
  1301. RUN chown dockerio.dockerio exists
  1302. COPY test_dir /
  1303. RUN [ $(ls -l /test_file | awk '{print $3":"$4}') = 'root:root' ]
  1304. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  1305. map[string]string{
  1306. "test_dir/test_file": "test1",
  1307. })
  1308. if err != nil {
  1309. t.Fatal(err)
  1310. }
  1311. defer ctx.Close()
  1312. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1313. t.Fatal(err)
  1314. }
  1315. logDone("build - copy directory contents to root")
  1316. }
  1317. func TestBuildCopyDirContentToExistDir(t *testing.T) {
  1318. name := "testcopydircontenttoexistdir"
  1319. defer deleteImages(name)
  1320. ctx, err := fakeContext(`FROM busybox
  1321. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  1322. RUN echo 'dockerio:x:1001:' >> /etc/group
  1323. RUN mkdir /exists
  1324. RUN touch /exists/exists_file
  1325. RUN chown -R dockerio.dockerio /exists
  1326. COPY test_dir/ /exists/
  1327. RUN [ $(ls -l / | grep exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]
  1328. RUN [ $(ls -l /exists/exists_file | awk '{print $3":"$4}') = 'dockerio:dockerio' ]
  1329. RUN [ $(ls -l /exists/test_file | awk '{print $3":"$4}') = 'root:root' ]`,
  1330. map[string]string{
  1331. "test_dir/test_file": "test1",
  1332. })
  1333. if err != nil {
  1334. t.Fatal(err)
  1335. }
  1336. defer ctx.Close()
  1337. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1338. t.Fatal(err)
  1339. }
  1340. logDone("build - copy directory contents to existing dir")
  1341. }
  1342. func TestBuildCopyWholeDirToRoot(t *testing.T) {
  1343. name := "testcopywholedirtoroot"
  1344. defer deleteImages(name)
  1345. ctx, err := fakeContext(fmt.Sprintf(`FROM busybox
  1346. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  1347. RUN echo 'dockerio:x:1001:' >> /etc/group
  1348. RUN touch /exists
  1349. RUN chown dockerio.dockerio exists
  1350. COPY test_dir /test_dir
  1351. RUN [ $(ls -l / | grep test_dir | awk '{print $3":"$4}') = 'root:root' ]
  1352. RUN [ $(ls -l / | grep test_dir | awk '{print $1}') = 'drwxr-xr-x' ]
  1353. RUN [ $(ls -l /test_dir/test_file | awk '{print $3":"$4}') = 'root:root' ]
  1354. RUN [ $(ls -l /test_dir/test_file | awk '{print $1}') = '%s' ]
  1355. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`, expectedFileChmod),
  1356. map[string]string{
  1357. "test_dir/test_file": "test1",
  1358. })
  1359. if err != nil {
  1360. t.Fatal(err)
  1361. }
  1362. defer ctx.Close()
  1363. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1364. t.Fatal(err)
  1365. }
  1366. logDone("build - copy whole directory to root")
  1367. }
  1368. func TestBuildCopyEtcToRoot(t *testing.T) {
  1369. name := "testcopyetctoroot"
  1370. defer deleteImages(name)
  1371. ctx, err := fakeContext(`FROM scratch
  1372. COPY . /`,
  1373. map[string]string{
  1374. "etc/test_file": "test1",
  1375. })
  1376. if err != nil {
  1377. t.Fatal(err)
  1378. }
  1379. defer ctx.Close()
  1380. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1381. t.Fatal(err)
  1382. }
  1383. logDone("build - copy etc directory to root")
  1384. }
  1385. func TestBuildCopyDisallowRemote(t *testing.T) {
  1386. name := "testcopydisallowremote"
  1387. defer deleteImages(name)
  1388. _, out, err := buildImageWithOut(name, `FROM scratch
  1389. COPY https://index.docker.io/robots.txt /`,
  1390. true)
  1391. if err == nil || !strings.Contains(out, "Source can't be a URL for COPY") {
  1392. t.Fatalf("Error should be about disallowed remote source, got err: %s, out: %q", err, out)
  1393. }
  1394. logDone("build - copy - disallow copy from remote")
  1395. }
  1396. func TestBuildAddBadLinks(t *testing.T) {
  1397. const (
  1398. dockerfile = `
  1399. FROM scratch
  1400. ADD links.tar /
  1401. ADD foo.txt /symlink/
  1402. `
  1403. targetFile = "foo.txt"
  1404. )
  1405. var (
  1406. name = "test-link-absolute"
  1407. )
  1408. defer deleteImages(name)
  1409. ctx, err := fakeContext(dockerfile, nil)
  1410. if err != nil {
  1411. t.Fatal(err)
  1412. }
  1413. defer ctx.Close()
  1414. tempDir, err := ioutil.TempDir("", "test-link-absolute-temp-")
  1415. if err != nil {
  1416. t.Fatalf("failed to create temporary directory: %s", tempDir)
  1417. }
  1418. defer os.RemoveAll(tempDir)
  1419. var symlinkTarget string
  1420. if runtime.GOOS == "windows" {
  1421. var driveLetter string
  1422. if abs, err := filepath.Abs(tempDir); err != nil {
  1423. t.Fatal(err)
  1424. } else {
  1425. driveLetter = abs[:1]
  1426. }
  1427. tempDirWithoutDrive := tempDir[2:]
  1428. symlinkTarget = fmt.Sprintf(`%s:\..\..\..\..\..\..\..\..\..\..\..\..%s`, driveLetter, tempDirWithoutDrive)
  1429. } else {
  1430. symlinkTarget = fmt.Sprintf("/../../../../../../../../../../../..%s", tempDir)
  1431. }
  1432. tarPath := filepath.Join(ctx.Dir, "links.tar")
  1433. nonExistingFile := filepath.Join(tempDir, targetFile)
  1434. fooPath := filepath.Join(ctx.Dir, targetFile)
  1435. tarOut, err := os.Create(tarPath)
  1436. if err != nil {
  1437. t.Fatal(err)
  1438. }
  1439. tarWriter := tar.NewWriter(tarOut)
  1440. header := &tar.Header{
  1441. Name: "symlink",
  1442. Typeflag: tar.TypeSymlink,
  1443. Linkname: symlinkTarget,
  1444. Mode: 0755,
  1445. Uid: 0,
  1446. Gid: 0,
  1447. }
  1448. err = tarWriter.WriteHeader(header)
  1449. if err != nil {
  1450. t.Fatal(err)
  1451. }
  1452. tarWriter.Close()
  1453. tarOut.Close()
  1454. foo, err := os.Create(fooPath)
  1455. if err != nil {
  1456. t.Fatal(err)
  1457. }
  1458. defer foo.Close()
  1459. if _, err := foo.WriteString("test"); err != nil {
  1460. t.Fatal(err)
  1461. }
  1462. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1463. t.Fatal(err)
  1464. }
  1465. if _, err := os.Stat(nonExistingFile); err == nil || err != nil && !os.IsNotExist(err) {
  1466. t.Fatalf("%s shouldn't have been written and it shouldn't exist", nonExistingFile)
  1467. }
  1468. logDone("build - ADD must add files in container")
  1469. }
  1470. func TestBuildAddBadLinksVolume(t *testing.T) {
  1471. const (
  1472. dockerfileTemplate = `
  1473. FROM busybox
  1474. RUN ln -s /../../../../../../../../%s /x
  1475. VOLUME /x
  1476. ADD foo.txt /x/`
  1477. targetFile = "foo.txt"
  1478. )
  1479. var (
  1480. name = "test-link-absolute-volume"
  1481. dockerfile = ""
  1482. )
  1483. defer deleteImages(name)
  1484. tempDir, err := ioutil.TempDir("", "test-link-absolute-volume-temp-")
  1485. if err != nil {
  1486. t.Fatalf("failed to create temporary directory: %s", tempDir)
  1487. }
  1488. defer os.RemoveAll(tempDir)
  1489. dockerfile = fmt.Sprintf(dockerfileTemplate, tempDir)
  1490. nonExistingFile := filepath.Join(tempDir, targetFile)
  1491. ctx, err := fakeContext(dockerfile, nil)
  1492. if err != nil {
  1493. t.Fatal(err)
  1494. }
  1495. defer ctx.Close()
  1496. fooPath := filepath.Join(ctx.Dir, targetFile)
  1497. foo, err := os.Create(fooPath)
  1498. if err != nil {
  1499. t.Fatal(err)
  1500. }
  1501. defer foo.Close()
  1502. if _, err := foo.WriteString("test"); err != nil {
  1503. t.Fatal(err)
  1504. }
  1505. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1506. t.Fatal(err)
  1507. }
  1508. if _, err := os.Stat(nonExistingFile); err == nil || err != nil && !os.IsNotExist(err) {
  1509. t.Fatalf("%s shouldn't have been written and it shouldn't exist", nonExistingFile)
  1510. }
  1511. logDone("build - ADD should add files in volume")
  1512. }
  1513. // Issue #5270 - ensure we throw a better error than "unexpected EOF"
  1514. // when we can't access files in the context.
  1515. func TestBuildWithInaccessibleFilesInContext(t *testing.T) {
  1516. testRequires(t, UnixCli) // test uses chown/chmod: not available on windows
  1517. {
  1518. name := "testbuildinaccessiblefiles"
  1519. defer deleteImages(name)
  1520. ctx, err := fakeContext("FROM scratch\nADD . /foo/", map[string]string{"fileWithoutReadAccess": "foo"})
  1521. if err != nil {
  1522. t.Fatal(err)
  1523. }
  1524. defer ctx.Close()
  1525. // This is used to ensure we detect inaccessible files early during build in the cli client
  1526. pathToFileWithoutReadAccess := filepath.Join(ctx.Dir, "fileWithoutReadAccess")
  1527. if err = os.Chown(pathToFileWithoutReadAccess, 0, 0); err != nil {
  1528. t.Fatalf("failed to chown file to root: %s", err)
  1529. }
  1530. if err = os.Chmod(pathToFileWithoutReadAccess, 0700); err != nil {
  1531. t.Fatalf("failed to chmod file to 700: %s", err)
  1532. }
  1533. buildCmd := exec.Command("su", "unprivilegeduser", "-c", fmt.Sprintf("%s build -t %s .", dockerBinary, name))
  1534. buildCmd.Dir = ctx.Dir
  1535. out, _, err := runCommandWithOutput(buildCmd)
  1536. if err == nil {
  1537. t.Fatalf("build should have failed: %s %s", err, out)
  1538. }
  1539. // check if we've detected the failure before we started building
  1540. if !strings.Contains(out, "no permission to read from ") {
  1541. t.Fatalf("output should've contained the string: no permission to read from but contained: %s", out)
  1542. }
  1543. if !strings.Contains(out, "Error checking context is accessible") {
  1544. t.Fatalf("output should've contained the string: Error checking context is accessible")
  1545. }
  1546. }
  1547. {
  1548. name := "testbuildinaccessibledirectory"
  1549. defer deleteImages(name)
  1550. ctx, err := fakeContext("FROM scratch\nADD . /foo/", map[string]string{"directoryWeCantStat/bar": "foo"})
  1551. if err != nil {
  1552. t.Fatal(err)
  1553. }
  1554. defer ctx.Close()
  1555. // This is used to ensure we detect inaccessible directories early during build in the cli client
  1556. pathToDirectoryWithoutReadAccess := filepath.Join(ctx.Dir, "directoryWeCantStat")
  1557. pathToFileInDirectoryWithoutReadAccess := filepath.Join(pathToDirectoryWithoutReadAccess, "bar")
  1558. if err = os.Chown(pathToDirectoryWithoutReadAccess, 0, 0); err != nil {
  1559. t.Fatalf("failed to chown directory to root: %s", err)
  1560. }
  1561. if err = os.Chmod(pathToDirectoryWithoutReadAccess, 0444); err != nil {
  1562. t.Fatalf("failed to chmod directory to 444: %s", err)
  1563. }
  1564. if err = os.Chmod(pathToFileInDirectoryWithoutReadAccess, 0700); err != nil {
  1565. t.Fatalf("failed to chmod file to 700: %s", err)
  1566. }
  1567. buildCmd := exec.Command("su", "unprivilegeduser", "-c", fmt.Sprintf("%s build -t %s .", dockerBinary, name))
  1568. buildCmd.Dir = ctx.Dir
  1569. out, _, err := runCommandWithOutput(buildCmd)
  1570. if err == nil {
  1571. t.Fatalf("build should have failed: %s %s", err, out)
  1572. }
  1573. // check if we've detected the failure before we started building
  1574. if !strings.Contains(out, "can't stat") {
  1575. t.Fatalf("output should've contained the string: can't access %s", out)
  1576. }
  1577. if !strings.Contains(out, "Error checking context is accessible") {
  1578. t.Fatalf("output should've contained the string: Error checking context is accessible")
  1579. }
  1580. }
  1581. {
  1582. name := "testlinksok"
  1583. defer deleteImages(name)
  1584. ctx, err := fakeContext("FROM scratch\nADD . /foo/", nil)
  1585. if err != nil {
  1586. t.Fatal(err)
  1587. }
  1588. defer ctx.Close()
  1589. target := "../../../../../../../../../../../../../../../../../../../azA"
  1590. if err := os.Symlink(filepath.Join(ctx.Dir, "g"), target); err != nil {
  1591. t.Fatal(err)
  1592. }
  1593. defer os.Remove(target)
  1594. // This is used to ensure we don't follow links when checking if everything in the context is accessible
  1595. // This test doesn't require that we run commands as an unprivileged user
  1596. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1597. t.Fatal(err)
  1598. }
  1599. }
  1600. {
  1601. name := "testbuildignoredinaccessible"
  1602. defer deleteImages(name)
  1603. ctx, err := fakeContext("FROM scratch\nADD . /foo/",
  1604. map[string]string{
  1605. "directoryWeCantStat/bar": "foo",
  1606. ".dockerignore": "directoryWeCantStat",
  1607. })
  1608. if err != nil {
  1609. t.Fatal(err)
  1610. }
  1611. defer ctx.Close()
  1612. // This is used to ensure we don't try to add inaccessible files when they are ignored by a .dockerignore pattern
  1613. pathToDirectoryWithoutReadAccess := filepath.Join(ctx.Dir, "directoryWeCantStat")
  1614. pathToFileInDirectoryWithoutReadAccess := filepath.Join(pathToDirectoryWithoutReadAccess, "bar")
  1615. if err = os.Chown(pathToDirectoryWithoutReadAccess, 0, 0); err != nil {
  1616. t.Fatalf("failed to chown directory to root: %s", err)
  1617. }
  1618. if err = os.Chmod(pathToDirectoryWithoutReadAccess, 0444); err != nil {
  1619. t.Fatalf("failed to chmod directory to 755: %s", err)
  1620. }
  1621. if err = os.Chmod(pathToFileInDirectoryWithoutReadAccess, 0700); err != nil {
  1622. t.Fatalf("failed to chmod file to 444: %s", err)
  1623. }
  1624. buildCmd := exec.Command("su", "unprivilegeduser", "-c", fmt.Sprintf("%s build -t %s .", dockerBinary, name))
  1625. buildCmd.Dir = ctx.Dir
  1626. if out, _, err := runCommandWithOutput(buildCmd); err != nil {
  1627. t.Fatalf("build should have worked: %s %s", err, out)
  1628. }
  1629. }
  1630. logDone("build - ADD from context with inaccessible files must not pass")
  1631. logDone("build - ADD from context with accessible links must work")
  1632. logDone("build - ADD from context with ignored inaccessible files must work")
  1633. }
  1634. func TestBuildForceRm(t *testing.T) {
  1635. containerCountBefore, err := getContainerCount()
  1636. if err != nil {
  1637. t.Fatalf("failed to get the container count: %s", err)
  1638. }
  1639. name := "testbuildforcerm"
  1640. defer deleteImages(name)
  1641. ctx, err := fakeContext("FROM scratch\nRUN true\nRUN thiswillfail", nil)
  1642. if err != nil {
  1643. t.Fatal(err)
  1644. }
  1645. defer ctx.Close()
  1646. buildCmd := exec.Command(dockerBinary, "build", "-t", name, "--force-rm", ".")
  1647. buildCmd.Dir = ctx.Dir
  1648. if out, _, err := runCommandWithOutput(buildCmd); err == nil {
  1649. t.Fatalf("failed to build the image: %s, %v", out, err)
  1650. }
  1651. containerCountAfter, err := getContainerCount()
  1652. if err != nil {
  1653. t.Fatalf("failed to get the container count: %s", err)
  1654. }
  1655. if containerCountBefore != containerCountAfter {
  1656. t.Fatalf("--force-rm shouldn't have left containers behind")
  1657. }
  1658. logDone("build - ensure --force-rm doesn't leave containers behind")
  1659. }
  1660. func TestBuildRm(t *testing.T) {
  1661. name := "testbuildrm"
  1662. defer deleteImages(name)
  1663. ctx, err := fakeContext("FROM scratch\nADD foo /\nADD foo /", map[string]string{"foo": "bar"})
  1664. if err != nil {
  1665. t.Fatal(err)
  1666. }
  1667. defer ctx.Close()
  1668. {
  1669. containerCountBefore, err := getContainerCount()
  1670. if err != nil {
  1671. t.Fatalf("failed to get the container count: %s", err)
  1672. }
  1673. out, _, err := dockerCmdInDir(t, ctx.Dir, "build", "--rm", "-t", name, ".")
  1674. if err != nil {
  1675. t.Fatal("failed to build the image", out)
  1676. }
  1677. containerCountAfter, err := getContainerCount()
  1678. if err != nil {
  1679. t.Fatalf("failed to get the container count: %s", err)
  1680. }
  1681. if containerCountBefore != containerCountAfter {
  1682. t.Fatalf("-rm shouldn't have left containers behind")
  1683. }
  1684. deleteImages(name)
  1685. }
  1686. {
  1687. containerCountBefore, err := getContainerCount()
  1688. if err != nil {
  1689. t.Fatalf("failed to get the container count: %s", err)
  1690. }
  1691. out, _, err := dockerCmdInDir(t, ctx.Dir, "build", "-t", name, ".")
  1692. if err != nil {
  1693. t.Fatal("failed to build the image", out)
  1694. }
  1695. containerCountAfter, err := getContainerCount()
  1696. if err != nil {
  1697. t.Fatalf("failed to get the container count: %s", err)
  1698. }
  1699. if containerCountBefore != containerCountAfter {
  1700. t.Fatalf("--rm shouldn't have left containers behind")
  1701. }
  1702. deleteImages(name)
  1703. }
  1704. {
  1705. containerCountBefore, err := getContainerCount()
  1706. if err != nil {
  1707. t.Fatalf("failed to get the container count: %s", err)
  1708. }
  1709. out, _, err := dockerCmdInDir(t, ctx.Dir, "build", "--rm=false", "-t", name, ".")
  1710. if err != nil {
  1711. t.Fatal("failed to build the image", out)
  1712. }
  1713. containerCountAfter, err := getContainerCount()
  1714. if err != nil {
  1715. t.Fatalf("failed to get the container count: %s", err)
  1716. }
  1717. if containerCountBefore == containerCountAfter {
  1718. t.Fatalf("--rm=false should have left containers behind")
  1719. }
  1720. deleteAllContainers()
  1721. deleteImages(name)
  1722. }
  1723. logDone("build - ensure --rm doesn't leave containers behind and that --rm=true is the default")
  1724. logDone("build - ensure --rm=false overrides the default")
  1725. }
  1726. func TestBuildWithVolumes(t *testing.T) {
  1727. var (
  1728. result map[string]map[string]struct{}
  1729. name = "testbuildvolumes"
  1730. emptyMap = make(map[string]struct{})
  1731. expected = map[string]map[string]struct{}{
  1732. "/test1": emptyMap,
  1733. "/test2": emptyMap,
  1734. "/test3": emptyMap,
  1735. "/test4": emptyMap,
  1736. "/test5": emptyMap,
  1737. "/test6": emptyMap,
  1738. "[/test7": emptyMap,
  1739. "/test8]": emptyMap,
  1740. }
  1741. )
  1742. defer deleteImages(name)
  1743. _, err := buildImage(name,
  1744. `FROM scratch
  1745. VOLUME /test1
  1746. VOLUME /test2
  1747. VOLUME /test3 /test4
  1748. VOLUME ["/test5", "/test6"]
  1749. VOLUME [/test7 /test8]
  1750. `,
  1751. true)
  1752. if err != nil {
  1753. t.Fatal(err)
  1754. }
  1755. res, err := inspectFieldJSON(name, "Config.Volumes")
  1756. if err != nil {
  1757. t.Fatal(err)
  1758. }
  1759. err = unmarshalJSON([]byte(res), &result)
  1760. if err != nil {
  1761. t.Fatal(err)
  1762. }
  1763. equal := reflect.DeepEqual(&result, &expected)
  1764. if !equal {
  1765. t.Fatalf("Volumes %s, expected %s", result, expected)
  1766. }
  1767. logDone("build - with volumes")
  1768. }
  1769. func TestBuildMaintainer(t *testing.T) {
  1770. name := "testbuildmaintainer"
  1771. expected := "dockerio"
  1772. defer deleteImages(name)
  1773. _, err := buildImage(name,
  1774. `FROM scratch
  1775. MAINTAINER dockerio`,
  1776. true)
  1777. if err != nil {
  1778. t.Fatal(err)
  1779. }
  1780. res, err := inspectField(name, "Author")
  1781. if err != nil {
  1782. t.Fatal(err)
  1783. }
  1784. if res != expected {
  1785. t.Fatalf("Maintainer %s, expected %s", res, expected)
  1786. }
  1787. logDone("build - maintainer")
  1788. }
  1789. func TestBuildUser(t *testing.T) {
  1790. name := "testbuilduser"
  1791. expected := "dockerio"
  1792. defer deleteImages(name)
  1793. _, err := buildImage(name,
  1794. `FROM busybox
  1795. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  1796. USER dockerio
  1797. RUN [ $(whoami) = 'dockerio' ]`,
  1798. true)
  1799. if err != nil {
  1800. t.Fatal(err)
  1801. }
  1802. res, err := inspectField(name, "Config.User")
  1803. if err != nil {
  1804. t.Fatal(err)
  1805. }
  1806. if res != expected {
  1807. t.Fatalf("User %s, expected %s", res, expected)
  1808. }
  1809. logDone("build - user")
  1810. }
  1811. func TestBuildRelativeWorkdir(t *testing.T) {
  1812. name := "testbuildrelativeworkdir"
  1813. expected := "/test2/test3"
  1814. defer deleteImages(name)
  1815. _, err := buildImage(name,
  1816. `FROM busybox
  1817. RUN [ "$PWD" = '/' ]
  1818. WORKDIR test1
  1819. RUN [ "$PWD" = '/test1' ]
  1820. WORKDIR /test2
  1821. RUN [ "$PWD" = '/test2' ]
  1822. WORKDIR test3
  1823. RUN [ "$PWD" = '/test2/test3' ]`,
  1824. true)
  1825. if err != nil {
  1826. t.Fatal(err)
  1827. }
  1828. res, err := inspectField(name, "Config.WorkingDir")
  1829. if err != nil {
  1830. t.Fatal(err)
  1831. }
  1832. if res != expected {
  1833. t.Fatalf("Workdir %s, expected %s", res, expected)
  1834. }
  1835. logDone("build - relative workdir")
  1836. }
  1837. func TestBuildWorkdirWithEnvVariables(t *testing.T) {
  1838. name := "testbuildworkdirwithenvvariables"
  1839. expected := "/test1/test2"
  1840. defer deleteImages(name)
  1841. _, err := buildImage(name,
  1842. `FROM busybox
  1843. ENV DIRPATH /test1
  1844. ENV SUBDIRNAME test2
  1845. WORKDIR $DIRPATH
  1846. WORKDIR $SUBDIRNAME/$MISSING_VAR`,
  1847. true)
  1848. if err != nil {
  1849. t.Fatal(err)
  1850. }
  1851. res, err := inspectField(name, "Config.WorkingDir")
  1852. if err != nil {
  1853. t.Fatal(err)
  1854. }
  1855. if res != expected {
  1856. t.Fatalf("Workdir %s, expected %s", res, expected)
  1857. }
  1858. logDone("build - workdir with env variables")
  1859. }
  1860. func TestBuildRelativeCopy(t *testing.T) {
  1861. name := "testbuildrelativecopy"
  1862. defer deleteImages(name)
  1863. dockerfile := `
  1864. FROM busybox
  1865. WORKDIR /test1
  1866. WORKDIR test2
  1867. RUN [ "$PWD" = '/test1/test2' ]
  1868. COPY foo ./
  1869. RUN [ "$(cat /test1/test2/foo)" = 'hello' ]
  1870. ADD foo ./bar/baz
  1871. RUN [ "$(cat /test1/test2/bar/baz)" = 'hello' ]
  1872. COPY foo ./bar/baz2
  1873. RUN [ "$(cat /test1/test2/bar/baz2)" = 'hello' ]
  1874. WORKDIR ..
  1875. COPY foo ./
  1876. RUN [ "$(cat /test1/foo)" = 'hello' ]
  1877. COPY foo /test3/
  1878. RUN [ "$(cat /test3/foo)" = 'hello' ]
  1879. WORKDIR /test4
  1880. COPY . .
  1881. RUN [ "$(cat /test4/foo)" = 'hello' ]
  1882. WORKDIR /test5/test6
  1883. COPY foo ../
  1884. RUN [ "$(cat /test5/foo)" = 'hello' ]
  1885. `
  1886. ctx, err := fakeContext(dockerfile, map[string]string{
  1887. "foo": "hello",
  1888. })
  1889. defer ctx.Close()
  1890. if err != nil {
  1891. t.Fatal(err)
  1892. }
  1893. _, err = buildImageFromContext(name, ctx, false)
  1894. if err != nil {
  1895. t.Fatal(err)
  1896. }
  1897. logDone("build - relative copy/add")
  1898. }
  1899. func TestBuildEnv(t *testing.T) {
  1900. name := "testbuildenv"
  1901. expected := "[PATH=/test:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PORT=2375]"
  1902. defer deleteImages(name)
  1903. _, err := buildImage(name,
  1904. `FROM busybox
  1905. ENV PATH /test:$PATH
  1906. ENV PORT 2375
  1907. RUN [ $(env | grep PORT) = 'PORT=2375' ]`,
  1908. true)
  1909. if err != nil {
  1910. t.Fatal(err)
  1911. }
  1912. res, err := inspectField(name, "Config.Env")
  1913. if err != nil {
  1914. t.Fatal(err)
  1915. }
  1916. if res != expected {
  1917. t.Fatalf("Env %s, expected %s", res, expected)
  1918. }
  1919. logDone("build - env")
  1920. }
  1921. func TestBuildContextCleanup(t *testing.T) {
  1922. testRequires(t, SameHostDaemon)
  1923. name := "testbuildcontextcleanup"
  1924. defer deleteImages(name)
  1925. entries, err := ioutil.ReadDir("/var/lib/docker/tmp")
  1926. if err != nil {
  1927. t.Fatalf("failed to list contents of tmp dir: %s", err)
  1928. }
  1929. _, err = buildImage(name,
  1930. `FROM scratch
  1931. ENTRYPOINT ["/bin/echo"]`,
  1932. true)
  1933. if err != nil {
  1934. t.Fatal(err)
  1935. }
  1936. entriesFinal, err := ioutil.ReadDir("/var/lib/docker/tmp")
  1937. if err != nil {
  1938. t.Fatalf("failed to list contents of tmp dir: %s", err)
  1939. }
  1940. if err = compareDirectoryEntries(entries, entriesFinal); err != nil {
  1941. t.Fatalf("context should have been deleted, but wasn't")
  1942. }
  1943. logDone("build - verify context cleanup works properly")
  1944. }
  1945. func TestBuildContextCleanupFailedBuild(t *testing.T) {
  1946. testRequires(t, SameHostDaemon)
  1947. name := "testbuildcontextcleanup"
  1948. defer deleteImages(name)
  1949. defer deleteAllContainers()
  1950. entries, err := ioutil.ReadDir("/var/lib/docker/tmp")
  1951. if err != nil {
  1952. t.Fatalf("failed to list contents of tmp dir: %s", err)
  1953. }
  1954. _, err = buildImage(name,
  1955. `FROM scratch
  1956. RUN /non/existing/command`,
  1957. true)
  1958. if err == nil {
  1959. t.Fatalf("expected build to fail, but it didn't")
  1960. }
  1961. entriesFinal, err := ioutil.ReadDir("/var/lib/docker/tmp")
  1962. if err != nil {
  1963. t.Fatalf("failed to list contents of tmp dir: %s", err)
  1964. }
  1965. if err = compareDirectoryEntries(entries, entriesFinal); err != nil {
  1966. t.Fatalf("context should have been deleted, but wasn't")
  1967. }
  1968. logDone("build - verify context cleanup works properly after an unsuccessful build")
  1969. }
  1970. func TestBuildCmd(t *testing.T) {
  1971. name := "testbuildcmd"
  1972. expected := "[/bin/echo Hello World]"
  1973. defer deleteImages(name)
  1974. _, err := buildImage(name,
  1975. `FROM scratch
  1976. CMD ["/bin/echo", "Hello World"]`,
  1977. true)
  1978. if err != nil {
  1979. t.Fatal(err)
  1980. }
  1981. res, err := inspectField(name, "Config.Cmd")
  1982. if err != nil {
  1983. t.Fatal(err)
  1984. }
  1985. if res != expected {
  1986. t.Fatalf("Cmd %s, expected %s", res, expected)
  1987. }
  1988. logDone("build - cmd")
  1989. }
  1990. func TestBuildExpose(t *testing.T) {
  1991. name := "testbuildexpose"
  1992. expected := "map[2375/tcp:map[]]"
  1993. defer deleteImages(name)
  1994. _, err := buildImage(name,
  1995. `FROM scratch
  1996. EXPOSE 2375`,
  1997. true)
  1998. if err != nil {
  1999. t.Fatal(err)
  2000. }
  2001. res, err := inspectField(name, "Config.ExposedPorts")
  2002. if err != nil {
  2003. t.Fatal(err)
  2004. }
  2005. if res != expected {
  2006. t.Fatalf("Exposed ports %s, expected %s", res, expected)
  2007. }
  2008. logDone("build - expose")
  2009. }
  2010. func TestBuildExposeMorePorts(t *testing.T) {
  2011. // start building docker file with a large number of ports
  2012. portList := make([]string, 50)
  2013. line := make([]string, 100)
  2014. expectedPorts := make([]int, len(portList)*len(line))
  2015. for i := 0; i < len(portList); i++ {
  2016. for j := 0; j < len(line); j++ {
  2017. p := i*len(line) + j + 1
  2018. line[j] = strconv.Itoa(p)
  2019. expectedPorts[p-1] = p
  2020. }
  2021. if i == len(portList)-1 {
  2022. portList[i] = strings.Join(line, " ")
  2023. } else {
  2024. portList[i] = strings.Join(line, " ") + ` \`
  2025. }
  2026. }
  2027. dockerfile := `FROM scratch
  2028. EXPOSE {{range .}} {{.}}
  2029. {{end}}`
  2030. tmpl := template.Must(template.New("dockerfile").Parse(dockerfile))
  2031. buf := bytes.NewBuffer(nil)
  2032. tmpl.Execute(buf, portList)
  2033. name := "testbuildexpose"
  2034. defer deleteImages(name)
  2035. _, err := buildImage(name, buf.String(), true)
  2036. if err != nil {
  2037. t.Fatal(err)
  2038. }
  2039. // check if all the ports are saved inside Config.ExposedPorts
  2040. res, err := inspectFieldJSON(name, "Config.ExposedPorts")
  2041. if err != nil {
  2042. t.Fatal(err)
  2043. }
  2044. var exposedPorts map[string]interface{}
  2045. if err := json.Unmarshal([]byte(res), &exposedPorts); err != nil {
  2046. t.Fatal(err)
  2047. }
  2048. for _, p := range expectedPorts {
  2049. ep := fmt.Sprintf("%d/tcp", p)
  2050. if _, ok := exposedPorts[ep]; !ok {
  2051. t.Errorf("Port(%s) is not exposed", ep)
  2052. } else {
  2053. delete(exposedPorts, ep)
  2054. }
  2055. }
  2056. if len(exposedPorts) != 0 {
  2057. t.Errorf("Unexpected extra exposed ports %v", exposedPorts)
  2058. }
  2059. logDone("build - expose large number of ports")
  2060. }
  2061. func TestBuildExposeOrder(t *testing.T) {
  2062. buildID := func(name, exposed string) string {
  2063. _, err := buildImage(name, fmt.Sprintf(`FROM scratch
  2064. EXPOSE %s`, exposed), true)
  2065. if err != nil {
  2066. t.Fatal(err)
  2067. }
  2068. id, err := inspectField(name, "Id")
  2069. if err != nil {
  2070. t.Fatal(err)
  2071. }
  2072. return id
  2073. }
  2074. id1 := buildID("testbuildexpose1", "80 2375")
  2075. id2 := buildID("testbuildexpose2", "2375 80")
  2076. defer deleteImages("testbuildexpose1", "testbuildexpose2")
  2077. if id1 != id2 {
  2078. t.Errorf("EXPOSE should invalidate the cache only when ports actually changed")
  2079. }
  2080. logDone("build - expose order")
  2081. }
  2082. func TestBuildExposeUpperCaseProto(t *testing.T) {
  2083. name := "testbuildexposeuppercaseproto"
  2084. expected := "map[5678/udp:map[]]"
  2085. defer deleteImages(name)
  2086. _, err := buildImage(name,
  2087. `FROM scratch
  2088. EXPOSE 5678/UDP`,
  2089. true)
  2090. if err != nil {
  2091. t.Fatal(err)
  2092. }
  2093. res, err := inspectField(name, "Config.ExposedPorts")
  2094. if err != nil {
  2095. t.Fatal(err)
  2096. }
  2097. if res != expected {
  2098. t.Fatalf("Exposed ports %s, expected %s", res, expected)
  2099. }
  2100. logDone("build - expose port with upper case proto")
  2101. }
  2102. func TestBuildExposeHostPort(t *testing.T) {
  2103. // start building docker file with ip:hostPort:containerPort
  2104. name := "testbuildexpose"
  2105. expected := "map[5678/tcp:map[]]"
  2106. defer deleteImages(name)
  2107. _, out, err := buildImageWithOut(name,
  2108. `FROM scratch
  2109. EXPOSE 192.168.1.2:2375:5678`,
  2110. true)
  2111. if err != nil {
  2112. t.Fatal(err)
  2113. }
  2114. if !strings.Contains(out, "to map host ports to container ports (ip:hostPort:containerPort) is deprecated.") {
  2115. t.Fatal("Missing warning message")
  2116. }
  2117. res, err := inspectField(name, "Config.ExposedPorts")
  2118. if err != nil {
  2119. t.Fatal(err)
  2120. }
  2121. if res != expected {
  2122. t.Fatalf("Exposed ports %s, expected %s", res, expected)
  2123. }
  2124. logDone("build - ignore exposing host's port")
  2125. }
  2126. func TestBuildEmptyEntrypointInheritance(t *testing.T) {
  2127. name := "testbuildentrypointinheritance"
  2128. name2 := "testbuildentrypointinheritance2"
  2129. defer deleteImages(name, name2)
  2130. _, err := buildImage(name,
  2131. `FROM busybox
  2132. ENTRYPOINT ["/bin/echo"]`,
  2133. true)
  2134. if err != nil {
  2135. t.Fatal(err)
  2136. }
  2137. res, err := inspectField(name, "Config.Entrypoint")
  2138. if err != nil {
  2139. t.Fatal(err)
  2140. }
  2141. expected := "[/bin/echo]"
  2142. if res != expected {
  2143. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  2144. }
  2145. _, err = buildImage(name2,
  2146. fmt.Sprintf(`FROM %s
  2147. ENTRYPOINT []`, name),
  2148. true)
  2149. if err != nil {
  2150. t.Fatal(err)
  2151. }
  2152. res, err = inspectField(name2, "Config.Entrypoint")
  2153. if err != nil {
  2154. t.Fatal(err)
  2155. }
  2156. expected = "[]"
  2157. if res != expected {
  2158. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  2159. }
  2160. logDone("build - empty entrypoint inheritance")
  2161. }
  2162. func TestBuildEmptyEntrypoint(t *testing.T) {
  2163. name := "testbuildentrypoint"
  2164. defer deleteImages(name)
  2165. expected := "[]"
  2166. _, err := buildImage(name,
  2167. `FROM busybox
  2168. ENTRYPOINT []`,
  2169. true)
  2170. if err != nil {
  2171. t.Fatal(err)
  2172. }
  2173. res, err := inspectField(name, "Config.Entrypoint")
  2174. if err != nil {
  2175. t.Fatal(err)
  2176. }
  2177. if res != expected {
  2178. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  2179. }
  2180. logDone("build - empty entrypoint")
  2181. }
  2182. func TestBuildEntrypoint(t *testing.T) {
  2183. name := "testbuildentrypoint"
  2184. expected := "[/bin/echo]"
  2185. defer deleteImages(name)
  2186. _, err := buildImage(name,
  2187. `FROM scratch
  2188. ENTRYPOINT ["/bin/echo"]`,
  2189. true)
  2190. if err != nil {
  2191. t.Fatal(err)
  2192. }
  2193. res, err := inspectField(name, "Config.Entrypoint")
  2194. if err != nil {
  2195. t.Fatal(err)
  2196. }
  2197. if res != expected {
  2198. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  2199. }
  2200. logDone("build - entrypoint")
  2201. }
  2202. // #6445 ensure ONBUILD triggers aren't committed to grandchildren
  2203. func TestBuildOnBuildLimitedInheritence(t *testing.T) {
  2204. var (
  2205. out2, out3 string
  2206. )
  2207. {
  2208. name1 := "testonbuildtrigger1"
  2209. dockerfile1 := `
  2210. FROM busybox
  2211. RUN echo "GRANDPARENT"
  2212. ONBUILD RUN echo "ONBUILD PARENT"
  2213. `
  2214. ctx, err := fakeContext(dockerfile1, nil)
  2215. if err != nil {
  2216. t.Fatal(err)
  2217. }
  2218. defer ctx.Close()
  2219. out1, _, err := dockerCmdInDir(t, ctx.Dir, "build", "-t", name1, ".")
  2220. if err != nil {
  2221. t.Fatalf("build failed to complete: %s, %v", out1, err)
  2222. }
  2223. defer deleteImages(name1)
  2224. }
  2225. {
  2226. name2 := "testonbuildtrigger2"
  2227. dockerfile2 := `
  2228. FROM testonbuildtrigger1
  2229. `
  2230. ctx, err := fakeContext(dockerfile2, nil)
  2231. if err != nil {
  2232. t.Fatal(err)
  2233. }
  2234. defer ctx.Close()
  2235. out2, _, err = dockerCmdInDir(t, ctx.Dir, "build", "-t", name2, ".")
  2236. if err != nil {
  2237. t.Fatalf("build failed to complete: %s, %v", out2, err)
  2238. }
  2239. defer deleteImages(name2)
  2240. }
  2241. {
  2242. name3 := "testonbuildtrigger3"
  2243. dockerfile3 := `
  2244. FROM testonbuildtrigger2
  2245. `
  2246. ctx, err := fakeContext(dockerfile3, nil)
  2247. if err != nil {
  2248. t.Fatal(err)
  2249. }
  2250. defer ctx.Close()
  2251. out3, _, err = dockerCmdInDir(t, ctx.Dir, "build", "-t", name3, ".")
  2252. if err != nil {
  2253. t.Fatalf("build failed to complete: %s, %v", out3, err)
  2254. }
  2255. defer deleteImages(name3)
  2256. }
  2257. // ONBUILD should be run in second build.
  2258. if !strings.Contains(out2, "ONBUILD PARENT") {
  2259. t.Fatalf("ONBUILD instruction did not run in child of ONBUILD parent")
  2260. }
  2261. // ONBUILD should *not* be run in third build.
  2262. if strings.Contains(out3, "ONBUILD PARENT") {
  2263. t.Fatalf("ONBUILD instruction ran in grandchild of ONBUILD parent")
  2264. }
  2265. logDone("build - onbuild")
  2266. }
  2267. func TestBuildWithCache(t *testing.T) {
  2268. name := "testbuildwithcache"
  2269. defer deleteImages(name)
  2270. id1, err := buildImage(name,
  2271. `FROM scratch
  2272. MAINTAINER dockerio
  2273. EXPOSE 5432
  2274. ENTRYPOINT ["/bin/echo"]`,
  2275. true)
  2276. if err != nil {
  2277. t.Fatal(err)
  2278. }
  2279. id2, err := buildImage(name,
  2280. `FROM scratch
  2281. MAINTAINER dockerio
  2282. EXPOSE 5432
  2283. ENTRYPOINT ["/bin/echo"]`,
  2284. true)
  2285. if err != nil {
  2286. t.Fatal(err)
  2287. }
  2288. if id1 != id2 {
  2289. t.Fatal("The cache should have been used but hasn't.")
  2290. }
  2291. logDone("build - with cache")
  2292. }
  2293. func TestBuildWithoutCache(t *testing.T) {
  2294. name := "testbuildwithoutcache"
  2295. name2 := "testbuildwithoutcache2"
  2296. defer deleteImages(name, name2)
  2297. id1, err := buildImage(name,
  2298. `FROM scratch
  2299. MAINTAINER dockerio
  2300. EXPOSE 5432
  2301. ENTRYPOINT ["/bin/echo"]`,
  2302. true)
  2303. if err != nil {
  2304. t.Fatal(err)
  2305. }
  2306. id2, err := buildImage(name2,
  2307. `FROM scratch
  2308. MAINTAINER dockerio
  2309. EXPOSE 5432
  2310. ENTRYPOINT ["/bin/echo"]`,
  2311. false)
  2312. if err != nil {
  2313. t.Fatal(err)
  2314. }
  2315. if id1 == id2 {
  2316. t.Fatal("The cache should have been invalided but hasn't.")
  2317. }
  2318. logDone("build - without cache")
  2319. }
  2320. func TestBuildConditionalCache(t *testing.T) {
  2321. name := "testbuildconditionalcache"
  2322. name2 := "testbuildconditionalcache2"
  2323. defer deleteImages(name, name2)
  2324. dockerfile := `
  2325. FROM busybox
  2326. ADD foo /tmp/`
  2327. ctx, err := fakeContext(dockerfile, map[string]string{
  2328. "foo": "hello",
  2329. })
  2330. if err != nil {
  2331. t.Fatal(err)
  2332. }
  2333. defer ctx.Close()
  2334. id1, err := buildImageFromContext(name, ctx, true)
  2335. if err != nil {
  2336. t.Fatalf("Error building #1: %s", err)
  2337. }
  2338. if err := ctx.Add("foo", "bye"); err != nil {
  2339. t.Fatalf("Error modifying foo: %s", err)
  2340. }
  2341. id2, err := buildImageFromContext(name, ctx, false)
  2342. if err != nil {
  2343. t.Fatalf("Error building #2: %s", err)
  2344. }
  2345. if id2 == id1 {
  2346. t.Fatal("Should not have used the cache")
  2347. }
  2348. id3, err := buildImageFromContext(name, ctx, true)
  2349. if err != nil {
  2350. t.Fatalf("Error building #3: %s", err)
  2351. }
  2352. if id3 != id2 {
  2353. t.Fatal("Should have used the cache")
  2354. }
  2355. logDone("build - conditional cache")
  2356. }
  2357. func TestBuildADDLocalFileWithCache(t *testing.T) {
  2358. name := "testbuildaddlocalfilewithcache"
  2359. name2 := "testbuildaddlocalfilewithcache2"
  2360. defer deleteImages(name, name2)
  2361. dockerfile := `
  2362. FROM busybox
  2363. MAINTAINER dockerio
  2364. ADD foo /usr/lib/bla/bar
  2365. RUN [ "$(cat /usr/lib/bla/bar)" = "hello" ]`
  2366. ctx, err := fakeContext(dockerfile, map[string]string{
  2367. "foo": "hello",
  2368. })
  2369. defer ctx.Close()
  2370. if err != nil {
  2371. t.Fatal(err)
  2372. }
  2373. id1, err := buildImageFromContext(name, ctx, true)
  2374. if err != nil {
  2375. t.Fatal(err)
  2376. }
  2377. id2, err := buildImageFromContext(name2, ctx, true)
  2378. if err != nil {
  2379. t.Fatal(err)
  2380. }
  2381. if id1 != id2 {
  2382. t.Fatal("The cache should have been used but hasn't.")
  2383. }
  2384. logDone("build - add local file with cache")
  2385. }
  2386. func TestBuildADDMultipleLocalFileWithCache(t *testing.T) {
  2387. name := "testbuildaddmultiplelocalfilewithcache"
  2388. name2 := "testbuildaddmultiplelocalfilewithcache2"
  2389. defer deleteImages(name, name2)
  2390. dockerfile := `
  2391. FROM busybox
  2392. MAINTAINER dockerio
  2393. ADD foo Dockerfile /usr/lib/bla/
  2394. RUN [ "$(cat /usr/lib/bla/foo)" = "hello" ]`
  2395. ctx, err := fakeContext(dockerfile, map[string]string{
  2396. "foo": "hello",
  2397. })
  2398. defer ctx.Close()
  2399. if err != nil {
  2400. t.Fatal(err)
  2401. }
  2402. id1, err := buildImageFromContext(name, ctx, true)
  2403. if err != nil {
  2404. t.Fatal(err)
  2405. }
  2406. id2, err := buildImageFromContext(name2, ctx, true)
  2407. if err != nil {
  2408. t.Fatal(err)
  2409. }
  2410. if id1 != id2 {
  2411. t.Fatal("The cache should have been used but hasn't.")
  2412. }
  2413. logDone("build - add multiple local files with cache")
  2414. }
  2415. func TestBuildADDLocalFileWithoutCache(t *testing.T) {
  2416. name := "testbuildaddlocalfilewithoutcache"
  2417. name2 := "testbuildaddlocalfilewithoutcache2"
  2418. defer deleteImages(name, name2)
  2419. dockerfile := `
  2420. FROM busybox
  2421. MAINTAINER dockerio
  2422. ADD foo /usr/lib/bla/bar
  2423. RUN [ "$(cat /usr/lib/bla/bar)" = "hello" ]`
  2424. ctx, err := fakeContext(dockerfile, map[string]string{
  2425. "foo": "hello",
  2426. })
  2427. defer ctx.Close()
  2428. if err != nil {
  2429. t.Fatal(err)
  2430. }
  2431. id1, err := buildImageFromContext(name, ctx, true)
  2432. if err != nil {
  2433. t.Fatal(err)
  2434. }
  2435. id2, err := buildImageFromContext(name2, ctx, false)
  2436. if err != nil {
  2437. t.Fatal(err)
  2438. }
  2439. if id1 == id2 {
  2440. t.Fatal("The cache should have been invalided but hasn't.")
  2441. }
  2442. logDone("build - add local file without cache")
  2443. }
  2444. func TestBuildCopyDirButNotFile(t *testing.T) {
  2445. name := "testbuildcopydirbutnotfile"
  2446. name2 := "testbuildcopydirbutnotfile2"
  2447. defer deleteImages(name, name2)
  2448. dockerfile := `
  2449. FROM scratch
  2450. COPY dir /tmp/`
  2451. ctx, err := fakeContext(dockerfile, map[string]string{
  2452. "dir/foo": "hello",
  2453. })
  2454. defer ctx.Close()
  2455. if err != nil {
  2456. t.Fatal(err)
  2457. }
  2458. id1, err := buildImageFromContext(name, ctx, true)
  2459. if err != nil {
  2460. t.Fatal(err)
  2461. }
  2462. // Check that adding file with similar name doesn't mess with cache
  2463. if err := ctx.Add("dir_file", "hello2"); err != nil {
  2464. t.Fatal(err)
  2465. }
  2466. id2, err := buildImageFromContext(name2, ctx, true)
  2467. if err != nil {
  2468. t.Fatal(err)
  2469. }
  2470. if id1 != id2 {
  2471. t.Fatal("The cache should have been used but wasn't")
  2472. }
  2473. logDone("build - add current directory but not file")
  2474. }
  2475. func TestBuildADDCurrentDirWithCache(t *testing.T) {
  2476. name := "testbuildaddcurrentdirwithcache"
  2477. name2 := name + "2"
  2478. name3 := name + "3"
  2479. name4 := name + "4"
  2480. name5 := name + "5"
  2481. defer deleteImages(name, name2, name3, name4, name5)
  2482. dockerfile := `
  2483. FROM scratch
  2484. MAINTAINER dockerio
  2485. ADD . /usr/lib/bla`
  2486. ctx, err := fakeContext(dockerfile, map[string]string{
  2487. "foo": "hello",
  2488. })
  2489. defer ctx.Close()
  2490. if err != nil {
  2491. t.Fatal(err)
  2492. }
  2493. id1, err := buildImageFromContext(name, ctx, true)
  2494. if err != nil {
  2495. t.Fatal(err)
  2496. }
  2497. // Check that adding file invalidate cache of "ADD ."
  2498. if err := ctx.Add("bar", "hello2"); err != nil {
  2499. t.Fatal(err)
  2500. }
  2501. id2, err := buildImageFromContext(name2, ctx, true)
  2502. if err != nil {
  2503. t.Fatal(err)
  2504. }
  2505. if id1 == id2 {
  2506. t.Fatal("The cache should have been invalided but hasn't.")
  2507. }
  2508. // Check that changing file invalidate cache of "ADD ."
  2509. if err := ctx.Add("foo", "hello1"); err != nil {
  2510. t.Fatal(err)
  2511. }
  2512. id3, err := buildImageFromContext(name3, ctx, true)
  2513. if err != nil {
  2514. t.Fatal(err)
  2515. }
  2516. if id2 == id3 {
  2517. t.Fatal("The cache should have been invalided but hasn't.")
  2518. }
  2519. // Check that changing file to same content invalidate cache of "ADD ."
  2520. time.Sleep(1 * time.Second) // wait second because of mtime precision
  2521. if err := ctx.Add("foo", "hello1"); err != nil {
  2522. t.Fatal(err)
  2523. }
  2524. id4, err := buildImageFromContext(name4, ctx, true)
  2525. if err != nil {
  2526. t.Fatal(err)
  2527. }
  2528. if id3 == id4 {
  2529. t.Fatal("The cache should have been invalided but hasn't.")
  2530. }
  2531. id5, err := buildImageFromContext(name5, ctx, true)
  2532. if err != nil {
  2533. t.Fatal(err)
  2534. }
  2535. if id4 != id5 {
  2536. t.Fatal("The cache should have been used but hasn't.")
  2537. }
  2538. logDone("build - add current directory with cache")
  2539. }
  2540. func TestBuildADDCurrentDirWithoutCache(t *testing.T) {
  2541. name := "testbuildaddcurrentdirwithoutcache"
  2542. name2 := "testbuildaddcurrentdirwithoutcache2"
  2543. defer deleteImages(name, name2)
  2544. dockerfile := `
  2545. FROM scratch
  2546. MAINTAINER dockerio
  2547. ADD . /usr/lib/bla`
  2548. ctx, err := fakeContext(dockerfile, map[string]string{
  2549. "foo": "hello",
  2550. })
  2551. defer ctx.Close()
  2552. if err != nil {
  2553. t.Fatal(err)
  2554. }
  2555. id1, err := buildImageFromContext(name, ctx, true)
  2556. if err != nil {
  2557. t.Fatal(err)
  2558. }
  2559. id2, err := buildImageFromContext(name2, ctx, false)
  2560. if err != nil {
  2561. t.Fatal(err)
  2562. }
  2563. if id1 == id2 {
  2564. t.Fatal("The cache should have been invalided but hasn't.")
  2565. }
  2566. logDone("build - add current directory without cache")
  2567. }
  2568. func TestBuildADDRemoteFileWithCache(t *testing.T) {
  2569. name := "testbuildaddremotefilewithcache"
  2570. defer deleteImages(name)
  2571. server, err := fakeStorage(map[string]string{
  2572. "baz": "hello",
  2573. })
  2574. if err != nil {
  2575. t.Fatal(err)
  2576. }
  2577. defer server.Close()
  2578. id1, err := buildImage(name,
  2579. fmt.Sprintf(`FROM scratch
  2580. MAINTAINER dockerio
  2581. ADD %s/baz /usr/lib/baz/quux`, server.URL()),
  2582. true)
  2583. if err != nil {
  2584. t.Fatal(err)
  2585. }
  2586. id2, err := buildImage(name,
  2587. fmt.Sprintf(`FROM scratch
  2588. MAINTAINER dockerio
  2589. ADD %s/baz /usr/lib/baz/quux`, server.URL()),
  2590. true)
  2591. if err != nil {
  2592. t.Fatal(err)
  2593. }
  2594. if id1 != id2 {
  2595. t.Fatal("The cache should have been used but hasn't.")
  2596. }
  2597. logDone("build - add remote file with cache")
  2598. }
  2599. func TestBuildADDRemoteFileWithoutCache(t *testing.T) {
  2600. name := "testbuildaddremotefilewithoutcache"
  2601. name2 := "testbuildaddremotefilewithoutcache2"
  2602. defer deleteImages(name, name2)
  2603. server, err := fakeStorage(map[string]string{
  2604. "baz": "hello",
  2605. })
  2606. if err != nil {
  2607. t.Fatal(err)
  2608. }
  2609. defer server.Close()
  2610. id1, err := buildImage(name,
  2611. fmt.Sprintf(`FROM scratch
  2612. MAINTAINER dockerio
  2613. ADD %s/baz /usr/lib/baz/quux`, server.URL()),
  2614. true)
  2615. if err != nil {
  2616. t.Fatal(err)
  2617. }
  2618. id2, err := buildImage(name2,
  2619. fmt.Sprintf(`FROM scratch
  2620. MAINTAINER dockerio
  2621. ADD %s/baz /usr/lib/baz/quux`, server.URL()),
  2622. false)
  2623. if err != nil {
  2624. t.Fatal(err)
  2625. }
  2626. if id1 == id2 {
  2627. t.Fatal("The cache should have been invalided but hasn't.")
  2628. }
  2629. logDone("build - add remote file without cache")
  2630. }
  2631. func TestBuildADDRemoteFileMTime(t *testing.T) {
  2632. name := "testbuildaddremotefilemtime"
  2633. name2 := name + "2"
  2634. name3 := name + "3"
  2635. name4 := name + "4"
  2636. defer deleteImages(name, name2, name3, name4)
  2637. files := map[string]string{"baz": "hello"}
  2638. server, err := fakeStorage(files)
  2639. if err != nil {
  2640. t.Fatal(err)
  2641. }
  2642. defer server.Close()
  2643. ctx, err := fakeContext(fmt.Sprintf(`FROM scratch
  2644. MAINTAINER dockerio
  2645. ADD %s/baz /usr/lib/baz/quux`, server.URL()), nil)
  2646. if err != nil {
  2647. t.Fatal(err)
  2648. }
  2649. defer ctx.Close()
  2650. id1, err := buildImageFromContext(name, ctx, true)
  2651. if err != nil {
  2652. t.Fatal(err)
  2653. }
  2654. id2, err := buildImageFromContext(name2, ctx, true)
  2655. if err != nil {
  2656. t.Fatal(err)
  2657. }
  2658. if id1 != id2 {
  2659. t.Fatal("The cache should have been used but wasn't - #1")
  2660. }
  2661. // Now create a different server withsame contents (causes different mtim)
  2662. // This time the cache should not be used
  2663. // allow some time for clock to pass as mtime precision is only 1s
  2664. time.Sleep(2 * time.Second)
  2665. server2, err := fakeStorage(files)
  2666. if err != nil {
  2667. t.Fatal(err)
  2668. }
  2669. defer server2.Close()
  2670. ctx2, err := fakeContext(fmt.Sprintf(`FROM scratch
  2671. MAINTAINER dockerio
  2672. ADD %s/baz /usr/lib/baz/quux`, server2.URL()), nil)
  2673. if err != nil {
  2674. t.Fatal(err)
  2675. }
  2676. defer ctx2.Close()
  2677. id3, err := buildImageFromContext(name3, ctx2, true)
  2678. if err != nil {
  2679. t.Fatal(err)
  2680. }
  2681. if id1 == id3 {
  2682. t.Fatal("The cache should not have been used but was")
  2683. }
  2684. // And for good measure do it again and make sure cache is used this time
  2685. id4, err := buildImageFromContext(name4, ctx2, true)
  2686. if err != nil {
  2687. t.Fatal(err)
  2688. }
  2689. if id3 != id4 {
  2690. t.Fatal("The cache should have been used but wasn't - #2")
  2691. }
  2692. logDone("build - add remote file testing mtime")
  2693. }
  2694. func TestBuildADDLocalAndRemoteFilesWithCache(t *testing.T) {
  2695. name := "testbuildaddlocalandremotefilewithcache"
  2696. defer deleteImages(name)
  2697. server, err := fakeStorage(map[string]string{
  2698. "baz": "hello",
  2699. })
  2700. if err != nil {
  2701. t.Fatal(err)
  2702. }
  2703. defer server.Close()
  2704. ctx, err := fakeContext(fmt.Sprintf(`FROM scratch
  2705. MAINTAINER dockerio
  2706. ADD foo /usr/lib/bla/bar
  2707. ADD %s/baz /usr/lib/baz/quux`, server.URL()),
  2708. map[string]string{
  2709. "foo": "hello world",
  2710. })
  2711. if err != nil {
  2712. t.Fatal(err)
  2713. }
  2714. defer ctx.Close()
  2715. id1, err := buildImageFromContext(name, ctx, true)
  2716. if err != nil {
  2717. t.Fatal(err)
  2718. }
  2719. id2, err := buildImageFromContext(name, ctx, true)
  2720. if err != nil {
  2721. t.Fatal(err)
  2722. }
  2723. if id1 != id2 {
  2724. t.Fatal("The cache should have been used but hasn't.")
  2725. }
  2726. logDone("build - add local and remote file with cache")
  2727. }
  2728. func testContextTar(t *testing.T, compression archive.Compression) {
  2729. ctx, err := fakeContext(
  2730. `FROM busybox
  2731. ADD foo /foo
  2732. CMD ["cat", "/foo"]`,
  2733. map[string]string{
  2734. "foo": "bar",
  2735. },
  2736. )
  2737. defer ctx.Close()
  2738. if err != nil {
  2739. t.Fatal(err)
  2740. }
  2741. context, err := archive.Tar(ctx.Dir, compression)
  2742. if err != nil {
  2743. t.Fatalf("failed to build context tar: %v", err)
  2744. }
  2745. name := "contexttar"
  2746. buildCmd := exec.Command(dockerBinary, "build", "-t", name, "-")
  2747. defer deleteImages(name)
  2748. buildCmd.Stdin = context
  2749. if out, _, err := runCommandWithOutput(buildCmd); err != nil {
  2750. t.Fatalf("build failed to complete: %v %v", out, err)
  2751. }
  2752. logDone(fmt.Sprintf("build - build an image with a context tar, compression: %v", compression))
  2753. }
  2754. func TestBuildContextTarGzip(t *testing.T) {
  2755. testContextTar(t, archive.Gzip)
  2756. }
  2757. func TestBuildContextTarNoCompression(t *testing.T) {
  2758. testContextTar(t, archive.Uncompressed)
  2759. }
  2760. func TestBuildNoContext(t *testing.T) {
  2761. buildCmd := exec.Command(dockerBinary, "build", "-t", "nocontext", "-")
  2762. buildCmd.Stdin = strings.NewReader("FROM busybox\nCMD echo ok\n")
  2763. if out, _, err := runCommandWithOutput(buildCmd); err != nil {
  2764. t.Fatalf("build failed to complete: %v %v", out, err)
  2765. }
  2766. if out, _, err := dockerCmd(t, "run", "--rm", "nocontext"); out != "ok\n" || err != nil {
  2767. t.Fatalf("run produced invalid output: %q, expected %q", out, "ok")
  2768. }
  2769. deleteImages("nocontext")
  2770. logDone("build - build an image with no context")
  2771. }
  2772. // TODO: TestCaching
  2773. func TestBuildADDLocalAndRemoteFilesWithoutCache(t *testing.T) {
  2774. name := "testbuildaddlocalandremotefilewithoutcache"
  2775. name2 := "testbuildaddlocalandremotefilewithoutcache2"
  2776. defer deleteImages(name, name2)
  2777. server, err := fakeStorage(map[string]string{
  2778. "baz": "hello",
  2779. })
  2780. if err != nil {
  2781. t.Fatal(err)
  2782. }
  2783. defer server.Close()
  2784. ctx, err := fakeContext(fmt.Sprintf(`FROM scratch
  2785. MAINTAINER dockerio
  2786. ADD foo /usr/lib/bla/bar
  2787. ADD %s/baz /usr/lib/baz/quux`, server.URL()),
  2788. map[string]string{
  2789. "foo": "hello world",
  2790. })
  2791. if err != nil {
  2792. t.Fatal(err)
  2793. }
  2794. defer ctx.Close()
  2795. id1, err := buildImageFromContext(name, ctx, true)
  2796. if err != nil {
  2797. t.Fatal(err)
  2798. }
  2799. id2, err := buildImageFromContext(name2, ctx, false)
  2800. if err != nil {
  2801. t.Fatal(err)
  2802. }
  2803. if id1 == id2 {
  2804. t.Fatal("The cache should have been invalided but hasn't.")
  2805. }
  2806. logDone("build - add local and remote file without cache")
  2807. }
  2808. func TestBuildWithVolumeOwnership(t *testing.T) {
  2809. name := "testbuildimg"
  2810. defer deleteImages(name)
  2811. _, err := buildImage(name,
  2812. `FROM busybox:latest
  2813. RUN mkdir /test && chown daemon:daemon /test && chmod 0600 /test
  2814. VOLUME /test`,
  2815. true)
  2816. if err != nil {
  2817. t.Fatal(err)
  2818. }
  2819. cmd := exec.Command(dockerBinary, "run", "--rm", "testbuildimg", "ls", "-la", "/test")
  2820. out, _, err := runCommandWithOutput(cmd)
  2821. if err != nil {
  2822. t.Fatal(out, err)
  2823. }
  2824. if expected := "drw-------"; !strings.Contains(out, expected) {
  2825. t.Fatalf("expected %s received %s", expected, out)
  2826. }
  2827. if expected := "daemon daemon"; !strings.Contains(out, expected) {
  2828. t.Fatalf("expected %s received %s", expected, out)
  2829. }
  2830. logDone("build - volume ownership")
  2831. }
  2832. // testing #1405 - config.Cmd does not get cleaned up if
  2833. // utilizing cache
  2834. func TestBuildEntrypointRunCleanup(t *testing.T) {
  2835. name := "testbuildcmdcleanup"
  2836. defer deleteImages(name)
  2837. if _, err := buildImage(name,
  2838. `FROM busybox
  2839. RUN echo "hello"`,
  2840. true); err != nil {
  2841. t.Fatal(err)
  2842. }
  2843. ctx, err := fakeContext(`FROM busybox
  2844. RUN echo "hello"
  2845. ADD foo /foo
  2846. ENTRYPOINT ["/bin/echo"]`,
  2847. map[string]string{
  2848. "foo": "hello",
  2849. })
  2850. defer ctx.Close()
  2851. if err != nil {
  2852. t.Fatal(err)
  2853. }
  2854. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  2855. t.Fatal(err)
  2856. }
  2857. res, err := inspectField(name, "Config.Cmd")
  2858. if err != nil {
  2859. t.Fatal(err)
  2860. }
  2861. // Cmd must be cleaned up
  2862. if expected := "<no value>"; res != expected {
  2863. t.Fatalf("Cmd %s, expected %s", res, expected)
  2864. }
  2865. logDone("build - cleanup cmd after RUN")
  2866. }
  2867. func TestBuildForbiddenContextPath(t *testing.T) {
  2868. name := "testbuildforbidpath"
  2869. defer deleteImages(name)
  2870. ctx, err := fakeContext(`FROM scratch
  2871. ADD ../../ test/
  2872. `,
  2873. map[string]string{
  2874. "test.txt": "test1",
  2875. "other.txt": "other",
  2876. })
  2877. defer ctx.Close()
  2878. if err != nil {
  2879. t.Fatal(err)
  2880. }
  2881. expected := "Forbidden path outside the build context: ../../ "
  2882. if _, err := buildImageFromContext(name, ctx, true); err == nil || !strings.Contains(err.Error(), expected) {
  2883. t.Fatalf("Wrong error: (should contain \"%s\") got:\n%v", expected, err)
  2884. }
  2885. logDone("build - forbidden context path")
  2886. }
  2887. func TestBuildADDFileNotFound(t *testing.T) {
  2888. name := "testbuildaddnotfound"
  2889. defer deleteImages(name)
  2890. ctx, err := fakeContext(`FROM scratch
  2891. ADD foo /usr/local/bar`,
  2892. map[string]string{"bar": "hello"})
  2893. defer ctx.Close()
  2894. if err != nil {
  2895. t.Fatal(err)
  2896. }
  2897. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  2898. if !strings.Contains(err.Error(), "foo: no such file or directory") {
  2899. t.Fatalf("Wrong error %v, must be about missing foo file or directory", err)
  2900. }
  2901. } else {
  2902. t.Fatal("Error must not be nil")
  2903. }
  2904. logDone("build - add file not found")
  2905. }
  2906. func TestBuildInheritance(t *testing.T) {
  2907. name := "testbuildinheritance"
  2908. defer deleteImages(name)
  2909. _, err := buildImage(name,
  2910. `FROM scratch
  2911. EXPOSE 2375`,
  2912. true)
  2913. if err != nil {
  2914. t.Fatal(err)
  2915. }
  2916. ports1, err := inspectField(name, "Config.ExposedPorts")
  2917. if err != nil {
  2918. t.Fatal(err)
  2919. }
  2920. _, err = buildImage(name,
  2921. fmt.Sprintf(`FROM %s
  2922. ENTRYPOINT ["/bin/echo"]`, name),
  2923. true)
  2924. if err != nil {
  2925. t.Fatal(err)
  2926. }
  2927. res, err := inspectField(name, "Config.Entrypoint")
  2928. if err != nil {
  2929. t.Fatal(err)
  2930. }
  2931. if expected := "[/bin/echo]"; res != expected {
  2932. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  2933. }
  2934. ports2, err := inspectField(name, "Config.ExposedPorts")
  2935. if err != nil {
  2936. t.Fatal(err)
  2937. }
  2938. if ports1 != ports2 {
  2939. t.Fatalf("Ports must be same: %s != %s", ports1, ports2)
  2940. }
  2941. logDone("build - inheritance")
  2942. }
  2943. func TestBuildFails(t *testing.T) {
  2944. name := "testbuildfails"
  2945. defer deleteImages(name)
  2946. defer deleteAllContainers()
  2947. _, err := buildImage(name,
  2948. `FROM busybox
  2949. RUN sh -c "exit 23"`,
  2950. true)
  2951. if err != nil {
  2952. if !strings.Contains(err.Error(), "returned a non-zero code: 23") {
  2953. t.Fatalf("Wrong error %v, must be about non-zero code 23", err)
  2954. }
  2955. } else {
  2956. t.Fatal("Error must not be nil")
  2957. }
  2958. logDone("build - unsuccessful")
  2959. }
  2960. func TestBuildFailsDockerfileEmpty(t *testing.T) {
  2961. name := "testbuildfails"
  2962. defer deleteImages(name)
  2963. _, err := buildImage(name, ``, true)
  2964. if err != nil {
  2965. if !strings.Contains(err.Error(), "Dockerfile cannot be empty") {
  2966. t.Fatalf("Wrong error %v, must be about empty Dockerfile", err)
  2967. }
  2968. } else {
  2969. t.Fatal("Error must not be nil")
  2970. }
  2971. logDone("build - unsuccessful with empty dockerfile")
  2972. }
  2973. func TestBuildOnBuild(t *testing.T) {
  2974. name := "testbuildonbuild"
  2975. defer deleteImages(name)
  2976. _, err := buildImage(name,
  2977. `FROM busybox
  2978. ONBUILD RUN touch foobar`,
  2979. true)
  2980. if err != nil {
  2981. t.Fatal(err)
  2982. }
  2983. _, err = buildImage(name,
  2984. fmt.Sprintf(`FROM %s
  2985. RUN [ -f foobar ]`, name),
  2986. true)
  2987. if err != nil {
  2988. t.Fatal(err)
  2989. }
  2990. logDone("build - onbuild")
  2991. }
  2992. func TestBuildOnBuildForbiddenChained(t *testing.T) {
  2993. name := "testbuildonbuildforbiddenchained"
  2994. defer deleteImages(name)
  2995. _, err := buildImage(name,
  2996. `FROM busybox
  2997. ONBUILD ONBUILD RUN touch foobar`,
  2998. true)
  2999. if err != nil {
  3000. if !strings.Contains(err.Error(), "Chaining ONBUILD via `ONBUILD ONBUILD` isn't allowed") {
  3001. t.Fatalf("Wrong error %v, must be about chaining ONBUILD", err)
  3002. }
  3003. } else {
  3004. t.Fatal("Error must not be nil")
  3005. }
  3006. logDone("build - onbuild forbidden chained")
  3007. }
  3008. func TestBuildOnBuildForbiddenFrom(t *testing.T) {
  3009. name := "testbuildonbuildforbiddenfrom"
  3010. defer deleteImages(name)
  3011. _, err := buildImage(name,
  3012. `FROM busybox
  3013. ONBUILD FROM scratch`,
  3014. true)
  3015. if err != nil {
  3016. if !strings.Contains(err.Error(), "FROM isn't allowed as an ONBUILD trigger") {
  3017. t.Fatalf("Wrong error %v, must be about FROM forbidden", err)
  3018. }
  3019. } else {
  3020. t.Fatal("Error must not be nil")
  3021. }
  3022. logDone("build - onbuild forbidden from")
  3023. }
  3024. func TestBuildOnBuildForbiddenMaintainer(t *testing.T) {
  3025. name := "testbuildonbuildforbiddenmaintainer"
  3026. defer deleteImages(name)
  3027. _, err := buildImage(name,
  3028. `FROM busybox
  3029. ONBUILD MAINTAINER docker.io`,
  3030. true)
  3031. if err != nil {
  3032. if !strings.Contains(err.Error(), "MAINTAINER isn't allowed as an ONBUILD trigger") {
  3033. t.Fatalf("Wrong error %v, must be about MAINTAINER forbidden", err)
  3034. }
  3035. } else {
  3036. t.Fatal("Error must not be nil")
  3037. }
  3038. logDone("build - onbuild forbidden maintainer")
  3039. }
  3040. // gh #2446
  3041. func TestBuildAddToSymlinkDest(t *testing.T) {
  3042. name := "testbuildaddtosymlinkdest"
  3043. defer deleteImages(name)
  3044. ctx, err := fakeContext(`FROM busybox
  3045. RUN mkdir /foo
  3046. RUN ln -s /foo /bar
  3047. ADD foo /bar/
  3048. RUN [ -f /bar/foo ]
  3049. RUN [ -f /foo/foo ]`,
  3050. map[string]string{
  3051. "foo": "hello",
  3052. })
  3053. if err != nil {
  3054. t.Fatal(err)
  3055. }
  3056. defer ctx.Close()
  3057. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  3058. t.Fatal(err)
  3059. }
  3060. logDone("build - add to symlink destination")
  3061. }
  3062. func TestBuildEscapeWhitespace(t *testing.T) {
  3063. name := "testbuildescaping"
  3064. defer deleteImages(name)
  3065. _, err := buildImage(name, `
  3066. FROM busybox
  3067. MAINTAINER "Docker \
  3068. IO <io@\
  3069. docker.com>"
  3070. `, true)
  3071. res, err := inspectField(name, "Author")
  3072. if err != nil {
  3073. t.Fatal(err)
  3074. }
  3075. if res != "\"Docker IO <io@docker.com>\"" {
  3076. t.Fatalf("Parsed string did not match the escaped string. Got: %q", res)
  3077. }
  3078. logDone("build - validate escaping whitespace")
  3079. }
  3080. func TestBuildVerifyIntString(t *testing.T) {
  3081. // Verify that strings that look like ints are still passed as strings
  3082. name := "testbuildstringing"
  3083. defer deleteImages(name)
  3084. _, err := buildImage(name, `
  3085. FROM busybox
  3086. MAINTAINER 123
  3087. `, true)
  3088. out, rc, err := runCommandWithOutput(exec.Command(dockerBinary, "inspect", name))
  3089. if rc != 0 || err != nil {
  3090. t.Fatalf("Unexcepted error from inspect: rc: %v err: %v", rc, err)
  3091. }
  3092. if !strings.Contains(out, "\"123\"") {
  3093. t.Fatalf("Output does not contain the int as a string:\n%s", out)
  3094. }
  3095. logDone("build - verify int/strings as strings")
  3096. }
  3097. func TestBuildDockerignore(t *testing.T) {
  3098. name := "testbuilddockerignore"
  3099. defer deleteImages(name)
  3100. dockerfile := `
  3101. FROM busybox
  3102. ADD . /bla
  3103. RUN [[ -f /bla/src/x.go ]]
  3104. RUN [[ -f /bla/Makefile ]]
  3105. RUN [[ ! -e /bla/src/_vendor ]]
  3106. RUN [[ ! -e /bla/.gitignore ]]
  3107. RUN [[ ! -e /bla/README.md ]]
  3108. RUN [[ ! -e /bla/.git ]]`
  3109. ctx, err := fakeContext(dockerfile, map[string]string{
  3110. "Makefile": "all:",
  3111. ".git/HEAD": "ref: foo",
  3112. "src/x.go": "package main",
  3113. "src/_vendor/v.go": "package main",
  3114. ".gitignore": "",
  3115. "README.md": "readme",
  3116. ".dockerignore": ".git\npkg\n.gitignore\nsrc/_vendor\n*.md",
  3117. })
  3118. defer ctx.Close()
  3119. if err != nil {
  3120. t.Fatal(err)
  3121. }
  3122. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  3123. t.Fatal(err)
  3124. }
  3125. logDone("build - test .dockerignore")
  3126. }
  3127. func TestBuildDockerignoreCleanPaths(t *testing.T) {
  3128. name := "testbuilddockerignorecleanpaths"
  3129. defer deleteImages(name)
  3130. dockerfile := `
  3131. FROM busybox
  3132. ADD . /tmp/
  3133. RUN (! ls /tmp/foo) && (! ls /tmp/foo2) && (! ls /tmp/dir1/foo)`
  3134. ctx, err := fakeContext(dockerfile, map[string]string{
  3135. "foo": "foo",
  3136. "foo2": "foo2",
  3137. "dir1/foo": "foo in dir1",
  3138. ".dockerignore": "./foo\ndir1//foo\n./dir1/../foo2",
  3139. })
  3140. if err != nil {
  3141. t.Fatal(err)
  3142. }
  3143. defer ctx.Close()
  3144. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  3145. t.Fatal(err)
  3146. }
  3147. logDone("build - test .dockerignore with clean paths")
  3148. }
  3149. func TestBuildDockerignoringDockerfile(t *testing.T) {
  3150. name := "testbuilddockerignoredockerfile"
  3151. defer deleteImages(name)
  3152. dockerfile := `
  3153. FROM busybox
  3154. ADD . /tmp/
  3155. RUN ! ls /tmp/Dockerfile
  3156. RUN ls /tmp/.dockerignore`
  3157. ctx, err := fakeContext(dockerfile, map[string]string{
  3158. "Dockerfile": dockerfile,
  3159. ".dockerignore": "Dockerfile\n",
  3160. })
  3161. if err != nil {
  3162. t.Fatal(err)
  3163. }
  3164. defer ctx.Close()
  3165. if _, err = buildImageFromContext(name, ctx, true); err != nil {
  3166. t.Fatalf("Didn't ignore Dockerfile correctly:%s", err)
  3167. }
  3168. // now try it with ./Dockerfile
  3169. ctx.Add(".dockerignore", "./Dockerfile\n")
  3170. if _, err = buildImageFromContext(name, ctx, true); err != nil {
  3171. t.Fatalf("Didn't ignore ./Dockerfile correctly:%s", err)
  3172. }
  3173. logDone("build - test .dockerignore of Dockerfile")
  3174. }
  3175. func TestBuildDockerignoringRenamedDockerfile(t *testing.T) {
  3176. name := "testbuilddockerignoredockerfile"
  3177. defer deleteImages(name)
  3178. dockerfile := `
  3179. FROM busybox
  3180. ADD . /tmp/
  3181. RUN ls /tmp/Dockerfile
  3182. RUN ! ls /tmp/MyDockerfile
  3183. RUN ls /tmp/.dockerignore`
  3184. ctx, err := fakeContext(dockerfile, map[string]string{
  3185. "Dockerfile": "Should not use me",
  3186. "MyDockerfile": dockerfile,
  3187. ".dockerignore": "MyDockerfile\n",
  3188. })
  3189. if err != nil {
  3190. t.Fatal(err)
  3191. }
  3192. defer ctx.Close()
  3193. if _, err = buildImageFromContext(name, ctx, true); err != nil {
  3194. t.Fatalf("Didn't ignore MyDockerfile correctly:%s", err)
  3195. }
  3196. // now try it with ./MyDockerfile
  3197. ctx.Add(".dockerignore", "./MyDockerfile\n")
  3198. if _, err = buildImageFromContext(name, ctx, true); err != nil {
  3199. t.Fatalf("Didn't ignore ./MyDockerfile correctly:%s", err)
  3200. }
  3201. logDone("build - test .dockerignore of renamed Dockerfile")
  3202. }
  3203. func TestBuildDockerignoringDockerignore(t *testing.T) {
  3204. name := "testbuilddockerignoredockerignore"
  3205. defer deleteImages(name)
  3206. dockerfile := `
  3207. FROM busybox
  3208. ADD . /tmp/
  3209. RUN ! ls /tmp/.dockerignore
  3210. RUN ls /tmp/Dockerfile`
  3211. ctx, err := fakeContext(dockerfile, map[string]string{
  3212. "Dockerfile": dockerfile,
  3213. ".dockerignore": ".dockerignore\n",
  3214. })
  3215. defer ctx.Close()
  3216. if err != nil {
  3217. t.Fatal(err)
  3218. }
  3219. if _, err = buildImageFromContext(name, ctx, true); err != nil {
  3220. t.Fatalf("Didn't ignore .dockerignore correctly:%s", err)
  3221. }
  3222. logDone("build - test .dockerignore of .dockerignore")
  3223. }
  3224. func TestBuildDockerignoreTouchDockerfile(t *testing.T) {
  3225. var id1 string
  3226. var id2 string
  3227. name := "testbuilddockerignoretouchdockerfile"
  3228. defer deleteImages(name)
  3229. dockerfile := `
  3230. FROM busybox
  3231. ADD . /tmp/`
  3232. ctx, err := fakeContext(dockerfile, map[string]string{
  3233. "Dockerfile": dockerfile,
  3234. ".dockerignore": "Dockerfile\n",
  3235. })
  3236. defer ctx.Close()
  3237. if err != nil {
  3238. t.Fatal(err)
  3239. }
  3240. if id1, err = buildImageFromContext(name, ctx, true); err != nil {
  3241. t.Fatalf("Didn't build it correctly:%s", err)
  3242. }
  3243. if id2, err = buildImageFromContext(name, ctx, true); err != nil {
  3244. t.Fatalf("Didn't build it correctly:%s", err)
  3245. }
  3246. if id1 != id2 {
  3247. t.Fatalf("Didn't use the cache - 1")
  3248. }
  3249. // Now make sure touching Dockerfile doesn't invalidate the cache
  3250. if err = ctx.Add("Dockerfile", dockerfile+"\n# hi"); err != nil {
  3251. t.Fatalf("Didn't add Dockerfile: %s", err)
  3252. }
  3253. if id2, err = buildImageFromContext(name, ctx, true); err != nil {
  3254. t.Fatalf("Didn't build it correctly:%s", err)
  3255. }
  3256. if id1 != id2 {
  3257. t.Fatalf("Didn't use the cache - 2")
  3258. }
  3259. // One more time but just 'touch' it instead of changing the content
  3260. if err = ctx.Add("Dockerfile", dockerfile+"\n# hi"); err != nil {
  3261. t.Fatalf("Didn't add Dockerfile: %s", err)
  3262. }
  3263. if id2, err = buildImageFromContext(name, ctx, true); err != nil {
  3264. t.Fatalf("Didn't build it correctly:%s", err)
  3265. }
  3266. if id1 != id2 {
  3267. t.Fatalf("Didn't use the cache - 3")
  3268. }
  3269. logDone("build - test .dockerignore touch dockerfile")
  3270. }
  3271. func TestBuildDockerignoringWholeDir(t *testing.T) {
  3272. name := "testbuilddockerignorewholedir"
  3273. defer deleteImages(name)
  3274. dockerfile := `
  3275. FROM busybox
  3276. COPY . /
  3277. RUN [[ ! -e /.gitignore ]]
  3278. RUN [[ -f /Makefile ]]`
  3279. ctx, err := fakeContext(dockerfile, map[string]string{
  3280. "Dockerfile": "FROM scratch",
  3281. "Makefile": "all:",
  3282. ".dockerignore": ".*\n",
  3283. })
  3284. defer ctx.Close()
  3285. if err != nil {
  3286. t.Fatal(err)
  3287. }
  3288. if _, err = buildImageFromContext(name, ctx, true); err != nil {
  3289. t.Fatal(err)
  3290. }
  3291. logDone("build - test .dockerignore whole dir with .*")
  3292. }
  3293. func TestBuildLineBreak(t *testing.T) {
  3294. name := "testbuildlinebreak"
  3295. defer deleteImages(name)
  3296. _, err := buildImage(name,
  3297. `FROM busybox
  3298. RUN sh -c 'echo root:testpass \
  3299. > /tmp/passwd'
  3300. RUN mkdir -p /var/run/sshd
  3301. RUN [ "$(cat /tmp/passwd)" = "root:testpass" ]
  3302. RUN [ "$(ls -d /var/run/sshd)" = "/var/run/sshd" ]`,
  3303. true)
  3304. if err != nil {
  3305. t.Fatal(err)
  3306. }
  3307. logDone("build - line break with \\")
  3308. }
  3309. func TestBuildEOLInLine(t *testing.T) {
  3310. name := "testbuildeolinline"
  3311. defer deleteImages(name)
  3312. _, err := buildImage(name,
  3313. `FROM busybox
  3314. RUN sh -c 'echo root:testpass > /tmp/passwd'
  3315. RUN echo "foo \n bar"; echo "baz"
  3316. RUN mkdir -p /var/run/sshd
  3317. RUN [ "$(cat /tmp/passwd)" = "root:testpass" ]
  3318. RUN [ "$(ls -d /var/run/sshd)" = "/var/run/sshd" ]`,
  3319. true)
  3320. if err != nil {
  3321. t.Fatal(err)
  3322. }
  3323. logDone("build - end of line in dockerfile instruction")
  3324. }
  3325. func TestBuildCommentsShebangs(t *testing.T) {
  3326. name := "testbuildcomments"
  3327. defer deleteImages(name)
  3328. _, err := buildImage(name,
  3329. `FROM busybox
  3330. # This is an ordinary comment.
  3331. RUN { echo '#!/bin/sh'; echo 'echo hello world'; } > /hello.sh
  3332. RUN [ ! -x /hello.sh ]
  3333. # comment with line break \
  3334. RUN chmod +x /hello.sh
  3335. RUN [ -x /hello.sh ]
  3336. RUN [ "$(cat /hello.sh)" = $'#!/bin/sh\necho hello world' ]
  3337. RUN [ "$(/hello.sh)" = "hello world" ]`,
  3338. true)
  3339. if err != nil {
  3340. t.Fatal(err)
  3341. }
  3342. logDone("build - comments and shebangs")
  3343. }
  3344. func TestBuildUsersAndGroups(t *testing.T) {
  3345. name := "testbuildusers"
  3346. defer deleteImages(name)
  3347. _, err := buildImage(name,
  3348. `FROM busybox
  3349. # Make sure our defaults work
  3350. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)" = '0:0/root:root' ]
  3351. # TODO decide if "args.user = strconv.Itoa(syscall.Getuid())" is acceptable behavior for changeUser in sysvinit instead of "return nil" when "USER" isn't specified (so that we get the proper group list even if that is the empty list, even in the default case of not supplying an explicit USER to run as, which implies USER 0)
  3352. USER root
  3353. RUN [ "$(id -G):$(id -Gn)" = '0 10:root wheel' ]
  3354. # Setup dockerio user and group
  3355. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  3356. RUN echo 'dockerio:x:1001:' >> /etc/group
  3357. # Make sure we can switch to our user and all the information is exactly as we expect it to be
  3358. USER dockerio
  3359. RUN id -G
  3360. RUN id -Gn
  3361. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  3362. # Switch back to root and double check that worked exactly as we might expect it to
  3363. USER root
  3364. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '0:0/root:root/0 10:root wheel' ]
  3365. # Add a "supplementary" group for our dockerio user
  3366. RUN echo 'supplementary:x:1002:dockerio' >> /etc/group
  3367. # ... and then go verify that we get it like we expect
  3368. USER dockerio
  3369. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001 1002:dockerio supplementary' ]
  3370. USER 1001
  3371. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001 1002:dockerio supplementary' ]
  3372. # super test the new "user:group" syntax
  3373. USER dockerio:dockerio
  3374. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  3375. USER 1001:dockerio
  3376. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  3377. USER dockerio:1001
  3378. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  3379. USER 1001:1001
  3380. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  3381. USER dockerio:supplementary
  3382. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1002/dockerio:supplementary/1002:supplementary' ]
  3383. USER dockerio:1002
  3384. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1002/dockerio:supplementary/1002:supplementary' ]
  3385. USER 1001:supplementary
  3386. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1002/dockerio:supplementary/1002:supplementary' ]
  3387. USER 1001:1002
  3388. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1002/dockerio:supplementary/1002:supplementary' ]
  3389. # make sure unknown uid/gid still works properly
  3390. USER 1042:1043
  3391. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1042:1043/1042:1043/1043:1043' ]`,
  3392. true)
  3393. if err != nil {
  3394. t.Fatal(err)
  3395. }
  3396. logDone("build - users and groups")
  3397. }
  3398. func TestBuildEnvUsage(t *testing.T) {
  3399. name := "testbuildenvusage"
  3400. defer deleteImages(name)
  3401. dockerfile := `FROM busybox
  3402. ENV HOME /root
  3403. ENV PATH $HOME/bin:$PATH
  3404. ENV PATH /tmp:$PATH
  3405. RUN [ "$PATH" = "/tmp:$HOME/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" ]
  3406. ENV FOO /foo/baz
  3407. ENV BAR /bar
  3408. ENV BAZ $BAR
  3409. ENV FOOPATH $PATH:$FOO
  3410. RUN [ "$BAR" = "$BAZ" ]
  3411. RUN [ "$FOOPATH" = "$PATH:/foo/baz" ]
  3412. ENV FROM hello/docker/world
  3413. ENV TO /docker/world/hello
  3414. ADD $FROM $TO
  3415. RUN [ "$(cat $TO)" = "hello" ]
  3416. ENV abc=def
  3417. ENV ghi=$abc
  3418. RUN [ "$ghi" = "def" ]
  3419. `
  3420. ctx, err := fakeContext(dockerfile, map[string]string{
  3421. "hello/docker/world": "hello",
  3422. })
  3423. if err != nil {
  3424. t.Fatal(err)
  3425. }
  3426. defer ctx.Close()
  3427. _, err = buildImageFromContext(name, ctx, true)
  3428. if err != nil {
  3429. t.Fatal(err)
  3430. }
  3431. logDone("build - environment variables usage")
  3432. }
  3433. func TestBuildEnvUsage2(t *testing.T) {
  3434. name := "testbuildenvusage2"
  3435. defer deleteImages(name)
  3436. dockerfile := `FROM busybox
  3437. ENV abc=def
  3438. RUN [ "$abc" = "def" ]
  3439. ENV def="hello world"
  3440. RUN [ "$def" = "hello world" ]
  3441. ENV def=hello\ world
  3442. RUN [ "$def" = "hello world" ]
  3443. ENV v1=abc v2="hi there"
  3444. RUN [ "$v1" = "abc" ]
  3445. RUN [ "$v2" = "hi there" ]
  3446. ENV v3='boogie nights' v4="with'quotes too"
  3447. RUN [ "$v3" = "boogie nights" ]
  3448. RUN [ "$v4" = "with'quotes too" ]
  3449. ENV abc=zzz FROM=hello/docker/world
  3450. ENV abc=zzz TO=/docker/world/hello
  3451. ADD $FROM $TO
  3452. RUN [ "$(cat $TO)" = "hello" ]
  3453. ENV abc "zzz"
  3454. RUN [ $abc = "zzz" ]
  3455. ENV abc 'yyy'
  3456. RUN [ $abc = 'yyy' ]
  3457. ENV abc=
  3458. RUN [ "$abc" = "" ]
  3459. # use grep to make sure if the builder substitutes \$foo by mistake
  3460. # we don't get a false positive
  3461. ENV abc=\$foo
  3462. RUN [ "$abc" = "\$foo" ] && (echo "$abc" | grep foo)
  3463. ENV abc \$foo
  3464. RUN [ "$abc" = "\$foo" ] && (echo "$abc" | grep foo)
  3465. ENV abc=\'foo\'
  3466. RUN [ "$abc" = "'foo'" ]
  3467. ENV abc=\"foo\"
  3468. RUN [ "$abc" = "\"foo\"" ]
  3469. ENV abc "foo"
  3470. RUN [ "$abc" = "foo" ]
  3471. ENV abc 'foo'
  3472. RUN [ "$abc" = 'foo' ]
  3473. ENV abc \'foo\'
  3474. RUN [ "$abc" = "'foo'" ]
  3475. ENV abc \"foo\"
  3476. RUN [ "$abc" = '"foo"' ]
  3477. ENV e1=bar
  3478. ENV e2=$e1
  3479. ENV e3=$e11
  3480. ENV e4=\$e1
  3481. ENV e5=\$e11
  3482. RUN [ "$e0,$e1,$e2,$e3,$e4,$e5" = ',bar,bar,,$e1,$e11' ]
  3483. ENV ee1 bar
  3484. ENV ee2 $ee1
  3485. ENV ee3 $ee11
  3486. ENV ee4 \$ee1
  3487. ENV ee5 \$ee11
  3488. RUN [ "$ee1,$ee2,$ee3,$ee4,$ee5" = 'bar,bar,,$ee1,$ee11' ]
  3489. ENV eee1="foo"
  3490. ENV eee2='foo'
  3491. ENV eee3 "foo"
  3492. ENV eee4 'foo'
  3493. RUN [ "$eee1,$eee2,$eee3,$eee4" = 'foo,foo,foo,foo' ]
  3494. `
  3495. ctx, err := fakeContext(dockerfile, map[string]string{
  3496. "hello/docker/world": "hello",
  3497. })
  3498. if err != nil {
  3499. t.Fatal(err)
  3500. }
  3501. defer ctx.Close()
  3502. _, err = buildImageFromContext(name, ctx, true)
  3503. if err != nil {
  3504. t.Fatal(err)
  3505. }
  3506. logDone("build - environment variables usage2")
  3507. }
  3508. func TestBuildAddScript(t *testing.T) {
  3509. name := "testbuildaddscript"
  3510. defer deleteImages(name)
  3511. dockerfile := `
  3512. FROM busybox
  3513. ADD test /test
  3514. RUN ["chmod","+x","/test"]
  3515. RUN ["/test"]
  3516. RUN [ "$(cat /testfile)" = 'test!' ]`
  3517. ctx, err := fakeContext(dockerfile, map[string]string{
  3518. "test": "#!/bin/sh\necho 'test!' > /testfile",
  3519. })
  3520. if err != nil {
  3521. t.Fatal(err)
  3522. }
  3523. defer ctx.Close()
  3524. _, err = buildImageFromContext(name, ctx, true)
  3525. if err != nil {
  3526. t.Fatal(err)
  3527. }
  3528. logDone("build - add and run script")
  3529. }
  3530. func TestBuildAddTar(t *testing.T) {
  3531. name := "testbuildaddtar"
  3532. defer deleteImages(name)
  3533. ctx := func() *FakeContext {
  3534. dockerfile := `
  3535. FROM busybox
  3536. ADD test.tar /
  3537. RUN cat /test/foo | grep Hi
  3538. ADD test.tar /test.tar
  3539. RUN cat /test.tar/test/foo | grep Hi
  3540. ADD test.tar /unlikely-to-exist
  3541. RUN cat /unlikely-to-exist/test/foo | grep Hi
  3542. ADD test.tar /unlikely-to-exist-trailing-slash/
  3543. RUN cat /unlikely-to-exist-trailing-slash/test/foo | grep Hi
  3544. RUN mkdir /existing-directory
  3545. ADD test.tar /existing-directory
  3546. RUN cat /existing-directory/test/foo | grep Hi
  3547. ADD test.tar /existing-directory-trailing-slash/
  3548. RUN cat /existing-directory-trailing-slash/test/foo | grep Hi`
  3549. tmpDir, err := ioutil.TempDir("", "fake-context")
  3550. testTar, err := os.Create(filepath.Join(tmpDir, "test.tar"))
  3551. if err != nil {
  3552. t.Fatalf("failed to create test.tar archive: %v", err)
  3553. }
  3554. defer testTar.Close()
  3555. tw := tar.NewWriter(testTar)
  3556. if err := tw.WriteHeader(&tar.Header{
  3557. Name: "test/foo",
  3558. Size: 2,
  3559. }); err != nil {
  3560. t.Fatalf("failed to write tar file header: %v", err)
  3561. }
  3562. if _, err := tw.Write([]byte("Hi")); err != nil {
  3563. t.Fatalf("failed to write tar file content: %v", err)
  3564. }
  3565. if err := tw.Close(); err != nil {
  3566. t.Fatalf("failed to close tar archive: %v", err)
  3567. }
  3568. if err := ioutil.WriteFile(filepath.Join(tmpDir, "Dockerfile"), []byte(dockerfile), 0644); err != nil {
  3569. t.Fatalf("failed to open destination dockerfile: %v", err)
  3570. }
  3571. return fakeContextFromDir(tmpDir)
  3572. }()
  3573. defer ctx.Close()
  3574. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  3575. t.Fatalf("build failed to complete for TestBuildAddTar: %v", err)
  3576. }
  3577. logDone("build - ADD tar")
  3578. }
  3579. func TestBuildAddTarXz(t *testing.T) {
  3580. name := "testbuildaddtarxz"
  3581. defer deleteImages(name)
  3582. ctx := func() *FakeContext {
  3583. dockerfile := `
  3584. FROM busybox
  3585. ADD test.tar.xz /
  3586. RUN cat /test/foo | grep Hi`
  3587. tmpDir, err := ioutil.TempDir("", "fake-context")
  3588. testTar, err := os.Create(filepath.Join(tmpDir, "test.tar"))
  3589. if err != nil {
  3590. t.Fatalf("failed to create test.tar archive: %v", err)
  3591. }
  3592. defer testTar.Close()
  3593. tw := tar.NewWriter(testTar)
  3594. if err := tw.WriteHeader(&tar.Header{
  3595. Name: "test/foo",
  3596. Size: 2,
  3597. }); err != nil {
  3598. t.Fatalf("failed to write tar file header: %v", err)
  3599. }
  3600. if _, err := tw.Write([]byte("Hi")); err != nil {
  3601. t.Fatalf("failed to write tar file content: %v", err)
  3602. }
  3603. if err := tw.Close(); err != nil {
  3604. t.Fatalf("failed to close tar archive: %v", err)
  3605. }
  3606. xzCompressCmd := exec.Command("xz", "-k", "test.tar")
  3607. xzCompressCmd.Dir = tmpDir
  3608. out, _, err := runCommandWithOutput(xzCompressCmd)
  3609. if err != nil {
  3610. t.Fatal(err, out)
  3611. }
  3612. if err := ioutil.WriteFile(filepath.Join(tmpDir, "Dockerfile"), []byte(dockerfile), 0644); err != nil {
  3613. t.Fatalf("failed to open destination dockerfile: %v", err)
  3614. }
  3615. return fakeContextFromDir(tmpDir)
  3616. }()
  3617. defer ctx.Close()
  3618. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  3619. t.Fatalf("build failed to complete for TestBuildAddTarXz: %v", err)
  3620. }
  3621. logDone("build - ADD tar.xz")
  3622. }
  3623. func TestBuildAddTarXzGz(t *testing.T) {
  3624. name := "testbuildaddtarxzgz"
  3625. defer deleteImages(name)
  3626. ctx := func() *FakeContext {
  3627. dockerfile := `
  3628. FROM busybox
  3629. ADD test.tar.xz.gz /
  3630. RUN ls /test.tar.xz.gz`
  3631. tmpDir, err := ioutil.TempDir("", "fake-context")
  3632. testTar, err := os.Create(filepath.Join(tmpDir, "test.tar"))
  3633. if err != nil {
  3634. t.Fatalf("failed to create test.tar archive: %v", err)
  3635. }
  3636. defer testTar.Close()
  3637. tw := tar.NewWriter(testTar)
  3638. if err := tw.WriteHeader(&tar.Header{
  3639. Name: "test/foo",
  3640. Size: 2,
  3641. }); err != nil {
  3642. t.Fatalf("failed to write tar file header: %v", err)
  3643. }
  3644. if _, err := tw.Write([]byte("Hi")); err != nil {
  3645. t.Fatalf("failed to write tar file content: %v", err)
  3646. }
  3647. if err := tw.Close(); err != nil {
  3648. t.Fatalf("failed to close tar archive: %v", err)
  3649. }
  3650. xzCompressCmd := exec.Command("xz", "-k", "test.tar")
  3651. xzCompressCmd.Dir = tmpDir
  3652. out, _, err := runCommandWithOutput(xzCompressCmd)
  3653. if err != nil {
  3654. t.Fatal(err, out)
  3655. }
  3656. gzipCompressCmd := exec.Command("gzip", "test.tar.xz")
  3657. gzipCompressCmd.Dir = tmpDir
  3658. out, _, err = runCommandWithOutput(gzipCompressCmd)
  3659. if err != nil {
  3660. t.Fatal(err, out)
  3661. }
  3662. if err := ioutil.WriteFile(filepath.Join(tmpDir, "Dockerfile"), []byte(dockerfile), 0644); err != nil {
  3663. t.Fatalf("failed to open destination dockerfile: %v", err)
  3664. }
  3665. return fakeContextFromDir(tmpDir)
  3666. }()
  3667. defer ctx.Close()
  3668. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  3669. t.Fatalf("build failed to complete for TestBuildAddTarXz: %v", err)
  3670. }
  3671. logDone("build - ADD tar.xz.gz")
  3672. }
  3673. func TestBuildFromGIT(t *testing.T) {
  3674. name := "testbuildfromgit"
  3675. defer deleteImages(name)
  3676. git, err := fakeGIT("repo", map[string]string{
  3677. "Dockerfile": `FROM busybox
  3678. ADD first /first
  3679. RUN [ -f /first ]
  3680. MAINTAINER docker`,
  3681. "first": "test git data",
  3682. }, true)
  3683. if err != nil {
  3684. t.Fatal(err)
  3685. }
  3686. defer git.Close()
  3687. _, err = buildImageFromPath(name, git.RepoURL, true)
  3688. if err != nil {
  3689. t.Fatal(err)
  3690. }
  3691. res, err := inspectField(name, "Author")
  3692. if err != nil {
  3693. t.Fatal(err)
  3694. }
  3695. if res != "docker" {
  3696. t.Fatalf("Maintainer should be docker, got %s", res)
  3697. }
  3698. logDone("build - build from GIT")
  3699. }
  3700. func TestBuildCleanupCmdOnEntrypoint(t *testing.T) {
  3701. name := "testbuildcmdcleanuponentrypoint"
  3702. defer deleteImages(name)
  3703. if _, err := buildImage(name,
  3704. `FROM scratch
  3705. CMD ["test"]
  3706. ENTRYPOINT ["echo"]`,
  3707. true); err != nil {
  3708. t.Fatal(err)
  3709. }
  3710. if _, err := buildImage(name,
  3711. fmt.Sprintf(`FROM %s
  3712. ENTRYPOINT ["cat"]`, name),
  3713. true); err != nil {
  3714. t.Fatal(err)
  3715. }
  3716. res, err := inspectField(name, "Config.Cmd")
  3717. if err != nil {
  3718. t.Fatal(err)
  3719. }
  3720. if expected := "<no value>"; res != expected {
  3721. t.Fatalf("Cmd %s, expected %s", res, expected)
  3722. }
  3723. res, err = inspectField(name, "Config.Entrypoint")
  3724. if err != nil {
  3725. t.Fatal(err)
  3726. }
  3727. if expected := "[cat]"; res != expected {
  3728. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  3729. }
  3730. logDone("build - cleanup cmd on ENTRYPOINT")
  3731. }
  3732. func TestBuildClearCmd(t *testing.T) {
  3733. name := "testbuildclearcmd"
  3734. defer deleteImages(name)
  3735. _, err := buildImage(name,
  3736. `From scratch
  3737. ENTRYPOINT ["/bin/bash"]
  3738. CMD []`,
  3739. true)
  3740. if err != nil {
  3741. t.Fatal(err)
  3742. }
  3743. res, err := inspectFieldJSON(name, "Config.Cmd")
  3744. if err != nil {
  3745. t.Fatal(err)
  3746. }
  3747. if res != "[]" {
  3748. t.Fatalf("Cmd %s, expected %s", res, "[]")
  3749. }
  3750. logDone("build - clearcmd")
  3751. }
  3752. func TestBuildEmptyCmd(t *testing.T) {
  3753. name := "testbuildemptycmd"
  3754. defer deleteImages(name)
  3755. if _, err := buildImage(name, "FROM scratch\nMAINTAINER quux\n", true); err != nil {
  3756. t.Fatal(err)
  3757. }
  3758. res, err := inspectFieldJSON(name, "Config.Cmd")
  3759. if err != nil {
  3760. t.Fatal(err)
  3761. }
  3762. if res != "null" {
  3763. t.Fatalf("Cmd %s, expected %s", res, "null")
  3764. }
  3765. logDone("build - empty cmd")
  3766. }
  3767. func TestBuildOnBuildOutput(t *testing.T) {
  3768. name := "testbuildonbuildparent"
  3769. defer deleteImages(name)
  3770. if _, err := buildImage(name, "FROM busybox\nONBUILD RUN echo foo\n", true); err != nil {
  3771. t.Fatal(err)
  3772. }
  3773. childname := "testbuildonbuildchild"
  3774. defer deleteImages(childname)
  3775. _, out, err := buildImageWithOut(name, "FROM "+name+"\nMAINTAINER quux\n", true)
  3776. if err != nil {
  3777. t.Fatal(err)
  3778. }
  3779. if !strings.Contains(out, "Trigger 0, RUN echo foo") {
  3780. t.Fatal("failed to find the ONBUILD output", out)
  3781. }
  3782. logDone("build - onbuild output")
  3783. }
  3784. func TestBuildInvalidTag(t *testing.T) {
  3785. name := "abcd:" + makeRandomString(200)
  3786. defer deleteImages(name)
  3787. _, out, err := buildImageWithOut(name, "FROM scratch\nMAINTAINER quux\n", true)
  3788. // if the error doesnt check for illegal tag name, or the image is built
  3789. // then this should fail
  3790. if !strings.Contains(out, "Illegal tag name") || strings.Contains(out, "Sending build context to Docker daemon") {
  3791. t.Fatalf("failed to stop before building. Error: %s, Output: %s", err, out)
  3792. }
  3793. logDone("build - invalid tag")
  3794. }
  3795. func TestBuildCmdShDashC(t *testing.T) {
  3796. name := "testbuildcmdshc"
  3797. defer deleteImages(name)
  3798. if _, err := buildImage(name, "FROM busybox\nCMD echo cmd\n", true); err != nil {
  3799. t.Fatal(err)
  3800. }
  3801. res, err := inspectFieldJSON(name, "Config.Cmd")
  3802. if err != nil {
  3803. t.Fatal(err, res)
  3804. }
  3805. expected := `["/bin/sh","-c","echo cmd"]`
  3806. if res != expected {
  3807. t.Fatalf("Expected value %s not in Config.Cmd: %s", expected, res)
  3808. }
  3809. logDone("build - cmd should have sh -c for non-json")
  3810. }
  3811. func TestBuildCmdSpaces(t *testing.T) {
  3812. // Test to make sure that when we strcat arrays we take into account
  3813. // the arg separator to make sure ["echo","hi"] and ["echo hi"] don't
  3814. // look the same
  3815. name := "testbuildcmdspaces"
  3816. defer deleteImages(name)
  3817. var id1 string
  3818. var id2 string
  3819. var err error
  3820. if id1, err = buildImage(name, "FROM busybox\nCMD [\"echo hi\"]\n", true); err != nil {
  3821. t.Fatal(err)
  3822. }
  3823. if id2, err = buildImage(name, "FROM busybox\nCMD [\"echo\", \"hi\"]\n", true); err != nil {
  3824. t.Fatal(err)
  3825. }
  3826. if id1 == id2 {
  3827. t.Fatal("Should not have resulted in the same CMD")
  3828. }
  3829. // Now do the same with ENTRYPOINT
  3830. if id1, err = buildImage(name, "FROM busybox\nENTRYPOINT [\"echo hi\"]\n", true); err != nil {
  3831. t.Fatal(err)
  3832. }
  3833. if id2, err = buildImage(name, "FROM busybox\nENTRYPOINT [\"echo\", \"hi\"]\n", true); err != nil {
  3834. t.Fatal(err)
  3835. }
  3836. if id1 == id2 {
  3837. t.Fatal("Should not have resulted in the same ENTRYPOINT")
  3838. }
  3839. logDone("build - cmd with spaces")
  3840. }
  3841. func TestBuildCmdJSONNoShDashC(t *testing.T) {
  3842. name := "testbuildcmdjson"
  3843. defer deleteImages(name)
  3844. if _, err := buildImage(name, "FROM busybox\nCMD [\"echo\", \"cmd\"]", true); err != nil {
  3845. t.Fatal(err)
  3846. }
  3847. res, err := inspectFieldJSON(name, "Config.Cmd")
  3848. if err != nil {
  3849. t.Fatal(err, res)
  3850. }
  3851. expected := `["echo","cmd"]`
  3852. if res != expected {
  3853. t.Fatalf("Expected value %s not in Config.Cmd: %s", expected, res)
  3854. }
  3855. logDone("build - cmd should not have /bin/sh -c for json")
  3856. }
  3857. func TestBuildErrorInvalidInstruction(t *testing.T) {
  3858. name := "testbuildignoreinvalidinstruction"
  3859. defer deleteImages(name)
  3860. out, _, err := buildImageWithOut(name, "FROM busybox\nfoo bar", true)
  3861. if err == nil {
  3862. t.Fatalf("Should have failed: %s", out)
  3863. }
  3864. logDone("build - error invalid Dockerfile instruction")
  3865. }
  3866. func TestBuildEntrypointInheritance(t *testing.T) {
  3867. defer deleteImages("parent", "child")
  3868. defer deleteAllContainers()
  3869. if _, err := buildImage("parent", `
  3870. FROM busybox
  3871. ENTRYPOINT exit 130
  3872. `, true); err != nil {
  3873. t.Fatal(err)
  3874. }
  3875. status, _ := runCommand(exec.Command(dockerBinary, "run", "parent"))
  3876. if status != 130 {
  3877. t.Fatalf("expected exit code 130 but received %d", status)
  3878. }
  3879. if _, err := buildImage("child", `
  3880. FROM parent
  3881. ENTRYPOINT exit 5
  3882. `, true); err != nil {
  3883. t.Fatal(err)
  3884. }
  3885. status, _ = runCommand(exec.Command(dockerBinary, "run", "child"))
  3886. if status != 5 {
  3887. t.Fatalf("expected exit code 5 but received %d", status)
  3888. }
  3889. logDone("build - clear entrypoint")
  3890. }
  3891. func TestBuildEntrypointInheritanceInspect(t *testing.T) {
  3892. var (
  3893. name = "testbuildepinherit"
  3894. name2 = "testbuildepinherit2"
  3895. expected = `["/bin/sh","-c","echo quux"]`
  3896. )
  3897. defer deleteImages(name, name2)
  3898. defer deleteAllContainers()
  3899. if _, err := buildImage(name, "FROM busybox\nENTRYPOINT /foo/bar", true); err != nil {
  3900. t.Fatal(err)
  3901. }
  3902. if _, err := buildImage(name2, fmt.Sprintf("FROM %s\nENTRYPOINT echo quux", name), true); err != nil {
  3903. t.Fatal(err)
  3904. }
  3905. res, err := inspectFieldJSON(name2, "Config.Entrypoint")
  3906. if err != nil {
  3907. t.Fatal(err, res)
  3908. }
  3909. if res != expected {
  3910. t.Fatalf("Expected value %s not in Config.Entrypoint: %s", expected, res)
  3911. }
  3912. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "-t", name2))
  3913. if err != nil {
  3914. t.Fatal(err, out)
  3915. }
  3916. expected = "quux"
  3917. if strings.TrimSpace(out) != expected {
  3918. t.Fatalf("Expected output is %s, got %s", expected, out)
  3919. }
  3920. logDone("build - entrypoint override inheritance properly")
  3921. }
  3922. func TestBuildRunShEntrypoint(t *testing.T) {
  3923. name := "testbuildentrypoint"
  3924. defer deleteImages(name)
  3925. _, err := buildImage(name,
  3926. `FROM busybox
  3927. ENTRYPOINT /bin/echo`,
  3928. true)
  3929. if err != nil {
  3930. t.Fatal(err)
  3931. }
  3932. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "--rm", name))
  3933. if err != nil {
  3934. t.Fatal(err, out)
  3935. }
  3936. logDone("build - entrypoint with /bin/echo running successfully")
  3937. }
  3938. func TestBuildExoticShellInterpolation(t *testing.T) {
  3939. name := "testbuildexoticshellinterpolation"
  3940. defer deleteImages(name)
  3941. _, err := buildImage(name, `
  3942. FROM busybox
  3943. ENV SOME_VAR a.b.c
  3944. RUN [ "$SOME_VAR" = 'a.b.c' ]
  3945. RUN [ "${SOME_VAR}" = 'a.b.c' ]
  3946. RUN [ "${SOME_VAR%.*}" = 'a.b' ]
  3947. RUN [ "${SOME_VAR%%.*}" = 'a' ]
  3948. RUN [ "${SOME_VAR#*.}" = 'b.c' ]
  3949. RUN [ "${SOME_VAR##*.}" = 'c' ]
  3950. RUN [ "${SOME_VAR/c/d}" = 'a.b.d' ]
  3951. RUN [ "${#SOME_VAR}" = '5' ]
  3952. RUN [ "${SOME_UNSET_VAR:-$SOME_VAR}" = 'a.b.c' ]
  3953. RUN [ "${SOME_VAR:+Version: ${SOME_VAR}}" = 'Version: a.b.c' ]
  3954. RUN [ "${SOME_UNSET_VAR:+${SOME_VAR}}" = '' ]
  3955. RUN [ "${SOME_UNSET_VAR:-${SOME_VAR:-d.e.f}}" = 'a.b.c' ]
  3956. `, false)
  3957. if err != nil {
  3958. t.Fatal(err)
  3959. }
  3960. logDone("build - exotic shell interpolation")
  3961. }
  3962. func TestBuildVerifySingleQuoteFails(t *testing.T) {
  3963. // This testcase is supposed to generate an error because the
  3964. // JSON array we're passing in on the CMD uses single quotes instead
  3965. // of double quotes (per the JSON spec). This means we interpret it
  3966. // as a "string" insead of "JSON array" and pass it on to "sh -c" and
  3967. // it should barf on it.
  3968. name := "testbuildsinglequotefails"
  3969. defer deleteImages(name)
  3970. defer deleteAllContainers()
  3971. _, err := buildImage(name,
  3972. `FROM busybox
  3973. CMD [ '/bin/sh', '-c', 'echo hi' ]`,
  3974. true)
  3975. _, _, err = runCommandWithOutput(exec.Command(dockerBinary, "run", "--rm", name))
  3976. if err == nil {
  3977. t.Fatal("The image was not supposed to be able to run")
  3978. }
  3979. logDone("build - verify single quotes break the build")
  3980. }
  3981. func TestBuildVerboseOut(t *testing.T) {
  3982. name := "testbuildverboseout"
  3983. defer deleteImages(name)
  3984. _, out, err := buildImageWithOut(name,
  3985. `FROM busybox
  3986. RUN echo 123`,
  3987. false)
  3988. if err != nil {
  3989. t.Fatal(err)
  3990. }
  3991. if !strings.Contains(out, "\n123\n") {
  3992. t.Fatalf("Output should contain %q: %q", "123", out)
  3993. }
  3994. logDone("build - verbose output from commands")
  3995. }
  3996. func TestBuildWithTabs(t *testing.T) {
  3997. name := "testbuildwithtabs"
  3998. defer deleteImages(name)
  3999. _, err := buildImage(name,
  4000. "FROM busybox\nRUN echo\tone\t\ttwo", true)
  4001. if err != nil {
  4002. t.Fatal(err)
  4003. }
  4004. res, err := inspectFieldJSON(name, "ContainerConfig.Cmd")
  4005. if err != nil {
  4006. t.Fatal(err)
  4007. }
  4008. expected1 := `["/bin/sh","-c","echo\tone\t\ttwo"]`
  4009. expected2 := `["/bin/sh","-c","echo\u0009one\u0009\u0009two"]` // syntactically equivalent, and what Go 1.3 generates
  4010. if res != expected1 && res != expected2 {
  4011. t.Fatalf("Missing tabs.\nGot: %s\nExp: %s or %s", res, expected1, expected2)
  4012. }
  4013. logDone("build - with tabs")
  4014. }
  4015. func TestBuildLabels(t *testing.T) {
  4016. name := "testbuildlabel"
  4017. expected := `{"License":"GPL","Vendor":"Acme"}`
  4018. defer deleteImages(name)
  4019. _, err := buildImage(name,
  4020. `FROM busybox
  4021. LABEL Vendor=Acme
  4022. LABEL License GPL`,
  4023. true)
  4024. if err != nil {
  4025. t.Fatal(err)
  4026. }
  4027. res, err := inspectFieldJSON(name, "Config.Labels")
  4028. if err != nil {
  4029. t.Fatal(err)
  4030. }
  4031. if res != expected {
  4032. t.Fatalf("Labels %s, expected %s", res, expected)
  4033. }
  4034. logDone("build - label")
  4035. }
  4036. func TestBuildLabelsCache(t *testing.T) {
  4037. name := "testbuildlabelcache"
  4038. defer deleteImages(name)
  4039. id1, err := buildImage(name,
  4040. `FROM busybox
  4041. LABEL Vendor=Acme`, false)
  4042. if err != nil {
  4043. t.Fatalf("Build 1 should have worked: %v", err)
  4044. }
  4045. id2, err := buildImage(name,
  4046. `FROM busybox
  4047. LABEL Vendor=Acme`, true)
  4048. if err != nil || id1 != id2 {
  4049. t.Fatalf("Build 2 should have worked & used cache(%s,%s): %v", id1, id2, err)
  4050. }
  4051. id2, err = buildImage(name,
  4052. `FROM busybox
  4053. LABEL Vendor=Acme1`, true)
  4054. if err != nil || id1 == id2 {
  4055. t.Fatalf("Build 3 should have worked & NOT used cache(%s,%s): %v", id1, id2, err)
  4056. }
  4057. id2, err = buildImage(name,
  4058. `FROM busybox
  4059. LABEL Vendor Acme`, true) // Note: " " and "=" should be same
  4060. if err != nil || id1 != id2 {
  4061. t.Fatalf("Build 4 should have worked & used cache(%s,%s): %v", id1, id2, err)
  4062. }
  4063. // Now make sure the cache isn't used by mistake
  4064. id1, err = buildImage(name,
  4065. `FROM busybox
  4066. LABEL f1=b1 f2=b2`, false)
  4067. if err != nil {
  4068. t.Fatalf("Build 5 should have worked: %q", err)
  4069. }
  4070. id2, err = buildImage(name,
  4071. `FROM busybox
  4072. LABEL f1="b1 f2=b2"`, true)
  4073. if err != nil || id1 == id2 {
  4074. t.Fatalf("Build 6 should have worked & NOT used the cache(%s,%s): %q", id1, id2, err)
  4075. }
  4076. logDone("build - label cache")
  4077. }
  4078. func TestBuildStderr(t *testing.T) {
  4079. // This test just makes sure that no non-error output goes
  4080. // to stderr
  4081. name := "testbuildstderr"
  4082. defer deleteImages(name)
  4083. _, _, stderr, err := buildImageWithStdoutStderr(name,
  4084. "FROM busybox\nRUN echo one", true)
  4085. if err != nil {
  4086. t.Fatal(err)
  4087. }
  4088. if runtime.GOOS == "windows" {
  4089. // stderr might contain a security warning on windows
  4090. lines := strings.Split(stderr, "\n")
  4091. for _, v := range lines {
  4092. if v != "" && !strings.Contains(v, "SECURITY WARNING:") {
  4093. t.Fatalf("Stderr contains unexpected output line: %q", v)
  4094. }
  4095. }
  4096. } else {
  4097. if stderr != "" {
  4098. t.Fatalf("Stderr should have been empty, instead its: %q", stderr)
  4099. }
  4100. }
  4101. logDone("build - testing stderr")
  4102. }
  4103. func TestBuildChownSingleFile(t *testing.T) {
  4104. testRequires(t, UnixCli) // test uses chown: not available on windows
  4105. name := "testbuildchownsinglefile"
  4106. defer deleteImages(name)
  4107. ctx, err := fakeContext(`
  4108. FROM busybox
  4109. COPY test /
  4110. RUN ls -l /test
  4111. RUN [ $(ls -l /test | awk '{print $3":"$4}') = 'root:root' ]
  4112. `, map[string]string{
  4113. "test": "test",
  4114. })
  4115. if err != nil {
  4116. t.Fatal(err)
  4117. }
  4118. defer ctx.Close()
  4119. if err := os.Chown(filepath.Join(ctx.Dir, "test"), 4242, 4242); err != nil {
  4120. t.Fatal(err)
  4121. }
  4122. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  4123. t.Fatal(err)
  4124. }
  4125. logDone("build - change permission on single file")
  4126. }
  4127. func TestBuildSymlinkBreakout(t *testing.T) {
  4128. name := "testbuildsymlinkbreakout"
  4129. tmpdir, err := ioutil.TempDir("", name)
  4130. if err != nil {
  4131. t.Fatal(err)
  4132. }
  4133. defer os.RemoveAll(tmpdir)
  4134. ctx := filepath.Join(tmpdir, "context")
  4135. if err := os.MkdirAll(ctx, 0755); err != nil {
  4136. t.Fatal(err)
  4137. }
  4138. if err := ioutil.WriteFile(filepath.Join(ctx, "Dockerfile"), []byte(`
  4139. from busybox
  4140. add symlink.tar /
  4141. add inject /symlink/
  4142. `), 0644); err != nil {
  4143. t.Fatal(err)
  4144. }
  4145. inject := filepath.Join(ctx, "inject")
  4146. if err := ioutil.WriteFile(inject, nil, 0644); err != nil {
  4147. t.Fatal(err)
  4148. }
  4149. f, err := os.Create(filepath.Join(ctx, "symlink.tar"))
  4150. if err != nil {
  4151. t.Fatal(err)
  4152. }
  4153. w := tar.NewWriter(f)
  4154. w.WriteHeader(&tar.Header{
  4155. Name: "symlink2",
  4156. Typeflag: tar.TypeSymlink,
  4157. Linkname: "/../../../../../../../../../../../../../../",
  4158. Uid: os.Getuid(),
  4159. Gid: os.Getgid(),
  4160. })
  4161. w.WriteHeader(&tar.Header{
  4162. Name: "symlink",
  4163. Typeflag: tar.TypeSymlink,
  4164. Linkname: filepath.Join("symlink2", tmpdir),
  4165. Uid: os.Getuid(),
  4166. Gid: os.Getgid(),
  4167. })
  4168. w.Close()
  4169. f.Close()
  4170. if _, err := buildImageFromContext(name, fakeContextFromDir(ctx), false); err != nil {
  4171. t.Fatal(err)
  4172. }
  4173. if _, err := os.Lstat(filepath.Join(tmpdir, "inject")); err == nil {
  4174. t.Fatal("symlink breakout - inject")
  4175. } else if !os.IsNotExist(err) {
  4176. t.Fatalf("unexpected error: %v", err)
  4177. }
  4178. logDone("build - symlink breakout")
  4179. }
  4180. func TestBuildXZHost(t *testing.T) {
  4181. name := "testbuildxzhost"
  4182. defer deleteImages(name)
  4183. ctx, err := fakeContext(`
  4184. FROM busybox
  4185. ADD xz /usr/local/sbin/
  4186. RUN chmod 755 /usr/local/sbin/xz
  4187. ADD test.xz /
  4188. RUN [ ! -e /injected ]`,
  4189. map[string]string{
  4190. "test.xz": "\xfd\x37\x7a\x58\x5a\x00\x00\x04\xe6\xd6\xb4\x46\x02\x00" +
  4191. "\x21\x01\x16\x00\x00\x00\x74\x2f\xe5\xa3\x01\x00\x3f\xfd" +
  4192. "\x37\x7a\x58\x5a\x00\x00\x04\xe6\xd6\xb4\x46\x02\x00\x21",
  4193. "xz": "#!/bin/sh\ntouch /injected",
  4194. })
  4195. if err != nil {
  4196. t.Fatal(err)
  4197. }
  4198. defer ctx.Close()
  4199. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  4200. t.Fatal(err)
  4201. }
  4202. logDone("build - xz host is being used")
  4203. }
  4204. func TestBuildVolumesRetainContents(t *testing.T) {
  4205. var (
  4206. name = "testbuildvolumescontent"
  4207. expected = "some text"
  4208. )
  4209. defer deleteImages(name)
  4210. ctx, err := fakeContext(`
  4211. FROM busybox
  4212. COPY content /foo/file
  4213. VOLUME /foo
  4214. CMD cat /foo/file`,
  4215. map[string]string{
  4216. "content": expected,
  4217. })
  4218. if err != nil {
  4219. t.Fatal(err)
  4220. }
  4221. defer ctx.Close()
  4222. if _, err := buildImageFromContext(name, ctx, false); err != nil {
  4223. t.Fatal(err)
  4224. }
  4225. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "--rm", name))
  4226. if err != nil {
  4227. t.Fatal(err)
  4228. }
  4229. if out != expected {
  4230. t.Fatalf("expected file contents for /foo/file to be %q but received %q", expected, out)
  4231. }
  4232. logDone("build - volumes retain contents in build")
  4233. }
  4234. func TestBuildRenamedDockerfile(t *testing.T) {
  4235. defer deleteAllContainers()
  4236. ctx, err := fakeContext(`FROM busybox
  4237. RUN echo from Dockerfile`,
  4238. map[string]string{
  4239. "Dockerfile": "FROM busybox\nRUN echo from Dockerfile",
  4240. "files/Dockerfile": "FROM busybox\nRUN echo from files/Dockerfile",
  4241. "files/dFile": "FROM busybox\nRUN echo from files/dFile",
  4242. "dFile": "FROM busybox\nRUN echo from dFile",
  4243. "files/dFile2": "FROM busybox\nRUN echo from files/dFile2",
  4244. })
  4245. defer ctx.Close()
  4246. if err != nil {
  4247. t.Fatal(err)
  4248. }
  4249. out, _, err := dockerCmdInDir(t, ctx.Dir, "build", "-t", "test1", ".")
  4250. if err != nil {
  4251. t.Fatalf("Failed to build: %s\n%s", out, err)
  4252. }
  4253. if !strings.Contains(out, "from Dockerfile") {
  4254. t.Fatalf("test1 should have used Dockerfile, output:%s", out)
  4255. }
  4256. out, _, err = dockerCmdInDir(t, ctx.Dir, "build", "-f", filepath.Join("files", "Dockerfile"), "-t", "test2", ".")
  4257. if err != nil {
  4258. t.Fatal(err)
  4259. }
  4260. if !strings.Contains(out, "from files/Dockerfile") {
  4261. t.Fatalf("test2 should have used files/Dockerfile, output:%s", out)
  4262. }
  4263. out, _, err = dockerCmdInDir(t, ctx.Dir, "build", fmt.Sprintf("--file=%s", filepath.Join("files", "dFile")), "-t", "test3", ".")
  4264. if err != nil {
  4265. t.Fatal(err)
  4266. }
  4267. if !strings.Contains(out, "from files/dFile") {
  4268. t.Fatalf("test3 should have used files/dFile, output:%s", out)
  4269. }
  4270. out, _, err = dockerCmdInDir(t, ctx.Dir, "build", "--file=dFile", "-t", "test4", ".")
  4271. if err != nil {
  4272. t.Fatal(err)
  4273. }
  4274. if !strings.Contains(out, "from dFile") {
  4275. t.Fatalf("test4 should have used dFile, output:%s", out)
  4276. }
  4277. dirWithNoDockerfile, _ := ioutil.TempDir(os.TempDir(), "test5")
  4278. nonDockerfileFile := filepath.Join(dirWithNoDockerfile, "notDockerfile")
  4279. if _, err = os.Create(nonDockerfileFile); err != nil {
  4280. t.Fatal(err)
  4281. }
  4282. out, _, err = dockerCmdInDir(t, ctx.Dir, "build", fmt.Sprintf("--file=%s", nonDockerfileFile), "-t", "test5", ".")
  4283. if err == nil {
  4284. t.Fatalf("test5 was supposed to fail to find passwd")
  4285. }
  4286. if expected := fmt.Sprintf("The Dockerfile (%s) must be within the build context (.)", strings.Replace(nonDockerfileFile, `\`, `\\`, -1)); !strings.Contains(out, expected) {
  4287. t.Fatalf("wrong error messsage:%v\nexpected to contain=%v", out, expected)
  4288. }
  4289. out, _, err = dockerCmdInDir(t, filepath.Join(ctx.Dir, "files"), "build", "-f", filepath.Join("..", "Dockerfile"), "-t", "test6", "..")
  4290. if err != nil {
  4291. t.Fatalf("test6 failed: %s", err)
  4292. }
  4293. if !strings.Contains(out, "from Dockerfile") {
  4294. t.Fatalf("test6 should have used root Dockerfile, output:%s", out)
  4295. }
  4296. out, _, err = dockerCmdInDir(t, filepath.Join(ctx.Dir, "files"), "build", "-f", filepath.Join(ctx.Dir, "files", "Dockerfile"), "-t", "test7", "..")
  4297. if err != nil {
  4298. t.Fatalf("test7 failed: %s", err)
  4299. }
  4300. if !strings.Contains(out, "from files/Dockerfile") {
  4301. t.Fatalf("test7 should have used files Dockerfile, output:%s", out)
  4302. }
  4303. out, _, err = dockerCmdInDir(t, filepath.Join(ctx.Dir, "files"), "build", "-f", filepath.Join("..", "Dockerfile"), "-t", "test8", ".")
  4304. if err == nil || !strings.Contains(out, "must be within the build context") {
  4305. t.Fatalf("test8 should have failed with Dockerfile out of context: %s", err)
  4306. }
  4307. tmpDir := os.TempDir()
  4308. out, _, err = dockerCmdInDir(t, tmpDir, "build", "-t", "test9", ctx.Dir)
  4309. if err != nil {
  4310. t.Fatalf("test9 - failed: %s", err)
  4311. }
  4312. if !strings.Contains(out, "from Dockerfile") {
  4313. t.Fatalf("test9 should have used root Dockerfile, output:%s", out)
  4314. }
  4315. out, _, err = dockerCmdInDir(t, filepath.Join(ctx.Dir, "files"), "build", "-f", "dFile2", "-t", "test10", ".")
  4316. if err != nil {
  4317. t.Fatalf("test10 should have worked: %s", err)
  4318. }
  4319. if !strings.Contains(out, "from files/dFile2") {
  4320. t.Fatalf("test10 should have used files/dFile2, output:%s", out)
  4321. }
  4322. logDone("build - rename dockerfile")
  4323. }
  4324. func TestBuildFromMixedcaseDockerfile(t *testing.T) {
  4325. testRequires(t, UnixCli) // Dockerfile overwrites dockerfile on windows
  4326. defer deleteImages("test1")
  4327. ctx, err := fakeContext(`FROM busybox
  4328. RUN echo from dockerfile`,
  4329. map[string]string{
  4330. "dockerfile": "FROM busybox\nRUN echo from dockerfile",
  4331. })
  4332. defer ctx.Close()
  4333. if err != nil {
  4334. t.Fatal(err)
  4335. }
  4336. out, _, err := dockerCmdInDir(t, ctx.Dir, "build", "-t", "test1", ".")
  4337. if err != nil {
  4338. t.Fatalf("Failed to build: %s\n%s", out, err)
  4339. }
  4340. if !strings.Contains(out, "from dockerfile") {
  4341. t.Fatalf("Missing proper output: %s", out)
  4342. }
  4343. logDone("build - mixedcase Dockerfile")
  4344. }
  4345. func TestBuildWithTwoDockerfiles(t *testing.T) {
  4346. testRequires(t, UnixCli) // Dockerfile overwrites dockerfile on windows
  4347. defer deleteImages("test1")
  4348. ctx, err := fakeContext(`FROM busybox
  4349. RUN echo from Dockerfile`,
  4350. map[string]string{
  4351. "dockerfile": "FROM busybox\nRUN echo from dockerfile",
  4352. })
  4353. defer ctx.Close()
  4354. if err != nil {
  4355. t.Fatal(err)
  4356. }
  4357. out, _, err := dockerCmdInDir(t, ctx.Dir, "build", "-t", "test1", ".")
  4358. if err != nil {
  4359. t.Fatalf("Failed to build: %s\n%s", out, err)
  4360. }
  4361. if !strings.Contains(out, "from Dockerfile") {
  4362. t.Fatalf("Missing proper output: %s", out)
  4363. }
  4364. logDone("build - two Dockerfiles")
  4365. }
  4366. func TestBuildFromURLWithF(t *testing.T) {
  4367. defer deleteImages("test1")
  4368. server, err := fakeStorage(map[string]string{"baz": `FROM busybox
  4369. RUN echo from baz
  4370. COPY * /tmp/
  4371. RUN find /tmp/`})
  4372. if err != nil {
  4373. t.Fatal(err)
  4374. }
  4375. defer server.Close()
  4376. ctx, err := fakeContext(`FROM busybox
  4377. RUN echo from Dockerfile`,
  4378. map[string]string{})
  4379. defer ctx.Close()
  4380. if err != nil {
  4381. t.Fatal(err)
  4382. }
  4383. // Make sure that -f is ignored and that we don't use the Dockerfile
  4384. // that's in the current dir
  4385. out, _, err := dockerCmdInDir(t, ctx.Dir, "build", "-f", "baz", "-t", "test1", server.URL()+"/baz")
  4386. if err != nil {
  4387. t.Fatalf("Failed to build: %s\n%s", out, err)
  4388. }
  4389. if !strings.Contains(out, "from baz") ||
  4390. strings.Contains(out, "/tmp/baz") ||
  4391. !strings.Contains(out, "/tmp/Dockerfile") {
  4392. t.Fatalf("Missing proper output: %s", out)
  4393. }
  4394. logDone("build - from URL with -f")
  4395. }
  4396. func TestBuildFromStdinWithF(t *testing.T) {
  4397. defer deleteImages("test1")
  4398. ctx, err := fakeContext(`FROM busybox
  4399. RUN echo from Dockerfile`,
  4400. map[string]string{})
  4401. defer ctx.Close()
  4402. if err != nil {
  4403. t.Fatal(err)
  4404. }
  4405. // Make sure that -f is ignored and that we don't use the Dockerfile
  4406. // that's in the current dir
  4407. dockerCommand := exec.Command(dockerBinary, "build", "-f", "baz", "-t", "test1", "-")
  4408. dockerCommand.Dir = ctx.Dir
  4409. dockerCommand.Stdin = strings.NewReader(`FROM busybox
  4410. RUN echo from baz
  4411. COPY * /tmp/
  4412. RUN find /tmp/`)
  4413. out, status, err := runCommandWithOutput(dockerCommand)
  4414. if err != nil || status != 0 {
  4415. t.Fatalf("Error building: %s", err)
  4416. }
  4417. if !strings.Contains(out, "from baz") ||
  4418. strings.Contains(out, "/tmp/baz") ||
  4419. !strings.Contains(out, "/tmp/Dockerfile") {
  4420. t.Fatalf("Missing proper output: %s", out)
  4421. }
  4422. logDone("build - from stdin with -f")
  4423. }
  4424. func TestBuildFromOfficialNames(t *testing.T) {
  4425. name := "testbuildfromofficial"
  4426. fromNames := []string{
  4427. "busybox",
  4428. "docker.io/busybox",
  4429. "index.docker.io/busybox",
  4430. "library/busybox",
  4431. "docker.io/library/busybox",
  4432. "index.docker.io/library/busybox",
  4433. }
  4434. for idx, fromName := range fromNames {
  4435. imgName := fmt.Sprintf("%s%d", name, idx)
  4436. _, err := buildImage(imgName, "FROM "+fromName, true)
  4437. if err != nil {
  4438. t.Errorf("Build failed using FROM %s: %s", fromName, err)
  4439. }
  4440. deleteImages(imgName)
  4441. }
  4442. logDone("build - from official names")
  4443. }
  4444. func TestBuildDockerfileOutsideContext(t *testing.T) {
  4445. testRequires(t, UnixCli) // uses os.Symlink: not implemented in windows at the time of writing (go-1.4.2)
  4446. name := "testbuilddockerfileoutsidecontext"
  4447. tmpdir, err := ioutil.TempDir("", name)
  4448. if err != nil {
  4449. t.Fatal(err)
  4450. }
  4451. defer os.RemoveAll(tmpdir)
  4452. ctx := filepath.Join(tmpdir, "context")
  4453. if err := os.MkdirAll(ctx, 0755); err != nil {
  4454. t.Fatal(err)
  4455. }
  4456. if err := ioutil.WriteFile(filepath.Join(ctx, "Dockerfile"), []byte("FROM scratch\nENV X Y"), 0644); err != nil {
  4457. t.Fatal(err)
  4458. }
  4459. wd, err := os.Getwd()
  4460. if err != nil {
  4461. t.Fatal(err)
  4462. }
  4463. defer os.Chdir(wd)
  4464. if err := os.Chdir(ctx); err != nil {
  4465. t.Fatal(err)
  4466. }
  4467. if err := ioutil.WriteFile(filepath.Join(tmpdir, "outsideDockerfile"), []byte("FROM scratch\nENV x y"), 0644); err != nil {
  4468. t.Fatal(err)
  4469. }
  4470. if err := os.Symlink(filepath.Join("..", "outsideDockerfile"), filepath.Join(ctx, "dockerfile1")); err != nil {
  4471. t.Fatal(err)
  4472. }
  4473. if err := os.Symlink(filepath.Join(tmpdir, "outsideDockerfile"), filepath.Join(ctx, "dockerfile2")); err != nil {
  4474. t.Fatal(err)
  4475. }
  4476. for _, dockerfilePath := range []string{
  4477. filepath.Join("..", "outsideDockerfile"),
  4478. filepath.Join(ctx, "dockerfile1"),
  4479. filepath.Join(ctx, "dockerfile2"),
  4480. } {
  4481. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "build", "-t", name, "--no-cache", "-f", dockerfilePath, "."))
  4482. if err == nil {
  4483. t.Fatalf("Expected error with %s. Out: %s", dockerfilePath, out)
  4484. }
  4485. if !strings.Contains(out, "must be within the build context") && !strings.Contains(out, "Cannot locate Dockerfile") {
  4486. t.Fatalf("Unexpected error with %s. Out: %s", dockerfilePath, out)
  4487. }
  4488. deleteImages(name)
  4489. }
  4490. os.Chdir(tmpdir)
  4491. // Path to Dockerfile should be resolved relative to working directory, not relative to context.
  4492. // There is a Dockerfile in the context, but since there is no Dockerfile in the current directory, the following should fail
  4493. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "build", "-t", name, "--no-cache", "-f", "Dockerfile", ctx))
  4494. if err == nil {
  4495. t.Fatalf("Expected error. Out: %s", out)
  4496. }
  4497. deleteImages(name)
  4498. logDone("build - Dockerfile outside context")
  4499. }
  4500. func TestBuildSpaces(t *testing.T) {
  4501. // Test to make sure that leading/trailing spaces on a command
  4502. // doesn't change the error msg we get
  4503. var (
  4504. err1 error
  4505. err2 error
  4506. )
  4507. name := "testspaces"
  4508. defer deleteImages(name)
  4509. ctx, err := fakeContext("FROM busybox\nCOPY\n",
  4510. map[string]string{
  4511. "Dockerfile": "FROM busybox\nCOPY\n",
  4512. })
  4513. if err != nil {
  4514. t.Fatal(err)
  4515. }
  4516. defer ctx.Close()
  4517. if _, err1 = buildImageFromContext(name, ctx, false); err1 == nil {
  4518. t.Fatal("Build 1 was supposed to fail, but didn't")
  4519. }
  4520. ctx.Add("Dockerfile", "FROM busybox\nCOPY ")
  4521. if _, err2 = buildImageFromContext(name, ctx, false); err2 == nil {
  4522. t.Fatal("Build 2 was supposed to fail, but didn't")
  4523. }
  4524. // Skip over the times
  4525. e1 := err1.Error()[strings.Index(err1.Error(), `level=`):]
  4526. e2 := err2.Error()[strings.Index(err1.Error(), `level=`):]
  4527. // Ignore whitespace since that's what were verifying doesn't change stuff
  4528. if strings.Replace(e1, " ", "", -1) != strings.Replace(e2, " ", "", -1) {
  4529. t.Fatalf("Build 2's error wasn't the same as build 1's\n1:%s\n2:%s", err1, err2)
  4530. }
  4531. ctx.Add("Dockerfile", "FROM busybox\n COPY")
  4532. if _, err2 = buildImageFromContext(name, ctx, false); err2 == nil {
  4533. t.Fatal("Build 3 was supposed to fail, but didn't")
  4534. }
  4535. // Skip over the times
  4536. e1 = err1.Error()[strings.Index(err1.Error(), `level=`):]
  4537. e2 = err2.Error()[strings.Index(err1.Error(), `level=`):]
  4538. // Ignore whitespace since that's what were verifying doesn't change stuff
  4539. if strings.Replace(e1, " ", "", -1) != strings.Replace(e2, " ", "", -1) {
  4540. t.Fatalf("Build 3's error wasn't the same as build 1's\n1:%s\n3:%s", err1, err2)
  4541. }
  4542. ctx.Add("Dockerfile", "FROM busybox\n COPY ")
  4543. if _, err2 = buildImageFromContext(name, ctx, false); err2 == nil {
  4544. t.Fatal("Build 4 was supposed to fail, but didn't")
  4545. }
  4546. // Skip over the times
  4547. e1 = err1.Error()[strings.Index(err1.Error(), `level=`):]
  4548. e2 = err2.Error()[strings.Index(err1.Error(), `level=`):]
  4549. // Ignore whitespace since that's what were verifying doesn't change stuff
  4550. if strings.Replace(e1, " ", "", -1) != strings.Replace(e2, " ", "", -1) {
  4551. t.Fatalf("Build 4's error wasn't the same as build 1's\n1:%s\n4:%s", err1, err2)
  4552. }
  4553. logDone("build - test spaces")
  4554. }
  4555. func TestBuildSpacesWithQuotes(t *testing.T) {
  4556. // Test to make sure that spaces in quotes aren't lost
  4557. name := "testspacesquotes"
  4558. defer deleteImages(name)
  4559. dockerfile := `FROM busybox
  4560. RUN echo " \
  4561. foo "`
  4562. _, out, err := buildImageWithOut(name, dockerfile, false)
  4563. if err != nil {
  4564. t.Fatal("Build failed:", err)
  4565. }
  4566. expecting := "\n foo \n"
  4567. if !strings.Contains(out, expecting) {
  4568. t.Fatalf("Bad output: %q expecting to contian %q", out, expecting)
  4569. }
  4570. logDone("build - test spaces with quotes")
  4571. }
  4572. // #4393
  4573. func TestBuildVolumeFileExistsinContainer(t *testing.T) {
  4574. buildCmd := exec.Command(dockerBinary, "build", "-t", "docker-test-errcreatevolumewithfile", "-")
  4575. buildCmd.Stdin = strings.NewReader(`
  4576. FROM busybox
  4577. RUN touch /foo
  4578. VOLUME /foo
  4579. `)
  4580. out, _, err := runCommandWithOutput(buildCmd)
  4581. if err == nil || !strings.Contains(out, "file exists") {
  4582. t.Fatalf("expected build to fail when file exists in container at requested volume path")
  4583. }
  4584. logDone("build - errors when volume is specified where a file exists")
  4585. }
  4586. func TestBuildMissingArgs(t *testing.T) {
  4587. // Test to make sure that all Dockerfile commands (except the ones listed
  4588. // in skipCmds) will generate an error if no args are provided.
  4589. // Note: INSERT is deprecated so we exclude it because of that.
  4590. skipCmds := map[string]struct{}{
  4591. "CMD": {},
  4592. "RUN": {},
  4593. "ENTRYPOINT": {},
  4594. "INSERT": {},
  4595. }
  4596. defer deleteAllContainers()
  4597. for cmd := range command.Commands {
  4598. cmd = strings.ToUpper(cmd)
  4599. if _, ok := skipCmds[cmd]; ok {
  4600. continue
  4601. }
  4602. var dockerfile string
  4603. if cmd == "FROM" {
  4604. dockerfile = cmd
  4605. } else {
  4606. // Add FROM to make sure we don't complain about it missing
  4607. dockerfile = "FROM busybox\n" + cmd
  4608. }
  4609. ctx, err := fakeContext(dockerfile, map[string]string{})
  4610. if err != nil {
  4611. t.Fatal(err)
  4612. }
  4613. defer ctx.Close()
  4614. var out string
  4615. if out, err = buildImageFromContext("args", ctx, true); err == nil {
  4616. t.Fatalf("%s was supposed to fail. Out:%s", cmd, out)
  4617. }
  4618. if !strings.Contains(err.Error(), cmd+" requires") {
  4619. t.Fatalf("%s returned the wrong type of error:%s", cmd, err)
  4620. }
  4621. }
  4622. logDone("build - verify missing args")
  4623. }
  4624. func TestBuildEmptyScratch(t *testing.T) {
  4625. defer deleteImages("sc")
  4626. _, out, err := buildImageWithOut("sc", "FROM scratch", true)
  4627. if err == nil {
  4628. t.Fatalf("Build was supposed to fail")
  4629. }
  4630. if !strings.Contains(out, "No image was generated") {
  4631. t.Fatalf("Wrong error message: %v", out)
  4632. }
  4633. logDone("build - empty scratch Dockerfile")
  4634. }
  4635. func TestBuildDotDotFile(t *testing.T) {
  4636. defer deleteImages("sc")
  4637. ctx, err := fakeContext("FROM busybox\n",
  4638. map[string]string{
  4639. "..gitme": "",
  4640. })
  4641. if err != nil {
  4642. t.Fatal(err)
  4643. }
  4644. defer ctx.Close()
  4645. if _, err = buildImageFromContext("sc", ctx, false); err != nil {
  4646. t.Fatalf("Build was supposed to work: %s", err)
  4647. }
  4648. logDone("build - ..file")
  4649. }
  4650. func TestBuildNotVerbose(t *testing.T) {
  4651. defer deleteAllContainers()
  4652. defer deleteImages("verbose")
  4653. ctx, err := fakeContext("FROM busybox\nENV abc=hi\nRUN echo $abc there", map[string]string{})
  4654. if err != nil {
  4655. t.Fatal(err)
  4656. }
  4657. defer ctx.Close()
  4658. // First do it w/verbose - baseline
  4659. buildCmd := exec.Command(dockerBinary, "build", "--no-cache", "-t", "verbose", ".")
  4660. buildCmd.Dir = ctx.Dir
  4661. out, _, err := runCommandWithOutput(buildCmd)
  4662. if err != nil {
  4663. t.Fatalf("failed to build the image w/o -q: %s, %v", out, err)
  4664. }
  4665. if !strings.Contains(out, "hi there") {
  4666. t.Fatalf("missing output:%s\n", out)
  4667. }
  4668. // Now do it w/o verbose
  4669. buildCmd = exec.Command(dockerBinary, "build", "--no-cache", "-q", "-t", "verbose", ".")
  4670. buildCmd.Dir = ctx.Dir
  4671. out, _, err = runCommandWithOutput(buildCmd)
  4672. if err != nil {
  4673. t.Fatalf("failed to build the image w/ -q: %s, %v", out, err)
  4674. }
  4675. if strings.Contains(out, "hi there") {
  4676. t.Fatalf("Bad output, should not contain 'hi there':%s", out)
  4677. }
  4678. logDone("build - not verbose")
  4679. }
  4680. func TestBuildRUNoneJSON(t *testing.T) {
  4681. name := "testbuildrunonejson"
  4682. defer deleteAllContainers()
  4683. defer deleteImages(name)
  4684. ctx, err := fakeContext(`FROM hello-world:frozen
  4685. RUN [ "/hello" ]`, map[string]string{})
  4686. if err != nil {
  4687. t.Fatal(err)
  4688. }
  4689. defer ctx.Close()
  4690. buildCmd := exec.Command(dockerBinary, "build", "--no-cache", "-t", name, ".")
  4691. buildCmd.Dir = ctx.Dir
  4692. out, _, err := runCommandWithOutput(buildCmd)
  4693. if err != nil {
  4694. t.Fatalf("failed to build the image: %s, %v", out, err)
  4695. }
  4696. if !strings.Contains(out, "Hello from Docker") {
  4697. t.Fatalf("bad output: %s", out)
  4698. }
  4699. logDone("build - RUN with one JSON arg")
  4700. }
  4701. func TestBuildResourceConstraintsAreUsed(t *testing.T) {
  4702. name := "testbuildresourceconstraints"
  4703. defer deleteAllContainers()
  4704. defer deleteImages(name)
  4705. ctx, err := fakeContext(`
  4706. FROM hello-world:frozen
  4707. RUN ["/hello"]
  4708. `, map[string]string{})
  4709. if err != nil {
  4710. t.Fatal(err)
  4711. }
  4712. cmd := exec.Command(dockerBinary, "build", "--rm=false", "--memory=64m", "--memory-swap=-1", "--cpuset-cpus=1", "--cpu-shares=100", "-t", name, ".")
  4713. cmd.Dir = ctx.Dir
  4714. out, _, err := runCommandWithOutput(cmd)
  4715. if err != nil {
  4716. t.Fatal(err, out)
  4717. }
  4718. out, _, err = dockerCmd(t, "ps", "-lq")
  4719. if err != nil {
  4720. t.Fatal(err, out)
  4721. }
  4722. cID := stripTrailingCharacters(out)
  4723. type hostConfig struct {
  4724. Memory float64 // Use float64 here since the json decoder sees it that way
  4725. MemorySwap int
  4726. CpusetCpus string
  4727. CpuShares int
  4728. }
  4729. cfg, err := inspectFieldJSON(cID, "HostConfig")
  4730. if err != nil {
  4731. t.Fatal(err)
  4732. }
  4733. var c1 hostConfig
  4734. if err := json.Unmarshal([]byte(cfg), &c1); err != nil {
  4735. t.Fatal(err, cfg)
  4736. }
  4737. mem := int64(c1.Memory)
  4738. if mem != 67108864 || c1.MemorySwap != -1 || c1.CpusetCpus != "1" || c1.CpuShares != 100 {
  4739. t.Fatalf("resource constraints not set properly:\nMemory: %d, MemSwap: %d, CpusetCpus: %s, CpuShares: %d",
  4740. mem, c1.MemorySwap, c1.CpusetCpus, c1.CpuShares)
  4741. }
  4742. // Make sure constraints aren't saved to image
  4743. _, _, err = dockerCmd(t, "run", "--name=test", name)
  4744. if err != nil {
  4745. t.Fatal(err)
  4746. }
  4747. cfg, err = inspectFieldJSON("test", "HostConfig")
  4748. if err != nil {
  4749. t.Fatal(err)
  4750. }
  4751. var c2 hostConfig
  4752. if err := json.Unmarshal([]byte(cfg), &c2); err != nil {
  4753. t.Fatal(err, cfg)
  4754. }
  4755. mem = int64(c2.Memory)
  4756. if mem == 67108864 || c2.MemorySwap == -1 || c2.CpusetCpus == "1" || c2.CpuShares == 100 {
  4757. t.Fatalf("resource constraints leaked from build:\nMemory: %d, MemSwap: %d, CpusetCpus: %s, CpuShares: %d",
  4758. mem, c2.MemorySwap, c2.CpusetCpus, c2.CpuShares)
  4759. }
  4760. logDone("build - resource constraints applied")
  4761. }