docker_cli_build_test.go 88 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543154415451546154715481549155015511552155315541555155615571558155915601561156215631564156515661567156815691570157115721573157415751576157715781579158015811582158315841585158615871588158915901591159215931594159515961597159815991600160116021603160416051606160716081609161016111612161316141615161616171618161916201621162216231624162516261627162816291630163116321633163416351636163716381639164016411642164316441645164616471648164916501651165216531654165516561657165816591660166116621663166416651666166716681669167016711672167316741675167616771678167916801681168216831684168516861687168816891690169116921693169416951696169716981699170017011702170317041705170617071708170917101711171217131714171517161717171817191720172117221723172417251726172717281729173017311732173317341735173617371738173917401741174217431744174517461747174817491750175117521753175417551756175717581759176017611762176317641765176617671768176917701771177217731774177517761777177817791780178117821783178417851786178717881789179017911792179317941795179617971798179918001801180218031804180518061807180818091810181118121813181418151816181718181819182018211822182318241825182618271828182918301831183218331834183518361837183818391840184118421843184418451846184718481849185018511852185318541855185618571858185918601861186218631864186518661867186818691870187118721873187418751876187718781879188018811882188318841885188618871888188918901891189218931894189518961897189818991900190119021903190419051906190719081909191019111912191319141915191619171918191919201921192219231924192519261927192819291930193119321933193419351936193719381939194019411942194319441945194619471948194919501951195219531954195519561957195819591960196119621963196419651966196719681969197019711972197319741975197619771978197919801981198219831984198519861987198819891990199119921993199419951996199719981999200020012002200320042005200620072008200920102011201220132014201520162017201820192020202120222023202420252026202720282029203020312032203320342035203620372038203920402041204220432044204520462047204820492050205120522053205420552056205720582059206020612062206320642065206620672068206920702071207220732074207520762077207820792080208120822083208420852086208720882089209020912092209320942095209620972098209921002101210221032104210521062107210821092110211121122113211421152116211721182119212021212122212321242125212621272128212921302131213221332134213521362137213821392140214121422143214421452146214721482149215021512152215321542155215621572158215921602161216221632164216521662167216821692170217121722173217421752176217721782179218021812182218321842185218621872188218921902191219221932194219521962197219821992200220122022203220422052206220722082209221022112212221322142215221622172218221922202221222222232224222522262227222822292230223122322233223422352236223722382239224022412242224322442245224622472248224922502251225222532254225522562257225822592260226122622263226422652266226722682269227022712272227322742275227622772278227922802281228222832284228522862287228822892290229122922293229422952296229722982299230023012302230323042305230623072308230923102311231223132314231523162317231823192320232123222323232423252326232723282329233023312332233323342335233623372338233923402341234223432344234523462347234823492350235123522353235423552356235723582359236023612362236323642365236623672368236923702371237223732374237523762377237823792380238123822383238423852386238723882389239023912392239323942395239623972398239924002401240224032404240524062407240824092410241124122413241424152416241724182419242024212422242324242425242624272428242924302431243224332434243524362437243824392440244124422443244424452446244724482449245024512452245324542455245624572458245924602461246224632464246524662467246824692470247124722473247424752476247724782479248024812482248324842485248624872488248924902491249224932494249524962497249824992500250125022503250425052506250725082509251025112512251325142515251625172518251925202521252225232524252525262527252825292530253125322533253425352536253725382539254025412542254325442545254625472548254925502551255225532554255525562557255825592560256125622563256425652566256725682569257025712572257325742575257625772578257925802581258225832584258525862587258825892590259125922593259425952596259725982599260026012602260326042605260626072608260926102611261226132614261526162617261826192620262126222623262426252626262726282629263026312632263326342635263626372638263926402641264226432644264526462647264826492650265126522653265426552656265726582659266026612662266326642665266626672668266926702671267226732674267526762677267826792680268126822683268426852686268726882689269026912692269326942695269626972698269927002701270227032704270527062707270827092710271127122713271427152716271727182719272027212722272327242725272627272728272927302731273227332734273527362737273827392740274127422743274427452746274727482749275027512752275327542755275627572758275927602761276227632764276527662767276827692770277127722773277427752776277727782779278027812782278327842785278627872788278927902791279227932794279527962797279827992800280128022803280428052806280728082809281028112812281328142815281628172818281928202821282228232824282528262827282828292830283128322833283428352836283728382839284028412842284328442845284628472848284928502851285228532854285528562857285828592860286128622863286428652866286728682869287028712872287328742875287628772878287928802881288228832884288528862887288828892890289128922893289428952896289728982899290029012902290329042905290629072908290929102911291229132914291529162917291829192920292129222923292429252926292729282929293029312932293329342935293629372938293929402941294229432944294529462947294829492950295129522953295429552956295729582959296029612962296329642965296629672968296929702971297229732974297529762977297829792980298129822983298429852986298729882989299029912992299329942995299629972998299930003001300230033004300530063007300830093010301130123013301430153016301730183019302030213022302330243025302630273028302930303031303230333034303530363037303830393040304130423043304430453046304730483049305030513052305330543055305630573058305930603061306230633064306530663067306830693070307130723073307430753076307730783079308030813082308330843085308630873088308930903091309230933094309530963097309830993100310131023103310431053106310731083109311031113112311331143115311631173118311931203121312231233124312531263127312831293130313131323133313431353136313731383139314031413142314331443145314631473148314931503151315231533154315531563157315831593160316131623163316431653166316731683169317031713172317331743175317631773178317931803181318231833184318531863187318831893190319131923193319431953196319731983199320032013202320332043205320632073208320932103211321232133214321532163217321832193220322132223223322432253226322732283229323032313232323332343235323632373238323932403241324232433244324532463247324832493250325132523253325432553256325732583259326032613262326332643265326632673268326932703271327232733274327532763277327832793280328132823283328432853286328732883289329032913292329332943295329632973298329933003301330233033304330533063307330833093310331133123313331433153316331733183319332033213322332333243325332633273328332933303331333233333334333533363337333833393340334133423343334433453346334733483349335033513352335333543355335633573358335933603361336233633364336533663367336833693370337133723373337433753376337733783379338033813382338333843385338633873388338933903391339233933394339533963397339833993400340134023403340434053406340734083409341034113412341334143415341634173418341934203421342234233424342534263427342834293430343134323433343434353436343734383439344034413442344334443445344634473448344934503451345234533454345534563457345834593460346134623463346434653466346734683469347034713472347334743475347634773478347934803481348234833484348534863487348834893490349134923493349434953496349734983499350035013502350335043505350635073508350935103511351235133514351535163517351835193520352135223523352435253526352735283529353035313532353335343535353635373538353935403541
  1. package main
  2. import (
  3. "archive/tar"
  4. "encoding/json"
  5. "fmt"
  6. "io/ioutil"
  7. "os"
  8. "os/exec"
  9. "path"
  10. "path/filepath"
  11. "reflect"
  12. "regexp"
  13. "strings"
  14. "syscall"
  15. "testing"
  16. "time"
  17. "github.com/docker/docker/pkg/archive"
  18. )
  19. func TestBuildShCmdJSONEntrypoint(t *testing.T) {
  20. name := "testbuildshcmdjsonentrypoint"
  21. defer deleteImages(name)
  22. _, err := buildImage(
  23. name,
  24. `
  25. FROM busybox
  26. ENTRYPOINT ["/bin/echo"]
  27. CMD echo test
  28. `,
  29. true)
  30. if err != nil {
  31. t.Fatal(err)
  32. }
  33. out, _, err := runCommandWithOutput(
  34. exec.Command(
  35. dockerBinary,
  36. "run",
  37. "--rm",
  38. name))
  39. if err != nil {
  40. t.Fatal(err)
  41. }
  42. if strings.TrimSpace(out) != "/bin/sh -c echo test" {
  43. t.Fatal("CMD did not contain /bin/sh -c")
  44. }
  45. logDone("build - CMD should always contain /bin/sh -c when specified without JSON")
  46. }
  47. func TestBuildEnvironmentReplacementUser(t *testing.T) {
  48. name := "testbuildenvironmentreplacement"
  49. defer deleteImages(name)
  50. _, err := buildImage(name, `
  51. FROM scratch
  52. ENV user foo
  53. USER ${user}
  54. `, true)
  55. if err != nil {
  56. t.Fatal(err)
  57. }
  58. res, err := inspectFieldJSON(name, "Config.User")
  59. if err != nil {
  60. t.Fatal(err)
  61. }
  62. if res != `"foo"` {
  63. t.Fatal("User foo from environment not in Config.User on image")
  64. }
  65. logDone("build - user environment replacement")
  66. }
  67. func TestBuildEnvironmentReplacementVolume(t *testing.T) {
  68. name := "testbuildenvironmentreplacement"
  69. defer deleteImages(name)
  70. _, err := buildImage(name, `
  71. FROM scratch
  72. ENV volume /quux
  73. VOLUME ${volume}
  74. `, true)
  75. if err != nil {
  76. t.Fatal(err)
  77. }
  78. res, err := inspectFieldJSON(name, "Config.Volumes")
  79. if err != nil {
  80. t.Fatal(err)
  81. }
  82. var volumes map[string]interface{}
  83. if err := json.Unmarshal([]byte(res), &volumes); err != nil {
  84. t.Fatal(err)
  85. }
  86. if _, ok := volumes["/quux"]; !ok {
  87. t.Fatal("Volume /quux from environment not in Config.Volumes on image")
  88. }
  89. logDone("build - volume environment replacement")
  90. }
  91. func TestBuildEnvironmentReplacementExpose(t *testing.T) {
  92. name := "testbuildenvironmentreplacement"
  93. defer deleteImages(name)
  94. _, err := buildImage(name, `
  95. FROM scratch
  96. ENV port 80
  97. EXPOSE ${port}
  98. `, true)
  99. if err != nil {
  100. t.Fatal(err)
  101. }
  102. res, err := inspectFieldJSON(name, "Config.ExposedPorts")
  103. if err != nil {
  104. t.Fatal(err)
  105. }
  106. var exposedPorts map[string]interface{}
  107. if err := json.Unmarshal([]byte(res), &exposedPorts); err != nil {
  108. t.Fatal(err)
  109. }
  110. if _, ok := exposedPorts["80/tcp"]; !ok {
  111. t.Fatal("Exposed port 80 from environment not in Config.ExposedPorts on image")
  112. }
  113. logDone("build - expose environment replacement")
  114. }
  115. func TestBuildEnvironmentReplacementWorkdir(t *testing.T) {
  116. name := "testbuildenvironmentreplacement"
  117. defer deleteImages(name)
  118. _, err := buildImage(name, `
  119. FROM busybox
  120. ENV MYWORKDIR /work
  121. RUN mkdir ${MYWORKDIR}
  122. WORKDIR ${MYWORKDIR}
  123. `, true)
  124. if err != nil {
  125. t.Fatal(err)
  126. }
  127. logDone("build - workdir environment replacement")
  128. }
  129. func TestBuildEnvironmentReplacementAddCopy(t *testing.T) {
  130. name := "testbuildenvironmentreplacement"
  131. defer deleteImages(name)
  132. ctx, err := fakeContext(`
  133. FROM scratch
  134. ENV baz foo
  135. ENV quux bar
  136. ENV dot .
  137. ADD ${baz} ${dot}
  138. COPY ${quux} ${dot}
  139. `,
  140. map[string]string{
  141. "foo": "test1",
  142. "bar": "test2",
  143. })
  144. if err != nil {
  145. t.Fatal(err)
  146. }
  147. defer ctx.Close()
  148. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  149. t.Fatal(err)
  150. }
  151. logDone("build - add/copy environment replacement")
  152. }
  153. func TestBuildEnvironmentReplacementEnv(t *testing.T) {
  154. name := "testbuildenvironmentreplacement"
  155. defer deleteImages(name)
  156. _, err := buildImage(name,
  157. `
  158. FROM scratch
  159. ENV foo foo
  160. ENV bar ${foo}
  161. `, true)
  162. if err != nil {
  163. t.Fatal(err)
  164. }
  165. res, err := inspectFieldJSON(name, "Config.Env")
  166. if err != nil {
  167. t.Fatal(err)
  168. }
  169. envResult := []string{}
  170. if err = unmarshalJSON([]byte(res), &envResult); err != nil {
  171. t.Fatal(err)
  172. }
  173. found := false
  174. for _, env := range envResult {
  175. parts := strings.SplitN(env, "=", 2)
  176. if parts[0] == "bar" {
  177. found = true
  178. if parts[1] != "foo" {
  179. t.Fatalf("Could not find replaced var for env `bar`: got %q instead of `foo`", parts[1])
  180. }
  181. }
  182. }
  183. if !found {
  184. t.Fatal("Never found the `bar` env variable")
  185. }
  186. logDone("build - env environment replacement")
  187. }
  188. func TestBuildHandleEscapes(t *testing.T) {
  189. name := "testbuildhandleescapes"
  190. defer deleteImages(name)
  191. _, err := buildImage(name,
  192. `
  193. FROM scratch
  194. ENV FOO bar
  195. VOLUME ${FOO}
  196. `, true)
  197. if err != nil {
  198. t.Fatal(err)
  199. }
  200. var result map[string]map[string]struct{}
  201. res, err := inspectFieldJSON(name, "Config.Volumes")
  202. if err != nil {
  203. t.Fatal(err)
  204. }
  205. if err = unmarshalJSON([]byte(res), &result); err != nil {
  206. t.Fatal(err)
  207. }
  208. if _, ok := result["bar"]; !ok {
  209. t.Fatal("Could not find volume bar set from env foo in volumes table")
  210. }
  211. deleteImages(name)
  212. _, err = buildImage(name,
  213. `
  214. FROM scratch
  215. ENV FOO bar
  216. VOLUME \${FOO}
  217. `, true)
  218. if err != nil {
  219. t.Fatal(err)
  220. }
  221. res, err = inspectFieldJSON(name, "Config.Volumes")
  222. if err != nil {
  223. t.Fatal(err)
  224. }
  225. if err = unmarshalJSON([]byte(res), &result); err != nil {
  226. t.Fatal(err)
  227. }
  228. if _, ok := result["${FOO}"]; !ok {
  229. t.Fatal("Could not find volume ${FOO} set from env foo in volumes table")
  230. }
  231. deleteImages(name)
  232. // this test in particular provides *7* backslashes and expects 6 to come back.
  233. // Like above, the first escape is swallowed and the rest are treated as
  234. // literals, this one is just less obvious because of all the character noise.
  235. _, err = buildImage(name,
  236. `
  237. FROM scratch
  238. ENV FOO bar
  239. VOLUME \\\\\\\${FOO}
  240. `, true)
  241. if err != nil {
  242. t.Fatal(err)
  243. }
  244. res, err = inspectFieldJSON(name, "Config.Volumes")
  245. if err != nil {
  246. t.Fatal(err)
  247. }
  248. if err = unmarshalJSON([]byte(res), &result); err != nil {
  249. t.Fatal(err)
  250. }
  251. if _, ok := result[`\\\\\\${FOO}`]; !ok {
  252. t.Fatal(`Could not find volume \\\\\\${FOO} set from env foo in volumes table`)
  253. }
  254. logDone("build - handle escapes")
  255. }
  256. func TestBuildOnBuildLowercase(t *testing.T) {
  257. name := "testbuildonbuildlowercase"
  258. name2 := "testbuildonbuildlowercase2"
  259. defer deleteImages(name, name2)
  260. _, err := buildImage(name,
  261. `
  262. FROM busybox
  263. onbuild run echo quux
  264. `, true)
  265. if err != nil {
  266. t.Fatal(err)
  267. }
  268. _, out, err := buildImageWithOut(name2, fmt.Sprintf(`
  269. FROM %s
  270. `, name), true)
  271. if err != nil {
  272. t.Fatal(err)
  273. }
  274. if !strings.Contains(out, "quux") {
  275. t.Fatalf("Did not receive the expected echo text, got %s", out)
  276. }
  277. if strings.Contains(out, "ONBUILD ONBUILD") {
  278. t.Fatalf("Got an ONBUILD ONBUILD error with no error: got %s", out)
  279. }
  280. logDone("build - handle case-insensitive onbuild statement")
  281. }
  282. func TestBuildEnvEscapes(t *testing.T) {
  283. name := "testbuildenvescapes"
  284. defer deleteImages(name)
  285. defer deleteAllContainers()
  286. _, err := buildImage(name,
  287. `
  288. FROM busybox
  289. ENV TEST foo
  290. CMD echo \$
  291. `,
  292. true)
  293. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "-t", name))
  294. if err != nil {
  295. t.Fatal(err)
  296. }
  297. if strings.TrimSpace(out) != "$" {
  298. t.Fatalf("Env TEST was not overwritten with bar when foo was supplied to dockerfile: was %q", strings.TrimSpace(out))
  299. }
  300. logDone("build - env should handle \\$ properly")
  301. }
  302. func TestBuildEnvOverwrite(t *testing.T) {
  303. name := "testbuildenvoverwrite"
  304. defer deleteImages(name)
  305. defer deleteAllContainers()
  306. _, err := buildImage(name,
  307. `
  308. FROM busybox
  309. ENV TEST foo
  310. CMD echo ${TEST}
  311. `,
  312. true)
  313. if err != nil {
  314. t.Fatal(err)
  315. }
  316. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "-e", "TEST=bar", "-t", name))
  317. if err != nil {
  318. t.Fatal(err)
  319. }
  320. if strings.TrimSpace(out) != "bar" {
  321. t.Fatalf("Env TEST was not overwritten with bar when foo was supplied to dockerfile: was %q", strings.TrimSpace(out))
  322. }
  323. logDone("build - env should overwrite builder ENV during run")
  324. }
  325. func TestBuildOnBuildForbiddenMaintainerInSourceImage(t *testing.T) {
  326. name := "testbuildonbuildforbiddenmaintainerinsourceimage"
  327. defer deleteImages("onbuild")
  328. defer deleteImages(name)
  329. defer deleteAllContainers()
  330. createCmd := exec.Command(dockerBinary, "create", "busybox", "true")
  331. out, _, _, err := runCommandWithStdoutStderr(createCmd)
  332. if err != nil {
  333. t.Fatal(out, err)
  334. }
  335. cleanedContainerID := stripTrailingCharacters(out)
  336. commitCmd := exec.Command(dockerBinary, "commit", "--run", "{\"OnBuild\":[\"MAINTAINER docker.io\"]}", cleanedContainerID, "onbuild")
  337. if _, err := runCommand(commitCmd); err != nil {
  338. t.Fatal(err)
  339. }
  340. _, err = buildImage(name,
  341. `FROM onbuild`,
  342. true)
  343. if err != nil {
  344. if !strings.Contains(err.Error(), "maintainer isn't allowed as an ONBUILD trigger") {
  345. t.Fatalf("Wrong error %v, must be about MAINTAINER and ONBUILD in source image", err)
  346. }
  347. } else {
  348. t.Fatal("Error must not be nil")
  349. }
  350. logDone("build - onbuild forbidden maintainer in source image")
  351. }
  352. func TestBuildOnBuildForbiddenFromInSourceImage(t *testing.T) {
  353. name := "testbuildonbuildforbiddenfrominsourceimage"
  354. defer deleteImages("onbuild")
  355. defer deleteImages(name)
  356. defer deleteAllContainers()
  357. createCmd := exec.Command(dockerBinary, "create", "busybox", "true")
  358. out, _, _, err := runCommandWithStdoutStderr(createCmd)
  359. if err != nil {
  360. t.Fatal(out, err)
  361. }
  362. cleanedContainerID := stripTrailingCharacters(out)
  363. commitCmd := exec.Command(dockerBinary, "commit", "--run", "{\"OnBuild\":[\"FROM busybox\"]}", cleanedContainerID, "onbuild")
  364. if _, err := runCommand(commitCmd); err != nil {
  365. t.Fatal(err)
  366. }
  367. _, err = buildImage(name,
  368. `FROM onbuild`,
  369. true)
  370. if err != nil {
  371. if !strings.Contains(err.Error(), "from isn't allowed as an ONBUILD trigger") {
  372. t.Fatalf("Wrong error %v, must be about FROM and ONBUILD in source image", err)
  373. }
  374. } else {
  375. t.Fatal("Error must not be nil")
  376. }
  377. logDone("build - onbuild forbidden from in source image")
  378. }
  379. func TestBuildOnBuildForbiddenChainedInSourceImage(t *testing.T) {
  380. name := "testbuildonbuildforbiddenchainedinsourceimage"
  381. defer deleteImages("onbuild")
  382. defer deleteImages(name)
  383. defer deleteAllContainers()
  384. createCmd := exec.Command(dockerBinary, "create", "busybox", "true")
  385. out, _, _, err := runCommandWithStdoutStderr(createCmd)
  386. if err != nil {
  387. t.Fatal(out, err)
  388. }
  389. cleanedContainerID := stripTrailingCharacters(out)
  390. commitCmd := exec.Command(dockerBinary, "commit", "--run", "{\"OnBuild\":[\"ONBUILD RUN ls\"]}", cleanedContainerID, "onbuild")
  391. if _, err := runCommand(commitCmd); err != nil {
  392. t.Fatal(err)
  393. }
  394. _, err = buildImage(name,
  395. `FROM onbuild`,
  396. true)
  397. if err != nil {
  398. if !strings.Contains(err.Error(), "Chaining ONBUILD via `ONBUILD ONBUILD` isn't allowed") {
  399. t.Fatalf("Wrong error %v, must be about chaining ONBUILD in source image", err)
  400. }
  401. } else {
  402. t.Fatal("Error must not be nil")
  403. }
  404. logDone("build - onbuild forbidden chained in source image")
  405. }
  406. func TestBuildOnBuildCmdEntrypointJSON(t *testing.T) {
  407. name1 := "onbuildcmd"
  408. name2 := "onbuildgenerated"
  409. defer deleteImages(name2)
  410. defer deleteImages(name1)
  411. defer deleteAllContainers()
  412. _, err := buildImage(name1, `
  413. FROM busybox
  414. ONBUILD CMD ["hello world"]
  415. ONBUILD ENTRYPOINT ["echo"]
  416. ONBUILD RUN ["true"]`,
  417. false)
  418. if err != nil {
  419. t.Fatal(err)
  420. }
  421. _, err = buildImage(name2, fmt.Sprintf(`FROM %s`, name1), false)
  422. if err != nil {
  423. t.Fatal(err)
  424. }
  425. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "-t", name2))
  426. if err != nil {
  427. t.Fatal(err)
  428. }
  429. if !regexp.MustCompile(`(?m)^hello world`).MatchString(out) {
  430. t.Fatal("did not get echo output from onbuild", out)
  431. }
  432. logDone("build - onbuild with json entrypoint/cmd")
  433. }
  434. func TestBuildOnBuildEntrypointJSON(t *testing.T) {
  435. name1 := "onbuildcmd"
  436. name2 := "onbuildgenerated"
  437. defer deleteImages(name2)
  438. defer deleteImages(name1)
  439. defer deleteAllContainers()
  440. _, err := buildImage(name1, `
  441. FROM busybox
  442. ONBUILD ENTRYPOINT ["echo"]`,
  443. false)
  444. if err != nil {
  445. t.Fatal(err)
  446. }
  447. _, err = buildImage(name2, fmt.Sprintf("FROM %s\nCMD [\"hello world\"]\n", name1), false)
  448. if err != nil {
  449. t.Fatal(err)
  450. }
  451. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "-t", name2))
  452. if err != nil {
  453. t.Fatal(err)
  454. }
  455. if !regexp.MustCompile(`(?m)^hello world`).MatchString(out) {
  456. t.Fatal("got malformed output from onbuild", out)
  457. }
  458. logDone("build - onbuild with json entrypoint")
  459. }
  460. func TestBuildCacheADD(t *testing.T) {
  461. name := "testbuildtwoimageswithadd"
  462. defer deleteImages(name)
  463. server, err := fakeStorage(map[string]string{
  464. "robots.txt": "hello",
  465. "index.html": "world",
  466. })
  467. if err != nil {
  468. t.Fatal(err)
  469. }
  470. defer server.Close()
  471. if _, err := buildImage(name,
  472. fmt.Sprintf(`FROM scratch
  473. ADD %s/robots.txt /`, server.URL),
  474. true); err != nil {
  475. t.Fatal(err)
  476. }
  477. if err != nil {
  478. t.Fatal(err)
  479. }
  480. deleteImages(name)
  481. _, out, err := buildImageWithOut(name,
  482. fmt.Sprintf(`FROM scratch
  483. ADD %s/index.html /`, server.URL),
  484. true)
  485. if err != nil {
  486. t.Fatal(err)
  487. }
  488. if strings.Contains(out, "Using cache") {
  489. t.Fatal("2nd build used cache on ADD, it shouldn't")
  490. }
  491. logDone("build - build two images with remote ADD")
  492. }
  493. func TestBuildSixtySteps(t *testing.T) {
  494. name := "foobuildsixtysteps"
  495. defer deleteImages(name)
  496. ctx, err := fakeContext("FROM scratch\n"+strings.Repeat("ADD foo /\n", 60),
  497. map[string]string{
  498. "foo": "test1",
  499. })
  500. if err != nil {
  501. t.Fatal(err)
  502. }
  503. defer ctx.Close()
  504. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  505. t.Fatal(err)
  506. }
  507. logDone("build - build an image with sixty build steps")
  508. }
  509. func TestBuildAddSingleFileToRoot(t *testing.T) {
  510. name := "testaddimg"
  511. defer deleteImages(name)
  512. ctx, err := fakeContext(`FROM busybox
  513. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  514. RUN echo 'dockerio:x:1001:' >> /etc/group
  515. RUN touch /exists
  516. RUN chown dockerio.dockerio /exists
  517. ADD test_file /
  518. RUN [ $(ls -l /test_file | awk '{print $3":"$4}') = 'root:root' ]
  519. RUN [ $(ls -l /test_file | awk '{print $1}') = '-rw-r--r--' ]
  520. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  521. map[string]string{
  522. "test_file": "test1",
  523. })
  524. if err != nil {
  525. t.Fatal(err)
  526. }
  527. defer ctx.Close()
  528. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  529. t.Fatal(err)
  530. }
  531. logDone("build - add single file to root")
  532. }
  533. // Issue #3960: "ADD src ." hangs
  534. func TestBuildAddSingleFileToWorkdir(t *testing.T) {
  535. name := "testaddsinglefiletoworkdir"
  536. defer deleteImages(name)
  537. ctx, err := fakeContext(`FROM busybox
  538. ADD test_file .`,
  539. map[string]string{
  540. "test_file": "test1",
  541. })
  542. if err != nil {
  543. t.Fatal(err)
  544. }
  545. defer ctx.Close()
  546. done := make(chan struct{})
  547. go func() {
  548. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  549. t.Fatal(err)
  550. }
  551. close(done)
  552. }()
  553. select {
  554. case <-time.After(5 * time.Second):
  555. t.Fatal("Build with adding to workdir timed out")
  556. case <-done:
  557. }
  558. logDone("build - add single file to workdir")
  559. }
  560. func TestBuildAddSingleFileToExistDir(t *testing.T) {
  561. name := "testaddsinglefiletoexistdir"
  562. defer deleteImages(name)
  563. ctx, err := fakeContext(`FROM busybox
  564. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  565. RUN echo 'dockerio:x:1001:' >> /etc/group
  566. RUN mkdir /exists
  567. RUN touch /exists/exists_file
  568. RUN chown -R dockerio.dockerio /exists
  569. ADD test_file /exists/
  570. RUN [ $(ls -l / | grep exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]
  571. RUN [ $(ls -l /exists/test_file | awk '{print $3":"$4}') = 'root:root' ]
  572. RUN [ $(ls -l /exists/exists_file | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  573. map[string]string{
  574. "test_file": "test1",
  575. })
  576. if err != nil {
  577. t.Fatal(err)
  578. }
  579. defer ctx.Close()
  580. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  581. t.Fatal(err)
  582. }
  583. logDone("build - add single file to existing dir")
  584. }
  585. func TestBuildCopyAddMultipleFiles(t *testing.T) {
  586. name := "testcopymultiplefilestofile"
  587. defer deleteImages(name)
  588. ctx, err := fakeContext(`FROM busybox
  589. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  590. RUN echo 'dockerio:x:1001:' >> /etc/group
  591. RUN mkdir /exists
  592. RUN touch /exists/exists_file
  593. RUN chown -R dockerio.dockerio /exists
  594. COPY test_file1 test_file2 /exists/
  595. ADD test_file3 test_file4 https://docker.com/robots.txt /exists/
  596. RUN [ $(ls -l / | grep exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]
  597. RUN [ $(ls -l /exists/test_file1 | awk '{print $3":"$4}') = 'root:root' ]
  598. RUN [ $(ls -l /exists/test_file2 | awk '{print $3":"$4}') = 'root:root' ]
  599. RUN [ $(ls -l /exists/test_file3 | awk '{print $3":"$4}') = 'root:root' ]
  600. RUN [ $(ls -l /exists/test_file4 | awk '{print $3":"$4}') = 'root:root' ]
  601. RUN [ $(ls -l /exists/robots.txt | awk '{print $3":"$4}') = 'root:root' ]
  602. RUN [ $(ls -l /exists/exists_file | awk '{print $3":"$4}') = 'dockerio:dockerio' ]
  603. `,
  604. map[string]string{
  605. "test_file1": "test1",
  606. "test_file2": "test2",
  607. "test_file3": "test3",
  608. "test_file4": "test4",
  609. })
  610. defer ctx.Close()
  611. if err != nil {
  612. t.Fatal(err)
  613. }
  614. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  615. t.Fatal(err)
  616. }
  617. logDone("build - mulitple file copy/add tests")
  618. }
  619. func TestBuildAddMultipleFilesToFile(t *testing.T) {
  620. name := "testaddmultiplefilestofile"
  621. defer deleteImages(name)
  622. ctx, err := fakeContext(`FROM scratch
  623. ADD file1.txt file2.txt test
  624. `,
  625. map[string]string{
  626. "file1.txt": "test1",
  627. "file2.txt": "test1",
  628. })
  629. defer ctx.Close()
  630. if err != nil {
  631. t.Fatal(err)
  632. }
  633. expected := "When using ADD with more than one source file, the destination must be a directory and end with a /"
  634. if _, err := buildImageFromContext(name, ctx, true); err == nil || !strings.Contains(err.Error(), expected) {
  635. t.Fatalf("Wrong error: (should contain \"%s\") got:\n%v", expected, err)
  636. }
  637. logDone("build - multiple add files to file")
  638. }
  639. func TestBuildAddMultipleFilesToFileWild(t *testing.T) {
  640. name := "testaddmultiplefilestofilewild"
  641. defer deleteImages(name)
  642. ctx, err := fakeContext(`FROM scratch
  643. ADD file*.txt test
  644. `,
  645. map[string]string{
  646. "file1.txt": "test1",
  647. "file2.txt": "test1",
  648. })
  649. defer ctx.Close()
  650. if err != nil {
  651. t.Fatal(err)
  652. }
  653. expected := "When using ADD with more than one source file, the destination must be a directory and end with a /"
  654. if _, err := buildImageFromContext(name, ctx, true); err == nil || !strings.Contains(err.Error(), expected) {
  655. t.Fatalf("Wrong error: (should contain \"%s\") got:\n%v", expected, err)
  656. }
  657. logDone("build - multiple add files to file wild")
  658. }
  659. func TestBuildCopyMultipleFilesToFile(t *testing.T) {
  660. name := "testcopymultiplefilestofile"
  661. defer deleteImages(name)
  662. ctx, err := fakeContext(`FROM scratch
  663. COPY file1.txt file2.txt test
  664. `,
  665. map[string]string{
  666. "file1.txt": "test1",
  667. "file2.txt": "test1",
  668. })
  669. defer ctx.Close()
  670. if err != nil {
  671. t.Fatal(err)
  672. }
  673. expected := "When using COPY with more than one source file, the destination must be a directory and end with a /"
  674. if _, err := buildImageFromContext(name, ctx, true); err == nil || !strings.Contains(err.Error(), expected) {
  675. t.Fatalf("Wrong error: (should contain \"%s\") got:\n%v", expected, err)
  676. }
  677. logDone("build - multiple copy files to file")
  678. }
  679. func TestBuildCopyWildcard(t *testing.T) {
  680. name := "testcopywildcard"
  681. defer deleteImages(name)
  682. server, err := fakeStorage(map[string]string{
  683. "robots.txt": "hello",
  684. "index.html": "world",
  685. })
  686. if err != nil {
  687. t.Fatal(err)
  688. }
  689. defer server.Close()
  690. ctx, err := fakeContext(fmt.Sprintf(`FROM busybox
  691. COPY file*.txt /tmp/
  692. RUN ls /tmp/file1.txt /tmp/file2.txt
  693. RUN mkdir /tmp1
  694. COPY dir* /tmp1/
  695. RUN ls /tmp1/dirt /tmp1/nested_file /tmp1/nested_dir/nest_nest_file
  696. RUN mkdir /tmp2
  697. ADD dir/*dir %s/robots.txt /tmp2/
  698. RUN ls /tmp2/nest_nest_file /tmp2/robots.txt
  699. `, server.URL),
  700. map[string]string{
  701. "file1.txt": "test1",
  702. "file2.txt": "test2",
  703. "dir/nested_file": "nested file",
  704. "dir/nested_dir/nest_nest_file": "2 times nested",
  705. "dirt": "dirty",
  706. })
  707. defer ctx.Close()
  708. if err != nil {
  709. t.Fatal(err)
  710. }
  711. id1, err := buildImageFromContext(name, ctx, true)
  712. if err != nil {
  713. t.Fatal(err)
  714. }
  715. // Now make sure we use a cache the 2nd time
  716. id2, err := buildImageFromContext(name, ctx, true)
  717. if err != nil {
  718. t.Fatal(err)
  719. }
  720. if id1 != id2 {
  721. t.Fatal("didn't use the cache")
  722. }
  723. logDone("build - copy wild card")
  724. }
  725. func TestBuildCopyWildcardNoFind(t *testing.T) {
  726. name := "testcopywildcardnofind"
  727. defer deleteImages(name)
  728. ctx, err := fakeContext(`FROM busybox
  729. COPY file*.txt /tmp/
  730. `, nil)
  731. defer ctx.Close()
  732. if err != nil {
  733. t.Fatal(err)
  734. }
  735. _, err = buildImageFromContext(name, ctx, true)
  736. if err == nil {
  737. t.Fatal("should have failed to find a file")
  738. }
  739. if !strings.Contains(err.Error(), "No source files were specified") {
  740. t.Fatalf("Wrong error %v, must be about no source files", err)
  741. }
  742. logDone("build - copy wild card no find")
  743. }
  744. func TestBuildCopyWildcardCache(t *testing.T) {
  745. name := "testcopywildcardcache"
  746. defer deleteImages(name)
  747. ctx, err := fakeContext(`FROM busybox
  748. COPY file1.txt /tmp/`,
  749. map[string]string{
  750. "file1.txt": "test1",
  751. })
  752. defer ctx.Close()
  753. if err != nil {
  754. t.Fatal(err)
  755. }
  756. id1, err := buildImageFromContext(name, ctx, true)
  757. if err != nil {
  758. t.Fatal(err)
  759. }
  760. // Now make sure we use a cache the 2nd time even with wild cards.
  761. // Use the same context so the file is the same and the checksum will match
  762. ctx.Add("Dockerfile", `FROM busybox
  763. COPY file*.txt /tmp/`)
  764. id2, err := buildImageFromContext(name, ctx, true)
  765. if err != nil {
  766. t.Fatal(err)
  767. }
  768. if id1 != id2 {
  769. t.Fatal("didn't use the cache")
  770. }
  771. logDone("build - copy wild card cache")
  772. }
  773. func TestBuildAddSingleFileToNonExistingDir(t *testing.T) {
  774. name := "testaddsinglefiletononexistingdir"
  775. defer deleteImages(name)
  776. ctx, err := fakeContext(`FROM busybox
  777. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  778. RUN echo 'dockerio:x:1001:' >> /etc/group
  779. RUN touch /exists
  780. RUN chown dockerio.dockerio /exists
  781. ADD test_file /test_dir/
  782. RUN [ $(ls -l / | grep test_dir | awk '{print $3":"$4}') = 'root:root' ]
  783. RUN [ $(ls -l /test_dir/test_file | awk '{print $3":"$4}') = 'root:root' ]
  784. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  785. map[string]string{
  786. "test_file": "test1",
  787. })
  788. if err != nil {
  789. t.Fatal(err)
  790. }
  791. defer ctx.Close()
  792. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  793. t.Fatal(err)
  794. }
  795. logDone("build - add single file to non-existing dir")
  796. }
  797. func TestBuildAddDirContentToRoot(t *testing.T) {
  798. name := "testadddircontenttoroot"
  799. defer deleteImages(name)
  800. ctx, err := fakeContext(`FROM busybox
  801. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  802. RUN echo 'dockerio:x:1001:' >> /etc/group
  803. RUN touch /exists
  804. RUN chown dockerio.dockerio exists
  805. ADD test_dir /
  806. RUN [ $(ls -l /test_file | awk '{print $3":"$4}') = 'root:root' ]
  807. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  808. map[string]string{
  809. "test_dir/test_file": "test1",
  810. })
  811. if err != nil {
  812. t.Fatal(err)
  813. }
  814. defer ctx.Close()
  815. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  816. t.Fatal(err)
  817. }
  818. logDone("build - add directory contents to root")
  819. }
  820. func TestBuildAddDirContentToExistingDir(t *testing.T) {
  821. name := "testadddircontenttoexistingdir"
  822. defer deleteImages(name)
  823. ctx, err := fakeContext(`FROM busybox
  824. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  825. RUN echo 'dockerio:x:1001:' >> /etc/group
  826. RUN mkdir /exists
  827. RUN touch /exists/exists_file
  828. RUN chown -R dockerio.dockerio /exists
  829. ADD test_dir/ /exists/
  830. RUN [ $(ls -l / | grep exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]
  831. RUN [ $(ls -l /exists/exists_file | awk '{print $3":"$4}') = 'dockerio:dockerio' ]
  832. RUN [ $(ls -l /exists/test_file | awk '{print $3":"$4}') = 'root:root' ]`,
  833. map[string]string{
  834. "test_dir/test_file": "test1",
  835. })
  836. if err != nil {
  837. t.Fatal(err)
  838. }
  839. defer ctx.Close()
  840. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  841. t.Fatal(err)
  842. }
  843. logDone("build - add directory contents to existing dir")
  844. }
  845. func TestBuildAddWholeDirToRoot(t *testing.T) {
  846. name := "testaddwholedirtoroot"
  847. defer deleteImages(name)
  848. ctx, err := fakeContext(`FROM busybox
  849. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  850. RUN echo 'dockerio:x:1001:' >> /etc/group
  851. RUN touch /exists
  852. RUN chown dockerio.dockerio exists
  853. ADD test_dir /test_dir
  854. RUN [ $(ls -l / | grep test_dir | awk '{print $3":"$4}') = 'root:root' ]
  855. RUN [ $(ls -l / | grep test_dir | awk '{print $1}') = 'drwxr-xr-x' ]
  856. RUN [ $(ls -l /test_dir/test_file | awk '{print $3":"$4}') = 'root:root' ]
  857. RUN [ $(ls -l /test_dir/test_file | awk '{print $1}') = '-rw-r--r--' ]
  858. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  859. map[string]string{
  860. "test_dir/test_file": "test1",
  861. })
  862. if err != nil {
  863. t.Fatal(err)
  864. }
  865. defer ctx.Close()
  866. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  867. t.Fatal(err)
  868. }
  869. logDone("build - add whole directory to root")
  870. }
  871. // Testing #5941
  872. func TestBuildAddEtcToRoot(t *testing.T) {
  873. name := "testaddetctoroot"
  874. defer deleteImages(name)
  875. ctx, err := fakeContext(`FROM scratch
  876. ADD . /`,
  877. map[string]string{
  878. "etc/test_file": "test1",
  879. })
  880. if err != nil {
  881. t.Fatal(err)
  882. }
  883. defer ctx.Close()
  884. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  885. t.Fatal(err)
  886. }
  887. logDone("build - add etc directory to root")
  888. }
  889. func TestBuildCopySingleFileToRoot(t *testing.T) {
  890. name := "testcopysinglefiletoroot"
  891. defer deleteImages(name)
  892. ctx, err := fakeContext(`FROM busybox
  893. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  894. RUN echo 'dockerio:x:1001:' >> /etc/group
  895. RUN touch /exists
  896. RUN chown dockerio.dockerio /exists
  897. COPY test_file /
  898. RUN [ $(ls -l /test_file | awk '{print $3":"$4}') = 'root:root' ]
  899. RUN [ $(ls -l /test_file | awk '{print $1}') = '-rw-r--r--' ]
  900. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  901. map[string]string{
  902. "test_file": "test1",
  903. })
  904. if err != nil {
  905. t.Fatal(err)
  906. }
  907. defer ctx.Close()
  908. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  909. t.Fatal(err)
  910. }
  911. logDone("build - copy single file to root")
  912. }
  913. // Issue #3960: "ADD src ." hangs - adapted for COPY
  914. func TestBuildCopySingleFileToWorkdir(t *testing.T) {
  915. name := "testcopysinglefiletoworkdir"
  916. defer deleteImages(name)
  917. ctx, err := fakeContext(`FROM busybox
  918. COPY test_file .`,
  919. map[string]string{
  920. "test_file": "test1",
  921. })
  922. if err != nil {
  923. t.Fatal(err)
  924. }
  925. defer ctx.Close()
  926. done := make(chan struct{})
  927. go func() {
  928. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  929. t.Fatal(err)
  930. }
  931. close(done)
  932. }()
  933. select {
  934. case <-time.After(5 * time.Second):
  935. t.Fatal("Build with adding to workdir timed out")
  936. case <-done:
  937. }
  938. logDone("build - copy single file to workdir")
  939. }
  940. func TestBuildCopySingleFileToExistDir(t *testing.T) {
  941. name := "testcopysinglefiletoexistdir"
  942. defer deleteImages(name)
  943. ctx, err := fakeContext(`FROM busybox
  944. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  945. RUN echo 'dockerio:x:1001:' >> /etc/group
  946. RUN mkdir /exists
  947. RUN touch /exists/exists_file
  948. RUN chown -R dockerio.dockerio /exists
  949. COPY test_file /exists/
  950. RUN [ $(ls -l / | grep exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]
  951. RUN [ $(ls -l /exists/test_file | awk '{print $3":"$4}') = 'root:root' ]
  952. RUN [ $(ls -l /exists/exists_file | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  953. map[string]string{
  954. "test_file": "test1",
  955. })
  956. if err != nil {
  957. t.Fatal(err)
  958. }
  959. defer ctx.Close()
  960. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  961. t.Fatal(err)
  962. }
  963. logDone("build - copy single file to existing dir")
  964. }
  965. func TestBuildCopySingleFileToNonExistDir(t *testing.T) {
  966. name := "testcopysinglefiletononexistdir"
  967. defer deleteImages(name)
  968. ctx, err := fakeContext(`FROM busybox
  969. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  970. RUN echo 'dockerio:x:1001:' >> /etc/group
  971. RUN touch /exists
  972. RUN chown dockerio.dockerio /exists
  973. COPY test_file /test_dir/
  974. RUN [ $(ls -l / | grep test_dir | awk '{print $3":"$4}') = 'root:root' ]
  975. RUN [ $(ls -l /test_dir/test_file | awk '{print $3":"$4}') = 'root:root' ]
  976. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  977. map[string]string{
  978. "test_file": "test1",
  979. })
  980. if err != nil {
  981. t.Fatal(err)
  982. }
  983. defer ctx.Close()
  984. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  985. t.Fatal(err)
  986. }
  987. logDone("build - copy single file to non-existing dir")
  988. }
  989. func TestBuildCopyDirContentToRoot(t *testing.T) {
  990. name := "testcopydircontenttoroot"
  991. defer deleteImages(name)
  992. ctx, err := fakeContext(`FROM busybox
  993. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  994. RUN echo 'dockerio:x:1001:' >> /etc/group
  995. RUN touch /exists
  996. RUN chown dockerio.dockerio exists
  997. COPY test_dir /
  998. RUN [ $(ls -l /test_file | awk '{print $3":"$4}') = 'root:root' ]
  999. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  1000. map[string]string{
  1001. "test_dir/test_file": "test1",
  1002. })
  1003. if err != nil {
  1004. t.Fatal(err)
  1005. }
  1006. defer ctx.Close()
  1007. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1008. t.Fatal(err)
  1009. }
  1010. logDone("build - copy directory contents to root")
  1011. }
  1012. func TestBuildCopyDirContentToExistDir(t *testing.T) {
  1013. name := "testcopydircontenttoexistdir"
  1014. defer deleteImages(name)
  1015. ctx, err := fakeContext(`FROM busybox
  1016. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  1017. RUN echo 'dockerio:x:1001:' >> /etc/group
  1018. RUN mkdir /exists
  1019. RUN touch /exists/exists_file
  1020. RUN chown -R dockerio.dockerio /exists
  1021. COPY test_dir/ /exists/
  1022. RUN [ $(ls -l / | grep exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]
  1023. RUN [ $(ls -l /exists/exists_file | awk '{print $3":"$4}') = 'dockerio:dockerio' ]
  1024. RUN [ $(ls -l /exists/test_file | awk '{print $3":"$4}') = 'root:root' ]`,
  1025. map[string]string{
  1026. "test_dir/test_file": "test1",
  1027. })
  1028. if err != nil {
  1029. t.Fatal(err)
  1030. }
  1031. defer ctx.Close()
  1032. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1033. t.Fatal(err)
  1034. }
  1035. logDone("build - copy directory contents to existing dir")
  1036. }
  1037. func TestBuildCopyWholeDirToRoot(t *testing.T) {
  1038. name := "testcopywholedirtoroot"
  1039. defer deleteImages(name)
  1040. ctx, err := fakeContext(`FROM busybox
  1041. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  1042. RUN echo 'dockerio:x:1001:' >> /etc/group
  1043. RUN touch /exists
  1044. RUN chown dockerio.dockerio exists
  1045. COPY test_dir /test_dir
  1046. RUN [ $(ls -l / | grep test_dir | awk '{print $3":"$4}') = 'root:root' ]
  1047. RUN [ $(ls -l / | grep test_dir | awk '{print $1}') = 'drwxr-xr-x' ]
  1048. RUN [ $(ls -l /test_dir/test_file | awk '{print $3":"$4}') = 'root:root' ]
  1049. RUN [ $(ls -l /test_dir/test_file | awk '{print $1}') = '-rw-r--r--' ]
  1050. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  1051. map[string]string{
  1052. "test_dir/test_file": "test1",
  1053. })
  1054. if err != nil {
  1055. t.Fatal(err)
  1056. }
  1057. defer ctx.Close()
  1058. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1059. t.Fatal(err)
  1060. }
  1061. logDone("build - copy whole directory to root")
  1062. }
  1063. func TestBuildCopyEtcToRoot(t *testing.T) {
  1064. name := "testcopyetctoroot"
  1065. defer deleteImages(name)
  1066. ctx, err := fakeContext(`FROM scratch
  1067. COPY . /`,
  1068. map[string]string{
  1069. "etc/test_file": "test1",
  1070. })
  1071. if err != nil {
  1072. t.Fatal(err)
  1073. }
  1074. defer ctx.Close()
  1075. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1076. t.Fatal(err)
  1077. }
  1078. logDone("build - copy etc directory to root")
  1079. }
  1080. func TestBuildCopyDisallowRemote(t *testing.T) {
  1081. name := "testcopydisallowremote"
  1082. defer deleteImages(name)
  1083. _, out, err := buildImageWithOut(name, `FROM scratch
  1084. COPY https://index.docker.io/robots.txt /`,
  1085. true)
  1086. if err == nil || !strings.Contains(out, "Source can't be a URL for COPY") {
  1087. t.Fatalf("Error should be about disallowed remote source, got err: %s, out: %q", err, out)
  1088. }
  1089. logDone("build - copy - disallow copy from remote")
  1090. }
  1091. // Issue #5270 - ensure we throw a better error than "unexpected EOF"
  1092. // when we can't access files in the context.
  1093. func TestBuildWithInaccessibleFilesInContext(t *testing.T) {
  1094. {
  1095. name := "testbuildinaccessiblefiles"
  1096. defer deleteImages(name)
  1097. ctx, err := fakeContext("FROM scratch\nADD . /foo/", map[string]string{"fileWithoutReadAccess": "foo"})
  1098. if err != nil {
  1099. t.Fatal(err)
  1100. }
  1101. defer ctx.Close()
  1102. // This is used to ensure we detect inaccessible files early during build in the cli client
  1103. pathToFileWithoutReadAccess := filepath.Join(ctx.Dir, "fileWithoutReadAccess")
  1104. if err = os.Chown(pathToFileWithoutReadAccess, 0, 0); err != nil {
  1105. t.Fatalf("failed to chown file to root: %s", err)
  1106. }
  1107. if err = os.Chmod(pathToFileWithoutReadAccess, 0700); err != nil {
  1108. t.Fatalf("failed to chmod file to 700: %s", err)
  1109. }
  1110. buildCmd := exec.Command("su", "unprivilegeduser", "-c", fmt.Sprintf("%s build -t %s .", dockerBinary, name))
  1111. buildCmd.Dir = ctx.Dir
  1112. out, _, err := runCommandWithOutput(buildCmd)
  1113. if err == nil {
  1114. t.Fatalf("build should have failed: %s %s", err, out)
  1115. }
  1116. // check if we've detected the failure before we started building
  1117. if !strings.Contains(out, "no permission to read from ") {
  1118. t.Fatalf("output should've contained the string: no permission to read from but contained: %s", out)
  1119. }
  1120. if !strings.Contains(out, "Error checking context is accessible") {
  1121. t.Fatalf("output should've contained the string: Error checking context is accessible")
  1122. }
  1123. }
  1124. {
  1125. name := "testbuildinaccessibledirectory"
  1126. defer deleteImages(name)
  1127. ctx, err := fakeContext("FROM scratch\nADD . /foo/", map[string]string{"directoryWeCantStat/bar": "foo"})
  1128. if err != nil {
  1129. t.Fatal(err)
  1130. }
  1131. defer ctx.Close()
  1132. // This is used to ensure we detect inaccessible directories early during build in the cli client
  1133. pathToDirectoryWithoutReadAccess := filepath.Join(ctx.Dir, "directoryWeCantStat")
  1134. pathToFileInDirectoryWithoutReadAccess := filepath.Join(pathToDirectoryWithoutReadAccess, "bar")
  1135. if err = os.Chown(pathToDirectoryWithoutReadAccess, 0, 0); err != nil {
  1136. t.Fatalf("failed to chown directory to root: %s", err)
  1137. }
  1138. if err = os.Chmod(pathToDirectoryWithoutReadAccess, 0444); err != nil {
  1139. t.Fatalf("failed to chmod directory to 755: %s", err)
  1140. }
  1141. if err = os.Chmod(pathToFileInDirectoryWithoutReadAccess, 0700); err != nil {
  1142. t.Fatalf("failed to chmod file to 444: %s", err)
  1143. }
  1144. buildCmd := exec.Command("su", "unprivilegeduser", "-c", fmt.Sprintf("%s build -t %s .", dockerBinary, name))
  1145. buildCmd.Dir = ctx.Dir
  1146. out, _, err := runCommandWithOutput(buildCmd)
  1147. if err == nil {
  1148. t.Fatalf("build should have failed: %s %s", err, out)
  1149. }
  1150. // check if we've detected the failure before we started building
  1151. if !strings.Contains(out, "can't stat") {
  1152. t.Fatalf("output should've contained the string: can't access %s", out)
  1153. }
  1154. if !strings.Contains(out, "Error checking context is accessible") {
  1155. t.Fatalf("output should've contained the string: Error checking context is accessible")
  1156. }
  1157. }
  1158. {
  1159. name := "testlinksok"
  1160. defer deleteImages(name)
  1161. ctx, err := fakeContext("FROM scratch\nADD . /foo/", nil)
  1162. if err != nil {
  1163. t.Fatal(err)
  1164. }
  1165. defer ctx.Close()
  1166. target := "../../../../../../../../../../../../../../../../../../../azA"
  1167. if err := os.Symlink(filepath.Join(ctx.Dir, "g"), target); err != nil {
  1168. t.Fatal(err)
  1169. }
  1170. defer os.Remove(target)
  1171. // This is used to ensure we don't follow links when checking if everything in the context is accessible
  1172. // This test doesn't require that we run commands as an unprivileged user
  1173. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1174. t.Fatal(err)
  1175. }
  1176. }
  1177. {
  1178. name := "testbuildignoredinaccessible"
  1179. defer deleteImages(name)
  1180. ctx, err := fakeContext("FROM scratch\nADD . /foo/",
  1181. map[string]string{
  1182. "directoryWeCantStat/bar": "foo",
  1183. ".dockerignore": "directoryWeCantStat",
  1184. })
  1185. if err != nil {
  1186. t.Fatal(err)
  1187. }
  1188. defer ctx.Close()
  1189. // This is used to ensure we don't try to add inaccessible files when they are ignored by a .dockerignore pattern
  1190. pathToDirectoryWithoutReadAccess := filepath.Join(ctx.Dir, "directoryWeCantStat")
  1191. pathToFileInDirectoryWithoutReadAccess := filepath.Join(pathToDirectoryWithoutReadAccess, "bar")
  1192. if err = os.Chown(pathToDirectoryWithoutReadAccess, 0, 0); err != nil {
  1193. t.Fatalf("failed to chown directory to root: %s", err)
  1194. }
  1195. if err = os.Chmod(pathToDirectoryWithoutReadAccess, 0444); err != nil {
  1196. t.Fatalf("failed to chmod directory to 755: %s", err)
  1197. }
  1198. if err = os.Chmod(pathToFileInDirectoryWithoutReadAccess, 0700); err != nil {
  1199. t.Fatalf("failed to chmod file to 444: %s", err)
  1200. }
  1201. buildCmd := exec.Command("su", "unprivilegeduser", "-c", fmt.Sprintf("%s build -t %s .", dockerBinary, name))
  1202. buildCmd.Dir = ctx.Dir
  1203. if out, _, err := runCommandWithOutput(buildCmd); err != nil {
  1204. t.Fatalf("build should have worked: %s %s", err, out)
  1205. }
  1206. }
  1207. logDone("build - ADD from context with inaccessible files must fail")
  1208. logDone("build - ADD from context with accessible links must work")
  1209. logDone("build - ADD from context with ignored inaccessible files must work")
  1210. }
  1211. func TestBuildForceRm(t *testing.T) {
  1212. containerCountBefore, err := getContainerCount()
  1213. if err != nil {
  1214. t.Fatalf("failed to get the container count: %s", err)
  1215. }
  1216. name := "testbuildforcerm"
  1217. defer deleteImages(name)
  1218. ctx, err := fakeContext("FROM scratch\nRUN true\nRUN thiswillfail", nil)
  1219. if err != nil {
  1220. t.Fatal(err)
  1221. }
  1222. defer ctx.Close()
  1223. buildCmd := exec.Command(dockerBinary, "build", "-t", name, "--force-rm", ".")
  1224. buildCmd.Dir = ctx.Dir
  1225. if out, _, err := runCommandWithOutput(buildCmd); err == nil {
  1226. t.Fatalf("failed to build the image: %s, %v", out, err)
  1227. }
  1228. containerCountAfter, err := getContainerCount()
  1229. if err != nil {
  1230. t.Fatalf("failed to get the container count: %s", err)
  1231. }
  1232. if containerCountBefore != containerCountAfter {
  1233. t.Fatalf("--force-rm shouldn't have left containers behind")
  1234. }
  1235. logDone("build - ensure --force-rm doesn't leave containers behind")
  1236. }
  1237. func TestBuildRm(t *testing.T) {
  1238. name := "testbuildrm"
  1239. defer deleteImages(name)
  1240. ctx, err := fakeContext("FROM scratch\nADD foo /\nADD foo /", map[string]string{"foo": "bar"})
  1241. if err != nil {
  1242. t.Fatal(err)
  1243. }
  1244. defer ctx.Close()
  1245. {
  1246. containerCountBefore, err := getContainerCount()
  1247. if err != nil {
  1248. t.Fatalf("failed to get the container count: %s", err)
  1249. }
  1250. out, _, err := dockerCmdInDir(t, ctx.Dir, "build", "--rm", "-t", name, ".")
  1251. if err != nil {
  1252. t.Fatal("failed to build the image", out)
  1253. }
  1254. containerCountAfter, err := getContainerCount()
  1255. if err != nil {
  1256. t.Fatalf("failed to get the container count: %s", err)
  1257. }
  1258. if containerCountBefore != containerCountAfter {
  1259. t.Fatalf("-rm shouldn't have left containers behind")
  1260. }
  1261. deleteImages(name)
  1262. }
  1263. {
  1264. containerCountBefore, err := getContainerCount()
  1265. if err != nil {
  1266. t.Fatalf("failed to get the container count: %s", err)
  1267. }
  1268. out, _, err := dockerCmdInDir(t, ctx.Dir, "build", "-t", name, ".")
  1269. if err != nil {
  1270. t.Fatal("failed to build the image", out)
  1271. }
  1272. containerCountAfter, err := getContainerCount()
  1273. if err != nil {
  1274. t.Fatalf("failed to get the container count: %s", err)
  1275. }
  1276. if containerCountBefore != containerCountAfter {
  1277. t.Fatalf("--rm shouldn't have left containers behind")
  1278. }
  1279. deleteImages(name)
  1280. }
  1281. {
  1282. containerCountBefore, err := getContainerCount()
  1283. if err != nil {
  1284. t.Fatalf("failed to get the container count: %s", err)
  1285. }
  1286. out, _, err := dockerCmdInDir(t, ctx.Dir, "build", "--rm=false", "-t", name, ".")
  1287. if err != nil {
  1288. t.Fatal("failed to build the image", out)
  1289. }
  1290. containerCountAfter, err := getContainerCount()
  1291. if err != nil {
  1292. t.Fatalf("failed to get the container count: %s", err)
  1293. }
  1294. if containerCountBefore == containerCountAfter {
  1295. t.Fatalf("--rm=false should have left containers behind")
  1296. }
  1297. deleteAllContainers()
  1298. deleteImages(name)
  1299. }
  1300. logDone("build - ensure --rm doesn't leave containers behind and that --rm=true is the default")
  1301. logDone("build - ensure --rm=false overrides the default")
  1302. }
  1303. func TestBuildWithVolumes(t *testing.T) {
  1304. var (
  1305. result map[string]map[string]struct{}
  1306. name = "testbuildvolumes"
  1307. emptyMap = make(map[string]struct{})
  1308. expected = map[string]map[string]struct{}{
  1309. "/test1": emptyMap,
  1310. "/test2": emptyMap,
  1311. "/test3": emptyMap,
  1312. "/test4": emptyMap,
  1313. "/test5": emptyMap,
  1314. "/test6": emptyMap,
  1315. "[/test7": emptyMap,
  1316. "/test8]": emptyMap,
  1317. }
  1318. )
  1319. defer deleteImages(name)
  1320. _, err := buildImage(name,
  1321. `FROM scratch
  1322. VOLUME /test1
  1323. VOLUME /test2
  1324. VOLUME /test3 /test4
  1325. VOLUME ["/test5", "/test6"]
  1326. VOLUME [/test7 /test8]
  1327. `,
  1328. true)
  1329. if err != nil {
  1330. t.Fatal(err)
  1331. }
  1332. res, err := inspectFieldJSON(name, "Config.Volumes")
  1333. if err != nil {
  1334. t.Fatal(err)
  1335. }
  1336. err = unmarshalJSON([]byte(res), &result)
  1337. if err != nil {
  1338. t.Fatal(err)
  1339. }
  1340. equal := reflect.DeepEqual(&result, &expected)
  1341. if !equal {
  1342. t.Fatalf("Volumes %s, expected %s", result, expected)
  1343. }
  1344. logDone("build - with volumes")
  1345. }
  1346. func TestBuildMaintainer(t *testing.T) {
  1347. name := "testbuildmaintainer"
  1348. expected := "dockerio"
  1349. defer deleteImages(name)
  1350. _, err := buildImage(name,
  1351. `FROM scratch
  1352. MAINTAINER dockerio`,
  1353. true)
  1354. if err != nil {
  1355. t.Fatal(err)
  1356. }
  1357. res, err := inspectField(name, "Author")
  1358. if err != nil {
  1359. t.Fatal(err)
  1360. }
  1361. if res != expected {
  1362. t.Fatalf("Maintainer %s, expected %s", res, expected)
  1363. }
  1364. logDone("build - maintainer")
  1365. }
  1366. func TestBuildUser(t *testing.T) {
  1367. name := "testbuilduser"
  1368. expected := "dockerio"
  1369. defer deleteImages(name)
  1370. _, err := buildImage(name,
  1371. `FROM busybox
  1372. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  1373. USER dockerio
  1374. RUN [ $(whoami) = 'dockerio' ]`,
  1375. true)
  1376. if err != nil {
  1377. t.Fatal(err)
  1378. }
  1379. res, err := inspectField(name, "Config.User")
  1380. if err != nil {
  1381. t.Fatal(err)
  1382. }
  1383. if res != expected {
  1384. t.Fatalf("User %s, expected %s", res, expected)
  1385. }
  1386. logDone("build - user")
  1387. }
  1388. func TestBuildRelativeWorkdir(t *testing.T) {
  1389. name := "testbuildrelativeworkdir"
  1390. expected := "/test2/test3"
  1391. defer deleteImages(name)
  1392. _, err := buildImage(name,
  1393. `FROM busybox
  1394. RUN [ "$PWD" = '/' ]
  1395. WORKDIR test1
  1396. RUN [ "$PWD" = '/test1' ]
  1397. WORKDIR /test2
  1398. RUN [ "$PWD" = '/test2' ]
  1399. WORKDIR test3
  1400. RUN [ "$PWD" = '/test2/test3' ]`,
  1401. true)
  1402. if err != nil {
  1403. t.Fatal(err)
  1404. }
  1405. res, err := inspectField(name, "Config.WorkingDir")
  1406. if err != nil {
  1407. t.Fatal(err)
  1408. }
  1409. if res != expected {
  1410. t.Fatalf("Workdir %s, expected %s", res, expected)
  1411. }
  1412. logDone("build - relative workdir")
  1413. }
  1414. func TestBuildWorkdirWithEnvVariables(t *testing.T) {
  1415. name := "testbuildworkdirwithenvvariables"
  1416. expected := "/test1/test2/$MISSING_VAR"
  1417. defer deleteImages(name)
  1418. _, err := buildImage(name,
  1419. `FROM busybox
  1420. ENV DIRPATH /test1
  1421. ENV SUBDIRNAME test2
  1422. WORKDIR $DIRPATH
  1423. WORKDIR $SUBDIRNAME/$MISSING_VAR`,
  1424. true)
  1425. if err != nil {
  1426. t.Fatal(err)
  1427. }
  1428. res, err := inspectField(name, "Config.WorkingDir")
  1429. if err != nil {
  1430. t.Fatal(err)
  1431. }
  1432. if res != expected {
  1433. t.Fatalf("Workdir %s, expected %s", res, expected)
  1434. }
  1435. logDone("build - workdir with env variables")
  1436. }
  1437. func TestBuildEnv(t *testing.T) {
  1438. name := "testbuildenv"
  1439. expected := "[PATH=/test:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PORT=2375]"
  1440. defer deleteImages(name)
  1441. _, err := buildImage(name,
  1442. `FROM busybox
  1443. ENV PATH /test:$PATH
  1444. ENV PORT 2375
  1445. RUN [ $(env | grep PORT) = 'PORT=2375' ]`,
  1446. true)
  1447. if err != nil {
  1448. t.Fatal(err)
  1449. }
  1450. res, err := inspectField(name, "Config.Env")
  1451. if err != nil {
  1452. t.Fatal(err)
  1453. }
  1454. if res != expected {
  1455. t.Fatalf("Env %s, expected %s", res, expected)
  1456. }
  1457. logDone("build - env")
  1458. }
  1459. func TestBuildContextCleanup(t *testing.T) {
  1460. name := "testbuildcontextcleanup"
  1461. defer deleteImages(name)
  1462. entries, err := ioutil.ReadDir("/var/lib/docker/tmp")
  1463. if err != nil {
  1464. t.Fatalf("failed to list contents of tmp dir: %s", err)
  1465. }
  1466. _, err = buildImage(name,
  1467. `FROM scratch
  1468. ENTRYPOINT ["/bin/echo"]`,
  1469. true)
  1470. if err != nil {
  1471. t.Fatal(err)
  1472. }
  1473. entriesFinal, err := ioutil.ReadDir("/var/lib/docker/tmp")
  1474. if err != nil {
  1475. t.Fatalf("failed to list contents of tmp dir: %s", err)
  1476. }
  1477. if err = compareDirectoryEntries(entries, entriesFinal); err != nil {
  1478. t.Fatalf("context should have been deleted, but wasn't")
  1479. }
  1480. logDone("build - verify context cleanup works properly")
  1481. }
  1482. func TestBuildContextCleanupFailedBuild(t *testing.T) {
  1483. name := "testbuildcontextcleanup"
  1484. defer deleteImages(name)
  1485. defer deleteAllContainers()
  1486. entries, err := ioutil.ReadDir("/var/lib/docker/tmp")
  1487. if err != nil {
  1488. t.Fatalf("failed to list contents of tmp dir: %s", err)
  1489. }
  1490. _, err = buildImage(name,
  1491. `FROM scratch
  1492. RUN /non/existing/command`,
  1493. true)
  1494. if err == nil {
  1495. t.Fatalf("expected build to fail, but it didn't")
  1496. }
  1497. entriesFinal, err := ioutil.ReadDir("/var/lib/docker/tmp")
  1498. if err != nil {
  1499. t.Fatalf("failed to list contents of tmp dir: %s", err)
  1500. }
  1501. if err = compareDirectoryEntries(entries, entriesFinal); err != nil {
  1502. t.Fatalf("context should have been deleted, but wasn't")
  1503. }
  1504. logDone("build - verify context cleanup works properly after a failed build")
  1505. }
  1506. func TestBuildCmd(t *testing.T) {
  1507. name := "testbuildcmd"
  1508. expected := "[/bin/echo Hello World]"
  1509. defer deleteImages(name)
  1510. _, err := buildImage(name,
  1511. `FROM scratch
  1512. CMD ["/bin/echo", "Hello World"]`,
  1513. true)
  1514. if err != nil {
  1515. t.Fatal(err)
  1516. }
  1517. res, err := inspectField(name, "Config.Cmd")
  1518. if err != nil {
  1519. t.Fatal(err)
  1520. }
  1521. if res != expected {
  1522. t.Fatalf("Cmd %s, expected %s", res, expected)
  1523. }
  1524. logDone("build - cmd")
  1525. }
  1526. func TestBuildExpose(t *testing.T) {
  1527. name := "testbuildexpose"
  1528. expected := "map[2375/tcp:map[]]"
  1529. defer deleteImages(name)
  1530. _, err := buildImage(name,
  1531. `FROM scratch
  1532. EXPOSE 2375`,
  1533. true)
  1534. if err != nil {
  1535. t.Fatal(err)
  1536. }
  1537. res, err := inspectField(name, "Config.ExposedPorts")
  1538. if err != nil {
  1539. t.Fatal(err)
  1540. }
  1541. if res != expected {
  1542. t.Fatalf("Exposed ports %s, expected %s", res, expected)
  1543. }
  1544. logDone("build - expose")
  1545. }
  1546. func TestBuildEmptyEntrypointInheritance(t *testing.T) {
  1547. name := "testbuildentrypointinheritance"
  1548. name2 := "testbuildentrypointinheritance2"
  1549. defer deleteImages(name, name2)
  1550. _, err := buildImage(name,
  1551. `FROM busybox
  1552. ENTRYPOINT ["/bin/echo"]`,
  1553. true)
  1554. if err != nil {
  1555. t.Fatal(err)
  1556. }
  1557. res, err := inspectField(name, "Config.Entrypoint")
  1558. if err != nil {
  1559. t.Fatal(err)
  1560. }
  1561. expected := "[/bin/echo]"
  1562. if res != expected {
  1563. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  1564. }
  1565. _, err = buildImage(name2,
  1566. fmt.Sprintf(`FROM %s
  1567. ENTRYPOINT []`, name),
  1568. true)
  1569. if err != nil {
  1570. t.Fatal(err)
  1571. }
  1572. res, err = inspectField(name2, "Config.Entrypoint")
  1573. if err != nil {
  1574. t.Fatal(err)
  1575. }
  1576. expected = "[]"
  1577. if res != expected {
  1578. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  1579. }
  1580. logDone("build - empty entrypoint inheritance")
  1581. }
  1582. func TestBuildEmptyEntrypoint(t *testing.T) {
  1583. name := "testbuildentrypoint"
  1584. defer deleteImages(name)
  1585. expected := "[]"
  1586. _, err := buildImage(name,
  1587. `FROM busybox
  1588. ENTRYPOINT []`,
  1589. true)
  1590. if err != nil {
  1591. t.Fatal(err)
  1592. }
  1593. res, err := inspectField(name, "Config.Entrypoint")
  1594. if err != nil {
  1595. t.Fatal(err)
  1596. }
  1597. if res != expected {
  1598. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  1599. }
  1600. logDone("build - empty entrypoint")
  1601. }
  1602. func TestBuildEntrypoint(t *testing.T) {
  1603. name := "testbuildentrypoint"
  1604. expected := "[/bin/echo]"
  1605. defer deleteImages(name)
  1606. _, err := buildImage(name,
  1607. `FROM scratch
  1608. ENTRYPOINT ["/bin/echo"]`,
  1609. true)
  1610. if err != nil {
  1611. t.Fatal(err)
  1612. }
  1613. res, err := inspectField(name, "Config.Entrypoint")
  1614. if err != nil {
  1615. t.Fatal(err)
  1616. }
  1617. if res != expected {
  1618. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  1619. }
  1620. logDone("build - entrypoint")
  1621. }
  1622. // #6445 ensure ONBUILD triggers aren't committed to grandchildren
  1623. func TestBuildOnBuildLimitedInheritence(t *testing.T) {
  1624. var (
  1625. out2, out3 string
  1626. )
  1627. {
  1628. name1 := "testonbuildtrigger1"
  1629. dockerfile1 := `
  1630. FROM busybox
  1631. RUN echo "GRANDPARENT"
  1632. ONBUILD RUN echo "ONBUILD PARENT"
  1633. `
  1634. ctx, err := fakeContext(dockerfile1, nil)
  1635. if err != nil {
  1636. t.Fatal(err)
  1637. }
  1638. defer ctx.Close()
  1639. out1, _, err := dockerCmdInDir(t, ctx.Dir, "build", "-t", name1, ".")
  1640. if err != nil {
  1641. t.Fatalf("build failed to complete: %s, %v", out1, err)
  1642. }
  1643. defer deleteImages(name1)
  1644. }
  1645. {
  1646. name2 := "testonbuildtrigger2"
  1647. dockerfile2 := `
  1648. FROM testonbuildtrigger1
  1649. `
  1650. ctx, err := fakeContext(dockerfile2, nil)
  1651. if err != nil {
  1652. t.Fatal(err)
  1653. }
  1654. defer ctx.Close()
  1655. out2, _, err = dockerCmdInDir(t, ctx.Dir, "build", "-t", name2, ".")
  1656. if err != nil {
  1657. t.Fatalf("build failed to complete: %s, %v", out2, err)
  1658. }
  1659. defer deleteImages(name2)
  1660. }
  1661. {
  1662. name3 := "testonbuildtrigger3"
  1663. dockerfile3 := `
  1664. FROM testonbuildtrigger2
  1665. `
  1666. ctx, err := fakeContext(dockerfile3, nil)
  1667. if err != nil {
  1668. t.Fatal(err)
  1669. }
  1670. defer ctx.Close()
  1671. out3, _, err = dockerCmdInDir(t, ctx.Dir, "build", "-t", name3, ".")
  1672. if err != nil {
  1673. t.Fatalf("build failed to complete: %s, %v", out3, err)
  1674. }
  1675. defer deleteImages(name3)
  1676. }
  1677. // ONBUILD should be run in second build.
  1678. if !strings.Contains(out2, "ONBUILD PARENT") {
  1679. t.Fatalf("ONBUILD instruction did not run in child of ONBUILD parent")
  1680. }
  1681. // ONBUILD should *not* be run in third build.
  1682. if strings.Contains(out3, "ONBUILD PARENT") {
  1683. t.Fatalf("ONBUILD instruction ran in grandchild of ONBUILD parent")
  1684. }
  1685. logDone("build - onbuild")
  1686. }
  1687. func TestBuildWithCache(t *testing.T) {
  1688. name := "testbuildwithcache"
  1689. defer deleteImages(name)
  1690. id1, err := buildImage(name,
  1691. `FROM scratch
  1692. MAINTAINER dockerio
  1693. EXPOSE 5432
  1694. ENTRYPOINT ["/bin/echo"]`,
  1695. true)
  1696. if err != nil {
  1697. t.Fatal(err)
  1698. }
  1699. id2, err := buildImage(name,
  1700. `FROM scratch
  1701. MAINTAINER dockerio
  1702. EXPOSE 5432
  1703. ENTRYPOINT ["/bin/echo"]`,
  1704. true)
  1705. if err != nil {
  1706. t.Fatal(err)
  1707. }
  1708. if id1 != id2 {
  1709. t.Fatal("The cache should have been used but hasn't.")
  1710. }
  1711. logDone("build - with cache")
  1712. }
  1713. func TestBuildWithoutCache(t *testing.T) {
  1714. name := "testbuildwithoutcache"
  1715. name2 := "testbuildwithoutcache2"
  1716. defer deleteImages(name, name2)
  1717. id1, err := buildImage(name,
  1718. `FROM scratch
  1719. MAINTAINER dockerio
  1720. EXPOSE 5432
  1721. ENTRYPOINT ["/bin/echo"]`,
  1722. true)
  1723. if err != nil {
  1724. t.Fatal(err)
  1725. }
  1726. id2, err := buildImage(name2,
  1727. `FROM scratch
  1728. MAINTAINER dockerio
  1729. EXPOSE 5432
  1730. ENTRYPOINT ["/bin/echo"]`,
  1731. false)
  1732. if err != nil {
  1733. t.Fatal(err)
  1734. }
  1735. if id1 == id2 {
  1736. t.Fatal("The cache should have been invalided but hasn't.")
  1737. }
  1738. logDone("build - without cache")
  1739. }
  1740. func TestBuildADDLocalFileWithCache(t *testing.T) {
  1741. name := "testbuildaddlocalfilewithcache"
  1742. name2 := "testbuildaddlocalfilewithcache2"
  1743. defer deleteImages(name, name2)
  1744. dockerfile := `
  1745. FROM busybox
  1746. MAINTAINER dockerio
  1747. ADD foo /usr/lib/bla/bar
  1748. RUN [ "$(cat /usr/lib/bla/bar)" = "hello" ]`
  1749. ctx, err := fakeContext(dockerfile, map[string]string{
  1750. "foo": "hello",
  1751. })
  1752. defer ctx.Close()
  1753. if err != nil {
  1754. t.Fatal(err)
  1755. }
  1756. id1, err := buildImageFromContext(name, ctx, true)
  1757. if err != nil {
  1758. t.Fatal(err)
  1759. }
  1760. id2, err := buildImageFromContext(name2, ctx, true)
  1761. if err != nil {
  1762. t.Fatal(err)
  1763. }
  1764. if id1 != id2 {
  1765. t.Fatal("The cache should have been used but hasn't.")
  1766. }
  1767. logDone("build - add local file with cache")
  1768. }
  1769. func TestBuildADDMultipleLocalFileWithCache(t *testing.T) {
  1770. name := "testbuildaddmultiplelocalfilewithcache"
  1771. name2 := "testbuildaddmultiplelocalfilewithcache2"
  1772. defer deleteImages(name, name2)
  1773. dockerfile := `
  1774. FROM busybox
  1775. MAINTAINER dockerio
  1776. ADD foo Dockerfile /usr/lib/bla/
  1777. RUN [ "$(cat /usr/lib/bla/foo)" = "hello" ]`
  1778. ctx, err := fakeContext(dockerfile, map[string]string{
  1779. "foo": "hello",
  1780. })
  1781. defer ctx.Close()
  1782. if err != nil {
  1783. t.Fatal(err)
  1784. }
  1785. id1, err := buildImageFromContext(name, ctx, true)
  1786. if err != nil {
  1787. t.Fatal(err)
  1788. }
  1789. id2, err := buildImageFromContext(name2, ctx, true)
  1790. if err != nil {
  1791. t.Fatal(err)
  1792. }
  1793. if id1 != id2 {
  1794. t.Fatal("The cache should have been used but hasn't.")
  1795. }
  1796. logDone("build - add multiple local files with cache")
  1797. }
  1798. func TestBuildADDLocalFileWithoutCache(t *testing.T) {
  1799. name := "testbuildaddlocalfilewithoutcache"
  1800. name2 := "testbuildaddlocalfilewithoutcache2"
  1801. defer deleteImages(name, name2)
  1802. dockerfile := `
  1803. FROM busybox
  1804. MAINTAINER dockerio
  1805. ADD foo /usr/lib/bla/bar
  1806. RUN [ "$(cat /usr/lib/bla/bar)" = "hello" ]`
  1807. ctx, err := fakeContext(dockerfile, map[string]string{
  1808. "foo": "hello",
  1809. })
  1810. defer ctx.Close()
  1811. if err != nil {
  1812. t.Fatal(err)
  1813. }
  1814. id1, err := buildImageFromContext(name, ctx, true)
  1815. if err != nil {
  1816. t.Fatal(err)
  1817. }
  1818. id2, err := buildImageFromContext(name2, ctx, false)
  1819. if err != nil {
  1820. t.Fatal(err)
  1821. }
  1822. if id1 == id2 {
  1823. t.Fatal("The cache should have been invalided but hasn't.")
  1824. }
  1825. logDone("build - add local file without cache")
  1826. }
  1827. func TestBuildCopyDirButNotFile(t *testing.T) {
  1828. name := "testbuildcopydirbutnotfile"
  1829. name2 := "testbuildcopydirbutnotfile2"
  1830. defer deleteImages(name, name2)
  1831. dockerfile := `
  1832. FROM scratch
  1833. COPY dir /tmp/`
  1834. ctx, err := fakeContext(dockerfile, map[string]string{
  1835. "dir/foo": "hello",
  1836. })
  1837. defer ctx.Close()
  1838. if err != nil {
  1839. t.Fatal(err)
  1840. }
  1841. id1, err := buildImageFromContext(name, ctx, true)
  1842. if err != nil {
  1843. t.Fatal(err)
  1844. }
  1845. // Check that adding file with similar name doesn't mess with cache
  1846. if err := ctx.Add("dir_file", "hello2"); err != nil {
  1847. t.Fatal(err)
  1848. }
  1849. id2, err := buildImageFromContext(name2, ctx, true)
  1850. if err != nil {
  1851. t.Fatal(err)
  1852. }
  1853. if id1 != id2 {
  1854. t.Fatal("The cache should have been used but wasn't")
  1855. }
  1856. logDone("build - add current directory but not file")
  1857. }
  1858. func TestBuildADDCurrentDirWithCache(t *testing.T) {
  1859. name := "testbuildaddcurrentdirwithcache"
  1860. name2 := name + "2"
  1861. name3 := name + "3"
  1862. name4 := name + "4"
  1863. name5 := name + "5"
  1864. defer deleteImages(name, name2, name3, name4, name5)
  1865. dockerfile := `
  1866. FROM scratch
  1867. MAINTAINER dockerio
  1868. ADD . /usr/lib/bla`
  1869. ctx, err := fakeContext(dockerfile, map[string]string{
  1870. "foo": "hello",
  1871. })
  1872. defer ctx.Close()
  1873. if err != nil {
  1874. t.Fatal(err)
  1875. }
  1876. id1, err := buildImageFromContext(name, ctx, true)
  1877. if err != nil {
  1878. t.Fatal(err)
  1879. }
  1880. // Check that adding file invalidate cache of "ADD ."
  1881. if err := ctx.Add("bar", "hello2"); err != nil {
  1882. t.Fatal(err)
  1883. }
  1884. id2, err := buildImageFromContext(name2, ctx, true)
  1885. if err != nil {
  1886. t.Fatal(err)
  1887. }
  1888. if id1 == id2 {
  1889. t.Fatal("The cache should have been invalided but hasn't.")
  1890. }
  1891. // Check that changing file invalidate cache of "ADD ."
  1892. if err := ctx.Add("foo", "hello1"); err != nil {
  1893. t.Fatal(err)
  1894. }
  1895. id3, err := buildImageFromContext(name3, ctx, true)
  1896. if err != nil {
  1897. t.Fatal(err)
  1898. }
  1899. if id2 == id3 {
  1900. t.Fatal("The cache should have been invalided but hasn't.")
  1901. }
  1902. // Check that changing file to same content invalidate cache of "ADD ."
  1903. time.Sleep(1 * time.Second) // wait second because of mtime precision
  1904. if err := ctx.Add("foo", "hello1"); err != nil {
  1905. t.Fatal(err)
  1906. }
  1907. id4, err := buildImageFromContext(name4, ctx, true)
  1908. if err != nil {
  1909. t.Fatal(err)
  1910. }
  1911. if id3 == id4 {
  1912. t.Fatal("The cache should have been invalided but hasn't.")
  1913. }
  1914. id5, err := buildImageFromContext(name5, ctx, true)
  1915. if err != nil {
  1916. t.Fatal(err)
  1917. }
  1918. if id4 != id5 {
  1919. t.Fatal("The cache should have been used but hasn't.")
  1920. }
  1921. logDone("build - add current directory with cache")
  1922. }
  1923. func TestBuildADDCurrentDirWithoutCache(t *testing.T) {
  1924. name := "testbuildaddcurrentdirwithoutcache"
  1925. name2 := "testbuildaddcurrentdirwithoutcache2"
  1926. defer deleteImages(name, name2)
  1927. dockerfile := `
  1928. FROM scratch
  1929. MAINTAINER dockerio
  1930. ADD . /usr/lib/bla`
  1931. ctx, err := fakeContext(dockerfile, map[string]string{
  1932. "foo": "hello",
  1933. })
  1934. defer ctx.Close()
  1935. if err != nil {
  1936. t.Fatal(err)
  1937. }
  1938. id1, err := buildImageFromContext(name, ctx, true)
  1939. if err != nil {
  1940. t.Fatal(err)
  1941. }
  1942. id2, err := buildImageFromContext(name2, ctx, false)
  1943. if err != nil {
  1944. t.Fatal(err)
  1945. }
  1946. if id1 == id2 {
  1947. t.Fatal("The cache should have been invalided but hasn't.")
  1948. }
  1949. logDone("build - add current directory without cache")
  1950. }
  1951. func TestBuildADDRemoteFileWithCache(t *testing.T) {
  1952. name := "testbuildaddremotefilewithcache"
  1953. defer deleteImages(name)
  1954. server, err := fakeStorage(map[string]string{
  1955. "baz": "hello",
  1956. })
  1957. if err != nil {
  1958. t.Fatal(err)
  1959. }
  1960. defer server.Close()
  1961. id1, err := buildImage(name,
  1962. fmt.Sprintf(`FROM scratch
  1963. MAINTAINER dockerio
  1964. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  1965. true)
  1966. if err != nil {
  1967. t.Fatal(err)
  1968. }
  1969. id2, err := buildImage(name,
  1970. fmt.Sprintf(`FROM scratch
  1971. MAINTAINER dockerio
  1972. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  1973. true)
  1974. if err != nil {
  1975. t.Fatal(err)
  1976. }
  1977. if id1 != id2 {
  1978. t.Fatal("The cache should have been used but hasn't.")
  1979. }
  1980. logDone("build - add remote file with cache")
  1981. }
  1982. func TestBuildADDRemoteFileWithoutCache(t *testing.T) {
  1983. name := "testbuildaddremotefilewithoutcache"
  1984. name2 := "testbuildaddremotefilewithoutcache2"
  1985. defer deleteImages(name, name2)
  1986. server, err := fakeStorage(map[string]string{
  1987. "baz": "hello",
  1988. })
  1989. if err != nil {
  1990. t.Fatal(err)
  1991. }
  1992. defer server.Close()
  1993. id1, err := buildImage(name,
  1994. fmt.Sprintf(`FROM scratch
  1995. MAINTAINER dockerio
  1996. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  1997. true)
  1998. if err != nil {
  1999. t.Fatal(err)
  2000. }
  2001. id2, err := buildImage(name2,
  2002. fmt.Sprintf(`FROM scratch
  2003. MAINTAINER dockerio
  2004. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  2005. false)
  2006. if err != nil {
  2007. t.Fatal(err)
  2008. }
  2009. if id1 == id2 {
  2010. t.Fatal("The cache should have been invalided but hasn't.")
  2011. }
  2012. logDone("build - add remote file without cache")
  2013. }
  2014. func TestBuildADDRemoteFileMTime(t *testing.T) {
  2015. name := "testbuildaddremotefilemtime"
  2016. name2 := name + "2"
  2017. name3 := name + "3"
  2018. name4 := name + "4"
  2019. defer deleteImages(name, name2, name3, name4)
  2020. server, err := fakeStorage(map[string]string{"baz": "hello"})
  2021. if err != nil {
  2022. t.Fatal(err)
  2023. }
  2024. defer server.Close()
  2025. ctx, err := fakeContext(fmt.Sprintf(`FROM scratch
  2026. MAINTAINER dockerio
  2027. ADD %s/baz /usr/lib/baz/quux`, server.URL), nil)
  2028. if err != nil {
  2029. t.Fatal(err)
  2030. }
  2031. defer ctx.Close()
  2032. id1, err := buildImageFromContext(name, ctx, true)
  2033. if err != nil {
  2034. t.Fatal(err)
  2035. }
  2036. id2, err := buildImageFromContext(name2, ctx, true)
  2037. if err != nil {
  2038. t.Fatal(err)
  2039. }
  2040. if id1 != id2 {
  2041. t.Fatal("The cache should have been used but wasn't - #1")
  2042. }
  2043. // Now set baz's times to anything else and redo the build
  2044. // This time the cache should not be used
  2045. bazPath := path.Join(server.FakeContext.Dir, "baz")
  2046. err = syscall.UtimesNano(bazPath, make([]syscall.Timespec, 2))
  2047. if err != nil {
  2048. t.Fatalf("Error setting mtime on %q: %v", bazPath, err)
  2049. }
  2050. id3, err := buildImageFromContext(name3, ctx, true)
  2051. if err != nil {
  2052. t.Fatal(err)
  2053. }
  2054. if id1 == id3 {
  2055. t.Fatal("The cache should not have been used but was")
  2056. }
  2057. // And for good measure do it again and make sure cache is used this time
  2058. id4, err := buildImageFromContext(name4, ctx, true)
  2059. if err != nil {
  2060. t.Fatal(err)
  2061. }
  2062. if id3 != id4 {
  2063. t.Fatal("The cache should have been used but wasn't - #2")
  2064. }
  2065. logDone("build - add remote file testing mtime")
  2066. }
  2067. func TestBuildADDLocalAndRemoteFilesWithCache(t *testing.T) {
  2068. name := "testbuildaddlocalandremotefilewithcache"
  2069. defer deleteImages(name)
  2070. server, err := fakeStorage(map[string]string{
  2071. "baz": "hello",
  2072. })
  2073. if err != nil {
  2074. t.Fatal(err)
  2075. }
  2076. defer server.Close()
  2077. ctx, err := fakeContext(fmt.Sprintf(`FROM scratch
  2078. MAINTAINER dockerio
  2079. ADD foo /usr/lib/bla/bar
  2080. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  2081. map[string]string{
  2082. "foo": "hello world",
  2083. })
  2084. if err != nil {
  2085. t.Fatal(err)
  2086. }
  2087. defer ctx.Close()
  2088. id1, err := buildImageFromContext(name, ctx, true)
  2089. if err != nil {
  2090. t.Fatal(err)
  2091. }
  2092. id2, err := buildImageFromContext(name, ctx, true)
  2093. if err != nil {
  2094. t.Fatal(err)
  2095. }
  2096. if id1 != id2 {
  2097. t.Fatal("The cache should have been used but hasn't.")
  2098. }
  2099. logDone("build - add local and remote file with cache")
  2100. }
  2101. func testContextTar(t *testing.T, compression archive.Compression) {
  2102. ctx, err := fakeContext(
  2103. `FROM busybox
  2104. ADD foo /foo
  2105. CMD ["cat", "/foo"]`,
  2106. map[string]string{
  2107. "foo": "bar",
  2108. },
  2109. )
  2110. defer ctx.Close()
  2111. if err != nil {
  2112. t.Fatal(err)
  2113. }
  2114. context, err := archive.Tar(ctx.Dir, compression)
  2115. if err != nil {
  2116. t.Fatalf("failed to build context tar: %v", err)
  2117. }
  2118. name := "contexttar"
  2119. buildCmd := exec.Command(dockerBinary, "build", "-t", name, "-")
  2120. defer deleteImages(name)
  2121. buildCmd.Stdin = context
  2122. if out, _, err := runCommandWithOutput(buildCmd); err != nil {
  2123. t.Fatalf("build failed to complete: %v %v", out, err)
  2124. }
  2125. logDone(fmt.Sprintf("build - build an image with a context tar, compression: %v", compression))
  2126. }
  2127. func TestBuildContextTarGzip(t *testing.T) {
  2128. testContextTar(t, archive.Gzip)
  2129. }
  2130. func TestBuildContextTarNoCompression(t *testing.T) {
  2131. testContextTar(t, archive.Uncompressed)
  2132. }
  2133. func TestBuildNoContext(t *testing.T) {
  2134. buildCmd := exec.Command(dockerBinary, "build", "-t", "nocontext", "-")
  2135. buildCmd.Stdin = strings.NewReader("FROM busybox\nCMD echo ok\n")
  2136. if out, _, err := runCommandWithOutput(buildCmd); err != nil {
  2137. t.Fatalf("build failed to complete: %v %v", out, err)
  2138. }
  2139. if out, _, err := dockerCmd(t, "run", "--rm", "nocontext"); out != "ok\n" || err != nil {
  2140. t.Fatalf("run produced invalid output: %q, expected %q", out, "ok")
  2141. }
  2142. deleteImages("nocontext")
  2143. logDone("build - build an image with no context")
  2144. }
  2145. // TODO: TestCaching
  2146. func TestBuildADDLocalAndRemoteFilesWithoutCache(t *testing.T) {
  2147. name := "testbuildaddlocalandremotefilewithoutcache"
  2148. name2 := "testbuildaddlocalandremotefilewithoutcache2"
  2149. defer deleteImages(name, name2)
  2150. server, err := fakeStorage(map[string]string{
  2151. "baz": "hello",
  2152. })
  2153. if err != nil {
  2154. t.Fatal(err)
  2155. }
  2156. defer server.Close()
  2157. ctx, err := fakeContext(fmt.Sprintf(`FROM scratch
  2158. MAINTAINER dockerio
  2159. ADD foo /usr/lib/bla/bar
  2160. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  2161. map[string]string{
  2162. "foo": "hello world",
  2163. })
  2164. if err != nil {
  2165. t.Fatal(err)
  2166. }
  2167. defer ctx.Close()
  2168. id1, err := buildImageFromContext(name, ctx, true)
  2169. if err != nil {
  2170. t.Fatal(err)
  2171. }
  2172. id2, err := buildImageFromContext(name2, ctx, false)
  2173. if err != nil {
  2174. t.Fatal(err)
  2175. }
  2176. if id1 == id2 {
  2177. t.Fatal("The cache should have been invalided but hasn't.")
  2178. }
  2179. logDone("build - add local and remote file without cache")
  2180. }
  2181. func TestBuildWithVolumeOwnership(t *testing.T) {
  2182. name := "testbuildimg"
  2183. defer deleteImages(name)
  2184. _, err := buildImage(name,
  2185. `FROM busybox:latest
  2186. RUN mkdir /test && chown daemon:daemon /test && chmod 0600 /test
  2187. VOLUME /test`,
  2188. true)
  2189. if err != nil {
  2190. t.Fatal(err)
  2191. }
  2192. cmd := exec.Command(dockerBinary, "run", "--rm", "testbuildimg", "ls", "-la", "/test")
  2193. out, _, err := runCommandWithOutput(cmd)
  2194. if err != nil {
  2195. t.Fatal(out, err)
  2196. }
  2197. if expected := "drw-------"; !strings.Contains(out, expected) {
  2198. t.Fatalf("expected %s received %s", expected, out)
  2199. }
  2200. if expected := "daemon daemon"; !strings.Contains(out, expected) {
  2201. t.Fatalf("expected %s received %s", expected, out)
  2202. }
  2203. logDone("build - volume ownership")
  2204. }
  2205. // testing #1405 - config.Cmd does not get cleaned up if
  2206. // utilizing cache
  2207. func TestBuildEntrypointRunCleanup(t *testing.T) {
  2208. name := "testbuildcmdcleanup"
  2209. defer deleteImages(name)
  2210. if _, err := buildImage(name,
  2211. `FROM busybox
  2212. RUN echo "hello"`,
  2213. true); err != nil {
  2214. t.Fatal(err)
  2215. }
  2216. ctx, err := fakeContext(`FROM busybox
  2217. RUN echo "hello"
  2218. ADD foo /foo
  2219. ENTRYPOINT ["/bin/echo"]`,
  2220. map[string]string{
  2221. "foo": "hello",
  2222. })
  2223. defer ctx.Close()
  2224. if err != nil {
  2225. t.Fatal(err)
  2226. }
  2227. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  2228. t.Fatal(err)
  2229. }
  2230. res, err := inspectField(name, "Config.Cmd")
  2231. if err != nil {
  2232. t.Fatal(err)
  2233. }
  2234. // Cmd must be cleaned up
  2235. if expected := "<no value>"; res != expected {
  2236. t.Fatalf("Cmd %s, expected %s", res, expected)
  2237. }
  2238. logDone("build - cleanup cmd after RUN")
  2239. }
  2240. func TestBuildForbiddenContextPath(t *testing.T) {
  2241. name := "testbuildforbidpath"
  2242. defer deleteImages(name)
  2243. ctx, err := fakeContext(`FROM scratch
  2244. ADD ../../ test/
  2245. `,
  2246. map[string]string{
  2247. "test.txt": "test1",
  2248. "other.txt": "other",
  2249. })
  2250. defer ctx.Close()
  2251. if err != nil {
  2252. t.Fatal(err)
  2253. }
  2254. expected := "Forbidden path outside the build context: ../../ "
  2255. if _, err := buildImageFromContext(name, ctx, true); err == nil || !strings.Contains(err.Error(), expected) {
  2256. t.Fatalf("Wrong error: (should contain \"%s\") got:\n%v", expected, err)
  2257. }
  2258. logDone("build - forbidden context path")
  2259. }
  2260. func TestBuildADDFileNotFound(t *testing.T) {
  2261. name := "testbuildaddnotfound"
  2262. defer deleteImages(name)
  2263. ctx, err := fakeContext(`FROM scratch
  2264. ADD foo /usr/local/bar`,
  2265. map[string]string{"bar": "hello"})
  2266. defer ctx.Close()
  2267. if err != nil {
  2268. t.Fatal(err)
  2269. }
  2270. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  2271. if !strings.Contains(err.Error(), "foo: no such file or directory") {
  2272. t.Fatalf("Wrong error %v, must be about missing foo file or directory", err)
  2273. }
  2274. } else {
  2275. t.Fatal("Error must not be nil")
  2276. }
  2277. logDone("build - add file not found")
  2278. }
  2279. func TestBuildInheritance(t *testing.T) {
  2280. name := "testbuildinheritance"
  2281. defer deleteImages(name)
  2282. _, err := buildImage(name,
  2283. `FROM scratch
  2284. EXPOSE 2375`,
  2285. true)
  2286. if err != nil {
  2287. t.Fatal(err)
  2288. }
  2289. ports1, err := inspectField(name, "Config.ExposedPorts")
  2290. if err != nil {
  2291. t.Fatal(err)
  2292. }
  2293. _, err = buildImage(name,
  2294. fmt.Sprintf(`FROM %s
  2295. ENTRYPOINT ["/bin/echo"]`, name),
  2296. true)
  2297. if err != nil {
  2298. t.Fatal(err)
  2299. }
  2300. res, err := inspectField(name, "Config.Entrypoint")
  2301. if err != nil {
  2302. t.Fatal(err)
  2303. }
  2304. if expected := "[/bin/echo]"; res != expected {
  2305. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  2306. }
  2307. ports2, err := inspectField(name, "Config.ExposedPorts")
  2308. if err != nil {
  2309. t.Fatal(err)
  2310. }
  2311. if ports1 != ports2 {
  2312. t.Fatalf("Ports must be same: %s != %s", ports1, ports2)
  2313. }
  2314. logDone("build - inheritance")
  2315. }
  2316. func TestBuildFails(t *testing.T) {
  2317. name := "testbuildfails"
  2318. defer deleteImages(name)
  2319. defer deleteAllContainers()
  2320. _, err := buildImage(name,
  2321. `FROM busybox
  2322. RUN sh -c "exit 23"`,
  2323. true)
  2324. if err != nil {
  2325. if !strings.Contains(err.Error(), "returned a non-zero code: 23") {
  2326. t.Fatalf("Wrong error %v, must be about non-zero code 23", err)
  2327. }
  2328. } else {
  2329. t.Fatal("Error must not be nil")
  2330. }
  2331. logDone("build - fails")
  2332. }
  2333. func TestBuildFailsDockerfileEmpty(t *testing.T) {
  2334. name := "testbuildfails"
  2335. defer deleteImages(name)
  2336. _, err := buildImage(name, ``, true)
  2337. if err != nil {
  2338. if !strings.Contains(err.Error(), "Dockerfile cannot be empty") {
  2339. t.Fatalf("Wrong error %v, must be about empty Dockerfile", err)
  2340. }
  2341. } else {
  2342. t.Fatal("Error must not be nil")
  2343. }
  2344. logDone("build - fails with empty dockerfile")
  2345. }
  2346. func TestBuildOnBuild(t *testing.T) {
  2347. name := "testbuildonbuild"
  2348. defer deleteImages(name)
  2349. _, err := buildImage(name,
  2350. `FROM busybox
  2351. ONBUILD RUN touch foobar`,
  2352. true)
  2353. if err != nil {
  2354. t.Fatal(err)
  2355. }
  2356. _, err = buildImage(name,
  2357. fmt.Sprintf(`FROM %s
  2358. RUN [ -f foobar ]`, name),
  2359. true)
  2360. if err != nil {
  2361. t.Fatal(err)
  2362. }
  2363. logDone("build - onbuild")
  2364. }
  2365. func TestBuildOnBuildForbiddenChained(t *testing.T) {
  2366. name := "testbuildonbuildforbiddenchained"
  2367. defer deleteImages(name)
  2368. _, err := buildImage(name,
  2369. `FROM busybox
  2370. ONBUILD ONBUILD RUN touch foobar`,
  2371. true)
  2372. if err != nil {
  2373. if !strings.Contains(err.Error(), "Chaining ONBUILD via `ONBUILD ONBUILD` isn't allowed") {
  2374. t.Fatalf("Wrong error %v, must be about chaining ONBUILD", err)
  2375. }
  2376. } else {
  2377. t.Fatal("Error must not be nil")
  2378. }
  2379. logDone("build - onbuild forbidden chained")
  2380. }
  2381. func TestBuildOnBuildForbiddenFrom(t *testing.T) {
  2382. name := "testbuildonbuildforbiddenfrom"
  2383. defer deleteImages(name)
  2384. _, err := buildImage(name,
  2385. `FROM busybox
  2386. ONBUILD FROM scratch`,
  2387. true)
  2388. if err != nil {
  2389. if !strings.Contains(err.Error(), "FROM isn't allowed as an ONBUILD trigger") {
  2390. t.Fatalf("Wrong error %v, must be about FROM forbidden", err)
  2391. }
  2392. } else {
  2393. t.Fatal("Error must not be nil")
  2394. }
  2395. logDone("build - onbuild forbidden from")
  2396. }
  2397. func TestBuildOnBuildForbiddenMaintainer(t *testing.T) {
  2398. name := "testbuildonbuildforbiddenmaintainer"
  2399. defer deleteImages(name)
  2400. _, err := buildImage(name,
  2401. `FROM busybox
  2402. ONBUILD MAINTAINER docker.io`,
  2403. true)
  2404. if err != nil {
  2405. if !strings.Contains(err.Error(), "MAINTAINER isn't allowed as an ONBUILD trigger") {
  2406. t.Fatalf("Wrong error %v, must be about MAINTAINER forbidden", err)
  2407. }
  2408. } else {
  2409. t.Fatal("Error must not be nil")
  2410. }
  2411. logDone("build - onbuild forbidden maintainer")
  2412. }
  2413. // gh #2446
  2414. func TestBuildAddToSymlinkDest(t *testing.T) {
  2415. name := "testbuildaddtosymlinkdest"
  2416. defer deleteImages(name)
  2417. ctx, err := fakeContext(`FROM busybox
  2418. RUN mkdir /foo
  2419. RUN ln -s /foo /bar
  2420. ADD foo /bar/
  2421. RUN [ -f /bar/foo ]
  2422. RUN [ -f /foo/foo ]`,
  2423. map[string]string{
  2424. "foo": "hello",
  2425. })
  2426. if err != nil {
  2427. t.Fatal(err)
  2428. }
  2429. defer ctx.Close()
  2430. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  2431. t.Fatal(err)
  2432. }
  2433. logDone("build - add to symlink destination")
  2434. }
  2435. func TestBuildEscapeWhitespace(t *testing.T) {
  2436. name := "testbuildescaping"
  2437. defer deleteImages(name)
  2438. _, err := buildImage(name, `
  2439. FROM busybox
  2440. MAINTAINER "Docker \
  2441. IO <io@\
  2442. docker.com>"
  2443. `, true)
  2444. res, err := inspectField(name, "Author")
  2445. if err != nil {
  2446. t.Fatal(err)
  2447. }
  2448. if res != "Docker IO <io@docker.com>" {
  2449. t.Fatal("Parsed string did not match the escaped string")
  2450. }
  2451. logDone("build - validate escaping whitespace")
  2452. }
  2453. func TestBuildDockerignore(t *testing.T) {
  2454. name := "testbuilddockerignore"
  2455. defer deleteImages(name)
  2456. dockerfile := `
  2457. FROM busybox
  2458. ADD . /bla
  2459. RUN [[ -f /bla/src/x.go ]]
  2460. RUN [[ -f /bla/Makefile ]]
  2461. RUN [[ ! -e /bla/src/_vendor ]]
  2462. RUN [[ ! -e /bla/.gitignore ]]
  2463. RUN [[ ! -e /bla/README.md ]]
  2464. RUN [[ ! -e /bla/.git ]]`
  2465. ctx, err := fakeContext(dockerfile, map[string]string{
  2466. "Makefile": "all:",
  2467. ".git/HEAD": "ref: foo",
  2468. "src/x.go": "package main",
  2469. "src/_vendor/v.go": "package main",
  2470. ".gitignore": "",
  2471. "README.md": "readme",
  2472. ".dockerignore": ".git\npkg\n.gitignore\nsrc/_vendor\n*.md",
  2473. })
  2474. defer ctx.Close()
  2475. if err != nil {
  2476. t.Fatal(err)
  2477. }
  2478. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  2479. t.Fatal(err)
  2480. }
  2481. logDone("build - test .dockerignore")
  2482. }
  2483. func TestBuildDockerignoreCleanPaths(t *testing.T) {
  2484. name := "testbuilddockerignorecleanpaths"
  2485. defer deleteImages(name)
  2486. dockerfile := `
  2487. FROM busybox
  2488. ADD . /tmp/
  2489. RUN (! ls /tmp/foo) && (! ls /tmp/foo2) && (! ls /tmp/dir1/foo)`
  2490. ctx, err := fakeContext(dockerfile, map[string]string{
  2491. "foo": "foo",
  2492. "foo2": "foo2",
  2493. "dir1/foo": "foo in dir1",
  2494. ".dockerignore": "./foo\ndir1//foo\n./dir1/../foo2",
  2495. })
  2496. if err != nil {
  2497. t.Fatal(err)
  2498. }
  2499. defer ctx.Close()
  2500. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  2501. t.Fatal(err)
  2502. }
  2503. logDone("build - test .dockerignore with clean paths")
  2504. }
  2505. func TestBuildDockerignoringDockerfile(t *testing.T) {
  2506. name := "testbuilddockerignoredockerfile"
  2507. defer deleteImages(name)
  2508. dockerfile := `
  2509. FROM scratch`
  2510. ctx, err := fakeContext(dockerfile, map[string]string{
  2511. "Dockerfile": "FROM scratch",
  2512. ".dockerignore": "Dockerfile\n",
  2513. })
  2514. if err != nil {
  2515. t.Fatal(err)
  2516. }
  2517. defer ctx.Close()
  2518. if _, err = buildImageFromContext(name, ctx, true); err == nil {
  2519. t.Fatalf("Didn't get expected error from ignoring Dockerfile")
  2520. }
  2521. // now try it with ./Dockerfile
  2522. ctx.Add(".dockerignore", "./Dockerfile\n")
  2523. if _, err = buildImageFromContext(name, ctx, true); err == nil {
  2524. t.Fatalf("Didn't get expected error from ignoring ./Dockerfile")
  2525. }
  2526. logDone("build - test .dockerignore of Dockerfile")
  2527. }
  2528. func TestBuildDockerignoringWholeDir(t *testing.T) {
  2529. name := "testbuilddockerignorewholedir"
  2530. defer deleteImages(name)
  2531. dockerfile := `
  2532. FROM busybox
  2533. COPY . /
  2534. RUN [[ ! -e /.gitignore ]]
  2535. RUN [[ -f /Makefile ]]`
  2536. ctx, err := fakeContext(dockerfile, map[string]string{
  2537. "Dockerfile": "FROM scratch",
  2538. "Makefile": "all:",
  2539. ".dockerignore": ".*\n",
  2540. })
  2541. defer ctx.Close()
  2542. if err != nil {
  2543. t.Fatal(err)
  2544. }
  2545. if _, err = buildImageFromContext(name, ctx, true); err != nil {
  2546. t.Fatal(err)
  2547. }
  2548. logDone("build - test .dockerignore whole dir with .*")
  2549. }
  2550. func TestBuildLineBreak(t *testing.T) {
  2551. name := "testbuildlinebreak"
  2552. defer deleteImages(name)
  2553. _, err := buildImage(name,
  2554. `FROM busybox
  2555. RUN sh -c 'echo root:testpass \
  2556. > /tmp/passwd'
  2557. RUN mkdir -p /var/run/sshd
  2558. RUN [ "$(cat /tmp/passwd)" = "root:testpass" ]
  2559. RUN [ "$(ls -d /var/run/sshd)" = "/var/run/sshd" ]`,
  2560. true)
  2561. if err != nil {
  2562. t.Fatal(err)
  2563. }
  2564. logDone("build - line break with \\")
  2565. }
  2566. func TestBuildEOLInLine(t *testing.T) {
  2567. name := "testbuildeolinline"
  2568. defer deleteImages(name)
  2569. _, err := buildImage(name,
  2570. `FROM busybox
  2571. RUN sh -c 'echo root:testpass > /tmp/passwd'
  2572. RUN echo "foo \n bar"; echo "baz"
  2573. RUN mkdir -p /var/run/sshd
  2574. RUN [ "$(cat /tmp/passwd)" = "root:testpass" ]
  2575. RUN [ "$(ls -d /var/run/sshd)" = "/var/run/sshd" ]`,
  2576. true)
  2577. if err != nil {
  2578. t.Fatal(err)
  2579. }
  2580. logDone("build - end of line in dockerfile instruction")
  2581. }
  2582. func TestBuildCommentsShebangs(t *testing.T) {
  2583. name := "testbuildcomments"
  2584. defer deleteImages(name)
  2585. _, err := buildImage(name,
  2586. `FROM busybox
  2587. # This is an ordinary comment.
  2588. RUN { echo '#!/bin/sh'; echo 'echo hello world'; } > /hello.sh
  2589. RUN [ ! -x /hello.sh ]
  2590. # comment with line break \
  2591. RUN chmod +x /hello.sh
  2592. RUN [ -x /hello.sh ]
  2593. RUN [ "$(cat /hello.sh)" = $'#!/bin/sh\necho hello world' ]
  2594. RUN [ "$(/hello.sh)" = "hello world" ]`,
  2595. true)
  2596. if err != nil {
  2597. t.Fatal(err)
  2598. }
  2599. logDone("build - comments and shebangs")
  2600. }
  2601. func TestBuildUsersAndGroups(t *testing.T) {
  2602. name := "testbuildusers"
  2603. defer deleteImages(name)
  2604. _, err := buildImage(name,
  2605. `FROM busybox
  2606. # Make sure our defaults work
  2607. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)" = '0:0/root:root' ]
  2608. # TODO decide if "args.user = strconv.Itoa(syscall.Getuid())" is acceptable behavior for changeUser in sysvinit instead of "return nil" when "USER" isn't specified (so that we get the proper group list even if that is the empty list, even in the default case of not supplying an explicit USER to run as, which implies USER 0)
  2609. USER root
  2610. RUN [ "$(id -G):$(id -Gn)" = '0 10:root wheel' ]
  2611. # Setup dockerio user and group
  2612. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  2613. RUN echo 'dockerio:x:1001:' >> /etc/group
  2614. # Make sure we can switch to our user and all the information is exactly as we expect it to be
  2615. USER dockerio
  2616. RUN id -G
  2617. RUN id -Gn
  2618. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  2619. # Switch back to root and double check that worked exactly as we might expect it to
  2620. USER root
  2621. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '0:0/root:root/0 10:root wheel' ]
  2622. # Add a "supplementary" group for our dockerio user
  2623. RUN echo 'supplementary:x:1002:dockerio' >> /etc/group
  2624. # ... and then go verify that we get it like we expect
  2625. USER dockerio
  2626. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001 1002:dockerio supplementary' ]
  2627. USER 1001
  2628. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001 1002:dockerio supplementary' ]
  2629. # super test the new "user:group" syntax
  2630. USER dockerio:dockerio
  2631. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  2632. USER 1001:dockerio
  2633. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  2634. USER dockerio:1001
  2635. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  2636. USER 1001:1001
  2637. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  2638. USER dockerio:supplementary
  2639. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1002/dockerio:supplementary/1002:supplementary' ]
  2640. USER dockerio:1002
  2641. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1002/dockerio:supplementary/1002:supplementary' ]
  2642. USER 1001:supplementary
  2643. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1002/dockerio:supplementary/1002:supplementary' ]
  2644. USER 1001:1002
  2645. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1002/dockerio:supplementary/1002:supplementary' ]
  2646. # make sure unknown uid/gid still works properly
  2647. USER 1042:1043
  2648. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1042:1043/1042:1043/1043:1043' ]`,
  2649. true)
  2650. if err != nil {
  2651. t.Fatal(err)
  2652. }
  2653. logDone("build - users and groups")
  2654. }
  2655. func TestBuildEnvUsage(t *testing.T) {
  2656. name := "testbuildenvusage"
  2657. defer deleteImages(name)
  2658. dockerfile := `FROM busybox
  2659. ENV HOME /root
  2660. ENV PATH $HOME/bin:$PATH
  2661. ENV PATH /tmp:$PATH
  2662. RUN [ "$PATH" = "/tmp:$HOME/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" ]
  2663. ENV FOO /foo/baz
  2664. ENV BAR /bar
  2665. ENV BAZ $BAR
  2666. ENV FOOPATH $PATH:$FOO
  2667. RUN [ "$BAR" = "$BAZ" ]
  2668. RUN [ "$FOOPATH" = "$PATH:/foo/baz" ]
  2669. ENV FROM hello/docker/world
  2670. ENV TO /docker/world/hello
  2671. ADD $FROM $TO
  2672. RUN [ "$(cat $TO)" = "hello" ]
  2673. `
  2674. ctx, err := fakeContext(dockerfile, map[string]string{
  2675. "hello/docker/world": "hello",
  2676. })
  2677. if err != nil {
  2678. t.Fatal(err)
  2679. }
  2680. defer ctx.Close()
  2681. _, err = buildImageFromContext(name, ctx, true)
  2682. if err != nil {
  2683. t.Fatal(err)
  2684. }
  2685. logDone("build - environment variables usage")
  2686. }
  2687. func TestBuildEnvUsage2(t *testing.T) {
  2688. name := "testbuildenvusage2"
  2689. defer deleteImages(name)
  2690. dockerfile := `FROM busybox
  2691. ENV abc=def
  2692. RUN [ "$abc" = "def" ]
  2693. ENV def="hello world"
  2694. RUN [ "$def" = "hello world" ]
  2695. ENV def=hello\ world
  2696. RUN [ "$def" = "hello world" ]
  2697. ENV v1=abc v2="hi there"
  2698. RUN [ "$v1" = "abc" ]
  2699. RUN [ "$v2" = "hi there" ]
  2700. ENV v3='boogie nights' v4="with'quotes too"
  2701. RUN [ "$v3" = "boogie nights" ]
  2702. RUN [ "$v4" = "with'quotes too" ]
  2703. ENV abc=zzz FROM=hello/docker/world
  2704. ENV abc=zzz TO=/docker/world/hello
  2705. ADD $FROM $TO
  2706. RUN [ "$(cat $TO)" = "hello" ]
  2707. ENV abc "zzz"
  2708. RUN [ $abc = \"zzz\" ]
  2709. ENV abc 'yyy'
  2710. RUN [ $abc = \'yyy\' ]
  2711. ENV abc=
  2712. RUN [ "$abc" = "" ]
  2713. `
  2714. ctx, err := fakeContext(dockerfile, map[string]string{
  2715. "hello/docker/world": "hello",
  2716. })
  2717. if err != nil {
  2718. t.Fatal(err)
  2719. }
  2720. _, err = buildImageFromContext(name, ctx, true)
  2721. if err != nil {
  2722. t.Fatal(err)
  2723. }
  2724. logDone("build - environment variables usage2")
  2725. }
  2726. func TestBuildAddScript(t *testing.T) {
  2727. name := "testbuildaddscript"
  2728. defer deleteImages(name)
  2729. dockerfile := `
  2730. FROM busybox
  2731. ADD test /test
  2732. RUN ["chmod","+x","/test"]
  2733. RUN ["/test"]
  2734. RUN [ "$(cat /testfile)" = 'test!' ]`
  2735. ctx, err := fakeContext(dockerfile, map[string]string{
  2736. "test": "#!/bin/sh\necho 'test!' > /testfile",
  2737. })
  2738. if err != nil {
  2739. t.Fatal(err)
  2740. }
  2741. defer ctx.Close()
  2742. _, err = buildImageFromContext(name, ctx, true)
  2743. if err != nil {
  2744. t.Fatal(err)
  2745. }
  2746. logDone("build - add and run script")
  2747. }
  2748. func TestBuildAddTar(t *testing.T) {
  2749. name := "testbuildaddtar"
  2750. defer deleteImages(name)
  2751. ctx := func() *FakeContext {
  2752. dockerfile := `
  2753. FROM busybox
  2754. ADD test.tar /
  2755. RUN cat /test/foo | grep Hi
  2756. ADD test.tar /test.tar
  2757. RUN cat /test.tar/test/foo | grep Hi
  2758. ADD test.tar /unlikely-to-exist
  2759. RUN cat /unlikely-to-exist/test/foo | grep Hi
  2760. ADD test.tar /unlikely-to-exist-trailing-slash/
  2761. RUN cat /unlikely-to-exist-trailing-slash/test/foo | grep Hi
  2762. RUN mkdir /existing-directory
  2763. ADD test.tar /existing-directory
  2764. RUN cat /existing-directory/test/foo | grep Hi
  2765. ADD test.tar /existing-directory-trailing-slash/
  2766. RUN cat /existing-directory-trailing-slash/test/foo | grep Hi`
  2767. tmpDir, err := ioutil.TempDir("", "fake-context")
  2768. testTar, err := os.Create(filepath.Join(tmpDir, "test.tar"))
  2769. if err != nil {
  2770. t.Fatalf("failed to create test.tar archive: %v", err)
  2771. }
  2772. defer testTar.Close()
  2773. tw := tar.NewWriter(testTar)
  2774. if err := tw.WriteHeader(&tar.Header{
  2775. Name: "test/foo",
  2776. Size: 2,
  2777. }); err != nil {
  2778. t.Fatalf("failed to write tar file header: %v", err)
  2779. }
  2780. if _, err := tw.Write([]byte("Hi")); err != nil {
  2781. t.Fatalf("failed to write tar file content: %v", err)
  2782. }
  2783. if err := tw.Close(); err != nil {
  2784. t.Fatalf("failed to close tar archive: %v", err)
  2785. }
  2786. if err := ioutil.WriteFile(filepath.Join(tmpDir, "Dockerfile"), []byte(dockerfile), 0644); err != nil {
  2787. t.Fatalf("failed to open destination dockerfile: %v", err)
  2788. }
  2789. return &FakeContext{Dir: tmpDir}
  2790. }()
  2791. defer ctx.Close()
  2792. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  2793. t.Fatalf("build failed to complete for TestBuildAddTar: %v", err)
  2794. }
  2795. logDone("build - ADD tar")
  2796. }
  2797. func TestBuildFromGIT(t *testing.T) {
  2798. name := "testbuildfromgit"
  2799. defer deleteImages(name)
  2800. git, err := fakeGIT("repo", map[string]string{
  2801. "Dockerfile": `FROM busybox
  2802. ADD first /first
  2803. RUN [ -f /first ]
  2804. MAINTAINER docker`,
  2805. "first": "test git data",
  2806. })
  2807. if err != nil {
  2808. t.Fatal(err)
  2809. }
  2810. defer git.Close()
  2811. _, err = buildImageFromPath(name, git.RepoURL, true)
  2812. if err != nil {
  2813. t.Fatal(err)
  2814. }
  2815. res, err := inspectField(name, "Author")
  2816. if err != nil {
  2817. t.Fatal(err)
  2818. }
  2819. if res != "docker" {
  2820. t.Fatalf("Maintainer should be docker, got %s", res)
  2821. }
  2822. logDone("build - build from GIT")
  2823. }
  2824. func TestBuildCleanupCmdOnEntrypoint(t *testing.T) {
  2825. name := "testbuildcmdcleanuponentrypoint"
  2826. defer deleteImages(name)
  2827. if _, err := buildImage(name,
  2828. `FROM scratch
  2829. CMD ["test"]
  2830. ENTRYPOINT ["echo"]`,
  2831. true); err != nil {
  2832. t.Fatal(err)
  2833. }
  2834. if _, err := buildImage(name,
  2835. fmt.Sprintf(`FROM %s
  2836. ENTRYPOINT ["cat"]`, name),
  2837. true); err != nil {
  2838. t.Fatal(err)
  2839. }
  2840. res, err := inspectField(name, "Config.Cmd")
  2841. if err != nil {
  2842. t.Fatal(err)
  2843. }
  2844. if expected := "<no value>"; res != expected {
  2845. t.Fatalf("Cmd %s, expected %s", res, expected)
  2846. }
  2847. res, err = inspectField(name, "Config.Entrypoint")
  2848. if err != nil {
  2849. t.Fatal(err)
  2850. }
  2851. if expected := "[cat]"; res != expected {
  2852. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  2853. }
  2854. logDone("build - cleanup cmd on ENTRYPOINT")
  2855. }
  2856. func TestBuildClearCmd(t *testing.T) {
  2857. name := "testbuildclearcmd"
  2858. defer deleteImages(name)
  2859. _, err := buildImage(name,
  2860. `From scratch
  2861. ENTRYPOINT ["/bin/bash"]
  2862. CMD []`,
  2863. true)
  2864. if err != nil {
  2865. t.Fatal(err)
  2866. }
  2867. res, err := inspectFieldJSON(name, "Config.Cmd")
  2868. if err != nil {
  2869. t.Fatal(err)
  2870. }
  2871. if res != "[]" {
  2872. t.Fatalf("Cmd %s, expected %s", res, "[]")
  2873. }
  2874. logDone("build - clearcmd")
  2875. }
  2876. func TestBuildEmptyCmd(t *testing.T) {
  2877. name := "testbuildemptycmd"
  2878. defer deleteImages(name)
  2879. if _, err := buildImage(name, "FROM scratch\nMAINTAINER quux\n", true); err != nil {
  2880. t.Fatal(err)
  2881. }
  2882. res, err := inspectFieldJSON(name, "Config.Cmd")
  2883. if err != nil {
  2884. t.Fatal(err)
  2885. }
  2886. if res != "null" {
  2887. t.Fatalf("Cmd %s, expected %s", res, "null")
  2888. }
  2889. logDone("build - empty cmd")
  2890. }
  2891. func TestBuildOnBuildOutput(t *testing.T) {
  2892. name := "testbuildonbuildparent"
  2893. defer deleteImages(name)
  2894. if _, err := buildImage(name, "FROM busybox\nONBUILD RUN echo foo\n", true); err != nil {
  2895. t.Fatal(err)
  2896. }
  2897. childname := "testbuildonbuildchild"
  2898. defer deleteImages(childname)
  2899. _, out, err := buildImageWithOut(name, "FROM "+name+"\nMAINTAINER quux\n", true)
  2900. if err != nil {
  2901. t.Fatal(err)
  2902. }
  2903. if !strings.Contains(out, "Trigger 0, RUN echo foo") {
  2904. t.Fatal("failed to find the ONBUILD output", out)
  2905. }
  2906. logDone("build - onbuild output")
  2907. }
  2908. func TestBuildInvalidTag(t *testing.T) {
  2909. name := "abcd:" + makeRandomString(200)
  2910. defer deleteImages(name)
  2911. _, out, err := buildImageWithOut(name, "FROM scratch\nMAINTAINER quux\n", true)
  2912. // if the error doesnt check for illegal tag name, or the image is built
  2913. // then this should fail
  2914. if !strings.Contains(out, "Illegal tag name") || strings.Contains(out, "Sending build context to Docker daemon") {
  2915. t.Fatalf("failed to stop before building. Error: %s, Output: %s", err, out)
  2916. }
  2917. logDone("build - invalid tag")
  2918. }
  2919. func TestBuildCmdShDashC(t *testing.T) {
  2920. name := "testbuildcmdshc"
  2921. defer deleteImages(name)
  2922. if _, err := buildImage(name, "FROM busybox\nCMD echo cmd\n", true); err != nil {
  2923. t.Fatal(err)
  2924. }
  2925. res, err := inspectFieldJSON(name, "Config.Cmd")
  2926. if err != nil {
  2927. t.Fatal(err, res)
  2928. }
  2929. expected := `["/bin/sh","-c","echo cmd"]`
  2930. if res != expected {
  2931. t.Fatalf("Expected value %s not in Config.Cmd: %s", expected, res)
  2932. }
  2933. logDone("build - cmd should have sh -c for non-json")
  2934. }
  2935. func TestBuildCmdJSONNoShDashC(t *testing.T) {
  2936. name := "testbuildcmdjson"
  2937. defer deleteImages(name)
  2938. if _, err := buildImage(name, "FROM busybox\nCMD [\"echo\", \"cmd\"]", true); err != nil {
  2939. t.Fatal(err)
  2940. }
  2941. res, err := inspectFieldJSON(name, "Config.Cmd")
  2942. if err != nil {
  2943. t.Fatal(err, res)
  2944. }
  2945. expected := `["echo","cmd"]`
  2946. if res != expected {
  2947. t.Fatalf("Expected value %s not in Config.Cmd: %s", expected, res)
  2948. }
  2949. logDone("build - cmd should not have /bin/sh -c for json")
  2950. }
  2951. func TestBuildIgnoreInvalidInstruction(t *testing.T) {
  2952. name := "testbuildignoreinvalidinstruction"
  2953. defer deleteImages(name)
  2954. out, _, err := buildImageWithOut(name, "FROM busybox\nfoo bar", true)
  2955. if err != nil {
  2956. t.Fatal(err, out)
  2957. }
  2958. logDone("build - ignore invalid Dockerfile instruction")
  2959. }
  2960. func TestBuildEntrypointInheritance(t *testing.T) {
  2961. defer deleteImages("parent", "child")
  2962. defer deleteAllContainers()
  2963. if _, err := buildImage("parent", `
  2964. FROM busybox
  2965. ENTRYPOINT exit 130
  2966. `, true); err != nil {
  2967. t.Fatal(err)
  2968. }
  2969. status, _ := runCommand(exec.Command(dockerBinary, "run", "parent"))
  2970. if status != 130 {
  2971. t.Fatalf("expected exit code 130 but received %d", status)
  2972. }
  2973. if _, err := buildImage("child", `
  2974. FROM parent
  2975. ENTRYPOINT exit 5
  2976. `, true); err != nil {
  2977. t.Fatal(err)
  2978. }
  2979. status, _ = runCommand(exec.Command(dockerBinary, "run", "child"))
  2980. if status != 5 {
  2981. t.Fatalf("expected exit code 5 but received %d", status)
  2982. }
  2983. logDone("build - clear entrypoint")
  2984. }
  2985. func TestBuildEntrypointInheritanceInspect(t *testing.T) {
  2986. var (
  2987. name = "testbuildepinherit"
  2988. name2 = "testbuildepinherit2"
  2989. expected = `["/bin/sh","-c","echo quux"]`
  2990. )
  2991. defer deleteImages(name, name2)
  2992. defer deleteAllContainers()
  2993. if _, err := buildImage(name, "FROM busybox\nENTRYPOINT /foo/bar", true); err != nil {
  2994. t.Fatal(err)
  2995. }
  2996. if _, err := buildImage(name2, fmt.Sprintf("FROM %s\nENTRYPOINT echo quux", name), true); err != nil {
  2997. t.Fatal(err)
  2998. }
  2999. res, err := inspectFieldJSON(name2, "Config.Entrypoint")
  3000. if err != nil {
  3001. t.Fatal(err, res)
  3002. }
  3003. if res != expected {
  3004. t.Fatalf("Expected value %s not in Config.Entrypoint: %s", expected, res)
  3005. }
  3006. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "-t", name2))
  3007. if err != nil {
  3008. t.Fatal(err, out)
  3009. }
  3010. expected = "quux"
  3011. if strings.TrimSpace(out) != expected {
  3012. t.Fatalf("Expected output is %s, got %s", expected, out)
  3013. }
  3014. logDone("build - entrypoint override inheritance properly")
  3015. }
  3016. func TestBuildRunShEntrypoint(t *testing.T) {
  3017. name := "testbuildentrypoint"
  3018. defer deleteImages(name)
  3019. _, err := buildImage(name,
  3020. `FROM busybox
  3021. ENTRYPOINT /bin/echo`,
  3022. true)
  3023. if err != nil {
  3024. t.Fatal(err)
  3025. }
  3026. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "--rm", name))
  3027. if err != nil {
  3028. t.Fatal(err, out)
  3029. }
  3030. logDone("build - entrypoint with /bin/echo running successfully")
  3031. }
  3032. func TestBuildExoticShellInterpolation(t *testing.T) {
  3033. name := "testbuildexoticshellinterpolation"
  3034. defer deleteImages(name)
  3035. _, err := buildImage(name, `
  3036. FROM busybox
  3037. ENV SOME_VAR a.b.c
  3038. RUN [ "$SOME_VAR" = 'a.b.c' ]
  3039. RUN [ "${SOME_VAR}" = 'a.b.c' ]
  3040. RUN [ "${SOME_VAR%.*}" = 'a.b' ]
  3041. RUN [ "${SOME_VAR%%.*}" = 'a' ]
  3042. RUN [ "${SOME_VAR#*.}" = 'b.c' ]
  3043. RUN [ "${SOME_VAR##*.}" = 'c' ]
  3044. RUN [ "${SOME_VAR/c/d}" = 'a.b.d' ]
  3045. RUN [ "${#SOME_VAR}" = '5' ]
  3046. RUN [ "${SOME_UNSET_VAR:-$SOME_VAR}" = 'a.b.c' ]
  3047. RUN [ "${SOME_VAR:+Version: ${SOME_VAR}}" = 'Version: a.b.c' ]
  3048. RUN [ "${SOME_UNSET_VAR:+${SOME_VAR}}" = '' ]
  3049. RUN [ "${SOME_UNSET_VAR:-${SOME_VAR:-d.e.f}}" = 'a.b.c' ]
  3050. `, false)
  3051. if err != nil {
  3052. t.Fatal(err)
  3053. }
  3054. logDone("build - exotic shell interpolation")
  3055. }
  3056. func TestBuildVerifySingleQuoteFails(t *testing.T) {
  3057. // This testcase is supposed to generate an error because the
  3058. // JSON array we're passing in on the CMD uses single quotes instead
  3059. // of double quotes (per the JSON spec). This means we interpret it
  3060. // as a "string" insead of "JSON array" and pass it on to "sh -c" and
  3061. // it should barf on it.
  3062. name := "testbuildsinglequotefails"
  3063. defer deleteImages(name)
  3064. defer deleteAllContainers()
  3065. _, err := buildImage(name,
  3066. `FROM busybox
  3067. CMD [ '/bin/sh', '-c', 'echo hi' ]`,
  3068. true)
  3069. _, _, err = runCommandWithOutput(exec.Command(dockerBinary, "run", "--rm", name))
  3070. if err == nil {
  3071. t.Fatal("The image was not supposed to be able to run")
  3072. }
  3073. logDone("build - verify single quotes fail")
  3074. }
  3075. func TestBuildVerboseOut(t *testing.T) {
  3076. name := "testbuildverboseout"
  3077. defer deleteImages(name)
  3078. _, out, err := buildImageWithOut(name,
  3079. `FROM busybox
  3080. RUN echo 123`,
  3081. false)
  3082. if err != nil {
  3083. t.Fatal(err)
  3084. }
  3085. if !strings.Contains(out, "\n123\n") {
  3086. t.Fatalf("Output should contain %q: %q", "123", out)
  3087. }
  3088. logDone("build - verbose output from commands")
  3089. }
  3090. func TestBuildWithTabs(t *testing.T) {
  3091. name := "testbuildwithtabs"
  3092. defer deleteImages(name)
  3093. _, err := buildImage(name,
  3094. "FROM busybox\nRUN echo\tone\t\ttwo", true)
  3095. if err != nil {
  3096. t.Fatal(err)
  3097. }
  3098. res, err := inspectFieldJSON(name, "ContainerConfig.Cmd")
  3099. if err != nil {
  3100. t.Fatal(err)
  3101. }
  3102. expected := "[\"/bin/sh\",\"-c\",\"echo\\u0009one\\u0009\\u0009two\"]"
  3103. if res != expected {
  3104. t.Fatalf("Missing tabs.\nGot:%s\nExp:%s", res, expected)
  3105. }
  3106. logDone("build - with tabs")
  3107. }
  3108. func TestBuildStderr(t *testing.T) {
  3109. // This test just makes sure that no non-error output goes
  3110. // to stderr
  3111. name := "testbuildstderr"
  3112. defer deleteImages(name)
  3113. _, _, stderr, err := buildImageWithStdoutStderr(name,
  3114. "FROM busybox\nRUN echo one", true)
  3115. if err != nil {
  3116. t.Fatal(err)
  3117. }
  3118. if stderr != "" {
  3119. t.Fatal("Stderr should have been empty, instead its: %q", stderr)
  3120. }
  3121. logDone("build - testing stderr")
  3122. }