123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391 |
- package config
- import (
- "io/ioutil"
- "os"
- "runtime"
- "strings"
- "testing"
- "github.com/docker/docker/daemon/discovery"
- "github.com/docker/docker/opts"
- "github.com/docker/docker/pkg/testutil"
- "github.com/spf13/pflag"
- "github.com/stretchr/testify/assert"
- )
- func TestDaemonConfigurationNotFound(t *testing.T) {
- _, err := MergeDaemonConfigurations(&Config{}, nil, "/tmp/foo-bar-baz-docker")
- if err == nil || !os.IsNotExist(err) {
- t.Fatalf("expected does not exist error, got %v", err)
- }
- }
- func TestDaemonBrokenConfiguration(t *testing.T) {
- f, err := ioutil.TempFile("", "docker-config-")
- if err != nil {
- t.Fatal(err)
- }
- configFile := f.Name()
- f.Write([]byte(`{"Debug": tru`))
- f.Close()
- _, err = MergeDaemonConfigurations(&Config{}, nil, configFile)
- if err == nil {
- t.Fatalf("expected error, got %v", err)
- }
- }
- func TestParseClusterAdvertiseSettings(t *testing.T) {
- if runtime.GOOS == "solaris" {
- t.Skip("ClusterSettings not supported on Solaris\n")
- }
- _, err := ParseClusterAdvertiseSettings("something", "")
- if err != discovery.ErrDiscoveryDisabled {
- t.Fatalf("expected discovery disabled error, got %v\n", err)
- }
- _, err = ParseClusterAdvertiseSettings("", "something")
- if err == nil {
- t.Fatalf("expected discovery store error, got %v\n", err)
- }
- _, err = ParseClusterAdvertiseSettings("etcd", "127.0.0.1:8080")
- if err != nil {
- t.Fatal(err)
- }
- }
- func TestFindConfigurationConflicts(t *testing.T) {
- config := map[string]interface{}{"authorization-plugins": "foobar"}
- flags := pflag.NewFlagSet("test", pflag.ContinueOnError)
- flags.String("authorization-plugins", "", "")
- assert.NoError(t, flags.Set("authorization-plugins", "asdf"))
- testutil.ErrorContains(t,
- findConfigurationConflicts(config, flags),
- "authorization-plugins: (from flag: asdf, from file: foobar)")
- }
- func TestFindConfigurationConflictsWithNamedOptions(t *testing.T) {
- config := map[string]interface{}{"hosts": []string{"qwer"}}
- flags := pflag.NewFlagSet("test", pflag.ContinueOnError)
- var hosts []string
- flags.VarP(opts.NewNamedListOptsRef("hosts", &hosts, opts.ValidateHost), "host", "H", "Daemon socket(s) to connect to")
- assert.NoError(t, flags.Set("host", "tcp://127.0.0.1:4444"))
- assert.NoError(t, flags.Set("host", "unix:///var/run/docker.sock"))
- testutil.ErrorContains(t, findConfigurationConflicts(config, flags), "hosts")
- }
- func TestDaemonConfigurationMergeConflicts(t *testing.T) {
- f, err := ioutil.TempFile("", "docker-config-")
- if err != nil {
- t.Fatal(err)
- }
- configFile := f.Name()
- f.Write([]byte(`{"debug": true}`))
- f.Close()
- flags := pflag.NewFlagSet("test", pflag.ContinueOnError)
- flags.Bool("debug", false, "")
- flags.Set("debug", "false")
- _, err = MergeDaemonConfigurations(&Config{}, flags, configFile)
- if err == nil {
- t.Fatal("expected error, got nil")
- }
- if !strings.Contains(err.Error(), "debug") {
- t.Fatalf("expected debug conflict, got %v", err)
- }
- }
- func TestDaemonConfigurationMergeConcurrent(t *testing.T) {
- f, err := ioutil.TempFile("", "docker-config-")
- if err != nil {
- t.Fatal(err)
- }
- configFile := f.Name()
- f.Write([]byte(`{"max-concurrent-downloads": 1}`))
- f.Close()
- _, err = MergeDaemonConfigurations(&Config{}, nil, configFile)
- if err != nil {
- t.Fatal("expected error, got nil")
- }
- }
- func TestDaemonConfigurationMergeConcurrentError(t *testing.T) {
- f, err := ioutil.TempFile("", "docker-config-")
- if err != nil {
- t.Fatal(err)
- }
- configFile := f.Name()
- f.Write([]byte(`{"max-concurrent-downloads": -1}`))
- f.Close()
- _, err = MergeDaemonConfigurations(&Config{}, nil, configFile)
- if err == nil {
- t.Fatalf("expected no error, got error %v", err)
- }
- }
- func TestDaemonConfigurationMergeConflictsWithInnerStructs(t *testing.T) {
- f, err := ioutil.TempFile("", "docker-config-")
- if err != nil {
- t.Fatal(err)
- }
- configFile := f.Name()
- f.Write([]byte(`{"tlscacert": "/etc/certificates/ca.pem"}`))
- f.Close()
- flags := pflag.NewFlagSet("test", pflag.ContinueOnError)
- flags.String("tlscacert", "", "")
- flags.Set("tlscacert", "~/.docker/ca.pem")
- _, err = MergeDaemonConfigurations(&Config{}, flags, configFile)
- if err == nil {
- t.Fatal("expected error, got nil")
- }
- if !strings.Contains(err.Error(), "tlscacert") {
- t.Fatalf("expected tlscacert conflict, got %v", err)
- }
- }
- func TestFindConfigurationConflictsWithUnknownKeys(t *testing.T) {
- config := map[string]interface{}{"tls-verify": "true"}
- flags := pflag.NewFlagSet("test", pflag.ContinueOnError)
- flags.Bool("tlsverify", false, "")
- err := findConfigurationConflicts(config, flags)
- if err == nil {
- t.Fatal("expected error, got nil")
- }
- if !strings.Contains(err.Error(), "the following directives don't match any configuration option: tls-verify") {
- t.Fatalf("expected tls-verify conflict, got %v", err)
- }
- }
- func TestFindConfigurationConflictsWithMergedValues(t *testing.T) {
- var hosts []string
- config := map[string]interface{}{"hosts": "tcp://127.0.0.1:2345"}
- flags := pflag.NewFlagSet("base", pflag.ContinueOnError)
- flags.VarP(opts.NewNamedListOptsRef("hosts", &hosts, nil), "host", "H", "")
- err := findConfigurationConflicts(config, flags)
- if err != nil {
- t.Fatal(err)
- }
- flags.Set("host", "unix:///var/run/docker.sock")
- err = findConfigurationConflicts(config, flags)
- if err == nil {
- t.Fatal("expected error, got nil")
- }
- if !strings.Contains(err.Error(), "hosts: (from flag: [unix:///var/run/docker.sock], from file: tcp://127.0.0.1:2345)") {
- t.Fatalf("expected hosts conflict, got %v", err)
- }
- }
- func TestValidateConfigurationErrors(t *testing.T) {
- minusNumber := -10
- testCases := []struct {
- config *Config
- }{
- {
- config: &Config{
- CommonConfig: CommonConfig{
- Labels: []string{"one"},
- },
- },
- },
- {
- config: &Config{
- CommonConfig: CommonConfig{
- Labels: []string{"foo=bar", "one"},
- },
- },
- },
- {
- config: &Config{
- CommonConfig: CommonConfig{
- DNS: []string{"1.1.1.1o"},
- },
- },
- },
- {
- config: &Config{
- CommonConfig: CommonConfig{
- DNS: []string{"2.2.2.2", "1.1.1.1o"},
- },
- },
- },
- {
- config: &Config{
- CommonConfig: CommonConfig{
- DNSSearch: []string{"123456"},
- },
- },
- },
- {
- config: &Config{
- CommonConfig: CommonConfig{
- DNSSearch: []string{"a.b.c", "123456"},
- },
- },
- },
- {
- config: &Config{
- CommonConfig: CommonConfig{
- MaxConcurrentDownloads: &minusNumber,
- // This is weird...
- ValuesSet: map[string]interface{}{
- "max-concurrent-downloads": -1,
- },
- },
- },
- },
- {
- config: &Config{
- CommonConfig: CommonConfig{
- MaxConcurrentUploads: &minusNumber,
- // This is weird...
- ValuesSet: map[string]interface{}{
- "max-concurrent-uploads": -1,
- },
- },
- },
- },
- }
- for _, tc := range testCases {
- err := Validate(tc.config)
- if err == nil {
- t.Fatalf("expected error, got nil for config %v", tc.config)
- }
- }
- }
- func TestValidateConfiguration(t *testing.T) {
- minusNumber := 4
- testCases := []struct {
- config *Config
- }{
- {
- config: &Config{
- CommonConfig: CommonConfig{
- Labels: []string{"one=two"},
- },
- },
- },
- {
- config: &Config{
- CommonConfig: CommonConfig{
- DNS: []string{"1.1.1.1"},
- },
- },
- },
- {
- config: &Config{
- CommonConfig: CommonConfig{
- DNSSearch: []string{"a.b.c"},
- },
- },
- },
- {
- config: &Config{
- CommonConfig: CommonConfig{
- MaxConcurrentDownloads: &minusNumber,
- // This is weird...
- ValuesSet: map[string]interface{}{
- "max-concurrent-downloads": -1,
- },
- },
- },
- },
- {
- config: &Config{
- CommonConfig: CommonConfig{
- MaxConcurrentUploads: &minusNumber,
- // This is weird...
- ValuesSet: map[string]interface{}{
- "max-concurrent-uploads": -1,
- },
- },
- },
- },
- }
- for _, tc := range testCases {
- err := Validate(tc.config)
- if err != nil {
- t.Fatalf("expected no error, got error %v", err)
- }
- }
- }
- func TestModifiedDiscoverySettings(t *testing.T) {
- cases := []struct {
- current *Config
- modified *Config
- expected bool
- }{
- {
- current: discoveryConfig("foo", "bar", map[string]string{}),
- modified: discoveryConfig("foo", "bar", map[string]string{}),
- expected: false,
- },
- {
- current: discoveryConfig("foo", "bar", map[string]string{"foo": "bar"}),
- modified: discoveryConfig("foo", "bar", map[string]string{"foo": "bar"}),
- expected: false,
- },
- {
- current: discoveryConfig("foo", "bar", map[string]string{}),
- modified: discoveryConfig("foo", "bar", nil),
- expected: false,
- },
- {
- current: discoveryConfig("foo", "bar", nil),
- modified: discoveryConfig("foo", "bar", map[string]string{}),
- expected: false,
- },
- {
- current: discoveryConfig("foo", "bar", nil),
- modified: discoveryConfig("baz", "bar", nil),
- expected: true,
- },
- {
- current: discoveryConfig("foo", "bar", nil),
- modified: discoveryConfig("foo", "baz", nil),
- expected: true,
- },
- {
- current: discoveryConfig("foo", "bar", nil),
- modified: discoveryConfig("foo", "bar", map[string]string{"foo": "bar"}),
- expected: true,
- },
- }
- for _, c := range cases {
- got := ModifiedDiscoverySettings(c.current, c.modified.ClusterStore, c.modified.ClusterAdvertise, c.modified.ClusterOpts)
- if c.expected != got {
- t.Fatalf("expected %v, got %v: current config %v, new config %v", c.expected, got, c.current, c.modified)
- }
- }
- }
- func discoveryConfig(backendAddr, advertiseAddr string, opts map[string]string) *Config {
- return &Config{
- CommonConfig: CommonConfig{
- ClusterStore: backendAddr,
- ClusterAdvertise: advertiseAddr,
- ClusterOpts: opts,
- },
- }
- }
|