builder.go 10 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377
  1. package dockerfile
  2. import (
  3. "bytes"
  4. "fmt"
  5. "io"
  6. "io/ioutil"
  7. "os"
  8. "strings"
  9. "github.com/Sirupsen/logrus"
  10. "github.com/docker/distribution/reference"
  11. apierrors "github.com/docker/docker/api/errors"
  12. "github.com/docker/docker/api/types"
  13. "github.com/docker/docker/api/types/backend"
  14. "github.com/docker/docker/api/types/container"
  15. "github.com/docker/docker/builder"
  16. "github.com/docker/docker/builder/dockerfile/command"
  17. "github.com/docker/docker/builder/dockerfile/parser"
  18. "github.com/docker/docker/image"
  19. "github.com/docker/docker/pkg/stringid"
  20. "github.com/pkg/errors"
  21. "golang.org/x/net/context"
  22. )
  23. var validCommitCommands = map[string]bool{
  24. "cmd": true,
  25. "entrypoint": true,
  26. "healthcheck": true,
  27. "env": true,
  28. "expose": true,
  29. "label": true,
  30. "onbuild": true,
  31. "user": true,
  32. "volume": true,
  33. "workdir": true,
  34. }
  35. var defaultLogConfig = container.LogConfig{Type: "none"}
  36. // Builder is a Dockerfile builder
  37. // It implements the builder.Backend interface.
  38. type Builder struct {
  39. options *types.ImageBuildOptions
  40. Stdout io.Writer
  41. Stderr io.Writer
  42. Output io.Writer
  43. docker builder.Backend
  44. context builder.Context
  45. clientCtx context.Context
  46. runConfig *container.Config // runconfig for cmd, run, entrypoint etc.
  47. tmpContainers map[string]struct{}
  48. imageContexts *imageContexts // helper for storing contexts from builds
  49. disableCommit bool
  50. cacheBusted bool
  51. buildArgs *buildArgs
  52. imageCache builder.ImageCache
  53. // TODO: these move to DispatchState
  54. escapeToken rune
  55. maintainer string
  56. cmdSet bool
  57. noBaseImage bool // A flag to track the use of `scratch` as the base image
  58. image string // imageID
  59. from builder.Image
  60. }
  61. // BuildManager implements builder.Backend and is shared across all Builder objects.
  62. type BuildManager struct {
  63. backend builder.Backend
  64. pathCache *pathCache // TODO: make this persistent
  65. }
  66. // NewBuildManager creates a BuildManager.
  67. func NewBuildManager(b builder.Backend) (bm *BuildManager) {
  68. return &BuildManager{backend: b, pathCache: &pathCache{}}
  69. }
  70. // BuildFromContext builds a new image from a given context.
  71. func (bm *BuildManager) BuildFromContext(ctx context.Context, src io.ReadCloser, remote string, buildOptions *types.ImageBuildOptions, pg backend.ProgressWriter) (string, error) {
  72. if buildOptions.Squash && !bm.backend.HasExperimental() {
  73. return "", apierrors.NewBadRequestError(errors.New("squash is only supported with experimental mode"))
  74. }
  75. buildContext, dockerfileName, err := builder.DetectContextFromRemoteURL(src, remote, pg.ProgressReaderFunc)
  76. if err != nil {
  77. return "", err
  78. }
  79. defer func() {
  80. if err := buildContext.Close(); err != nil {
  81. logrus.Debugf("[BUILDER] failed to remove temporary context: %v", err)
  82. }
  83. }()
  84. if len(dockerfileName) > 0 {
  85. buildOptions.Dockerfile = dockerfileName
  86. }
  87. b, err := NewBuilder(ctx, buildOptions, bm.backend, builder.DockerIgnoreContext{ModifiableContext: buildContext})
  88. if err != nil {
  89. return "", err
  90. }
  91. b.imageContexts.cache = bm.pathCache
  92. return b.build(pg.StdoutFormatter, pg.StderrFormatter, pg.Output)
  93. }
  94. // NewBuilder creates a new Dockerfile builder from an optional dockerfile and a Config.
  95. // If dockerfile is nil, the Dockerfile specified by Config.DockerfileName,
  96. // will be read from the Context passed to Build().
  97. func NewBuilder(clientCtx context.Context, config *types.ImageBuildOptions, backend builder.Backend, buildContext builder.Context) (b *Builder, err error) {
  98. if config == nil {
  99. config = new(types.ImageBuildOptions)
  100. }
  101. b = &Builder{
  102. clientCtx: clientCtx,
  103. options: config,
  104. Stdout: os.Stdout,
  105. Stderr: os.Stderr,
  106. docker: backend,
  107. context: buildContext,
  108. runConfig: new(container.Config),
  109. tmpContainers: map[string]struct{}{},
  110. buildArgs: newBuildArgs(config.BuildArgs),
  111. escapeToken: parser.DefaultEscapeToken,
  112. }
  113. b.imageContexts = &imageContexts{b: b}
  114. return b, nil
  115. }
  116. func (b *Builder) resetImageCache() {
  117. if icb, ok := b.docker.(builder.ImageCacheBuilder); ok {
  118. b.imageCache = icb.MakeImageCache(b.options.CacheFrom)
  119. }
  120. b.noBaseImage = false
  121. b.cacheBusted = false
  122. }
  123. // sanitizeRepoAndTags parses the raw "t" parameter received from the client
  124. // to a slice of repoAndTag.
  125. // It also validates each repoName and tag.
  126. func sanitizeRepoAndTags(names []string) ([]reference.Named, error) {
  127. var (
  128. repoAndTags []reference.Named
  129. // This map is used for deduplicating the "-t" parameter.
  130. uniqNames = make(map[string]struct{})
  131. )
  132. for _, repo := range names {
  133. if repo == "" {
  134. continue
  135. }
  136. ref, err := reference.ParseNormalizedNamed(repo)
  137. if err != nil {
  138. return nil, err
  139. }
  140. if _, isCanonical := ref.(reference.Canonical); isCanonical {
  141. return nil, errors.New("build tag cannot contain a digest")
  142. }
  143. ref = reference.TagNameOnly(ref)
  144. nameWithTag := ref.String()
  145. if _, exists := uniqNames[nameWithTag]; !exists {
  146. uniqNames[nameWithTag] = struct{}{}
  147. repoAndTags = append(repoAndTags, ref)
  148. }
  149. }
  150. return repoAndTags, nil
  151. }
  152. // build runs the Dockerfile builder from a context and a docker object that allows to make calls
  153. // to Docker.
  154. func (b *Builder) build(stdout io.Writer, stderr io.Writer, out io.Writer) (string, error) {
  155. defer b.imageContexts.unmount()
  156. b.Stdout = stdout
  157. b.Stderr = stderr
  158. b.Output = out
  159. dockerfile, err := b.readAndParseDockerfile()
  160. if err != nil {
  161. return "", err
  162. }
  163. repoAndTags, err := sanitizeRepoAndTags(b.options.Tags)
  164. if err != nil {
  165. return "", err
  166. }
  167. addNodesForLabelOption(dockerfile.AST, b.options.Labels)
  168. if err := checkDispatchDockerfile(dockerfile.AST); err != nil {
  169. return "", err
  170. }
  171. imageID, err := b.dispatchDockerfileWithCancellation(dockerfile)
  172. if err != nil {
  173. return "", err
  174. }
  175. b.warnOnUnusedBuildArgs()
  176. if imageID == "" {
  177. return "", errors.New("No image was generated. Is your Dockerfile empty?")
  178. }
  179. if b.options.Squash {
  180. if imageID, err = b.squashBuild(imageID); err != nil {
  181. return "", err
  182. }
  183. }
  184. fmt.Fprintf(b.Stdout, "Successfully built %s\n", stringid.TruncateID(imageID))
  185. if err := b.tagImages(imageID, repoAndTags); err != nil {
  186. return "", err
  187. }
  188. return imageID, nil
  189. }
  190. func (b *Builder) dispatchDockerfileWithCancellation(dockerfile *parser.Result) (string, error) {
  191. // TODO: pass this to dispatchRequest instead
  192. b.escapeToken = dockerfile.EscapeToken
  193. total := len(dockerfile.AST.Children)
  194. var imageID string
  195. for i, n := range dockerfile.AST.Children {
  196. select {
  197. case <-b.clientCtx.Done():
  198. logrus.Debug("Builder: build cancelled!")
  199. fmt.Fprint(b.Stdout, "Build cancelled")
  200. return "", errors.New("Build cancelled")
  201. default:
  202. // Not cancelled yet, keep going...
  203. }
  204. if command.From == n.Value && b.imageContexts.isCurrentTarget(b.options.Target) {
  205. break
  206. }
  207. if err := b.dispatch(i, total, n); err != nil {
  208. if b.options.ForceRemove {
  209. b.clearTmp()
  210. }
  211. return "", err
  212. }
  213. // TODO: get this from dispatch
  214. imageID = b.image
  215. fmt.Fprintf(b.Stdout, " ---> %s\n", stringid.TruncateID(imageID))
  216. if b.options.Remove {
  217. b.clearTmp()
  218. }
  219. }
  220. if b.options.Target != "" && !b.imageContexts.isCurrentTarget(b.options.Target) {
  221. return "", errors.Errorf("failed to reach build target %s in Dockerfile", b.options.Target)
  222. }
  223. return imageID, nil
  224. }
  225. func (b *Builder) squashBuild(imageID string) (string, error) {
  226. var fromID string
  227. var err error
  228. if b.from != nil {
  229. fromID = b.from.ImageID()
  230. }
  231. imageID, err = b.docker.SquashImage(imageID, fromID)
  232. if err != nil {
  233. return "", errors.Wrap(err, "error squashing image")
  234. }
  235. return imageID, nil
  236. }
  237. func addNodesForLabelOption(dockerfile *parser.Node, labels map[string]string) {
  238. if len(labels) == 0 {
  239. return
  240. }
  241. node := parser.NodeFromLabels(labels)
  242. dockerfile.Children = append(dockerfile.Children, node)
  243. }
  244. // check if there are any leftover build-args that were passed but not
  245. // consumed during build. Print a warning, if there are any.
  246. func (b *Builder) warnOnUnusedBuildArgs() {
  247. leftoverArgs := b.buildArgs.UnreferencedOptionArgs()
  248. if len(leftoverArgs) > 0 {
  249. fmt.Fprintf(b.Stderr, "[Warning] One or more build-args %v were not consumed\n", leftoverArgs)
  250. }
  251. }
  252. func (b *Builder) tagImages(id string, repoAndTags []reference.Named) error {
  253. imageID := image.ID(id)
  254. for _, rt := range repoAndTags {
  255. if err := b.docker.TagImageWithReference(imageID, rt); err != nil {
  256. return err
  257. }
  258. fmt.Fprintf(b.Stdout, "Successfully tagged %s\n", reference.FamiliarString(rt))
  259. }
  260. return nil
  261. }
  262. // hasFromImage returns true if the builder has processed a `FROM <image>` line
  263. // TODO: move to DispatchState
  264. func (b *Builder) hasFromImage() bool {
  265. return b.image != "" || b.noBaseImage
  266. }
  267. // BuildFromConfig builds directly from `changes`, treating it as if it were the contents of a Dockerfile
  268. // It will:
  269. // - Call parse.Parse() to get an AST root for the concatenated Dockerfile entries.
  270. // - Do build by calling builder.dispatch() to call all entries' handling routines
  271. //
  272. // BuildFromConfig is used by the /commit endpoint, with the changes
  273. // coming from the query parameter of the same name.
  274. //
  275. // TODO: Remove?
  276. func BuildFromConfig(config *container.Config, changes []string) (*container.Config, error) {
  277. b, err := NewBuilder(context.Background(), nil, nil, nil)
  278. if err != nil {
  279. return nil, err
  280. }
  281. result, err := parser.Parse(bytes.NewBufferString(strings.Join(changes, "\n")))
  282. if err != nil {
  283. return nil, err
  284. }
  285. // ensure that the commands are valid
  286. for _, n := range result.AST.Children {
  287. if !validCommitCommands[n.Value] {
  288. return nil, fmt.Errorf("%s is not a valid change command", n.Value)
  289. }
  290. }
  291. b.runConfig = config
  292. b.Stdout = ioutil.Discard
  293. b.Stderr = ioutil.Discard
  294. b.disableCommit = true
  295. if err := checkDispatchDockerfile(result.AST); err != nil {
  296. return nil, err
  297. }
  298. if err := dispatchFromDockerfile(b, result); err != nil {
  299. return nil, err
  300. }
  301. return b.runConfig, nil
  302. }
  303. func checkDispatchDockerfile(dockerfile *parser.Node) error {
  304. for _, n := range dockerfile.Children {
  305. if err := checkDispatch(n); err != nil {
  306. return errors.Wrapf(err, "Dockerfile parse error line %d", n.StartLine)
  307. }
  308. }
  309. return nil
  310. }
  311. func dispatchFromDockerfile(b *Builder, result *parser.Result) error {
  312. // TODO: pass this to dispatchRequest instead
  313. b.escapeToken = result.EscapeToken
  314. ast := result.AST
  315. total := len(ast.Children)
  316. for i, n := range ast.Children {
  317. if err := b.dispatch(i, total, n); err != nil {
  318. return err
  319. }
  320. }
  321. return nil
  322. }