docker_cli_build_test.go 80 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198219922002201220222032204220522062207220822092210221122122213221422152216221722182219222022212222222322242225222622272228222922302231223222332234223522362237223822392240224122422243224422452246224722482249225022512252225322542255225622572258225922602261226222632264226522662267226822692270227122722273227422752276227722782279228022812282228322842285228622872288228922902291229222932294229522962297229822992300230123022303230423052306230723082309231023112312231323142315231623172318231923202321232223232324232523262327232823292330233123322333233423352336233723382339234023412342234323442345234623472348234923502351235223532354235523562357235823592360236123622363236423652366236723682369237023712372237323742375237623772378237923802381238223832384238523862387238823892390239123922393239423952396239723982399240024012402240324042405240624072408240924102411241224132414241524162417241824192420242124222423242424252426242724282429243024312432243324342435243624372438243924402441244224432444244524462447244824492450245124522453245424552456245724582459246024612462246324642465246624672468246924702471247224732474247524762477247824792480248124822483248424852486248724882489249024912492249324942495249624972498249925002501250225032504250525062507250825092510251125122513251425152516251725182519252025212522252325242525252625272528252925302531253225332534253525362537253825392540254125422543254425452546254725482549255025512552255325542555255625572558255925602561256225632564256525662567256825692570257125722573257425752576257725782579258025812582258325842585258625872588258925902591259225932594259525962597259825992600260126022603260426052606260726082609261026112612261326142615261626172618261926202621262226232624262526262627262826292630263126322633263426352636263726382639264026412642264326442645264626472648264926502651265226532654265526562657265826592660266126622663266426652666266726682669267026712672267326742675267626772678267926802681268226832684268526862687268826892690269126922693269426952696269726982699270027012702270327042705270627072708270927102711271227132714271527162717271827192720272127222723272427252726272727282729273027312732273327342735273627372738273927402741274227432744274527462747274827492750275127522753275427552756275727582759276027612762276327642765276627672768276927702771277227732774277527762777277827792780278127822783278427852786278727882789279027912792279327942795279627972798279928002801280228032804280528062807280828092810281128122813281428152816281728182819282028212822282328242825282628272828282928302831283228332834283528362837283828392840284128422843284428452846284728482849285028512852285328542855285628572858285928602861286228632864286528662867286828692870287128722873287428752876287728782879288028812882288328842885288628872888288928902891289228932894289528962897289828992900290129022903290429052906290729082909291029112912291329142915291629172918291929202921292229232924292529262927292829292930293129322933293429352936293729382939294029412942294329442945294629472948294929502951295229532954295529562957295829592960296129622963296429652966296729682969297029712972297329742975297629772978297929802981298229832984298529862987298829892990299129922993299429952996299729982999300030013002300330043005300630073008300930103011301230133014301530163017301830193020302130223023302430253026302730283029303030313032303330343035303630373038303930403041304230433044304530463047304830493050305130523053305430553056305730583059306030613062306330643065306630673068306930703071307230733074307530763077307830793080308130823083308430853086308730883089309030913092309330943095309630973098309931003101310231033104310531063107310831093110311131123113311431153116311731183119312031213122312331243125312631273128312931303131313231333134313531363137313831393140314131423143
  1. package main
  2. import (
  3. "archive/tar"
  4. "encoding/json"
  5. "fmt"
  6. "io/ioutil"
  7. "os"
  8. "os/exec"
  9. "path/filepath"
  10. "regexp"
  11. "strings"
  12. "testing"
  13. "time"
  14. "github.com/docker/docker/pkg/archive"
  15. )
  16. func TestBuildEnvironmentReplacementUser(t *testing.T) {
  17. name := "testbuildenvironmentreplacement"
  18. defer deleteImages(name)
  19. _, err := buildImage(name, `
  20. FROM scratch
  21. ENV user foo
  22. USER ${user}
  23. `, true)
  24. if err != nil {
  25. t.Fatal(err)
  26. }
  27. res, err := inspectFieldJSON(name, "Config.User")
  28. if err != nil {
  29. t.Fatal(err)
  30. }
  31. if res != `"foo"` {
  32. t.Fatal("User foo from environment not in Config.User on image")
  33. }
  34. logDone("build - user environment replacement")
  35. }
  36. func TestBuildEnvironmentReplacementVolume(t *testing.T) {
  37. name := "testbuildenvironmentreplacement"
  38. defer deleteImages(name)
  39. _, err := buildImage(name, `
  40. FROM scratch
  41. ENV volume /quux
  42. VOLUME ${volume}
  43. `, true)
  44. if err != nil {
  45. t.Fatal(err)
  46. }
  47. res, err := inspectFieldJSON(name, "Config.Volumes")
  48. if err != nil {
  49. t.Fatal(err)
  50. }
  51. var volumes map[string]interface{}
  52. if err := json.Unmarshal([]byte(res), &volumes); err != nil {
  53. t.Fatal(err)
  54. }
  55. if _, ok := volumes["/quux"]; !ok {
  56. t.Fatal("Volume /quux from environment not in Config.Volumes on image")
  57. }
  58. logDone("build - volume environment replacement")
  59. }
  60. func TestBuildEnvironmentReplacementExpose(t *testing.T) {
  61. name := "testbuildenvironmentreplacement"
  62. defer deleteImages(name)
  63. _, err := buildImage(name, `
  64. FROM scratch
  65. ENV port 80
  66. EXPOSE ${port}
  67. `, true)
  68. if err != nil {
  69. t.Fatal(err)
  70. }
  71. res, err := inspectFieldJSON(name, "Config.ExposedPorts")
  72. if err != nil {
  73. t.Fatal(err)
  74. }
  75. var exposedPorts map[string]interface{}
  76. if err := json.Unmarshal([]byte(res), &exposedPorts); err != nil {
  77. t.Fatal(err)
  78. }
  79. if _, ok := exposedPorts["80/tcp"]; !ok {
  80. t.Fatal("Exposed port 80 from environment not in Config.ExposedPorts on image")
  81. }
  82. logDone("build - expose environment replacement")
  83. }
  84. func TestBuildEnvironmentReplacementWorkdir(t *testing.T) {
  85. name := "testbuildenvironmentreplacement"
  86. defer deleteImages(name)
  87. _, err := buildImage(name, `
  88. FROM busybox
  89. ENV MYWORKDIR /work
  90. RUN mkdir ${MYWORKDIR}
  91. WORKDIR ${MYWORKDIR}
  92. `, true)
  93. if err != nil {
  94. t.Fatal(err)
  95. }
  96. logDone("build - workdir environment replacement")
  97. }
  98. func TestBuildEnvironmentReplacementAddCopy(t *testing.T) {
  99. name := "testbuildenvironmentreplacement"
  100. defer deleteImages(name)
  101. ctx, err := fakeContext(`
  102. FROM scratch
  103. ENV baz foo
  104. ENV quux bar
  105. ENV dot .
  106. ADD ${baz} ${dot}
  107. COPY ${quux} ${dot}
  108. `,
  109. map[string]string{
  110. "foo": "test1",
  111. "bar": "test2",
  112. })
  113. if err != nil {
  114. t.Fatal(err)
  115. }
  116. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  117. t.Fatal(err)
  118. }
  119. logDone("build - add/copy environment replacement")
  120. }
  121. func TestBuildEnvironmentReplacementEnv(t *testing.T) {
  122. name := "testbuildenvironmentreplacement"
  123. defer deleteImages(name)
  124. _, err := buildImage(name,
  125. `
  126. FROM scratch
  127. ENV foo foo
  128. ENV bar ${foo}
  129. `, true)
  130. if err != nil {
  131. t.Fatal(err)
  132. }
  133. res, err := inspectFieldJSON(name, "Config.Env")
  134. if err != nil {
  135. t.Fatal(err)
  136. }
  137. envResult := []string{}
  138. if err = unmarshalJSON([]byte(res), &envResult); err != nil {
  139. t.Fatal(err)
  140. }
  141. found := false
  142. for _, env := range envResult {
  143. parts := strings.SplitN(env, "=", 2)
  144. if parts[0] == "bar" {
  145. found = true
  146. if parts[1] != "foo" {
  147. t.Fatal("Could not find replaced var for env `bar`: got %q instead of `foo`", parts[1])
  148. }
  149. }
  150. }
  151. if !found {
  152. t.Fatal("Never found the `bar` env variable")
  153. }
  154. logDone("build - env environment replacement")
  155. }
  156. func TestBuildHandleEscapes(t *testing.T) {
  157. name := "testbuildhandleescapes"
  158. defer deleteImages(name)
  159. _, err := buildImage(name,
  160. `
  161. FROM scratch
  162. ENV FOO bar
  163. VOLUME ${FOO}
  164. `, true)
  165. if err != nil {
  166. t.Fatal(err)
  167. }
  168. var result map[string]map[string]struct{}
  169. res, err := inspectFieldJSON(name, "Config.Volumes")
  170. if err != nil {
  171. t.Fatal(err)
  172. }
  173. if err = unmarshalJSON([]byte(res), &result); err != nil {
  174. t.Fatal(err)
  175. }
  176. if _, ok := result["bar"]; !ok {
  177. t.Fatal("Could not find volume bar set from env foo in volumes table")
  178. }
  179. _, err = buildImage(name,
  180. `
  181. FROM scratch
  182. ENV FOO bar
  183. VOLUME \${FOO}
  184. `, true)
  185. if err != nil {
  186. t.Fatal(err)
  187. }
  188. res, err = inspectFieldJSON(name, "Config.Volumes")
  189. if err != nil {
  190. t.Fatal(err)
  191. }
  192. if err = unmarshalJSON([]byte(res), &result); err != nil {
  193. t.Fatal(err)
  194. }
  195. if _, ok := result["${FOO}"]; !ok {
  196. t.Fatal("Could not find volume ${FOO} set from env foo in volumes table")
  197. }
  198. // this test in particular provides *7* backslashes and expects 6 to come back.
  199. // Like above, the first escape is swallowed and the rest are treated as
  200. // literals, this one is just less obvious because of all the character noise.
  201. _, err = buildImage(name,
  202. `
  203. FROM scratch
  204. ENV FOO bar
  205. VOLUME \\\\\\\${FOO}
  206. `, true)
  207. if err != nil {
  208. t.Fatal(err)
  209. }
  210. res, err = inspectFieldJSON(name, "Config.Volumes")
  211. if err != nil {
  212. t.Fatal(err)
  213. }
  214. if err = unmarshalJSON([]byte(res), &result); err != nil {
  215. t.Fatal(err)
  216. }
  217. if _, ok := result[`\\\\\\${FOO}`]; !ok {
  218. t.Fatal(`Could not find volume \\\\\\${FOO} set from env foo in volumes table`)
  219. }
  220. logDone("build - handle escapes")
  221. }
  222. func TestBuildOnBuildLowercase(t *testing.T) {
  223. name := "testbuildonbuildlowercase"
  224. name2 := "testbuildonbuildlowercase2"
  225. defer deleteImages(name, name2)
  226. _, err := buildImage(name,
  227. `
  228. FROM busybox
  229. onbuild run echo quux
  230. `, true)
  231. if err != nil {
  232. t.Fatal(err)
  233. }
  234. _, out, err := buildImageWithOut(name2, fmt.Sprintf(`
  235. FROM %s
  236. `, name), true)
  237. if err != nil {
  238. t.Fatal(err)
  239. }
  240. if !strings.Contains(out, "quux") {
  241. t.Fatalf("Did not receive the expected echo text, got %s", out)
  242. }
  243. if strings.Contains(out, "ONBUILD ONBUILD") {
  244. t.Fatalf("Got an ONBUILD ONBUILD error with no error: got %s", out)
  245. }
  246. logDone("build - handle case-insensitive onbuild statement")
  247. }
  248. func TestBuildEnvEscapes(t *testing.T) {
  249. name := "testbuildenvescapes"
  250. defer deleteAllContainers()
  251. defer deleteImages(name)
  252. _, err := buildImage(name,
  253. `
  254. FROM busybox
  255. ENV TEST foo
  256. CMD echo \$
  257. `,
  258. true)
  259. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "-t", name))
  260. if err != nil {
  261. t.Fatal(err)
  262. }
  263. if strings.TrimSpace(out) != "$" {
  264. t.Fatalf("Env TEST was not overwritten with bar when foo was supplied to dockerfile: was %q", strings.TrimSpace(out))
  265. }
  266. logDone("build - env should handle \\$ properly")
  267. }
  268. func TestBuildEnvOverwrite(t *testing.T) {
  269. name := "testbuildenvoverwrite"
  270. defer deleteAllContainers()
  271. defer deleteImages(name)
  272. _, err := buildImage(name,
  273. `
  274. FROM busybox
  275. ENV TEST foo
  276. CMD echo ${TEST}
  277. `,
  278. true)
  279. if err != nil {
  280. t.Fatal(err)
  281. }
  282. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "-e", "TEST=bar", "-t", name))
  283. if err != nil {
  284. t.Fatal(err)
  285. }
  286. if strings.TrimSpace(out) != "bar" {
  287. t.Fatalf("Env TEST was not overwritten with bar when foo was supplied to dockerfile: was %q", strings.TrimSpace(out))
  288. }
  289. logDone("build - env should overwrite builder ENV during run")
  290. }
  291. func TestBuildOnBuildForbiddenMaintainerInSourceImage(t *testing.T) {
  292. name := "testbuildonbuildforbiddenmaintainerinsourceimage"
  293. defer deleteImages(name)
  294. createCmd := exec.Command(dockerBinary, "create", "busybox", "true")
  295. out, _, _, err := runCommandWithStdoutStderr(createCmd)
  296. errorOut(err, t, out)
  297. cleanedContainerID := stripTrailingCharacters(out)
  298. commitCmd := exec.Command(dockerBinary, "commit", "--run", "{\"OnBuild\":[\"MAINTAINER docker.io\"]}", cleanedContainerID, "onbuild")
  299. if _, err := runCommand(commitCmd); err != nil {
  300. t.Fatal(err)
  301. }
  302. _, err = buildImage(name,
  303. `FROM onbuild`,
  304. true)
  305. if err != nil {
  306. if !strings.Contains(err.Error(), "maintainer isn't allowed as an ONBUILD trigger") {
  307. t.Fatalf("Wrong error %v, must be about MAINTAINER and ONBUILD in source image", err)
  308. }
  309. } else {
  310. t.Fatal("Error must not be nil")
  311. }
  312. logDone("build - onbuild forbidden maintainer in source image")
  313. }
  314. func TestBuildOnBuildForbiddenFromInSourceImage(t *testing.T) {
  315. name := "testbuildonbuildforbiddenfrominsourceimage"
  316. defer deleteImages(name)
  317. createCmd := exec.Command(dockerBinary, "create", "busybox", "true")
  318. out, _, _, err := runCommandWithStdoutStderr(createCmd)
  319. errorOut(err, t, out)
  320. cleanedContainerID := stripTrailingCharacters(out)
  321. commitCmd := exec.Command(dockerBinary, "commit", "--run", "{\"OnBuild\":[\"FROM busybox\"]}", cleanedContainerID, "onbuild")
  322. if _, err := runCommand(commitCmd); err != nil {
  323. t.Fatal(err)
  324. }
  325. _, err = buildImage(name,
  326. `FROM onbuild`,
  327. true)
  328. if err != nil {
  329. if !strings.Contains(err.Error(), "from isn't allowed as an ONBUILD trigger") {
  330. t.Fatalf("Wrong error %v, must be about FROM and ONBUILD in source image", err)
  331. }
  332. } else {
  333. t.Fatal("Error must not be nil")
  334. }
  335. logDone("build - onbuild forbidden from in source image")
  336. }
  337. func TestBuildOnBuildForbiddenChainedInSourceImage(t *testing.T) {
  338. name := "testbuildonbuildforbiddenchainedinsourceimage"
  339. defer deleteImages(name)
  340. createCmd := exec.Command(dockerBinary, "create", "busybox", "true")
  341. out, _, _, err := runCommandWithStdoutStderr(createCmd)
  342. errorOut(err, t, out)
  343. cleanedContainerID := stripTrailingCharacters(out)
  344. commitCmd := exec.Command(dockerBinary, "commit", "--run", "{\"OnBuild\":[\"ONBUILD RUN ls\"]}", cleanedContainerID, "onbuild")
  345. if _, err := runCommand(commitCmd); err != nil {
  346. t.Fatal(err)
  347. }
  348. _, err = buildImage(name,
  349. `FROM onbuild`,
  350. true)
  351. if err != nil {
  352. if !strings.Contains(err.Error(), "Chaining ONBUILD via `ONBUILD ONBUILD` isn't allowed") {
  353. t.Fatalf("Wrong error %v, must be about chaining ONBUILD in source image", err)
  354. }
  355. } else {
  356. t.Fatal("Error must not be nil")
  357. }
  358. logDone("build - onbuild forbidden chained in source image")
  359. }
  360. func TestBuildOnBuildCmdEntrypointJSON(t *testing.T) {
  361. name1 := "onbuildcmd"
  362. name2 := "onbuildgenerated"
  363. defer deleteAllContainers()
  364. defer deleteImages(name2)
  365. defer deleteImages(name1)
  366. _, err := buildImage(name1, `
  367. FROM busybox
  368. ONBUILD CMD ["hello world"]
  369. ONBUILD ENTRYPOINT ["echo"]
  370. ONBUILD RUN ["true"]`,
  371. false)
  372. if err != nil {
  373. t.Fatal(err)
  374. }
  375. _, err = buildImage(name2, fmt.Sprintf(`FROM %s`, name1), false)
  376. if err != nil {
  377. t.Fatal(err)
  378. }
  379. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "-t", name2))
  380. if err != nil {
  381. t.Fatal(err)
  382. }
  383. if !regexp.MustCompile(`(?m)^hello world`).MatchString(out) {
  384. t.Fatal("did not get echo output from onbuild", out)
  385. }
  386. logDone("build - onbuild with json entrypoint/cmd")
  387. }
  388. func TestBuildOnBuildEntrypointJSON(t *testing.T) {
  389. name1 := "onbuildcmd"
  390. name2 := "onbuildgenerated"
  391. defer deleteAllContainers()
  392. defer deleteImages(name2)
  393. defer deleteImages(name1)
  394. _, err := buildImage(name1, `
  395. FROM busybox
  396. ONBUILD ENTRYPOINT ["echo"]`,
  397. false)
  398. if err != nil {
  399. t.Fatal(err)
  400. }
  401. _, err = buildImage(name2, fmt.Sprintf("FROM %s\nCMD [\"hello world\"]\n", name1), false)
  402. if err != nil {
  403. t.Fatal(err)
  404. }
  405. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "-t", name2))
  406. if err != nil {
  407. t.Fatal(err)
  408. }
  409. if !regexp.MustCompile(`(?m)^hello world`).MatchString(out) {
  410. t.Fatal("got malformed output from onbuild", out)
  411. }
  412. logDone("build - onbuild with json entrypoint")
  413. }
  414. func TestBuildCacheADD(t *testing.T) {
  415. name := "testbuildtwoimageswithadd"
  416. defer deleteImages(name)
  417. server, err := fakeStorage(map[string]string{
  418. "robots.txt": "hello",
  419. "index.html": "world",
  420. })
  421. if err != nil {
  422. t.Fatal(err)
  423. }
  424. defer server.Close()
  425. if _, err := buildImage(name,
  426. fmt.Sprintf(`FROM scratch
  427. ADD %s/robots.txt /`, server.URL),
  428. true); err != nil {
  429. t.Fatal(err)
  430. }
  431. _, out, err := buildImageWithOut(name,
  432. fmt.Sprintf(`FROM scratch
  433. ADD %s/index.html /`, server.URL),
  434. true)
  435. if err != nil {
  436. t.Fatal(err)
  437. }
  438. if strings.Contains(out, "Using cache") {
  439. t.Fatal("2nd build used cache on ADD, it shouldn't")
  440. }
  441. logDone("build - build two images with remote ADD")
  442. }
  443. func TestBuildSixtySteps(t *testing.T) {
  444. name := "foobuildsixtysteps"
  445. defer deleteImages(name)
  446. ctx, err := fakeContext("FROM scratch\n"+strings.Repeat("ADD foo /\n", 60),
  447. map[string]string{
  448. "foo": "test1",
  449. })
  450. if err != nil {
  451. t.Fatal(err)
  452. }
  453. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  454. t.Fatal(err)
  455. }
  456. logDone("build - build an image with sixty build steps")
  457. }
  458. func TestBuildAddSingleFileToRoot(t *testing.T) {
  459. name := "testaddimg"
  460. defer deleteImages(name)
  461. ctx, err := fakeContext(`FROM busybox
  462. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  463. RUN echo 'dockerio:x:1001:' >> /etc/group
  464. RUN touch /exists
  465. RUN chown dockerio.dockerio /exists
  466. ADD test_file /
  467. RUN [ $(ls -l /test_file | awk '{print $3":"$4}') = 'root:root' ]
  468. RUN [ $(ls -l /test_file | awk '{print $1}') = '-rw-r--r--' ]
  469. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  470. map[string]string{
  471. "test_file": "test1",
  472. })
  473. if err != nil {
  474. t.Fatal(err)
  475. }
  476. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  477. t.Fatal(err)
  478. }
  479. logDone("build - add single file to root")
  480. }
  481. // Issue #3960: "ADD src ." hangs
  482. func TestBuildAddSingleFileToWorkdir(t *testing.T) {
  483. name := "testaddsinglefiletoworkdir"
  484. defer deleteImages(name)
  485. ctx, err := fakeContext(`FROM busybox
  486. ADD test_file .`,
  487. map[string]string{
  488. "test_file": "test1",
  489. })
  490. if err != nil {
  491. t.Fatal(err)
  492. }
  493. done := make(chan struct{})
  494. go func() {
  495. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  496. t.Fatal(err)
  497. }
  498. close(done)
  499. }()
  500. select {
  501. case <-time.After(5 * time.Second):
  502. t.Fatal("Build with adding to workdir timed out")
  503. case <-done:
  504. }
  505. logDone("build - add single file to workdir")
  506. }
  507. func TestBuildAddSingleFileToExistDir(t *testing.T) {
  508. name := "testaddsinglefiletoexistdir"
  509. defer deleteImages(name)
  510. ctx, err := fakeContext(`FROM busybox
  511. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  512. RUN echo 'dockerio:x:1001:' >> /etc/group
  513. RUN mkdir /exists
  514. RUN touch /exists/exists_file
  515. RUN chown -R dockerio.dockerio /exists
  516. ADD test_file /exists/
  517. RUN [ $(ls -l / | grep exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]
  518. RUN [ $(ls -l /exists/test_file | awk '{print $3":"$4}') = 'root:root' ]
  519. RUN [ $(ls -l /exists/exists_file | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  520. map[string]string{
  521. "test_file": "test1",
  522. })
  523. if err != nil {
  524. t.Fatal(err)
  525. }
  526. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  527. t.Fatal(err)
  528. }
  529. logDone("build - add single file to existing dir")
  530. }
  531. func TestBuildCopyAddMultipleFiles(t *testing.T) {
  532. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
  533. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testaddimg", "MultipleFiles")
  534. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  535. if err != nil || exitCode != 0 {
  536. t.Fatal("failed to build the image")
  537. }
  538. deleteImages("testaddimg")
  539. logDone("build - mulitple file copy/add tests")
  540. }
  541. func TestBuildAddMultipleFilesToFile(t *testing.T) {
  542. name := "testaddmultiplefilestofile"
  543. defer deleteImages(name)
  544. ctx, err := fakeContext(`FROM scratch
  545. ADD file1.txt file2.txt test
  546. `,
  547. map[string]string{
  548. "file1.txt": "test1",
  549. "file2.txt": "test1",
  550. })
  551. defer ctx.Close()
  552. if err != nil {
  553. t.Fatal(err)
  554. }
  555. expected := "When using ADD with more than one source file, the destination must be a directory and end with a /"
  556. if _, err := buildImageFromContext(name, ctx, true); err == nil || !strings.Contains(err.Error(), expected) {
  557. t.Fatalf("Wrong error: (should contain \"%s\") got:\n%v", expected, err)
  558. }
  559. logDone("build - multiple add files to file")
  560. }
  561. func TestBuildAddMultipleFilesToFileWild(t *testing.T) {
  562. name := "testaddmultiplefilestofilewild"
  563. defer deleteImages(name)
  564. ctx, err := fakeContext(`FROM scratch
  565. ADD file*.txt test
  566. `,
  567. map[string]string{
  568. "file1.txt": "test1",
  569. "file2.txt": "test1",
  570. })
  571. defer ctx.Close()
  572. if err != nil {
  573. t.Fatal(err)
  574. }
  575. expected := "When using ADD with more than one source file, the destination must be a directory and end with a /"
  576. if _, err := buildImageFromContext(name, ctx, true); err == nil || !strings.Contains(err.Error(), expected) {
  577. t.Fatalf("Wrong error: (should contain \"%s\") got:\n%v", expected, err)
  578. }
  579. logDone("build - multiple add files to file wild")
  580. }
  581. func TestBuildCopyMultipleFilesToFile(t *testing.T) {
  582. name := "testcopymultiplefilestofile"
  583. defer deleteImages(name)
  584. ctx, err := fakeContext(`FROM scratch
  585. COPY file1.txt file2.txt test
  586. `,
  587. map[string]string{
  588. "file1.txt": "test1",
  589. "file2.txt": "test1",
  590. })
  591. defer ctx.Close()
  592. if err != nil {
  593. t.Fatal(err)
  594. }
  595. expected := "When using COPY with more than one source file, the destination must be a directory and end with a /"
  596. if _, err := buildImageFromContext(name, ctx, true); err == nil || !strings.Contains(err.Error(), expected) {
  597. t.Fatalf("Wrong error: (should contain \"%s\") got:\n%v", expected, err)
  598. }
  599. logDone("build - multiple copy files to file")
  600. }
  601. func TestBuildCopyWildcard(t *testing.T) {
  602. name := "testcopywildcard"
  603. defer deleteImages(name)
  604. server, err := fakeStorage(map[string]string{
  605. "robots.txt": "hello",
  606. "index.html": "world",
  607. })
  608. if err != nil {
  609. t.Fatal(err)
  610. }
  611. defer server.Close()
  612. ctx, err := fakeContext(fmt.Sprintf(`FROM busybox
  613. COPY file*.txt /tmp/
  614. RUN ls /tmp/file1.txt /tmp/file2.txt
  615. RUN mkdir /tmp1
  616. COPY dir* /tmp1/
  617. RUN ls /tmp1/dirt /tmp1/nested_file /tmp1/nested_dir/nest_nest_file
  618. RUN mkdir /tmp2
  619. ADD dir/*dir %s/robots.txt /tmp2/
  620. RUN ls /tmp2/nest_nest_file /tmp2/robots.txt
  621. `, server.URL),
  622. map[string]string{
  623. "file1.txt": "test1",
  624. "file2.txt": "test2",
  625. "dir/nested_file": "nested file",
  626. "dir/nested_dir/nest_nest_file": "2 times nested",
  627. "dirt": "dirty",
  628. })
  629. defer ctx.Close()
  630. if err != nil {
  631. t.Fatal(err)
  632. }
  633. id1, err := buildImageFromContext(name, ctx, true)
  634. if err != nil {
  635. t.Fatal(err)
  636. }
  637. // Now make sure we use a cache the 2nd time
  638. id2, err := buildImageFromContext(name, ctx, true)
  639. if err != nil {
  640. t.Fatal(err)
  641. }
  642. if id1 != id2 {
  643. t.Fatal("didn't use the cache")
  644. }
  645. logDone("build - copy wild card")
  646. }
  647. func TestBuildCopyWildcardNoFind(t *testing.T) {
  648. name := "testcopywildcardnofind"
  649. defer deleteImages(name)
  650. ctx, err := fakeContext(`FROM busybox
  651. COPY file*.txt /tmp/
  652. `, nil)
  653. defer ctx.Close()
  654. if err != nil {
  655. t.Fatal(err)
  656. }
  657. _, err = buildImageFromContext(name, ctx, true)
  658. if err == nil {
  659. t.Fatal("should have failed to find a file")
  660. }
  661. if !strings.Contains(err.Error(), "No source files were specified") {
  662. t.Fatalf("Wrong error %v, must be about no source files", err)
  663. }
  664. logDone("build - copy wild card no find")
  665. }
  666. func TestBuildCopyWildcardCache(t *testing.T) {
  667. name := "testcopywildcardcache"
  668. defer deleteImages(name)
  669. ctx, err := fakeContext(`FROM busybox
  670. COPY file1.txt /tmp/`,
  671. map[string]string{
  672. "file1.txt": "test1",
  673. })
  674. defer ctx.Close()
  675. if err != nil {
  676. t.Fatal(err)
  677. }
  678. id1, err := buildImageFromContext(name, ctx, true)
  679. if err != nil {
  680. t.Fatal(err)
  681. }
  682. // Now make sure we use a cache the 2nd time even with wild cards.
  683. // Use the same context so the file is the same and the checksum will match
  684. ctx.Add("Dockerfile", `FROM busybox
  685. COPY file*.txt /tmp/`)
  686. id2, err := buildImageFromContext(name, ctx, true)
  687. if err != nil {
  688. t.Fatal(err)
  689. }
  690. if id1 != id2 {
  691. t.Fatal("didn't use the cache")
  692. }
  693. logDone("build - copy wild card cache")
  694. }
  695. func TestBuildAddSingleFileToNonExistDir(t *testing.T) {
  696. name := "testaddsinglefiletononexistdir"
  697. defer deleteImages(name)
  698. ctx, err := fakeContext(`FROM busybox
  699. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  700. RUN echo 'dockerio:x:1001:' >> /etc/group
  701. RUN touch /exists
  702. RUN chown dockerio.dockerio /exists
  703. ADD test_file /test_dir/
  704. RUN [ $(ls -l / | grep test_dir | awk '{print $3":"$4}') = 'root:root' ]
  705. RUN [ $(ls -l /test_dir/test_file | awk '{print $3":"$4}') = 'root:root' ]
  706. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  707. map[string]string{
  708. "test_file": "test1",
  709. })
  710. if err != nil {
  711. t.Fatal(err)
  712. }
  713. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  714. t.Fatal(err)
  715. }
  716. }
  717. func TestBuildAddDirContentToRoot(t *testing.T) {
  718. name := "testadddircontenttoroot"
  719. defer deleteImages(name)
  720. ctx, err := fakeContext(`FROM busybox
  721. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  722. RUN echo 'dockerio:x:1001:' >> /etc/group
  723. RUN touch /exists
  724. RUN chown dockerio.dockerio exists
  725. ADD test_dir /
  726. RUN [ $(ls -l /test_file | awk '{print $3":"$4}') = 'root:root' ]
  727. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  728. map[string]string{
  729. "test_dir/test_file": "test1",
  730. })
  731. if err != nil {
  732. t.Fatal(err)
  733. }
  734. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  735. t.Fatal(err)
  736. }
  737. logDone("build - add directory contents to root")
  738. }
  739. func TestBuildAddDirContentToExistDir(t *testing.T) {
  740. name := "testadddircontenttoexistdir"
  741. defer deleteImages(name)
  742. ctx, err := fakeContext(`FROM busybox
  743. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  744. RUN echo 'dockerio:x:1001:' >> /etc/group
  745. RUN mkdir /exists
  746. RUN touch /exists/exists_file
  747. RUN chown -R dockerio.dockerio /exists
  748. ADD test_dir/ /exists/
  749. RUN [ $(ls -l / | grep exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]
  750. RUN [ $(ls -l /exists/exists_file | awk '{print $3":"$4}') = 'dockerio:dockerio' ]
  751. RUN [ $(ls -l /exists/test_file | awk '{print $3":"$4}') = 'root:root' ]`,
  752. map[string]string{
  753. "test_dir/test_file": "test1",
  754. })
  755. if err != nil {
  756. t.Fatal(err)
  757. }
  758. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  759. t.Fatal(err)
  760. }
  761. logDone("build - add directory contents to existing dir")
  762. }
  763. func TestBuildAddWholeDirToRoot(t *testing.T) {
  764. name := "testaddwholedirtoroot"
  765. defer deleteImages(name)
  766. ctx, err := fakeContext(`FROM busybox
  767. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  768. RUN echo 'dockerio:x:1001:' >> /etc/group
  769. RUN touch /exists
  770. RUN chown dockerio.dockerio exists
  771. ADD test_dir /test_dir
  772. RUN [ $(ls -l / | grep test_dir | awk '{print $3":"$4}') = 'root:root' ]
  773. RUN [ $(ls -l / | grep test_dir | awk '{print $1}') = 'drwxr-xr-x' ]
  774. RUN [ $(ls -l /test_dir/test_file | awk '{print $3":"$4}') = 'root:root' ]
  775. RUN [ $(ls -l /test_dir/test_file | awk '{print $1}') = '-rw-r--r--' ]
  776. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  777. map[string]string{
  778. "test_dir/test_file": "test1",
  779. })
  780. if err != nil {
  781. t.Fatal(err)
  782. }
  783. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  784. t.Fatal(err)
  785. }
  786. logDone("build - add whole directory to root")
  787. }
  788. // Testing #5941
  789. func TestBuildAddEtcToRoot(t *testing.T) {
  790. name := "testaddetctoroot"
  791. defer deleteImages(name)
  792. ctx, err := fakeContext(`FROM scratch
  793. ADD . /`,
  794. map[string]string{
  795. "etc/test_file": "test1",
  796. })
  797. if err != nil {
  798. t.Fatal(err)
  799. }
  800. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  801. t.Fatal(err)
  802. }
  803. logDone("build - add etc directory to root")
  804. }
  805. func TestBuildCopySingleFileToRoot(t *testing.T) {
  806. testDirName := "SingleFileToRoot"
  807. sourceDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy", testDirName)
  808. buildDirectory, err := ioutil.TempDir("", "test-build-add")
  809. defer os.RemoveAll(buildDirectory)
  810. err = copyWithCP(sourceDirectory, buildDirectory)
  811. if err != nil {
  812. t.Fatalf("failed to copy files to temporary directory: %s", err)
  813. }
  814. buildDirectory = filepath.Join(buildDirectory, testDirName)
  815. f, err := os.OpenFile(filepath.Join(buildDirectory, "test_file"), os.O_CREATE, 0644)
  816. if err != nil {
  817. t.Fatal(err)
  818. }
  819. f.Close()
  820. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", ".")
  821. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  822. if err != nil || exitCode != 0 {
  823. t.Fatal("failed to build the image")
  824. }
  825. deleteImages("testcopyimg")
  826. logDone("build - copy single file to root")
  827. }
  828. // Issue #3960: "ADD src ." hangs - adapted for COPY
  829. func TestBuildCopySingleFileToWorkdir(t *testing.T) {
  830. testDirName := "SingleFileToWorkdir"
  831. sourceDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy", testDirName)
  832. buildDirectory, err := ioutil.TempDir("", "test-build-add")
  833. defer os.RemoveAll(buildDirectory)
  834. err = copyWithCP(sourceDirectory, buildDirectory)
  835. if err != nil {
  836. t.Fatalf("failed to copy files to temporary directory: %s", err)
  837. }
  838. buildDirectory = filepath.Join(buildDirectory, testDirName)
  839. f, err := os.OpenFile(filepath.Join(buildDirectory, "test_file"), os.O_CREATE, 0644)
  840. if err != nil {
  841. t.Fatal(err)
  842. }
  843. f.Close()
  844. _, exitCode, err := dockerCmdInDirWithTimeout(5*time.Second, buildDirectory, "build", "-t", "testcopyimg", ".")
  845. if err != nil || exitCode != 0 {
  846. t.Fatalf("build failed: %s", err)
  847. }
  848. deleteImages("testcopyimg")
  849. logDone("build - copy single file to workdir")
  850. }
  851. func TestBuildCopySingleFileToExistDir(t *testing.T) {
  852. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
  853. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", "SingleFileToExistDir")
  854. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  855. if err != nil || exitCode != 0 {
  856. t.Fatal("failed to build the image")
  857. }
  858. deleteImages("testcopyimg")
  859. logDone("build - copy single file to existing dir")
  860. }
  861. func TestBuildCopySingleFileToNonExistDir(t *testing.T) {
  862. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
  863. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", "SingleFileToNonExistDir")
  864. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  865. if err != nil || exitCode != 0 {
  866. t.Fatal("failed to build the image")
  867. }
  868. deleteImages("testcopyimg")
  869. logDone("build - copy single file to non-existing dir")
  870. }
  871. func TestBuildCopyDirContentToRoot(t *testing.T) {
  872. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
  873. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", "DirContentToRoot")
  874. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  875. if err != nil || exitCode != 0 {
  876. t.Fatal("failed to build the image")
  877. }
  878. deleteImages("testcopyimg")
  879. logDone("build - copy directory contents to root")
  880. }
  881. func TestBuildCopyDirContentToExistDir(t *testing.T) {
  882. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
  883. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", "DirContentToExistDir")
  884. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  885. if err != nil || exitCode != 0 {
  886. t.Fatal("failed to build the image")
  887. }
  888. deleteImages("testcopyimg")
  889. logDone("build - copy directory contents to existing dir")
  890. }
  891. func TestBuildCopyWholeDirToRoot(t *testing.T) {
  892. testDirName := "WholeDirToRoot"
  893. sourceDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy", testDirName)
  894. buildDirectory, err := ioutil.TempDir("", "test-build-add")
  895. defer os.RemoveAll(buildDirectory)
  896. err = copyWithCP(sourceDirectory, buildDirectory)
  897. if err != nil {
  898. t.Fatalf("failed to copy files to temporary directory: %s", err)
  899. }
  900. buildDirectory = filepath.Join(buildDirectory, testDirName)
  901. testDir := filepath.Join(buildDirectory, "test_dir")
  902. if err := os.MkdirAll(testDir, 0755); err != nil {
  903. t.Fatal(err)
  904. }
  905. f, err := os.OpenFile(filepath.Join(testDir, "test_file"), os.O_CREATE, 0644)
  906. if err != nil {
  907. t.Fatal(err)
  908. }
  909. f.Close()
  910. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", ".")
  911. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  912. if err != nil || exitCode != 0 {
  913. t.Fatal("failed to build the image")
  914. }
  915. deleteImages("testcopyimg")
  916. logDone("build - copy whole directory to root")
  917. }
  918. func TestBuildCopyEtcToRoot(t *testing.T) {
  919. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
  920. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", "EtcToRoot")
  921. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  922. if err != nil || exitCode != 0 {
  923. t.Fatal("failed to build the image")
  924. }
  925. deleteImages("testcopyimg")
  926. logDone("build - copy etc directory to root")
  927. }
  928. func TestBuildCopyDisallowRemote(t *testing.T) {
  929. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
  930. buildCmd := exec.Command(dockerBinary, "build", "-t", "testcopyimg", "DisallowRemote")
  931. buildCmd.Dir = buildDirectory
  932. out, exitCode, err := runCommandWithOutput(buildCmd)
  933. if err == nil || exitCode == 0 {
  934. t.Fatalf("building the image should've failed; output: %s", out)
  935. }
  936. deleteImages("testcopyimg")
  937. logDone("build - copy - disallow copy from remote")
  938. }
  939. // Issue #5270 - ensure we throw a better error than "unexpected EOF"
  940. // when we can't access files in the context.
  941. func TestBuildWithInaccessibleFilesInContext(t *testing.T) {
  942. {
  943. name := "testbuildinaccessiblefiles"
  944. defer deleteImages(name)
  945. ctx, err := fakeContext("FROM scratch\nADD . /foo/", map[string]string{"fileWithoutReadAccess": "foo"})
  946. if err != nil {
  947. t.Fatal(err)
  948. }
  949. defer ctx.Close()
  950. // This is used to ensure we detect inaccessible files early during build in the cli client
  951. pathToFileWithoutReadAccess := filepath.Join(ctx.Dir, "fileWithoutReadAccess")
  952. err = os.Chown(pathToFileWithoutReadAccess, 0, 0)
  953. errorOut(err, t, fmt.Sprintf("failed to chown file to root: %s", err))
  954. err = os.Chmod(pathToFileWithoutReadAccess, 0700)
  955. errorOut(err, t, fmt.Sprintf("failed to chmod file to 700: %s", err))
  956. buildCmd := exec.Command("su", "unprivilegeduser", "-c", fmt.Sprintf("%s build -t %s .", dockerBinary, name))
  957. buildCmd.Dir = ctx.Dir
  958. out, exitCode, err := runCommandWithOutput(buildCmd)
  959. if err == nil || exitCode == 0 {
  960. t.Fatalf("build should have failed: %s %s", err, out)
  961. }
  962. // check if we've detected the failure before we started building
  963. if !strings.Contains(out, "no permission to read from ") {
  964. t.Fatalf("output should've contained the string: no permission to read from but contained: %s", out)
  965. }
  966. if !strings.Contains(out, "Error checking context is accessible") {
  967. t.Fatalf("output should've contained the string: Error checking context is accessible")
  968. }
  969. }
  970. {
  971. name := "testbuildinaccessibledirectory"
  972. defer deleteImages(name)
  973. ctx, err := fakeContext("FROM scratch\nADD . /foo/", map[string]string{"directoryWeCantStat/bar": "foo"})
  974. if err != nil {
  975. t.Fatal(err)
  976. }
  977. defer ctx.Close()
  978. // This is used to ensure we detect inaccessible directories early during build in the cli client
  979. pathToDirectoryWithoutReadAccess := filepath.Join(ctx.Dir, "directoryWeCantStat")
  980. pathToFileInDirectoryWithoutReadAccess := filepath.Join(pathToDirectoryWithoutReadAccess, "bar")
  981. err = os.Chown(pathToDirectoryWithoutReadAccess, 0, 0)
  982. errorOut(err, t, fmt.Sprintf("failed to chown directory to root: %s", err))
  983. err = os.Chmod(pathToDirectoryWithoutReadAccess, 0444)
  984. errorOut(err, t, fmt.Sprintf("failed to chmod directory to 755: %s", err))
  985. err = os.Chmod(pathToFileInDirectoryWithoutReadAccess, 0700)
  986. errorOut(err, t, fmt.Sprintf("failed to chmod file to 444: %s", err))
  987. buildCmd := exec.Command("su", "unprivilegeduser", "-c", fmt.Sprintf("%s build -t %s .", dockerBinary, name))
  988. buildCmd.Dir = ctx.Dir
  989. out, exitCode, err := runCommandWithOutput(buildCmd)
  990. if err == nil || exitCode == 0 {
  991. t.Fatalf("build should have failed: %s %s", err, out)
  992. }
  993. // check if we've detected the failure before we started building
  994. if !strings.Contains(out, "can't stat") {
  995. t.Fatalf("output should've contained the string: can't access %s", out)
  996. }
  997. if !strings.Contains(out, "Error checking context is accessible") {
  998. t.Fatalf("output should've contained the string: Error checking context is accessible")
  999. }
  1000. }
  1001. {
  1002. name := "testlinksok"
  1003. defer deleteImages(name)
  1004. ctx, err := fakeContext("FROM scratch\nADD . /foo/", nil)
  1005. if err != nil {
  1006. t.Fatal(err)
  1007. }
  1008. defer ctx.Close()
  1009. if err := os.Symlink(filepath.Join(ctx.Dir, "g"), "../../../../../../../../../../../../../../../../../../../azA"); err != nil {
  1010. t.Fatal(err)
  1011. }
  1012. // This is used to ensure we don't follow links when checking if everything in the context is accessible
  1013. // This test doesn't require that we run commands as an unprivileged user
  1014. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1015. t.Fatal(err)
  1016. }
  1017. }
  1018. {
  1019. name := "testbuildignoredinaccessible"
  1020. defer deleteImages(name)
  1021. ctx, err := fakeContext("FROM scratch\nADD . /foo/",
  1022. map[string]string{
  1023. "directoryWeCantStat/bar": "foo",
  1024. ".dockerignore": "directoryWeCantStat",
  1025. })
  1026. if err != nil {
  1027. t.Fatal(err)
  1028. }
  1029. defer ctx.Close()
  1030. // This is used to ensure we don't try to add inaccessible files when they are ignored by a .dockerignore pattern
  1031. pathToDirectoryWithoutReadAccess := filepath.Join(ctx.Dir, "directoryWeCantStat")
  1032. pathToFileInDirectoryWithoutReadAccess := filepath.Join(pathToDirectoryWithoutReadAccess, "bar")
  1033. err = os.Chown(pathToDirectoryWithoutReadAccess, 0, 0)
  1034. errorOut(err, t, fmt.Sprintf("failed to chown directory to root: %s", err))
  1035. err = os.Chmod(pathToDirectoryWithoutReadAccess, 0444)
  1036. errorOut(err, t, fmt.Sprintf("failed to chmod directory to 755: %s", err))
  1037. err = os.Chmod(pathToFileInDirectoryWithoutReadAccess, 0700)
  1038. errorOut(err, t, fmt.Sprintf("failed to chmod file to 444: %s", err))
  1039. buildCmd := exec.Command("su", "unprivilegeduser", "-c", fmt.Sprintf("%s build -t %s .", dockerBinary, name))
  1040. buildCmd.Dir = ctx.Dir
  1041. out, exitCode, err := runCommandWithOutput(buildCmd)
  1042. if err != nil || exitCode != 0 {
  1043. t.Fatalf("build should have worked: %s %s", err, out)
  1044. }
  1045. }
  1046. logDone("build - ADD from context with inaccessible files must fail")
  1047. logDone("build - ADD from context with accessible links must work")
  1048. logDone("build - ADD from context with ignored inaccessible files must work")
  1049. }
  1050. func TestBuildForceRm(t *testing.T) {
  1051. containerCountBefore, err := getContainerCount()
  1052. if err != nil {
  1053. t.Fatalf("failed to get the container count: %s", err)
  1054. }
  1055. name := "testbuildforcerm"
  1056. defer deleteImages(name)
  1057. ctx, err := fakeContext("FROM scratch\nRUN true\nRUN thiswillfail", nil)
  1058. if err != nil {
  1059. t.Fatal(err)
  1060. }
  1061. defer ctx.Close()
  1062. buildCmd := exec.Command(dockerBinary, "build", "-t", name, "--force-rm", ".")
  1063. buildCmd.Dir = ctx.Dir
  1064. _, exitCode, err := runCommandWithOutput(buildCmd)
  1065. if err == nil || exitCode == 0 {
  1066. t.Fatal("failed to build the image")
  1067. }
  1068. containerCountAfter, err := getContainerCount()
  1069. if err != nil {
  1070. t.Fatalf("failed to get the container count: %s", err)
  1071. }
  1072. if containerCountBefore != containerCountAfter {
  1073. t.Fatalf("--force-rm shouldn't have left containers behind")
  1074. }
  1075. logDone("build - ensure --force-rm doesn't leave containers behind")
  1076. }
  1077. func TestBuildRm(t *testing.T) {
  1078. name := "testbuildrm"
  1079. defer deleteImages(name)
  1080. ctx, err := fakeContext("FROM scratch\nADD foo /\nADD foo /", map[string]string{"foo": "bar"})
  1081. if err != nil {
  1082. t.Fatal(err)
  1083. }
  1084. defer ctx.Close()
  1085. {
  1086. containerCountBefore, err := getContainerCount()
  1087. if err != nil {
  1088. t.Fatalf("failed to get the container count: %s", err)
  1089. }
  1090. out, exitCode, err := dockerCmdInDir(t, ctx.Dir, "build", "--rm", "-t", name, ".")
  1091. if err != nil || exitCode != 0 {
  1092. t.Fatal("failed to build the image", out)
  1093. }
  1094. containerCountAfter, err := getContainerCount()
  1095. if err != nil {
  1096. t.Fatalf("failed to get the container count: %s", err)
  1097. }
  1098. if containerCountBefore != containerCountAfter {
  1099. t.Fatalf("-rm shouldn't have left containers behind")
  1100. }
  1101. deleteImages(name)
  1102. }
  1103. {
  1104. containerCountBefore, err := getContainerCount()
  1105. if err != nil {
  1106. t.Fatalf("failed to get the container count: %s", err)
  1107. }
  1108. out, exitCode, err := dockerCmdInDir(t, ctx.Dir, "build", "-t", name, ".")
  1109. if err != nil || exitCode != 0 {
  1110. t.Fatal("failed to build the image", out)
  1111. }
  1112. containerCountAfter, err := getContainerCount()
  1113. if err != nil {
  1114. t.Fatalf("failed to get the container count: %s", err)
  1115. }
  1116. if containerCountBefore != containerCountAfter {
  1117. t.Fatalf("--rm shouldn't have left containers behind")
  1118. }
  1119. deleteImages(name)
  1120. }
  1121. {
  1122. containerCountBefore, err := getContainerCount()
  1123. if err != nil {
  1124. t.Fatalf("failed to get the container count: %s", err)
  1125. }
  1126. out, exitCode, err := dockerCmdInDir(t, ctx.Dir, "build", "--rm=false", "-t", name, ".")
  1127. if err != nil || exitCode != 0 {
  1128. t.Fatal("failed to build the image", out)
  1129. }
  1130. containerCountAfter, err := getContainerCount()
  1131. if err != nil {
  1132. t.Fatalf("failed to get the container count: %s", err)
  1133. }
  1134. if containerCountBefore == containerCountAfter {
  1135. t.Fatalf("--rm=false should have left containers behind")
  1136. }
  1137. deleteAllContainers()
  1138. deleteImages(name)
  1139. }
  1140. logDone("build - ensure --rm doesn't leave containers behind and that --rm=true is the default")
  1141. logDone("build - ensure --rm=false overrides the default")
  1142. }
  1143. func TestBuildWithVolumes(t *testing.T) {
  1144. var (
  1145. result map[string]map[string]struct{}
  1146. name = "testbuildvolumes"
  1147. emptyMap = make(map[string]struct{})
  1148. expected = map[string]map[string]struct{}{
  1149. "/test1": emptyMap,
  1150. "/test2": emptyMap,
  1151. "/test3": emptyMap,
  1152. "/test4": emptyMap,
  1153. "/test5": emptyMap,
  1154. "/test6": emptyMap,
  1155. "[/test7": emptyMap,
  1156. "/test8]": emptyMap,
  1157. }
  1158. )
  1159. defer deleteImages(name)
  1160. _, err := buildImage(name,
  1161. `FROM scratch
  1162. VOLUME /test1
  1163. VOLUME /test2
  1164. VOLUME /test3 /test4
  1165. VOLUME ["/test5", "/test6"]
  1166. VOLUME [/test7 /test8]
  1167. `,
  1168. true)
  1169. if err != nil {
  1170. t.Fatal(err)
  1171. }
  1172. res, err := inspectFieldJSON(name, "Config.Volumes")
  1173. if err != nil {
  1174. t.Fatal(err)
  1175. }
  1176. err = unmarshalJSON([]byte(res), &result)
  1177. if err != nil {
  1178. t.Fatal(err)
  1179. }
  1180. equal := deepEqual(&expected, &result)
  1181. if !equal {
  1182. t.Fatalf("Volumes %s, expected %s", result, expected)
  1183. }
  1184. logDone("build - with volumes")
  1185. }
  1186. func TestBuildMaintainer(t *testing.T) {
  1187. name := "testbuildmaintainer"
  1188. expected := "dockerio"
  1189. defer deleteImages(name)
  1190. _, err := buildImage(name,
  1191. `FROM scratch
  1192. MAINTAINER dockerio`,
  1193. true)
  1194. if err != nil {
  1195. t.Fatal(err)
  1196. }
  1197. res, err := inspectField(name, "Author")
  1198. if err != nil {
  1199. t.Fatal(err)
  1200. }
  1201. if res != expected {
  1202. t.Fatalf("Maintainer %s, expected %s", res, expected)
  1203. }
  1204. logDone("build - maintainer")
  1205. }
  1206. func TestBuildUser(t *testing.T) {
  1207. name := "testbuilduser"
  1208. expected := "dockerio"
  1209. defer deleteImages(name)
  1210. _, err := buildImage(name,
  1211. `FROM busybox
  1212. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  1213. USER dockerio
  1214. RUN [ $(whoami) = 'dockerio' ]`,
  1215. true)
  1216. if err != nil {
  1217. t.Fatal(err)
  1218. }
  1219. res, err := inspectField(name, "Config.User")
  1220. if err != nil {
  1221. t.Fatal(err)
  1222. }
  1223. if res != expected {
  1224. t.Fatalf("User %s, expected %s", res, expected)
  1225. }
  1226. logDone("build - user")
  1227. }
  1228. func TestBuildRelativeWorkdir(t *testing.T) {
  1229. name := "testbuildrelativeworkdir"
  1230. expected := "/test2/test3"
  1231. defer deleteImages(name)
  1232. _, err := buildImage(name,
  1233. `FROM busybox
  1234. RUN [ "$PWD" = '/' ]
  1235. WORKDIR test1
  1236. RUN [ "$PWD" = '/test1' ]
  1237. WORKDIR /test2
  1238. RUN [ "$PWD" = '/test2' ]
  1239. WORKDIR test3
  1240. RUN [ "$PWD" = '/test2/test3' ]`,
  1241. true)
  1242. if err != nil {
  1243. t.Fatal(err)
  1244. }
  1245. res, err := inspectField(name, "Config.WorkingDir")
  1246. if err != nil {
  1247. t.Fatal(err)
  1248. }
  1249. if res != expected {
  1250. t.Fatalf("Workdir %s, expected %s", res, expected)
  1251. }
  1252. logDone("build - relative workdir")
  1253. }
  1254. func TestBuildWorkdirWithEnvVariables(t *testing.T) {
  1255. name := "testbuildworkdirwithenvvariables"
  1256. expected := "/test1/test2/$MISSING_VAR"
  1257. defer deleteImages(name)
  1258. _, err := buildImage(name,
  1259. `FROM busybox
  1260. ENV DIRPATH /test1
  1261. ENV SUBDIRNAME test2
  1262. WORKDIR $DIRPATH
  1263. WORKDIR $SUBDIRNAME/$MISSING_VAR`,
  1264. true)
  1265. if err != nil {
  1266. t.Fatal(err)
  1267. }
  1268. res, err := inspectField(name, "Config.WorkingDir")
  1269. if err != nil {
  1270. t.Fatal(err)
  1271. }
  1272. if res != expected {
  1273. t.Fatalf("Workdir %s, expected %s", res, expected)
  1274. }
  1275. logDone("build - workdir with env variables")
  1276. }
  1277. func TestBuildEnv(t *testing.T) {
  1278. name := "testbuildenv"
  1279. expected := "[PATH=/test:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PORT=2375]"
  1280. defer deleteImages(name)
  1281. _, err := buildImage(name,
  1282. `FROM busybox
  1283. ENV PATH /test:$PATH
  1284. ENV PORT 2375
  1285. RUN [ $(env | grep PORT) = 'PORT=2375' ]`,
  1286. true)
  1287. if err != nil {
  1288. t.Fatal(err)
  1289. }
  1290. res, err := inspectField(name, "Config.Env")
  1291. if err != nil {
  1292. t.Fatal(err)
  1293. }
  1294. if res != expected {
  1295. t.Fatalf("Env %s, expected %s", res, expected)
  1296. }
  1297. logDone("build - env")
  1298. }
  1299. func TestBuildContextCleanup(t *testing.T) {
  1300. name := "testbuildcontextcleanup"
  1301. defer deleteImages(name)
  1302. entries, err := ioutil.ReadDir("/var/lib/docker/tmp")
  1303. if err != nil {
  1304. t.Fatalf("failed to list contents of tmp dir: %s", err)
  1305. }
  1306. _, err = buildImage(name,
  1307. `FROM scratch
  1308. ENTRYPOINT ["/bin/echo"]`,
  1309. true)
  1310. if err != nil {
  1311. t.Fatal(err)
  1312. }
  1313. entriesFinal, err := ioutil.ReadDir("/var/lib/docker/tmp")
  1314. if err != nil {
  1315. t.Fatalf("failed to list contents of tmp dir: %s", err)
  1316. }
  1317. if err = compareDirectoryEntries(entries, entriesFinal); err != nil {
  1318. t.Fatalf("context should have been deleted, but wasn't")
  1319. }
  1320. logDone("build - verify context cleanup works properly")
  1321. }
  1322. func TestBuildContextCleanupFailedBuild(t *testing.T) {
  1323. name := "testbuildcontextcleanup"
  1324. defer deleteImages(name)
  1325. entries, err := ioutil.ReadDir("/var/lib/docker/tmp")
  1326. if err != nil {
  1327. t.Fatalf("failed to list contents of tmp dir: %s", err)
  1328. }
  1329. _, err = buildImage(name,
  1330. `FROM scratch
  1331. RUN /non/existing/command`,
  1332. true)
  1333. if err == nil {
  1334. t.Fatalf("expected build to fail, but it didn't")
  1335. }
  1336. entriesFinal, err := ioutil.ReadDir("/var/lib/docker/tmp")
  1337. if err != nil {
  1338. t.Fatalf("failed to list contents of tmp dir: %s", err)
  1339. }
  1340. if err = compareDirectoryEntries(entries, entriesFinal); err != nil {
  1341. t.Fatalf("context should have been deleted, but wasn't")
  1342. }
  1343. logDone("build - verify context cleanup works properly after a failed build")
  1344. }
  1345. func TestBuildCmd(t *testing.T) {
  1346. name := "testbuildcmd"
  1347. expected := "[/bin/echo Hello World]"
  1348. defer deleteImages(name)
  1349. _, err := buildImage(name,
  1350. `FROM scratch
  1351. CMD ["/bin/echo", "Hello World"]`,
  1352. true)
  1353. if err != nil {
  1354. t.Fatal(err)
  1355. }
  1356. res, err := inspectField(name, "Config.Cmd")
  1357. if err != nil {
  1358. t.Fatal(err)
  1359. }
  1360. if res != expected {
  1361. t.Fatalf("Cmd %s, expected %s", res, expected)
  1362. }
  1363. logDone("build - cmd")
  1364. }
  1365. func TestBuildExpose(t *testing.T) {
  1366. name := "testbuildexpose"
  1367. expected := "map[2375/tcp:map[]]"
  1368. defer deleteImages(name)
  1369. _, err := buildImage(name,
  1370. `FROM scratch
  1371. EXPOSE 2375`,
  1372. true)
  1373. if err != nil {
  1374. t.Fatal(err)
  1375. }
  1376. res, err := inspectField(name, "Config.ExposedPorts")
  1377. if err != nil {
  1378. t.Fatal(err)
  1379. }
  1380. if res != expected {
  1381. t.Fatalf("Exposed ports %s, expected %s", res, expected)
  1382. }
  1383. logDone("build - expose")
  1384. }
  1385. func TestBuildEmptyEntrypointInheritance(t *testing.T) {
  1386. name := "testbuildentrypointinheritance"
  1387. name2 := "testbuildentrypointinheritance2"
  1388. defer deleteImages(name, name2)
  1389. _, err := buildImage(name,
  1390. `FROM busybox
  1391. ENTRYPOINT ["/bin/echo"]`,
  1392. true)
  1393. if err != nil {
  1394. t.Fatal(err)
  1395. }
  1396. res, err := inspectField(name, "Config.Entrypoint")
  1397. if err != nil {
  1398. t.Fatal(err)
  1399. }
  1400. expected := "[/bin/echo]"
  1401. if res != expected {
  1402. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  1403. }
  1404. _, err = buildImage(name2,
  1405. fmt.Sprintf(`FROM %s
  1406. ENTRYPOINT []`, name),
  1407. true)
  1408. if err != nil {
  1409. t.Fatal(err)
  1410. }
  1411. res, err = inspectField(name2, "Config.Entrypoint")
  1412. if err != nil {
  1413. t.Fatal(err)
  1414. }
  1415. expected = "[]"
  1416. if res != expected {
  1417. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  1418. }
  1419. logDone("build - empty entrypoint inheritance")
  1420. }
  1421. func TestBuildEmptyEntrypoint(t *testing.T) {
  1422. name := "testbuildentrypoint"
  1423. defer deleteImages(name)
  1424. expected := "[]"
  1425. _, err := buildImage(name,
  1426. `FROM busybox
  1427. ENTRYPOINT []`,
  1428. true)
  1429. if err != nil {
  1430. t.Fatal(err)
  1431. }
  1432. res, err := inspectField(name, "Config.Entrypoint")
  1433. if err != nil {
  1434. t.Fatal(err)
  1435. }
  1436. if res != expected {
  1437. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  1438. }
  1439. logDone("build - empty entrypoint")
  1440. }
  1441. func TestBuildEntrypoint(t *testing.T) {
  1442. name := "testbuildentrypoint"
  1443. expected := "[/bin/echo]"
  1444. defer deleteImages(name)
  1445. _, err := buildImage(name,
  1446. `FROM scratch
  1447. ENTRYPOINT ["/bin/echo"]`,
  1448. true)
  1449. if err != nil {
  1450. t.Fatal(err)
  1451. }
  1452. res, err := inspectField(name, "Config.Entrypoint")
  1453. if err != nil {
  1454. t.Fatal(err)
  1455. }
  1456. if res != expected {
  1457. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  1458. }
  1459. logDone("build - entrypoint")
  1460. }
  1461. // #6445 ensure ONBUILD triggers aren't committed to grandchildren
  1462. func TestBuildOnBuildLimitedInheritence(t *testing.T) {
  1463. var (
  1464. out2, out3 string
  1465. )
  1466. {
  1467. name1 := "testonbuildtrigger1"
  1468. dockerfile1 := `
  1469. FROM busybox
  1470. RUN echo "GRANDPARENT"
  1471. ONBUILD RUN echo "ONBUILD PARENT"
  1472. `
  1473. ctx, err := fakeContext(dockerfile1, nil)
  1474. if err != nil {
  1475. t.Fatal(err)
  1476. }
  1477. out1, _, err := dockerCmdInDir(t, ctx.Dir, "build", "-t", name1, ".")
  1478. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out1, err))
  1479. defer deleteImages(name1)
  1480. }
  1481. {
  1482. name2 := "testonbuildtrigger2"
  1483. dockerfile2 := `
  1484. FROM testonbuildtrigger1
  1485. `
  1486. ctx, err := fakeContext(dockerfile2, nil)
  1487. if err != nil {
  1488. t.Fatal(err)
  1489. }
  1490. out2, _, err = dockerCmdInDir(t, ctx.Dir, "build", "-t", name2, ".")
  1491. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out2, err))
  1492. defer deleteImages(name2)
  1493. }
  1494. {
  1495. name3 := "testonbuildtrigger3"
  1496. dockerfile3 := `
  1497. FROM testonbuildtrigger2
  1498. `
  1499. ctx, err := fakeContext(dockerfile3, nil)
  1500. if err != nil {
  1501. t.Fatal(err)
  1502. }
  1503. out3, _, err = dockerCmdInDir(t, ctx.Dir, "build", "-t", name3, ".")
  1504. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out3, err))
  1505. defer deleteImages(name3)
  1506. }
  1507. // ONBUILD should be run in second build.
  1508. if !strings.Contains(out2, "ONBUILD PARENT") {
  1509. t.Fatalf("ONBUILD instruction did not run in child of ONBUILD parent")
  1510. }
  1511. // ONBUILD should *not* be run in third build.
  1512. if strings.Contains(out3, "ONBUILD PARENT") {
  1513. t.Fatalf("ONBUILD instruction ran in grandchild of ONBUILD parent")
  1514. }
  1515. logDone("build - onbuild")
  1516. }
  1517. func TestBuildWithCache(t *testing.T) {
  1518. name := "testbuildwithcache"
  1519. defer deleteImages(name)
  1520. id1, err := buildImage(name,
  1521. `FROM scratch
  1522. MAINTAINER dockerio
  1523. EXPOSE 5432
  1524. ENTRYPOINT ["/bin/echo"]`,
  1525. true)
  1526. if err != nil {
  1527. t.Fatal(err)
  1528. }
  1529. id2, err := buildImage(name,
  1530. `FROM scratch
  1531. MAINTAINER dockerio
  1532. EXPOSE 5432
  1533. ENTRYPOINT ["/bin/echo"]`,
  1534. true)
  1535. if err != nil {
  1536. t.Fatal(err)
  1537. }
  1538. if id1 != id2 {
  1539. t.Fatal("The cache should have been used but hasn't.")
  1540. }
  1541. logDone("build - with cache")
  1542. }
  1543. func TestBuildWithoutCache(t *testing.T) {
  1544. name := "testbuildwithoutcache"
  1545. defer deleteImages(name)
  1546. id1, err := buildImage(name,
  1547. `FROM scratch
  1548. MAINTAINER dockerio
  1549. EXPOSE 5432
  1550. ENTRYPOINT ["/bin/echo"]`,
  1551. true)
  1552. if err != nil {
  1553. t.Fatal(err)
  1554. }
  1555. id2, err := buildImage(name,
  1556. `FROM scratch
  1557. MAINTAINER dockerio
  1558. EXPOSE 5432
  1559. ENTRYPOINT ["/bin/echo"]`,
  1560. false)
  1561. if err != nil {
  1562. t.Fatal(err)
  1563. }
  1564. if id1 == id2 {
  1565. t.Fatal("The cache should have been invalided but hasn't.")
  1566. }
  1567. logDone("build - without cache")
  1568. }
  1569. func TestBuildADDLocalFileWithCache(t *testing.T) {
  1570. name := "testbuildaddlocalfilewithcache"
  1571. defer deleteImages(name)
  1572. dockerfile := `
  1573. FROM busybox
  1574. MAINTAINER dockerio
  1575. ADD foo /usr/lib/bla/bar
  1576. RUN [ "$(cat /usr/lib/bla/bar)" = "hello" ]`
  1577. ctx, err := fakeContext(dockerfile, map[string]string{
  1578. "foo": "hello",
  1579. })
  1580. defer ctx.Close()
  1581. if err != nil {
  1582. t.Fatal(err)
  1583. }
  1584. id1, err := buildImageFromContext(name, ctx, true)
  1585. if err != nil {
  1586. t.Fatal(err)
  1587. }
  1588. id2, err := buildImageFromContext(name, ctx, true)
  1589. if err != nil {
  1590. t.Fatal(err)
  1591. }
  1592. if id1 != id2 {
  1593. t.Fatal("The cache should have been used but hasn't.")
  1594. }
  1595. logDone("build - add local file with cache")
  1596. }
  1597. func TestBuildADDMultipleLocalFileWithCache(t *testing.T) {
  1598. name := "testbuildaddmultiplelocalfilewithcache"
  1599. defer deleteImages(name)
  1600. dockerfile := `
  1601. FROM busybox
  1602. MAINTAINER dockerio
  1603. ADD foo Dockerfile /usr/lib/bla/
  1604. RUN [ "$(cat /usr/lib/bla/foo)" = "hello" ]`
  1605. ctx, err := fakeContext(dockerfile, map[string]string{
  1606. "foo": "hello",
  1607. })
  1608. defer ctx.Close()
  1609. if err != nil {
  1610. t.Fatal(err)
  1611. }
  1612. id1, err := buildImageFromContext(name, ctx, true)
  1613. if err != nil {
  1614. t.Fatal(err)
  1615. }
  1616. id2, err := buildImageFromContext(name, ctx, true)
  1617. if err != nil {
  1618. t.Fatal(err)
  1619. }
  1620. if id1 != id2 {
  1621. t.Fatal("The cache should have been used but hasn't.")
  1622. }
  1623. logDone("build - add multiple local files with cache")
  1624. }
  1625. func TestBuildADDLocalFileWithoutCache(t *testing.T) {
  1626. name := "testbuildaddlocalfilewithoutcache"
  1627. defer deleteImages(name)
  1628. dockerfile := `
  1629. FROM busybox
  1630. MAINTAINER dockerio
  1631. ADD foo /usr/lib/bla/bar
  1632. RUN [ "$(cat /usr/lib/bla/bar)" = "hello" ]`
  1633. ctx, err := fakeContext(dockerfile, map[string]string{
  1634. "foo": "hello",
  1635. })
  1636. defer ctx.Close()
  1637. if err != nil {
  1638. t.Fatal(err)
  1639. }
  1640. id1, err := buildImageFromContext(name, ctx, true)
  1641. if err != nil {
  1642. t.Fatal(err)
  1643. }
  1644. id2, err := buildImageFromContext(name, ctx, false)
  1645. if err != nil {
  1646. t.Fatal(err)
  1647. }
  1648. if id1 == id2 {
  1649. t.Fatal("The cache should have been invalided but hasn't.")
  1650. }
  1651. logDone("build - add local file without cache")
  1652. }
  1653. func TestBuildCopyDirButNotFile(t *testing.T) {
  1654. name := "testbuildcopydirbutnotfile"
  1655. defer deleteImages(name)
  1656. dockerfile := `
  1657. FROM scratch
  1658. COPY dir /tmp/`
  1659. ctx, err := fakeContext(dockerfile, map[string]string{
  1660. "dir/foo": "hello",
  1661. })
  1662. defer ctx.Close()
  1663. if err != nil {
  1664. t.Fatal(err)
  1665. }
  1666. id1, err := buildImageFromContext(name, ctx, true)
  1667. if err != nil {
  1668. t.Fatal(err)
  1669. }
  1670. // Check that adding file with similar name doesn't mess with cache
  1671. if err := ctx.Add("dir_file", "hello2"); err != nil {
  1672. t.Fatal(err)
  1673. }
  1674. id2, err := buildImageFromContext(name, ctx, true)
  1675. if err != nil {
  1676. t.Fatal(err)
  1677. }
  1678. if id1 != id2 {
  1679. t.Fatal("The cache should have been used but wasn't")
  1680. }
  1681. logDone("build - add current directory but not file")
  1682. }
  1683. func TestBuildADDCurrentDirWithCache(t *testing.T) {
  1684. name := "testbuildaddcurrentdirwithcache"
  1685. defer deleteImages(name)
  1686. dockerfile := `
  1687. FROM scratch
  1688. MAINTAINER dockerio
  1689. ADD . /usr/lib/bla`
  1690. ctx, err := fakeContext(dockerfile, map[string]string{
  1691. "foo": "hello",
  1692. })
  1693. defer ctx.Close()
  1694. if err != nil {
  1695. t.Fatal(err)
  1696. }
  1697. id1, err := buildImageFromContext(name, ctx, true)
  1698. if err != nil {
  1699. t.Fatal(err)
  1700. }
  1701. // Check that adding file invalidate cache of "ADD ."
  1702. if err := ctx.Add("bar", "hello2"); err != nil {
  1703. t.Fatal(err)
  1704. }
  1705. id2, err := buildImageFromContext(name, ctx, true)
  1706. if err != nil {
  1707. t.Fatal(err)
  1708. }
  1709. if id1 == id2 {
  1710. t.Fatal("The cache should have been invalided but hasn't.")
  1711. }
  1712. // Check that changing file invalidate cache of "ADD ."
  1713. if err := ctx.Add("foo", "hello1"); err != nil {
  1714. t.Fatal(err)
  1715. }
  1716. id3, err := buildImageFromContext(name, ctx, true)
  1717. if err != nil {
  1718. t.Fatal(err)
  1719. }
  1720. if id2 == id3 {
  1721. t.Fatal("The cache should have been invalided but hasn't.")
  1722. }
  1723. // Check that changing file to same content invalidate cache of "ADD ."
  1724. time.Sleep(1 * time.Second) // wait second because of mtime precision
  1725. if err := ctx.Add("foo", "hello1"); err != nil {
  1726. t.Fatal(err)
  1727. }
  1728. id4, err := buildImageFromContext(name, ctx, true)
  1729. if err != nil {
  1730. t.Fatal(err)
  1731. }
  1732. if id3 == id4 {
  1733. t.Fatal("The cache should have been invalided but hasn't.")
  1734. }
  1735. id5, err := buildImageFromContext(name, ctx, true)
  1736. if err != nil {
  1737. t.Fatal(err)
  1738. }
  1739. if id4 != id5 {
  1740. t.Fatal("The cache should have been used but hasn't.")
  1741. }
  1742. logDone("build - add current directory with cache")
  1743. }
  1744. func TestBuildADDCurrentDirWithoutCache(t *testing.T) {
  1745. name := "testbuildaddcurrentdirwithoutcache"
  1746. defer deleteImages(name)
  1747. dockerfile := `
  1748. FROM scratch
  1749. MAINTAINER dockerio
  1750. ADD . /usr/lib/bla`
  1751. ctx, err := fakeContext(dockerfile, map[string]string{
  1752. "foo": "hello",
  1753. })
  1754. defer ctx.Close()
  1755. if err != nil {
  1756. t.Fatal(err)
  1757. }
  1758. id1, err := buildImageFromContext(name, ctx, true)
  1759. if err != nil {
  1760. t.Fatal(err)
  1761. }
  1762. id2, err := buildImageFromContext(name, ctx, false)
  1763. if err != nil {
  1764. t.Fatal(err)
  1765. }
  1766. if id1 == id2 {
  1767. t.Fatal("The cache should have been invalided but hasn't.")
  1768. }
  1769. logDone("build - add current directory without cache")
  1770. }
  1771. func TestBuildADDRemoteFileWithCache(t *testing.T) {
  1772. name := "testbuildaddremotefilewithcache"
  1773. defer deleteImages(name)
  1774. server, err := fakeStorage(map[string]string{
  1775. "baz": "hello",
  1776. })
  1777. if err != nil {
  1778. t.Fatal(err)
  1779. }
  1780. defer server.Close()
  1781. id1, err := buildImage(name,
  1782. fmt.Sprintf(`FROM scratch
  1783. MAINTAINER dockerio
  1784. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  1785. true)
  1786. if err != nil {
  1787. t.Fatal(err)
  1788. }
  1789. id2, err := buildImage(name,
  1790. fmt.Sprintf(`FROM scratch
  1791. MAINTAINER dockerio
  1792. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  1793. true)
  1794. if err != nil {
  1795. t.Fatal(err)
  1796. }
  1797. if id1 != id2 {
  1798. t.Fatal("The cache should have been used but hasn't.")
  1799. }
  1800. logDone("build - add remote file with cache")
  1801. }
  1802. func TestBuildADDRemoteFileWithoutCache(t *testing.T) {
  1803. name := "testbuildaddremotefilewithoutcache"
  1804. defer deleteImages(name)
  1805. server, err := fakeStorage(map[string]string{
  1806. "baz": "hello",
  1807. })
  1808. if err != nil {
  1809. t.Fatal(err)
  1810. }
  1811. defer server.Close()
  1812. id1, err := buildImage(name,
  1813. fmt.Sprintf(`FROM scratch
  1814. MAINTAINER dockerio
  1815. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  1816. true)
  1817. if err != nil {
  1818. t.Fatal(err)
  1819. }
  1820. id2, err := buildImage(name,
  1821. fmt.Sprintf(`FROM scratch
  1822. MAINTAINER dockerio
  1823. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  1824. false)
  1825. if err != nil {
  1826. t.Fatal(err)
  1827. }
  1828. if id1 == id2 {
  1829. t.Fatal("The cache should have been invalided but hasn't.")
  1830. }
  1831. logDone("build - add remote file without cache")
  1832. }
  1833. func TestBuildADDLocalAndRemoteFilesWithCache(t *testing.T) {
  1834. name := "testbuildaddlocalandremotefilewithcache"
  1835. defer deleteImages(name)
  1836. server, err := fakeStorage(map[string]string{
  1837. "baz": "hello",
  1838. })
  1839. if err != nil {
  1840. t.Fatal(err)
  1841. }
  1842. defer server.Close()
  1843. ctx, err := fakeContext(fmt.Sprintf(`FROM scratch
  1844. MAINTAINER dockerio
  1845. ADD foo /usr/lib/bla/bar
  1846. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  1847. map[string]string{
  1848. "foo": "hello world",
  1849. })
  1850. if err != nil {
  1851. t.Fatal(err)
  1852. }
  1853. defer ctx.Close()
  1854. id1, err := buildImageFromContext(name, ctx, true)
  1855. if err != nil {
  1856. t.Fatal(err)
  1857. }
  1858. id2, err := buildImageFromContext(name, ctx, true)
  1859. if err != nil {
  1860. t.Fatal(err)
  1861. }
  1862. if id1 != id2 {
  1863. t.Fatal("The cache should have been used but hasn't.")
  1864. }
  1865. logDone("build - add local and remote file with cache")
  1866. }
  1867. func testContextTar(t *testing.T, compression archive.Compression) {
  1868. ctx, err := fakeContext(
  1869. `FROM busybox
  1870. ADD foo /foo
  1871. CMD ["cat", "/foo"]`,
  1872. map[string]string{
  1873. "foo": "bar",
  1874. },
  1875. )
  1876. defer ctx.Close()
  1877. if err != nil {
  1878. t.Fatal(err)
  1879. }
  1880. context, err := archive.Tar(ctx.Dir, compression)
  1881. if err != nil {
  1882. t.Fatalf("failed to build context tar: %v", err)
  1883. }
  1884. name := "contexttar"
  1885. buildCmd := exec.Command(dockerBinary, "build", "-t", name, "-")
  1886. defer deleteImages(name)
  1887. buildCmd.Stdin = context
  1888. out, exitCode, err := runCommandWithOutput(buildCmd)
  1889. if err != nil || exitCode != 0 {
  1890. t.Fatalf("build failed to complete: %v %v", out, err)
  1891. }
  1892. logDone(fmt.Sprintf("build - build an image with a context tar, compression: %v", compression))
  1893. }
  1894. func TestBuildContextTarGzip(t *testing.T) {
  1895. testContextTar(t, archive.Gzip)
  1896. }
  1897. func TestBuildContextTarNoCompression(t *testing.T) {
  1898. testContextTar(t, archive.Uncompressed)
  1899. }
  1900. func TestBuildNoContext(t *testing.T) {
  1901. buildCmd := exec.Command(dockerBinary, "build", "-t", "nocontext", "-")
  1902. buildCmd.Stdin = strings.NewReader("FROM busybox\nCMD echo ok\n")
  1903. out, exitCode, err := runCommandWithOutput(buildCmd)
  1904. if err != nil || exitCode != 0 {
  1905. t.Fatalf("build failed to complete: %v %v", out, err)
  1906. }
  1907. out, exitCode, err = cmd(t, "run", "nocontext")
  1908. if out != "ok\n" {
  1909. t.Fatalf("run produced invalid output: %q, expected %q", out, "ok")
  1910. }
  1911. deleteImages("nocontext")
  1912. logDone("build - build an image with no context")
  1913. }
  1914. // TODO: TestCaching
  1915. func TestBuildADDLocalAndRemoteFilesWithoutCache(t *testing.T) {
  1916. name := "testbuildaddlocalandremotefilewithoutcache"
  1917. defer deleteImages(name)
  1918. server, err := fakeStorage(map[string]string{
  1919. "baz": "hello",
  1920. })
  1921. if err != nil {
  1922. t.Fatal(err)
  1923. }
  1924. defer server.Close()
  1925. ctx, err := fakeContext(fmt.Sprintf(`FROM scratch
  1926. MAINTAINER dockerio
  1927. ADD foo /usr/lib/bla/bar
  1928. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  1929. map[string]string{
  1930. "foo": "hello world",
  1931. })
  1932. if err != nil {
  1933. t.Fatal(err)
  1934. }
  1935. defer ctx.Close()
  1936. id1, err := buildImageFromContext(name, ctx, true)
  1937. if err != nil {
  1938. t.Fatal(err)
  1939. }
  1940. id2, err := buildImageFromContext(name, ctx, false)
  1941. if err != nil {
  1942. t.Fatal(err)
  1943. }
  1944. if id1 == id2 {
  1945. t.Fatal("The cache should have been invalided but hasn't.")
  1946. }
  1947. logDone("build - add local and remote file without cache")
  1948. }
  1949. func TestBuildWithVolumeOwnership(t *testing.T) {
  1950. name := "testbuildimg"
  1951. defer deleteImages(name)
  1952. _, err := buildImage(name,
  1953. `FROM busybox:latest
  1954. RUN mkdir /test && chown daemon:daemon /test && chmod 0600 /test
  1955. VOLUME /test`,
  1956. true)
  1957. if err != nil {
  1958. t.Fatal(err)
  1959. }
  1960. cmd := exec.Command(dockerBinary, "run", "--rm", "testbuildimg", "ls", "-la", "/test")
  1961. out, _, err := runCommandWithOutput(cmd)
  1962. if err != nil {
  1963. t.Fatal(out, err)
  1964. }
  1965. if expected := "drw-------"; !strings.Contains(out, expected) {
  1966. t.Fatalf("expected %s received %s", expected, out)
  1967. }
  1968. if expected := "daemon daemon"; !strings.Contains(out, expected) {
  1969. t.Fatalf("expected %s received %s", expected, out)
  1970. }
  1971. logDone("build - volume ownership")
  1972. }
  1973. // testing #1405 - config.Cmd does not get cleaned up if
  1974. // utilizing cache
  1975. func TestBuildEntrypointRunCleanup(t *testing.T) {
  1976. name := "testbuildcmdcleanup"
  1977. defer deleteImages(name)
  1978. if _, err := buildImage(name,
  1979. `FROM busybox
  1980. RUN echo "hello"`,
  1981. true); err != nil {
  1982. t.Fatal(err)
  1983. }
  1984. ctx, err := fakeContext(`FROM busybox
  1985. RUN echo "hello"
  1986. ADD foo /foo
  1987. ENTRYPOINT ["/bin/echo"]`,
  1988. map[string]string{
  1989. "foo": "hello",
  1990. })
  1991. defer ctx.Close()
  1992. if err != nil {
  1993. t.Fatal(err)
  1994. }
  1995. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1996. t.Fatal(err)
  1997. }
  1998. res, err := inspectField(name, "Config.Cmd")
  1999. if err != nil {
  2000. t.Fatal(err)
  2001. }
  2002. // Cmd must be cleaned up
  2003. if expected := "<no value>"; res != expected {
  2004. t.Fatalf("Cmd %s, expected %s", res, expected)
  2005. }
  2006. logDone("build - cleanup cmd after RUN")
  2007. }
  2008. func TestBuildForbiddenContextPath(t *testing.T) {
  2009. name := "testbuildforbidpath"
  2010. defer deleteImages(name)
  2011. ctx, err := fakeContext(`FROM scratch
  2012. ADD ../../ test/
  2013. `,
  2014. map[string]string{
  2015. "test.txt": "test1",
  2016. "other.txt": "other",
  2017. })
  2018. defer ctx.Close()
  2019. if err != nil {
  2020. t.Fatal(err)
  2021. }
  2022. expected := "Forbidden path outside the build context: ../../ "
  2023. if _, err := buildImageFromContext(name, ctx, true); err == nil || !strings.Contains(err.Error(), expected) {
  2024. t.Fatalf("Wrong error: (should contain \"%s\") got:\n%v", expected, err)
  2025. }
  2026. logDone("build - forbidden context path")
  2027. }
  2028. func TestBuildADDFileNotFound(t *testing.T) {
  2029. name := "testbuildaddnotfound"
  2030. defer deleteImages(name)
  2031. ctx, err := fakeContext(`FROM scratch
  2032. ADD foo /usr/local/bar`,
  2033. map[string]string{"bar": "hello"})
  2034. defer ctx.Close()
  2035. if err != nil {
  2036. t.Fatal(err)
  2037. }
  2038. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  2039. if !strings.Contains(err.Error(), "foo: no such file or directory") {
  2040. t.Fatalf("Wrong error %v, must be about missing foo file or directory", err)
  2041. }
  2042. } else {
  2043. t.Fatal("Error must not be nil")
  2044. }
  2045. logDone("build - add file not found")
  2046. }
  2047. func TestBuildInheritance(t *testing.T) {
  2048. name := "testbuildinheritance"
  2049. defer deleteImages(name)
  2050. _, err := buildImage(name,
  2051. `FROM scratch
  2052. EXPOSE 2375`,
  2053. true)
  2054. if err != nil {
  2055. t.Fatal(err)
  2056. }
  2057. ports1, err := inspectField(name, "Config.ExposedPorts")
  2058. if err != nil {
  2059. t.Fatal(err)
  2060. }
  2061. _, err = buildImage(name,
  2062. fmt.Sprintf(`FROM %s
  2063. ENTRYPOINT ["/bin/echo"]`, name),
  2064. true)
  2065. if err != nil {
  2066. t.Fatal(err)
  2067. }
  2068. res, err := inspectField(name, "Config.Entrypoint")
  2069. if err != nil {
  2070. t.Fatal(err)
  2071. }
  2072. if expected := "[/bin/echo]"; res != expected {
  2073. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  2074. }
  2075. ports2, err := inspectField(name, "Config.ExposedPorts")
  2076. if err != nil {
  2077. t.Fatal(err)
  2078. }
  2079. if ports1 != ports2 {
  2080. t.Fatalf("Ports must be same: %s != %s", ports1, ports2)
  2081. }
  2082. logDone("build - inheritance")
  2083. }
  2084. func TestBuildFails(t *testing.T) {
  2085. name := "testbuildfails"
  2086. defer deleteImages(name)
  2087. _, err := buildImage(name,
  2088. `FROM busybox
  2089. RUN sh -c "exit 23"`,
  2090. true)
  2091. if err != nil {
  2092. if !strings.Contains(err.Error(), "returned a non-zero code: 23") {
  2093. t.Fatalf("Wrong error %v, must be about non-zero code 23", err)
  2094. }
  2095. } else {
  2096. t.Fatal("Error must not be nil")
  2097. }
  2098. logDone("build - fails")
  2099. }
  2100. func TestBuildFailsDockerfileEmpty(t *testing.T) {
  2101. name := "testbuildfails"
  2102. defer deleteImages(name)
  2103. _, err := buildImage(name, ``, true)
  2104. if err != nil {
  2105. if !strings.Contains(err.Error(), "Dockerfile cannot be empty") {
  2106. t.Fatalf("Wrong error %v, must be about empty Dockerfile", err)
  2107. }
  2108. } else {
  2109. t.Fatal("Error must not be nil")
  2110. }
  2111. logDone("build - fails with empty dockerfile")
  2112. }
  2113. func TestBuildOnBuild(t *testing.T) {
  2114. name := "testbuildonbuild"
  2115. defer deleteImages(name)
  2116. _, err := buildImage(name,
  2117. `FROM busybox
  2118. ONBUILD RUN touch foobar`,
  2119. true)
  2120. if err != nil {
  2121. t.Fatal(err)
  2122. }
  2123. _, err = buildImage(name,
  2124. fmt.Sprintf(`FROM %s
  2125. RUN [ -f foobar ]`, name),
  2126. true)
  2127. if err != nil {
  2128. t.Fatal(err)
  2129. }
  2130. logDone("build - onbuild")
  2131. }
  2132. func TestBuildOnBuildForbiddenChained(t *testing.T) {
  2133. name := "testbuildonbuildforbiddenchained"
  2134. defer deleteImages(name)
  2135. _, err := buildImage(name,
  2136. `FROM busybox
  2137. ONBUILD ONBUILD RUN touch foobar`,
  2138. true)
  2139. if err != nil {
  2140. if !strings.Contains(err.Error(), "Chaining ONBUILD via `ONBUILD ONBUILD` isn't allowed") {
  2141. t.Fatalf("Wrong error %v, must be about chaining ONBUILD", err)
  2142. }
  2143. } else {
  2144. t.Fatal("Error must not be nil")
  2145. }
  2146. logDone("build - onbuild forbidden chained")
  2147. }
  2148. func TestBuildOnBuildForbiddenFrom(t *testing.T) {
  2149. name := "testbuildonbuildforbiddenfrom"
  2150. defer deleteImages(name)
  2151. _, err := buildImage(name,
  2152. `FROM busybox
  2153. ONBUILD FROM scratch`,
  2154. true)
  2155. if err != nil {
  2156. if !strings.Contains(err.Error(), "FROM isn't allowed as an ONBUILD trigger") {
  2157. t.Fatalf("Wrong error %v, must be about FROM forbidden", err)
  2158. }
  2159. } else {
  2160. t.Fatal("Error must not be nil")
  2161. }
  2162. logDone("build - onbuild forbidden from")
  2163. }
  2164. func TestBuildOnBuildForbiddenMaintainer(t *testing.T) {
  2165. name := "testbuildonbuildforbiddenmaintainer"
  2166. defer deleteImages(name)
  2167. _, err := buildImage(name,
  2168. `FROM busybox
  2169. ONBUILD MAINTAINER docker.io`,
  2170. true)
  2171. if err != nil {
  2172. if !strings.Contains(err.Error(), "MAINTAINER isn't allowed as an ONBUILD trigger") {
  2173. t.Fatalf("Wrong error %v, must be about MAINTAINER forbidden", err)
  2174. }
  2175. } else {
  2176. t.Fatal("Error must not be nil")
  2177. }
  2178. logDone("build - onbuild forbidden maintainer")
  2179. }
  2180. // gh #2446
  2181. func TestBuildAddToSymlinkDest(t *testing.T) {
  2182. name := "testbuildaddtosymlinkdest"
  2183. defer deleteImages(name)
  2184. ctx, err := fakeContext(`FROM busybox
  2185. RUN mkdir /foo
  2186. RUN ln -s /foo /bar
  2187. ADD foo /bar/
  2188. RUN [ -f /bar/foo ]
  2189. RUN [ -f /foo/foo ]`,
  2190. map[string]string{
  2191. "foo": "hello",
  2192. })
  2193. if err != nil {
  2194. t.Fatal(err)
  2195. }
  2196. defer ctx.Close()
  2197. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  2198. t.Fatal(err)
  2199. }
  2200. logDone("build - add to symlink destination")
  2201. }
  2202. func TestBuildEscapeWhitespace(t *testing.T) {
  2203. name := "testbuildescaping"
  2204. defer deleteImages(name)
  2205. _, err := buildImage(name, `
  2206. FROM busybox
  2207. MAINTAINER "Docker \
  2208. IO <io@\
  2209. docker.com>"
  2210. `, true)
  2211. res, err := inspectField(name, "Author")
  2212. if err != nil {
  2213. t.Fatal(err)
  2214. }
  2215. if res != "Docker IO <io@docker.com>" {
  2216. t.Fatal("Parsed string did not match the escaped string")
  2217. }
  2218. logDone("build - validate escaping whitespace")
  2219. }
  2220. func TestBuildDockerignore(t *testing.T) {
  2221. name := "testbuilddockerignore"
  2222. defer deleteImages(name)
  2223. dockerfile := `
  2224. FROM busybox
  2225. ADD . /bla
  2226. RUN [[ -f /bla/src/x.go ]]
  2227. RUN [[ -f /bla/Makefile ]]
  2228. RUN [[ ! -e /bla/src/_vendor ]]
  2229. RUN [[ ! -e /bla/.gitignore ]]
  2230. RUN [[ ! -e /bla/README.md ]]
  2231. RUN [[ ! -e /bla/.git ]]`
  2232. ctx, err := fakeContext(dockerfile, map[string]string{
  2233. "Makefile": "all:",
  2234. ".git/HEAD": "ref: foo",
  2235. "src/x.go": "package main",
  2236. "src/_vendor/v.go": "package main",
  2237. ".gitignore": "",
  2238. "README.md": "readme",
  2239. ".dockerignore": ".git\npkg\n.gitignore\nsrc/_vendor\n*.md",
  2240. })
  2241. defer ctx.Close()
  2242. if err != nil {
  2243. t.Fatal(err)
  2244. }
  2245. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  2246. t.Fatal(err)
  2247. }
  2248. logDone("build - test .dockerignore")
  2249. }
  2250. func TestBuildDockerignoringDockerfile(t *testing.T) {
  2251. name := "testbuilddockerignoredockerfile"
  2252. defer deleteImages(name)
  2253. dockerfile := `
  2254. FROM scratch`
  2255. ctx, err := fakeContext(dockerfile, map[string]string{
  2256. "Dockerfile": "FROM scratch",
  2257. ".dockerignore": "Dockerfile\n",
  2258. })
  2259. defer ctx.Close()
  2260. if err != nil {
  2261. t.Fatal(err)
  2262. }
  2263. if _, err = buildImageFromContext(name, ctx, true); err == nil {
  2264. t.Fatalf("Didn't get expected error from ignoring Dockerfile")
  2265. }
  2266. logDone("build - test .dockerignore of Dockerfile")
  2267. }
  2268. func TestBuildDockerignoringWholeDir(t *testing.T) {
  2269. name := "testbuilddockerignorewholedir"
  2270. defer deleteImages(name)
  2271. dockerfile := `
  2272. FROM busybox
  2273. COPY . /
  2274. RUN [[ ! -e /.gitignore ]]
  2275. RUN [[ -f /Makefile ]]`
  2276. ctx, err := fakeContext(dockerfile, map[string]string{
  2277. "Dockerfile": "FROM scratch",
  2278. "Makefile": "all:",
  2279. ".dockerignore": ".*\n",
  2280. })
  2281. defer ctx.Close()
  2282. if err != nil {
  2283. t.Fatal(err)
  2284. }
  2285. if _, err = buildImageFromContext(name, ctx, true); err != nil {
  2286. t.Fatal(err)
  2287. }
  2288. logDone("build - test .dockerignore whole dir with .*")
  2289. }
  2290. func TestBuildLineBreak(t *testing.T) {
  2291. name := "testbuildlinebreak"
  2292. defer deleteImages(name)
  2293. _, err := buildImage(name,
  2294. `FROM busybox
  2295. RUN sh -c 'echo root:testpass \
  2296. > /tmp/passwd'
  2297. RUN mkdir -p /var/run/sshd
  2298. RUN [ "$(cat /tmp/passwd)" = "root:testpass" ]
  2299. RUN [ "$(ls -d /var/run/sshd)" = "/var/run/sshd" ]`,
  2300. true)
  2301. if err != nil {
  2302. t.Fatal(err)
  2303. }
  2304. logDone("build - line break with \\")
  2305. }
  2306. func TestBuildEOLInLine(t *testing.T) {
  2307. name := "testbuildeolinline"
  2308. defer deleteImages(name)
  2309. _, err := buildImage(name,
  2310. `FROM busybox
  2311. RUN sh -c 'echo root:testpass > /tmp/passwd'
  2312. RUN echo "foo \n bar"; echo "baz"
  2313. RUN mkdir -p /var/run/sshd
  2314. RUN [ "$(cat /tmp/passwd)" = "root:testpass" ]
  2315. RUN [ "$(ls -d /var/run/sshd)" = "/var/run/sshd" ]`,
  2316. true)
  2317. if err != nil {
  2318. t.Fatal(err)
  2319. }
  2320. logDone("build - end of line in dockerfile instruction")
  2321. }
  2322. func TestBuildCommentsShebangs(t *testing.T) {
  2323. name := "testbuildcomments"
  2324. defer deleteImages(name)
  2325. _, err := buildImage(name,
  2326. `FROM busybox
  2327. # This is an ordinary comment.
  2328. RUN { echo '#!/bin/sh'; echo 'echo hello world'; } > /hello.sh
  2329. RUN [ ! -x /hello.sh ]
  2330. # comment with line break \
  2331. RUN chmod +x /hello.sh
  2332. RUN [ -x /hello.sh ]
  2333. RUN [ "$(cat /hello.sh)" = $'#!/bin/sh\necho hello world' ]
  2334. RUN [ "$(/hello.sh)" = "hello world" ]`,
  2335. true)
  2336. if err != nil {
  2337. t.Fatal(err)
  2338. }
  2339. logDone("build - comments and shebangs")
  2340. }
  2341. func TestBuildUsersAndGroups(t *testing.T) {
  2342. name := "testbuildusers"
  2343. defer deleteImages(name)
  2344. _, err := buildImage(name,
  2345. `FROM busybox
  2346. # Make sure our defaults work
  2347. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)" = '0:0/root:root' ]
  2348. # TODO decide if "args.user = strconv.Itoa(syscall.Getuid())" is acceptable behavior for changeUser in sysvinit instead of "return nil" when "USER" isn't specified (so that we get the proper group list even if that is the empty list, even in the default case of not supplying an explicit USER to run as, which implies USER 0)
  2349. USER root
  2350. RUN [ "$(id -G):$(id -Gn)" = '0 10:root wheel' ]
  2351. # Setup dockerio user and group
  2352. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  2353. RUN echo 'dockerio:x:1001:' >> /etc/group
  2354. # Make sure we can switch to our user and all the information is exactly as we expect it to be
  2355. USER dockerio
  2356. RUN id -G
  2357. RUN id -Gn
  2358. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  2359. # Switch back to root and double check that worked exactly as we might expect it to
  2360. USER root
  2361. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '0:0/root:root/0 10:root wheel' ]
  2362. # Add a "supplementary" group for our dockerio user
  2363. RUN echo 'supplementary:x:1002:dockerio' >> /etc/group
  2364. # ... and then go verify that we get it like we expect
  2365. USER dockerio
  2366. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001 1002:dockerio supplementary' ]
  2367. USER 1001
  2368. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001 1002:dockerio supplementary' ]
  2369. # super test the new "user:group" syntax
  2370. USER dockerio:dockerio
  2371. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  2372. USER 1001:dockerio
  2373. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  2374. USER dockerio:1001
  2375. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  2376. USER 1001:1001
  2377. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  2378. USER dockerio:supplementary
  2379. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1002/dockerio:supplementary/1002:supplementary' ]
  2380. USER dockerio:1002
  2381. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1002/dockerio:supplementary/1002:supplementary' ]
  2382. USER 1001:supplementary
  2383. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1002/dockerio:supplementary/1002:supplementary' ]
  2384. USER 1001:1002
  2385. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1002/dockerio:supplementary/1002:supplementary' ]
  2386. # make sure unknown uid/gid still works properly
  2387. USER 1042:1043
  2388. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1042:1043/1042:1043/1043:1043' ]`,
  2389. true)
  2390. if err != nil {
  2391. t.Fatal(err)
  2392. }
  2393. logDone("build - users and groups")
  2394. }
  2395. func TestBuildEnvUsage(t *testing.T) {
  2396. name := "testbuildenvusage"
  2397. defer deleteImages(name)
  2398. dockerfile := `FROM busybox
  2399. ENV HOME /root
  2400. ENV PATH $HOME/bin:$PATH
  2401. ENV PATH /tmp:$PATH
  2402. RUN [ "$PATH" = "/tmp:$HOME/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" ]
  2403. ENV FOO /foo/baz
  2404. ENV BAR /bar
  2405. ENV BAZ $BAR
  2406. ENV FOOPATH $PATH:$FOO
  2407. RUN [ "$BAR" = "$BAZ" ]
  2408. RUN [ "$FOOPATH" = "$PATH:/foo/baz" ]
  2409. ENV FROM hello/docker/world
  2410. ENV TO /docker/world/hello
  2411. ADD $FROM $TO
  2412. RUN [ "$(cat $TO)" = "hello" ]
  2413. `
  2414. ctx, err := fakeContext(dockerfile, map[string]string{
  2415. "hello/docker/world": "hello",
  2416. })
  2417. if err != nil {
  2418. t.Fatal(err)
  2419. }
  2420. _, err = buildImageFromContext(name, ctx, true)
  2421. if err != nil {
  2422. t.Fatal(err)
  2423. }
  2424. logDone("build - environment variables usage")
  2425. }
  2426. func TestBuildAddScript(t *testing.T) {
  2427. name := "testbuildaddscript"
  2428. defer deleteImages(name)
  2429. dockerfile := `
  2430. FROM busybox
  2431. ADD test /test
  2432. RUN ["chmod","+x","/test"]
  2433. RUN ["/test"]
  2434. RUN [ "$(cat /testfile)" = 'test!' ]`
  2435. ctx, err := fakeContext(dockerfile, map[string]string{
  2436. "test": "#!/bin/sh\necho 'test!' > /testfile",
  2437. })
  2438. if err != nil {
  2439. t.Fatal(err)
  2440. }
  2441. _, err = buildImageFromContext(name, ctx, true)
  2442. if err != nil {
  2443. t.Fatal(err)
  2444. }
  2445. logDone("build - add and run script")
  2446. }
  2447. func TestBuildAddTar(t *testing.T) {
  2448. name := "testbuildaddtar"
  2449. defer deleteImages(name)
  2450. ctx := func() *FakeContext {
  2451. dockerfile := `
  2452. FROM busybox
  2453. ADD test.tar /
  2454. RUN cat /test/foo | grep Hi
  2455. ADD test.tar /test.tar
  2456. RUN cat /test.tar/test/foo | grep Hi
  2457. ADD test.tar /unlikely-to-exist
  2458. RUN cat /unlikely-to-exist/test/foo | grep Hi
  2459. ADD test.tar /unlikely-to-exist-trailing-slash/
  2460. RUN cat /unlikely-to-exist-trailing-slash/test/foo | grep Hi
  2461. RUN mkdir /existing-directory
  2462. ADD test.tar /existing-directory
  2463. RUN cat /existing-directory/test/foo | grep Hi
  2464. ADD test.tar /existing-directory-trailing-slash/
  2465. RUN cat /existing-directory-trailing-slash/test/foo | grep Hi`
  2466. tmpDir, err := ioutil.TempDir("", "fake-context")
  2467. testTar, err := os.Create(filepath.Join(tmpDir, "test.tar"))
  2468. if err != nil {
  2469. t.Fatalf("failed to create test.tar archive: %v", err)
  2470. }
  2471. defer testTar.Close()
  2472. tw := tar.NewWriter(testTar)
  2473. if err := tw.WriteHeader(&tar.Header{
  2474. Name: "test/foo",
  2475. Size: 2,
  2476. }); err != nil {
  2477. t.Fatalf("failed to write tar file header: %v", err)
  2478. }
  2479. if _, err := tw.Write([]byte("Hi")); err != nil {
  2480. t.Fatalf("failed to write tar file content: %v", err)
  2481. }
  2482. if err := tw.Close(); err != nil {
  2483. t.Fatalf("failed to close tar archive: %v", err)
  2484. }
  2485. if err := ioutil.WriteFile(filepath.Join(tmpDir, "Dockerfile"), []byte(dockerfile), 0644); err != nil {
  2486. t.Fatalf("failed to open destination dockerfile: %v", err)
  2487. }
  2488. return &FakeContext{Dir: tmpDir}
  2489. }()
  2490. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  2491. t.Fatalf("build failed to complete for TestBuildAddTar: %v", err)
  2492. }
  2493. logDone("build - ADD tar")
  2494. }
  2495. func TestBuildFromGIT(t *testing.T) {
  2496. name := "testbuildfromgit"
  2497. defer deleteImages(name)
  2498. git, err := fakeGIT("repo", map[string]string{
  2499. "Dockerfile": `FROM busybox
  2500. ADD first /first
  2501. RUN [ -f /first ]
  2502. MAINTAINER docker`,
  2503. "first": "test git data",
  2504. })
  2505. if err != nil {
  2506. t.Fatal(err)
  2507. }
  2508. defer git.Close()
  2509. _, err = buildImageFromPath(name, git.RepoURL, true)
  2510. if err != nil {
  2511. t.Fatal(err)
  2512. }
  2513. res, err := inspectField(name, "Author")
  2514. if err != nil {
  2515. t.Fatal(err)
  2516. }
  2517. if res != "docker" {
  2518. t.Fatalf("Maintainer should be docker, got %s", res)
  2519. }
  2520. logDone("build - build from GIT")
  2521. }
  2522. func TestBuildCleanupCmdOnEntrypoint(t *testing.T) {
  2523. name := "testbuildcmdcleanuponentrypoint"
  2524. defer deleteImages(name)
  2525. if _, err := buildImage(name,
  2526. `FROM scratch
  2527. CMD ["test"]
  2528. ENTRYPOINT ["echo"]`,
  2529. true); err != nil {
  2530. t.Fatal(err)
  2531. }
  2532. if _, err := buildImage(name,
  2533. fmt.Sprintf(`FROM %s
  2534. ENTRYPOINT ["cat"]`, name),
  2535. true); err != nil {
  2536. t.Fatal(err)
  2537. }
  2538. res, err := inspectField(name, "Config.Cmd")
  2539. if err != nil {
  2540. t.Fatal(err)
  2541. }
  2542. if expected := "<no value>"; res != expected {
  2543. t.Fatalf("Cmd %s, expected %s", res, expected)
  2544. }
  2545. res, err = inspectField(name, "Config.Entrypoint")
  2546. if err != nil {
  2547. t.Fatal(err)
  2548. }
  2549. if expected := "[cat]"; res != expected {
  2550. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  2551. }
  2552. logDone("build - cleanup cmd on ENTRYPOINT")
  2553. }
  2554. func TestBuildClearCmd(t *testing.T) {
  2555. name := "testbuildclearcmd"
  2556. defer deleteImages(name)
  2557. _, err := buildImage(name,
  2558. `From scratch
  2559. ENTRYPOINT ["/bin/bash"]
  2560. CMD []`,
  2561. true)
  2562. if err != nil {
  2563. t.Fatal(err)
  2564. }
  2565. res, err := inspectFieldJSON(name, "Config.Cmd")
  2566. if err != nil {
  2567. t.Fatal(err)
  2568. }
  2569. if res != "[]" {
  2570. t.Fatalf("Cmd %s, expected %s", res, "[]")
  2571. }
  2572. logDone("build - clearcmd")
  2573. }
  2574. func TestBuildEmptyCmd(t *testing.T) {
  2575. name := "testbuildemptycmd"
  2576. defer deleteImages(name)
  2577. if _, err := buildImage(name, "FROM scratch\nMAINTAINER quux\n", true); err != nil {
  2578. t.Fatal(err)
  2579. }
  2580. res, err := inspectFieldJSON(name, "Config.Cmd")
  2581. if err != nil {
  2582. t.Fatal(err)
  2583. }
  2584. if res != "null" {
  2585. t.Fatalf("Cmd %s, expected %s", res, "null")
  2586. }
  2587. logDone("build - empty cmd")
  2588. }
  2589. func TestBuildOnBuildOutput(t *testing.T) {
  2590. name := "testbuildonbuildparent"
  2591. defer deleteImages(name)
  2592. if _, err := buildImage(name, "FROM busybox\nONBUILD RUN echo foo\n", true); err != nil {
  2593. t.Fatal(err)
  2594. }
  2595. childname := "testbuildonbuildchild"
  2596. defer deleteImages(childname)
  2597. _, out, err := buildImageWithOut(name, "FROM "+name+"\nMAINTAINER quux\n", true)
  2598. if err != nil {
  2599. t.Fatal(err)
  2600. }
  2601. if !strings.Contains(out, "Trigger 0, RUN echo foo") {
  2602. t.Fatal("failed to find the ONBUILD output", out)
  2603. }
  2604. logDone("build - onbuild output")
  2605. }
  2606. func TestBuildInvalidTag(t *testing.T) {
  2607. name := "abcd:" + makeRandomString(200)
  2608. defer deleteImages(name)
  2609. _, out, err := buildImageWithOut(name, "FROM scratch\nMAINTAINER quux\n", true)
  2610. // if the error doesnt check for illegal tag name, or the image is built
  2611. // then this should fail
  2612. if !strings.Contains(out, "Illegal tag name") || strings.Contains(out, "Sending build context to Docker daemon") {
  2613. t.Fatalf("failed to stop before building. Error: %s, Output: %s", err, out)
  2614. }
  2615. logDone("build - invalid tag")
  2616. }
  2617. func TestBuildCmdShDashC(t *testing.T) {
  2618. name := "testbuildcmdshc"
  2619. defer deleteImages(name)
  2620. if _, err := buildImage(name, "FROM busybox\nCMD echo cmd\n", true); err != nil {
  2621. t.Fatal(err)
  2622. }
  2623. res, err := inspectFieldJSON(name, "Config.Cmd")
  2624. if err != nil {
  2625. t.Fatal(err, res)
  2626. }
  2627. expected := `["/bin/sh","-c","echo cmd"]`
  2628. if res != expected {
  2629. t.Fatalf("Expected value %s not in Config.Cmd: %s", expected, res)
  2630. }
  2631. logDone("build - cmd should have sh -c for non-json")
  2632. }
  2633. func TestBuildCmdJSONNoShDashC(t *testing.T) {
  2634. name := "testbuildcmdjson"
  2635. defer deleteImages(name)
  2636. if _, err := buildImage(name, "FROM busybox\nCMD [\"echo\", \"cmd\"]", true); err != nil {
  2637. t.Fatal(err)
  2638. }
  2639. res, err := inspectFieldJSON(name, "Config.Cmd")
  2640. if err != nil {
  2641. t.Fatal(err, res)
  2642. }
  2643. expected := `["echo","cmd"]`
  2644. if res != expected {
  2645. t.Fatalf("Expected value %s not in Config.Cmd: %s", expected, res)
  2646. }
  2647. logDone("build - cmd should not have /bin/sh -c for json")
  2648. }
  2649. func TestBuildIgnoreInvalidInstruction(t *testing.T) {
  2650. name := "testbuildignoreinvalidinstruction"
  2651. defer deleteImages(name)
  2652. out, _, err := buildImageWithOut(name, "FROM busybox\nfoo bar", true)
  2653. if err != nil {
  2654. t.Fatal(err, out)
  2655. }
  2656. logDone("build - ignore invalid Dockerfile instruction")
  2657. }
  2658. func TestBuildEntrypointInheritance(t *testing.T) {
  2659. defer deleteImages("parent", "child")
  2660. if _, err := buildImage("parent", `
  2661. FROM busybox
  2662. ENTRYPOINT exit 130
  2663. `, true); err != nil {
  2664. t.Fatal(err)
  2665. }
  2666. status, _ := runCommand(exec.Command(dockerBinary, "run", "parent"))
  2667. if status != 130 {
  2668. t.Fatalf("expected exit code 130 but received %d", status)
  2669. }
  2670. if _, err := buildImage("child", `
  2671. FROM parent
  2672. ENTRYPOINT exit 5
  2673. `, true); err != nil {
  2674. t.Fatal(err)
  2675. }
  2676. status, _ = runCommand(exec.Command(dockerBinary, "run", "child"))
  2677. if status != 5 {
  2678. t.Fatal("expected exit code 5 but received %d", status)
  2679. }
  2680. logDone("build - clear entrypoint")
  2681. }
  2682. func TestBuildEntrypointInheritanceInspect(t *testing.T) {
  2683. var (
  2684. name = "testbuildepinherit"
  2685. name2 = "testbuildepinherit2"
  2686. expected = `["/bin/sh","-c","echo quux"]`
  2687. )
  2688. defer deleteImages(name, name2)
  2689. if _, err := buildImage(name, "FROM busybox\nENTRYPOINT /foo/bar", true); err != nil {
  2690. t.Fatal(err)
  2691. }
  2692. if _, err := buildImage(name2, fmt.Sprintf("FROM %s\nENTRYPOINT echo quux", name), true); err != nil {
  2693. t.Fatal(err)
  2694. }
  2695. res, err := inspectFieldJSON(name2, "Config.Entrypoint")
  2696. if err != nil {
  2697. t.Fatal(err, res)
  2698. }
  2699. if res != expected {
  2700. t.Fatalf("Expected value %s not in Config.Entrypoint: %s", expected, res)
  2701. }
  2702. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "-t", name2))
  2703. if err != nil {
  2704. t.Fatal(err, out)
  2705. }
  2706. expected = "quux"
  2707. if strings.TrimSpace(out) != expected {
  2708. t.Fatalf("Expected output is %s, got %s", expected, out)
  2709. }
  2710. logDone("build - entrypoint override inheritance properly")
  2711. }
  2712. func TestBuildRunShEntrypoint(t *testing.T) {
  2713. name := "testbuildentrypoint"
  2714. defer deleteImages(name)
  2715. _, err := buildImage(name,
  2716. `FROM busybox
  2717. ENTRYPOINT /bin/echo`,
  2718. true)
  2719. if err != nil {
  2720. t.Fatal(err)
  2721. }
  2722. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", name))
  2723. if err != nil {
  2724. t.Fatal(err, out)
  2725. }
  2726. logDone("build - entrypoint with /bin/echo running successfully")
  2727. }
  2728. func TestBuildExoticShellInterpolation(t *testing.T) {
  2729. name := "testbuildexoticshellinterpolation"
  2730. defer deleteImages(name)
  2731. _, err := buildImage(name, `
  2732. FROM busybox
  2733. ENV SOME_VAR a.b.c
  2734. RUN [ "$SOME_VAR" = 'a.b.c' ]
  2735. RUN [ "${SOME_VAR}" = 'a.b.c' ]
  2736. RUN [ "${SOME_VAR%.*}" = 'a.b' ]
  2737. RUN [ "${SOME_VAR%%.*}" = 'a' ]
  2738. RUN [ "${SOME_VAR#*.}" = 'b.c' ]
  2739. RUN [ "${SOME_VAR##*.}" = 'c' ]
  2740. RUN [ "${SOME_VAR/c/d}" = 'a.b.d' ]
  2741. RUN [ "${#SOME_VAR}" = '5' ]
  2742. RUN [ "${SOME_UNSET_VAR:-$SOME_VAR}" = 'a.b.c' ]
  2743. RUN [ "${SOME_VAR:+Version: ${SOME_VAR}}" = 'Version: a.b.c' ]
  2744. RUN [ "${SOME_UNSET_VAR:+${SOME_VAR}}" = '' ]
  2745. RUN [ "${SOME_UNSET_VAR:-${SOME_VAR:-d.e.f}}" = 'a.b.c' ]
  2746. `, false)
  2747. if err != nil {
  2748. t.Fatal(err)
  2749. }
  2750. logDone("build - exotic shell interpolation")
  2751. }