builder.go 10 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373
  1. package dockerfile
  2. import (
  3. "bytes"
  4. "fmt"
  5. "io"
  6. "io/ioutil"
  7. "os"
  8. "strings"
  9. "github.com/Sirupsen/logrus"
  10. "github.com/docker/distribution/reference"
  11. apierrors "github.com/docker/docker/api/errors"
  12. "github.com/docker/docker/api/types"
  13. "github.com/docker/docker/api/types/backend"
  14. "github.com/docker/docker/api/types/container"
  15. "github.com/docker/docker/builder"
  16. "github.com/docker/docker/builder/dockerfile/command"
  17. "github.com/docker/docker/builder/dockerfile/parser"
  18. "github.com/docker/docker/image"
  19. "github.com/docker/docker/pkg/stringid"
  20. "github.com/pkg/errors"
  21. "golang.org/x/net/context"
  22. )
  23. var validCommitCommands = map[string]bool{
  24. "cmd": true,
  25. "entrypoint": true,
  26. "healthcheck": true,
  27. "env": true,
  28. "expose": true,
  29. "label": true,
  30. "onbuild": true,
  31. "user": true,
  32. "volume": true,
  33. "workdir": true,
  34. }
  35. var defaultLogConfig = container.LogConfig{Type: "none"}
  36. // Builder is a Dockerfile builder
  37. // It implements the builder.Backend interface.
  38. type Builder struct {
  39. options *types.ImageBuildOptions
  40. Stdout io.Writer
  41. Stderr io.Writer
  42. Output io.Writer
  43. docker builder.Backend
  44. context builder.Context
  45. clientCtx context.Context
  46. runConfig *container.Config // runconfig for cmd, run, entrypoint etc.
  47. tmpContainers map[string]struct{}
  48. imageContexts *imageContexts // helper for storing contexts from builds
  49. disableCommit bool
  50. cacheBusted bool
  51. buildArgs *buildArgs
  52. imageCache builder.ImageCache
  53. // TODO: these move to DispatchState
  54. maintainer string
  55. cmdSet bool
  56. noBaseImage bool // A flag to track the use of `scratch` as the base image
  57. image string // imageID
  58. from builder.Image
  59. }
  60. // BuildManager implements builder.Backend and is shared across all Builder objects.
  61. type BuildManager struct {
  62. backend builder.Backend
  63. pathCache *pathCache // TODO: make this persistent
  64. }
  65. // NewBuildManager creates a BuildManager.
  66. func NewBuildManager(b builder.Backend) (bm *BuildManager) {
  67. return &BuildManager{backend: b, pathCache: &pathCache{}}
  68. }
  69. // BuildFromContext builds a new image from a given context.
  70. func (bm *BuildManager) BuildFromContext(ctx context.Context, src io.ReadCloser, remote string, buildOptions *types.ImageBuildOptions, pg backend.ProgressWriter) (string, error) {
  71. if buildOptions.Squash && !bm.backend.HasExperimental() {
  72. return "", apierrors.NewBadRequestError(errors.New("squash is only supported with experimental mode"))
  73. }
  74. buildContext, dockerfileName, err := builder.DetectContextFromRemoteURL(src, remote, pg.ProgressReaderFunc)
  75. if err != nil {
  76. return "", err
  77. }
  78. defer func() {
  79. if err := buildContext.Close(); err != nil {
  80. logrus.Debugf("[BUILDER] failed to remove temporary context: %v", err)
  81. }
  82. }()
  83. if len(dockerfileName) > 0 {
  84. buildOptions.Dockerfile = dockerfileName
  85. }
  86. b, err := NewBuilder(ctx, buildOptions, bm.backend, builder.DockerIgnoreContext{ModifiableContext: buildContext})
  87. if err != nil {
  88. return "", err
  89. }
  90. b.imageContexts.cache = bm.pathCache
  91. return b.build(pg.StdoutFormatter, pg.StderrFormatter, pg.Output)
  92. }
  93. // NewBuilder creates a new Dockerfile builder from an optional dockerfile and a Config.
  94. // If dockerfile is nil, the Dockerfile specified by Config.DockerfileName,
  95. // will be read from the Context passed to Build().
  96. func NewBuilder(clientCtx context.Context, config *types.ImageBuildOptions, backend builder.Backend, buildContext builder.Context) (b *Builder, err error) {
  97. if config == nil {
  98. config = new(types.ImageBuildOptions)
  99. }
  100. b = &Builder{
  101. clientCtx: clientCtx,
  102. options: config,
  103. Stdout: os.Stdout,
  104. Stderr: os.Stderr,
  105. docker: backend,
  106. context: buildContext,
  107. runConfig: new(container.Config),
  108. tmpContainers: map[string]struct{}{},
  109. buildArgs: newBuildArgs(config.BuildArgs),
  110. }
  111. b.imageContexts = &imageContexts{b: b}
  112. return b, nil
  113. }
  114. func (b *Builder) resetImageCache() {
  115. if icb, ok := b.docker.(builder.ImageCacheBuilder); ok {
  116. b.imageCache = icb.MakeImageCache(b.options.CacheFrom)
  117. }
  118. b.noBaseImage = false
  119. b.cacheBusted = false
  120. }
  121. // sanitizeRepoAndTags parses the raw "t" parameter received from the client
  122. // to a slice of repoAndTag.
  123. // It also validates each repoName and tag.
  124. func sanitizeRepoAndTags(names []string) ([]reference.Named, error) {
  125. var (
  126. repoAndTags []reference.Named
  127. // This map is used for deduplicating the "-t" parameter.
  128. uniqNames = make(map[string]struct{})
  129. )
  130. for _, repo := range names {
  131. if repo == "" {
  132. continue
  133. }
  134. ref, err := reference.ParseNormalizedNamed(repo)
  135. if err != nil {
  136. return nil, err
  137. }
  138. if _, isCanonical := ref.(reference.Canonical); isCanonical {
  139. return nil, errors.New("build tag cannot contain a digest")
  140. }
  141. ref = reference.TagNameOnly(ref)
  142. nameWithTag := ref.String()
  143. if _, exists := uniqNames[nameWithTag]; !exists {
  144. uniqNames[nameWithTag] = struct{}{}
  145. repoAndTags = append(repoAndTags, ref)
  146. }
  147. }
  148. return repoAndTags, nil
  149. }
  150. // build runs the Dockerfile builder from a context and a docker object that allows to make calls
  151. // to Docker.
  152. func (b *Builder) build(stdout io.Writer, stderr io.Writer, out io.Writer) (string, error) {
  153. defer b.imageContexts.unmount()
  154. b.Stdout = stdout
  155. b.Stderr = stderr
  156. b.Output = out
  157. dockerfile, err := b.readAndParseDockerfile()
  158. if err != nil {
  159. return "", err
  160. }
  161. repoAndTags, err := sanitizeRepoAndTags(b.options.Tags)
  162. if err != nil {
  163. return "", err
  164. }
  165. addNodesForLabelOption(dockerfile.AST, b.options.Labels)
  166. if err := checkDispatchDockerfile(dockerfile.AST); err != nil {
  167. return "", err
  168. }
  169. imageID, err := b.dispatchDockerfileWithCancellation(dockerfile)
  170. if err != nil {
  171. return "", err
  172. }
  173. b.warnOnUnusedBuildArgs()
  174. if imageID == "" {
  175. return "", errors.New("No image was generated. Is your Dockerfile empty?")
  176. }
  177. if b.options.Squash {
  178. if imageID, err = b.squashBuild(imageID); err != nil {
  179. return "", err
  180. }
  181. }
  182. fmt.Fprintf(b.Stdout, "Successfully built %s\n", stringid.TruncateID(imageID))
  183. if err := b.tagImages(imageID, repoAndTags); err != nil {
  184. return "", err
  185. }
  186. return imageID, nil
  187. }
  188. func (b *Builder) dispatchDockerfileWithCancellation(dockerfile *parser.Result) (string, error) {
  189. shlex := NewShellLex(dockerfile.EscapeToken)
  190. total := len(dockerfile.AST.Children)
  191. var imageID string
  192. for i, n := range dockerfile.AST.Children {
  193. select {
  194. case <-b.clientCtx.Done():
  195. logrus.Debug("Builder: build cancelled!")
  196. fmt.Fprint(b.Stdout, "Build cancelled")
  197. return "", errors.New("Build cancelled")
  198. default:
  199. // Not cancelled yet, keep going...
  200. }
  201. if command.From == n.Value && b.imageContexts.isCurrentTarget(b.options.Target) {
  202. break
  203. }
  204. if err := b.dispatch(i, total, n, shlex); err != nil {
  205. if b.options.ForceRemove {
  206. b.clearTmp()
  207. }
  208. return "", err
  209. }
  210. // TODO: get this from dispatch
  211. imageID = b.image
  212. fmt.Fprintf(b.Stdout, " ---> %s\n", stringid.TruncateID(imageID))
  213. if b.options.Remove {
  214. b.clearTmp()
  215. }
  216. }
  217. if b.options.Target != "" && !b.imageContexts.isCurrentTarget(b.options.Target) {
  218. return "", errors.Errorf("failed to reach build target %s in Dockerfile", b.options.Target)
  219. }
  220. return imageID, nil
  221. }
  222. func (b *Builder) squashBuild(imageID string) (string, error) {
  223. var fromID string
  224. var err error
  225. if b.from != nil {
  226. fromID = b.from.ImageID()
  227. }
  228. imageID, err = b.docker.SquashImage(imageID, fromID)
  229. if err != nil {
  230. return "", errors.Wrap(err, "error squashing image")
  231. }
  232. return imageID, nil
  233. }
  234. func addNodesForLabelOption(dockerfile *parser.Node, labels map[string]string) {
  235. if len(labels) == 0 {
  236. return
  237. }
  238. node := parser.NodeFromLabels(labels)
  239. dockerfile.Children = append(dockerfile.Children, node)
  240. }
  241. // check if there are any leftover build-args that were passed but not
  242. // consumed during build. Print a warning, if there are any.
  243. func (b *Builder) warnOnUnusedBuildArgs() {
  244. leftoverArgs := b.buildArgs.UnreferencedOptionArgs()
  245. if len(leftoverArgs) > 0 {
  246. fmt.Fprintf(b.Stderr, "[Warning] One or more build-args %v were not consumed\n", leftoverArgs)
  247. }
  248. }
  249. func (b *Builder) tagImages(id string, repoAndTags []reference.Named) error {
  250. imageID := image.ID(id)
  251. for _, rt := range repoAndTags {
  252. if err := b.docker.TagImageWithReference(imageID, rt); err != nil {
  253. return err
  254. }
  255. fmt.Fprintf(b.Stdout, "Successfully tagged %s\n", reference.FamiliarString(rt))
  256. }
  257. return nil
  258. }
  259. // hasFromImage returns true if the builder has processed a `FROM <image>` line
  260. // TODO: move to DispatchState
  261. func (b *Builder) hasFromImage() bool {
  262. return b.image != "" || b.noBaseImage
  263. }
  264. // BuildFromConfig builds directly from `changes`, treating it as if it were the contents of a Dockerfile
  265. // It will:
  266. // - Call parse.Parse() to get an AST root for the concatenated Dockerfile entries.
  267. // - Do build by calling builder.dispatch() to call all entries' handling routines
  268. //
  269. // BuildFromConfig is used by the /commit endpoint, with the changes
  270. // coming from the query parameter of the same name.
  271. //
  272. // TODO: Remove?
  273. func BuildFromConfig(config *container.Config, changes []string) (*container.Config, error) {
  274. b, err := NewBuilder(context.Background(), nil, nil, nil)
  275. if err != nil {
  276. return nil, err
  277. }
  278. result, err := parser.Parse(bytes.NewBufferString(strings.Join(changes, "\n")))
  279. if err != nil {
  280. return nil, err
  281. }
  282. // ensure that the commands are valid
  283. for _, n := range result.AST.Children {
  284. if !validCommitCommands[n.Value] {
  285. return nil, fmt.Errorf("%s is not a valid change command", n.Value)
  286. }
  287. }
  288. b.runConfig = config
  289. b.Stdout = ioutil.Discard
  290. b.Stderr = ioutil.Discard
  291. b.disableCommit = true
  292. if err := checkDispatchDockerfile(result.AST); err != nil {
  293. return nil, err
  294. }
  295. if err := dispatchFromDockerfile(b, result); err != nil {
  296. return nil, err
  297. }
  298. return b.runConfig, nil
  299. }
  300. func checkDispatchDockerfile(dockerfile *parser.Node) error {
  301. for _, n := range dockerfile.Children {
  302. if err := checkDispatch(n); err != nil {
  303. return errors.Wrapf(err, "Dockerfile parse error line %d", n.StartLine)
  304. }
  305. }
  306. return nil
  307. }
  308. func dispatchFromDockerfile(b *Builder, result *parser.Result) error {
  309. shlex := NewShellLex(result.EscapeToken)
  310. ast := result.AST
  311. total := len(ast.Children)
  312. for i, n := range ast.Children {
  313. if err := b.dispatch(i, total, n, shlex); err != nil {
  314. return err
  315. }
  316. }
  317. return nil
  318. }