docker_cli_rename_test.go 4.8 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127
  1. package main
  2. import (
  3. "strings"
  4. "github.com/docker/docker/integration-cli/checker"
  5. "github.com/docker/docker/pkg/stringid"
  6. "github.com/go-check/check"
  7. "github.com/gotestyourself/gotestyourself/icmd"
  8. )
  9. func (s *DockerSuite) TestRenameStoppedContainer(c *check.C) {
  10. out, _ := dockerCmd(c, "run", "--name", "first_name", "-d", "busybox", "sh")
  11. cleanedContainerID := strings.TrimSpace(out)
  12. dockerCmd(c, "wait", cleanedContainerID)
  13. name := inspectField(c, cleanedContainerID, "Name")
  14. newName := "new_name" + stringid.GenerateNonCryptoID()
  15. dockerCmd(c, "rename", "first_name", newName)
  16. name = inspectField(c, cleanedContainerID, "Name")
  17. c.Assert(name, checker.Equals, "/"+newName, check.Commentf("Failed to rename container %s", name))
  18. }
  19. func (s *DockerSuite) TestRenameRunningContainer(c *check.C) {
  20. out, _ := dockerCmd(c, "run", "--name", "first_name", "-d", "busybox", "sh")
  21. newName := "new_name" + stringid.GenerateNonCryptoID()
  22. cleanedContainerID := strings.TrimSpace(out)
  23. dockerCmd(c, "rename", "first_name", newName)
  24. name := inspectField(c, cleanedContainerID, "Name")
  25. c.Assert(name, checker.Equals, "/"+newName, check.Commentf("Failed to rename container %s", name))
  26. }
  27. func (s *DockerSuite) TestRenameRunningContainerAndReuse(c *check.C) {
  28. out := runSleepingContainer(c, "--name", "first_name")
  29. c.Assert(waitRun("first_name"), check.IsNil)
  30. newName := "new_name"
  31. ContainerID := strings.TrimSpace(out)
  32. dockerCmd(c, "rename", "first_name", newName)
  33. name := inspectField(c, ContainerID, "Name")
  34. c.Assert(name, checker.Equals, "/"+newName, check.Commentf("Failed to rename container"))
  35. out = runSleepingContainer(c, "--name", "first_name")
  36. c.Assert(waitRun("first_name"), check.IsNil)
  37. newContainerID := strings.TrimSpace(out)
  38. name = inspectField(c, newContainerID, "Name")
  39. c.Assert(name, checker.Equals, "/first_name", check.Commentf("Failed to reuse container name"))
  40. }
  41. func (s *DockerSuite) TestRenameCheckNames(c *check.C) {
  42. dockerCmd(c, "run", "--name", "first_name", "-d", "busybox", "sh")
  43. newName := "new_name" + stringid.GenerateNonCryptoID()
  44. dockerCmd(c, "rename", "first_name", newName)
  45. name := inspectField(c, newName, "Name")
  46. c.Assert(name, checker.Equals, "/"+newName, check.Commentf("Failed to rename container %s", name))
  47. result := dockerCmdWithResult("inspect", "-f={{.Name}}", "--type=container", "first_name")
  48. result.Assert(c, icmd.Expected{
  49. ExitCode: 1,
  50. Err: "No such container: first_name",
  51. })
  52. }
  53. // TODO: move to unit test
  54. func (s *DockerSuite) TestRenameInvalidName(c *check.C) {
  55. runSleepingContainer(c, "--name", "myname")
  56. out, _, err := dockerCmdWithError("rename", "myname", "new:invalid")
  57. c.Assert(err, checker.NotNil, check.Commentf("Renaming container to invalid name should have failed: %s", out))
  58. c.Assert(out, checker.Contains, "Invalid container name", check.Commentf("%v", err))
  59. out, _ = dockerCmd(c, "ps", "-a")
  60. c.Assert(out, checker.Contains, "myname", check.Commentf("Output of docker ps should have included 'myname': %s", out))
  61. }
  62. func (s *DockerSuite) TestRenameAnonymousContainer(c *check.C) {
  63. testRequires(c, DaemonIsLinux)
  64. dockerCmd(c, "network", "create", "network1")
  65. out, _ := dockerCmd(c, "create", "-it", "--net", "network1", "busybox", "top")
  66. anonymousContainerID := strings.TrimSpace(out)
  67. dockerCmd(c, "rename", anonymousContainerID, "container1")
  68. dockerCmd(c, "start", "container1")
  69. count := "-c"
  70. if testEnv.DaemonPlatform() == "windows" {
  71. count = "-n"
  72. }
  73. _, _, err := dockerCmdWithError("run", "--net", "network1", "busybox", "ping", count, "1", "container1")
  74. c.Assert(err, check.IsNil, check.Commentf("Embedded DNS lookup fails after renaming anonymous container: %v", err))
  75. }
  76. func (s *DockerSuite) TestRenameContainerWithSameName(c *check.C) {
  77. out := runSleepingContainer(c, "--name", "old")
  78. ContainerID := strings.TrimSpace(out)
  79. out, _, err := dockerCmdWithError("rename", "old", "old")
  80. c.Assert(err, checker.NotNil, check.Commentf("Renaming a container with the same name should have failed"))
  81. c.Assert(out, checker.Contains, "Renaming a container with the same name", check.Commentf("%v", err))
  82. out, _, err = dockerCmdWithError("rename", ContainerID, "old")
  83. c.Assert(err, checker.NotNil, check.Commentf("Renaming a container with the same name should have failed"))
  84. c.Assert(out, checker.Contains, "Renaming a container with the same name", check.Commentf("%v", err))
  85. }
  86. // Test case for #23973
  87. func (s *DockerSuite) TestRenameContainerWithLinkedContainer(c *check.C) {
  88. testRequires(c, DaemonIsLinux)
  89. db1, _ := dockerCmd(c, "run", "--name", "db1", "-d", "busybox", "top")
  90. dockerCmd(c, "run", "--name", "app1", "-d", "--link", "db1:/mysql", "busybox", "top")
  91. dockerCmd(c, "rename", "app1", "app2")
  92. out, _, err := dockerCmdWithError("inspect", "--format={{ .Id }}", "app2/mysql")
  93. c.Assert(err, checker.IsNil)
  94. c.Assert(strings.TrimSpace(out), checker.Equals, strings.TrimSpace(db1))
  95. }