docker_cli_build_test.go 71 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740174117421743174417451746174717481749175017511752175317541755175617571758175917601761176217631764176517661767176817691770177117721773177417751776177717781779178017811782178317841785178617871788178917901791179217931794179517961797179817991800180118021803180418051806180718081809181018111812181318141815181618171818181918201821182218231824182518261827182818291830183118321833183418351836183718381839184018411842184318441845184618471848184918501851185218531854185518561857185818591860186118621863186418651866186718681869187018711872187318741875187618771878187918801881188218831884188518861887188818891890189118921893189418951896189718981899190019011902190319041905190619071908190919101911191219131914191519161917191819191920192119221923192419251926192719281929193019311932193319341935193619371938193919401941194219431944194519461947194819491950195119521953195419551956195719581959196019611962196319641965196619671968196919701971197219731974197519761977197819791980198119821983198419851986198719881989199019911992199319941995199619971998199920002001200220032004200520062007200820092010201120122013201420152016201720182019202020212022202320242025202620272028202920302031203220332034203520362037203820392040204120422043204420452046204720482049205020512052205320542055205620572058205920602061206220632064206520662067206820692070207120722073207420752076207720782079208020812082208320842085208620872088208920902091209220932094209520962097209820992100210121022103210421052106210721082109211021112112211321142115211621172118211921202121212221232124212521262127212821292130213121322133213421352136213721382139214021412142214321442145214621472148214921502151215221532154215521562157215821592160216121622163216421652166216721682169217021712172217321742175217621772178217921802181218221832184218521862187218821892190219121922193219421952196219721982199220022012202220322042205220622072208220922102211221222132214221522162217221822192220222122222223222422252226222722282229223022312232223322342235223622372238223922402241224222432244224522462247224822492250225122522253225422552256225722582259226022612262226322642265226622672268226922702271227222732274227522762277227822792280228122822283228422852286228722882289229022912292229322942295229622972298229923002301230223032304230523062307230823092310231123122313231423152316231723182319232023212322232323242325232623272328232923302331233223332334233523362337233823392340234123422343234423452346234723482349235023512352235323542355235623572358235923602361236223632364236523662367236823692370237123722373237423752376237723782379238023812382238323842385238623872388238923902391239223932394239523962397239823992400240124022403240424052406240724082409241024112412241324142415241624172418241924202421242224232424242524262427242824292430243124322433243424352436243724382439244024412442244324442445244624472448244924502451245224532454245524562457245824592460246124622463246424652466246724682469247024712472247324742475247624772478247924802481248224832484248524862487248824892490249124922493249424952496249724982499250025012502250325042505250625072508250925102511251225132514251525162517251825192520252125222523252425252526252725282529253025312532253325342535253625372538253925402541254225432544254525462547254825492550255125522553255425552556255725582559256025612562256325642565256625672568256925702571257225732574257525762577257825792580258125822583258425852586258725882589259025912592259325942595259625972598259926002601260226032604260526062607260826092610261126122613261426152616261726182619262026212622262326242625262626272628262926302631263226332634263526362637263826392640264126422643264426452646264726482649265026512652265326542655265626572658265926602661266226632664266526662667266826692670267126722673267426752676267726782679268026812682268326842685268626872688268926902691269226932694269526962697269826992700270127022703270427052706270727082709271027112712
  1. package main
  2. import (
  3. "archive/tar"
  4. "fmt"
  5. "io/ioutil"
  6. "os"
  7. "os/exec"
  8. "path/filepath"
  9. "regexp"
  10. "strings"
  11. "testing"
  12. "time"
  13. "github.com/docker/docker/pkg/archive"
  14. )
  15. func TestBuildOnBuildForbiddenMaintainerInSourceImage(t *testing.T) {
  16. name := "testbuildonbuildforbiddenmaintainerinsourceimage"
  17. defer deleteImages(name)
  18. createCmd := exec.Command(dockerBinary, "create", "busybox", "true")
  19. out, _, _, err := runCommandWithStdoutStderr(createCmd)
  20. errorOut(err, t, out)
  21. cleanedContainerID := stripTrailingCharacters(out)
  22. commitCmd := exec.Command(dockerBinary, "commit", "--run", "{\"OnBuild\":[\"MAINTAINER docker.io\"]}", cleanedContainerID, "onbuild")
  23. if _, err := runCommand(commitCmd); err != nil {
  24. t.Fatal(err)
  25. }
  26. _, err = buildImage(name,
  27. `FROM onbuild`,
  28. true)
  29. if err != nil {
  30. if !strings.Contains(err.Error(), "maintainer isn't allowed as an ONBUILD trigger") {
  31. t.Fatalf("Wrong error %v, must be about MAINTAINER and ONBUILD in source image", err)
  32. }
  33. } else {
  34. t.Fatal("Error must not be nil")
  35. }
  36. logDone("build - onbuild forbidden maintainer in source image")
  37. }
  38. func TestBuildOnBuildForbiddenFromInSourceImage(t *testing.T) {
  39. name := "testbuildonbuildforbiddenfrominsourceimage"
  40. defer deleteImages(name)
  41. createCmd := exec.Command(dockerBinary, "create", "busybox", "true")
  42. out, _, _, err := runCommandWithStdoutStderr(createCmd)
  43. errorOut(err, t, out)
  44. cleanedContainerID := stripTrailingCharacters(out)
  45. commitCmd := exec.Command(dockerBinary, "commit", "--run", "{\"OnBuild\":[\"FROM busybox\"]}", cleanedContainerID, "onbuild")
  46. if _, err := runCommand(commitCmd); err != nil {
  47. t.Fatal(err)
  48. }
  49. _, err = buildImage(name,
  50. `FROM onbuild`,
  51. true)
  52. if err != nil {
  53. if !strings.Contains(err.Error(), "from isn't allowed as an ONBUILD trigger") {
  54. t.Fatalf("Wrong error %v, must be about FROM and ONBUILD in source image", err)
  55. }
  56. } else {
  57. t.Fatal("Error must not be nil")
  58. }
  59. logDone("build - onbuild forbidden from in source image")
  60. }
  61. func TestBuildOnBuildForbiddenChainedInSourceImage(t *testing.T) {
  62. name := "testbuildonbuildforbiddenchainedinsourceimage"
  63. defer deleteImages(name)
  64. createCmd := exec.Command(dockerBinary, "create", "busybox", "true")
  65. out, _, _, err := runCommandWithStdoutStderr(createCmd)
  66. errorOut(err, t, out)
  67. cleanedContainerID := stripTrailingCharacters(out)
  68. commitCmd := exec.Command(dockerBinary, "commit", "--run", "{\"OnBuild\":[\"ONBUILD RUN ls\"]}", cleanedContainerID, "onbuild")
  69. if _, err := runCommand(commitCmd); err != nil {
  70. t.Fatal(err)
  71. }
  72. _, err = buildImage(name,
  73. `FROM onbuild`,
  74. true)
  75. if err != nil {
  76. if !strings.Contains(err.Error(), "Chaining ONBUILD via `ONBUILD ONBUILD` isn't allowed") {
  77. t.Fatalf("Wrong error %v, must be about chaining ONBUILD in source image", err)
  78. }
  79. } else {
  80. t.Fatal("Error must not be nil")
  81. }
  82. logDone("build - onbuild forbidden chained in source image")
  83. }
  84. func TestBuildOnBuildCmdEntrypointJSON(t *testing.T) {
  85. name1 := "onbuildcmd"
  86. name2 := "onbuildgenerated"
  87. defer deleteAllContainers()
  88. defer deleteImages(name2)
  89. defer deleteImages(name1)
  90. _, err := buildImage(name1, `
  91. FROM busybox
  92. ONBUILD CMD ["hello world"]
  93. ONBUILD ENTRYPOINT ["echo"]
  94. ONBUILD RUN ["true"]`,
  95. false)
  96. if err != nil {
  97. t.Fatal(err)
  98. }
  99. _, err = buildImage(name2, fmt.Sprintf(`FROM %s`, name1), false)
  100. if err != nil {
  101. t.Fatal(err)
  102. }
  103. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "-t", name2))
  104. if err != nil {
  105. t.Fatal(err)
  106. }
  107. if !regexp.MustCompile(`(?m)^hello world`).MatchString(out) {
  108. t.Fatal("did not get echo output from onbuild", out)
  109. }
  110. logDone("build - onbuild with json entrypoint/cmd")
  111. }
  112. func TestBuildOnBuildEntrypointJSON(t *testing.T) {
  113. name1 := "onbuildcmd"
  114. name2 := "onbuildgenerated"
  115. defer deleteAllContainers()
  116. defer deleteImages(name2)
  117. defer deleteImages(name1)
  118. _, err := buildImage(name1, `
  119. FROM busybox
  120. ONBUILD ENTRYPOINT ["echo"]`,
  121. false)
  122. if err != nil {
  123. t.Fatal(err)
  124. }
  125. _, err = buildImage(name2, fmt.Sprintf("FROM %s\nCMD [\"hello world\"]\n", name1), false)
  126. if err != nil {
  127. t.Fatal(err)
  128. }
  129. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "-t", name2))
  130. if err != nil {
  131. t.Fatal(err)
  132. }
  133. if !regexp.MustCompile(`(?m)^hello world`).MatchString(out) {
  134. t.Fatal("got malformed output from onbuild", out)
  135. }
  136. logDone("build - onbuild with json entrypoint")
  137. }
  138. func TestBuildCacheADD(t *testing.T) {
  139. name := "testbuildtwoimageswithadd"
  140. defer deleteImages(name)
  141. server, err := fakeStorage(map[string]string{
  142. "robots.txt": "hello",
  143. "index.html": "world",
  144. })
  145. if err != nil {
  146. t.Fatal(err)
  147. }
  148. defer server.Close()
  149. if _, err := buildImage(name,
  150. fmt.Sprintf(`FROM scratch
  151. ADD %s/robots.txt /`, server.URL),
  152. true); err != nil {
  153. t.Fatal(err)
  154. }
  155. _, out, err := buildImageWithOut(name,
  156. fmt.Sprintf(`FROM scratch
  157. ADD %s/index.html /`, server.URL),
  158. true)
  159. if err != nil {
  160. t.Fatal(err)
  161. }
  162. if strings.Contains(out, "Using cache") {
  163. t.Fatal("2nd build used cache on ADD, it shouldn't")
  164. }
  165. logDone("build - build two images with remote ADD")
  166. }
  167. func TestBuildSixtySteps(t *testing.T) {
  168. name := "foobuildsixtysteps"
  169. defer deleteImages(name)
  170. ctx, err := fakeContext("FROM scratch\n"+strings.Repeat("ADD foo /\n", 60),
  171. map[string]string{
  172. "foo": "test1",
  173. })
  174. if err != nil {
  175. t.Fatal(err)
  176. }
  177. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  178. t.Fatal(err)
  179. }
  180. logDone("build - build an image with sixty build steps")
  181. }
  182. func TestBuildAddSingleFileToRoot(t *testing.T) {
  183. name := "testaddimg"
  184. defer deleteImages(name)
  185. ctx, err := fakeContext(`FROM busybox
  186. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  187. RUN echo 'dockerio:x:1001:' >> /etc/group
  188. RUN touch /exists
  189. RUN chown dockerio.dockerio /exists
  190. ADD test_file /
  191. RUN [ $(ls -l /test_file | awk '{print $3":"$4}') = 'root:root' ]
  192. RUN [ $(ls -l /test_file | awk '{print $1}') = '-rw-r--r--' ]
  193. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  194. map[string]string{
  195. "test_file": "test1",
  196. })
  197. if err != nil {
  198. t.Fatal(err)
  199. }
  200. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  201. t.Fatal(err)
  202. }
  203. logDone("build - add single file to root")
  204. }
  205. // Issue #3960: "ADD src ." hangs
  206. func TestBuildAddSingleFileToWorkdir(t *testing.T) {
  207. name := "testaddsinglefiletoworkdir"
  208. defer deleteImages(name)
  209. ctx, err := fakeContext(`FROM busybox
  210. ADD test_file .`,
  211. map[string]string{
  212. "test_file": "test1",
  213. })
  214. if err != nil {
  215. t.Fatal(err)
  216. }
  217. done := make(chan struct{})
  218. go func() {
  219. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  220. t.Fatal(err)
  221. }
  222. close(done)
  223. }()
  224. select {
  225. case <-time.After(5 * time.Second):
  226. t.Fatal("Build with adding to workdir timed out")
  227. case <-done:
  228. }
  229. logDone("build - add single file to workdir")
  230. }
  231. func TestBuildAddSingleFileToExistDir(t *testing.T) {
  232. name := "testaddsinglefiletoexistdir"
  233. defer deleteImages(name)
  234. ctx, err := fakeContext(`FROM busybox
  235. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  236. RUN echo 'dockerio:x:1001:' >> /etc/group
  237. RUN mkdir /exists
  238. RUN touch /exists/exists_file
  239. RUN chown -R dockerio.dockerio /exists
  240. ADD test_file /exists/
  241. RUN [ $(ls -l / | grep exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]
  242. RUN [ $(ls -l /exists/test_file | awk '{print $3":"$4}') = 'root:root' ]
  243. RUN [ $(ls -l /exists/exists_file | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  244. map[string]string{
  245. "test_file": "test1",
  246. })
  247. if err != nil {
  248. t.Fatal(err)
  249. }
  250. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  251. t.Fatal(err)
  252. }
  253. logDone("build - add single file to existing dir")
  254. }
  255. func TestBuildCopyAddMultipleFiles(t *testing.T) {
  256. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
  257. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testaddimg", "MultipleFiles")
  258. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  259. if err != nil || exitCode != 0 {
  260. t.Fatal("failed to build the image")
  261. }
  262. deleteImages("testaddimg")
  263. logDone("build - mulitple file copy/add tests")
  264. }
  265. func TestBuildAddMultipleFilesToFile(t *testing.T) {
  266. name := "testaddmultiplefilestofile"
  267. defer deleteImages(name)
  268. ctx, err := fakeContext(`FROM scratch
  269. ADD file1.txt file2.txt test
  270. `,
  271. map[string]string{
  272. "file1.txt": "test1",
  273. "file2.txt": "test1",
  274. })
  275. defer ctx.Close()
  276. if err != nil {
  277. t.Fatal(err)
  278. }
  279. expected := "When using ADD with more than one source file, the destination must be a directory and end with a /"
  280. if _, err := buildImageFromContext(name, ctx, true); err == nil || !strings.Contains(err.Error(), expected) {
  281. t.Fatalf("Wrong error: (should contain \"%s\") got:\n%v", expected, err)
  282. }
  283. logDone("build - multiple add files to file")
  284. }
  285. func TestBuildAddMultipleFilesToFileWild(t *testing.T) {
  286. name := "testaddmultiplefilestofilewild"
  287. defer deleteImages(name)
  288. ctx, err := fakeContext(`FROM scratch
  289. ADD file*.txt test
  290. `,
  291. map[string]string{
  292. "file1.txt": "test1",
  293. "file2.txt": "test1",
  294. })
  295. defer ctx.Close()
  296. if err != nil {
  297. t.Fatal(err)
  298. }
  299. expected := "When using ADD with more than one source file, the destination must be a directory and end with a /"
  300. if _, err := buildImageFromContext(name, ctx, true); err == nil || !strings.Contains(err.Error(), expected) {
  301. t.Fatalf("Wrong error: (should contain \"%s\") got:\n%v", expected, err)
  302. }
  303. logDone("build - multiple add files to file wild")
  304. }
  305. func TestBuildCopyMultipleFilesToFile(t *testing.T) {
  306. name := "testcopymultiplefilestofile"
  307. defer deleteImages(name)
  308. ctx, err := fakeContext(`FROM scratch
  309. COPY file1.txt file2.txt test
  310. `,
  311. map[string]string{
  312. "file1.txt": "test1",
  313. "file2.txt": "test1",
  314. })
  315. defer ctx.Close()
  316. if err != nil {
  317. t.Fatal(err)
  318. }
  319. expected := "When using COPY with more than one source file, the destination must be a directory and end with a /"
  320. if _, err := buildImageFromContext(name, ctx, true); err == nil || !strings.Contains(err.Error(), expected) {
  321. t.Fatalf("Wrong error: (should contain \"%s\") got:\n%v", expected, err)
  322. }
  323. logDone("build - multiple copy files to file")
  324. }
  325. func TestBuildCopyWildcard(t *testing.T) {
  326. name := "testcopywildcard"
  327. defer deleteImages(name)
  328. server, err := fakeStorage(map[string]string{
  329. "robots.txt": "hello",
  330. "index.html": "world",
  331. })
  332. if err != nil {
  333. t.Fatal(err)
  334. }
  335. defer server.Close()
  336. ctx, err := fakeContext(fmt.Sprintf(`FROM busybox
  337. COPY file*.txt /tmp/
  338. RUN ls /tmp/file1.txt /tmp/file2.txt
  339. RUN mkdir /tmp1
  340. COPY dir* /tmp1/
  341. RUN ls /tmp1/dirt /tmp1/nested_file /tmp1/nested_dir/nest_nest_file
  342. RUN mkdir /tmp2
  343. ADD dir/*dir %s/robots.txt /tmp2/
  344. RUN ls /tmp2/nest_nest_file /tmp2/robots.txt
  345. `, server.URL),
  346. map[string]string{
  347. "file1.txt": "test1",
  348. "file2.txt": "test2",
  349. "dir/nested_file": "nested file",
  350. "dir/nested_dir/nest_nest_file": "2 times nested",
  351. "dirt": "dirty",
  352. })
  353. defer ctx.Close()
  354. if err != nil {
  355. t.Fatal(err)
  356. }
  357. id1, err := buildImageFromContext(name, ctx, true)
  358. if err != nil {
  359. t.Fatal(err)
  360. }
  361. // Now make sure we use a cache the 2nd time
  362. id2, err := buildImageFromContext(name, ctx, true)
  363. if err != nil {
  364. t.Fatal(err)
  365. }
  366. if id1 != id2 {
  367. t.Fatal("didn't use the cache")
  368. }
  369. logDone("build - copy wild card")
  370. }
  371. func TestBuildCopyWildcardNoFind(t *testing.T) {
  372. name := "testcopywildcardnofind"
  373. defer deleteImages(name)
  374. ctx, err := fakeContext(`FROM busybox
  375. COPY file*.txt /tmp/
  376. `, nil)
  377. defer ctx.Close()
  378. if err != nil {
  379. t.Fatal(err)
  380. }
  381. _, err = buildImageFromContext(name, ctx, true)
  382. if err == nil {
  383. t.Fatal("should have failed to find a file")
  384. }
  385. if !strings.Contains(err.Error(), "No source files were specified") {
  386. t.Fatalf("Wrong error %v, must be about no source files", err)
  387. }
  388. logDone("build - copy wild card no find")
  389. }
  390. func TestBuildCopyWildcardCache(t *testing.T) {
  391. name := "testcopywildcardcache"
  392. defer deleteImages(name)
  393. ctx, err := fakeContext(`FROM busybox
  394. COPY file1.txt /tmp/`,
  395. map[string]string{
  396. "file1.txt": "test1",
  397. })
  398. defer ctx.Close()
  399. if err != nil {
  400. t.Fatal(err)
  401. }
  402. id1, err := buildImageFromContext(name, ctx, true)
  403. if err != nil {
  404. t.Fatal(err)
  405. }
  406. // Now make sure we use a cache the 2nd time even with wild cards.
  407. // Use the same context so the file is the same and the checksum will match
  408. ctx.Add("Dockerfile", `FROM busybox
  409. COPY file*.txt /tmp/`)
  410. id2, err := buildImageFromContext(name, ctx, true)
  411. if err != nil {
  412. t.Fatal(err)
  413. }
  414. if id1 != id2 {
  415. t.Fatal("didn't use the cache")
  416. }
  417. logDone("build - copy wild card cache")
  418. }
  419. func TestBuildAddSingleFileToNonExistDir(t *testing.T) {
  420. name := "testaddsinglefiletononexistdir"
  421. defer deleteImages(name)
  422. ctx, err := fakeContext(`FROM busybox
  423. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  424. RUN echo 'dockerio:x:1001:' >> /etc/group
  425. RUN touch /exists
  426. RUN chown dockerio.dockerio /exists
  427. ADD test_file /test_dir/
  428. RUN [ $(ls -l / | grep test_dir | awk '{print $3":"$4}') = 'root:root' ]
  429. RUN [ $(ls -l /test_dir/test_file | awk '{print $3":"$4}') = 'root:root' ]
  430. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  431. map[string]string{
  432. "test_file": "test1",
  433. })
  434. if err != nil {
  435. t.Fatal(err)
  436. }
  437. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  438. t.Fatal(err)
  439. }
  440. }
  441. func TestBuildAddDirContentToRoot(t *testing.T) {
  442. name := "testadddircontenttoroot"
  443. defer deleteImages(name)
  444. ctx, err := fakeContext(`FROM busybox
  445. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  446. RUN echo 'dockerio:x:1001:' >> /etc/group
  447. RUN touch /exists
  448. RUN chown dockerio.dockerio exists
  449. ADD test_dir /
  450. RUN [ $(ls -l /test_file | awk '{print $3":"$4}') = 'root:root' ]
  451. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  452. map[string]string{
  453. "test_dir/test_file": "test1",
  454. })
  455. if err != nil {
  456. t.Fatal(err)
  457. }
  458. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  459. t.Fatal(err)
  460. }
  461. logDone("build - add directory contents to root")
  462. }
  463. func TestBuildAddDirContentToExistDir(t *testing.T) {
  464. name := "testadddircontenttoexistdir"
  465. defer deleteImages(name)
  466. ctx, err := fakeContext(`FROM busybox
  467. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  468. RUN echo 'dockerio:x:1001:' >> /etc/group
  469. RUN mkdir /exists
  470. RUN touch /exists/exists_file
  471. RUN chown -R dockerio.dockerio /exists
  472. ADD test_dir/ /exists/
  473. RUN [ $(ls -l / | grep exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]
  474. RUN [ $(ls -l /exists/exists_file | awk '{print $3":"$4}') = 'dockerio:dockerio' ]
  475. RUN [ $(ls -l /exists/test_file | awk '{print $3":"$4}') = 'root:root' ]`,
  476. map[string]string{
  477. "test_dir/test_file": "test1",
  478. })
  479. if err != nil {
  480. t.Fatal(err)
  481. }
  482. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  483. t.Fatal(err)
  484. }
  485. logDone("build - add directory contents to existing dir")
  486. }
  487. func TestBuildAddWholeDirToRoot(t *testing.T) {
  488. name := "testaddwholedirtoroot"
  489. defer deleteImages(name)
  490. ctx, err := fakeContext(`FROM busybox
  491. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  492. RUN echo 'dockerio:x:1001:' >> /etc/group
  493. RUN touch /exists
  494. RUN chown dockerio.dockerio exists
  495. ADD test_dir /test_dir
  496. RUN [ $(ls -l / | grep test_dir | awk '{print $3":"$4}') = 'root:root' ]
  497. RUN [ $(ls -l / | grep test_dir | awk '{print $1}') = 'drwxr-xr-x' ]
  498. RUN [ $(ls -l /test_dir/test_file | awk '{print $3":"$4}') = 'root:root' ]
  499. RUN [ $(ls -l /test_dir/test_file | awk '{print $1}') = '-rw-r--r--' ]
  500. RUN [ $(ls -l /exists | awk '{print $3":"$4}') = 'dockerio:dockerio' ]`,
  501. map[string]string{
  502. "test_dir/test_file": "test1",
  503. })
  504. if err != nil {
  505. t.Fatal(err)
  506. }
  507. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  508. t.Fatal(err)
  509. }
  510. logDone("build - add whole directory to root")
  511. }
  512. // Testing #5941
  513. func TestBuildAddEtcToRoot(t *testing.T) {
  514. name := "testaddetctoroot"
  515. defer deleteImages(name)
  516. ctx, err := fakeContext(`FROM scratch
  517. ADD . /`,
  518. map[string]string{
  519. "etc/test_file": "test1",
  520. })
  521. if err != nil {
  522. t.Fatal(err)
  523. }
  524. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  525. t.Fatal(err)
  526. }
  527. logDone("build - add etc directory to root")
  528. }
  529. func TestBuildCopySingleFileToRoot(t *testing.T) {
  530. testDirName := "SingleFileToRoot"
  531. sourceDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy", testDirName)
  532. buildDirectory, err := ioutil.TempDir("", "test-build-add")
  533. defer os.RemoveAll(buildDirectory)
  534. err = copyWithCP(sourceDirectory, buildDirectory)
  535. if err != nil {
  536. t.Fatalf("failed to copy files to temporary directory: %s", err)
  537. }
  538. buildDirectory = filepath.Join(buildDirectory, testDirName)
  539. f, err := os.OpenFile(filepath.Join(buildDirectory, "test_file"), os.O_CREATE, 0644)
  540. if err != nil {
  541. t.Fatal(err)
  542. }
  543. f.Close()
  544. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", ".")
  545. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  546. if err != nil || exitCode != 0 {
  547. t.Fatal("failed to build the image")
  548. }
  549. deleteImages("testcopyimg")
  550. logDone("build - copy single file to root")
  551. }
  552. // Issue #3960: "ADD src ." hangs - adapted for COPY
  553. func TestBuildCopySingleFileToWorkdir(t *testing.T) {
  554. testDirName := "SingleFileToWorkdir"
  555. sourceDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy", testDirName)
  556. buildDirectory, err := ioutil.TempDir("", "test-build-add")
  557. defer os.RemoveAll(buildDirectory)
  558. err = copyWithCP(sourceDirectory, buildDirectory)
  559. if err != nil {
  560. t.Fatalf("failed to copy files to temporary directory: %s", err)
  561. }
  562. buildDirectory = filepath.Join(buildDirectory, testDirName)
  563. f, err := os.OpenFile(filepath.Join(buildDirectory, "test_file"), os.O_CREATE, 0644)
  564. if err != nil {
  565. t.Fatal(err)
  566. }
  567. f.Close()
  568. _, exitCode, err := dockerCmdInDirWithTimeout(5*time.Second, buildDirectory, "build", "-t", "testcopyimg", ".")
  569. if err != nil || exitCode != 0 {
  570. t.Fatalf("build failed: %s", err)
  571. }
  572. deleteImages("testcopyimg")
  573. logDone("build - copy single file to workdir")
  574. }
  575. func TestBuildCopySingleFileToExistDir(t *testing.T) {
  576. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
  577. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", "SingleFileToExistDir")
  578. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  579. if err != nil || exitCode != 0 {
  580. t.Fatal("failed to build the image")
  581. }
  582. deleteImages("testcopyimg")
  583. logDone("build - copy single file to existing dir")
  584. }
  585. func TestBuildCopySingleFileToNonExistDir(t *testing.T) {
  586. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
  587. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", "SingleFileToNonExistDir")
  588. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  589. if err != nil || exitCode != 0 {
  590. t.Fatal("failed to build the image")
  591. }
  592. deleteImages("testcopyimg")
  593. logDone("build - copy single file to non-existing dir")
  594. }
  595. func TestBuildCopyDirContentToRoot(t *testing.T) {
  596. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
  597. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", "DirContentToRoot")
  598. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  599. if err != nil || exitCode != 0 {
  600. t.Fatal("failed to build the image")
  601. }
  602. deleteImages("testcopyimg")
  603. logDone("build - copy directory contents to root")
  604. }
  605. func TestBuildCopyDirContentToExistDir(t *testing.T) {
  606. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
  607. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", "DirContentToExistDir")
  608. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  609. if err != nil || exitCode != 0 {
  610. t.Fatal("failed to build the image")
  611. }
  612. deleteImages("testcopyimg")
  613. logDone("build - copy directory contents to existing dir")
  614. }
  615. func TestBuildCopyWholeDirToRoot(t *testing.T) {
  616. testDirName := "WholeDirToRoot"
  617. sourceDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy", testDirName)
  618. buildDirectory, err := ioutil.TempDir("", "test-build-add")
  619. defer os.RemoveAll(buildDirectory)
  620. err = copyWithCP(sourceDirectory, buildDirectory)
  621. if err != nil {
  622. t.Fatalf("failed to copy files to temporary directory: %s", err)
  623. }
  624. buildDirectory = filepath.Join(buildDirectory, testDirName)
  625. testDir := filepath.Join(buildDirectory, "test_dir")
  626. if err := os.MkdirAll(testDir, 0755); err != nil {
  627. t.Fatal(err)
  628. }
  629. f, err := os.OpenFile(filepath.Join(testDir, "test_file"), os.O_CREATE, 0644)
  630. if err != nil {
  631. t.Fatal(err)
  632. }
  633. f.Close()
  634. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", ".")
  635. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  636. if err != nil || exitCode != 0 {
  637. t.Fatal("failed to build the image")
  638. }
  639. deleteImages("testcopyimg")
  640. logDone("build - copy whole directory to root")
  641. }
  642. func TestBuildCopyEtcToRoot(t *testing.T) {
  643. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
  644. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", "EtcToRoot")
  645. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  646. if err != nil || exitCode != 0 {
  647. t.Fatal("failed to build the image")
  648. }
  649. deleteImages("testcopyimg")
  650. logDone("build - copy etc directory to root")
  651. }
  652. func TestBuildCopyDisallowRemote(t *testing.T) {
  653. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
  654. buildCmd := exec.Command(dockerBinary, "build", "-t", "testcopyimg", "DisallowRemote")
  655. buildCmd.Dir = buildDirectory
  656. out, exitCode, err := runCommandWithOutput(buildCmd)
  657. if err == nil || exitCode == 0 {
  658. t.Fatalf("building the image should've failed; output: %s", out)
  659. }
  660. deleteImages("testcopyimg")
  661. logDone("build - copy - disallow copy from remote")
  662. }
  663. // Issue #5270 - ensure we throw a better error than "unexpected EOF"
  664. // when we can't access files in the context.
  665. func TestBuildWithInaccessibleFilesInContext(t *testing.T) {
  666. {
  667. name := "testbuildinaccessiblefiles"
  668. defer deleteImages(name)
  669. ctx, err := fakeContext("FROM scratch\nADD . /foo/", map[string]string{"fileWithoutReadAccess": "foo"})
  670. if err != nil {
  671. t.Fatal(err)
  672. }
  673. defer ctx.Close()
  674. // This is used to ensure we detect inaccessible files early during build in the cli client
  675. pathToFileWithoutReadAccess := filepath.Join(ctx.Dir, "fileWithoutReadAccess")
  676. err = os.Chown(pathToFileWithoutReadAccess, 0, 0)
  677. errorOut(err, t, fmt.Sprintf("failed to chown file to root: %s", err))
  678. err = os.Chmod(pathToFileWithoutReadAccess, 0700)
  679. errorOut(err, t, fmt.Sprintf("failed to chmod file to 700: %s", err))
  680. buildCmd := exec.Command("su", "unprivilegeduser", "-c", fmt.Sprintf("%s build -t %s .", dockerBinary, name))
  681. buildCmd.Dir = ctx.Dir
  682. out, exitCode, err := runCommandWithOutput(buildCmd)
  683. if err == nil || exitCode == 0 {
  684. t.Fatalf("build should have failed: %s %s", err, out)
  685. }
  686. // check if we've detected the failure before we started building
  687. if !strings.Contains(out, "no permission to read from ") {
  688. t.Fatalf("output should've contained the string: no permission to read from but contained: %s", out)
  689. }
  690. if !strings.Contains(out, "Error checking context is accessible") {
  691. t.Fatalf("output should've contained the string: Error checking context is accessible")
  692. }
  693. }
  694. {
  695. name := "testbuildinaccessibledirectory"
  696. defer deleteImages(name)
  697. ctx, err := fakeContext("FROM scratch\nADD . /foo/", map[string]string{"directoryWeCantStat/bar": "foo"})
  698. if err != nil {
  699. t.Fatal(err)
  700. }
  701. defer ctx.Close()
  702. // This is used to ensure we detect inaccessible directories early during build in the cli client
  703. pathToDirectoryWithoutReadAccess := filepath.Join(ctx.Dir, "directoryWeCantStat")
  704. pathToFileInDirectoryWithoutReadAccess := filepath.Join(pathToDirectoryWithoutReadAccess, "bar")
  705. err = os.Chown(pathToDirectoryWithoutReadAccess, 0, 0)
  706. errorOut(err, t, fmt.Sprintf("failed to chown directory to root: %s", err))
  707. err = os.Chmod(pathToDirectoryWithoutReadAccess, 0444)
  708. errorOut(err, t, fmt.Sprintf("failed to chmod directory to 755: %s", err))
  709. err = os.Chmod(pathToFileInDirectoryWithoutReadAccess, 0700)
  710. errorOut(err, t, fmt.Sprintf("failed to chmod file to 444: %s", err))
  711. buildCmd := exec.Command("su", "unprivilegeduser", "-c", fmt.Sprintf("%s build -t %s .", dockerBinary, name))
  712. buildCmd.Dir = ctx.Dir
  713. out, exitCode, err := runCommandWithOutput(buildCmd)
  714. if err == nil || exitCode == 0 {
  715. t.Fatalf("build should have failed: %s %s", err, out)
  716. }
  717. // check if we've detected the failure before we started building
  718. if !strings.Contains(out, "can't stat") {
  719. t.Fatalf("output should've contained the string: can't access %s", out)
  720. }
  721. if !strings.Contains(out, "Error checking context is accessible") {
  722. t.Fatalf("output should've contained the string: Error checking context is accessible")
  723. }
  724. }
  725. {
  726. name := "testlinksok"
  727. defer deleteImages(name)
  728. ctx, err := fakeContext("FROM scratch\nADD . /foo/", nil)
  729. if err != nil {
  730. t.Fatal(err)
  731. }
  732. defer ctx.Close()
  733. if err := os.Symlink(filepath.Join(ctx.Dir, "g"), "../../../../../../../../../../../../../../../../../../../azA"); err != nil {
  734. t.Fatal(err)
  735. }
  736. // This is used to ensure we don't follow links when checking if everything in the context is accessible
  737. // This test doesn't require that we run commands as an unprivileged user
  738. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  739. t.Fatal(err)
  740. }
  741. }
  742. {
  743. name := "testbuildignoredinaccessible"
  744. defer deleteImages(name)
  745. ctx, err := fakeContext("FROM scratch\nADD . /foo/",
  746. map[string]string{
  747. "directoryWeCantStat/bar": "foo",
  748. ".dockerignore": "directoryWeCantStat",
  749. })
  750. if err != nil {
  751. t.Fatal(err)
  752. }
  753. defer ctx.Close()
  754. // This is used to ensure we don't try to add inaccessible files when they are ignored by a .dockerignore pattern
  755. pathToDirectoryWithoutReadAccess := filepath.Join(ctx.Dir, "directoryWeCantStat")
  756. pathToFileInDirectoryWithoutReadAccess := filepath.Join(pathToDirectoryWithoutReadAccess, "bar")
  757. err = os.Chown(pathToDirectoryWithoutReadAccess, 0, 0)
  758. errorOut(err, t, fmt.Sprintf("failed to chown directory to root: %s", err))
  759. err = os.Chmod(pathToDirectoryWithoutReadAccess, 0444)
  760. errorOut(err, t, fmt.Sprintf("failed to chmod directory to 755: %s", err))
  761. err = os.Chmod(pathToFileInDirectoryWithoutReadAccess, 0700)
  762. errorOut(err, t, fmt.Sprintf("failed to chmod file to 444: %s", err))
  763. buildCmd := exec.Command("su", "unprivilegeduser", "-c", fmt.Sprintf("%s build -t %s .", dockerBinary, name))
  764. buildCmd.Dir = ctx.Dir
  765. out, exitCode, err := runCommandWithOutput(buildCmd)
  766. if err != nil || exitCode != 0 {
  767. t.Fatalf("build should have worked: %s %s", err, out)
  768. }
  769. }
  770. logDone("build - ADD from context with inaccessible files must fail")
  771. logDone("build - ADD from context with accessible links must work")
  772. logDone("build - ADD from context with ignored inaccessible files must work")
  773. }
  774. func TestBuildForceRm(t *testing.T) {
  775. containerCountBefore, err := getContainerCount()
  776. if err != nil {
  777. t.Fatalf("failed to get the container count: %s", err)
  778. }
  779. name := "testbuildforcerm"
  780. defer deleteImages(name)
  781. ctx, err := fakeContext("FROM scratch\nRUN true\nRUN thiswillfail", nil)
  782. if err != nil {
  783. t.Fatal(err)
  784. }
  785. defer ctx.Close()
  786. buildCmd := exec.Command(dockerBinary, "build", "-t", name, "--force-rm", ".")
  787. buildCmd.Dir = ctx.Dir
  788. _, exitCode, err := runCommandWithOutput(buildCmd)
  789. if err == nil || exitCode == 0 {
  790. t.Fatal("failed to build the image")
  791. }
  792. containerCountAfter, err := getContainerCount()
  793. if err != nil {
  794. t.Fatalf("failed to get the container count: %s", err)
  795. }
  796. if containerCountBefore != containerCountAfter {
  797. t.Fatalf("--force-rm shouldn't have left containers behind")
  798. }
  799. logDone("build - ensure --force-rm doesn't leave containers behind")
  800. }
  801. func TestBuildRm(t *testing.T) {
  802. name := "testbuildrm"
  803. defer deleteImages(name)
  804. ctx, err := fakeContext("FROM scratch\nADD foo /\nADD foo /", map[string]string{"foo": "bar"})
  805. if err != nil {
  806. t.Fatal(err)
  807. }
  808. defer ctx.Close()
  809. {
  810. containerCountBefore, err := getContainerCount()
  811. if err != nil {
  812. t.Fatalf("failed to get the container count: %s", err)
  813. }
  814. out, exitCode, err := dockerCmdInDir(t, ctx.Dir, "build", "--rm", "-t", name, ".")
  815. if err != nil || exitCode != 0 {
  816. t.Fatal("failed to build the image", out)
  817. }
  818. containerCountAfter, err := getContainerCount()
  819. if err != nil {
  820. t.Fatalf("failed to get the container count: %s", err)
  821. }
  822. if containerCountBefore != containerCountAfter {
  823. t.Fatalf("-rm shouldn't have left containers behind")
  824. }
  825. deleteImages(name)
  826. }
  827. {
  828. containerCountBefore, err := getContainerCount()
  829. if err != nil {
  830. t.Fatalf("failed to get the container count: %s", err)
  831. }
  832. out, exitCode, err := dockerCmdInDir(t, ctx.Dir, "build", "-t", name, ".")
  833. if err != nil || exitCode != 0 {
  834. t.Fatal("failed to build the image", out)
  835. }
  836. containerCountAfter, err := getContainerCount()
  837. if err != nil {
  838. t.Fatalf("failed to get the container count: %s", err)
  839. }
  840. if containerCountBefore != containerCountAfter {
  841. t.Fatalf("--rm shouldn't have left containers behind")
  842. }
  843. deleteImages(name)
  844. }
  845. {
  846. containerCountBefore, err := getContainerCount()
  847. if err != nil {
  848. t.Fatalf("failed to get the container count: %s", err)
  849. }
  850. out, exitCode, err := dockerCmdInDir(t, ctx.Dir, "build", "--rm=false", "-t", name, ".")
  851. if err != nil || exitCode != 0 {
  852. t.Fatal("failed to build the image", out)
  853. }
  854. containerCountAfter, err := getContainerCount()
  855. if err != nil {
  856. t.Fatalf("failed to get the container count: %s", err)
  857. }
  858. if containerCountBefore == containerCountAfter {
  859. t.Fatalf("--rm=false should have left containers behind")
  860. }
  861. deleteAllContainers()
  862. deleteImages(name)
  863. }
  864. logDone("build - ensure --rm doesn't leave containers behind and that --rm=true is the default")
  865. logDone("build - ensure --rm=false overrides the default")
  866. }
  867. func TestBuildWithVolumes(t *testing.T) {
  868. var (
  869. result map[string]map[string]struct{}
  870. name = "testbuildvolumes"
  871. emptyMap = make(map[string]struct{})
  872. expected = map[string]map[string]struct{}{
  873. "/test1": emptyMap,
  874. "/test2": emptyMap,
  875. "/test3": emptyMap,
  876. "/test4": emptyMap,
  877. "/test5": emptyMap,
  878. "/test6": emptyMap,
  879. "[/test7": emptyMap,
  880. "/test8]": emptyMap,
  881. }
  882. )
  883. defer deleteImages(name)
  884. _, err := buildImage(name,
  885. `FROM scratch
  886. VOLUME /test1
  887. VOLUME /test2
  888. VOLUME /test3 /test4
  889. VOLUME ["/test5", "/test6"]
  890. VOLUME [/test7 /test8]
  891. `,
  892. true)
  893. if err != nil {
  894. t.Fatal(err)
  895. }
  896. res, err := inspectFieldJSON(name, "Config.Volumes")
  897. if err != nil {
  898. t.Fatal(err)
  899. }
  900. err = unmarshalJSON([]byte(res), &result)
  901. if err != nil {
  902. t.Fatal(err)
  903. }
  904. equal := deepEqual(&expected, &result)
  905. if !equal {
  906. t.Fatalf("Volumes %s, expected %s", result, expected)
  907. }
  908. logDone("build - with volumes")
  909. }
  910. func TestBuildMaintainer(t *testing.T) {
  911. name := "testbuildmaintainer"
  912. expected := "dockerio"
  913. defer deleteImages(name)
  914. _, err := buildImage(name,
  915. `FROM scratch
  916. MAINTAINER dockerio`,
  917. true)
  918. if err != nil {
  919. t.Fatal(err)
  920. }
  921. res, err := inspectField(name, "Author")
  922. if err != nil {
  923. t.Fatal(err)
  924. }
  925. if res != expected {
  926. t.Fatalf("Maintainer %s, expected %s", res, expected)
  927. }
  928. logDone("build - maintainer")
  929. }
  930. func TestBuildUser(t *testing.T) {
  931. name := "testbuilduser"
  932. expected := "dockerio"
  933. defer deleteImages(name)
  934. _, err := buildImage(name,
  935. `FROM busybox
  936. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  937. USER dockerio
  938. RUN [ $(whoami) = 'dockerio' ]`,
  939. true)
  940. if err != nil {
  941. t.Fatal(err)
  942. }
  943. res, err := inspectField(name, "Config.User")
  944. if err != nil {
  945. t.Fatal(err)
  946. }
  947. if res != expected {
  948. t.Fatalf("User %s, expected %s", res, expected)
  949. }
  950. logDone("build - user")
  951. }
  952. func TestBuildRelativeWorkdir(t *testing.T) {
  953. name := "testbuildrelativeworkdir"
  954. expected := "/test2/test3"
  955. defer deleteImages(name)
  956. _, err := buildImage(name,
  957. `FROM busybox
  958. RUN [ "$PWD" = '/' ]
  959. WORKDIR test1
  960. RUN [ "$PWD" = '/test1' ]
  961. WORKDIR /test2
  962. RUN [ "$PWD" = '/test2' ]
  963. WORKDIR test3
  964. RUN [ "$PWD" = '/test2/test3' ]`,
  965. true)
  966. if err != nil {
  967. t.Fatal(err)
  968. }
  969. res, err := inspectField(name, "Config.WorkingDir")
  970. if err != nil {
  971. t.Fatal(err)
  972. }
  973. if res != expected {
  974. t.Fatalf("Workdir %s, expected %s", res, expected)
  975. }
  976. logDone("build - relative workdir")
  977. }
  978. func TestBuildWorkdirWithEnvVariables(t *testing.T) {
  979. name := "testbuildworkdirwithenvvariables"
  980. expected := "/test1/test2/$MISSING_VAR"
  981. defer deleteImages(name)
  982. _, err := buildImage(name,
  983. `FROM busybox
  984. ENV DIRPATH /test1
  985. ENV SUBDIRNAME test2
  986. WORKDIR $DIRPATH
  987. WORKDIR $SUBDIRNAME/$MISSING_VAR`,
  988. true)
  989. if err != nil {
  990. t.Fatal(err)
  991. }
  992. res, err := inspectField(name, "Config.WorkingDir")
  993. if err != nil {
  994. t.Fatal(err)
  995. }
  996. if res != expected {
  997. t.Fatalf("Workdir %s, expected %s", res, expected)
  998. }
  999. logDone("build - workdir with env variables")
  1000. }
  1001. func TestBuildEnv(t *testing.T) {
  1002. name := "testbuildenv"
  1003. expected := "[PATH=/test:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PORT=2375]"
  1004. defer deleteImages(name)
  1005. _, err := buildImage(name,
  1006. `FROM busybox
  1007. ENV PATH /test:$PATH
  1008. ENV PORT 2375
  1009. RUN [ $(env | grep PORT) = 'PORT=2375' ]`,
  1010. true)
  1011. if err != nil {
  1012. t.Fatal(err)
  1013. }
  1014. res, err := inspectField(name, "Config.Env")
  1015. if err != nil {
  1016. t.Fatal(err)
  1017. }
  1018. if res != expected {
  1019. t.Fatalf("Env %s, expected %s", res, expected)
  1020. }
  1021. logDone("build - env")
  1022. }
  1023. func TestBuildContextCleanup(t *testing.T) {
  1024. name := "testbuildcontextcleanup"
  1025. defer deleteImages(name)
  1026. entries, err := ioutil.ReadDir("/var/lib/docker/tmp")
  1027. if err != nil {
  1028. t.Fatalf("failed to list contents of tmp dir: %s", err)
  1029. }
  1030. _, err = buildImage(name,
  1031. `FROM scratch
  1032. ENTRYPOINT ["/bin/echo"]`,
  1033. true)
  1034. if err != nil {
  1035. t.Fatal(err)
  1036. }
  1037. entriesFinal, err := ioutil.ReadDir("/var/lib/docker/tmp")
  1038. if err != nil {
  1039. t.Fatalf("failed to list contents of tmp dir: %s", err)
  1040. }
  1041. if err = compareDirectoryEntries(entries, entriesFinal); err != nil {
  1042. t.Fatalf("context should have been deleted, but wasn't")
  1043. }
  1044. logDone("build - verify context cleanup works properly")
  1045. }
  1046. func TestBuildContextCleanupFailedBuild(t *testing.T) {
  1047. name := "testbuildcontextcleanup"
  1048. defer deleteImages(name)
  1049. entries, err := ioutil.ReadDir("/var/lib/docker/tmp")
  1050. if err != nil {
  1051. t.Fatalf("failed to list contents of tmp dir: %s", err)
  1052. }
  1053. _, err = buildImage(name,
  1054. `FROM scratch
  1055. RUN /non/existing/command`,
  1056. true)
  1057. if err == nil {
  1058. t.Fatalf("expected build to fail, but it didn't")
  1059. }
  1060. entriesFinal, err := ioutil.ReadDir("/var/lib/docker/tmp")
  1061. if err != nil {
  1062. t.Fatalf("failed to list contents of tmp dir: %s", err)
  1063. }
  1064. if err = compareDirectoryEntries(entries, entriesFinal); err != nil {
  1065. t.Fatalf("context should have been deleted, but wasn't")
  1066. }
  1067. logDone("build - verify context cleanup works properly after a failed build")
  1068. }
  1069. func TestBuildCmd(t *testing.T) {
  1070. name := "testbuildcmd"
  1071. expected := "[/bin/echo Hello World]"
  1072. defer deleteImages(name)
  1073. _, err := buildImage(name,
  1074. `FROM scratch
  1075. CMD ["/bin/echo", "Hello World"]`,
  1076. true)
  1077. if err != nil {
  1078. t.Fatal(err)
  1079. }
  1080. res, err := inspectField(name, "Config.Cmd")
  1081. if err != nil {
  1082. t.Fatal(err)
  1083. }
  1084. if res != expected {
  1085. t.Fatalf("Cmd %s, expected %s", res, expected)
  1086. }
  1087. logDone("build - cmd")
  1088. }
  1089. func TestBuildExpose(t *testing.T) {
  1090. name := "testbuildexpose"
  1091. expected := "map[2375/tcp:map[]]"
  1092. defer deleteImages(name)
  1093. _, err := buildImage(name,
  1094. `FROM scratch
  1095. EXPOSE 2375`,
  1096. true)
  1097. if err != nil {
  1098. t.Fatal(err)
  1099. }
  1100. res, err := inspectField(name, "Config.ExposedPorts")
  1101. if err != nil {
  1102. t.Fatal(err)
  1103. }
  1104. if res != expected {
  1105. t.Fatalf("Exposed ports %s, expected %s", res, expected)
  1106. }
  1107. logDone("build - expose")
  1108. }
  1109. func TestBuildEmptyEntrypoint(t *testing.T) {
  1110. name := "testbuildentrypoint"
  1111. defer deleteImages(name)
  1112. expected := "[]"
  1113. _, err := buildImage(name,
  1114. `FROM busybox
  1115. ENTRYPOINT []`,
  1116. true)
  1117. if err != nil {
  1118. t.Fatal(err)
  1119. }
  1120. res, err := inspectField(name, "Config.Entrypoint")
  1121. if err != nil {
  1122. t.Fatal(err)
  1123. }
  1124. if res != expected {
  1125. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  1126. }
  1127. logDone("build - empty entrypoint")
  1128. }
  1129. func TestBuildEntrypoint(t *testing.T) {
  1130. name := "testbuildentrypoint"
  1131. expected := "[/bin/echo]"
  1132. defer deleteImages(name)
  1133. _, err := buildImage(name,
  1134. `FROM scratch
  1135. ENTRYPOINT ["/bin/echo"]`,
  1136. true)
  1137. if err != nil {
  1138. t.Fatal(err)
  1139. }
  1140. res, err := inspectField(name, "Config.Entrypoint")
  1141. if err != nil {
  1142. t.Fatal(err)
  1143. }
  1144. if res != expected {
  1145. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  1146. }
  1147. logDone("build - entrypoint")
  1148. }
  1149. // #6445 ensure ONBUILD triggers aren't committed to grandchildren
  1150. func TestBuildOnBuildLimitedInheritence(t *testing.T) {
  1151. var (
  1152. out2, out3 string
  1153. )
  1154. {
  1155. name1 := "testonbuildtrigger1"
  1156. dockerfile1 := `
  1157. FROM busybox
  1158. RUN echo "GRANDPARENT"
  1159. ONBUILD RUN echo "ONBUILD PARENT"
  1160. `
  1161. ctx, err := fakeContext(dockerfile1, nil)
  1162. if err != nil {
  1163. t.Fatal(err)
  1164. }
  1165. out1, _, err := dockerCmdInDir(t, ctx.Dir, "build", "-t", name1, ".")
  1166. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out1, err))
  1167. defer deleteImages(name1)
  1168. }
  1169. {
  1170. name2 := "testonbuildtrigger2"
  1171. dockerfile2 := `
  1172. FROM testonbuildtrigger1
  1173. `
  1174. ctx, err := fakeContext(dockerfile2, nil)
  1175. if err != nil {
  1176. t.Fatal(err)
  1177. }
  1178. out2, _, err = dockerCmdInDir(t, ctx.Dir, "build", "-t", name2, ".")
  1179. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out2, err))
  1180. defer deleteImages(name2)
  1181. }
  1182. {
  1183. name3 := "testonbuildtrigger3"
  1184. dockerfile3 := `
  1185. FROM testonbuildtrigger2
  1186. `
  1187. ctx, err := fakeContext(dockerfile3, nil)
  1188. if err != nil {
  1189. t.Fatal(err)
  1190. }
  1191. out3, _, err = dockerCmdInDir(t, ctx.Dir, "build", "-t", name3, ".")
  1192. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out3, err))
  1193. defer deleteImages(name3)
  1194. }
  1195. // ONBUILD should be run in second build.
  1196. if !strings.Contains(out2, "ONBUILD PARENT") {
  1197. t.Fatalf("ONBUILD instruction did not run in child of ONBUILD parent")
  1198. }
  1199. // ONBUILD should *not* be run in third build.
  1200. if strings.Contains(out3, "ONBUILD PARENT") {
  1201. t.Fatalf("ONBUILD instruction ran in grandchild of ONBUILD parent")
  1202. }
  1203. logDone("build - onbuild")
  1204. }
  1205. func TestBuildWithCache(t *testing.T) {
  1206. name := "testbuildwithcache"
  1207. defer deleteImages(name)
  1208. id1, err := buildImage(name,
  1209. `FROM scratch
  1210. MAINTAINER dockerio
  1211. EXPOSE 5432
  1212. ENTRYPOINT ["/bin/echo"]`,
  1213. true)
  1214. if err != nil {
  1215. t.Fatal(err)
  1216. }
  1217. id2, err := buildImage(name,
  1218. `FROM scratch
  1219. MAINTAINER dockerio
  1220. EXPOSE 5432
  1221. ENTRYPOINT ["/bin/echo"]`,
  1222. true)
  1223. if err != nil {
  1224. t.Fatal(err)
  1225. }
  1226. if id1 != id2 {
  1227. t.Fatal("The cache should have been used but hasn't.")
  1228. }
  1229. logDone("build - with cache")
  1230. }
  1231. func TestBuildWithoutCache(t *testing.T) {
  1232. name := "testbuildwithoutcache"
  1233. defer deleteImages(name)
  1234. id1, err := buildImage(name,
  1235. `FROM scratch
  1236. MAINTAINER dockerio
  1237. EXPOSE 5432
  1238. ENTRYPOINT ["/bin/echo"]`,
  1239. true)
  1240. if err != nil {
  1241. t.Fatal(err)
  1242. }
  1243. id2, err := buildImage(name,
  1244. `FROM scratch
  1245. MAINTAINER dockerio
  1246. EXPOSE 5432
  1247. ENTRYPOINT ["/bin/echo"]`,
  1248. false)
  1249. if err != nil {
  1250. t.Fatal(err)
  1251. }
  1252. if id1 == id2 {
  1253. t.Fatal("The cache should have been invalided but hasn't.")
  1254. }
  1255. logDone("build - without cache")
  1256. }
  1257. func TestBuildADDLocalFileWithCache(t *testing.T) {
  1258. name := "testbuildaddlocalfilewithcache"
  1259. defer deleteImages(name)
  1260. dockerfile := `
  1261. FROM busybox
  1262. MAINTAINER dockerio
  1263. ADD foo /usr/lib/bla/bar
  1264. RUN [ "$(cat /usr/lib/bla/bar)" = "hello" ]`
  1265. ctx, err := fakeContext(dockerfile, map[string]string{
  1266. "foo": "hello",
  1267. })
  1268. defer ctx.Close()
  1269. if err != nil {
  1270. t.Fatal(err)
  1271. }
  1272. id1, err := buildImageFromContext(name, ctx, true)
  1273. if err != nil {
  1274. t.Fatal(err)
  1275. }
  1276. id2, err := buildImageFromContext(name, ctx, true)
  1277. if err != nil {
  1278. t.Fatal(err)
  1279. }
  1280. if id1 != id2 {
  1281. t.Fatal("The cache should have been used but hasn't.")
  1282. }
  1283. logDone("build - add local file with cache")
  1284. }
  1285. func TestBuildADDMultipleLocalFileWithCache(t *testing.T) {
  1286. name := "testbuildaddmultiplelocalfilewithcache"
  1287. defer deleteImages(name)
  1288. dockerfile := `
  1289. FROM busybox
  1290. MAINTAINER dockerio
  1291. ADD foo Dockerfile /usr/lib/bla/
  1292. RUN [ "$(cat /usr/lib/bla/foo)" = "hello" ]`
  1293. ctx, err := fakeContext(dockerfile, map[string]string{
  1294. "foo": "hello",
  1295. })
  1296. defer ctx.Close()
  1297. if err != nil {
  1298. t.Fatal(err)
  1299. }
  1300. id1, err := buildImageFromContext(name, ctx, true)
  1301. if err != nil {
  1302. t.Fatal(err)
  1303. }
  1304. id2, err := buildImageFromContext(name, ctx, true)
  1305. if err != nil {
  1306. t.Fatal(err)
  1307. }
  1308. if id1 != id2 {
  1309. t.Fatal("The cache should have been used but hasn't.")
  1310. }
  1311. logDone("build - add multiple local files with cache")
  1312. }
  1313. func TestBuildADDLocalFileWithoutCache(t *testing.T) {
  1314. name := "testbuildaddlocalfilewithoutcache"
  1315. defer deleteImages(name)
  1316. dockerfile := `
  1317. FROM busybox
  1318. MAINTAINER dockerio
  1319. ADD foo /usr/lib/bla/bar
  1320. RUN [ "$(cat /usr/lib/bla/bar)" = "hello" ]`
  1321. ctx, err := fakeContext(dockerfile, map[string]string{
  1322. "foo": "hello",
  1323. })
  1324. defer ctx.Close()
  1325. if err != nil {
  1326. t.Fatal(err)
  1327. }
  1328. id1, err := buildImageFromContext(name, ctx, true)
  1329. if err != nil {
  1330. t.Fatal(err)
  1331. }
  1332. id2, err := buildImageFromContext(name, ctx, false)
  1333. if err != nil {
  1334. t.Fatal(err)
  1335. }
  1336. if id1 == id2 {
  1337. t.Fatal("The cache should have been invalided but hasn't.")
  1338. }
  1339. logDone("build - add local file without cache")
  1340. }
  1341. func TestBuildCopyDirButNotFile(t *testing.T) {
  1342. name := "testbuildcopydirbutnotfile"
  1343. defer deleteImages(name)
  1344. dockerfile := `
  1345. FROM scratch
  1346. COPY dir /tmp/`
  1347. ctx, err := fakeContext(dockerfile, map[string]string{
  1348. "dir/foo": "hello",
  1349. })
  1350. defer ctx.Close()
  1351. if err != nil {
  1352. t.Fatal(err)
  1353. }
  1354. id1, err := buildImageFromContext(name, ctx, true)
  1355. if err != nil {
  1356. t.Fatal(err)
  1357. }
  1358. // Check that adding file with similar name doesn't mess with cache
  1359. if err := ctx.Add("dir_file", "hello2"); err != nil {
  1360. t.Fatal(err)
  1361. }
  1362. id2, err := buildImageFromContext(name, ctx, true)
  1363. if err != nil {
  1364. t.Fatal(err)
  1365. }
  1366. if id1 != id2 {
  1367. t.Fatal("The cache should have been used but wasn't")
  1368. }
  1369. logDone("build - add current directory but not file")
  1370. }
  1371. func TestBuildADDCurrentDirWithCache(t *testing.T) {
  1372. name := "testbuildaddcurrentdirwithcache"
  1373. defer deleteImages(name)
  1374. dockerfile := `
  1375. FROM scratch
  1376. MAINTAINER dockerio
  1377. ADD . /usr/lib/bla`
  1378. ctx, err := fakeContext(dockerfile, map[string]string{
  1379. "foo": "hello",
  1380. })
  1381. defer ctx.Close()
  1382. if err != nil {
  1383. t.Fatal(err)
  1384. }
  1385. id1, err := buildImageFromContext(name, ctx, true)
  1386. if err != nil {
  1387. t.Fatal(err)
  1388. }
  1389. // Check that adding file invalidate cache of "ADD ."
  1390. if err := ctx.Add("bar", "hello2"); err != nil {
  1391. t.Fatal(err)
  1392. }
  1393. id2, err := buildImageFromContext(name, ctx, true)
  1394. if err != nil {
  1395. t.Fatal(err)
  1396. }
  1397. if id1 == id2 {
  1398. t.Fatal("The cache should have been invalided but hasn't.")
  1399. }
  1400. // Check that changing file invalidate cache of "ADD ."
  1401. if err := ctx.Add("foo", "hello1"); err != nil {
  1402. t.Fatal(err)
  1403. }
  1404. id3, err := buildImageFromContext(name, ctx, true)
  1405. if err != nil {
  1406. t.Fatal(err)
  1407. }
  1408. if id2 == id3 {
  1409. t.Fatal("The cache should have been invalided but hasn't.")
  1410. }
  1411. // Check that changing file to same content invalidate cache of "ADD ."
  1412. time.Sleep(1 * time.Second) // wait second because of mtime precision
  1413. if err := ctx.Add("foo", "hello1"); err != nil {
  1414. t.Fatal(err)
  1415. }
  1416. id4, err := buildImageFromContext(name, ctx, true)
  1417. if err != nil {
  1418. t.Fatal(err)
  1419. }
  1420. if id3 == id4 {
  1421. t.Fatal("The cache should have been invalided but hasn't.")
  1422. }
  1423. id5, err := buildImageFromContext(name, ctx, true)
  1424. if err != nil {
  1425. t.Fatal(err)
  1426. }
  1427. if id4 != id5 {
  1428. t.Fatal("The cache should have been used but hasn't.")
  1429. }
  1430. logDone("build - add current directory with cache")
  1431. }
  1432. func TestBuildADDCurrentDirWithoutCache(t *testing.T) {
  1433. name := "testbuildaddcurrentdirwithoutcache"
  1434. defer deleteImages(name)
  1435. dockerfile := `
  1436. FROM scratch
  1437. MAINTAINER dockerio
  1438. ADD . /usr/lib/bla`
  1439. ctx, err := fakeContext(dockerfile, map[string]string{
  1440. "foo": "hello",
  1441. })
  1442. defer ctx.Close()
  1443. if err != nil {
  1444. t.Fatal(err)
  1445. }
  1446. id1, err := buildImageFromContext(name, ctx, true)
  1447. if err != nil {
  1448. t.Fatal(err)
  1449. }
  1450. id2, err := buildImageFromContext(name, ctx, false)
  1451. if err != nil {
  1452. t.Fatal(err)
  1453. }
  1454. if id1 == id2 {
  1455. t.Fatal("The cache should have been invalided but hasn't.")
  1456. }
  1457. logDone("build - add current directory without cache")
  1458. }
  1459. func TestBuildADDRemoteFileWithCache(t *testing.T) {
  1460. name := "testbuildaddremotefilewithcache"
  1461. defer deleteImages(name)
  1462. server, err := fakeStorage(map[string]string{
  1463. "baz": "hello",
  1464. })
  1465. if err != nil {
  1466. t.Fatal(err)
  1467. }
  1468. defer server.Close()
  1469. id1, err := buildImage(name,
  1470. fmt.Sprintf(`FROM scratch
  1471. MAINTAINER dockerio
  1472. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  1473. true)
  1474. if err != nil {
  1475. t.Fatal(err)
  1476. }
  1477. id2, err := buildImage(name,
  1478. fmt.Sprintf(`FROM scratch
  1479. MAINTAINER dockerio
  1480. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  1481. true)
  1482. if err != nil {
  1483. t.Fatal(err)
  1484. }
  1485. if id1 != id2 {
  1486. t.Fatal("The cache should have been used but hasn't.")
  1487. }
  1488. logDone("build - add remote file with cache")
  1489. }
  1490. func TestBuildADDRemoteFileWithoutCache(t *testing.T) {
  1491. name := "testbuildaddremotefilewithoutcache"
  1492. defer deleteImages(name)
  1493. server, err := fakeStorage(map[string]string{
  1494. "baz": "hello",
  1495. })
  1496. if err != nil {
  1497. t.Fatal(err)
  1498. }
  1499. defer server.Close()
  1500. id1, err := buildImage(name,
  1501. fmt.Sprintf(`FROM scratch
  1502. MAINTAINER dockerio
  1503. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  1504. true)
  1505. if err != nil {
  1506. t.Fatal(err)
  1507. }
  1508. id2, err := buildImage(name,
  1509. fmt.Sprintf(`FROM scratch
  1510. MAINTAINER dockerio
  1511. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  1512. false)
  1513. if err != nil {
  1514. t.Fatal(err)
  1515. }
  1516. if id1 == id2 {
  1517. t.Fatal("The cache should have been invalided but hasn't.")
  1518. }
  1519. logDone("build - add remote file without cache")
  1520. }
  1521. func TestBuildADDLocalAndRemoteFilesWithCache(t *testing.T) {
  1522. name := "testbuildaddlocalandremotefilewithcache"
  1523. defer deleteImages(name)
  1524. server, err := fakeStorage(map[string]string{
  1525. "baz": "hello",
  1526. })
  1527. if err != nil {
  1528. t.Fatal(err)
  1529. }
  1530. defer server.Close()
  1531. ctx, err := fakeContext(fmt.Sprintf(`FROM scratch
  1532. MAINTAINER dockerio
  1533. ADD foo /usr/lib/bla/bar
  1534. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  1535. map[string]string{
  1536. "foo": "hello world",
  1537. })
  1538. if err != nil {
  1539. t.Fatal(err)
  1540. }
  1541. defer ctx.Close()
  1542. id1, err := buildImageFromContext(name, ctx, true)
  1543. if err != nil {
  1544. t.Fatal(err)
  1545. }
  1546. id2, err := buildImageFromContext(name, ctx, true)
  1547. if err != nil {
  1548. t.Fatal(err)
  1549. }
  1550. if id1 != id2 {
  1551. t.Fatal("The cache should have been used but hasn't.")
  1552. }
  1553. logDone("build - add local and remote file with cache")
  1554. }
  1555. func testContextTar(t *testing.T, compression archive.Compression) {
  1556. ctx, err := fakeContext(
  1557. `FROM busybox
  1558. ADD foo /foo
  1559. CMD ["cat", "/foo"]`,
  1560. map[string]string{
  1561. "foo": "bar",
  1562. },
  1563. )
  1564. defer ctx.Close()
  1565. if err != nil {
  1566. t.Fatal(err)
  1567. }
  1568. context, err := archive.Tar(ctx.Dir, compression)
  1569. if err != nil {
  1570. t.Fatalf("failed to build context tar: %v", err)
  1571. }
  1572. name := "contexttar"
  1573. buildCmd := exec.Command(dockerBinary, "build", "-t", name, "-")
  1574. defer deleteImages(name)
  1575. buildCmd.Stdin = context
  1576. out, exitCode, err := runCommandWithOutput(buildCmd)
  1577. if err != nil || exitCode != 0 {
  1578. t.Fatalf("build failed to complete: %v %v", out, err)
  1579. }
  1580. logDone(fmt.Sprintf("build - build an image with a context tar, compression: %v", compression))
  1581. }
  1582. func TestBuildContextTarGzip(t *testing.T) {
  1583. testContextTar(t, archive.Gzip)
  1584. }
  1585. func TestBuildContextTarNoCompression(t *testing.T) {
  1586. testContextTar(t, archive.Uncompressed)
  1587. }
  1588. func TestBuildNoContext(t *testing.T) {
  1589. buildCmd := exec.Command(dockerBinary, "build", "-t", "nocontext", "-")
  1590. buildCmd.Stdin = strings.NewReader("FROM busybox\nCMD echo ok\n")
  1591. out, exitCode, err := runCommandWithOutput(buildCmd)
  1592. if err != nil || exitCode != 0 {
  1593. t.Fatalf("build failed to complete: %v %v", out, err)
  1594. }
  1595. out, exitCode, err = cmd(t, "run", "nocontext")
  1596. if out != "ok\n" {
  1597. t.Fatalf("run produced invalid output: %q, expected %q", out, "ok")
  1598. }
  1599. deleteImages("nocontext")
  1600. logDone("build - build an image with no context")
  1601. }
  1602. // TODO: TestCaching
  1603. func TestBuildADDLocalAndRemoteFilesWithoutCache(t *testing.T) {
  1604. name := "testbuildaddlocalandremotefilewithoutcache"
  1605. defer deleteImages(name)
  1606. server, err := fakeStorage(map[string]string{
  1607. "baz": "hello",
  1608. })
  1609. if err != nil {
  1610. t.Fatal(err)
  1611. }
  1612. defer server.Close()
  1613. ctx, err := fakeContext(fmt.Sprintf(`FROM scratch
  1614. MAINTAINER dockerio
  1615. ADD foo /usr/lib/bla/bar
  1616. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  1617. map[string]string{
  1618. "foo": "hello world",
  1619. })
  1620. if err != nil {
  1621. t.Fatal(err)
  1622. }
  1623. defer ctx.Close()
  1624. id1, err := buildImageFromContext(name, ctx, true)
  1625. if err != nil {
  1626. t.Fatal(err)
  1627. }
  1628. id2, err := buildImageFromContext(name, ctx, false)
  1629. if err != nil {
  1630. t.Fatal(err)
  1631. }
  1632. if id1 == id2 {
  1633. t.Fatal("The cache should have been invalided but hasn't.")
  1634. }
  1635. logDone("build - add local and remote file without cache")
  1636. }
  1637. func TestBuildWithVolumeOwnership(t *testing.T) {
  1638. name := "testbuildimg"
  1639. defer deleteImages(name)
  1640. _, err := buildImage(name,
  1641. `FROM busybox:latest
  1642. RUN mkdir /test && chown daemon:daemon /test && chmod 0600 /test
  1643. VOLUME /test`,
  1644. true)
  1645. if err != nil {
  1646. t.Fatal(err)
  1647. }
  1648. cmd := exec.Command(dockerBinary, "run", "--rm", "testbuildimg", "ls", "-la", "/test")
  1649. out, _, err := runCommandWithOutput(cmd)
  1650. if err != nil {
  1651. t.Fatal(out, err)
  1652. }
  1653. if expected := "drw-------"; !strings.Contains(out, expected) {
  1654. t.Fatalf("expected %s received %s", expected, out)
  1655. }
  1656. if expected := "daemon daemon"; !strings.Contains(out, expected) {
  1657. t.Fatalf("expected %s received %s", expected, out)
  1658. }
  1659. logDone("build - volume ownership")
  1660. }
  1661. // testing #1405 - config.Cmd does not get cleaned up if
  1662. // utilizing cache
  1663. func TestBuildEntrypointRunCleanup(t *testing.T) {
  1664. name := "testbuildcmdcleanup"
  1665. defer deleteImages(name)
  1666. if _, err := buildImage(name,
  1667. `FROM busybox
  1668. RUN echo "hello"`,
  1669. true); err != nil {
  1670. t.Fatal(err)
  1671. }
  1672. ctx, err := fakeContext(`FROM busybox
  1673. RUN echo "hello"
  1674. ADD foo /foo
  1675. ENTRYPOINT ["/bin/echo"]`,
  1676. map[string]string{
  1677. "foo": "hello",
  1678. })
  1679. defer ctx.Close()
  1680. if err != nil {
  1681. t.Fatal(err)
  1682. }
  1683. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1684. t.Fatal(err)
  1685. }
  1686. res, err := inspectField(name, "Config.Cmd")
  1687. if err != nil {
  1688. t.Fatal(err)
  1689. }
  1690. // Cmd must be cleaned up
  1691. if expected := "<no value>"; res != expected {
  1692. t.Fatalf("Cmd %s, expected %s", res, expected)
  1693. }
  1694. logDone("build - cleanup cmd after RUN")
  1695. }
  1696. func TestBuildForbiddenContextPath(t *testing.T) {
  1697. name := "testbuildforbidpath"
  1698. defer deleteImages(name)
  1699. ctx, err := fakeContext(`FROM scratch
  1700. ADD ../../ test/
  1701. `,
  1702. map[string]string{
  1703. "test.txt": "test1",
  1704. "other.txt": "other",
  1705. })
  1706. defer ctx.Close()
  1707. if err != nil {
  1708. t.Fatal(err)
  1709. }
  1710. expected := "Forbidden path outside the build context: ../../ "
  1711. if _, err := buildImageFromContext(name, ctx, true); err == nil || !strings.Contains(err.Error(), expected) {
  1712. t.Fatalf("Wrong error: (should contain \"%s\") got:\n%v", expected, err)
  1713. }
  1714. logDone("build - forbidden context path")
  1715. }
  1716. func TestBuildADDFileNotFound(t *testing.T) {
  1717. name := "testbuildaddnotfound"
  1718. defer deleteImages(name)
  1719. ctx, err := fakeContext(`FROM scratch
  1720. ADD foo /usr/local/bar`,
  1721. map[string]string{"bar": "hello"})
  1722. defer ctx.Close()
  1723. if err != nil {
  1724. t.Fatal(err)
  1725. }
  1726. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1727. if !strings.Contains(err.Error(), "foo: no such file or directory") {
  1728. t.Fatalf("Wrong error %v, must be about missing foo file or directory", err)
  1729. }
  1730. } else {
  1731. t.Fatal("Error must not be nil")
  1732. }
  1733. logDone("build - add file not found")
  1734. }
  1735. func TestBuildInheritance(t *testing.T) {
  1736. name := "testbuildinheritance"
  1737. defer deleteImages(name)
  1738. _, err := buildImage(name,
  1739. `FROM scratch
  1740. EXPOSE 2375`,
  1741. true)
  1742. if err != nil {
  1743. t.Fatal(err)
  1744. }
  1745. ports1, err := inspectField(name, "Config.ExposedPorts")
  1746. if err != nil {
  1747. t.Fatal(err)
  1748. }
  1749. _, err = buildImage(name,
  1750. fmt.Sprintf(`FROM %s
  1751. ENTRYPOINT ["/bin/echo"]`, name),
  1752. true)
  1753. if err != nil {
  1754. t.Fatal(err)
  1755. }
  1756. res, err := inspectField(name, "Config.Entrypoint")
  1757. if err != nil {
  1758. t.Fatal(err)
  1759. }
  1760. if expected := "[/bin/echo]"; res != expected {
  1761. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  1762. }
  1763. ports2, err := inspectField(name, "Config.ExposedPorts")
  1764. if err != nil {
  1765. t.Fatal(err)
  1766. }
  1767. if ports1 != ports2 {
  1768. t.Fatalf("Ports must be same: %s != %s", ports1, ports2)
  1769. }
  1770. logDone("build - inheritance")
  1771. }
  1772. func TestBuildFails(t *testing.T) {
  1773. name := "testbuildfails"
  1774. defer deleteImages(name)
  1775. _, err := buildImage(name,
  1776. `FROM busybox
  1777. RUN sh -c "exit 23"`,
  1778. true)
  1779. if err != nil {
  1780. if !strings.Contains(err.Error(), "returned a non-zero code: 23") {
  1781. t.Fatalf("Wrong error %v, must be about non-zero code 23", err)
  1782. }
  1783. } else {
  1784. t.Fatal("Error must not be nil")
  1785. }
  1786. logDone("build - fails")
  1787. }
  1788. func TestBuildFailsDockerfileEmpty(t *testing.T) {
  1789. name := "testbuildfails"
  1790. defer deleteImages(name)
  1791. _, err := buildImage(name, ``, true)
  1792. if err != nil {
  1793. if !strings.Contains(err.Error(), "Dockerfile cannot be empty") {
  1794. t.Fatalf("Wrong error %v, must be about empty Dockerfile", err)
  1795. }
  1796. } else {
  1797. t.Fatal("Error must not be nil")
  1798. }
  1799. logDone("build - fails with empty dockerfile")
  1800. }
  1801. func TestBuildOnBuild(t *testing.T) {
  1802. name := "testbuildonbuild"
  1803. defer deleteImages(name)
  1804. _, err := buildImage(name,
  1805. `FROM busybox
  1806. ONBUILD RUN touch foobar`,
  1807. true)
  1808. if err != nil {
  1809. t.Fatal(err)
  1810. }
  1811. _, err = buildImage(name,
  1812. fmt.Sprintf(`FROM %s
  1813. RUN [ -f foobar ]`, name),
  1814. true)
  1815. if err != nil {
  1816. t.Fatal(err)
  1817. }
  1818. logDone("build - onbuild")
  1819. }
  1820. func TestBuildOnBuildForbiddenChained(t *testing.T) {
  1821. name := "testbuildonbuildforbiddenchained"
  1822. defer deleteImages(name)
  1823. _, err := buildImage(name,
  1824. `FROM busybox
  1825. ONBUILD ONBUILD RUN touch foobar`,
  1826. true)
  1827. if err != nil {
  1828. if !strings.Contains(err.Error(), "Chaining ONBUILD via `ONBUILD ONBUILD` isn't allowed") {
  1829. t.Fatalf("Wrong error %v, must be about chaining ONBUILD", err)
  1830. }
  1831. } else {
  1832. t.Fatal("Error must not be nil")
  1833. }
  1834. logDone("build - onbuild forbidden chained")
  1835. }
  1836. func TestBuildOnBuildForbiddenFrom(t *testing.T) {
  1837. name := "testbuildonbuildforbiddenfrom"
  1838. defer deleteImages(name)
  1839. _, err := buildImage(name,
  1840. `FROM busybox
  1841. ONBUILD FROM scratch`,
  1842. true)
  1843. if err != nil {
  1844. if !strings.Contains(err.Error(), "FROM isn't allowed as an ONBUILD trigger") {
  1845. t.Fatalf("Wrong error %v, must be about FROM forbidden", err)
  1846. }
  1847. } else {
  1848. t.Fatal("Error must not be nil")
  1849. }
  1850. logDone("build - onbuild forbidden from")
  1851. }
  1852. func TestBuildOnBuildForbiddenMaintainer(t *testing.T) {
  1853. name := "testbuildonbuildforbiddenmaintainer"
  1854. defer deleteImages(name)
  1855. _, err := buildImage(name,
  1856. `FROM busybox
  1857. ONBUILD MAINTAINER docker.io`,
  1858. true)
  1859. if err != nil {
  1860. if !strings.Contains(err.Error(), "MAINTAINER isn't allowed as an ONBUILD trigger") {
  1861. t.Fatalf("Wrong error %v, must be about MAINTAINER forbidden", err)
  1862. }
  1863. } else {
  1864. t.Fatal("Error must not be nil")
  1865. }
  1866. logDone("build - onbuild forbidden maintainer")
  1867. }
  1868. // gh #2446
  1869. func TestBuildAddToSymlinkDest(t *testing.T) {
  1870. name := "testbuildaddtosymlinkdest"
  1871. defer deleteImages(name)
  1872. ctx, err := fakeContext(`FROM busybox
  1873. RUN mkdir /foo
  1874. RUN ln -s /foo /bar
  1875. ADD foo /bar/
  1876. RUN [ -f /bar/foo ]
  1877. RUN [ -f /foo/foo ]`,
  1878. map[string]string{
  1879. "foo": "hello",
  1880. })
  1881. if err != nil {
  1882. t.Fatal(err)
  1883. }
  1884. defer ctx.Close()
  1885. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1886. t.Fatal(err)
  1887. }
  1888. logDone("build - add to symlink destination")
  1889. }
  1890. func TestBuildEscapeWhitespace(t *testing.T) {
  1891. name := "testbuildescaping"
  1892. defer deleteImages(name)
  1893. _, err := buildImage(name, `
  1894. FROM busybox
  1895. MAINTAINER "Docker \
  1896. IO <io@\
  1897. docker.com>"
  1898. `, true)
  1899. res, err := inspectField(name, "Author")
  1900. if err != nil {
  1901. t.Fatal(err)
  1902. }
  1903. if res != "Docker IO <io@docker.com>" {
  1904. t.Fatal("Parsed string did not match the escaped string")
  1905. }
  1906. logDone("build - validate escaping whitespace")
  1907. }
  1908. func TestBuildDockerignore(t *testing.T) {
  1909. name := "testbuilddockerignore"
  1910. defer deleteImages(name)
  1911. dockerfile := `
  1912. FROM busybox
  1913. ADD . /bla
  1914. RUN [[ -f /bla/src/x.go ]]
  1915. RUN [[ -f /bla/Makefile ]]
  1916. RUN [[ ! -e /bla/src/_vendor ]]
  1917. RUN [[ ! -e /bla/.gitignore ]]
  1918. RUN [[ ! -e /bla/README.md ]]
  1919. RUN [[ ! -e /bla/.git ]]`
  1920. ctx, err := fakeContext(dockerfile, map[string]string{
  1921. "Makefile": "all:",
  1922. ".git/HEAD": "ref: foo",
  1923. "src/x.go": "package main",
  1924. "src/_vendor/v.go": "package main",
  1925. ".gitignore": "",
  1926. "README.md": "readme",
  1927. ".dockerignore": ".git\npkg\n.gitignore\nsrc/_vendor\n*.md",
  1928. })
  1929. defer ctx.Close()
  1930. if err != nil {
  1931. t.Fatal(err)
  1932. }
  1933. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1934. t.Fatal(err)
  1935. }
  1936. logDone("build - test .dockerignore")
  1937. }
  1938. func TestBuildDockerignoringDockerfile(t *testing.T) {
  1939. name := "testbuilddockerignoredockerfile"
  1940. defer deleteImages(name)
  1941. dockerfile := `
  1942. FROM scratch`
  1943. ctx, err := fakeContext(dockerfile, map[string]string{
  1944. "Dockerfile": "FROM scratch",
  1945. ".dockerignore": "Dockerfile\n",
  1946. })
  1947. defer ctx.Close()
  1948. if err != nil {
  1949. t.Fatal(err)
  1950. }
  1951. if _, err = buildImageFromContext(name, ctx, true); err == nil {
  1952. t.Fatalf("Didn't get expected error from ignoring Dockerfile")
  1953. }
  1954. logDone("build - test .dockerignore of Dockerfile")
  1955. }
  1956. func TestBuildDockerignoringWholeDir(t *testing.T) {
  1957. name := "testbuilddockerignorewholedir"
  1958. defer deleteImages(name)
  1959. dockerfile := `
  1960. FROM busybox
  1961. COPY . /
  1962. RUN [[ ! -e /.gitignore ]]
  1963. RUN [[ -f /Makefile ]]`
  1964. ctx, err := fakeContext(dockerfile, map[string]string{
  1965. "Dockerfile": "FROM scratch",
  1966. "Makefile": "all:",
  1967. ".dockerignore": ".*\n",
  1968. })
  1969. defer ctx.Close()
  1970. if err != nil {
  1971. t.Fatal(err)
  1972. }
  1973. if _, err = buildImageFromContext(name, ctx, true); err != nil {
  1974. t.Fatal(err)
  1975. }
  1976. logDone("build - test .dockerignore whole dir with .*")
  1977. }
  1978. func TestBuildLineBreak(t *testing.T) {
  1979. name := "testbuildlinebreak"
  1980. defer deleteImages(name)
  1981. _, err := buildImage(name,
  1982. `FROM busybox
  1983. RUN sh -c 'echo root:testpass \
  1984. > /tmp/passwd'
  1985. RUN mkdir -p /var/run/sshd
  1986. RUN [ "$(cat /tmp/passwd)" = "root:testpass" ]
  1987. RUN [ "$(ls -d /var/run/sshd)" = "/var/run/sshd" ]`,
  1988. true)
  1989. if err != nil {
  1990. t.Fatal(err)
  1991. }
  1992. logDone("build - line break with \\")
  1993. }
  1994. func TestBuildEOLInLine(t *testing.T) {
  1995. name := "testbuildeolinline"
  1996. defer deleteImages(name)
  1997. _, err := buildImage(name,
  1998. `FROM busybox
  1999. RUN sh -c 'echo root:testpass > /tmp/passwd'
  2000. RUN echo "foo \n bar"; echo "baz"
  2001. RUN mkdir -p /var/run/sshd
  2002. RUN [ "$(cat /tmp/passwd)" = "root:testpass" ]
  2003. RUN [ "$(ls -d /var/run/sshd)" = "/var/run/sshd" ]`,
  2004. true)
  2005. if err != nil {
  2006. t.Fatal(err)
  2007. }
  2008. logDone("build - end of line in dockerfile instruction")
  2009. }
  2010. func TestBuildCommentsShebangs(t *testing.T) {
  2011. name := "testbuildcomments"
  2012. defer deleteImages(name)
  2013. _, err := buildImage(name,
  2014. `FROM busybox
  2015. # This is an ordinary comment.
  2016. RUN { echo '#!/bin/sh'; echo 'echo hello world'; } > /hello.sh
  2017. RUN [ ! -x /hello.sh ]
  2018. # comment with line break \
  2019. RUN chmod +x /hello.sh
  2020. RUN [ -x /hello.sh ]
  2021. RUN [ "$(cat /hello.sh)" = $'#!/bin/sh\necho hello world' ]
  2022. RUN [ "$(/hello.sh)" = "hello world" ]`,
  2023. true)
  2024. if err != nil {
  2025. t.Fatal(err)
  2026. }
  2027. logDone("build - comments and shebangs")
  2028. }
  2029. func TestBuildUsersAndGroups(t *testing.T) {
  2030. name := "testbuildusers"
  2031. defer deleteImages(name)
  2032. _, err := buildImage(name,
  2033. `FROM busybox
  2034. # Make sure our defaults work
  2035. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)" = '0:0/root:root' ]
  2036. # TODO decide if "args.user = strconv.Itoa(syscall.Getuid())" is acceptable behavior for changeUser in sysvinit instead of "return nil" when "USER" isn't specified (so that we get the proper group list even if that is the empty list, even in the default case of not supplying an explicit USER to run as, which implies USER 0)
  2037. USER root
  2038. RUN [ "$(id -G):$(id -Gn)" = '0 10:root wheel' ]
  2039. # Setup dockerio user and group
  2040. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  2041. RUN echo 'dockerio:x:1001:' >> /etc/group
  2042. # Make sure we can switch to our user and all the information is exactly as we expect it to be
  2043. USER dockerio
  2044. RUN id -G
  2045. RUN id -Gn
  2046. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  2047. # Switch back to root and double check that worked exactly as we might expect it to
  2048. USER root
  2049. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '0:0/root:root/0 10:root wheel' ]
  2050. # Add a "supplementary" group for our dockerio user
  2051. RUN echo 'supplementary:x:1002:dockerio' >> /etc/group
  2052. # ... and then go verify that we get it like we expect
  2053. USER dockerio
  2054. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001 1002:dockerio supplementary' ]
  2055. USER 1001
  2056. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001 1002:dockerio supplementary' ]
  2057. # super test the new "user:group" syntax
  2058. USER dockerio:dockerio
  2059. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  2060. USER 1001:dockerio
  2061. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  2062. USER dockerio:1001
  2063. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  2064. USER 1001:1001
  2065. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  2066. USER dockerio:supplementary
  2067. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1002/dockerio:supplementary/1002:supplementary' ]
  2068. USER dockerio:1002
  2069. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1002/dockerio:supplementary/1002:supplementary' ]
  2070. USER 1001:supplementary
  2071. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1002/dockerio:supplementary/1002:supplementary' ]
  2072. USER 1001:1002
  2073. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1002/dockerio:supplementary/1002:supplementary' ]
  2074. # make sure unknown uid/gid still works properly
  2075. USER 1042:1043
  2076. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1042:1043/1042:1043/1043:1043' ]`,
  2077. true)
  2078. if err != nil {
  2079. t.Fatal(err)
  2080. }
  2081. logDone("build - users and groups")
  2082. }
  2083. func TestBuildEnvUsage(t *testing.T) {
  2084. name := "testbuildenvusage"
  2085. defer deleteImages(name)
  2086. dockerfile := `FROM busybox
  2087. ENV PATH $HOME/bin:$PATH
  2088. ENV PATH /tmp:$PATH
  2089. RUN [ "$PATH" = "/tmp:$HOME/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" ]
  2090. ENV FOO /foo/baz
  2091. ENV BAR /bar
  2092. ENV BAZ $BAR
  2093. ENV FOOPATH $PATH:$FOO
  2094. RUN [ "$BAR" = "$BAZ" ]
  2095. RUN [ "$FOOPATH" = "$PATH:/foo/baz" ]
  2096. ENV FROM hello/docker/world
  2097. ENV TO /docker/world/hello
  2098. ADD $FROM $TO
  2099. RUN [ "$(cat $TO)" = "hello" ]
  2100. `
  2101. ctx, err := fakeContext(dockerfile, map[string]string{
  2102. "hello/docker/world": "hello",
  2103. })
  2104. if err != nil {
  2105. t.Fatal(err)
  2106. }
  2107. _, err = buildImageFromContext(name, ctx, true)
  2108. if err != nil {
  2109. t.Fatal(err)
  2110. }
  2111. logDone("build - environment variables usage")
  2112. }
  2113. func TestBuildAddScript(t *testing.T) {
  2114. name := "testbuildaddscript"
  2115. defer deleteImages(name)
  2116. dockerfile := `
  2117. FROM busybox
  2118. ADD test /test
  2119. RUN ["chmod","+x","/test"]
  2120. RUN ["/test"]
  2121. RUN [ "$(cat /testfile)" = 'test!' ]`
  2122. ctx, err := fakeContext(dockerfile, map[string]string{
  2123. "test": "#!/bin/sh\necho 'test!' > /testfile",
  2124. })
  2125. if err != nil {
  2126. t.Fatal(err)
  2127. }
  2128. _, err = buildImageFromContext(name, ctx, true)
  2129. if err != nil {
  2130. t.Fatal(err)
  2131. }
  2132. logDone("build - add and run script")
  2133. }
  2134. func TestBuildAddTar(t *testing.T) {
  2135. name := "testbuildaddtar"
  2136. defer deleteImages(name)
  2137. ctx := func() *FakeContext {
  2138. dockerfile := `
  2139. FROM busybox
  2140. ADD test.tar /
  2141. RUN cat /test/foo | grep Hi
  2142. ADD test.tar /test.tar
  2143. RUN cat /test.tar/test/foo | grep Hi
  2144. ADD test.tar /unlikely-to-exist
  2145. RUN cat /unlikely-to-exist/test/foo | grep Hi
  2146. ADD test.tar /unlikely-to-exist-trailing-slash/
  2147. RUN cat /unlikely-to-exist-trailing-slash/test/foo | grep Hi
  2148. RUN mkdir /existing-directory
  2149. ADD test.tar /existing-directory
  2150. RUN cat /existing-directory/test/foo | grep Hi
  2151. ADD test.tar /existing-directory-trailing-slash/
  2152. RUN cat /existing-directory-trailing-slash/test/foo | grep Hi`
  2153. tmpDir, err := ioutil.TempDir("", "fake-context")
  2154. testTar, err := os.Create(filepath.Join(tmpDir, "test.tar"))
  2155. if err != nil {
  2156. t.Fatalf("failed to create test.tar archive: %v", err)
  2157. }
  2158. defer testTar.Close()
  2159. tw := tar.NewWriter(testTar)
  2160. if err := tw.WriteHeader(&tar.Header{
  2161. Name: "test/foo",
  2162. Size: 2,
  2163. }); err != nil {
  2164. t.Fatalf("failed to write tar file header: %v", err)
  2165. }
  2166. if _, err := tw.Write([]byte("Hi")); err != nil {
  2167. t.Fatalf("failed to write tar file content: %v", err)
  2168. }
  2169. if err := tw.Close(); err != nil {
  2170. t.Fatalf("failed to close tar archive: %v", err)
  2171. }
  2172. if err := ioutil.WriteFile(filepath.Join(tmpDir, "Dockerfile"), []byte(dockerfile), 0644); err != nil {
  2173. t.Fatalf("failed to open destination dockerfile: %v", err)
  2174. }
  2175. return &FakeContext{Dir: tmpDir}
  2176. }()
  2177. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  2178. t.Fatalf("build failed to complete for TestBuildAddTar: %v", err)
  2179. }
  2180. logDone("build - ADD tar")
  2181. }
  2182. func TestBuildFromGIT(t *testing.T) {
  2183. name := "testbuildfromgit"
  2184. defer deleteImages(name)
  2185. git, err := fakeGIT("repo", map[string]string{
  2186. "Dockerfile": `FROM busybox
  2187. ADD first /first
  2188. RUN [ -f /first ]
  2189. MAINTAINER docker`,
  2190. "first": "test git data",
  2191. })
  2192. if err != nil {
  2193. t.Fatal(err)
  2194. }
  2195. defer git.Close()
  2196. _, err = buildImageFromPath(name, git.RepoURL, true)
  2197. if err != nil {
  2198. t.Fatal(err)
  2199. }
  2200. res, err := inspectField(name, "Author")
  2201. if err != nil {
  2202. t.Fatal(err)
  2203. }
  2204. if res != "docker" {
  2205. t.Fatalf("Maintainer should be docker, got %s", res)
  2206. }
  2207. logDone("build - build from GIT")
  2208. }
  2209. func TestBuildCleanupCmdOnEntrypoint(t *testing.T) {
  2210. name := "testbuildcmdcleanuponentrypoint"
  2211. defer deleteImages(name)
  2212. if _, err := buildImage(name,
  2213. `FROM scratch
  2214. CMD ["test"]
  2215. ENTRYPOINT ["echo"]`,
  2216. true); err != nil {
  2217. t.Fatal(err)
  2218. }
  2219. if _, err := buildImage(name,
  2220. fmt.Sprintf(`FROM %s
  2221. ENTRYPOINT ["cat"]`, name),
  2222. true); err != nil {
  2223. t.Fatal(err)
  2224. }
  2225. res, err := inspectField(name, "Config.Cmd")
  2226. if err != nil {
  2227. t.Fatal(err)
  2228. }
  2229. if expected := "<no value>"; res != expected {
  2230. t.Fatalf("Cmd %s, expected %s", res, expected)
  2231. }
  2232. res, err = inspectField(name, "Config.Entrypoint")
  2233. if err != nil {
  2234. t.Fatal(err)
  2235. }
  2236. if expected := "[cat]"; res != expected {
  2237. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  2238. }
  2239. logDone("build - cleanup cmd on ENTRYPOINT")
  2240. }
  2241. func TestBuildClearCmd(t *testing.T) {
  2242. name := "testbuildclearcmd"
  2243. defer deleteImages(name)
  2244. _, err := buildImage(name,
  2245. `From scratch
  2246. ENTRYPOINT ["/bin/bash"]
  2247. CMD []`,
  2248. true)
  2249. if err != nil {
  2250. t.Fatal(err)
  2251. }
  2252. res, err := inspectFieldJSON(name, "Config.Cmd")
  2253. if err != nil {
  2254. t.Fatal(err)
  2255. }
  2256. if res != "[]" {
  2257. t.Fatalf("Cmd %s, expected %s", res, "[]")
  2258. }
  2259. logDone("build - clearcmd")
  2260. }
  2261. func TestBuildEmptyCmd(t *testing.T) {
  2262. name := "testbuildemptycmd"
  2263. defer deleteImages(name)
  2264. if _, err := buildImage(name, "FROM scratch\nMAINTAINER quux\n", true); err != nil {
  2265. t.Fatal(err)
  2266. }
  2267. res, err := inspectFieldJSON(name, "Config.Cmd")
  2268. if err != nil {
  2269. t.Fatal(err)
  2270. }
  2271. if res != "null" {
  2272. t.Fatalf("Cmd %s, expected %s", res, "null")
  2273. }
  2274. logDone("build - empty cmd")
  2275. }
  2276. func TestBuildOnBuildOutput(t *testing.T) {
  2277. name := "testbuildonbuildparent"
  2278. defer deleteImages(name)
  2279. if _, err := buildImage(name, "FROM busybox\nONBUILD RUN echo foo\n", true); err != nil {
  2280. t.Fatal(err)
  2281. }
  2282. childname := "testbuildonbuildchild"
  2283. defer deleteImages(childname)
  2284. _, out, err := buildImageWithOut(name, "FROM "+name+"\nMAINTAINER quux\n", true)
  2285. if err != nil {
  2286. t.Fatal(err)
  2287. }
  2288. if !strings.Contains(out, "Trigger 0, RUN echo foo") {
  2289. t.Fatal("failed to find the ONBUILD output", out)
  2290. }
  2291. logDone("build - onbuild output")
  2292. }
  2293. func TestBuildInvalidTag(t *testing.T) {
  2294. name := "abcd:" + makeRandomString(200)
  2295. defer deleteImages(name)
  2296. _, out, err := buildImageWithOut(name, "FROM scratch\nMAINTAINER quux\n", true)
  2297. // if the error doesnt check for illegal tag name, or the image is built
  2298. // then this should fail
  2299. if !strings.Contains(out, "Illegal tag name") || strings.Contains(out, "Sending build context to Docker daemon") {
  2300. t.Fatalf("failed to stop before building. Error: %s, Output: %s", err, out)
  2301. }
  2302. logDone("build - invalid tag")
  2303. }
  2304. func TestBuildCmdShDashC(t *testing.T) {
  2305. name := "testbuildcmdshc"
  2306. defer deleteImages(name)
  2307. if _, err := buildImage(name, "FROM busybox\nCMD echo cmd\n", true); err != nil {
  2308. t.Fatal(err)
  2309. }
  2310. res, err := inspectFieldJSON(name, "Config.Cmd")
  2311. if err != nil {
  2312. t.Fatal(err, res)
  2313. }
  2314. expected := `["/bin/sh","-c","echo cmd"]`
  2315. if res != expected {
  2316. t.Fatalf("Expected value %s not in Config.Cmd: %s", expected, res)
  2317. }
  2318. logDone("build - cmd should have sh -c for non-json")
  2319. }
  2320. func TestBuildCmdJSONNoShDashC(t *testing.T) {
  2321. name := "testbuildcmdjson"
  2322. defer deleteImages(name)
  2323. if _, err := buildImage(name, "FROM busybox\nCMD [\"echo\", \"cmd\"]", true); err != nil {
  2324. t.Fatal(err)
  2325. }
  2326. res, err := inspectFieldJSON(name, "Config.Cmd")
  2327. if err != nil {
  2328. t.Fatal(err, res)
  2329. }
  2330. expected := `["echo","cmd"]`
  2331. if res != expected {
  2332. t.Fatalf("Expected value %s not in Config.Cmd: %s", expected, res)
  2333. }
  2334. logDone("build - cmd should not have /bin/sh -c for json")
  2335. }
  2336. func TestBuildIgnoreInvalidInstruction(t *testing.T) {
  2337. name := "testbuildignoreinvalidinstruction"
  2338. defer deleteImages(name)
  2339. out, _, err := buildImageWithOut(name, "FROM busybox\nfoo bar", true)
  2340. if err != nil {
  2341. t.Fatal(err, out)
  2342. }
  2343. logDone("build - ignore invalid Dockerfile instruction")
  2344. }
  2345. func TestBuildEntrypointInheritance(t *testing.T) {
  2346. defer deleteImages("parent", "child")
  2347. if _, err := buildImage("parent", `
  2348. FROM busybox
  2349. ENTRYPOINT exit 130
  2350. `, true); err != nil {
  2351. t.Fatal(err)
  2352. }
  2353. status, _ := runCommand(exec.Command(dockerBinary, "run", "parent"))
  2354. if status != 130 {
  2355. t.Fatalf("expected exit code 130 but received %d", status)
  2356. }
  2357. if _, err := buildImage("child", `
  2358. FROM parent
  2359. ENTRYPOINT exit 5
  2360. `, true); err != nil {
  2361. t.Fatal(err)
  2362. }
  2363. status, _ = runCommand(exec.Command(dockerBinary, "run", "child"))
  2364. if status != 5 {
  2365. t.Fatal("expected exit code 5 but received %d", status)
  2366. }
  2367. logDone("build - clear entrypoint")
  2368. }
  2369. func TestBuildEntrypointInheritanceInspect(t *testing.T) {
  2370. var (
  2371. name = "testbuildepinherit"
  2372. name2 = "testbuildepinherit2"
  2373. expected = `["/bin/sh","-c","echo quux"]`
  2374. )
  2375. defer deleteImages(name, name2)
  2376. if _, err := buildImage(name, "FROM busybox\nENTRYPOINT /foo/bar", true); err != nil {
  2377. t.Fatal(err)
  2378. }
  2379. if _, err := buildImage(name2, fmt.Sprintf("FROM %s\nENTRYPOINT echo quux", name), true); err != nil {
  2380. t.Fatal(err)
  2381. }
  2382. res, err := inspectFieldJSON(name2, "Config.Entrypoint")
  2383. if err != nil {
  2384. t.Fatal(err, res)
  2385. }
  2386. if res != expected {
  2387. t.Fatalf("Expected value %s not in Config.Entrypoint: %s", expected, res)
  2388. }
  2389. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "-t", name2))
  2390. if err != nil {
  2391. t.Fatal(err, out)
  2392. }
  2393. expected = "quux"
  2394. if strings.TrimSpace(out) != expected {
  2395. t.Fatalf("Expected output is %s, got %s", expected, out)
  2396. }
  2397. logDone("build - entrypoint override inheritance properly")
  2398. }
  2399. func TestBuildRunShEntrypoint(t *testing.T) {
  2400. name := "testbuildentrypoint"
  2401. defer deleteImages(name)
  2402. _, err := buildImage(name,
  2403. `FROM busybox
  2404. ENTRYPOINT /bin/echo`,
  2405. true)
  2406. if err != nil {
  2407. t.Fatal(err)
  2408. }
  2409. out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", name))
  2410. if err != nil {
  2411. t.Fatal(err, out)
  2412. }
  2413. logDone("build - entrypoint with /bin/echo running successfully")
  2414. }