package client // import "github.com/docker/docker/client" import ( "bytes" "context" "fmt" "io" "net/http" "strings" "testing" "github.com/docker/docker/errdefs" "github.com/docker/docker/testutil" "gotest.tools/v3/assert" is "gotest.tools/v3/assert/cmp" ) func TestImageTagError(t *testing.T) { client := &Client{ client: newMockClient(errorMock(http.StatusInternalServerError, "Server error")), } err := client.ImageTag(context.Background(), "image_id", "repo:tag") assert.Check(t, is.ErrorType(err, errdefs.IsSystem)) } // Note: this is not testing all the InvalidReference as it's the responsibility // of distribution/reference package. func TestImageTagInvalidReference(t *testing.T) { client := &Client{ client: newMockClient(errorMock(http.StatusInternalServerError, "Server error")), } err := client.ImageTag(context.Background(), "image_id", "aa/asdf$$^/aa") if err == nil || err.Error() != `Error parsing reference: "aa/asdf$$^/aa" is not a valid repository/tag: invalid reference format` { t.Fatalf("expected ErrReferenceInvalidFormat, got %v", err) } } // Ensure we don't allow the use of invalid repository names or tags; these tag operations should fail. func TestImageTagInvalidSourceImageName(t *testing.T) { ctx := context.Background() client := &Client{ client: newMockClient(errorMock(http.StatusInternalServerError, "client should not have made an API call")), } invalidRepos := []string{"fo$z$", "Foo@3cc", "Foo$3", "Foo*3", "Fo^3", "Foo!3", "F)xcz(", "fo%asd", "aa/asdf$$^/aa"} for _, repo := range invalidRepos { repo := repo t.Run("invalidRepo/"+repo, func(t *testing.T) { t.Parallel() err := client.ImageTag(ctx, "busybox", repo) assert.Check(t, is.ErrorContains(err, "not a valid repository/tag")) }) } longTag := testutil.GenerateRandomAlphaOnlyString(121) invalidTags := []string{"repo:fo$z$", "repo:Foo@3cc", "repo:Foo$3", "repo:Foo*3", "repo:Fo^3", "repo:Foo!3", "repo:%goodbye", "repo:#hashtagit", "repo:F)xcz(", "repo:-foo", "repo:..", longTag} for _, repotag := range invalidTags { repotag := repotag t.Run("invalidTag/"+repotag, func(t *testing.T) { t.Parallel() err := client.ImageTag(ctx, "busybox", repotag) assert.Check(t, is.ErrorContains(err, "not a valid repository/tag")) }) } t.Run("test repository name begin with '-'", func(t *testing.T) { t.Parallel() err := client.ImageTag(ctx, "busybox:latest", "-busybox:test") assert.Check(t, is.ErrorContains(err, "Error parsing reference")) }) t.Run("test namespace name begin with '-'", func(t *testing.T) { t.Parallel() err := client.ImageTag(ctx, "busybox:latest", "-test/busybox:test") assert.Check(t, is.ErrorContains(err, "Error parsing reference")) }) t.Run("test index name begin with '-'", func(t *testing.T) { t.Parallel() err := client.ImageTag(ctx, "busybox:latest", "-index:5000/busybox:test") assert.Check(t, is.ErrorContains(err, "Error parsing reference")) }) } func TestImageTagHexSource(t *testing.T) { client := &Client{ client: newMockClient(errorMock(http.StatusOK, "OK")), } err := client.ImageTag(context.Background(), "0d409d33b27e47423b049f7f863faa08655a8c901749c2b25b93ca67d01a470d", "repo:tag") if err != nil { t.Fatalf("got error: %v", err) } } func TestImageTag(t *testing.T) { expectedURL := "/images/image_id/tag" tagCases := []struct { reference string expectedQueryParams map[string]string }{ { reference: "repository:tag1", expectedQueryParams: map[string]string{ "repo": "repository", "tag": "tag1", }, }, { reference: "another_repository:latest", expectedQueryParams: map[string]string{ "repo": "another_repository", "tag": "latest", }, }, { reference: "another_repository", expectedQueryParams: map[string]string{ "repo": "another_repository", "tag": "latest", }, }, { reference: "test/another_repository", expectedQueryParams: map[string]string{ "repo": "test/another_repository", "tag": "latest", }, }, { reference: "test/another_repository:tag1", expectedQueryParams: map[string]string{ "repo": "test/another_repository", "tag": "tag1", }, }, { reference: "test/test/another_repository:tag1", expectedQueryParams: map[string]string{ "repo": "test/test/another_repository", "tag": "tag1", }, }, { reference: "test:5000/test/another_repository:tag1", expectedQueryParams: map[string]string{ "repo": "test:5000/test/another_repository", "tag": "tag1", }, }, { reference: "test:5000/test/another_repository", expectedQueryParams: map[string]string{ "repo": "test:5000/test/another_repository", "tag": "latest", }, }, } for _, tagCase := range tagCases { client := &Client{ client: newMockClient(func(req *http.Request) (*http.Response, error) { if !strings.HasPrefix(req.URL.Path, expectedURL) { return nil, fmt.Errorf("expected URL '%s', got '%s'", expectedURL, req.URL) } if req.Method != http.MethodPost { return nil, fmt.Errorf("expected POST method, got %s", req.Method) } query := req.URL.Query() for key, expected := range tagCase.expectedQueryParams { actual := query.Get(key) if actual != expected { return nil, fmt.Errorf("%s not set in URL query properly. Expected '%s', got %s", key, expected, actual) } } return &http.Response{ StatusCode: http.StatusOK, Body: io.NopCloser(bytes.NewReader([]byte(""))), }, nil }), } err := client.ImageTag(context.Background(), "image_id", tagCase.reference) if err != nil { t.Fatal(err) } } }