Guillaume J. Charmes
9e81ab65cb
Merge pull request #301 from dotcloud/container_test_improvment-1
...
Avoid destroy() timeout by closing stdin in TestStart()
2013-04-01 13:36:02 -07:00
Guillaume J. Charmes
ff26493fd5
Merge pull request #298 from cespare/cleanup-1
...
Some style, text, and comment cleanup.
2013-04-01 13:26:40 -07:00
Caleb Spare
9b13d21fc9
Add a 'fmt' target to the Makefile.
...
A convenience for gofmting all the code, including subpackages.
2013-04-01 13:05:00 -07:00
Caleb Spare
887f509d1d
Don't use an interface{} where a string will do.
2013-04-01 12:56:59 -07:00
Caleb Spare
13d2b08638
A few spelling/grammar corrections.
2013-04-01 12:56:50 -07:00
Caleb Spare
c298a91f95
Use a *println or *print function instead of *printf where appropriate.
2013-04-01 12:17:00 -07:00
Shawn Siefkas
37a78902db
Adding git commit to the version output
...
The Makefile must be used in order to inject the git commit
via -ldflags.
2013-04-01 13:52:45 -05:00
Caleb Spare
15b3088157
Don't convert []byte to string unnecessarily.
2013-04-01 11:15:40 -07:00
Caleb Spare
7830cf9166
Don't use a strings.Reader where a bytes.Reader will do.
...
There are several places where a []byte is converted to a string
and then fed into strings.NewReader().
2013-04-01 11:15:10 -07:00
Jonathan Rudenberg
321d94b17e
Expand the contributing guidelines
2013-04-01 12:35:04 -04:00
Jonathan Rudenberg
6b59cc8a10
Close HTTP response bodies
...
Fixes #285 .
2013-04-01 09:51:56 -04:00
Guillaume J. Charmes
91b1f9eee9
Avoid destroy() timeout by closing stdin in TestStart()
2013-03-31 22:42:10 -07:00
Solomon Hykes
c9a13147fe
Merge pull request #238 from johncosta/42-contribution-guidelines
...
Contribution guidelines
2013-03-31 22:14:18 -07:00
Solomon Hykes
1632566ecb
Show shorthand image IDs for convenience. Shorthand IDs (or any non-conflicting prefix) can be used to lookup images
2013-03-31 22:11:55 -07:00
Solomon Hykes
a52a28b609
Temporarily disable a broken test (waiting for @creack to fix it), and silence a warning which pollutes unit tests but is complicated to fix
2013-03-31 22:05:14 -07:00
Solomon Hykes
54443c092c
gofmt
2013-03-31 22:04:59 -07:00
Guillaume J. Charmes
ad1e8a9b0f
Add unit test for CmdAttach
2013-03-31 21:48:18 -07:00
Solomon Hykes
29b7ecb017
Merge pull request #272 from dominikh/improve/lazy-ip-allocator
...
Make IP allocator lazy
2013-03-31 21:04:35 -07:00
Dominik Honnef
6f9a67a7c7
Make IP allocator lazy
...
Instead of allocating all possible IPs in advance, generate them as
needed.
A loop will cycle through all possible IPs in sequential order,
allocating them as needed and marking them as in use. Once the loop
exhausts all IPs, it will wrap back to the beginning. IPs that are
already in use will be skipped. When an IP is released, it will be
cleared and be available for allocation again.
Two decisions went into this design:
1) Minimize memory footprint by only allocating IPs that are actually
in use
2) Minimize reuse of released IP addresses to avoid sending traffic to
the wrong containers
As a side effect, the functions for IP/Mask<->int conversion have been
rewritten to never be able to fail in order to reduce the amount of
error returns.
Fixes gh-231
2013-04-01 06:02:44 +02:00
Guillaume J. Charmes
cfeed391d7
Change the commands unit tests in order to reflect the proper behaviour of CmdRun
2013-03-31 20:52:35 -07:00
Guillaume J. Charmes
8c36e6920a
Working in progress: add unit tests for the running state check
2013-03-31 20:14:54 -07:00
Guillaume J. Charmes
3dcaf20d6b
Check if the containers are really running when starting docker
2013-03-31 17:40:39 -07:00
Guillaume J. Charmes
d949e2804a
Add a check to avoid double start (resulting in dockerd to panic) and unit test for it
2013-03-31 14:15:10 -07:00
Guillaume J. Charmes
1fc9405537
Add progress bar on docker push
2013-03-31 13:53:47 -07:00
Guillaume J. Charmes
b64dfdd8cd
Add a progress bar to docker pull
2013-03-31 13:04:41 -07:00
Solomon Hykes
a6779bcae2
Revert regression introduced in 81eac415ad
, which caused 'docker run -i' to never close stdin
2013-03-31 02:44:56 -07:00
Solomon Hykes
8293a0d533
Bumped version to 0.1.1
2013-03-31 02:18:04 -07:00
Solomon Hykes
0b9a3c86a2
Show shorthand container IDs for convenience. Shorthand IDs (or any non-conflicting prefix) can be used to lookup containers
2013-03-31 02:02:01 -07:00
Solomon Hykes
5a2a044e24
Merge remote-tracking branch 'origin/125-reattach_attached_run_command-fix'
2013-03-31 00:20:31 -07:00
Guillaume J. Charmes
99f9b69716
Add debug infos in CmdInfo to know the amount of fds and goroutines in use
2013-03-30 10:33:10 -07:00
Guillaume J. Charmes
b336d928fe
Make sure to close all pipes when detaching client ( #228 )
2013-03-30 09:47:09 -07:00
Guillaume J. Charmes
4760749402
Close the containers stdin when the process dies
2013-03-30 09:08:53 -07:00
Guillaume J. Charmes
7efde5eb83
Fix a scope issue preventing the close of slave stdin pty ( #228 )
2013-03-30 09:07:54 -07:00
Guillaume J. Charmes
5252ab697c
Store the master ptys in order to close them when the process dies ( #228 )
2013-03-30 09:05:53 -07:00
Guillaume J. Charmes
41555f67e0
Merge pull request #269 from cespare/gofmt-1
...
Gofmt.
2013-03-30 12:46:47 -07:00
Robert Obryk
75ba07cb3a
Swapped a map for a list in writeBroadcaster.
2013-03-30 16:04:19 +01:00
Robert Obryk
0bdfcfaa33
Make writeBroadcaster safe for concurrent use.
2013-03-30 16:02:22 +01:00
Guillaume J. Charmes
8cceafc834
Add unit test for the #125 scenario. Reattach after client disconnect on stdin allocated container
2013-03-30 06:55:47 -07:00
Caleb Spare
2d4c5ddbdd
Gofmt.
2013-03-29 23:58:30 -07:00
Solomon Hykes
d1ed28cb94
Merge remote-tracking branch 'robryk/cmdstream-deadlock'
2013-03-29 23:43:02 -07:00
Solomon Hykes
7dbb1eacc1
Merge remote-tracking branch 'origin/improve_container_tests'
2013-03-29 23:41:09 -07:00
Thatcher Peskens
e9d17b1f91
Redundant message in basics.
2013-03-29 17:38:31 -07:00
Thatcher Peskens
6437648176
Added a lot of basic instructions on various topics
2013-03-29 17:30:10 -07:00
Daniel Mizyrycki
e99541e637
packaging; issue #30 : Original files to make the Ubuntu PPA on launch date
2013-03-29 14:57:31 -07:00
Robert Obryk
68278b66c5
Added a timeout to TestCmdStreamLargeStderr.
2013-03-29 22:36:36 +01:00
Solomon Hykes
f483b214bb
Merge remote-tracking branch 'robryk/bufreader-race'
2013-03-29 13:50:33 -07:00
Solomon Hykes
f5b458b1dc
Merge pull request #250 from metachord/master
...
Remove unnecessary path parts
2013-03-29 13:42:23 -07:00
Solomon Hykes
f7b4f0c193
FIXME: implement a timeout in TestCmdStreamLArgStderr to avoid blocking the whole test suite when it fails
2013-03-29 13:37:52 -07:00
Solomon Hykes
6ede6bc8f2
Comment CmdStream a little bit to facilitate future fixes and contributions
2013-03-29 13:26:02 -07:00
Solomon Hykes
fdae64d8d7
Merge remote-tracking branch 'robryk/cmdstream-deadlock'
2013-03-29 13:20:17 -07:00