0ct0pu5/moby
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
34747 commits 14 branches 412 tags 338 MiB
Commit graph

34747 commits

This branch
This branch
All branches
Author SHA1 Message Date
Yong Tang
1778719d6a Remove unnecessary container.WithName in kill test 
This fix removes several unnecessary `container.WithName`
usage in docker kill integration test.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
 2018-03-03 01:06:49 +00:00
Yong Tang
6ab465804b Improvement in integration tests 
This fix adds several improvement:
1. No need for explicit ContainerRemove as it has been handled in setupTest()
2. Added `container.WithImage` helper function and used it in commit tests.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
 2018-03-02 19:03:59 +00:00
Vincent Demeester
135f815fb4
Merge pull request #36460 from yongtang/03012018-import 
Add missing canonical import comment to files in integration tests
 2018-03-02 09:37:58 +01:00
Yong Tang
4e702cf70d Migrate export tests to api tests 
This fix migrates export tests in integration-cli to api tests.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
 2018-03-02 00:44:03 +00:00
Yong Tang
9045406144 Add missing canonical import comment to files in integration tests 
The  canonical import comment was added some time ago, though several
newly added files do not have the comment. This fix adds the missing
canonical import comment to files in integration tests

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
 2018-03-01 22:51:11 +00:00
Sebastiaan van Stijn
7459e4cd4f
Merge pull request #36455 from thaJeztah/flip-asserts 
Fix "expected" and "actual" being reversed
 2018-03-01 21:31:46 +01:00
Yong Tang
9276750543
Merge pull request #36445 from yongtang/02282018-secret-inspect 
Remove docker_cli_secret_inspect_test.go
 2018-03-01 09:40:45 -08:00
Vincent Demeester
fa018b433a
Merge pull request #36450 from yongtang/02282018-enhancement 
Enhancement of replacing ContainerCreate with helper funcs in tests
 2018-03-01 16:47:49 +01:00
Sebastiaan van Stijn
a2517cbf62
Fix "expected" and "actual" being reversed 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2018-03-01 14:16:19 +01:00
Sebastiaan van Stijn
78efc2f383
Merge pull request #36425 from vdemeester/dockerfile-adjusts 
Follow-up fixes on multi-stage moby's Dockerfile
 2018-02-28 23:07:27 +01:00
Yong Tang
6ad4720c78 Enhancement of replacing ContainerCreate with helper funcs in tests 
This fix is a minor enhancement to replace several ContainerCreate with
helper funcs of `container.Create` in tests.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
 2018-02-28 21:35:56 +00:00
Sebastiaan van Stijn
aab5eaddcc
bump containerd/console to 2748ece16665b45a47f884001d5831ec79703880 
Fix runc exec on big-endian, causing:

    container_linux.go:265: starting container process caused "open /dev/pts/4294967296: no such file or directory"

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2018-02-28 21:43:20 +01:00
Sebastiaan van Stijn
a2f5a1a5b2
Bump Runc to 1.0.0-rc5 / 4fc53a81fb7c994640722ac585fa9ca548971871 
Release notes: https://github.com/opencontainers/runc/releases/tag/v1.0.0-rc5

Possibly relevant changes included:

- chroot when no mount namespaces is provided
- fix systemd slice expansion so that it could be consumed by cAdvisor
- libcontainer/capabilities_linux: Drop os.Getpid() call
- Update console dependency to fix runc exec on BE (causing: `container_linux.go:265: starting container process caused "open /dev/pts/4294967296: no such file or directory"`)
- libcontainer: setupUserNamespace is always called (fixes: Devices are mounted with wrong uid/gid)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2018-02-28 21:39:59 +01:00
Yong Tang
3d38adb20c Remove docker_cli_secret_inspect_test.go 
as the test (TestSecretInspectMultiple) seems to have been covered pretty well in cli:
https://github.com/docker/cli/blob/master/cli/command/secret/inspect_test.go

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
 2018-02-28 17:16:47 +00:00
Sebastiaan van Stijn
75377ec12c
Merge pull request #36434 from dnephin/fix-cp-cli-tests 
Migrate some container copy tests to integration
 2018-02-28 12:28:18 +01:00
Sebastiaan van Stijn
7c7dfce37f
Merge pull request #36429 from mnussbaum/cleanup_container_unit_test_temp_dir 
Clean up a temp dir created in container unit test
 2018-02-28 12:28:01 +01:00
Sebastiaan van Stijn
973cf656dd
Merge pull request #36430 from yongtang/02262018-config-test 
Migrate config inspect test to api test
 2018-02-28 11:50:52 +01:00
Sebastiaan van Stijn
3e0299f58c
Merge pull request #36375 from arm64b/frozen-busybox-latest-glibc 
Frozen busybox latest glibc
 2018-02-28 10:55:08 +01:00
Vincent Demeester
8fe1589615
Merge pull request #36293 from yongtang/02122018-rm-tests 
Migrate several docker rm tests to api tests
 2018-02-28 09:25:49 +01:00
Vincent Demeester
572cb66462
Use golang official image instead debian stretch 
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
 2018-02-28 09:04:48 +01:00
Sebastiaan van Stijn
f571eb1720
Merge pull request #36427 from vdemeester/micro-clean-docker-cli-build-test 
Clean some docker_cli_build_tests that are cli-only
 2018-02-28 08:20:51 +01:00
Kir Kolyshkin
0450f61cb9 devmapper.Mounted: remove 
It looks like no one uses this function.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
 2018-02-27 19:13:46 -08:00
mnussbaum
07d5446fe2 Clean-up after container unit test 
Remove temp directories and close file loggers in container unit tests.

Signed-off-by: mnussbaum <michael.nussbaum@getbraintree.com>
 2018-02-28 01:15:15 +00:00
Sebastiaan van Stijn
1346a2c89a
Merge pull request #36267 from Microsoft/jjh/removeservicing 
Windows: Remove servicing mode
 2018-02-28 01:15:03 +01:00
Yong Tang
4b99d78207 Migrate config inspect test to api test 
This fix migrates config inspect test in integration-cli
to api test.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
 2018-02-27 23:25:07 +00:00
Amr Gawish
df6af282b9 Print which path failed when the mount source doesn't exist. 
Changes Details:
--------------
Fixes: #36395

Refactoring the code to do the following:
1. Add the method `errBindSourceDoesNotExist` inside `validate.go` to be in-line with the rest of error message
2. Utilised the new method inside `linux_parser.go`, `windows_parser.go` and `validate_test.go`
3. Change the format from `bind mount source path: '%s' does not exist` to `bind mount source path does not exist: %s`
4. Reflected the format change into the 2 unit tests, namely: `volume_test.go` and `validate_test.go`
5. Reflected the format change into `docker_api_containers_test.go` integration test

Signed-off-by: Amr Gawish <amr.gawish@gmail.com>
 2018-02-27 23:19:46 +00:00
Victor Vieux
6cb75dd5b6
Merge pull request #36240 from dnephin/investigate-image-component 
Extract ImageService from Daemon
 2018-02-27 14:35:01 -08:00
Daniel Nephin
00d409f03e Migrate some copy tests to integration 
Signed-off-by: Daniel Nephin <dnephin@docker.com>
 2018-02-27 16:48:35 -05:00
Yong Tang
6bd4f4801b Migrate several docker rm tests to api tests 
This fix migrates several docker rm tests to api tests

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
 2018-02-27 19:20:01 +00:00
John Howard
d4f37c0885 Windows: Remove servicing mode 
Signed-off-by: John Howard <jhoward@microsoft.com>
 2018-02-27 08:48:31 -08:00
Brian Goff
a1afe38e52
Merge pull request #36272 from mnussbaum/36255-fix_log_path 
Fix empty LogPath with non-blocking logging mode
 2018-02-27 11:25:39 -05:00
Vincent Demeester
3cb8635001
Merge pull request #36391 from vdemeester/update-e2e-script 
Update e2e run script
 2018-02-27 16:23:36 +01:00
Vincent Demeester
894c213b3b
Clean some docker_cli_build_tests that are cli-only 
Remove TestBuildRenamedDockerfile and TestBuildDockerfileOutsideContext
that are cli-only tests (and already tested in the docker/cli
repository).

Also adds some comments on few tests that could be migrate to
docker/cli.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
 2018-02-27 13:42:29 +01:00
Vincent Demeester
407e122ac3
Merge pull request #36292 from yongtang/0212-2018-volumes-tests 
Migrate volumes tests in integration-cli to api tests
 2018-02-27 13:06:06 +01:00
Vincent Demeester
5b124d7422
Merge pull request #36424 from liubin/fix-typo 
Fix typos in builder and client
 2018-02-27 10:24:20 +01:00
Vincent Demeester
2c24bfd070
Merge pull request #36406 from yongtang/02222018-secret-create-with-labels 
Migrate some config secret tests to api test
 2018-02-27 10:01:39 +01:00
Vincent Demeester
30498c7c5f
Do not copy golang in itself 
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
 2018-02-27 09:16:13 +01:00
Dennis Chen
0d31dee5ec Network testing with busybox:glibc 
Using the `busybox:glibc` instead of `busybox:latest` to the
network related test cases (`ping` issue).

Signed-off-by: Dennis Chen <dennis.chen@arm.com>
 2018-02-27 06:53:00 +00:00
Dennis Chen
3ae45c5f17 Add busybox:latest into the frozen images 
Adding `busybox:latest` and `busybox:glibc` as the frozen images

Signed-off-by: Dennis Chen <dennis.chen@arm.com>
 2018-02-27 06:28:29 +00:00
Yong Tang
d896f87c05 Migrate volumes tests in integration-cli to api tests 
This fix migrates volumes tests in integration-cli to api tests
in integration/

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
 2018-02-27 05:18:31 +00:00
Daniel Nephin
c10e6a4d15 Remove unnecessary GetImageIDAndOS use GetImage 
Signed-off-by: Daniel Nephin <dnephin@docker.com>
 2018-02-26 16:49:37 -05:00
Daniel Nephin
2b1a2b10af Move ImageService to new package 
Signed-off-by: Daniel Nephin <dnephin@docker.com>
 2018-02-26 16:49:37 -05:00
Daniel Nephin
0dab53ff3c Move all daemon image methods into imageService 
imageService provides the backend for the image API and handles the
imageStore, and referenceStore.

Signed-off-by: Daniel Nephin <dnephin@docker.com>
 2018-02-26 16:48:29 -05:00
Vincent Demeester
600475715e
Merge pull request #36338 from tonistiigi/fix-copy-leak 
builder: fix layer lifecycle leak
 2018-02-26 22:36:40 +01:00
John Howard
83908836d3 Windows: Block pulling uplevel images 
Signed-off-by: John Howard <jhoward@microsoft.com>
 2018-02-26 12:33:54 -08:00
Vincent Demeester
4bb0f24716
Update e2e script 
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
 2018-02-26 14:32:41 +01:00
Vincent Demeester
00c1c604d0
Merge pull request #35100 from cpuguy83/multistage_dockerfile 
Updates the Dockerfile to use multi-stage
 2018-02-26 14:05:21 +01:00
Brian Goff
d539038d97
Updates the Dockerfile to use multi-stage 
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
 2018-02-26 09:10:17 +01:00
Yong Tang
99e2818850 Migrate some config secret tests to api test 
This fix migrates some secret create tests to api tests,
and remove redundant TestConfigCreate.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
 2018-02-25 23:58:04 +00:00
Sebastiaan van Stijn
5a7bbd6dba
Merge pull request #36393 from yongtang/02222018-containerIsStopped 
Move containerIsStopped/containerIsInState to integration/internal/container
 2018-02-25 16:02:12 +01:00