Commit graph

2840 commits

Author SHA1 Message Date
Sebastiaan van Stijn
5ae7f4daf7 Use errors.Wrap to preserve original error
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2019-04-01 20:14:54 +02:00
Flavio Crisciani
2b1e45c682 Merge pull request #2238 from talex5/networkdb-docs
Add NetworkDB docs
2019-03-14 16:05:31 -07:00
Flavio Crisciani
ff7e9788f2 Merge pull request #2349 from DataDog/lbernail/ipvs-timeouts
IPVS: Add support for GetConfig/SetConfig
2019-03-13 14:05:45 -07:00
Laurent Bernaille
efeae5e7ee [ipvs] Add SetConfig test with timeout=0
Signed-off-by: Laurent Bernaille <laurent.bernaille@datadoghq.com>
2019-03-13 21:43:01 +01:00
Laurent Bernaille
8e650a9685 [ipvs] Add tests for get/set timeout
Signed-off-by: Laurent Bernaille <laurent.bernaille@datadoghq.com>
2019-03-13 21:02:19 +01:00
Laurent Bernaille
7374284841 [ipvs] Add support for timeout configuration (Get/SetConfig)
Signed-off-by: Laurent Bernaille <laurent.bernaille@datadoghq.com>
2019-03-13 21:02:16 +01:00
Flavio Crisciani
daaa8f1e78 Merge pull request #2343 from arkodg/remove-iptables-legacy
Revert "debian has iptables-legacy and iptables-nft now"
2019-03-01 12:04:23 -08:00
Arko Dasgupta
068ca7d046 Revert "debian has iptables-legacy and iptables-nft now"
This reverts commit 7adcd856fe.

Libnetwork should only use the iptables binary. Iptables v1.8 and above
uses the nftables backend. The translations for all the rules used by
libnetwork is supported by the new iptables binary.

Signed-off-by: Arko Dasgupta <arko.dasgupta@docker.com>
2019-03-01 11:50:47 -08:00
Flavio Crisciani
8e7aead94f Merge pull request #2230 from mavenugo/exp-ipv
Moving IPVLAN driver out of experimental
2019-02-28 16:28:24 -08:00
Flavio Crisciani
d375c57204 Merge pull request #2342 from proelbtn/master
Typo in drivers/bridge/setup_up_forwarding.go
2019-02-26 10:48:29 -08:00
Ryoga
e744b62f49 Update setup_ip_forwarding.go
Signed-off-by: Ryoga Saito <proelbtn@users.noreply.github.com>
2019-02-26 13:30:01 +09:00
Flavio Crisciani
4c015269c5 Merge pull request #2307 from kylewuolle/fix-agent-init-problem
Fix for problem where agent is stopped and does not restart
2019-01-28 11:55:51 -08:00
Kyle Wuolle
7ca0bc66d3 Cleanup the cluster provider when the agent is closed
Signed-off-by: Kyle Wuolle <kyle.wuolle@gmail.com>
2019-01-25 08:36:28 -08:00
Flavio Crisciani
b0bef06dca Merge pull request #2332 from thaJeztah/bump_golang_1.10.7
Bump Go to 1.10.7
2019-01-23 17:00:52 -08:00
Sebastiaan van Stijn
916927d970 Bump Go to 1.10.7
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2019-01-23 21:12:12 +01:00
Flavio Crisciani
a52a6ba44e Merge pull request #2303 from thaJeztah/docs_and_error_touchup
Touch-up error-message and godoc for ConfigVXLANUDPPort
2019-01-23 09:42:36 -08:00
Flavio Crisciani
3c87075a2a Merge pull request #2325 from fcrisciani/fix-crash
Fix possible nil pointer exception
2019-01-23 07:14:19 -08:00
Sebastiaan van Stijn
d7f397c236 Touch-up error-message and godoc for ConfigVXLANUDPPort
Minor changes following review of the engine pull request
for this feature;

- Remove the name of the function from the error message
  as it's not a debug message.
- Add the valid range to the error message, so that a
  user has sufficient information to address the problem.
- Update GoDoc for the function to describe the default
  port, and valid port-ranges.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2019-01-23 10:56:40 +01:00
Flavio Crisciani
151f42aeaa Fix possible nil pointer exception
It is possible that the node is not yet present in
the node list map. In this case just print a warning
and return. The next iteration would be fine

Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
2019-01-22 17:07:15 -08:00
Flavio Crisciani
fefb622447 Merge pull request #2320 from fcrisciani/fix-build
Fix gosimple
2019-01-03 16:45:27 -08:00
Flavio Crisciani
d418337502 Fix gosimple
Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
2019-01-03 15:25:37 -08:00
Flavio Crisciani
25949f1470 Merge pull request #2302 from thaJeztah/vxlan_locking
Use sync.RWMutex for VXLANUDPPort
2019-01-03 11:12:26 -08:00
Flavio Crisciani
9b597f983f Merge pull request #2306 from qudongfang/add_more_details_to_no-available-network_error
Improve error if auto-selecting IP-range failed
2019-01-03 11:11:05 -08:00
Flavio Crisciani
f72e642339 Merge pull request #2316 from olljanat/roadmap-cleanup
Remove roadmap
2018-12-19 09:40:29 -08:00
Olli Janatuinen
ef2741452c Removed roadmap
Signed-off-by: Olli Janatuinen <olli.janatuinen@gmail.com>
2018-12-19 12:52:52 +02:00
Flavio Crisciani
d03dac939f Merge pull request #2313 from fcrisciani/buildkit
Use docker stable engine
2018-12-10 12:51:10 -08:00
Flavio Crisciani
33d47f95e8 Build with latest docker stable engine
Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
2018-12-10 08:36:52 -08:00
Flavio Crisciani
650280a057 Merge pull request #2311 from andrewhsu/updt
vndr runc 96ec217
2018-12-06 20:46:26 -08:00
Andrew Hsu
5338928eb8 account for removal of configs.HookState
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
2018-12-07 01:47:05 +00:00
Andrew Hsu
bb3ae82008 vndr runc 96ec217
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
2018-12-07 01:46:14 +00:00
Flavio Crisciani
2dc04ddf4f Merge pull request #2299 from olljanat/ip-to-hostname-fix
Do not add IP to name records for aliases
2018-11-29 08:16:29 -08:00
qudongfang
03b2393a80 Improve error if auto-selecting IP-range failed.
Signed-off-by: qudongfang <qudongfang@gmail.com>
2018-11-28 15:57:45 +08:00
Sebastiaan van Stijn
38c8a3f84d Use sync.RWMutex for VXLANUDPPort
Looks like concurrent reads should be possible, so use
a RWMutex instead of Mutex.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2018-11-22 21:29:20 +01:00
Flavio Crisciani
7667c0a4b2 Merge pull request #2300 from selansen/master
VXLAN port configuration - late review comments update
2018-11-15 08:25:45 -07:00
selansen
56ca280b27 VXLAN port configuration - late review comments update
Some review comments came in very late after merging
	#2282. This PR addresses those review comments.

Signed-off-by: selansen <elango.siva@docker.com>
2018-11-14 13:26:56 -05:00
Olli Janatuinen
d635844ed7 Do not add IP to Name records for aliases
Signed-off-by: Olli Janatuinen <olli.janatuinen@gmail.com>
2018-11-10 20:53:06 +02:00
Flavio Crisciani
ffa1330066 Merge pull request #2282 from selansen/master
VXLAN UDP Port configuration support
2018-11-05 07:41:26 -08:00
selansen
077ccabc45 VXLAN UDP Port configuration support
This PR chnages allow user to configure VxLAN UDP
port number. By default we use 4789 port number. But this commit
will allow user to configure port number during swarm init.
VxLAN port can't be modified after swarm init.

Signed-off-by: selansen <elango.siva@docker.com>
2018-11-01 15:20:30 -04:00
Flavio Crisciani
2d1311fc1b Merge pull request #2290 from fcrisciani/golint
Update golint tool
2018-11-01 10:21:34 -07:00
Flavio Crisciani
387aed91bf Update golint tool
Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
2018-11-01 10:09:47 -07:00
Flavio Crisciani
941f87407d Merge pull request #2285 from myobie/iptables-legacy
debian has iptables-legacy and iptables-nft now
2018-10-31 09:25:39 -07:00
Nathan Herald
7adcd856fe debian has iptables-legacy and iptables-nft now
Signed-off-by: Nathan Herald <me@nathanherald.com>
2018-10-31 09:14:35 -07:00
mrbeskin
1caeac8b64 clarifications and typo fixes for the design documentation
Signed-off-by: mrbeskin <mrbeskin@gmail.com>
2018-10-21 15:43:25 -05:00
Flavio Crisciani
cbf4d5ce89 Merge pull request #2171 from thaJeztah/dont_give_up
Handle NXDOMAIN, REFUSED and log errors
2018-10-12 08:38:25 -07:00
Flavio Crisciani
e0d1cdd3d4 Merge pull request #2270 from ctelfer/lbdsr
Use direct server return in east-west overlay load balancing
2018-10-11 17:44:44 -07:00
Sebastiaan van Stijn
6dd3f45248 Handle NXDOMAIN, REFUSED and log errors
- NXDOMAIN is an authoritive answer, so when receiving an NXDOMAIN, we're done.
  From RFC 1035: Name Error - Meaningful only for responses from an authoritative
  name server, this code signifies that the domain name referenced in the query
  does not exist.
  FROM RFC 8020: When an iterative caching DNS resolver receives an NXDOMAIN
  response, it SHOULD store it in its cache and then all names and resource
  record sets (RRsets) at or below that node SHOULD be considered unreachable.
  Subsequent queries for such names SHOULD elicit an NXDOMAIN response.
- REFUSED can be a transitional status: (https://www.ietf.org/rfc/rfc1035.txt)
  The name server refuses to perform the specified operation for
  policy reasons.  For example, a name server may not wish to provide the
  information to the particular requester, or a name server may not wish to
  perform a particular operation (e.g., zone)

Other errors are now logged as debug-message, which can be useful for
troubleshooting.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2018-10-12 00:55:36 +02:00
Sebastiaan van Stijn
a72bff0da3 Remove if/else and redundant brackets in resolver
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2018-10-12 00:55:28 +02:00
Christopher Adam Telfer
466225b792 Merge pull request #2276 from amoghe/amoghe_dest_stats
Add destination stats extraction to IPVS library
2018-10-11 18:01:20 -04:00
Chris Telfer
013ca3bdf8 Make DSR an overlay-specific driver "option"
Allow DSR to be a configurable option through a generic option to the
overlay driver.  On the one hand this approach makes sense insofar as
only overlay networks can currently perform load balancing.  On the
other hand, this approach has several issues.  First, should we create
another type of swarm scope network, this will prevent it working.
Second, the service core code is separate from the driver code and the
driver code can't influence the core data structures.  So the driver
code can't set this option itself.  Therefore, implementing in this way
requires some hack code to test for this option in
controller.NewNetwork.

A more correct approach would be to make this a generic option for any
network.  Then the driver could ignore, reject or be unaware of the option
depending on the chosen model.  This would require changes to:
  * libnetwork - naturally
  * the docker API - to carry the option
  * swarmkit - to propagate the option
  * the docker CLI - to support the option
  * moby - to translate the API option into a libnetwork option
Given the urgency of requests to address this issue, this approach will
be saved for a future iteration.

Signed-off-by: Chris Telfer <ctelfer@docker.com>
2018-10-11 14:13:19 -04:00
Chris Telfer
9a2464f436 Set east-west load balancing to use direct routing
Modify the loadbalancing for east-west traffic to use direct routing
rather than NAT and update tasks to use direct service return under
linux.  This avoids hiding the source address of the sender and improves
the performance in single-client/single-server tests.

Signed-off-by: Chris Telfer <ctelfer@docker.com>
2018-10-11 14:13:19 -04:00