Solomon Hykes 11 лет назад
Родитель
Сommit
f7a2f0b937
2 измененных файлов с 3 добавлено и 1 удалено
  1. 2 0
      gograph/gograph.go
  2. 1 1
      gograph/gograph_test.go

+ 2 - 0
gograph/gograph.go

@@ -104,9 +104,11 @@ func (db *Database) Set(fullPath, id string) (*Entity, error) {
 		return nil, err
 	}
 	defer conn.Close()
+	// FIXME: is rollback implicit when closing the connection?
 	rollback := func() {
 		conn.Exec("ROLLBACK")
 	}
+	// FIXME: use exclusive transactions to avoid race conditions
 	if _, err := conn.Exec("BEGIN"); err != nil {
 		return nil, err
 	}

+ 1 - 1
gograph/gograph_test.go

@@ -22,7 +22,7 @@ func destroyTestDb(db *Database) {
 func TestNewDatabase(t *testing.T) {
 	db := newTestDb(t)
 	if db == nil {
-		t.Fatal("Datbase should not be nil")
+		t.Fatal("Database should not be nil")
 	}
 	defer destroyTestDb(db)
 }