Browse Source

replace some strings with OCI consts

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sebastiaan van Stijn 1 năm trước cách đây
mục cha
commit
f05dce8d3a

+ 8 - 7
image/tarexport/save.go

@@ -241,7 +241,7 @@ func (s *saveSession) save(outStream io.Writer) error {
 		}
 		}
 		dgst := digest.FromBytes(data)
 		dgst := digest.FromBytes(data)
 
 
-		mFile := filepath.Join(s.outDir, "blobs", dgst.Algorithm().String(), dgst.Encoded())
+		mFile := filepath.Join(s.outDir, ocispec.ImageBlobsDir, dgst.Algorithm().String(), dgst.Encoded())
 		if err := os.MkdirAll(filepath.Dir(mFile), 0o755); err != nil {
 		if err := os.MkdirAll(filepath.Dir(mFile), 0o755); err != nil {
 			return errors.Wrap(err, "error creating blob directory")
 			return errors.Wrap(err, "error creating blob directory")
 		}
 		}
@@ -279,11 +279,11 @@ func (s *saveSession) save(outStream io.Writer) error {
 		for _, l := range imageDescr.layers {
 		for _, l := range imageDescr.layers {
 			// IMPORTANT: We use path, not filepath here to ensure the layers
 			// IMPORTANT: We use path, not filepath here to ensure the layers
 			// in the manifest use Unix-style forward-slashes.
 			// in the manifest use Unix-style forward-slashes.
-			layers = append(layers, path.Join("blobs", l.Algorithm().String(), l.Encoded()))
+			layers = append(layers, path.Join(ocispec.ImageBlobsDir, l.Algorithm().String(), l.Encoded()))
 		}
 		}
 
 
 		manifest = append(manifest, manifestItem{
 		manifest = append(manifest, manifestItem{
-			Config:       path.Join("blobs", id.Digest().Algorithm().String(), id.Digest().Encoded()),
+			Config:       path.Join(ocispec.ImageBlobsDir, id.Digest().Algorithm().String(), id.Digest().Encoded()),
 			RepoTags:     repoTags,
 			RepoTags:     repoTags,
 			Layers:       layers,
 			Layers:       layers,
 			LayerSources: foreignSrcs,
 			LayerSources: foreignSrcs,
@@ -336,7 +336,8 @@ func (s *saveSession) save(outStream io.Writer) error {
 		return err
 		return err
 	}
 	}
 
 
-	layoutPath := filepath.Join(tempDir, ociLayoutFilename)
+	const ociLayoutContent = `{"imageLayoutVersion": "` + ocispec.ImageLayoutVersion + `"}`
+	layoutPath := filepath.Join(tempDir, ocispec.ImageLayoutFile)
 	if err := os.WriteFile(layoutPath, []byte(ociLayoutContent), 0o644); err != nil {
 	if err := os.WriteFile(layoutPath, []byte(ociLayoutContent), 0o644); err != nil {
 		return errors.Wrap(err, "error writing oci layout file")
 		return errors.Wrap(err, "error writing oci layout file")
 	}
 	}
@@ -355,7 +356,7 @@ func (s *saveSession) save(outStream io.Writer) error {
 		return errors.Wrap(err, "error marshaling oci index")
 		return errors.Wrap(err, "error marshaling oci index")
 	}
 	}
 
 
-	idxFile := filepath.Join(s.outDir, ociIndexFileName)
+	idxFile := filepath.Join(s.outDir, ocispec.ImageIndexFile)
 	if err := os.WriteFile(idxFile, data, 0o644); err != nil {
 	if err := os.WriteFile(idxFile, data, 0o644); err != nil {
 		return errors.Wrap(err, "error writing oci index file")
 		return errors.Wrap(err, "error writing oci index file")
 	}
 	}
@@ -420,7 +421,7 @@ func (s *saveSession) saveImage(id image.ID) (map[layer.DiffID]distribution.Desc
 	data := img.RawJSON()
 	data := img.RawJSON()
 	dgst := digest.FromBytes(data)
 	dgst := digest.FromBytes(data)
 
 
-	blobDir := filepath.Join(s.outDir, "blobs", dgst.Algorithm().String())
+	blobDir := filepath.Join(s.outDir, ocispec.ImageBlobsDir, dgst.Algorithm().String())
 	if err := os.MkdirAll(blobDir, 0o755); err != nil {
 	if err := os.MkdirAll(blobDir, 0o755); err != nil {
 		return nil, err
 		return nil, err
 	}
 	}
@@ -452,7 +453,7 @@ func (s *saveSession) saveLayer(id layer.ChainID, legacyImg image.V1Image, creat
 		return distribution.Descriptor{}, nil
 		return distribution.Descriptor{}, nil
 	}
 	}
 
 
-	outDir := filepath.Join(s.outDir, "blobs")
+	outDir := filepath.Join(s.outDir, ocispec.ImageBlobsDir)
 
 
 	imageConfig, err := json.Marshal(legacyImg)
 	imageConfig, err := json.Marshal(legacyImg)
 	if err != nil {
 	if err != nil {

+ 0 - 4
image/tarexport/tarexport.go

@@ -13,10 +13,6 @@ const (
 	legacyLayerFileName        = "layer.tar"
 	legacyLayerFileName        = "layer.tar"
 	legacyConfigFileName       = "json"
 	legacyConfigFileName       = "json"
 	legacyRepositoriesFileName = "repositories"
 	legacyRepositoriesFileName = "repositories"
-
-	ociIndexFileName  = "index.json"
-	ociLayoutFilename = "oci-layout"
-	ociLayoutContent  = `{"imageLayoutVersion": "1.0.0"}`
 )
 )
 
 
 type manifestItem struct {
 type manifestItem struct {