|
@@ -193,13 +193,18 @@ for each.
|
|
|
# They should ask for any editorial change that makes the documentation more
|
|
# They should ask for any editorial change that makes the documentation more
|
|
|
# consistent and easier to understand.
|
|
# consistent and easier to understand.
|
|
|
#
|
|
#
|
|
|
- # Once documentation is approved, a maintainer should make sure to remove this
|
|
|
|
|
|
|
+ # Once documentation is approved (see below), a maintainer should make sure to remove this
|
|
|
# label and add the next one.
|
|
# label and add the next one.
|
|
|
|
|
|
|
|
close = ""
|
|
close = ""
|
|
|
2-code-review = "requires more code changes"
|
|
2-code-review = "requires more code changes"
|
|
|
1-design-review = "raises design concerns"
|
|
1-design-review = "raises design concerns"
|
|
|
4-merge = "general case"
|
|
4-merge = "general case"
|
|
|
|
|
+
|
|
|
|
|
+ # Docs approval
|
|
|
|
|
+ [Rules.review.docs-approval]
|
|
|
|
|
+ # Changes and additions to docs must be reviewed and approved (LGTM'd) by a minimum of two docs sub-project maintainers.
|
|
|
|
|
+ # If the docs change originates with a docs maintainer, only one additional LGTM is required (since we assume a docs maintainer approves of their own PR).
|
|
|
|
|
|
|
|
# Merge
|
|
# Merge
|
|
|
[Rules.review.states.4-merge]
|
|
[Rules.review.states.4-merge]
|
|
@@ -535,6 +540,11 @@ made through a pull request.
|
|
|
Email = "estesp@linux.vnet.ibm.com"
|
|
Email = "estesp@linux.vnet.ibm.com"
|
|
|
GitHub = "estesp"
|
|
GitHub = "estesp"
|
|
|
|
|
|
|
|
|
|
+ [people.fredlf]
|
|
|
|
|
+ Name = "Fred Lifton"
|
|
|
|
|
+ Email = "fred.lifton@docker.com"
|
|
|
|
|
+ GitHub = "fredlf"
|
|
|
|
|
+
|
|
|
[people.icecrime]
|
|
[people.icecrime]
|
|
|
Name = "Arnaud Porterie"
|
|
Name = "Arnaud Porterie"
|
|
|
Email = "arnaud@docker.com"
|
|
Email = "arnaud@docker.com"
|
Michael Crosby