Merge pull request #20522 from LK4D4/do_not_close_chan

filenotify: don't close channels to avoid panic

pkg/filenotify/poller.go

@@ -118,8 +118,10 @@ func (w *filePoller) Close() error {
 		w.remove(name)
 		delete(w.watches, name)
 	}
-	close(w.events)
-	close(w.errors)
+	// channels will be closed by GC, we don't do it to avoid panic in send
+	// functions
+	// close(w.events)
+	// close(w.errors)
 	return nil
 }
 

pkg/filenotify/poller_test.go

@@ -89,24 +89,6 @@ func TestPollerClose(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	select {
-	case _, open := <-w.Events():
-		if open {
-			t.Fatal("event chan should be closed")
-		}
-	default:
-		t.Fatal("event chan should be closed")
-	}
-
-	select {
-	case _, open := <-w.Errors():
-		if open {
-			t.Fatal("errors chan should be closed")
-		}
-	default:
-		t.Fatal("errors chan should be closed")
-	}
-
 	f, err := ioutil.TempFile("", "asdf")
 	if err != nil {
 		t.Fatal(err)