0ct0pu5/moby
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge pull request #2449 from espensuenson/bugfix_getnetworkfromstore

Browse source 
Fixed getNetworkFromStore, which returned an incorrect struct
This commit is contained in:
elangovan sivanandam 2019-09-28 18:27:21 -04:00 • committed by GitHub
commit e481dc9fad
1 changed files with 8 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
libnetwork/store.go
View file

@ -80,30 +80,15 @@ func (c *controller) getStores() []datastore.DataStore {
}
func (c *controller) getNetworkFromStore(nid string) (*network, error) {
for _, store := range c.getStores() {
n := &network{id: nid, ctrlr: c}
err := store.GetObject(datastore.Key(n.Key()...), n)
// Continue searching in the next store if the key is not found in this store
if err != nil {
if err != datastore.ErrKeyNotFound {
logrus.Debugf("could not find network %s: %v", nid, err)
}
continue
}
ec := &endpointCnt{n: n}
err = store.GetObject(datastore.Key(ec.Key()...), ec)
if err != nil && !n.inDelete {
return nil, fmt.Errorf("could not find endpoint count for network %s: %v", n.Name(), err)
}
n.epCnt = ec
if n.scope == "" {
n.scope = store.Scope()
}
return n, nil
ns, err := c.getNetworksFromStore()
if err != nil {
return nil, err
}
for _, n := range ns {
if n.id == nid {
return n, nil
}
}
return nil, fmt.Errorf("network %s not found", nid)
}