Przeglądaj źródła

Fix cases where we are wrapping a nil error

This was using `errors.Wrap` when there was no error to wrap, meanwhile
we are supposed to be creating a new error.

Found this while investigating some log corruption issues and
unexpectedly getting a nil reader and a nil error from `getTailReader`.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
(cherry picked from commit 0a48d26fbcb33a84da7f767c2a62cae362df9505)
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Brian Goff 1 rok temu
rodzic
commit
e2e670299f
1 zmienionych plików z 1 dodań i 1 usunięć
  1. 1 1
      daemon/logger/local/read.go

+ 1 - 1
daemon/logger/local/read.go

@@ -66,7 +66,7 @@ func getTailReader(ctx context.Context, r loggerutils.SizeReaderAt, req int) (io
 		}
 
 		if msgLen != binary.BigEndian.Uint32(buf) {
-			return nil, 0, errdefs.DataLoss(errors.Wrap(err, "log message header and footer indicate different message sizes"))
+			return nil, 0, errdefs.DataLoss(errors.New("log message header and footer indicate different message sizes"))
 		}
 
 		found++