浏览代码

awslogs & archive: prevent 2 goroutine leaks in test functions

Signed-off-by: Ziheng Liu <lzhfromustc@gmail.com>
Ziheng Liu 5 年之前
父节点
当前提交
d7bc994a08
共有 2 个文件被更改,包括 2 次插入2 次删除
  1. 1 1
      daemon/logger/awslogs/cloudwatchlogs_test.go
  2. 1 1
      pkg/archive/archive_test.go

+ 1 - 1
daemon/logger/awslogs/cloudwatchlogs_test.go

@@ -345,7 +345,7 @@ func TestLogNonBlockingBufferFull(t *testing.T) {
 		logNonBlocking: true,
 		logNonBlocking: true,
 	}
 	}
 	stream.messages <- &logger.Message{}
 	stream.messages <- &logger.Message{}
-	errorCh := make(chan error)
+	errorCh := make(chan error, 1)
 	started := make(chan bool)
 	started := make(chan bool)
 	go func() {
 	go func() {
 		started <- true
 		started <- true

+ 1 - 1
pkg/archive/archive_test.go

@@ -217,7 +217,7 @@ func TestCmdStreamLargeStderr(t *testing.T) {
 	if err != nil {
 	if err != nil {
 		t.Fatalf("Failed to start command: %s", err)
 		t.Fatalf("Failed to start command: %s", err)
 	}
 	}
-	errCh := make(chan error)
+	errCh := make(chan error, 1)
 	go func() {
 	go func() {
 		_, err := io.Copy(ioutil.Discard, out)
 		_, err := io.Copy(ioutil.Discard, out)
 		errCh <- err
 		errCh <- err