0ct0pu5/moby
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Use ExportChanges() in runtime.Diff()

Browse source 
This code was duplicated in two places, one which was unused. This
syncs the code and removes the unused version.
This commit is contained in:
Alexander Larsson 2013-11-14 22:57:33 +01:00
parent 006e2a600c
commit d69a6a20f0
2 changed files with 9 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
archive/changes.go
View file

@ -280,11 +280,7 @@ func ChangesDirs(newDir, oldDir string) ([]Change, error) {
return newRoot.Changes(oldRoot), nil return newRoot.Changes(oldRoot), nil
} }
func ExportChanges(root, rw string) (Archive, error) { func ExportChanges(dir string, changes []Change) (Archive, error) {
changes, err := ChangesDirs(root, rw)
if err != nil {
return nil, err
}
files := make([]string, 0) files := make([]string, 0)
deletions := make([]string, 0) deletions := make([]string, 0)
for _, change := range changes { for _, change := range changes {
@ -297,5 +293,11 @@ func ExportChanges(root, rw string) (Archive, error) {
deletions = append(deletions, filepath.Join(dir, ".wh."+base)) deletions = append(deletions, filepath.Join(dir, ".wh."+base))
} }
} }
return TarFilter(root, &TarOptions{Compression: Uncompressed, Recursive: false, Includes: files, CreateFiles: deletions}) // FIXME: Why do we create whiteout files inside Tar code ?
return TarFilter(dir, &TarOptions{
Compression: Uncompressed,
Includes: files,
Recursive: false,
CreateFiles: deletions,
})
} }

21
runtime.go
View file

@ -18,7 +18,6 @@ import (
"os" "os"
"os/exec" "os/exec"
"path" "path"
"path/filepath"
"sort" "sort"
"strings" "strings"
"time" "time"
@ -763,25 +762,7 @@ func (runtime *Runtime) Diff(container *Container) (archive.Archive, error) {
return nil, fmt.Errorf("Error getting container rootfs %s from driver %s: %s", container.ID, container.runtime.driver, err) return nil, fmt.Errorf("Error getting container rootfs %s from driver %s: %s", container.ID, container.runtime.driver, err)
} }
files := make([]string, 0) return archive.ExportChanges(cDir, changes)
deletions := make([]string, 0)
for _, change := range changes {
if change.Kind == archive.ChangeModify || change.Kind == archive.ChangeAdd {
files = append(files, change.Path)
}
if change.Kind == archive.ChangeDelete {
base := filepath.Base(change.Path)
dir := filepath.Dir(change.Path)
deletions = append(deletions, filepath.Join(dir, ".wh."+base))
}
}
// FIXME: Why do we create whiteout files inside Tar code ?
return archive.TarFilter(cDir, &archive.TarOptions{
Compression: archive.Uncompressed,
Includes: files,
Recursive: false,
CreateFiles: deletions,
})
} }
func linkLxcStart(root string) error { func linkLxcStart(root string) error {