Просмотр исходного кода

Test: Add buffer to two channels to avoid blocking goroutine

Signed-off-by: Ziheng Liu <lzhfromustc@gmail.com>
lzhfromustc 4 лет назад
Родитель
Сommit
d1c2f953c5
2 измененных файлов с 2 добавлено и 2 удалено
  1. 1 1
      builder/dockerfile/containerbackend.go
  2. 1 1
      integration/plugin/logging/read_test.go

+ 1 - 1
builder/dockerfile/containerbackend.go

@@ -45,7 +45,7 @@ var errCancelled = errors.New("build cancelled")
 // Run a container by ID
 func (c *containerManager) Run(ctx context.Context, cID string, stdout, stderr io.Writer) (err error) {
 	attached := make(chan struct{})
-	errCh := make(chan error)
+	errCh := make(chan error, 1)
 	go func() {
 		errCh <- c.backend.ContainerAttachRaw(cID, nil, stdout, stderr, true, attached)
 	}()

+ 1 - 1
integration/plugin/logging/read_test.go

@@ -73,7 +73,7 @@ func TestReadPluginNoRead(t *testing.T) {
 
 			buf := bytes.NewBuffer(nil)
 
-			errCh := make(chan error)
+			errCh := make(chan error, 1)
 			go func() {
 				_, err := stdcopy.StdCopy(buf, buf, logs)
 				errCh <- err