diff --git a/daemon/logger/awslogs/cloudwatchlogs.go b/daemon/logger/awslogs/cloudwatchlogs.go index 7406046298..14ef531553 100644 --- a/daemon/logger/awslogs/cloudwatchlogs.go +++ b/daemon/logger/awslogs/cloudwatchlogs.go @@ -120,10 +120,10 @@ type byTimestamp []wrappedEvent // init registers the awslogs driver func init() { if err := logger.RegisterLogDriver(name, New); err != nil { - logrus.Fatal(err) + panic(err) } if err := logger.RegisterLogOptValidator(name, ValidateLogOpt); err != nil { - logrus.Fatal(err) + panic(err) } } diff --git a/daemon/logger/etwlogs/etwlogs_windows.go b/daemon/logger/etwlogs/etwlogs_windows.go index 78d3477b61..9a410a1c05 100644 --- a/daemon/logger/etwlogs/etwlogs_windows.go +++ b/daemon/logger/etwlogs/etwlogs_windows.go @@ -48,7 +48,7 @@ var mu sync.Mutex func init() { providerHandle = windows.InvalidHandle if err := logger.RegisterLogDriver(name, New); err != nil { - logrus.Fatal(err) + panic(err) } } diff --git a/daemon/logger/fluentd/fluentd.go b/daemon/logger/fluentd/fluentd.go index b99c46e107..17778d8099 100644 --- a/daemon/logger/fluentd/fluentd.go +++ b/daemon/logger/fluentd/fluentd.go @@ -62,10 +62,10 @@ const ( func init() { if err := logger.RegisterLogDriver(name, New); err != nil { - logrus.Fatal(err) + panic(err) } if err := logger.RegisterLogOptValidator(name, ValidateLogOpt); err != nil { - logrus.Fatal(err) + panic(err) } } diff --git a/daemon/logger/gcplogs/gcplogging.go b/daemon/logger/gcplogs/gcplogging.go index 4d1e74152f..94ef107510 100644 --- a/daemon/logger/gcplogs/gcplogging.go +++ b/daemon/logger/gcplogs/gcplogging.go @@ -43,13 +43,12 @@ var ( ) func init() { - if err := logger.RegisterLogDriver(name, New); err != nil { - logrus.Fatal(err) + panic(err) } if err := logger.RegisterLogOptValidator(name, ValidateLogOpts); err != nil { - logrus.Fatal(err) + panic(err) } } diff --git a/daemon/logger/gelf/gelf.go b/daemon/logger/gelf/gelf.go index c7814e9207..4adf2b3efb 100644 --- a/daemon/logger/gelf/gelf.go +++ b/daemon/logger/gelf/gelf.go @@ -14,7 +14,6 @@ import ( "github.com/Graylog2/go-gelf/gelf" "github.com/docker/docker/daemon/logger" "github.com/docker/docker/daemon/logger/loggerutils" - "github.com/sirupsen/logrus" ) const name = "gelf" @@ -28,10 +27,10 @@ type gelfLogger struct { func init() { if err := logger.RegisterLogDriver(name, New); err != nil { - logrus.Fatal(err) + panic(err) } if err := logger.RegisterLogOptValidator(name, ValidateLogOpt); err != nil { - logrus.Fatal(err) + panic(err) } } diff --git a/daemon/logger/journald/journald.go b/daemon/logger/journald/journald.go index e809ca722c..dd7414e2ee 100644 --- a/daemon/logger/journald/journald.go +++ b/daemon/logger/journald/journald.go @@ -14,7 +14,6 @@ import ( "github.com/coreos/go-systemd/v22/journal" "github.com/docker/docker/daemon/logger" "github.com/docker/docker/daemon/logger/loggerutils" - "github.com/sirupsen/logrus" ) const name = "journald" @@ -27,10 +26,10 @@ type journald struct { func init() { if err := logger.RegisterLogDriver(name, New); err != nil { - logrus.Fatal(err) + panic(err) } if err := logger.RegisterLogOptValidator(name, validateLogOpt); err != nil { - logrus.Fatal(err) + panic(err) } } diff --git a/daemon/logger/jsonfilelog/jsonfilelog.go b/daemon/logger/jsonfilelog/jsonfilelog.go index e66a6b8266..385f63abea 100644 --- a/daemon/logger/jsonfilelog/jsonfilelog.go +++ b/daemon/logger/jsonfilelog/jsonfilelog.go @@ -15,7 +15,6 @@ import ( "github.com/docker/docker/daemon/logger/loggerutils" units "github.com/docker/go-units" "github.com/pkg/errors" - "github.com/sirupsen/logrus" ) // Name is the name of the file that the jsonlogger logs to. @@ -32,10 +31,10 @@ type JSONFileLogger struct { func init() { if err := logger.RegisterLogDriver(Name, New); err != nil { - logrus.Fatal(err) + panic(err) } if err := logger.RegisterLogOptValidator(Name, ValidateLogOpt); err != nil { - logrus.Fatal(err) + panic(err) } } diff --git a/daemon/logger/local/local.go b/daemon/logger/local/local.go index f4411d087a..169d2d38b8 100644 --- a/daemon/logger/local/local.go +++ b/daemon/logger/local/local.go @@ -14,7 +14,6 @@ import ( "github.com/docker/docker/errdefs" units "github.com/docker/go-units" "github.com/pkg/errors" - "github.com/sirupsen/logrus" ) const ( @@ -49,10 +48,10 @@ func ValidateLogOpt(cfg map[string]string) error { func init() { if err := logger.RegisterLogDriver(Name, New); err != nil { - logrus.Fatal(err) + panic(err) } if err := logger.RegisterLogOptValidator(Name, ValidateLogOpt); err != nil { - logrus.Fatal(err) + panic(err) } } diff --git a/daemon/logger/logentries/logentries.go b/daemon/logger/logentries/logentries.go index 013b182d82..15d8c75bc6 100644 --- a/daemon/logger/logentries/logentries.go +++ b/daemon/logger/logentries/logentries.go @@ -29,10 +29,10 @@ const ( func init() { if err := logger.RegisterLogDriver(name, New); err != nil { - logrus.Fatal(err) + panic(err) } if err := logger.RegisterLogOptValidator(name, ValidateLogOpt); err != nil { - logrus.Fatal(err) + panic(err) } } diff --git a/daemon/logger/splunk/splunk.go b/daemon/logger/splunk/splunk.go index ebdc88b552..d194334dad 100644 --- a/daemon/logger/splunk/splunk.go +++ b/daemon/logger/splunk/splunk.go @@ -142,10 +142,10 @@ const ( func init() { if err := logger.RegisterLogDriver(driverName, New); err != nil { - logrus.Fatal(err) + panic(err) } if err := logger.RegisterLogOptValidator(driverName, ValidateLogOpt); err != nil { - logrus.Fatal(err) + panic(err) } } diff --git a/daemon/logger/syslog/syslog.go b/daemon/logger/syslog/syslog.go index 4469af8a02..3b58e2249d 100644 --- a/daemon/logger/syslog/syslog.go +++ b/daemon/logger/syslog/syslog.go @@ -16,7 +16,6 @@ import ( "github.com/docker/docker/daemon/logger" "github.com/docker/docker/daemon/logger/loggerutils" "github.com/docker/go-connections/tlsconfig" - "github.com/sirupsen/logrus" ) const ( @@ -54,10 +53,10 @@ type syslogger struct { func init() { if err := logger.RegisterLogDriver(name, New); err != nil { - logrus.Fatal(err) + panic(err) } if err := logger.RegisterLogOptValidator(name, ValidateLogOpt); err != nil { - logrus.Fatal(err) + panic(err) } } diff --git a/integration-cli/check_test.go b/integration-cli/check_test.go index 9a710b5210..0001d081f3 100644 --- a/integration-cli/check_test.go +++ b/integration-cli/check_test.go @@ -54,8 +54,7 @@ func init() { testEnv, err = environment.New() if err != nil { - fmt.Println(err) - os.Exit(1) + panic(err) } } diff --git a/libnetwork/ipamutils/utils.go b/libnetwork/ipamutils/utils.go index 3fd37cd884..9be126ff7a 100644 --- a/libnetwork/ipamutils/utils.go +++ b/libnetwork/ipamutils/utils.go @@ -34,13 +34,11 @@ type NetworkToSplit struct { func init() { var err error if PredefinedGlobalScopeDefaultNetworks, err = splitNetworks(globalScopeDefaultNetworks); err != nil { - //we are going to panic in case of error as we should never get into this state - panic("InitAddressPools failed to initialize the global scope default address pool") + panic("failed to initialize the global scope default address pool: " + err.Error()) } if PredefinedLocalScopeDefaultNetworks, err = splitNetworks(localScopeDefaultNetworks); err != nil { - //we are going to panic in case of error as we should never get into this state - panic("InitAddressPools failed to initialize the local scope default address pool") + panic("failed to initialize the local scope default address pool: " + err.Error()) } } diff --git a/pkg/chrootarchive/init_windows.go b/pkg/chrootarchive/init_windows.go deleted file mode 100644 index 15ed874e77..0000000000 --- a/pkg/chrootarchive/init_windows.go +++ /dev/null @@ -1,4 +0,0 @@ -package chrootarchive // import "github.com/docker/docker/pkg/chrootarchive" - -func init() { -}