Procházet zdrojové kódy

Fix run `docker rename <container-id> new_name` concurrently, the container will have multi names

When run `docker rename <container-id> new_name` concurrently, every operation will release
container's old name. So container will have multi new names reserve in nameIndex.

Signed-off-by: Yang Pengfei <yangpengfei4@huawei.com>
Yang Pengfei před 8 roky
rodič
revize
cc2340689c
1 změnil soubory, kde provedl 3 přidání a 3 odebrání
  1. 3 3
      daemon/rename.go

+ 3 - 3
daemon/rename.go

@@ -32,6 +32,9 @@ func (daemon *Daemon) ContainerRename(oldName, newName string) error {
 		return err
 	}
 
+	container.Lock()
+	defer container.Unlock()
+
 	oldName = container.Name
 	oldIsAnonymousEndpoint := container.NetworkSettings.IsAnonymousEndpoint
 
@@ -39,9 +42,6 @@ func (daemon *Daemon) ContainerRename(oldName, newName string) error {
 		return errors.New("Renaming a container with the same name as its current name")
 	}
 
-	container.Lock()
-	defer container.Unlock()
-
 	links := map[string]*dockercontainer.Container{}
 	for k, v := range daemon.linkIndex.children(container) {
 		if !strings.HasPrefix(k, oldName) {