Test coverage

Signed-off-by: Arnaud Porterie <arnaud.porterie@docker.com>

libnetwork/drivers/bridge/network.go

@@ -11,5 +11,6 @@ func (b *bridgeNetwork) Type() string {
 }
 
 func (b *bridgeNetwork) Link(name string) ([]*libnetwork.Interface, error) {
+	// TODO
 	return nil, nil
 }

libnetwork/drivers/bridge/setup_ipv4.go

@@ -47,7 +47,11 @@ func SetupBridgeIPv4(i *Interface) error {
 	}
 
 	log.Debugf("Creating bridge interface %q with network %s", i.Config.BridgeName, bridgeIPv4)
-	return netlink.AddrAdd(i.Link, &netlink.Addr{bridgeIPv4, ""})
+	if err := netlink.AddrAdd(i.Link, &netlink.Addr{bridgeIPv4, ""}); err != nil {
+		return fmt.Errorf("Failed to add IPv4 address %s to bridge: %v", bridgeIPv4, err)
+	}
+
+	return nil
 }
 
 func electBridgeIPv4(config *Configuration) (*net.IPNet, error) {

libnetwork/drivers/bridge/setup_ipv6.go

@@ -28,5 +28,10 @@ func SetupBridgeIPv6(i *Interface) error {
 	if err := ioutil.WriteFile(procFile, []byte{'0', '\n'}, 0644); err != nil {
 		return fmt.Errorf("Unable to enable IPv6 addresses on bridge: %v", err)
 	}
-	return netlink.AddrAdd(i.Link, &netlink.Addr{BridgeIPv6, ""})
+
+	if err := netlink.AddrAdd(i.Link, &netlink.Addr{BridgeIPv6, ""}); err != nil {
+		return fmt.Errorf("Failed to add IPv6 address %s to bridge: %v", BridgeIPv6, err)
+	}
+
+	return nil
 }

libnetwork/drivers/bridge/setup_ipv6_test.go

@@ -0,0 +1,47 @@
+package bridge
+
+import (
+	"bytes"
+	"fmt"
+	"io/ioutil"
+	"testing"
+
+	"github.com/docker/libnetwork"
+	"github.com/vishvananda/netlink"
+)
+
+func TestSetupIPv6(t *testing.T) {
+	defer libnetwork.SetupTestNetNS(t)()
+
+	br := setupTestInterface(t)
+	if err := SetupBridgeIPv6(br); err != nil {
+		t.Fatalf("Failed to setup bridge IPv6: %v", err)
+	}
+
+	procSetting, err := ioutil.ReadFile(fmt.Sprintf("/proc/sys/net/ipv6/conf/%s/disable_ipv6", br.Config.BridgeName))
+	if err != nil {
+		t.Fatalf("Failed to read disable_ipv6 kernel setting: %v", err)
+	}
+
+	if expected := []byte("0\n"); bytes.Compare(expected, procSetting) != 0 {
+		t.Fatalf("Invalid kernel setting disable_ipv6: expected %q, got %q", string(expected), string(procSetting))
+	}
+
+	addrsv6, err := netlink.AddrList(br.Link, netlink.FAMILY_V6)
+	if err != nil {
+		t.Fatalf("Failed to list device IPv6 addresses: %v", err)
+	}
+
+	var found bool
+	for _, addr := range addrsv6 {
+		if BridgeIPv6Str == addr.IPNet.String() {
+			found = true
+			break
+		}
+	}
+
+	if !found {
+		t.Fatalf("Bridge device does not have requested IPv6 address %v", BridgeIPv6Str)
+	}
+
+}