Browse Source

Fix logic when enabling buildkit

Signed-off-by: Tibor Vass <tibor@docker.com>
Tibor Vass 6 years ago
parent
commit
c973cde760
2 changed files with 2 additions and 1 deletions
  1. 1 1
      api/server/router/build/build_routes.go
  2. 1 0
      daemon/config/config.go

+ 1 - 1
api/server/router/build/build_routes.go

@@ -231,7 +231,7 @@ func (br *buildRouter) postBuild(ctx context.Context, w http.ResponseWriter, r *
 	}
 	}
 
 
 	// check if the builder feature has been enabled from daemon as well.
 	// check if the builder feature has been enabled from daemon as well.
-	if buildOptions.Version == types.BuilderBuildKit && br.builderVersion != types.BuilderBuildKit {
+	if buildOptions.Version == types.BuilderBuildKit && br.builderVersion != "" && br.builderVersion != types.BuilderBuildKit {
 		return errdefs.InvalidParameter(errors.New("buildkit is not enabled on daemon"))
 		return errdefs.InvalidParameter(errors.New("buildkit is not enabled on daemon"))
 	}
 	}
 
 

+ 1 - 0
daemon/config/config.go

@@ -54,6 +54,7 @@ var flatOptions = map[string]bool{
 	"log-opts":           true,
 	"log-opts":           true,
 	"runtimes":           true,
 	"runtimes":           true,
 	"default-ulimits":    true,
 	"default-ulimits":    true,
+	"features":           true,
 }
 }
 
 
 // skipValidateOptions contains configuration keys
 // skipValidateOptions contains configuration keys