Forráskód Böngészése

Merge pull request #39360 from emosbaugh/logging-rate-limiter-bucket-fix

Fix rate limiting for logger, increase refill rate
Sebastiaan van Stijn 6 éve
szülő
commit
c2deb9f97f
1 módosított fájl, 3 hozzáadás és 1 törlés
  1. 3 1
      daemon/cluster/executor/container/controller.go

+ 3 - 1
daemon/cluster/executor/container/controller.go

@@ -508,7 +508,9 @@ func (r *controller) Logs(ctx context.Context, publisher exec.LogPublisher, opti
 	var (
 		// use a rate limiter to keep things under control but also provides some
 		// ability coalesce messages.
-		limiter = rate.NewLimiter(rate.Every(time.Second), 10<<20) // 10 MB/s
+		// this will implement a "token bucket" of size 10 MB, initially full and refilled
+		// at rate 10 MB tokens per second.
+		limiter = rate.NewLimiter(10<<20, 10<<20) // 10 MB/s
 		msgctx  = api.LogContext{
 			NodeID:    r.task.NodeID,
 			ServiceID: r.task.ServiceID,