소스 검색

Fix incorrect assumption in TestAPISwarmRaftQuorum

This test shuts down two out of three managers and then asserts that the
swarm has a leader. A swarm that lost quorum won't necessarily have a
leader, and in this case only has one because the old leader is still
around. Soon SwarmKit will be changed so the leader gives up leadership
when quorum is lost. This will avoid confusing situations, like
read-only APIs succeeding, while ones that write to Raft hang.

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
Aaron Lehmann 8 년 전
부모
커밋
c27603238c
1개의 변경된 파일0개의 추가작업 그리고 3개의 파일을 삭제
  1. 0 3
      integration-cli/docker_api_swarm_test.go

+ 0 - 3
integration-cli/docker_api_swarm_test.go

@@ -350,9 +350,6 @@ func (s *DockerSwarmSuite) TestAPISwarmRaftQuorum(c *check.C) {
 
 
 	d3.Stop(c)
 	d3.Stop(c)
 
 
-	// make sure there is a leader
-	waitAndAssert(c, defaultReconciliationTimeout, d1.CheckLeader, checker.IsNil)
-
 	var service swarm.Service
 	var service swarm.Service
 	simpleTestService(&service)
 	simpleTestService(&service)
 	service.Spec.Name = "top2"
 	service.Spec.Name = "top2"