Browse Source

Merge pull request #23577 from anusha-ragunathan/strings_conversion

Avoid back and forth conversion between strings and bytes.
Alexander Morozov 9 years ago
parent
commit
c18e036d36
1 changed files with 8 additions and 9 deletions
  1. 8 9
      cli/error.go

+ 8 - 9
cli/error.go

@@ -1,21 +1,20 @@
 package cli
 package cli
 
 
-import "bytes"
+import "strings"
 
 
 // Errors is a list of errors.
 // Errors is a list of errors.
 // Useful in a loop if you don't want to return the error right away and you want to display after the loop,
 // Useful in a loop if you don't want to return the error right away and you want to display after the loop,
 // all the errors that happened during the loop.
 // all the errors that happened during the loop.
 type Errors []error
 type Errors []error
 
 
-func (errs Errors) Error() string {
-	if len(errs) < 1 {
+func (errList Errors) Error() string {
+	if len(errList) < 1 {
 		return ""
 		return ""
 	}
 	}
-	var buf bytes.Buffer
-	buf.WriteString(errs[0].Error())
-	for _, err := range errs[1:] {
-		buf.WriteString(", ")
-		buf.WriteString(err.Error())
+
+	out := make([]string, len(errList))
+	for i := range errList {
+		out[i] = errList[i].Error()
 	}
 	}
-	return buf.String()
+	return strings.Join(out, ", ")
 }
 }