Explorar el Código

Merge pull request #26211 from aaronlehmann/no-advertise-addr-detection-on-join

cluster: Do not autodetect advertise address on join
Tõnis Tiigi hace 8 años
padre
commit
beba6ea311
Se han modificado 1 ficheros con 7 adiciones y 5 borrados
  1. 7 5
      daemon/cluster/cluster.go

+ 7 - 5
daemon/cluster/cluster.go

@@ -467,11 +467,13 @@ func (c *Cluster) Join(req types.JoinRequest) error {
 	}
 
 	var advertiseAddr string
-	advertiseHost, advertisePort, err := c.resolveAdvertiseAddr(req.AdvertiseAddr, listenPort)
-	// For joining, we don't need to provide an advertise address,
-	// since the remote side can detect it.
-	if err == nil {
-		advertiseAddr = net.JoinHostPort(advertiseHost, advertisePort)
+	if req.AdvertiseAddr != "" {
+		advertiseHost, advertisePort, err := c.resolveAdvertiseAddr(req.AdvertiseAddr, listenPort)
+		// For joining, we don't need to provide an advertise address,
+		// since the remote side can detect it.
+		if err == nil {
+			advertiseAddr = net.JoinHostPort(advertiseHost, advertisePort)
+		}
 	}
 
 	// todo: check current state existing