0ct0pu5/moby
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge pull request #46344 from thaJeztah/libnetwork_drivers_remote_cleanup_tests

Browse source 
libnetwork/drivers/remote: tests: cleanup dead code, and return concrete types
This commit is contained in:
Sebastiaan van Stijn 2023-08-29 11:34:00 +02:00 • committed by GitHub
commit bea39a49bc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
libnetwork/drivers/remote/driver.go
View file

@ -169,8 +169,7 @@ func (d *driver) CreateNetwork(id string, options map[string]interface{}, nInfo
}
func (d *driver) DeleteNetwork(nid string) error {
delete := &api.DeleteNetworkRequest{NetworkID: nid}
return d.call("DeleteNetwork", delete, &api.DeleteNetworkResponse{})
return d.call("DeleteNetwork", &api.DeleteNetworkRequest{NetworkID: nid}, &api.DeleteNetworkResponse{})
}
func (d *driver) CreateEndpoint(nid, eid string, ifInfo driverapi.InterfaceInfo, epOptions map[string]interface{}) error {

6
libnetwork/drivers/remote/driver_test.go
View file

@ -95,10 +95,6 @@ type testEndpoint struct {
disableGatewayService bool
}
func (test *testEndpoint) Interface() driverapi.InterfaceInfo {
return test
}
func (test *testEndpoint) Address() *net.IPNet {
if test.address == "" {
return nil
@ -550,7 +546,7 @@ func TestMissingValues(t *testing.T) {
type rollbackEndpoint struct{}
func (r *rollbackEndpoint) Interface() driverapi.InterfaceInfo {
func (r *rollbackEndpoint) Interface() *rollbackEndpoint {
return r
}