|
@@ -13,6 +13,7 @@ import (
|
|
|
"github.com/dotcloud/docker/pkg/listenbuffer"
|
|
|
"github.com/dotcloud/docker/pkg/systemd"
|
|
|
"github.com/dotcloud/docker/pkg/user"
|
|
|
+ "github.com/dotcloud/docker/pkg/version"
|
|
|
"github.com/dotcloud/docker/utils"
|
|
|
"github.com/gorilla/mux"
|
|
|
"io"
|
|
@@ -32,7 +33,7 @@ var (
|
|
|
activationLock chan struct{}
|
|
|
)
|
|
|
|
|
|
-type HttpApiFunc func(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error
|
|
|
+type HttpApiFunc func(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error
|
|
|
|
|
|
func hijackServer(w http.ResponseWriter) (io.ReadCloser, io.Writer, error) {
|
|
|
conn, _, err := w.(http.Hijacker).Hijack()
|
|
@@ -113,7 +114,7 @@ func getBoolParam(value string) (bool, error) {
|
|
|
return ret, nil
|
|
|
}
|
|
|
|
|
|
-func postAuth(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
+func postAuth(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
var (
|
|
|
authConfig, err = ioutil.ReadAll(r.Body)
|
|
|
job = eng.Job("auth")
|
|
@@ -136,13 +137,13 @@ func postAuth(eng *engine.Engine, version float64, w http.ResponseWriter, r *htt
|
|
|
return nil
|
|
|
}
|
|
|
|
|
|
-func getVersion(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
+func getVersion(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
w.Header().Set("Content-Type", "application/json")
|
|
|
eng.ServeHTTP(w, r)
|
|
|
return nil
|
|
|
}
|
|
|
|
|
|
-func postContainersKill(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
+func postContainersKill(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
if vars == nil {
|
|
|
return fmt.Errorf("Missing parameter")
|
|
|
}
|
|
@@ -160,7 +161,7 @@ func postContainersKill(eng *engine.Engine, version float64, w http.ResponseWrit
|
|
|
return nil
|
|
|
}
|
|
|
|
|
|
-func getContainersExport(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
+func getContainersExport(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
if vars == nil {
|
|
|
return fmt.Errorf("Missing parameter")
|
|
|
}
|
|
@@ -172,7 +173,7 @@ func getContainersExport(eng *engine.Engine, version float64, w http.ResponseWri
|
|
|
return nil
|
|
|
}
|
|
|
|
|
|
-func getImagesJSON(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
+func getImagesJSON(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
if err := parseForm(r); err != nil {
|
|
|
return err
|
|
|
}
|
|
@@ -186,7 +187,7 @@ func getImagesJSON(eng *engine.Engine, version float64, w http.ResponseWriter, r
|
|
|
job.Setenv("filter", r.Form.Get("filter"))
|
|
|
job.Setenv("all", r.Form.Get("all"))
|
|
|
|
|
|
- if version >= 1.7 {
|
|
|
+ if version.GreaterThanOrEqualTo("1.7") {
|
|
|
streamJSON(job, w, false)
|
|
|
} else if outs, err = job.Stdout.AddListTable(); err != nil {
|
|
|
return err
|
|
@@ -196,7 +197,7 @@ func getImagesJSON(eng *engine.Engine, version float64, w http.ResponseWriter, r
|
|
|
return err
|
|
|
}
|
|
|
|
|
|
- if version < 1.7 && outs != nil { // Convert to legacy format
|
|
|
+ if version.LessThan("1.7") && outs != nil { // Convert to legacy format
|
|
|
outsLegacy := engine.NewTable("Created", 0)
|
|
|
for _, out := range outs.Data {
|
|
|
for _, repoTag := range out.GetList("RepoTags") {
|
|
@@ -219,8 +220,8 @@ func getImagesJSON(eng *engine.Engine, version float64, w http.ResponseWriter, r
|
|
|
return nil
|
|
|
}
|
|
|
|
|
|
-func getImagesViz(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
- if version > 1.6 {
|
|
|
+func getImagesViz(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
+ if version.GreaterThan("1.6") {
|
|
|
w.WriteHeader(http.StatusNotFound)
|
|
|
return fmt.Errorf("This is now implemented in the client.")
|
|
|
}
|
|
@@ -228,13 +229,13 @@ func getImagesViz(eng *engine.Engine, version float64, w http.ResponseWriter, r
|
|
|
return nil
|
|
|
}
|
|
|
|
|
|
-func getInfo(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
+func getInfo(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
w.Header().Set("Content-Type", "application/json")
|
|
|
eng.ServeHTTP(w, r)
|
|
|
return nil
|
|
|
}
|
|
|
|
|
|
-func getEvents(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
+func getEvents(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
if err := parseForm(r); err != nil {
|
|
|
return err
|
|
|
}
|
|
@@ -245,7 +246,7 @@ func getEvents(eng *engine.Engine, version float64, w http.ResponseWriter, r *ht
|
|
|
return job.Run()
|
|
|
}
|
|
|
|
|
|
-func getImagesHistory(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
+func getImagesHistory(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
if vars == nil {
|
|
|
return fmt.Errorf("Missing parameter")
|
|
|
}
|
|
@@ -259,7 +260,7 @@ func getImagesHistory(eng *engine.Engine, version float64, w http.ResponseWriter
|
|
|
return nil
|
|
|
}
|
|
|
|
|
|
-func getContainersChanges(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
+func getContainersChanges(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
if vars == nil {
|
|
|
return fmt.Errorf("Missing parameter")
|
|
|
}
|
|
@@ -269,8 +270,8 @@ func getContainersChanges(eng *engine.Engine, version float64, w http.ResponseWr
|
|
|
return job.Run()
|
|
|
}
|
|
|
|
|
|
-func getContainersTop(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
- if version < 1.4 {
|
|
|
+func getContainersTop(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
+ if version.LessThan("1.4") {
|
|
|
return fmt.Errorf("top was improved a lot since 1.3, Please upgrade your docker client.")
|
|
|
}
|
|
|
if vars == nil {
|
|
@@ -285,7 +286,7 @@ func getContainersTop(eng *engine.Engine, version float64, w http.ResponseWriter
|
|
|
return job.Run()
|
|
|
}
|
|
|
|
|
|
-func getContainersJSON(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
+func getContainersJSON(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
if err := parseForm(r); err != nil {
|
|
|
return err
|
|
|
}
|
|
@@ -301,7 +302,7 @@ func getContainersJSON(eng *engine.Engine, version float64, w http.ResponseWrite
|
|
|
job.Setenv("before", r.Form.Get("before"))
|
|
|
job.Setenv("limit", r.Form.Get("limit"))
|
|
|
|
|
|
- if version >= 1.5 {
|
|
|
+ if version.GreaterThanOrEqualTo("1.5") {
|
|
|
streamJSON(job, w, false)
|
|
|
} else if outs, err = job.Stdout.AddTable(); err != nil {
|
|
|
return err
|
|
@@ -309,7 +310,7 @@ func getContainersJSON(eng *engine.Engine, version float64, w http.ResponseWrite
|
|
|
if err = job.Run(); err != nil {
|
|
|
return err
|
|
|
}
|
|
|
- if version < 1.5 { // Convert to legacy format
|
|
|
+ if version.LessThan("1.5") { // Convert to legacy format
|
|
|
for _, out := range outs.Data {
|
|
|
ports := engine.NewTable("", 0)
|
|
|
ports.ReadListFrom([]byte(out.Get("Ports")))
|
|
@@ -323,7 +324,7 @@ func getContainersJSON(eng *engine.Engine, version float64, w http.ResponseWrite
|
|
|
return nil
|
|
|
}
|
|
|
|
|
|
-func postImagesTag(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
+func postImagesTag(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
if err := parseForm(r); err != nil {
|
|
|
return err
|
|
|
}
|
|
@@ -340,7 +341,7 @@ func postImagesTag(eng *engine.Engine, version float64, w http.ResponseWriter, r
|
|
|
return nil
|
|
|
}
|
|
|
|
|
|
-func postCommit(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
+func postCommit(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
if err := parseForm(r); err != nil {
|
|
|
return err
|
|
|
}
|
|
@@ -369,7 +370,7 @@ func postCommit(eng *engine.Engine, version float64, w http.ResponseWriter, r *h
|
|
|
}
|
|
|
|
|
|
// Creates an image from Pull or from Import
|
|
|
-func postImagesCreate(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
+func postImagesCreate(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
if err := parseForm(r); err != nil {
|
|
|
return err
|
|
|
}
|
|
@@ -389,9 +390,6 @@ func postImagesCreate(eng *engine.Engine, version float64, w http.ResponseWriter
|
|
|
authConfig = &auth.AuthConfig{}
|
|
|
}
|
|
|
}
|
|
|
- if version > 1.0 {
|
|
|
- w.Header().Set("Content-Type", "application/json")
|
|
|
- }
|
|
|
if image != "" { //pull
|
|
|
metaHeaders := map[string][]string{}
|
|
|
for k, v := range r.Header {
|
|
@@ -400,7 +398,7 @@ func postImagesCreate(eng *engine.Engine, version float64, w http.ResponseWriter
|
|
|
}
|
|
|
}
|
|
|
job = eng.Job("pull", r.Form.Get("fromImage"), tag)
|
|
|
- job.SetenvBool("parallel", version > 1.3)
|
|
|
+ job.SetenvBool("parallel", version.GreaterThan("1.3"))
|
|
|
job.SetenvJson("metaHeaders", metaHeaders)
|
|
|
job.SetenvJson("authConfig", authConfig)
|
|
|
} else { //import
|
|
@@ -408,7 +406,7 @@ func postImagesCreate(eng *engine.Engine, version float64, w http.ResponseWriter
|
|
|
job.Stdin.Add(r.Body)
|
|
|
}
|
|
|
|
|
|
- if version > 1.0 {
|
|
|
+ if version.GreaterThan("1.0") {
|
|
|
job.SetenvBool("json", true)
|
|
|
streamJSON(job, w, true)
|
|
|
} else {
|
|
@@ -418,14 +416,14 @@ func postImagesCreate(eng *engine.Engine, version float64, w http.ResponseWriter
|
|
|
if !job.Stdout.Used() {
|
|
|
return err
|
|
|
}
|
|
|
- sf := utils.NewStreamFormatter(version > 1.0)
|
|
|
+ sf := utils.NewStreamFormatter(version.GreaterThan("1.0"))
|
|
|
w.Write(sf.FormatError(err))
|
|
|
}
|
|
|
|
|
|
return nil
|
|
|
}
|
|
|
|
|
|
-func getImagesSearch(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
+func getImagesSearch(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
if err := parseForm(r); err != nil {
|
|
|
return err
|
|
|
}
|
|
@@ -457,19 +455,15 @@ func getImagesSearch(eng *engine.Engine, version float64, w http.ResponseWriter,
|
|
|
return job.Run()
|
|
|
}
|
|
|
|
|
|
-func postImagesInsert(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
+func postImagesInsert(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
if err := parseForm(r); err != nil {
|
|
|
return err
|
|
|
}
|
|
|
if vars == nil {
|
|
|
return fmt.Errorf("Missing parameter")
|
|
|
}
|
|
|
- if version > 1.0 {
|
|
|
- w.Header().Set("Content-Type", "application/json")
|
|
|
- }
|
|
|
-
|
|
|
job := eng.Job("insert", vars["name"], r.Form.Get("url"), r.Form.Get("path"))
|
|
|
- if version > 1.0 {
|
|
|
+ if version.GreaterThan("1.0") {
|
|
|
job.SetenvBool("json", true)
|
|
|
streamJSON(job, w, false)
|
|
|
} else {
|
|
@@ -479,14 +473,14 @@ func postImagesInsert(eng *engine.Engine, version float64, w http.ResponseWriter
|
|
|
if !job.Stdout.Used() {
|
|
|
return err
|
|
|
}
|
|
|
- sf := utils.NewStreamFormatter(version > 1.0)
|
|
|
+ sf := utils.NewStreamFormatter(version.GreaterThan("1.0"))
|
|
|
w.Write(sf.FormatError(err))
|
|
|
}
|
|
|
|
|
|
return nil
|
|
|
}
|
|
|
|
|
|
-func postImagesPush(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
+func postImagesPush(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
if vars == nil {
|
|
|
return fmt.Errorf("Missing parameter")
|
|
|
}
|
|
@@ -517,13 +511,10 @@ func postImagesPush(eng *engine.Engine, version float64, w http.ResponseWriter,
|
|
|
}
|
|
|
}
|
|
|
|
|
|
- if version > 1.0 {
|
|
|
- w.Header().Set("Content-Type", "application/json")
|
|
|
- }
|
|
|
job := eng.Job("push", vars["name"])
|
|
|
job.SetenvJson("metaHeaders", metaHeaders)
|
|
|
job.SetenvJson("authConfig", authConfig)
|
|
|
- if version > 1.0 {
|
|
|
+ if version.GreaterThan("1.0") {
|
|
|
job.SetenvBool("json", true)
|
|
|
streamJSON(job, w, true)
|
|
|
} else {
|
|
@@ -534,17 +525,17 @@ func postImagesPush(eng *engine.Engine, version float64, w http.ResponseWriter,
|
|
|
if !job.Stdout.Used() {
|
|
|
return err
|
|
|
}
|
|
|
- sf := utils.NewStreamFormatter(version > 1.0)
|
|
|
+ sf := utils.NewStreamFormatter(version.GreaterThan("1.0"))
|
|
|
w.Write(sf.FormatError(err))
|
|
|
}
|
|
|
return nil
|
|
|
}
|
|
|
|
|
|
-func getImagesGet(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
+func getImagesGet(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
if vars == nil {
|
|
|
return fmt.Errorf("Missing parameter")
|
|
|
}
|
|
|
- if version > 1.0 {
|
|
|
+ if version.GreaterThan("1.0") {
|
|
|
w.Header().Set("Content-Type", "application/x-tar")
|
|
|
}
|
|
|
job := eng.Job("image_export", vars["name"])
|
|
@@ -552,13 +543,13 @@ func getImagesGet(eng *engine.Engine, version float64, w http.ResponseWriter, r
|
|
|
return job.Run()
|
|
|
}
|
|
|
|
|
|
-func postImagesLoad(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
+func postImagesLoad(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
job := eng.Job("load")
|
|
|
job.Stdin.Add(r.Body)
|
|
|
return job.Run()
|
|
|
}
|
|
|
|
|
|
-func postContainersCreate(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
+func postContainersCreate(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
if err := parseForm(r); err != nil {
|
|
|
return nil
|
|
|
}
|
|
@@ -589,7 +580,7 @@ func postContainersCreate(eng *engine.Engine, version float64, w http.ResponseWr
|
|
|
return writeJSON(w, http.StatusCreated, out)
|
|
|
}
|
|
|
|
|
|
-func postContainersRestart(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
+func postContainersRestart(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
if err := parseForm(r); err != nil {
|
|
|
return err
|
|
|
}
|
|
@@ -605,7 +596,7 @@ func postContainersRestart(eng *engine.Engine, version float64, w http.ResponseW
|
|
|
return nil
|
|
|
}
|
|
|
|
|
|
-func deleteContainers(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
+func deleteContainers(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
if err := parseForm(r); err != nil {
|
|
|
return err
|
|
|
}
|
|
@@ -622,7 +613,7 @@ func deleteContainers(eng *engine.Engine, version float64, w http.ResponseWriter
|
|
|
return nil
|
|
|
}
|
|
|
|
|
|
-func deleteImages(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
+func deleteImages(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
if err := parseForm(r); err != nil {
|
|
|
return err
|
|
|
}
|
|
@@ -631,12 +622,12 @@ func deleteImages(eng *engine.Engine, version float64, w http.ResponseWriter, r
|
|
|
}
|
|
|
var job = eng.Job("image_delete", vars["name"])
|
|
|
streamJSON(job, w, false)
|
|
|
- job.SetenvBool("autoPrune", version > 1.1)
|
|
|
+ job.Setenv("force", r.Form.Get("force"))
|
|
|
|
|
|
return job.Run()
|
|
|
}
|
|
|
|
|
|
-func postContainersStart(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
+func postContainersStart(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
if vars == nil {
|
|
|
return fmt.Errorf("Missing parameter")
|
|
|
}
|
|
@@ -657,7 +648,7 @@ func postContainersStart(eng *engine.Engine, version float64, w http.ResponseWri
|
|
|
return nil
|
|
|
}
|
|
|
|
|
|
-func postContainersStop(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
+func postContainersStop(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
if err := parseForm(r); err != nil {
|
|
|
return err
|
|
|
}
|
|
@@ -673,7 +664,7 @@ func postContainersStop(eng *engine.Engine, version float64, w http.ResponseWrit
|
|
|
return nil
|
|
|
}
|
|
|
|
|
|
-func postContainersWait(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
+func postContainersWait(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
if vars == nil {
|
|
|
return fmt.Errorf("Missing parameter")
|
|
|
}
|
|
@@ -695,7 +686,7 @@ func postContainersWait(eng *engine.Engine, version float64, w http.ResponseWrit
|
|
|
return writeJSON(w, http.StatusOK, env)
|
|
|
}
|
|
|
|
|
|
-func postContainersResize(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
+func postContainersResize(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
if err := parseForm(r); err != nil {
|
|
|
return err
|
|
|
}
|
|
@@ -708,7 +699,7 @@ func postContainersResize(eng *engine.Engine, version float64, w http.ResponseWr
|
|
|
return nil
|
|
|
}
|
|
|
|
|
|
-func postContainersAttach(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
+func postContainersAttach(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
if err := parseForm(r); err != nil {
|
|
|
return err
|
|
|
}
|
|
@@ -750,7 +741,7 @@ func postContainersAttach(eng *engine.Engine, version float64, w http.ResponseWr
|
|
|
|
|
|
fmt.Fprintf(outStream, "HTTP/1.1 200 OK\r\nContent-Type: application/vnd.docker.raw-stream\r\n\r\n")
|
|
|
|
|
|
- if c.GetSubEnv("Config") != nil && !c.GetSubEnv("Config").GetBool("Tty") && version >= 1.6 {
|
|
|
+ if c.GetSubEnv("Config") != nil && !c.GetSubEnv("Config").GetBool("Tty") && version.GreaterThanOrEqualTo("1.6") {
|
|
|
errStream = utils.NewStdWriter(outStream, utils.Stderr)
|
|
|
outStream = utils.NewStdWriter(outStream, utils.Stdout)
|
|
|
} else {
|
|
@@ -773,7 +764,7 @@ func postContainersAttach(eng *engine.Engine, version float64, w http.ResponseWr
|
|
|
return nil
|
|
|
}
|
|
|
|
|
|
-func wsContainersAttach(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
+func wsContainersAttach(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
if err := parseForm(r); err != nil {
|
|
|
return err
|
|
|
}
|
|
@@ -805,7 +796,7 @@ func wsContainersAttach(eng *engine.Engine, version float64, w http.ResponseWrit
|
|
|
return nil
|
|
|
}
|
|
|
|
|
|
-func getContainersByName(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
+func getContainersByName(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
if vars == nil {
|
|
|
return fmt.Errorf("Missing parameter")
|
|
|
}
|
|
@@ -815,7 +806,7 @@ func getContainersByName(eng *engine.Engine, version float64, w http.ResponseWri
|
|
|
return job.Run()
|
|
|
}
|
|
|
|
|
|
-func getImagesByName(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
+func getImagesByName(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
if vars == nil {
|
|
|
return fmt.Errorf("Missing parameter")
|
|
|
}
|
|
@@ -825,8 +816,8 @@ func getImagesByName(eng *engine.Engine, version float64, w http.ResponseWriter,
|
|
|
return job.Run()
|
|
|
}
|
|
|
|
|
|
-func postBuild(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
- if version < 1.3 {
|
|
|
+func postBuild(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
+ if version.LessThan("1.3") {
|
|
|
return fmt.Errorf("Multipart upload for build is no longer supported. Please upgrade your docker client.")
|
|
|
}
|
|
|
var (
|
|
@@ -841,7 +832,7 @@ func postBuild(eng *engine.Engine, version float64, w http.ResponseWriter, r *ht
|
|
|
// Both headers will be parsed and sent along to the daemon, but if a non-empty
|
|
|
// ConfigFile is present, any value provided as an AuthConfig directly will
|
|
|
// be overridden. See BuildFile::CmdFrom for details.
|
|
|
- if version < 1.9 && authEncoded != "" {
|
|
|
+ if version.LessThan("1.9") && authEncoded != "" {
|
|
|
authJson := base64.NewDecoder(base64.URLEncoding, strings.NewReader(authEncoded))
|
|
|
if err := json.NewDecoder(authJson).Decode(authConfig); err != nil {
|
|
|
// for a pull it is not an error if no auth was given
|
|
@@ -859,7 +850,7 @@ func postBuild(eng *engine.Engine, version float64, w http.ResponseWriter, r *ht
|
|
|
}
|
|
|
}
|
|
|
|
|
|
- if version >= 1.8 {
|
|
|
+ if version.GreaterThanOrEqualTo("1.8") {
|
|
|
job.SetenvBool("json", true)
|
|
|
streamJSON(job, w, true)
|
|
|
} else {
|
|
@@ -878,13 +869,13 @@ func postBuild(eng *engine.Engine, version float64, w http.ResponseWriter, r *ht
|
|
|
if !job.Stdout.Used() {
|
|
|
return err
|
|
|
}
|
|
|
- sf := utils.NewStreamFormatter(version >= 1.8)
|
|
|
+ sf := utils.NewStreamFormatter(version.GreaterThanOrEqualTo("1.8"))
|
|
|
w.Write(sf.FormatError(err))
|
|
|
}
|
|
|
return nil
|
|
|
}
|
|
|
|
|
|
-func postContainersCopy(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
+func postContainersCopy(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
if vars == nil {
|
|
|
return fmt.Errorf("Missing parameter")
|
|
|
}
|
|
@@ -917,7 +908,7 @@ func postContainersCopy(eng *engine.Engine, version float64, w http.ResponseWrit
|
|
|
return nil
|
|
|
}
|
|
|
|
|
|
-func optionsHandler(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
+func optionsHandler(eng *engine.Engine, version version.Version, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
|
w.WriteHeader(http.StatusOK)
|
|
|
return nil
|
|
|
}
|
|
@@ -927,7 +918,7 @@ func writeCorsHeaders(w http.ResponseWriter, r *http.Request) {
|
|
|
w.Header().Add("Access-Control-Allow-Methods", "GET, POST, DELETE, PUT, OPTIONS")
|
|
|
}
|
|
|
|
|
|
-func makeHttpHandler(eng *engine.Engine, logging bool, localMethod string, localRoute string, handlerFunc HttpApiFunc, enableCors bool, dockerVersion string) http.HandlerFunc {
|
|
|
+func makeHttpHandler(eng *engine.Engine, logging bool, localMethod string, localRoute string, handlerFunc HttpApiFunc, enableCors bool, dockerVersion version.Version) http.HandlerFunc {
|
|
|
return func(w http.ResponseWriter, r *http.Request) {
|
|
|
// log the request
|
|
|
utils.Debugf("Calling %s %s", localMethod, localRoute)
|
|
@@ -938,20 +929,20 @@ func makeHttpHandler(eng *engine.Engine, logging bool, localMethod string, local
|
|
|
|
|
|
if strings.Contains(r.Header.Get("User-Agent"), "Docker-Client/") {
|
|
|
userAgent := strings.Split(r.Header.Get("User-Agent"), "/")
|
|
|
- if len(userAgent) == 2 && userAgent[1] != dockerVersion {
|
|
|
+ if len(userAgent) == 2 && !dockerVersion.Equal(userAgent[1]) {
|
|
|
utils.Debugf("Warning: client and server don't have the same version (client: %s, server: %s)", userAgent[1], dockerVersion)
|
|
|
}
|
|
|
}
|
|
|
- version, err := strconv.ParseFloat(mux.Vars(r)["version"], 64)
|
|
|
- if err != nil {
|
|
|
+ version := version.Version(mux.Vars(r)["version"])
|
|
|
+ if version == "" {
|
|
|
version = APIVERSION
|
|
|
}
|
|
|
if enableCors {
|
|
|
writeCorsHeaders(w, r)
|
|
|
}
|
|
|
|
|
|
- if version == 0 || version > APIVERSION {
|
|
|
- http.Error(w, fmt.Errorf("client and server don't have same version (client : %g, server: %g)", version, APIVERSION).Error(), http.StatusNotFound)
|
|
|
+ if version.GreaterThan(APIVERSION) {
|
|
|
+ http.Error(w, fmt.Errorf("client and server don't have same version (client : %s, server: %s)", version, APIVERSION).Error(), http.StatusNotFound)
|
|
|
return
|
|
|
}
|
|
|
|
|
@@ -1049,7 +1040,7 @@ func createRouter(eng *engine.Engine, logging, enableCors bool, dockerVersion st
|
|
|
localMethod := method
|
|
|
|
|
|
// build the handler function
|
|
|
- f := makeHttpHandler(eng, logging, localMethod, localRoute, localFct, enableCors, dockerVersion)
|
|
|
+ f := makeHttpHandler(eng, logging, localMethod, localRoute, localFct, enableCors, version.Version(dockerVersion))
|
|
|
|
|
|
// add the new route
|
|
|
if localRoute == "" {
|
|
@@ -1067,13 +1058,13 @@ func createRouter(eng *engine.Engine, logging, enableCors bool, dockerVersion st
|
|
|
// ServeRequest processes a single http request to the docker remote api.
|
|
|
// FIXME: refactor this to be part of Server and not require re-creating a new
|
|
|
// router each time. This requires first moving ListenAndServe into Server.
|
|
|
-func ServeRequest(eng *engine.Engine, apiversion float64, w http.ResponseWriter, req *http.Request) error {
|
|
|
+func ServeRequest(eng *engine.Engine, apiversion version.Version, w http.ResponseWriter, req *http.Request) error {
|
|
|
router, err := createRouter(eng, false, true, "")
|
|
|
if err != nil {
|
|
|
return err
|
|
|
}
|
|
|
// Insert APIVERSION into the request as a convenience
|
|
|
- req.URL.Path = fmt.Sprintf("/v%g%s", apiversion, req.URL.Path)
|
|
|
+ req.URL.Path = fmt.Sprintf("/v%s%s", apiversion, req.URL.Path)
|
|
|
router.ServeHTTP(w, req)
|
|
|
return nil
|
|
|
}
|