瀏覽代碼

Fix flaky unit test

Fix flaky test `TestHTTPTimeout` caused by precision problem.

Signed-off-by: Zhang Wei <zhangwei555@huawei.com>
Zhang Wei 8 年之前
父節點
當前提交
bc5768733d
共有 1 個文件被更改,包括 2 次插入2 次删除
  1. 2 2
      pkg/plugins/client_test.go

+ 2 - 2
pkg/plugins/client_test.go

@@ -47,14 +47,14 @@ func testHTTPTimeout(t *testing.T, timeout, epsilon time.Duration) {
 		t.Fatalf("The request should be canceled %v", err)
 	}
 	elapsed := time.Now().Sub(begin)
-	if elapsed < timeout || elapsed > timeout+epsilon {
+	if elapsed < timeout-epsilon || elapsed > timeout+epsilon {
 		t.Fatalf("elapsed time: got %v, expected %v (epsilon=%v)",
 			elapsed, timeout, epsilon)
 	}
 }
 
 func TestHTTPTimeout(t *testing.T) {
-	testHTTPTimeout(t, 5*time.Second, 1*time.Second)
+	testHTTPTimeout(t, 5*time.Second, 500*time.Millisecond)
 }
 
 func TestFailedConnection(t *testing.T) {