From bb53ea71cb2b6cc2008b5686ac8c12d0a13f9ca5 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Sun, 25 Aug 2019 15:57:22 +0200 Subject: [PATCH] hack/make.sh remove "latest" symlink This symlink was added in d42753485b71f5f26b682a187d1963ef138cd0ab, to allow finding the path to the latest built binary, because at the time, those paths were prefixed with the version or commit (e.g. `bundles/1.5.0-dev`). Commit bac2447964c8cdfcf35f928841d60310db997c76 removed the version-prefix in paths, but kept the old symlink for backward compatiblity. However, many things were moved since then (e.g. paths were renamed to `binary-daemon`, and various other changes). With the symlink pointing to the symlink's parent directory, following the symlink may result into an infinite recursion, which can happen if scripts using wildcards / globbing to find files. With this symlink no longer serving a real purpose, we can probably safely remove this symlink now. Signed-off-by: Sebastiaan van Stijn (cherry picked from commit dde1fd78c7c9a142a4099917198e69d88d34d088) Signed-off-by: Sebastiaan van Stijn --- hack/make.sh | 7 ------- 1 file changed, 7 deletions(-) diff --git a/hack/make.sh b/hack/make.sh index 2c7ca612f5..29e3912235 100755 --- a/hack/make.sh +++ b/hack/make.sh @@ -179,13 +179,6 @@ main() { fi mkdir -p bundles - # Windows and symlinks don't get along well - if [ "$(go env GOHOSTOS)" != 'windows' ]; then - rm -f bundles/latest - # preserve latest symlink for backward compatibility - ln -sf . bundles/latest - fi - if [ $# -lt 1 ]; then bundles=(${DEFAULT_BUNDLES[@]}) else