Browse Source

Move errcode handling for resize upper

It'll allow to separate daemon layer more cleanly later.

Signed-off-by: Alexander Morozov <lk4d4@docker.com>
Alexander Morozov 9 years ago
parent
commit
bb0e7eb196
2 changed files with 6 additions and 3 deletions
  1. 0 3
      daemon/container.go
  2. 6 0
      daemon/resize.go

+ 0 - 3
daemon/container.go

@@ -244,9 +244,6 @@ func (container *Container) ExitOnNext() {
 // Resize changes the TTY of the process running inside the container
 // to the given height and width. The container must be running.
 func (container *Container) Resize(h, w int) error {
-	if !container.IsRunning() {
-		return derr.ErrorCodeNotRunning.WithArgs(container.ID)
-	}
 	if err := container.command.ProcessConfig.Terminal.Resize(h, w); err != nil {
 		return err
 	}

+ 6 - 0
daemon/resize.go

@@ -1,5 +1,7 @@
 package daemon
 
+import derr "github.com/docker/docker/errors"
+
 // ContainerResize changes the size of the TTY of the process running
 // in the container with the given name to the given height and width.
 func (daemon *Daemon) ContainerResize(name string, height, width int) error {
@@ -8,6 +10,10 @@ func (daemon *Daemon) ContainerResize(name string, height, width int) error {
 		return err
 	}
 
+	if !container.IsRunning() {
+		return derr.ErrorCodeNotRunning.WithArgs(container.ID)
+	}
+
 	if err = container.Resize(height, width); err == nil {
 		daemon.LogContainerEvent(container, "resize")
 	}