Merge pull request #19420 from clnperez/close-notify-fix

Move closeNotify to fix panic with newer golang
2016-01-18 20:08:25 -05:00 · 2016-01-18 20:08:25 -05:00 · b6be645197
commit b6be645197
parent 637f49b5af 2df5dafdaf
1 changed files with 2 additions and 1 deletions
--- a/api/server/router/build/build_routes.go
+++ b/api/server/router/build/build_routes.go
@ -227,10 +227,11 @@ func (br *buildRouter) postBuild(ctx context.Context, w http.ResponseWriter, r *
 	if closeNotifier, ok := w.(http.CloseNotifier); ok {
 		finished := make(chan struct{})
 		defer close(finished)
+		clientGone := closeNotifier.CloseNotify()
 		go func() {
 			select {
 			case <-finished:
-			case <-closeNotifier.CloseNotify():
+			case <-clientGone:
 				logrus.Infof("Client disconnected, cancelling job: build")
 				b.Cancel()
 			}