瀏覽代碼

Add the file close operation before function return to advoid resource leaking

Signed-off-by: Mabin <bin.ma@huawei.com>
Mabin 10 年之前
父節點
當前提交
b5eeab6e06
共有 1 個文件被更改,包括 2 次插入1 次删除
  1. 2 1
      daemon/graphdriver/devmapper/mount.go

+ 2 - 1
daemon/graphdriver/devmapper/mount.go

@@ -55,13 +55,14 @@ func ProbeFsType(device string) (string, error) {
 	if err != nil {
 	if err != nil {
 		return "", err
 		return "", err
 	}
 	}
+	defer file.Close()
 
 
 	buffer := make([]byte, maxLen)
 	buffer := make([]byte, maxLen)
 	l, err := file.Read(buffer)
 	l, err := file.Read(buffer)
 	if err != nil {
 	if err != nil {
 		return "", err
 		return "", err
 	}
 	}
-	file.Close()
+
 	if uint64(l) != maxLen {
 	if uint64(l) != maxLen {
 		return "", fmt.Errorf("unable to detect filesystem type of %s, short read", device)
 		return "", fmt.Errorf("unable to detect filesystem type of %s, short read", device)
 	}
 	}