Parcourir la source

chroot: remount everything as private in new mntns

If parent of the destination path is shared, this
path will be unmounted from the parent ns even if
the path itself is private.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Tonis Tiigi il y a 8 ans
Parent
commit
b511d1f0ca
1 fichiers modifiés avec 6 ajouts et 1 suppressions
  1. 6 1
      pkg/chrootarchive/chroot_linux.go

+ 6 - 1
pkg/chrootarchive/chroot_linux.go

@@ -26,7 +26,12 @@ func chroot(path string) (err error) {
 		return fmt.Errorf("Error creating mount namespace before pivot: %v", err)
 	}
 
-	if err := mount.MakeRPrivate(path); err != nil {
+	// make everything in new ns private
+	if err := mount.MakeRPrivate("/"); err != nil {
+		return err
+	}
+	// ensure path is a mountpoint
+	if err := mount.MakePrivate(path); err != nil {
 		return err
 	}