0ct0pu5/moby
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

libnetwork/datastore: don't access KVStore directly in tests

Browse source 
Test the datastore, not the KVStore backing it.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn 2023-07-25 14:38:17 +02:00
parent 65978e6982
commit b378669836
No known key found for this signature in database
GPG key ID: 76698F39D527CE8C
1 changed files with 5 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
libnetwork/datastore/datastore_test.go
View file

@ -38,11 +38,8 @@ func TestKVObjectFlatKey(t *testing.T) {
err := store.PutObjectAtomic(expected)
assert.Check(t, err)
data, err := store.KVStore().Get(Key(dummyKey, "1000"))
assert.Check(t, err)
var n dummyObject
err = json.Unmarshal(data.Value, &n)
n := dummyObject{ID: "1000"} // GetObject uses KVObject.Key() for cache lookup.
err = store.GetObject(Key(dummyKey, "1000"), &n)
assert.Check(t, err)
assert.Check(t, is.Equal(n.Name, expected.Name))
}
@ -62,20 +59,15 @@ func TestAtomicKVObjectFlatKey(t *testing.T) {
// Get the latest index and try PutObjectAtomic again for the same Key
// This must succeed as well
data, err := store.KVStore().Get(Key(expected.Key()...))
n := dummyObject{ID: "1111"} // GetObject uses KVObject.Key() for cache lookup.
err = store.GetObject(Key(expected.Key()...), &n)
assert.Check(t, err)
n := dummyObject{}
err = json.Unmarshal(data.Value, &n)
assert.Check(t, err)
n.ID = "1111"
n.SetIndex(data.LastIndex)
n.ReturnValue = true
err = store.PutObjectAtomic(&n)
assert.Check(t, err)
// Get the Object using GetObject, then set again.
newObj := dummyObject{}
newObj := dummyObject{ID: "1111"} // GetObject uses KVObject.Key() for cache lookup.
err = store.GetObject(Key(expected.Key()...), &newObj)
assert.Check(t, err)
assert.Check(t, newObj.Exists())