Browse Source

ineffectual assignment to isCanonical, delete it

Signed-off-by: yupengzte <yu.peng36@zte.com.cn>
yupengzte 8 years ago
parent
commit
b28c1eae01
1 changed files with 1 additions and 4 deletions
  1. 1 4
      client/service_create.go

+ 1 - 4
client/service_create.go

@@ -55,12 +55,9 @@ func (cli *Client) ServiceCreate(ctx context.Context, service swarm.ServiceSpec,
 // the image string if it didn't originally contain a digest. It assumes
 // that the image string is not an image ID
 func imageWithDigestString(image string, dgst digest.Digest) string {
-	isCanonical := false
 	ref, err := reference.ParseAnyReference(image)
 	if err == nil {
-		_, isCanonical = ref.(reference.Canonical)
-
-		if !isCanonical {
+		if _, isCanonical := ref.(reference.Canonical); !isCanonical {
 			namedRef, _ := ref.(reference.Named)
 			img, err := reference.WithDigest(namedRef, dgst)
 			if err == nil {