浏览代码

daemon/logger/fluentd: make error-handling less DRY

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sebastiaan van Stijn 3 年之前
父节点
当前提交
b161616202
共有 1 个文件被更改,包括 4 次插入5 次删除
  1. 4 5
      daemon/logger/fluentd/fluentd.go

+ 4 - 5
daemon/logger/fluentd/fluentd.go

@@ -172,7 +172,7 @@ func parseConfig(cfg map[string]string) (fluent.Config, error) {
 
 	loc, err := parseAddress(cfg[addressKey])
 	if err != nil {
-		return config, err
+		return config, errors.Wrapf(err, "invalid fluentd-address (%s)", cfg[addressKey])
 	}
 
 	bufferLimit := defaultBufferLimit
@@ -278,11 +278,10 @@ func parseAddress(address string) (*location, error) {
 	}
 
 	protocol := defaultProtocol
-	givenAddress := address
 	if urlutil.IsTransportURL(address) {
 		addr, err := url.Parse(address)
 		if err != nil {
-			return nil, errors.Wrapf(err, "invalid fluentd-address %s", givenAddress)
+			return nil, err
 		}
 		// unix and unixgram socket
 		if addr.Scheme == "unix" || addr.Scheme == "unixgram" {
@@ -301,7 +300,7 @@ func parseAddress(address string) (*location, error) {
 	host, port, err := net.SplitHostPort(address)
 	if err != nil {
 		if !strings.Contains(err.Error(), "missing port in address") {
-			return nil, errors.Wrapf(err, "invalid fluentd-address %s", givenAddress)
+			return nil, err
 		}
 		return &location{
 			protocol: protocol,
@@ -313,7 +312,7 @@ func parseAddress(address string) (*location, error) {
 
 	portnum, err := strconv.Atoi(port)
 	if err != nil {
-		return nil, errors.Wrapf(err, "invalid fluentd-address %s", givenAddress)
+		return nil, err
 	}
 	return &location{
 		protocol: protocol,