Merge pull request #23323 from tiborvass/debug-ci

Cleanup

distribution/push.go

@@ -88,7 +88,7 @@ func NewPusher(ref reference.Named, endpoint registry.APIEndpoint, repoInfo *reg
 	return nil, fmt.Errorf("unknown version %d for registry %s", endpoint.Version, endpoint.URL)
 }
 
-// Push initiates a push operation on the repository named localName.
+// Push initiates a push operation on ref.
 // ref is the specific variant of the image to be pushed.
 // If no tag is provided, all tags will be pushed.
 func Push(ctx context.Context, ref reference.Named, imagePushConfig *ImagePushConfig) error {

pkg/namesgenerator/names-generator_test.go

@@ -5,14 +5,6 @@ import (
 	"testing"
 )
 
-// Make sure the generated names are awesome
-func TestGenerateAwesomeNames(t *testing.T) {
-	name := GetRandomName(0)
-	if !isAwesome(name) {
-		t.Fatalf("Generated name '%s' is not awesome.", name)
-	}
-}
-
 func TestNameFormat(t *testing.T) {
 	name := GetRandomName(0)
 	if !strings.Contains(name, "_") {
@@ -33,13 +25,3 @@ func TestNameRetries(t *testing.T) {
 	}
 
 }
-
-// To be awesome, a container name must involve cool inventors, be easy to remember,
-// be at least mildly funny, and always be politically correct for enterprise adoption.
-func isAwesome(name string) bool {
-	coolInventorNames := true
-	easyToRemember := true
-	mildlyFunnyOnOccasion := true
-	politicallyCorrect := true
-	return coolInventorNames && easyToRemember && mildlyFunnyOnOccasion && politicallyCorrect
-}